~bzr-pqm/bzr/bzr.dev

4988.10.3 by John Arbash Meinel
Merge bzr.dev 5007, resolve conflict, update NEWS
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
369 by Martin Pool
- Split out log printing into new show_log function
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
369 by Martin Pool
- Split out log printing into new show_log function
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
369 by Martin Pool
- Split out log printing into new show_log function
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
369 by Martin Pool
- Split out log printing into new show_log function
16
375 by Martin Pool
- New command touching-revisions and function to trace
17
18
527 by Martin Pool
- refactor log command
19
"""Code to show logs of changes.
20
21
Various flavors of log can be produced:
22
23
* for one file, or the whole tree, and (not done yet) for
24
  files in a given directory
25
26
* in "verbose" mode with a description of what changed from one
27
  version to the next
28
29
* with file-ids and revision-ids shown
30
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
31
Logs are actually written out through an abstract LogFormatter
32
interface, which allows for different preferred formats.  Plugins can
33
register formats too.
34
35
Logs can be produced in either forward (oldest->newest) or reverse
36
(newest->oldest) order.
37
38
Logs can be filtered to show only revisions matching a particular
39
search string, or within a particular range of revisions.  The range
40
can be given as date/times, which are reduced to revisions before
41
calling in here.
42
43
In verbose mode we show a summary of what changed in each particular
44
revision.  Note that this is the delta for changes in that revision
2466.12.2 by Kent Gibson
shift log output with only merge revisions to the left margin
45
relative to its left-most parent, not the delta relative to the last
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
46
logged revision.  So for example if you ask for a verbose log of
47
changes touching hello.c you will get a list of those revisions also
48
listing other things that were changed in the same revision, but not
49
all the changes since the previous revision that touched hello.c.
527 by Martin Pool
- refactor log command
50
"""
51
2997.1.2 by Kent Gibson
Move all imports to top of log.py
52
import codecs
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
53
from cStringIO import StringIO
2997.1.2 by Kent Gibson
Move all imports to top of log.py
54
from itertools import (
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
55
    chain,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
56
    izip,
57
    )
1624.1.3 by Robert Collins
Convert log to use the new tsort.merge_sort routine.
58
import re
2997.1.2 by Kent Gibson
Move all imports to top of log.py
59
import sys
60
from warnings import (
61
    warn,
62
    )
1185.33.41 by Martin Pool
Fix regression of 'bzr log -v' - it wasn't showing changed files at all. (#4676)
63
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
64
from bzrlib.lazy_import import lazy_import
65
lazy_import(globals(), """
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
66
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
67
from bzrlib import (
4202.2.1 by Ian Clatworthy
get directory logging working again
68
    bzrdir,
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
69
    config,
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
70
    diff,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
71
    errors,
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
72
    foreign,
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
73
    repository as _mod_repository,
74
    revision as _mod_revision,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
75
    revisionspec,
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
76
    trace,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
77
    tsort,
78
    )
79
""")
80
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
81
from bzrlib import (
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
82
    registry,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
83
    )
84
from bzrlib.osutils import (
85
    format_date,
4379.4.1 by Ian Clatworthy
make log --long faster
86
    format_date_with_offset_in_original_timezone,
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
87
    get_terminal_encoding,
4183.6.4 by Martin Pool
Separate out re_compile_checked
88
    re_compile_checked,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
89
    terminal_width,
90
    )
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
91
from bzrlib.symbol_versioning import (
92
    deprecated_function,
93
    deprecated_in,
94
    )
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
95
375 by Martin Pool
- New command touching-revisions and function to trace
96
97
def find_touching_revisions(branch, file_id):
98
    """Yield a description of revisions which affect the file_id.
99
100
    Each returned element is (revno, revision_id, description)
101
102
    This is the list of revisions where the file is either added,
103
    modified, renamed or deleted.
104
105
    TODO: Perhaps some way to limit this to only particular revisions,
522 by Martin Pool
todo
106
    or to traverse a non-mainline set of revisions?
375 by Martin Pool
- New command touching-revisions and function to trace
107
    """
108
    last_ie = None
109
    last_path = None
110
    revno = 1
111
    for revision_id in branch.revision_history():
5035.3.1 by Jelmer Vernooij
Remove Repository.get_revision_inventory.
112
        this_inv = branch.repository.get_inventory(revision_id)
375 by Martin Pool
- New command touching-revisions and function to trace
113
        if file_id in this_inv:
114
            this_ie = this_inv[file_id]
115
            this_path = this_inv.id2path(file_id)
116
        else:
117
            this_ie = this_path = None
118
119
        # now we know how it was last time, and how it is in this revision.
120
        # are those two states effectively the same or not?
121
122
        if not this_ie and not last_ie:
123
            # not present in either
124
            pass
125
        elif this_ie and not last_ie:
126
            yield revno, revision_id, "added " + this_path
127
        elif not this_ie and last_ie:
128
            # deleted here
129
            yield revno, revision_id, "deleted " + last_path
130
        elif this_path != last_path:
131
            yield revno, revision_id, ("renamed %s => %s" % (last_path, this_path))
132
        elif (this_ie.text_size != last_ie.text_size
133
              or this_ie.text_sha1 != last_ie.text_sha1):
134
            yield revno, revision_id, "modified " + this_path
135
136
        last_ie = this_ie
137
        last_path = this_path
138
        revno += 1
139
140
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
141
def _enumerate_history(branch):
142
    rh = []
143
    revno = 1
144
    for rev_id in branch.revision_history():
145
        rh.append((revno, rev_id))
146
        revno += 1
147
    return rh
148
149
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
150
def show_log(branch,
151
             lf,
152
             specific_fileid=None,
153
             verbose=False,
154
             direction='reverse',
155
             start_revision=None,
156
             end_revision=None,
157
             search=None,
158
             limit=None,
159
             show_diff=False):
160
    """Write out human-readable log of commits to this branch.
161
162
    This function is being retained for backwards compatibility but
163
    should not be extended with new parameters. Use the new Logger class
164
    instead, eg. Logger(branch, rqst).show(lf), adding parameters to the
4205.1.1 by Ian Clatworthy
log multiple files and directories (Ian Clatworthy)
165
    make_log_request_dict function.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
166
167
    :param lf: The LogFormatter object showing the output.
168
169
    :param specific_fileid: If not None, list only the commits affecting the
170
        specified file, rather than all commits.
171
172
    :param verbose: If True show added/changed/deleted/renamed files.
173
174
    :param direction: 'reverse' (default) is latest to earliest; 'forward' is
175
        earliest to latest.
176
177
    :param start_revision: If not None, only show revisions >= start_revision
178
179
    :param end_revision: If not None, only show revisions <= end_revision
180
181
    :param search: If not None, only show revisions with matching commit
182
        messages
183
184
    :param limit: If set, shows only 'limit' revisions, all revisions are shown
185
        if None or 0.
186
187
    :param show_diff: If True, output a diff after each revision.
188
    """
189
    # Convert old-style parameters to new-style parameters
190
    if specific_fileid is not None:
191
        file_ids = [specific_fileid]
192
    else:
193
        file_ids = None
194
    if verbose:
195
        if file_ids:
196
            delta_type = 'partial'
197
        else:
198
            delta_type = 'full'
199
    else:
200
        delta_type = None
201
    if show_diff:
202
        if file_ids:
203
            diff_type = 'partial'
204
        else:
205
            diff_type = 'full'
206
    else:
207
        diff_type = None
208
209
    # Build the request and execute it
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
210
    rqst = make_log_request_dict(direction=direction, specific_fileids=file_ids,
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
211
        start_revision=start_revision, end_revision=end_revision,
212
        limit=limit, message_search=search,
213
        delta_type=delta_type, diff_type=diff_type)
214
    Logger(branch, rqst).show(lf)
215
216
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
217
# Note: This needs to be kept this in sync with the defaults in
218
# make_log_request_dict() below
219
_DEFAULT_REQUEST_PARAMS = {
220
    'direction': 'reverse',
221
    'levels': 1,
222
    'generate_tags': True,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
223
    'exclude_common_ancestry': False,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
224
    '_match_using_deltas': True,
225
    }
226
227
228
def make_log_request_dict(direction='reverse', specific_fileids=None,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
229
                          start_revision=None, end_revision=None, limit=None,
230
                          message_search=None, levels=1, generate_tags=True,
231
                          delta_type=None,
232
                          diff_type=None, _match_using_deltas=True,
233
                          exclude_common_ancestry=False,
234
                          ):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
235
    """Convenience function for making a logging request dictionary.
236
237
    Using this function may make code slightly safer by ensuring
238
    parameters have the correct names. It also provides a reference
239
    point for documenting the supported parameters.
240
241
    :param direction: 'reverse' (default) is latest to earliest;
242
      'forward' is earliest to latest.
243
244
    :param specific_fileids: If not None, only include revisions
245
      affecting the specified files, rather than all revisions.
246
247
    :param start_revision: If not None, only generate
248
      revisions >= start_revision
249
250
    :param end_revision: If not None, only generate
251
      revisions <= end_revision
252
253
    :param limit: If set, generate only 'limit' revisions, all revisions
254
      are shown if None or 0.
255
256
    :param message_search: If not None, only include revisions with
257
      matching commit messages
258
259
    :param levels: the number of levels of revisions to
260
      generate; 1 for just the mainline; 0 for all levels.
261
262
    :param generate_tags: If True, include tags for matched revisions.
263
264
    :param delta_type: Either 'full', 'partial' or None.
265
      'full' means generate the complete delta - adds/deletes/modifies/etc;
266
      'partial' means filter the delta using specific_fileids;
267
      None means do not generate any delta.
268
269
    :param diff_type: Either 'full', 'partial' or None.
270
      'full' means generate the complete diff - adds/deletes/modifies/etc;
271
      'partial' means filter the diff using specific_fileids;
272
      None means do not generate any diff.
273
274
    :param _match_using_deltas: a private parameter controlling the
275
      algorithm used for matching specific_fileids. This parameter
276
      may be removed in the future so bzrlib client code should NOT
277
      use it.
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
278
279
    :param exclude_common_ancestry: Whether -rX..Y should be interpreted as a
280
      range operator or as a graph difference.
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
281
    """
282
    return {
283
        'direction': direction,
284
        'specific_fileids': specific_fileids,
285
        'start_revision': start_revision,
286
        'end_revision': end_revision,
287
        'limit': limit,
288
        'message_search': message_search,
289
        'levels': levels,
290
        'generate_tags': generate_tags,
291
        'delta_type': delta_type,
292
        'diff_type': diff_type,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
293
        'exclude_common_ancestry': exclude_common_ancestry,
4202.2.1 by Ian Clatworthy
get directory logging working again
294
        # Add 'private' attributes for features that may be deprecated
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
295
        '_match_using_deltas': _match_using_deltas,
296
    }
297
298
299
def _apply_log_request_defaults(rqst):
300
    """Apply default values to a request dictionary."""
301
    result = _DEFAULT_REQUEST_PARAMS
302
    if rqst:
303
        result.update(rqst)
304
    return result
4202.2.1 by Ian Clatworthy
get directory logging working again
305
306
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
307
class LogGenerator(object):
308
    """A generator of log revisions."""
309
310
    def iter_log_revisions(self):
311
        """Iterate over LogRevision objects.
312
313
        :return: An iterator yielding LogRevision objects.
314
        """
315
        raise NotImplementedError(self.iter_log_revisions)
316
317
318
class Logger(object):
4955.5.3 by Vincent Ladeuil
Cleanup.
319
    """An object that generates, formats and displays a log."""
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
320
321
    def __init__(self, branch, rqst):
322
        """Create a Logger.
323
324
        :param branch: the branch to log
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
325
        :param rqst: A dictionary specifying the query parameters.
326
          See make_log_request_dict() for supported values.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
327
        """
328
        self.branch = branch
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
329
        self.rqst = _apply_log_request_defaults(rqst)
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
330
331
    def show(self, lf):
332
        """Display the log.
333
334
        :param lf: The LogFormatter object to send the output to.
335
        """
336
        if not isinstance(lf, LogFormatter):
337
            warn("not a LogFormatter instance: %r" % lf)
338
339
        self.branch.lock_read()
340
        try:
341
            if getattr(lf, 'begin_log', None):
342
                lf.begin_log()
343
            self._show_body(lf)
344
            if getattr(lf, 'end_log', None):
345
                lf.end_log()
346
        finally:
347
            self.branch.unlock()
348
349
    def _show_body(self, lf):
350
        """Show the main log output.
351
352
        Subclasses may wish to override this.
353
        """
354
        # Tweak the LogRequest based on what the LogFormatter can handle.
355
        # (There's no point generating stuff if the formatter can't display it.)
356
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
357
        rqst['levels'] = lf.get_levels()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
358
        if not getattr(lf, 'supports_tags', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
359
            rqst['generate_tags'] = False
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
360
        if not getattr(lf, 'supports_delta', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
361
            rqst['delta_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
362
        if not getattr(lf, 'supports_diff', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
363
            rqst['diff_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
364
365
        # Find and print the interesting revisions
366
        generator = self._generator_factory(self.branch, rqst)
367
        for lr in generator.iter_log_revisions():
368
            lf.log_revision(lr)
4208.2.1 by Ian Clatworthy
merge indicators in log --long
369
        lf.show_advice()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
370
371
    def _generator_factory(self, branch, rqst):
372
        """Make the LogGenerator object to use.
373
        
374
        Subclasses may wish to override this.
375
        """
376
        return _DefaultLogGenerator(branch, rqst)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
377
378
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
379
class _StartNotLinearAncestor(Exception):
380
    """Raised when a start revision is not found walking left-hand history."""
381
382
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
383
class _DefaultLogGenerator(LogGenerator):
384
    """The default generator of log revisions."""
4202.2.1 by Ian Clatworthy
get directory logging working again
385
386
    def __init__(self, branch, rqst):
387
        self.branch = branch
388
        self.rqst = rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
389
        if rqst.get('generate_tags') and branch.supports_tags():
4202.2.1 by Ian Clatworthy
get directory logging working again
390
            self.rev_tag_dict = branch.tags.get_reverse_tag_dict()
391
        else:
392
            self.rev_tag_dict = {}
393
394
    def iter_log_revisions(self):
395
        """Iterate over LogRevision objects.
396
397
        :return: An iterator yielding LogRevision objects.
398
        """
399
        rqst = self.rqst
4379.4.1 by Ian Clatworthy
make log --long faster
400
        levels = rqst.get('levels')
401
        limit = rqst.get('limit')
402
        diff_type = rqst.get('diff_type')
4202.2.1 by Ian Clatworthy
get directory logging working again
403
        log_count = 0
404
        revision_iterator = self._create_log_revision_iterator()
405
        for revs in revision_iterator:
406
            for (rev_id, revno, merge_depth), rev, delta in revs:
407
                # 0 levels means show everything; merge_depth counts from 0
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
408
                if levels != 0 and merge_depth >= levels:
4202.2.1 by Ian Clatworthy
get directory logging working again
409
                    continue
4379.4.1 by Ian Clatworthy
make log --long faster
410
                if diff_type is None:
411
                    diff = None
412
                else:
413
                    diff = self._format_diff(rev, rev_id, diff_type)
4202.2.1 by Ian Clatworthy
get directory logging working again
414
                yield LogRevision(rev, revno, merge_depth, delta,
415
                    self.rev_tag_dict.get(rev_id), diff)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
416
                if limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
417
                    log_count += 1
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
418
                    if log_count >= limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
419
                        return
420
4379.4.1 by Ian Clatworthy
make log --long faster
421
    def _format_diff(self, rev, rev_id, diff_type):
4202.2.1 by Ian Clatworthy
get directory logging working again
422
        repo = self.branch.repository
423
        if len(rev.parent_ids) == 0:
424
            ancestor_id = _mod_revision.NULL_REVISION
425
        else:
426
            ancestor_id = rev.parent_ids[0]
427
        tree_1 = repo.revision_tree(ancestor_id)
428
        tree_2 = repo.revision_tree(rev_id)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
429
        file_ids = self.rqst.get('specific_fileids')
4202.2.1 by Ian Clatworthy
get directory logging working again
430
        if diff_type == 'partial' and file_ids is not None:
431
            specific_files = [tree_2.id2path(id) for id in file_ids]
432
        else:
433
            specific_files = None
434
        s = StringIO()
435
        diff.show_diff_trees(tree_1, tree_2, s, specific_files, old_label='',
436
            new_label='')
437
        return s.getvalue()
438
439
    def _create_log_revision_iterator(self):
440
        """Create a revision iterator for log.
441
442
        :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
443
            delta).
444
        """
445
        self.start_rev_id, self.end_rev_id = _get_revision_limits(
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
446
            self.branch, self.rqst.get('start_revision'),
447
            self.rqst.get('end_revision'))
448
        if self.rqst.get('_match_using_deltas'):
4202.2.1 by Ian Clatworthy
get directory logging working again
449
            return self._log_revision_iterator_using_delta_matching()
450
        else:
451
            # We're using the per-file-graph algorithm. This scales really
452
            # well but only makes sense if there is a single file and it's
453
            # not a directory
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
454
            file_count = len(self.rqst.get('specific_fileids'))
4202.2.1 by Ian Clatworthy
get directory logging working again
455
            if file_count != 1:
456
                raise BzrError("illegal LogRequest: must match-using-deltas "
457
                    "when logging %d files" % file_count)
458
            return self._log_revision_iterator_using_per_file_graph()
459
460
    def _log_revision_iterator_using_delta_matching(self):
461
        # Get the base revisions, filtering by the revision range
462
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
463
        generate_merge_revisions = rqst.get('levels') != 1
464
        delayed_graph_generation = not rqst.get('specific_fileids') and (
465
                rqst.get('limit') or self.start_rev_id or self.end_rev_id)
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
466
        view_revisions = _calc_view_revisions(
467
            self.branch, self.start_rev_id, self.end_rev_id,
468
            rqst.get('direction'),
469
            generate_merge_revisions=generate_merge_revisions,
470
            delayed_graph_generation=delayed_graph_generation,
471
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
4202.2.1 by Ian Clatworthy
get directory logging working again
472
473
        # Apply the other filters
474
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
475
            rqst.get('delta_type'), rqst.get('message_search'),
476
            file_ids=rqst.get('specific_fileids'),
477
            direction=rqst.get('direction'))
4202.2.1 by Ian Clatworthy
get directory logging working again
478
479
    def _log_revision_iterator_using_per_file_graph(self):
480
        # Get the base revisions, filtering by the revision range.
481
        # Note that we always generate the merge revisions because
482
        # filter_revisions_touching_file_id() requires them ...
483
        rqst = self.rqst
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
484
        view_revisions = _calc_view_revisions(
485
            self.branch, self.start_rev_id, self.end_rev_id,
486
            rqst.get('direction'), generate_merge_revisions=True,
487
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
488
        if not isinstance(view_revisions, list):
489
            view_revisions = list(view_revisions)
4202.2.1 by Ian Clatworthy
get directory logging working again
490
        view_revisions = _filter_revisions_touching_file_id(self.branch,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
491
            rqst.get('specific_fileids')[0], view_revisions,
492
            include_merges=rqst.get('levels') != 1)
4202.2.1 by Ian Clatworthy
get directory logging working again
493
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
494
            rqst.get('delta_type'), rqst.get('message_search'))
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
495
496
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
497
def _calc_view_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
498
                         generate_merge_revisions,
499
                         delayed_graph_generation=False,
500
                         exclude_common_ancestry=False,
501
                         ):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
502
    """Calculate the revisions to view.
503
504
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
505
             a list of the same tuples.
506
    """
5097.1.13 by Vincent Ladeuil
Add more tests.
507
    if (exclude_common_ancestry and start_rev_id == end_rev_id):
508
        raise errors.BzrCommandError(
509
            '--exclude-common-ancestry requires two different revisions')
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
510
    if direction not in ('reverse', 'forward'):
511
        raise ValueError('invalid direction %r' % direction)
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
512
    br_revno, br_rev_id = branch.last_revision_info()
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
513
    if br_revno == 0:
514
        return []
515
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
516
    if (end_rev_id and start_rev_id == end_rev_id
5129.1.3 by Vincent Ladeuil
Slightly refactor the direction handling in log.
517
        and (not generate_merge_revisions
518
             or not _has_merges(branch, end_rev_id))):
5097.1.13 by Vincent Ladeuil
Add more tests.
519
        # If a single revision is requested, check we can handle it
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
520
        iter_revs = _generate_one_revision(branch, end_rev_id, br_rev_id,
521
                                           br_revno)
522
    elif not generate_merge_revisions:
523
        # If we only want to see linear revisions, we can iterate ...
524
        iter_revs = _generate_flat_revisions(branch, start_rev_id, end_rev_id,
525
                                             direction)
526
        if direction == 'forward':
527
            iter_revs = reversed(iter_revs)
4202.2.1 by Ian Clatworthy
get directory logging working again
528
    else:
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
529
        iter_revs = _generate_all_revisions(branch, start_rev_id, end_rev_id,
530
                                            direction, delayed_graph_generation,
531
                                            exclude_common_ancestry)
532
        if direction == 'forward':
533
            iter_revs = _rebase_merge_depth(reverse_by_depth(list(iter_revs)))
534
    return iter_revs
4202.2.1 by Ian Clatworthy
get directory logging working again
535
536
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
537
def _generate_one_revision(branch, rev_id, br_rev_id, br_revno):
4202.2.1 by Ian Clatworthy
get directory logging working again
538
    if rev_id == br_rev_id:
539
        # It's the tip
540
        return [(br_rev_id, br_revno, 0)]
541
    else:
542
        revno = branch.revision_id_to_dotted_revno(rev_id)
543
        revno_str = '.'.join(str(n) for n in revno)
544
        return [(rev_id, revno_str, 0)]
545
546
547
def _generate_flat_revisions(branch, start_rev_id, end_rev_id, direction):
548
    result = _linear_view_revisions(branch, start_rev_id, end_rev_id)
549
    # If a start limit was given and it's not obviously an
550
    # ancestor of the end limit, check it before outputting anything
551
    if direction == 'forward' or (start_rev_id
552
        and not _is_obvious_ancestor(branch, start_rev_id, end_rev_id)):
553
        try:
554
            result = list(result)
555
        except _StartNotLinearAncestor:
556
            raise errors.BzrCommandError('Start revision not found in'
557
                ' left-hand history of end revision.')
558
    return result
559
560
561
def _generate_all_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
562
                            delayed_graph_generation,
563
                            exclude_common_ancestry=False):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
564
    # On large trees, generating the merge graph can take 30-60 seconds
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
565
    # so we delay doing it until a merge is detected, incrementally
4955.7.5 by Vincent Ladeuil
Fixed as per Ian's review.
566
    # returning initial (non-merge) revisions while we can.
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
567
568
    # The above is only true for old formats (<= 0.92), for newer formats, a
569
    # couple of seconds only should be needed to load the whole graph and the
570
    # other graph operations needed are even faster than that -- vila 100201
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
571
    initial_revisions = []
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
572
    if delayed_graph_generation:
573
        try:
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
574
            for rev_id, revno, depth in  _linear_view_revisions(
575
                branch, start_rev_id, end_rev_id):
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
576
                if _has_merges(branch, rev_id):
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
577
                    # The end_rev_id can be nested down somewhere. We need an
578
                    # explicit ancestry check. There is an ambiguity here as we
579
                    # may not raise _StartNotLinearAncestor for a revision that
580
                    # is an ancestor but not a *linear* one. But since we have
581
                    # loaded the graph to do the check (or calculate a dotted
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
582
                    # revno), we may as well accept to show the log...  We need
583
                    # the check only if start_rev_id is not None as all
584
                    # revisions have _mod_revision.NULL_REVISION as an ancestor
585
                    # -- vila 20100319
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
586
                    graph = branch.repository.get_graph()
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
587
                    if (start_rev_id is not None
588
                        and not graph.is_ancestor(start_rev_id, end_rev_id)):
589
                        raise _StartNotLinearAncestor()
5097.1.1 by Vincent Ladeuil
Reduce duplication.
590
                    # Since we collected the revisions so far, we need to
591
                    # adjust end_rev_id.
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
592
                    end_rev_id = rev_id
593
                    break
594
                else:
595
                    initial_revisions.append((rev_id, revno, depth))
596
            else:
597
                # No merged revisions found
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
598
                return initial_revisions
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
599
        except _StartNotLinearAncestor:
600
            # A merge was never detected so the lower revision limit can't
601
            # be nested down somewhere
602
            raise errors.BzrCommandError('Start revision not found in'
603
                ' history of end revision.')
3936.3.15 by Ian Clatworthy
faster long log for a limited range with no merges
604
5097.1.1 by Vincent Ladeuil
Reduce duplication.
605
    # We exit the loop above because we encounter a revision with merges, from
606
    # this revision, we need to switch to _graph_view_revisions.
607
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
608
    # A log including nested merges is required. If the direction is reverse,
609
    # we rebase the initial merge depths so that the development line is
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
610
    # shown naturally, i.e. just like it is for linear logging. We can easily
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
611
    # make forward the exact opposite display, but showing the merge revisions
612
    # indented at the end seems slightly nicer in that case.
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
613
    view_revisions = chain(iter(initial_revisions),
614
        _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
615
                              rebase_initial_depths=(direction == 'reverse'),
616
                              exclude_common_ancestry=exclude_common_ancestry))
617
    return view_revisions
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
618
530 by Martin Pool
- put back verbose log support for reversed logs
619
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
620
def _has_merges(branch, rev_id):
621
    """Does a revision have multiple parents or not?"""
3936.3.40 by Ian Clatworthy
review feedback from jam
622
    parents = branch.repository.get_parent_map([rev_id]).get(rev_id, [])
623
    return len(parents) > 1
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
624
625
3936.3.31 by Ian Clatworthy
nicer obvious ancestor checking
626
def _is_obvious_ancestor(branch, start_rev_id, end_rev_id):
627
    """Is start_rev_id an obvious ancestor of end_rev_id?"""
628
    if start_rev_id and end_rev_id:
629
        start_dotted = branch.revision_id_to_dotted_revno(start_rev_id)
630
        end_dotted = branch.revision_id_to_dotted_revno(end_rev_id)
631
        if len(start_dotted) == 1 and len(end_dotted) == 1:
632
            # both on mainline
633
            return start_dotted[0] <= end_dotted[0]
634
        elif (len(start_dotted) == 3 and len(end_dotted) == 3 and
635
            start_dotted[0:1] == end_dotted[0:1]):
636
            # both on same development line
637
            return start_dotted[2] <= end_dotted[2]
638
        else:
639
            # not obvious
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
640
            return False
4955.5.3 by Vincent Ladeuil
Cleanup.
641
    # if either start or end is not specified then we use either the first or
642
    # the last revision and *they* are obvious ancestors.
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
643
    return True
644
645
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
646
def _linear_view_revisions(branch, start_rev_id, end_rev_id):
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
647
    """Calculate a sequence of revisions to view, newest to oldest.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
648
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
649
    :param start_rev_id: the lower revision-id
650
    :param end_rev_id: the upper revision-id
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
651
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
652
    :raises _StartNotLinearAncestor: if a start_rev_id is specified but
653
      is not found walking the left-hand history
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
654
    """
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
655
    br_revno, br_rev_id = branch.last_revision_info()
3943.4.5 by John Arbash Meinel
Restore _linear_view_revisions.
656
    repo = branch.repository
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
657
    if start_rev_id is None and end_rev_id is None:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
658
        cur_revno = br_revno
659
        for revision_id in repo.iter_reverse_revision_history(br_rev_id):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
660
            yield revision_id, str(cur_revno), 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
661
            cur_revno -= 1
3936.3.14 by Ian Clatworthy
bug fix
662
    else:
663
        if end_rev_id is None:
664
            end_rev_id = br_rev_id
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
665
        found_start = start_rev_id is None
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
666
        for revision_id in repo.iter_reverse_revision_history(end_rev_id):
3936.3.26 by Ian Clatworthy
use new dotted-revno-revision-id conversion methods to simplify & speed up code
667
            revno = branch.revision_id_to_dotted_revno(revision_id)
668
            revno_str = '.'.join(str(n) for n in revno)
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
669
            if not found_start and revision_id == start_rev_id:
670
                yield revision_id, revno_str, 0
671
                found_start = True
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
672
                break
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
673
            else:
674
                yield revision_id, revno_str, 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
675
        else:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
676
            if not found_start:
677
                raise _StartNotLinearAncestor()
3302.1.3 by Aaron Bentley
Add optimization of the simple case of generating view revisions
678
679
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
680
def _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
681
                          rebase_initial_depths=True,
682
                          exclude_common_ancestry=False):
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
683
    """Calculate revisions to view including merges, newest to oldest.
684
685
    :param branch: the branch
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
686
    :param start_rev_id: the lower revision-id
687
    :param end_rev_id: the upper revision-id
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
688
    :param rebase_initial_depth: should depths be rebased until a mainline
689
      revision is found?
690
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
691
    """
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
692
    if exclude_common_ancestry:
693
        stop_rule = 'with-merges-without-common-ancestry'
694
    else:
695
        stop_rule = 'with-merges'
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
696
    view_revisions = branch.iter_merge_sorted_revisions(
697
        start_revision_id=end_rev_id, stop_revision_id=start_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
698
        stop_rule=stop_rule)
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
699
    if not rebase_initial_depths:
700
        for (rev_id, merge_depth, revno, end_of_merge
701
             ) in view_revisions:
702
            yield rev_id, '.'.join(map(str, revno)), merge_depth
703
    else:
704
        # We're following a development line starting at a merged revision.
705
        # We need to adjust depths down by the initial depth until we find
706
        # a depth less than it. Then we use that depth as the adjustment.
707
        # If and when we reach the mainline, depth adjustment ends.
708
        depth_adjustment = None
709
        for (rev_id, merge_depth, revno, end_of_merge
710
             ) in view_revisions:
711
            if depth_adjustment is None:
712
                depth_adjustment = merge_depth
713
            if depth_adjustment:
714
                if merge_depth < depth_adjustment:
4955.5.3 by Vincent Ladeuil
Cleanup.
715
                    # From now on we reduce the depth adjustement, this can be
716
                    # surprising for users. The alternative requires two passes
717
                    # which breaks the fast display of the first revision
718
                    # though.
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
719
                    depth_adjustment = merge_depth
720
                merge_depth -= depth_adjustment
721
            yield rev_id, '.'.join(map(str, revno)), merge_depth
722
723
4955.4.14 by Vincent Ladeuil
Properly deprecate log.calculate_view_revisions.
724
@deprecated_function(deprecated_in((2, 2, 0)))
3936.3.13 by Ian Clatworthy
feedback from jameinel
725
def calculate_view_revisions(branch, start_revision, end_revision, direction,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
726
        specific_fileid, generate_merge_revisions):
3936.3.13 by Ian Clatworthy
feedback from jameinel
727
    """Calculate the revisions to view.
728
729
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
730
             a list of the same tuples.
731
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
732
    start_rev_id, end_rev_id = _get_revision_limits(branch, start_revision,
733
        end_revision)
734
    view_revisions = list(_calc_view_revisions(branch, start_rev_id, end_rev_id,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
735
        direction, generate_merge_revisions or specific_fileid))
3936.3.13 by Ian Clatworthy
feedback from jameinel
736
    if specific_fileid:
737
        view_revisions = _filter_revisions_touching_file_id(branch,
738
            specific_fileid, view_revisions,
739
            include_merges=generate_merge_revisions)
3936.3.28 by Ian Clatworthy
api compatibility: calculate_view_revisions rebases merge depth again
740
    return _rebase_merge_depth(view_revisions)
3936.3.13 by Ian Clatworthy
feedback from jameinel
741
742
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
743
def _rebase_merge_depth(view_revisions):
744
    """Adjust depths upwards so the top level is 0."""
745
    # If either the first or last revision have a merge_depth of 0, we're done
746
    if view_revisions and view_revisions[0][2] and view_revisions[-1][2]:
747
        min_depth = min([d for r,n,d in view_revisions])
748
        if min_depth != 0:
749
            view_revisions = [(r,n,d-min_depth) for r,n,d in view_revisions]
750
    return view_revisions
751
752
3936.3.16 by Ian Clatworthy
use deltas to match files in selected use cases
753
def make_log_rev_iterator(branch, view_revisions, generate_delta, search,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
754
        file_ids=None, direction='reverse'):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
755
    """Create a revision iterator for log.
756
757
    :param branch: The branch being logged.
758
    :param view_revisions: The revisions being viewed.
759
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
760
      Permitted values are None, 'full' and 'partial'.
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
761
    :param search: A user text search string.
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
762
    :param file_ids: If non empty, only revisions matching one or more of
763
      the file-ids are to be kept.
764
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
765
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
766
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
767
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
768
    # Convert view_revisions into (view, None, None) groups to fit with
769
    # the standard interface here.
770
    if type(view_revisions) == list:
3642.1.7 by Robert Collins
Review feedback.
771
        # A single batch conversion is faster than many incremental ones.
772
        # As we have all the data, do a batch conversion.
3642.1.5 by Robert Collins
Separate out batching of revisions.
773
        nones = [None] * len(view_revisions)
774
        log_rev_iterator = iter([zip(view_revisions, nones, nones)])
775
    else:
776
        def _convert():
777
            for view in view_revisions:
778
                yield (view, None, None)
779
        log_rev_iterator = iter([_convert()])
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
780
    for adapter in log_adapters:
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
781
        # It would be nicer if log adapters were first class objects
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
782
        # with custom parameters. This will do for now. IGC 20090127
783
        if adapter == _make_delta_filter:
784
            log_rev_iterator = adapter(branch, generate_delta,
785
                search, log_rev_iterator, file_ids, direction)
786
        else:
787
            log_rev_iterator = adapter(branch, generate_delta,
788
                search, log_rev_iterator)
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
789
    return log_rev_iterator
790
791
3642.1.7 by Robert Collins
Review feedback.
792
def _make_search_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
793
    """Create a filtered iterator of log_rev_iterator matching on a regex.
794
795
    :param branch: The branch being logged.
796
    :param generate_delta: Whether to generate a delta for each revision.
797
    :param search: A user text search string.
798
    :param log_rev_iterator: An input iterator containing all revisions that
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
799
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
800
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
801
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
802
    """
803
    if search is None:
804
        return log_rev_iterator
4183.6.4 by Martin Pool
Separate out re_compile_checked
805
    searchRE = re_compile_checked(search, re.IGNORECASE,
806
            'log message filter')
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
807
    return _filter_message_re(searchRE, log_rev_iterator)
808
809
810
def _filter_message_re(searchRE, log_rev_iterator):
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
811
    for revs in log_rev_iterator:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
812
        new_revs = []
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
813
        for (rev_id, revno, merge_depth), rev, delta in revs:
814
            if searchRE.search(rev.message):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
815
                new_revs.append(((rev_id, revno, merge_depth), rev, delta))
816
        yield new_revs
817
818
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
819
def _make_delta_filter(branch, generate_delta, search, log_rev_iterator,
820
    fileids=None, direction='reverse'):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
821
    """Add revision deltas to a log iterator if needed.
822
823
    :param branch: The branch being logged.
824
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
825
      Permitted values are None, 'full' and 'partial'.
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
826
    :param search: A user text search string.
827
    :param log_rev_iterator: An input iterator containing all revisions that
828
        could be displayed, in lists.
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
829
    :param fileids: If non empty, only revisions matching one or more of
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
830
      the file-ids are to be kept.
831
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
832
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
833
        delta).
834
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
835
    if not generate_delta and not fileids:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
836
        return log_rev_iterator
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
837
    return _generate_deltas(branch.repository, log_rev_iterator,
838
        generate_delta, fileids, direction)
839
840
4202.2.1 by Ian Clatworthy
get directory logging working again
841
def _generate_deltas(repository, log_rev_iterator, delta_type, fileids,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
842
    direction):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
843
    """Create deltas for each batch of revisions in log_rev_iterator.
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
844
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
845
    If we're only generating deltas for the sake of filtering against
846
    file-ids, we stop generating deltas once all file-ids reach the
847
    appropriate life-cycle point. If we're receiving data newest to
848
    oldest, then that life-cycle point is 'add', otherwise it's 'remove'.
849
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
850
    check_fileids = fileids is not None and len(fileids) > 0
851
    if check_fileids:
852
        fileid_set = set(fileids)
853
        if direction == 'reverse':
854
            stop_on = 'add'
855
        else:
856
            stop_on = 'remove'
857
    else:
858
        fileid_set = None
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
859
    for revs in log_rev_iterator:
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
860
        # If we were matching against fileids and we've run out,
3936.3.40 by Ian Clatworthy
review feedback from jam
861
        # there's nothing left to do
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
862
        if check_fileids and not fileid_set:
3936.3.40 by Ian Clatworthy
review feedback from jam
863
            return
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
864
        revisions = [rev[1] for rev in revs]
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
865
        new_revs = []
4202.2.1 by Ian Clatworthy
get directory logging working again
866
        if delta_type == 'full' and not check_fileids:
867
            deltas = repository.get_deltas_for_revisions(revisions)
868
            for rev, delta in izip(revs, deltas):
869
                new_revs.append((rev[0], rev[1], delta))
870
        else:
871
            deltas = repository.get_deltas_for_revisions(revisions, fileid_set)
872
            for rev, delta in izip(revs, deltas):
873
                if check_fileids:
874
                    if delta is None or not delta.has_changed():
875
                        continue
876
                    else:
877
                        _update_fileids(delta, fileid_set, stop_on)
878
                        if delta_type is None:
879
                            delta = None
880
                        elif delta_type == 'full':
881
                            # If the file matches all the time, rebuilding
882
                            # a full delta like this in addition to a partial
4202.2.4 by Ian Clatworthy
comment tweak from vila's review
883
                            # one could be slow. However, it's likely that
4202.2.1 by Ian Clatworthy
get directory logging working again
884
                            # most revisions won't get this far, making it
885
                            # faster to filter on the partial deltas and
886
                            # build the occasional full delta than always
887
                            # building full deltas and filtering those.
888
                            rev_id = rev[0][0]
889
                            delta = repository.get_revision_delta(rev_id)
890
                new_revs.append((rev[0], rev[1], delta))
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
891
        yield new_revs
892
893
4202.2.1 by Ian Clatworthy
get directory logging working again
894
def _update_fileids(delta, fileids, stop_on):
895
    """Update the set of file-ids to search based on file lifecycle events.
896
    
897
    :param fileids: a set of fileids to update
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
898
    :param stop_on: either 'add' or 'remove' - take file-ids out of the
899
      fileids set once their add or remove entry is detected respectively
900
    """
4202.2.1 by Ian Clatworthy
get directory logging working again
901
    if stop_on == 'add':
902
        for item in delta.added:
903
            if item[1] in fileids:
904
                fileids.remove(item[1])
905
    elif stop_on == 'delete':
906
        for item in delta.removed:
907
            if item[1] in fileids:
908
                fileids.remove(item[1])
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
909
910
3642.1.7 by Robert Collins
Review feedback.
911
def _make_revision_objects(branch, generate_delta, search, log_rev_iterator):
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
912
    """Extract revision objects from the repository
913
914
    :param branch: The branch being logged.
915
    :param generate_delta: Whether to generate a delta for each revision.
916
    :param search: A user text search string.
917
    :param log_rev_iterator: An input iterator containing all revisions that
918
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
919
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
920
        delta).
921
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
922
    repository = branch.repository
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
923
    for revs in log_rev_iterator:
924
        # r = revision_id, n = revno, d = merge depth
925
        revision_ids = [view[0] for view, _, _ in revs]
926
        revisions = repository.get_revisions(revision_ids)
927
        revs = [(rev[0], revision, rev[2]) for rev, revision in
928
            izip(revs, revisions)]
929
        yield revs
930
931
3642.1.7 by Robert Collins
Review feedback.
932
def _make_batch_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.5 by Robert Collins
Separate out batching of revisions.
933
    """Group up a single large batch into smaller ones.
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
934
935
    :param branch: The branch being logged.
936
    :param generate_delta: Whether to generate a delta for each revision.
937
    :param search: A user text search string.
3642.1.5 by Robert Collins
Separate out batching of revisions.
938
    :param log_rev_iterator: An input iterator containing all revisions that
939
        could be displayed, in lists.
3874.2.4 by Vincent Ladeuil
Fix too long lines.
940
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
941
        delta).
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
942
    """
943
    repository = branch.repository
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
944
    num = 9
3642.1.5 by Robert Collins
Separate out batching of revisions.
945
    for batch in log_rev_iterator:
946
        batch = iter(batch)
947
        while True:
948
            step = [detail for _, detail in zip(range(num), batch)]
949
            if len(step) == 0:
950
                break
951
            yield step
952
            num = min(int(num * 1.5), 200)
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
953
954
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
955
def _get_revision_limits(branch, start_revision, end_revision):
956
    """Get and check revision limits.
957
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
958
    :param  branch: The branch containing the revisions.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
959
960
    :param  start_revision: The first revision to be logged.
961
            For backwards compatibility this may be a mainline integer revno,
962
            but for merge revision support a RevisionInfo is expected.
963
964
    :param  end_revision: The last revision to be logged.
965
            For backwards compatibility this may be a mainline integer revno,
966
            but for merge revision support a RevisionInfo is expected.
967
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
968
    :return: (start_rev_id, end_rev_id) tuple.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
969
    """
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
970
    branch_revno, branch_rev_id = branch.last_revision_info()
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
971
    start_rev_id = None
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
972
    if start_revision is None:
973
        start_revno = 1
974
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
975
        if isinstance(start_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
976
            start_rev_id = start_revision.rev_id
977
            start_revno = start_revision.revno or 1
978
        else:
979
            branch.check_real_revno(start_revision)
980
            start_revno = start_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
981
            start_rev_id = branch.get_rev_id(start_revno)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
982
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
983
    end_rev_id = None
984
    if end_revision is None:
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
985
        end_revno = branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
986
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
987
        if isinstance(end_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
988
            end_rev_id = end_revision.rev_id
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
989
            end_revno = end_revision.revno or branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
990
        else:
991
            branch.check_real_revno(end_revision)
992
            end_revno = end_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
993
            end_rev_id = branch.get_rev_id(end_revno)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
994
3936.3.4 by Ian Clatworthy
fix empty_branch log
995
    if branch_revno != 0:
996
        if (start_rev_id == _mod_revision.NULL_REVISION
997
            or end_rev_id == _mod_revision.NULL_REVISION):
998
            raise errors.BzrCommandError('Logging revision 0 is invalid.')
999
        if start_revno > end_revno:
1000
            raise errors.BzrCommandError("Start revision must be older than "
1001
                                         "the end revision.")
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1002
    return (start_rev_id, end_rev_id)
1003
1004
1005
def _get_mainline_revs(branch, start_revision, end_revision):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1006
    """Get the mainline revisions from the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1007
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1008
    Generates the list of mainline revisions for the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1009
1010
    :param  branch: The branch containing the revisions.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1011
1012
    :param  start_revision: The first revision to be logged.
1013
            For backwards compatibility this may be a mainline integer revno,
1014
            but for merge revision support a RevisionInfo is expected.
1015
1016
    :param  end_revision: The last revision to be logged.
1017
            For backwards compatibility this may be a mainline integer revno,
1018
            but for merge revision support a RevisionInfo is expected.
1019
1020
    :return: A (mainline_revs, rev_nos, start_rev_id, end_rev_id) tuple.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1021
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1022
    branch_revno, branch_last_revision = branch.last_revision_info()
1023
    if branch_revno == 0:
1024
        return None, None, None, None
1025
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1026
    # For mainline generation, map start_revision and end_revision to
1027
    # mainline revnos. If the revision is not on the mainline choose the
1028
    # appropriate extreme of the mainline instead - the extra will be
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1029
    # filtered later.
1030
    # Also map the revisions to rev_ids, to be used in the later filtering
1031
    # stage.
1032
    start_rev_id = None
1033
    if start_revision is None:
1034
        start_revno = 1
1035
    else:
1036
        if isinstance(start_revision, revisionspec.RevisionInfo):
1037
            start_rev_id = start_revision.rev_id
1038
            start_revno = start_revision.revno or 1
1039
        else:
1040
            branch.check_real_revno(start_revision)
1041
            start_revno = start_revision
1042
1043
    end_rev_id = None
1044
    if end_revision is None:
1045
        end_revno = branch_revno
1046
    else:
1047
        if isinstance(end_revision, revisionspec.RevisionInfo):
1048
            end_rev_id = end_revision.rev_id
1049
            end_revno = end_revision.revno or branch_revno
1050
        else:
1051
            branch.check_real_revno(end_revision)
1052
            end_revno = end_revision
1053
1054
    if ((start_rev_id == _mod_revision.NULL_REVISION)
1055
        or (end_rev_id == _mod_revision.NULL_REVISION)):
1056
        raise errors.BzrCommandError('Logging revision 0 is invalid.')
1057
    if start_revno > end_revno:
1058
        raise errors.BzrCommandError("Start revision must be older than "
1059
                                     "the end revision.")
1060
1061
    if end_revno < start_revno:
1062
        return None, None, None, None
1063
    cur_revno = branch_revno
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1064
    rev_nos = {}
1065
    mainline_revs = []
1066
    for revision_id in branch.repository.iter_reverse_revision_history(
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1067
                        branch_last_revision):
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1068
        if cur_revno < start_revno:
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1069
            # We have gone far enough, but we always add 1 more revision
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1070
            rev_nos[revision_id] = cur_revno
1071
            mainline_revs.append(revision_id)
1072
            break
1073
        if cur_revno <= end_revno:
1074
            rev_nos[revision_id] = cur_revno
1075
            mainline_revs.append(revision_id)
1076
        cur_revno -= 1
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1077
    else:
1078
        # We walked off the edge of all revisions, so we add a 'None' marker
1079
        mainline_revs.append(None)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1080
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1081
    mainline_revs.reverse()
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1082
1083
    # override the mainline to look like the revision history.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1084
    return mainline_revs, rev_nos, start_rev_id, end_rev_id
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1085
1086
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1087
@deprecated_function(deprecated_in((2, 2, 0)))
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1088
def _filter_revision_range(view_revisions, start_rev_id, end_rev_id):
1089
    """Filter view_revisions based on revision ranges.
1090
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1091
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1092
            tuples to be filtered.
1093
1094
    :param start_rev_id: If not NONE specifies the first revision to be logged.
1095
            If NONE then all revisions up to the end_rev_id are logged.
1096
1097
    :param end_rev_id: If not NONE specifies the last revision to be logged.
1098
            If NONE then all revisions up to the end of the log are logged.
1099
1100
    :return: The filtered view_revisions.
1101
    """
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1102
    if start_rev_id or end_rev_id:
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1103
        revision_ids = [r for r, n, d in view_revisions]
1104
        if start_rev_id:
1105
            start_index = revision_ids.index(start_rev_id)
1106
        else:
1107
            start_index = 0
1108
        if start_rev_id == end_rev_id:
1109
            end_index = start_index
1110
        else:
1111
            if end_rev_id:
1112
                end_index = revision_ids.index(end_rev_id)
1113
            else:
1114
                end_index = len(view_revisions) - 1
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1115
        # To include the revisions merged into the last revision,
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1116
        # extend end_rev_id down to, but not including, the next rev
1117
        # with the same or lesser merge_depth
1118
        end_merge_depth = view_revisions[end_index][2]
1119
        try:
1120
            for index in xrange(end_index+1, len(view_revisions)+1):
1121
                if view_revisions[index][2] <= end_merge_depth:
1122
                    end_index = index - 1
1123
                    break
1124
        except IndexError:
1125
            # if the search falls off the end then log to the end as well
1126
            end_index = len(view_revisions) - 1
1127
        view_revisions = view_revisions[start_index:end_index+1]
1128
    return view_revisions
1129
1130
3940.1.3 by Ian Clatworthy
fix code
1131
def _filter_revisions_touching_file_id(branch, file_id, view_revisions,
1132
    include_merges=True):
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1133
    r"""Return the list of revision ids which touch a given file id.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1134
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1135
    The function filters view_revisions and returns a subset.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1136
    This includes the revisions which directly change the file id,
1137
    and the revisions which merge these changes. So if the
1138
    revision graph is::
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1139
        A-.
1140
        |\ \
1141
        B C E
1142
        |/ /
1143
        D |
1144
        |\|
1145
        | F
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1146
        |/
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1147
        G
1148
1149
    And 'C' changes a file, then both C and D will be returned. F will not be
1150
    returned even though it brings the changes to C into the branch starting
1151
    with E. (Note that if we were using F as the tip instead of G, then we
1152
    would see C, D, F.)
1153
1154
    This will also be restricted based on a subset of the mainline.
1155
1156
    :param branch: The branch where we can get text revision information.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1157
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1158
    :param file_id: Filter out revisions that do not touch file_id.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1159
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1160
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
1161
        tuples. This is the list of revisions which will be filtered. It is
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1162
        assumed that view_revisions is in merge_sort order (i.e. newest
1163
        revision first ).
1164
3940.1.3 by Ian Clatworthy
fix code
1165
    :param include_merges: include merge revisions in the result or not
1166
2359.1.8 by John Arbash Meinel
doc
1167
    :return: A list of (revision_id, dotted_revno, merge_depth) tuples.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1168
    """
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1169
    # Lookup all possible text keys to determine which ones actually modified
1170
    # the file.
1171
    text_keys = [(file_id, rev_id) for rev_id, revno, depth in view_revisions]
4183.3.1 by Vincent Ladeuil
Fix bug #346431 by allowing log._filter_revisions_touching_file_id to be
1172
    next_keys = None
3711.3.16 by John Arbash Meinel
Doc update.
1173
    # Looking up keys in batches of 1000 can cut the time in half, as well as
1174
    # memory consumption. GraphIndex *does* like to look for a few keys in
1175
    # parallel, it just doesn't like looking for *lots* of keys in parallel.
3711.3.19 by John Arbash Meinel
Add a TODO discussing how our index requests should evolve.
1176
    # TODO: This code needs to be re-evaluated periodically as we tune the
1177
    #       indexing layer. We might consider passing in hints as to the known
1178
    #       access pattern (sparse/clustered, high success rate/low success
1179
    #       rate). This particular access is clustered with a low success rate.
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1180
    get_parent_map = branch.repository.texts.get_parent_map
1181
    modified_text_revisions = set()
1182
    chunk_size = 1000
1183
    for start in xrange(0, len(text_keys), chunk_size):
1184
        next_keys = text_keys[start:start + chunk_size]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1185
        # Only keep the revision_id portion of the key
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1186
        modified_text_revisions.update(
1187
            [k[1] for k in get_parent_map(next_keys)])
1188
    del text_keys, next_keys
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1189
1190
    result = []
1191
    # Track what revisions will merge the current revision, replace entries
1192
    # with 'None' when they have been added to result
1193
    current_merge_stack = [None]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1194
    for info in view_revisions:
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1195
        rev_id, revno, depth = info
1196
        if depth == len(current_merge_stack):
1197
            current_merge_stack.append(info)
1198
        else:
1199
            del current_merge_stack[depth + 1:]
1200
            current_merge_stack[-1] = info
1201
1202
        if rev_id in modified_text_revisions:
1203
            # This needs to be logged, along with the extra revisions
1204
            for idx in xrange(len(current_merge_stack)):
1205
                node = current_merge_stack[idx]
1206
                if node is not None:
3940.1.3 by Ian Clatworthy
fix code
1207
                    if include_merges or node[2] == 0:
1208
                        result.append(node)
1209
                        current_merge_stack[idx] = None
3711.3.4 by John Arbash Meinel
Significantly faster, but consuming more memory.
1210
    return result
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1211
1212
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1213
@deprecated_function(deprecated_in((2, 2, 0)))
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1214
def get_view_revisions(mainline_revs, rev_nos, branch, direction,
1756.2.22 by Aaron Bentley
Apply review comments
1215
                       include_merges=True):
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1216
    """Produce an iterator of revisions to show
1217
    :return: an iterator of (revision_id, revno, merge_depth)
1218
    (if there is no revno for a revision, None is supplied)
1219
    """
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1220
    if not include_merges:
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1221
        revision_ids = mainline_revs[1:]
1222
        if direction == 'reverse':
1223
            revision_ids.reverse()
1224
        for revision_id in revision_ids:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1225
            yield revision_id, str(rev_nos[revision_id]), 0
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1226
        return
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1227
    graph = branch.repository.get_graph()
1228
    # This asks for all mainline revisions, which means we only have to spider
1229
    # sideways, rather than depth history. That said, its still size-of-history
1230
    # and should be addressed.
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1231
    # mainline_revisions always includes an extra revision at the beginning, so
1232
    # don't request it.
3287.6.8 by Robert Collins
Reduce code duplication as per review.
1233
    parent_map = dict(((key, value) for key, value in
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1234
        graph.iter_ancestry(mainline_revs[1:]) if value is not None))
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1235
    # filter out ghosts; merge_sort errors on ghosts.
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
1236
    rev_graph = _mod_repository._strip_NULL_ghosts(parent_map)
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1237
    merge_sorted_revisions = tsort.merge_sort(
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1238
        rev_graph,
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1239
        mainline_revs[-1],
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1240
        mainline_revs,
1241
        generate_revno=True)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1242
1243
    if direction == 'forward':
1244
        # forward means oldest first.
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1245
        merge_sorted_revisions = reverse_by_depth(merge_sorted_revisions)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1246
    elif direction != 'reverse':
1247
        raise ValueError('invalid direction %r' % direction)
1248
3874.2.4 by Vincent Ladeuil
Fix too long lines.
1249
    for (sequence, rev_id, merge_depth, revno, end_of_merge
1250
         ) in merge_sorted_revisions:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1251
        yield rev_id, '.'.join(map(str, revno)), merge_depth
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1252
1253
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1254
def reverse_by_depth(merge_sorted_revisions, _depth=0):
1255
    """Reverse revisions by depth.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1256
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1257
    Revisions with a different depth are sorted as a group with the previous
1258
    revision of that depth.  There may be no topological justification for this,
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1259
    but it looks much nicer.
1260
    """
3842.2.6 by Vincent Ladeuil
Fix typo.
1261
    # Add a fake revision at start so that we can always attach sub revisions
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1262
    merge_sorted_revisions = [(None, None, _depth)] + merge_sorted_revisions
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1263
    zd_revisions = []
1264
    for val in merge_sorted_revisions:
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1265
        if val[2] == _depth:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1266
            # Each revision at the current depth becomes a chunk grouping all
1267
            # higher depth revisions.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1268
            zd_revisions.append([val])
1269
        else:
1270
            zd_revisions[-1].append(val)
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1271
    for revisions in zd_revisions:
1272
        if len(revisions) > 1:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1273
            # We have higher depth revisions, let reverse them locally
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1274
            revisions[1:] = reverse_by_depth(revisions[1:], _depth + 1)
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1275
    zd_revisions.reverse()
1276
    result = []
1277
    for chunk in zd_revisions:
1278
        result.extend(chunk)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1279
    if _depth == 0:
1280
        # Top level call, get rid of the fake revisions that have been added
1281
        result = [r for r in result if r[0] is not None and r[1] is not None]
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1282
    return result
1283
1284
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1285
class LogRevision(object):
1286
    """A revision to be logged (by LogFormatter.log_revision).
1287
1288
    A simple wrapper for the attributes of a revision to be logged.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1289
    The attributes may or may not be populated, as determined by the
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1290
    logging options and the log formatter capabilities.
1291
    """
1292
2490.1.2 by John Arbash Meinel
Cleanup according to PEP8 and some other small whitespace fixes
1293
    def __init__(self, rev=None, revno=None, merge_depth=0, delta=None,
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1294
                 tags=None, diff=None):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1295
        self.rev = rev
3936.3.39 by Ian Clatworthy
merge bzr.dev r3975
1296
        self.revno = str(revno)
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1297
        self.merge_depth = merge_depth
1298
        self.delta = delta
1299
        self.tags = tags
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1300
        self.diff = diff
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1301
1302
794 by Martin Pool
- Merge John's nice short-log format.
1303
class LogFormatter(object):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1304
    """Abstract class to display log messages.
1305
1306
    At a minimum, a derived class must implement the log_revision method.
1307
1308
    If the LogFormatter needs to be informed of the beginning or end of
1309
    a log it should implement the begin_log and/or end_log hook methods.
1310
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1311
    A LogFormatter should define the following supports_XXX flags
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1312
    to indicate which LogRevision attributes it supports:
1313
1314
    - supports_delta must be True if this log formatter supports delta.
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1315
        Otherwise the delta attribute may not be populated.  The 'delta_format'
1316
        attribute describes whether the 'short_status' format (1) or the long
3936.3.2 by Ian Clatworthy
minor cleanups
1317
        one (2) should be used.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1318
1319
    - supports_merge_revisions must be True if this log formatter supports
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
1320
        merge revisions.  If not, then only mainline revisions will be passed
1321
        to the formatter.
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1322
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1323
    - preferred_levels is the number of levels this formatter defaults to.
1324
        The default value is zero meaning display all levels.
1325
        This value is only relevant if supports_merge_revisions is True.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1326
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1327
    - supports_tags must be True if this log formatter supports tags.
1328
        Otherwise the tags attribute may not be populated.
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1329
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1330
    - supports_diff must be True if this log formatter supports diffs.
1331
        Otherwise the diff attribute may not be populated.
1332
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1333
    Plugins can register functions to show custom revision properties using
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1334
    the properties_handler_registry. The registered function
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1335
    must respect the following interface description:
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1336
        def my_show_properties(properties_dict):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1337
            # code that returns a dict {'name':'value'} of the properties
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1338
            # to be shown
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1339
    """
3947.1.10 by Ian Clatworthy
review feedback from vila
1340
    preferred_levels = 0
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1341
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1342
    def __init__(self, to_file, show_ids=False, show_timezone='original',
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
1343
                 delta_format=None, levels=None, show_advice=False,
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1344
                 to_exact_file=None, author_list_handler=None):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1345
        """Create a LogFormatter.
1346
1347
        :param to_file: the file to output to
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1348
        :param to_exact_file: if set, gives an output stream to which 
1349
             non-Unicode diffs are written.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1350
        :param show_ids: if True, revision-ids are to be displayed
1351
        :param show_timezone: the timezone to use
1352
        :param delta_format: the level of delta information to display
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1353
          or None to leave it to the formatter to decide
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1354
        :param levels: the number of levels to display; None or -1 to
1355
          let the log formatter decide.
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1356
        :param show_advice: whether to show advice at the end of the
1357
          log or not
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1358
        :param author_list_handler: callable generating a list of
1359
          authors to display for a given revision
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1360
        """
794 by Martin Pool
- Merge John's nice short-log format.
1361
        self.to_file = to_file
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1362
        # 'exact' stream used to show diff, it should print content 'as is'
1363
        # and should not try to decode/encode it to unicode to avoid bug #328007
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1364
        if to_exact_file is not None:
1365
            self.to_exact_file = to_exact_file
1366
        else:
4792.8.12 by Martin Pool
comment
1367
            # XXX: somewhat hacky; this assumes it's a codec writer; it's better
1368
            # for code that expects to get diffs to pass in the exact file
1369
            # stream
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1370
            self.to_exact_file = getattr(to_file, 'stream', to_file)
794 by Martin Pool
- Merge John's nice short-log format.
1371
        self.show_ids = show_ids
1372
        self.show_timezone = show_timezone
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1373
        if delta_format is None:
1374
            # Ensures backward compatibility
1375
            delta_format = 2 # long format
1376
        self.delta_format = delta_format
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1377
        self.levels = levels
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1378
        self._show_advice = show_advice
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1379
        self._merge_count = 0
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1380
        self._author_list_handler = author_list_handler
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1381
3947.1.10 by Ian Clatworthy
review feedback from vila
1382
    def get_levels(self):
1383
        """Get the number of levels to display or 0 for all."""
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1384
        if getattr(self, 'supports_merge_revisions', False):
1385
            if self.levels is None or self.levels == -1:
4217.2.1 by Ian Clatworthy
fix log advice when the # of levels is implicit
1386
                self.levels = self.preferred_levels
1387
        else:
1388
            self.levels = 1
1389
        return self.levels
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1390
3947.1.10 by Ian Clatworthy
review feedback from vila
1391
    def log_revision(self, revision):
1392
        """Log a revision.
1393
1394
        :param  revision:   The LogRevision to be logged.
1395
        """
1396
        raise NotImplementedError('not implemented in abstract base')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1397
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1398
    def show_advice(self):
1399
        """Output user advice, if any, when the log is completed."""
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1400
        if self._show_advice and self.levels == 1 and self._merge_count > 0:
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1401
            advice_sep = self.get_advice_separator()
1402
            if advice_sep:
1403
                self.to_file.write(advice_sep)
4208.2.2 by Ian Clatworthy
show --levels 0 in advice, not just -n0
1404
            self.to_file.write(
4221.2.1 by Ian Clatworthy
--include-merges as an alias for --levels 0 in log
1405
                "Use --include-merges or -n0 to see merged revisions.\n")
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1406
1407
    def get_advice_separator(self):
1408
        """Get the text separating the log from the closing advice."""
1409
        return ''
1410
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1411
    def short_committer(self, rev):
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1412
        name, address = config.parse_username(rev.committer)
1413
        if name:
3063.3.1 by Lukáš Lalinský
Fall back to showing e-mail in ``log --short/--line`` if the committer/author has only e-mail.
1414
            return name
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1415
        return address
2388.1.11 by Alexander Belchenko
changes after John's review
1416
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1417
    def short_author(self, rev):
4081.3.14 by Martin von Gagern
Pass keyword arguments of authors method by name.
1418
        return self.authors(rev, 'first', short=True, sep=', ')
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1419
1420
    def authors(self, rev, who, short=False, sep=None):
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1421
        """Generate list of authors, taking --authors option into account.
1422
1423
        The caller has to specify the name of a author list handler,
1424
        as provided by the author list registry, using the ``who``
1425
        argument.  That name only sets a default, though: when the
1426
        user selected a different author list generation using the
1427
        ``--authors`` command line switch, as represented by the
1428
        ``author_list_handler`` constructor argument, that value takes
1429
        precedence.
1430
1431
        :param rev: The revision for which to generate the list of authors.
1432
        :param who: Name of the default handler.
1433
        :param short: Whether to shorten names to either name or address.
1434
        :param sep: What separator to use for automatic concatenation.
1435
        """
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1436
        if self._author_list_handler is not None:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1437
            # The user did specify --authors, which overrides the default
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1438
            author_list_handler = self._author_list_handler
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1439
        else:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1440
            # The user didn't specify --authors, so we use the caller's default
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1441
            author_list_handler = author_list_registry.get(who)
1442
        names = author_list_handler(rev)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1443
        if short:
1444
            for i in range(len(names)):
1445
                name, address = config.parse_username(names[i])
1446
                if name:
1447
                    names[i] = name
1448
                else:
1449
                    names[i] = address
1450
        if sep is not None:
1451
            names = sep.join(names)
1452
        return names
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1453
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1454
    def merge_marker(self, revision):
4213.1.1 by Ian Clatworthy
merge indicators in log --long (Ian Clatworthy)
1455
        """Get the merge marker to include in the output or '' if none."""
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1456
        if len(revision.rev.parent_ids) > 1:
1457
            self._merge_count += 1
1458
            return ' [merge]'
1459
        else:
1460
            return ''
1461
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
1462
    def show_properties(self, revision, indent):
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1463
        """Displays the custom properties returned by each registered handler.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1464
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1465
        If a registered handler raises an error it is propagated.
3144.7.5 by Guillermo Gonzalez
* some improvements to the doctstring in show_properties method and in LogFormatter
1466
        """
4379.4.1 by Ian Clatworthy
make log --long faster
1467
        for line in self.custom_properties(revision):
1468
            self.to_file.write("%s%s\n" % (indent, line))
1469
1470
    def custom_properties(self, revision):
1471
        """Format the custom properties returned by each registered handler.
1472
1473
        If a registered handler raises an error it is propagated.
1474
1475
        :return: a list of formatted lines (excluding trailing newlines)
1476
        """
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1477
        lines = self._foreign_info_properties(revision)
1478
        for key, handler in properties_handler_registry.iteritems():
1479
            lines.extend(self._format_properties(handler(revision)))
1480
        return lines
1481
1482
    def _foreign_info_properties(self, rev):
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1483
        """Custom log displayer for foreign revision identifiers.
1484
1485
        :param rev: Revision object.
1486
        """
1487
        # Revision comes directly from a foreign repository
1488
        if isinstance(rev, foreign.ForeignRevision):
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
1489
            return self._format_properties(
1490
                rev.mapping.vcs.show_foreign_revid(rev.foreign_revid))
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1491
1492
        # Imported foreign revision revision ids always contain :
1493
        if not ":" in rev.revision_id:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1494
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1495
1496
        # Revision was once imported from a foreign repository
1497
        try:
1498
            foreign_revid, mapping = \
1499
                foreign.foreign_vcs_registry.parse_revision_id(rev.revision_id)
1500
        except errors.InvalidRevisionId:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1501
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1502
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1503
        return self._format_properties(
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1504
            mapping.vcs.show_foreign_revid(foreign_revid))
1505
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1506
    def _format_properties(self, properties):
4379.4.1 by Ian Clatworthy
make log --long faster
1507
        lines = []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1508
        for key, value in properties.items():
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1509
            lines.append(key + ': ' + value)
4379.4.1 by Ian Clatworthy
make log --long faster
1510
        return lines
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1511
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1512
    def show_diff(self, to_file, diff, indent):
1513
        for l in diff.rstrip().split('\n'):
1514
            to_file.write(indent + '%s\n' % (l,))
1515
2388.1.11 by Alexander Belchenko
changes after John's review
1516
4379.4.1 by Ian Clatworthy
make log --long faster
1517
# Separator between revisions in long format
1518
_LONG_SEP = '-' * 60
1519
1520
794 by Martin Pool
- Merge John's nice short-log format.
1521
class LongLogFormatter(LogFormatter):
2388.1.11 by Alexander Belchenko
changes after John's review
1522
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1523
    supports_merge_revisions = True
4206.1.1 by Ian Clatworthy
log mainline by default
1524
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1525
    supports_delta = True
1526
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1527
    supports_diff = True
2388.1.10 by Alexander Belchenko
Slightly reworked: use None instead of [] as default tags list; PEP-8
1528
4379.4.1 by Ian Clatworthy
make log --long faster
1529
    def __init__(self, *args, **kwargs):
1530
        super(LongLogFormatter, self).__init__(*args, **kwargs)
1531
        if self.show_timezone == 'original':
1532
            self.date_string = self._date_string_original_timezone
1533
        else:
1534
            self.date_string = self._date_string_with_timezone
1535
1536
    def _date_string_with_timezone(self, rev):
1537
        return format_date(rev.timestamp, rev.timezone or 0,
1538
                           self.show_timezone)
1539
1540
    def _date_string_original_timezone(self, rev):
1541
        return format_date_with_offset_in_original_timezone(rev.timestamp,
1542
            rev.timezone or 0)
1543
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1544
    def log_revision(self, revision):
1545
        """Log a revision, either merged or not."""
2671.2.5 by Lukáš Lalinský
Fixes for comments from the mailing list.
1546
        indent = '    ' * revision.merge_depth
4379.4.1 by Ian Clatworthy
make log --long faster
1547
        lines = [_LONG_SEP]
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1548
        if revision.revno is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1549
            lines.append('revno: %s%s' % (revision.revno,
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1550
                self.merge_marker(revision)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1551
        if revision.tags:
4379.4.1 by Ian Clatworthy
make log --long faster
1552
            lines.append('tags: %s' % (', '.join(revision.tags)))
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1553
        if self.show_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1554
            lines.append('revision-id: %s' % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1555
            for parent_id in revision.rev.parent_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1556
                lines.append('parent: %s' % (parent_id,))
1557
        lines.extend(self.custom_properties(revision.rev))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1558
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1559
        committer = revision.rev.committer
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1560
        authors = self.authors(revision.rev, 'all')
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1561
        if authors != [committer]:
4379.4.1 by Ian Clatworthy
make log --long faster
1562
            lines.append('author: %s' % (", ".join(authors),))
1563
        lines.append('committer: %s' % (committer,))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1564
1565
        branch_nick = revision.rev.properties.get('branch-nick', None)
1566
        if branch_nick is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1567
            lines.append('branch nick: %s' % (branch_nick,))
1568
1569
        lines.append('timestamp: %s' % (self.date_string(revision.rev),))
1570
1571
        lines.append('message:')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1572
        if not revision.rev.message:
4379.4.1 by Ian Clatworthy
make log --long faster
1573
            lines.append('  (no message)')
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1574
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1575
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1576
            for l in message.split('\n'):
4379.4.1 by Ian Clatworthy
make log --long faster
1577
                lines.append('  %s' % (l,))
1578
1579
        # Dump the output, appending the delta and diff if requested
1580
        to_file = self.to_file
1581
        to_file.write("%s%s\n" % (indent, ('\n' + indent).join(lines)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1582
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1583
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1584
            from bzrlib.delta import report_delta
1585
            report_delta(to_file, revision.delta, short_status=False, 
1586
                         show_ids=self.show_ids, indent=indent)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1587
        if revision.diff is not None:
1588
            to_file.write(indent + 'diff:\n')
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1589
            to_file.flush()
3943.5.6 by Ian Clatworthy
feedback from jam's review
1590
            # Note: we explicitly don't indent the diff (relative to the
1591
            # revision information) so that the output can be fed to patch -p0
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1592
            self.show_diff(self.to_exact_file, revision.diff, indent)
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1593
            self.to_exact_file.flush()
794 by Martin Pool
- Merge John's nice short-log format.
1594
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1595
    def get_advice_separator(self):
1596
        """Get the text separating the log from the closing advice."""
1597
        return '-' * 60 + '\n'
1598
794 by Martin Pool
- Merge John's nice short-log format.
1599
1600
class ShortLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1601
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1602
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1603
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1604
    supports_delta = True
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1605
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1606
    supports_diff = True
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1607
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1608
    def __init__(self, *args, **kwargs):
1609
        super(ShortLogFormatter, self).__init__(*args, **kwargs)
1610
        self.revno_width_by_depth = {}
1611
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1612
    def log_revision(self, revision):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1613
        # We need two indents: one per depth and one for the information
1614
        # relative to that indent. Most mainline revnos are 5 chars or
3970.1.1 by Ian Clatworthy
log -n/--levels (Ian Clatworthy)
1615
        # less while dotted revnos are typically 11 chars or less. Once
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1616
        # calculated, we need to remember the offset for a given depth
1617
        # as we might be starting from a dotted revno in the first column
1618
        # and we want subsequent mainline revisions to line up.
1619
        depth = revision.merge_depth
1620
        indent = '    ' * depth
1621
        revno_width = self.revno_width_by_depth.get(depth)
1622
        if revno_width is None:
1623
            if revision.revno.find('.') == -1:
3947.1.10 by Ian Clatworthy
review feedback from vila
1624
                # mainline revno, e.g. 12345
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1625
                revno_width = 5
1626
            else:
3947.1.10 by Ian Clatworthy
review feedback from vila
1627
                # dotted revno, e.g. 12345.10.55
1628
                revno_width = 11
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1629
            self.revno_width_by_depth[depth] = revno_width
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1630
        offset = ' ' * (revno_width + 1)
1631
794 by Martin Pool
- Merge John's nice short-log format.
1632
        to_file = self.to_file
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1633
        tags = ''
1634
        if revision.tags:
3946.3.2 by Ian Clatworthy
add tests & NEWS item
1635
            tags = ' {%s}' % (', '.join(revision.tags))
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1636
        to_file.write(indent + "%*s %s\t%s%s%s\n" % (revno_width,
1637
                revision.revno, self.short_author(revision.rev),
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1638
                format_date(revision.rev.timestamp,
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1639
                            revision.rev.timezone or 0,
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1640
                            self.show_timezone, date_fmt="%Y-%m-%d",
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1641
                            show_offset=False),
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1642
                tags, self.merge_marker(revision)))
3976.3.1 by Neil Martinsen-Burrell
Add custom properties handling to short log format
1643
        self.show_properties(revision.rev, indent+offset)
794 by Martin Pool
- Merge John's nice short-log format.
1644
        if self.show_ids:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1645
            to_file.write(indent + offset + 'revision-id:%s\n'
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1646
                          % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1647
        if not revision.rev.message:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1648
            to_file.write(indent + offset + '(no message)\n')
794 by Martin Pool
- Merge John's nice short-log format.
1649
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1650
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1651
            for l in message.split('\n'):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1652
                to_file.write(indent + offset + '%s\n' % (l,))
794 by Martin Pool
- Merge John's nice short-log format.
1653
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1654
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1655
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1656
            from bzrlib.delta import report_delta
5076.4.6 by Arnaud Jeansen
Go back to unified report_delta method (i.e. former TreeDelta.show())
1657
            report_delta(to_file, revision.delta, 
1658
                         short_status=self.delta_format==1, 
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1659
                         show_ids=self.show_ids, indent=indent + offset)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1660
        if revision.diff is not None:
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1661
            self.show_diff(self.to_exact_file, revision.diff, '      ')
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1662
        to_file.write('\n')
794 by Martin Pool
- Merge John's nice short-log format.
1663
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1664
1185.12.25 by Aaron Bentley
Added one-line log format
1665
class LineLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1666
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1667
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1668
    preferred_levels = 1
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1669
    supports_tags = True
2997.1.1 by Kent Gibson
Support logging single merge revisions with short and line log formatters.
1670
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1671
    def __init__(self, *args, **kwargs):
1672
        super(LineLogFormatter, self).__init__(*args, **kwargs)
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1673
        width = terminal_width()
1674
        if width is not None:
1675
            # we need one extra space for terminals that wrap on last char
1676
            width = width - 1
1677
        self._max_chars = width
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1678
1185.12.25 by Aaron Bentley
Added one-line log format
1679
    def truncate(self, str, max_len):
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1680
        if max_len is None or len(str) <= max_len:
1185.12.25 by Aaron Bentley
Added one-line log format
1681
            return str
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1682
        return str[:max_len-3] + '...'
1185.12.25 by Aaron Bentley
Added one-line log format
1683
1684
    def date_string(self, rev):
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1685
        return format_date(rev.timestamp, rev.timezone or 0,
1185.12.25 by Aaron Bentley
Added one-line log format
1686
                           self.show_timezone, date_fmt="%Y-%m-%d",
1687
                           show_offset=False)
1688
1689
    def message(self, rev):
1690
        if not rev.message:
1691
            return '(no message)'
1692
        else:
1693
            return rev.message
1694
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1695
    def log_revision(self, revision):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1696
        indent = '  ' * revision.merge_depth
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1697
        self.to_file.write(self.log_string(revision.revno, revision.rev,
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1698
            self._max_chars, revision.tags, indent))
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1699
        self.to_file.write('\n')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1700
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1701
    def log_string(self, revno, rev, max_chars, tags=None, prefix=''):
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1702
        """Format log info into one string. Truncate tail of string
3677.1.1 by Vincent Ladeuil
Begin fixing bug #233817.
1703
        :param  revno:      revision number or None.
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1704
                            Revision numbers counts from 1.
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1705
        :param  rev:        revision object
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1706
        :param  max_chars:  maximum length of resulting string
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1707
        :param  tags:       list of tags or None
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1708
        :param  prefix:     string to prefix each line
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1709
        :return:            formatted truncated string
1710
        """
1711
        out = []
1712
        if revno:
1713
            # show revno only when is not None
3946.3.4 by Ian Clatworthy
minor cleanup
1714
            out.append("%s:" % revno)
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1715
        out.append(self.truncate(self.short_author(rev), 20))
1185.12.25 by Aaron Bentley
Added one-line log format
1716
        out.append(self.date_string(rev))
3983.2.1 by Neil Martinsen-Burrell
add merge indication to the line format
1717
        if len(rev.parent_ids) > 1:
1718
            out.append('[merge]')
3946.3.3 by Ian Clatworthy
feedback from jelmer re position of tags in --line
1719
        if tags:
1720
            tag_str = '{%s}' % (', '.join(tags))
1721
            out.append(tag_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
1722
        out.append(rev.get_summary())
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1723
        return self.truncate(prefix + " ".join(out).rstrip('\n'), max_chars)
794 by Martin Pool
- Merge John's nice short-log format.
1724
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1725
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1726
class GnuChangelogLogFormatter(LogFormatter):
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1727
1728
    supports_merge_revisions = True
1729
    supports_delta = True
1730
1731
    def log_revision(self, revision):
1732
        """Log a revision, either merged or not."""
1733
        to_file = self.to_file
1734
1735
        date_str = format_date(revision.rev.timestamp,
1736
                               revision.rev.timezone or 0,
1737
                               self.show_timezone,
1738
                               date_fmt='%Y-%m-%d',
1739
                               show_offset=False)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1740
        committer_str = self.authors(revision.rev, 'first', sep=', ')
4081.3.6 by Martin von Gagern
Drop space to make John happy.
1741
        committer_str = committer_str.replace(' <', '  <')
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1742
        to_file.write('%s  %s\n\n' % (date_str,committer_str))
1743
4137.1.1 by James Westby
Small improvements to the GNU ChangeLog formatter.
1744
        if revision.delta is not None and revision.delta.has_changed():
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1745
            for c in revision.delta.added + revision.delta.removed + revision.delta.modified:
1746
                path, = c[:1]
1747
                to_file.write('\t* %s:\n' % (path,))
1748
            for c in revision.delta.renamed:
1749
                oldpath,newpath = c[:2]
1750
                # For renamed files, show both the old and the new path
1751
                to_file.write('\t* %s:\n\t* %s:\n' % (oldpath,newpath))
1752
            to_file.write('\n')
1753
1754
        if not revision.rev.message:
1755
            to_file.write('\tNo commit message\n')
1756
        else:
1757
            message = revision.rev.message.rstrip('\r\n')
1758
            for l in message.split('\n'):
1759
                to_file.write('\t%s\n' % (l.lstrip(),))
1760
            to_file.write('\n')
1761
1762
1185.12.27 by Aaron Bentley
Use line log for pending merges
1763
def line_log(rev, max_chars):
1764
    lf = LineLogFormatter(None)
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1765
    return lf.log_string(None, rev, max_chars)
1185.12.27 by Aaron Bentley
Use line log for pending merges
1766
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1767
1768
class LogFormatterRegistry(registry.Registry):
1769
    """Registry for log formatters"""
1770
1771
    def make_formatter(self, name, *args, **kwargs):
1772
        """Construct a formatter from arguments.
1773
1774
        :param name: Name of the formatter to construct.  'short', 'long' and
1775
            'line' are built-in.
1776
        """
1777
        return self.get(name)(*args, **kwargs)
1778
1779
    def get_default(self, branch):
1780
        return self.get(branch.get_config().log_format())
1781
1782
1783
log_formatter_registry = LogFormatterRegistry()
1784
1785
1786
log_formatter_registry.register('short', ShortLogFormatter,
1787
                                'Moderately short log format')
1788
log_formatter_registry.register('long', LongLogFormatter,
1789
                                'Detailed log format')
1790
log_formatter_registry.register('line', LineLogFormatter,
1791
                                'Log format with one line per revision')
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1792
log_formatter_registry.register('gnu-changelog', GnuChangelogLogFormatter,
1793
                                'Format used by GNU ChangeLog files')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1794
794 by Martin Pool
- Merge John's nice short-log format.
1795
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1796
def register_formatter(name, formatter):
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1797
    log_formatter_registry.register(name, formatter)
1798
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1799
794 by Martin Pool
- Merge John's nice short-log format.
1800
def log_formatter(name, *args, **kwargs):
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1801
    """Construct a formatter from arguments.
1802
1185.12.27 by Aaron Bentley
Use line log for pending merges
1803
    name -- Name of the formatter to construct; currently 'long', 'short' and
1804
        'line' are supported.
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1805
    """
794 by Martin Pool
- Merge John's nice short-log format.
1806
    try:
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1807
        return log_formatter_registry.make_formatter(name, *args, **kwargs)
1553.2.2 by Erik Bågfors
Made "unknown log formatter" error message work
1808
    except KeyError:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1809
        raise errors.BzrCommandError("unknown log formatter: %r" % name)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1810
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1811
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1812
def author_list_all(rev):
1813
    return rev.get_apparent_authors()[:]
1814
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1815
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1816
def author_list_first(rev):
1817
    lst = rev.get_apparent_authors()
1818
    try:
1819
        return [lst[0]]
1820
    except IndexError:
1821
        return []
1822
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1823
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1824
def author_list_committer(rev):
1825
    return [rev.committer]
1826
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1827
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1828
author_list_registry = registry.Registry()
1829
1830
author_list_registry.register('all', author_list_all,
1831
                              'All authors')
1832
1833
author_list_registry.register('first', author_list_first,
1834
                              'The first author')
1835
1836
author_list_registry.register('committer', author_list_committer,
1837
                              'The committer')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1838
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1839
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1840
def show_one_log(revno, rev, delta, verbose, to_file, show_timezone):
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
1841
    # deprecated; for compatibility
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1842
    lf = LongLogFormatter(to_file=to_file, show_timezone=show_timezone)
1843
    lf.show(revno, rev, delta)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1844
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1845
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1846
def show_changed_revisions(branch, old_rh, new_rh, to_file=None,
1847
                           log_format='long'):
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1848
    """Show the change in revision history comparing the old revision history to the new one.
1849
1850
    :param branch: The branch where the revisions exist
1851
    :param old_rh: The old revision history
1852
    :param new_rh: The new revision history
1853
    :param to_file: A file to write the results to. If None, stdout will be used
1854
    """
1855
    if to_file is None:
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
1856
        to_file = codecs.getwriter(get_terminal_encoding())(sys.stdout,
1857
            errors='replace')
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1858
    lf = log_formatter(log_format,
1859
                       show_ids=False,
1860
                       to_file=to_file,
1861
                       show_timezone='original')
1862
1863
    # This is the first index which is different between
1864
    # old and new
1865
    base_idx = None
1866
    for i in xrange(max(len(new_rh),
1867
                        len(old_rh))):
1868
        if (len(new_rh) <= i
1869
            or len(old_rh) <= i
1870
            or new_rh[i] != old_rh[i]):
1871
            base_idx = i
1872
            break
1873
1874
    if base_idx is None:
1875
        to_file.write('Nothing seems to have changed\n')
1876
        return
1877
    ## TODO: It might be nice to do something like show_log
1878
    ##       and show the merged entries. But since this is the
1879
    ##       removed revisions, it shouldn't be as important
1880
    if base_idx < len(old_rh):
1881
        to_file.write('*'*60)
1882
        to_file.write('\nRemoved Revisions:\n')
1883
        for i in range(base_idx, len(old_rh)):
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
1884
            rev = branch.repository.get_revision(old_rh[i])
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1885
            lr = LogRevision(rev, i+1, 0, None)
1886
            lf.log_revision(lr)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1887
        to_file.write('*'*60)
1888
        to_file.write('\n\n')
1889
    if base_idx < len(new_rh):
1890
        to_file.write('Added Revisions:\n')
1891
        show_log(branch,
1892
                 lf,
1893
                 None,
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1894
                 verbose=False,
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1895
                 direction='forward',
1896
                 start_revision=base_idx+1,
1897
                 end_revision=len(new_rh),
1898
                 search=None)
1899
3144.7.4 by Guillermo Gonzalez
* move the function regisstry into a real Registry instead of a list
1900
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1901
def get_history_change(old_revision_id, new_revision_id, repository):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1902
    """Calculate the uncommon lefthand history between two revisions.
1903
1904
    :param old_revision_id: The original revision id.
1905
    :param new_revision_id: The new revision id.
3848.1.22 by Aaron Bentley
Fix spelling
1906
    :param repository: The repository to use for the calculation.
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1907
1908
    return old_history, new_history
1909
    """
3848.1.6 by Aaron Bentley
Implement get_history_change
1910
    old_history = []
1911
    old_revisions = set()
1912
    new_history = []
1913
    new_revisions = set()
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1914
    new_iter = repository.iter_reverse_revision_history(new_revision_id)
1915
    old_iter = repository.iter_reverse_revision_history(old_revision_id)
3848.1.6 by Aaron Bentley
Implement get_history_change
1916
    stop_revision = None
1917
    do_old = True
1918
    do_new = True
1919
    while do_new or do_old:
1920
        if do_new:
1921
            try:
1922
                new_revision = new_iter.next()
1923
            except StopIteration:
1924
                do_new = False
1925
            else:
1926
                new_history.append(new_revision)
1927
                new_revisions.add(new_revision)
1928
                if new_revision in old_revisions:
1929
                    stop_revision = new_revision
1930
                    break
1931
        if do_old:
1932
            try:
1933
                old_revision = old_iter.next()
1934
            except StopIteration:
1935
                do_old = False
1936
            else:
1937
                old_history.append(old_revision)
1938
                old_revisions.add(old_revision)
1939
                if old_revision in new_revisions:
1940
                    stop_revision = old_revision
1941
                    break
1942
    new_history.reverse()
1943
    old_history.reverse()
1944
    if stop_revision is not None:
1945
        new_history = new_history[new_history.index(stop_revision) + 1:]
1946
        old_history = old_history[old_history.index(stop_revision) + 1:]
1947
    return old_history, new_history
1948
1949
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1950
def show_branch_change(branch, output, old_revno, old_revision_id):
1951
    """Show the changes made to a branch.
1952
1953
    :param branch: The branch to show changes about.
1954
    :param output: A file-like object to write changes to.
1955
    :param old_revno: The revno of the old tip.
1956
    :param old_revision_id: The revision_id of the old tip.
1957
    """
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1958
    new_revno, new_revision_id = branch.last_revision_info()
1959
    old_history, new_history = get_history_change(old_revision_id,
1960
                                                  new_revision_id,
1961
                                                  branch.repository)
1962
    if old_history == [] and new_history == []:
1963
        output.write('Nothing seems to have changed\n')
1964
        return
1965
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1966
    log_format = log_formatter_registry.get_default(branch)
1967
    lf = log_format(show_ids=False, to_file=output, show_timezone='original')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1968
    if old_history != []:
1969
        output.write('*'*60)
1970
        output.write('\nRemoved Revisions:\n')
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1971
        show_flat_log(branch.repository, old_history, old_revno, lf)
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1972
        output.write('*'*60)
1973
        output.write('\n\n')
1974
    if new_history != []:
3848.1.9 by Aaron Bentley
new/old sections are omitted as appropriate.
1975
        output.write('Added Revisions:\n')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1976
        start_revno = new_revno - len(new_history) + 1
1977
        show_log(branch, lf, None, verbose=False, direction='forward',
1978
                 start_revision=start_revno,)
1979
1980
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1981
def show_flat_log(repository, history, last_revno, lf):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1982
    """Show a simple log of the specified history.
1983
1984
    :param repository: The repository to retrieve revisions from.
1985
    :param history: A list of revision_ids indicating the lefthand history.
1986
    :param last_revno: The revno of the last revision_id in the history.
1987
    :param lf: The log formatter to use.
1988
    """
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1989
    start_revno = last_revno - len(history) + 1
1990
    revisions = repository.get_revisions(history)
1991
    for i, rev in enumerate(revisions):
1992
        lr = LogRevision(rev, i + last_revno, 0, None)
1993
        lf.log_revision(lr)
1994
1995
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
1996
def _get_info_for_log_files(revisionspec_list, file_list, add_cleanup):
4202.2.1 by Ian Clatworthy
get directory logging working again
1997
    """Find file-ids and kinds given a list of files and a revision range.
1998
1999
    We search for files at the end of the range. If not found there,
2000
    we try the start of the range.
2001
2002
    :param revisionspec_list: revision range as parsed on the command line
2003
    :param file_list: the list of paths given on the command line;
2004
      the first of these can be a branch location or a file path,
2005
      the remainder must be file paths
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2006
    :param add_cleanup: When the branch returned is read locked,
2007
      an unlock call will be queued to the cleanup.
4202.2.1 by Ian Clatworthy
get directory logging working again
2008
    :return: (branch, info_list, start_rev_info, end_rev_info) where
2009
      info_list is a list of (relative_path, file_id, kind) tuples where
2010
      kind is one of values 'directory', 'file', 'symlink', 'tree-reference'.
4634.90.1 by Andrew Bennetts
Fix ObjectNotLocked error during 'bzr log' by acquiring branch read lock as soon as cmd_log acquires the branch, only releasing it at the end.
2011
      branch will be read-locked.
3943.6.4 by Ian Clatworthy
review feedback from vila
2012
    """
4202.2.1 by Ian Clatworthy
get directory logging working again
2013
    from builtins import _get_revision_range, safe_relpath_files
2014
    tree, b, path = bzrdir.BzrDir.open_containing_tree_or_branch(file_list[0])
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2015
    add_cleanup(b.lock_read().unlock)
4202.2.1 by Ian Clatworthy
get directory logging working again
2016
    # XXX: It's damn messy converting a list of paths to relative paths when
2017
    # those paths might be deleted ones, they might be on a case-insensitive
2018
    # filesystem and/or they might be in silly locations (like another branch).
2019
    # For example, what should "log bzr://branch/dir/file1 file2" do? (Is
2020
    # file2 implicitly in the same dir as file1 or should its directory be
2021
    # taken from the current tree somehow?) For now, this solves the common
2022
    # case of running log in a nested directory, assuming paths beyond the
2023
    # first one haven't been deleted ...
2024
    if tree:
2025
        relpaths = [path] + safe_relpath_files(tree, file_list[1:])
2026
    else:
2027
        relpaths = [path] + file_list[1:]
2028
    info_list = []
2029
    start_rev_info, end_rev_info = _get_revision_range(revisionspec_list, b,
2030
        "log")
4296.2.1 by Jelmer Vernooij
Don't retrieve the tree if log is called on the root.
2031
    if relpaths in ([], [u'']):
2032
        return b, [], start_rev_info, end_rev_info
4202.2.1 by Ian Clatworthy
get directory logging working again
2033
    if start_rev_info is None and end_rev_info is None:
3943.6.4 by Ian Clatworthy
review feedback from vila
2034
        if tree is None:
2035
            tree = b.basis_tree()
4202.2.1 by Ian Clatworthy
get directory logging working again
2036
        tree1 = None
2037
        for fp in relpaths:
2038
            file_id = tree.path2id(fp)
2039
            kind = _get_kind_for_file_id(tree, file_id)
2040
            if file_id is None:
2041
                # go back to when time began
2042
                if tree1 is None:
2043
                    try:
2044
                        rev1 = b.get_rev_id(1)
2045
                    except errors.NoSuchRevision:
2046
                        # No history at all
2047
                        file_id = None
2048
                        kind = None
2049
                    else:
2050
                        tree1 = b.repository.revision_tree(rev1)
2051
                if tree1:
2052
                    file_id = tree1.path2id(fp)
2053
                    kind = _get_kind_for_file_id(tree1, file_id)
2054
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2055
4202.2.1 by Ian Clatworthy
get directory logging working again
2056
    elif start_rev_info == end_rev_info:
3943.6.4 by Ian Clatworthy
review feedback from vila
2057
        # One revision given - file must exist in it
4202.2.1 by Ian Clatworthy
get directory logging working again
2058
        tree = b.repository.revision_tree(end_rev_info.rev_id)
2059
        for fp in relpaths:
2060
            file_id = tree.path2id(fp)
2061
            kind = _get_kind_for_file_id(tree, file_id)
2062
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2063
4202.2.1 by Ian Clatworthy
get directory logging working again
2064
    else:
3943.6.4 by Ian Clatworthy
review feedback from vila
2065
        # Revision range given. Get the file-id from the end tree.
2066
        # If that fails, try the start tree.
4202.2.1 by Ian Clatworthy
get directory logging working again
2067
        rev_id = end_rev_info.rev_id
3943.6.4 by Ian Clatworthy
review feedback from vila
2068
        if rev_id is None:
2069
            tree = b.basis_tree()
2070
        else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2071
            tree = b.repository.revision_tree(rev_id)
2072
        tree1 = None
2073
        for fp in relpaths:
3943.6.4 by Ian Clatworthy
review feedback from vila
2074
            file_id = tree.path2id(fp)
4202.2.1 by Ian Clatworthy
get directory logging working again
2075
            kind = _get_kind_for_file_id(tree, file_id)
2076
            if file_id is None:
2077
                if tree1 is None:
2078
                    rev_id = start_rev_info.rev_id
2079
                    if rev_id is None:
2080
                        rev1 = b.get_rev_id(1)
2081
                        tree1 = b.repository.revision_tree(rev1)
2082
                    else:
2083
                        tree1 = b.repository.revision_tree(rev_id)
2084
                file_id = tree1.path2id(fp)
2085
                kind = _get_kind_for_file_id(tree1, file_id)
2086
            info_list.append((fp, file_id, kind))
2087
    return b, info_list, start_rev_info, end_rev_info
2088
2089
2090
def _get_kind_for_file_id(tree, file_id):
2091
    """Return the kind of a file-id or None if it doesn't exist."""
2092
    if file_id is not None:
2093
        return tree.kind(file_id)
3943.6.4 by Ian Clatworthy
review feedback from vila
2094
    else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2095
        return None
3943.6.4 by Ian Clatworthy
review feedback from vila
2096
2097
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
2098
properties_handler_registry = registry.Registry()
3830.4.1 by Jelmer Vernooij
Add base classes for foreign branches.
2099
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2100
# Use the properties handlers to print out bug information if available
2101
def _bugs_properties_handler(revision):
2102
    if revision.properties.has_key('bugs'):
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2103
        bug_lines = revision.properties['bugs'].split('\n')
2104
        bug_rows = [line.split(' ', 1) for line in bug_lines]
2105
        fixed_bug_urls = [row[0] for row in bug_rows if
2106
                          len(row) > 1 and row[1] == 'fixed']
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
2107
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2108
        if fixed_bug_urls:
2109
            return {'fixes bug(s)': ' '.join(fixed_bug_urls)}
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2110
    return {}
2111
2112
properties_handler_registry.register('bugs_properties_handler',
2113
                                     _bugs_properties_handler)
2114
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2115
2116
# adapters which revision ids to log are filtered. When log is called, the
2117
# log_rev_iterator is adapted through each of these factory methods.
2118
# Plugins are welcome to mutate this list in any way they like - as long
2119
# as the overall behaviour is preserved. At this point there is no extensible
2120
# mechanism for getting parameters to each factory method, and until there is
2121
# this won't be considered a stable api.
2122
log_adapters = [
2123
    # core log logic
3642.1.7 by Robert Collins
Review feedback.
2124
    _make_batch_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2125
    # read revision objects
3642.1.7 by Robert Collins
Review feedback.
2126
    _make_revision_objects,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2127
    # filter on log messages
3642.1.7 by Robert Collins
Review feedback.
2128
    _make_search_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2129
    # generate deltas for things we will show
3642.1.7 by Robert Collins
Review feedback.
2130
    _make_delta_filter
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2131
    ]