~bzr-pqm/bzr/bzr.dev

4763.2.4 by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry.
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1551.8.30 by Aaron Bentley
Tweak from review comments
52
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
53
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
54
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
55
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
1551.8.30 by Aaron Bentley
Tweak from review comments
57
    tree,
58
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
59
from bzrlib.branch import Branch
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
60
from bzrlib.cleanup import OperationWithCleanups
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
61
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
62
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
63
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
64
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
65
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
66
from bzrlib.osutils import (get_user_encoding,
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
67
                            is_inside_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
68
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
69
                            splitpath,
70
                            )
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
71
from bzrlib.trace import mutter, note, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
72
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
73
from bzrlib import symbol_versioning
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
74
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
75
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
77
78
class NullCommitReporter(object):
79
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
80
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
81
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
82
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
83
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
84
                                   "to started.", DeprecationWarning,
85
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
86
        pass
87
88
    def snapshot_change(self, change, path):
89
        pass
90
91
    def completed(self, revno, rev_id):
92
        pass
93
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
94
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
95
        pass
96
97
    def missing(self, path):
98
        pass
99
100
    def renamed(self, change, old_path, new_path):
101
        pass
102
2789.2.11 by Ian Clatworthy
remove more reporting stuff
103
    def is_verbose(self):
104
        return False
105
106
107
class ReportCommitToLog(NullCommitReporter):
108
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
109
    def _note(self, format, *args):
110
        """Output a message.
111
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
112
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
113
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
114
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
115
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
116
    def snapshot_change(self, change, path):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
117
        if path == '' and change in ('added', 'modified'):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
118
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
119
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
120
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
121
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
122
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
123
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
124
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
125
            # When started was added, location was only made optional by
126
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
127
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
128
                                   "to started.", DeprecationWarning,
129
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
130
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
131
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
132
133
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
134
        self._note('Committed revision %d.', revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
135
        # self._note goes to the console too; so while we want to log the
136
        # rev_id, we can't trivially only log it. (See bug 526425). Long
137
        # term we should rearrange the reporting structure, but for now
138
        # we just mutter seperately. We mutter the revid and revno together
139
        # so that concurrent bzr invocations won't lead to confusion.
140
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
141
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
142
    def deleted(self, path):
143
        self._note('deleted %s', path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
144
145
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
146
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
148
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
149
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
150
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
151
    def is_verbose(self):
152
        return True
153
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
154
1189 by Martin Pool
- BROKEN: partial support for commit into weave
155
class Commit(object):
156
    """Task of committing a new revision.
157
158
    This is a MethodObject: it accumulates state as the commit is
159
    prepared, and then it is discarded.  It doesn't represent
160
    historical revisions, just the act of recording a new one.
161
162
            missing_ids
163
            Modified to hold a list of files that have been deleted from
164
            the working directory; these should be removed from the
165
            working inventory.
485 by Martin Pool
- move commit code into its own module
166
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
167
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
168
                 reporter=None,
169
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
170
        """Create a Commit object.
171
172
        :param reporter: the default reporter to use or None to decide later
173
        """
174
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
175
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
176
1189 by Martin Pool
- BROKEN: partial support for commit into weave
177
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
178
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
179
               timestamp=None,
180
               timezone=None,
181
               committer=None,
182
               specific_files=None,
183
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
184
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
185
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
186
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
187
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
188
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
189
               local=False,
190
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
191
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
192
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
193
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
194
               exclude=None,
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
195
               possible_master_transports=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
196
        """Commit working copy as a new revision.
197
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
198
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
199
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
200
201
        :param timestamp: if not None, seconds-since-epoch for a
202
            postdated/predated commit.
203
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
204
        :param specific_files: If not None, commit only those files. An empty
205
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
206
207
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
208
            Useful for test or import commands that need to tightly
209
            control what revisions are assigned.  If you duplicate
210
            a revision id that exists elsewhere it is your own fault.
211
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
212
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
213
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
214
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
215
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
216
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
217
            contains unknown files.
218
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
219
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
220
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
221
        :param reporter: the reporter to use or None for the default
222
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
223
        :param recursive: If set to 'down', commit in any subtrees that have
224
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
225
        :param exclude: None or a list of relative paths to exclude from the
226
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
227
            commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
228
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
229
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
230
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
231
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
232
        self.config = config or self.config
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
233
        return operation.run(
234
               message=message,
235
               timestamp=timestamp,
236
               timezone=timezone,
237
               committer=committer,
238
               specific_files=specific_files,
239
               rev_id=rev_id,
240
               allow_pointless=allow_pointless,
241
               strict=strict,
242
               verbose=verbose,
243
               working_tree=working_tree,
244
               local=local,
245
               reporter=reporter,
246
               message_callback=message_callback,
247
               recursive=recursive,
248
               exclude=exclude,
249
               possible_master_transports=possible_master_transports)
250
251
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
252
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
253
            working_tree, local, reporter, message_callback, recursive,
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
254
            exclude, possible_master_transports):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
255
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
256
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
257
        if working_tree is None:
258
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
259
        else:
260
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
261
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
262
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
263
                if not self.branch.repository.supports_rich_root():
264
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
265
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
266
            if message is not None:
267
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
268
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
269
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
270
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
271
                raise BzrError("The message or message_callback keyword"
272
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
273
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
274
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
275
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
276
        if exclude is not None:
277
            self.exclude = sorted(
278
                minimum_path_selection(exclude))
279
        else:
280
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
281
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
282
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
283
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
284
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
285
        # self.specific_files is None to indicate no filter, or any iterable to
286
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
287
        if specific_files is not None:
288
            self.specific_files = sorted(
289
                minimum_path_selection(specific_files))
290
        else:
291
            self.specific_files = None
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
292
            
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
293
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
294
        self.message_callback = message_callback
295
        self.timestamp = timestamp
296
        self.timezone = timezone
297
        self.committer = committer
298
        self.strict = strict
299
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
300
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
301
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
302
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
303
        self.parents = self.work_tree.get_parent_ids()
304
        # We can use record_iter_changes IFF iter_changes is compatible with
305
        # the command line parameters, and the repository has fast delta
306
        # generation. See bug 347649.
307
        self.use_record_iter_changes = (
308
            not self.exclude and 
309
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
310
            (self.branch.repository._format.fast_deltas or
311
             len(self.parents) < 2))
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
312
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
313
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
314
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
315
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
316
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
317
        operation.add_cleanup(self.basis_tree.unlock)
318
        # Cannot commit with conflicts present.
319
        if len(self.work_tree.conflicts()) > 0:
320
            raise ConflictsInTree
321
322
        # Setup the bound branch variables as needed.
323
        self._check_bound_branch(operation, possible_master_transports)
324
325
        # Check that the working tree is up to date
326
        old_revno, new_revno = self._check_out_of_date_tree()
327
328
        # Complete configuration setup
329
        if reporter is not None:
330
            self.reporter = reporter
331
        elif self.reporter is None:
332
            self.reporter = self._select_reporter()
333
        if self.config is None:
334
            self.config = self.branch.get_config()
335
336
        self._set_specific_file_ids()
337
338
        # Setup the progress bar. As the number of files that need to be
339
        # committed in unknown, progress is reported as stages.
340
        # We keep track of entries separately though and include that
341
        # information in the progress bar during the relevant stages.
342
        self.pb_stage_name = ""
343
        self.pb_stage_count = 0
344
        self.pb_stage_total = 5
345
        if self.bound_branch:
346
            self.pb_stage_total += 1
347
        self.pb.show_pct = False
348
        self.pb.show_spinner = False
349
        self.pb.show_eta = False
350
        self.pb.show_count = True
351
        self.pb.show_bar = True
352
353
        self._gather_parents()
354
        # After a merge, a selected file commit is not supported.
355
        # See 'bzr help merge' for an explanation as to why.
356
        if len(self.parents) > 1 and self.specific_files is not None:
357
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
358
        # Excludes are a form of selected file commit.
359
        if len(self.parents) > 1 and self.exclude:
360
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
361
362
        # Collect the changes
363
        self._set_progress_stage("Collecting changes", counter=True)
364
        self.builder = self.branch.get_commit_builder(self.parents,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
365
            self.config, timestamp, timezone, committer, self.revprops, rev_id)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
366
1189 by Martin Pool
- BROKEN: partial support for commit into weave
367
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
368
            self.builder.will_record_deletes()
369
            # find the location being committed to
370
            if self.bound_branch:
371
                master_location = self.master_branch.base
372
            else:
373
                master_location = self.branch.base
374
375
            # report the start of the commit
376
            self.reporter.started(new_revno, self.rev_id, master_location)
377
378
            self._update_builder_with_changes()
379
            self._check_pointless()
380
381
            # TODO: Now the new inventory is known, check for conflicts.
382
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
383
            # weave lines, because nothing should be recorded until it is known
384
            # that commit will succeed.
385
            self._set_progress_stage("Saving data locally")
386
            self.builder.finish_inventory()
387
388
            # Prompt the user for a commit message if none provided
389
            message = message_callback(self)
390
            self.message = message
391
392
            # Add revision data to the local branch
393
            self.rev_id = self.builder.commit(self.message)
394
395
        except Exception, e:
396
            mutter("aborting commit write group because of exception:")
397
            trace.log_exception_quietly()
398
            note("aborting commit write group: %r" % (e,))
399
            self.builder.abort()
400
            raise
401
402
        self._process_pre_hooks(old_revno, new_revno)
403
404
        # Upload revision data to the master.
405
        # this will propagate merged revisions too if needed.
406
        if self.bound_branch:
407
            self._set_progress_stage("Uploading data to master branch")
408
            # 'commit' to the master first so a timeout here causes the
409
            # local branch to be out of date
410
            self.master_branch.import_last_revision_info(
411
                self.branch.repository, new_revno, self.rev_id)
412
413
        # and now do the commit locally.
414
        self.branch.set_last_revision_info(new_revno, self.rev_id)
415
416
        # Make the working tree be up to date with the branch. This
417
        # includes automatic changes scheduled to be made to the tree, such
418
        # as updating its basis and unversioning paths that were missing.
419
        self.work_tree.unversion(self.deleted_ids)
420
        self._set_progress_stage("Updating the working tree")
421
        self.work_tree.update_basis_by_delta(self.rev_id,
422
             self.builder.get_basis_delta())
423
        self.reporter.completed(new_revno, self.rev_id)
424
        self._process_post_hooks(old_revno, new_revno)
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
425
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
426
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
427
    def _select_reporter(self):
428
        """Select the CommitReporter to use."""
429
        if is_quiet():
430
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
431
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
432
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
433
    def _check_pointless(self):
434
        if self.allow_pointless:
435
            return
436
        # A merge with no effect on files
437
        if len(self.parents) > 1:
438
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
439
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
440
2921.4.6 by Robert Collins
Typos found by Rob Weir.
441
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
442
        # a worthwhile commit.
443
        if (self.basis_revid == revision.NULL_REVISION and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
444
            ((self.builder.new_inventory is not None and
445
             len(self.builder.new_inventory) == 1) or
446
            len(self.builder._basis_delta) == 1)):
1731.1.49 by Aaron Bentley
Merge bzr.dev
447
            raise PointlessCommit()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
448
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
449
            return
450
        raise PointlessCommit()
451
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
452
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
453
        """Check to see if the local branch is bound.
454
455
        If it is bound, then most of the commit will actually be
456
        done using the remote branch as the target branch.
457
        Only at the end will the local branch be updated.
458
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
459
        if self.local and not self.branch.get_bound_location():
460
            raise errors.LocalRequiresBoundBranch()
461
462
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
463
            self.master_branch = self.branch.get_master_branch(
464
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
465
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
466
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
467
            # make this branch the reference branch for out of date checks.
468
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
469
            return
470
471
        # If the master branch is bound, we must fail
472
        master_bound_location = self.master_branch.get_bound_location()
473
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
474
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
475
                    self.master_branch, master_bound_location)
476
477
        # TODO: jam 20051230 We could automatically push local
478
        #       commits to the remote branch if they would fit.
479
        #       But for now, just require remote to be identical
480
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
481
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
482
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
483
        master_info = self.master_branch.last_revision_info()
484
        local_info = self.branch.last_revision_info()
485
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
486
            raise errors.BoundBranchOutOfDate(self.branch,
487
                    self.master_branch)
488
489
        # Now things are ready to change the master branch
490
        # so grab the lock
491
        self.bound_branch = self.branch
492
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
493
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
494
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
495
    def _check_out_of_date_tree(self):
496
        """Check that the working tree is up to date.
497
498
        :return: old_revision_number,new_revision_number tuple
499
        """
500
        try:
501
            first_tree_parent = self.work_tree.get_parent_ids()[0]
502
        except IndexError:
503
            # if there are no parents, treat our parent as 'None'
504
            # this is so that we still consider the master branch
505
            # - in a checkout scenario the tree may have no
506
            # parents but the branch may do.
507
            first_tree_parent = bzrlib.revision.NULL_REVISION
508
        old_revno, master_last = self.master_branch.last_revision_info()
509
        if master_last != first_tree_parent:
510
            if master_last != bzrlib.revision.NULL_REVISION:
511
                raise errors.OutOfDateTree(self.work_tree)
512
        if self.branch.repository.has_revision(first_tree_parent):
513
            new_revno = old_revno + 1
514
        else:
515
            # ghost parents never appear in revision history.
516
            new_revno = 1
517
        return old_revno,new_revno
518
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
519
    def _process_pre_hooks(self, old_revno, new_revno):
520
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
521
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
522
        self._process_hooks("pre_commit", old_revno, new_revno)
523
524
    def _process_post_hooks(self, old_revno, new_revno):
525
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
526
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
527
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
528
        # old style commit hooks - should be deprecated ? (obsoleted in
529
        # 0.15)
530
        if self.config.post_commit() is not None:
531
            hooks = self.config.post_commit().split(' ')
532
            # this would be nicer with twisted.python.reflect.namedAny
533
            for hook in hooks:
534
                result = eval(hook + '(branch, rev_id)',
535
                              {'branch':self.branch,
536
                               'bzrlib':bzrlib,
537
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
538
        # process new style post commit hooks
539
        self._process_hooks("post_commit", old_revno, new_revno)
540
541
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
542
        if not Branch.hooks[hook_name]:
543
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
544
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
545
        # new style commit hooks:
546
        if not self.bound_branch:
547
            hook_master = self.branch
548
            hook_local = None
549
        else:
550
            hook_master = self.master_branch
551
            hook_local = self.branch
552
        # With bound branches, when the master is behind the local branch,
553
        # the 'old_revno' and old_revid values here are incorrect.
554
        # XXX: FIXME ^. RBC 20060206
555
        if self.parents:
556
            old_revid = self.parents[0]
557
        else:
558
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
559
2659.3.9 by NamNguyen
branch.py:
560
        if hook_name == "pre_commit":
561
            future_tree = self.builder.revision_tree()
562
            tree_delta = future_tree.changes_from(self.basis_tree,
563
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
564
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
565
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
566
            # show the running hook in the progress bar. As hooks may
567
            # end up doing nothing (e.g. because they are not configured by
568
            # the user) this is still showing progress, not showing overall
569
            # actions - its up to each plugin to show a UI if it want's to
570
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
571
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
572
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
573
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
574
            if 'hooks' in debug.debug_flags:
575
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
576
            if hook_name == "post_commit":
577
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
578
                     self.rev_id)
579
            elif hook_name == "pre_commit":
580
                hook(hook_local, hook_master,
581
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
582
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
583
1223 by Martin Pool
- store inventories in weave
584
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
585
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
586
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
587
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
588
        if self.use_record_iter_changes:
589
            return
590
        self.basis_inv = self.basis_tree.inventory
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
591
        self.parent_invs = [self.basis_inv]
592
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
593
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
594
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
595
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
596
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
597
            else:
598
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
599
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
600
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
601
        """Update the commit builder with the data about what has changed.
602
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
603
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
604
        specific_files = self.specific_files
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
605
        mutter("Selecting files for commit with filter %s", specific_files)
606
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
607
        self._check_strict()
608
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
609
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
610
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
611
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
612
            for file_id, path, fs_hash in self.builder.record_iter_changes(
613
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
614
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
615
        else:
616
            # Build the new inventory
617
            self._populate_from_inventory()
618
            self._record_unselected()
619
            self._report_and_accumulate_deletes()
620
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
621
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
622
        """Process iter_changes.
623
624
        This method reports on the changes in iter_changes to the user, and 
625
        converts 'missing' entries in the iter_changes iterator to 'deleted'
626
        entries. 'missing' entries have their
627
628
        :param iter_changes: An iter_changes to process.
629
        :return: A generator of changes.
630
        """
631
        reporter = self.reporter
632
        report_changes = reporter.is_verbose()
633
        deleted_ids = []
634
        for change in iter_changes:
635
            if report_changes:
636
                old_path = change[1][0]
637
                new_path = change[1][1]
638
                versioned = change[3][1]
639
            kind = change[6][1]
640
            versioned = change[3][1]
641
            if kind is None and versioned:
642
                # 'missing' path
643
                if report_changes:
644
                    reporter.missing(new_path)
645
                deleted_ids.append(change[0])
646
                # Reset the new path (None) and new versioned flag (False)
647
                change = (change[0], (change[1][0], None), change[2],
648
                    (change[3][0], False)) + change[4:]
649
            elif kind == 'tree-reference':
650
                if self.recursive == 'down':
651
                    self._commit_nested_tree(change[0], change[1][1])
652
            if change[3][0] or change[3][1]:
653
                yield change
654
                if report_changes:
655
                    if new_path is None:
656
                        reporter.deleted(old_path)
657
                    elif old_path is None:
658
                        reporter.snapshot_change('added', new_path)
659
                    elif old_path != new_path:
660
                        reporter.renamed('renamed', old_path, new_path)
661
                    else:
662
                        if (new_path or 
663
                            self.work_tree.branch.repository._format.rich_root_data):
664
                            # Don't report on changes to '' in non rich root
665
                            # repositories.
666
                            reporter.snapshot_change('modified', new_path)
667
            self._next_progress_entry()
668
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
669
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
670
671
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
672
        # If specific files are selected, then all un-selected files must be
673
        # recorded in their previous state. For more details, see
674
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
675
        if self.specific_files or self.exclude:
676
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
677
            for path, old_ie in self.basis_inv.iter_entries():
678
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
679
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
680
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
681
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
682
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
683
                    # was inside the selected path, and not excluded - if not
684
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
685
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
686
                # From here down it was either not selected, or was excluded:
687
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
688
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
689
                # Note: specific file commits after a merge are currently
690
                # prohibited. This test is for sanity/safety in case it's
691
                # required after that changes.
692
                if len(self.parents) > 1:
693
                    ie.revision = None
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
694
                self.builder.record_entry_contents(ie, self.parent_invs, path,
695
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
696
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
697
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
698
        if (isinstance(self.basis_inv, Inventory)
699
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
700
            # the older Inventory classes provide a _byid dict, and building a
701
            # set from the keys of this dict is substantially faster than even
702
            # getting a set of ids from the inventory
703
            #
704
            # <lifeless> set(dict) is roughly the same speed as
705
            # set(iter(dict)) and both are significantly slower than
706
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
707
            deleted_ids = set(self.basis_inv._byid.keys()) - \
708
               set(self.builder.new_inventory._byid.keys())
709
        else:
710
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
711
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
712
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
713
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
714
                for file_id in deleted_ids]
715
            deleted.sort()
716
            # XXX: this is not quite directory-order sorting
717
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
718
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
719
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
720
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
721
    def _check_strict(self):
722
        # XXX: when we use iter_changes this would likely be faster if
723
        # iter_changes would check for us (even in the presence of
724
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
725
        if self.strict:
726
            # raise an exception as soon as we find a single unknown.
727
            for unknown in self.work_tree.unknowns():
728
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
729
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
730
    def _populate_from_inventory(self):
731
        """Populate the CommitBuilder by walking the working tree inventory."""
732
        # Build the revision inventory.
733
        #
734
        # This starts by creating a new empty inventory. Depending on
735
        # which files are selected for commit, and what is present in the
736
        # current tree, the new inventory is populated. inventory entries
737
        # which are candidates for modification have their revision set to
738
        # None; inventory entries that are carried over untouched have their
739
        # revision set to their prior value.
740
        #
741
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
742
        # results to create a new inventory at the same time, which results
743
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
744
        # ADHB 11-07-2006
745
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
746
        specific_files = self.specific_files
747
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
748
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
749
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
750
        # A tree of paths that have been deleted. E.g. if foo/bar has been
751
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
752
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
753
        # XXX: Note that entries may have the wrong kind because the entry does
754
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
755
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
756
        # NB: entries will include entries within the excluded ids/paths
757
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
758
        entries = work_inv.iter_entries_by_dir(
759
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
760
        for path, existing_ie in entries:
761
            file_id = existing_ie.file_id
762
            name = existing_ie.name
763
            parent_id = existing_ie.parent_id
764
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
765
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
766
            # The deleted path ids are also recorded so they can be explicitly
767
            # unversioned later.
768
            if deleted_paths:
769
                path_segments = splitpath(path)
770
                deleted_dict = deleted_paths
771
                for segment in path_segments:
772
                    deleted_dict = deleted_dict.get(segment, None)
773
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
774
                        # We either took a path not present in the dict
775
                        # (deleted_dict was None), or we've reached an empty
776
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
777
                        break
778
                else:
779
                    deleted_dict = None
780
                if deleted_dict is not None:
781
                    # the path has a deleted parent, do not add it.
782
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
783
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
784
                # Skip excluded paths. Excluded paths are processed by
785
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
786
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
787
            content_summary = self.work_tree.path_content_summary(path)
788
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
789
            # Note that when a filter of specific files is given, we must only
790
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
791
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
792
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
793
                    if not deleted_paths:
794
                        # path won't have been split yet.
795
                        path_segments = splitpath(path)
796
                    deleted_dict = deleted_paths
797
                    for segment in path_segments:
798
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
799
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
800
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
801
                    deleted_ids.append(file_id)
802
                    continue
4595.11.14 by Martin Pool
Small code cleanups
803
            # TODO: have the builder do the nested commit just-in-time IF and
804
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
805
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
806
                # enforce repository nested tree policy.
807
                if (not self.work_tree.supports_tree_reference() or
808
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
809
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
810
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
811
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
812
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
813
                    nested_revision_id = self._commit_nested_tree(
814
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
815
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
816
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
817
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
818
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
819
820
            # Record an entry for this item
821
            # Note: I don't particularly want to have the existing_ie
822
            # parameter but the test suite currently (28-Jun-07) breaks
823
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
824
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
825
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
826
                parent_id, definitely_changed, existing_ie, report_changes,
827
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
828
829
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
830
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
831
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
832
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
833
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
834
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
835
        # FIXME: be more comprehensive here:
836
        # this works when both trees are in --trees repository,
837
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
838
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
839
        # finally implement the explicit-caches approach design
840
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
841
        if sub_tree.branch.repository.has_same_location(
842
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
843
            sub_tree.branch.repository = \
844
                self.work_tree.branch.repository
845
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
846
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
847
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
848
                message_callback=self.message_callback,
849
                timestamp=self.timestamp, timezone=self.timezone,
850
                committer=self.committer,
851
                allow_pointless=self.allow_pointless,
852
                strict=self.strict, verbose=self.verbose,
853
                local=self.local, reporter=self.reporter)
854
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
855
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
856
857
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
858
        parent_id, definitely_changed, existing_ie, report_changes,
859
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
860
        "Record the new inventory entry for a path if any."
861
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
862
        # mutter('%s selected for commit', path)
863
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
864
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
865
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
866
            ie = existing_ie.copy()
867
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
868
        # For carried over entries we don't care about the fs hash - the repo
869
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
870
        _, _, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
871
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
872
        if report_changes:
873
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
874
        if fs_hash:
875
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
876
        return ie
877
878
    def _report_change(self, ie, path):
879
        """Report a change to the user.
880
881
        The change that has occurred is described relative to the basis
882
        inventory.
883
        """
884
        if (self.basis_inv.has_id(ie.file_id)):
885
            basis_ie = self.basis_inv[ie.file_id]
886
        else:
887
            basis_ie = None
888
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
889
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
890
            InventoryEntry.MODIFIED_AND_RENAMED):
891
            old_path = self.basis_inv.id2path(ie.file_id)
892
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
893
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
894
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
895
            if change == 'unchanged':
896
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
897
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
898
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
899
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
900
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
901
        """Set the progress stage and emit an update to the progress bar."""
902
        self.pb_stage_name = name
903
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
904
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
905
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
906
        else:
907
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
908
        self._emit_progress()
909
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
910
    def _next_progress_entry(self):
911
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
912
        self.pb_entries_count += 1
913
        self._emit_progress()
914
915
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
916
        if self.pb_entries_count is not None:
917
            text = "%s [%d] - Stage" % (self.pb_stage_name,
918
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
919
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
920
            text = "%s - Stage" % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
921
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
922
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
923
    def _set_specific_file_ids(self):
924
        """populate self.specific_file_ids if we will use it."""
925
        if not self.use_record_iter_changes:
926
            # If provided, ensure the specified files are versioned
927
            if self.specific_files is not None:
928
                # Note: This routine is being called because it raises
929
                # PathNotVersionedError as a side effect of finding the IDs. We
930
                # later use the ids we found as input to the working tree
931
                # inventory iterator, so we only consider those ids rather than
932
                # examining the whole tree again.
933
                # XXX: Dont we have filter_unversioned to do this more
934
                # cheaply?
935
                self.specific_file_ids = tree.find_ids_across_trees(
936
                    self.specific_files, [self.basis_tree, self.work_tree])
937
            else:
938
                self.specific_file_ids = None