~bzr-pqm/bzr/bzr.dev

4763.2.4 by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry.
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
62
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
63
    trace,
1551.8.30 by Aaron Bentley
Tweak from review comments
64
    tree,
4222.1.1 by Jelmer Vernooij
Make function for escaping invalid XML characters public.
65
    xml_serializer,
1551.8.30 by Aaron Bentley
Tweak from review comments
66
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
67
from bzrlib.branch import Branch
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
68
from bzrlib.cleanup import OperationWithCleanups
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
69
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
70
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
71
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
72
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
73
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
74
from bzrlib.osutils import (get_user_encoding,
75
                            kind_marker, isdir,isfile, is_inside_any,
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
76
                            is_inside_or_parent_of_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
77
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
78
                            quotefn, sha_file, split_lines,
79
                            splitpath,
80
                            )
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
81
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
82
from bzrlib.trace import mutter, note, warning, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
83
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
84
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
85
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
86
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
87
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
88
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
89
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
90
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
91
92
93
class NullCommitReporter(object):
94
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
95
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
96
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
97
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
98
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
99
                                   "to started.", DeprecationWarning,
100
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
101
        pass
102
103
    def snapshot_change(self, change, path):
104
        pass
105
106
    def completed(self, revno, rev_id):
107
        pass
108
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
109
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
110
        pass
111
112
    def missing(self, path):
113
        pass
114
115
    def renamed(self, change, old_path, new_path):
116
        pass
117
2789.2.11 by Ian Clatworthy
remove more reporting stuff
118
    def is_verbose(self):
119
        return False
120
121
122
class ReportCommitToLog(NullCommitReporter):
123
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
124
    def _note(self, format, *args):
125
        """Output a message.
126
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
127
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
128
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
129
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
130
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
131
    def snapshot_change(self, change, path):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
132
        if path == '' and change in ('added', 'modified'):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
133
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
134
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
135
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
136
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
137
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
138
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
139
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
140
            # When started was added, location was only made optional by
141
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
142
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
143
                                   "to started.", DeprecationWarning,
144
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
145
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
146
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
147
148
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
149
        self._note('Committed revision %d.', revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
150
        # self._note goes to the console too; so while we want to log the
151
        # rev_id, we can't trivially only log it. (See bug 526425). Long
152
        # term we should rearrange the reporting structure, but for now
153
        # we just mutter seperately. We mutter the revid and revno together
154
        # so that concurrent bzr invocations won't lead to confusion.
155
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
156
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
157
    def deleted(self, path):
158
        self._note('deleted %s', path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
159
160
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
161
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
162
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
163
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
164
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
165
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
166
    def is_verbose(self):
167
        return True
168
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
169
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
class Commit(object):
171
    """Task of committing a new revision.
172
173
    This is a MethodObject: it accumulates state as the commit is
174
    prepared, and then it is discarded.  It doesn't represent
175
    historical revisions, just the act of recording a new one.
176
177
            missing_ids
178
            Modified to hold a list of files that have been deleted from
179
            the working directory; these should be removed from the
180
            working inventory.
485 by Martin Pool
- move commit code into its own module
181
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
183
                 reporter=None,
184
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
185
        """Create a Commit object.
186
187
        :param reporter: the default reporter to use or None to decide later
188
        """
189
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
190
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
191
1189 by Martin Pool
- BROKEN: partial support for commit into weave
192
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
193
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
194
               timestamp=None,
195
               timezone=None,
196
               committer=None,
197
               specific_files=None,
198
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
199
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
200
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
201
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
202
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
203
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
204
               local=False,
205
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
206
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
207
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
208
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
209
               exclude=None,
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
210
               possible_master_transports=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
211
        """Commit working copy as a new revision.
212
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
213
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
214
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
215
216
        :param timestamp: if not None, seconds-since-epoch for a
217
            postdated/predated commit.
218
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
219
        :param specific_files: If not None, commit only those files. An empty
220
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
221
222
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
223
            Useful for test or import commands that need to tightly
224
            control what revisions are assigned.  If you duplicate
225
            a revision id that exists elsewhere it is your own fault.
226
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
227
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
228
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
229
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
230
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
231
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
232
            contains unknown files.
233
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
234
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
235
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
236
        :param reporter: the reporter to use or None for the default
237
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
238
        :param recursive: If set to 'down', commit in any subtrees that have
239
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
240
        :param exclude: None or a list of relative paths to exclude from the
241
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
242
            commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
243
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
244
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
245
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
246
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
247
        self.config = config or self.config
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
248
        return operation.run(
249
               message=message,
250
               timestamp=timestamp,
251
               timezone=timezone,
252
               committer=committer,
253
               specific_files=specific_files,
254
               rev_id=rev_id,
255
               allow_pointless=allow_pointless,
256
               strict=strict,
257
               verbose=verbose,
258
               working_tree=working_tree,
259
               local=local,
260
               reporter=reporter,
261
               message_callback=message_callback,
262
               recursive=recursive,
263
               exclude=exclude,
264
               possible_master_transports=possible_master_transports)
265
266
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
267
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
268
            working_tree, local, reporter, message_callback, recursive,
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
269
            exclude, possible_master_transports):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
270
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
271
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
272
        if working_tree is None:
273
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
274
        else:
275
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
276
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
277
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
278
                if not self.branch.repository.supports_rich_root():
279
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
280
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
281
            if message is not None:
282
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
283
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
284
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
285
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
286
                raise BzrError("The message or message_callback keyword"
287
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
288
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
289
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
290
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
291
        if exclude is not None:
292
            self.exclude = sorted(
293
                minimum_path_selection(exclude))
294
        else:
295
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
296
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
297
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
298
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
299
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
300
        # self.specific_files is None to indicate no filter, or any iterable to
301
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
302
        if specific_files is not None:
303
            self.specific_files = sorted(
304
                minimum_path_selection(specific_files))
305
        else:
306
            self.specific_files = None
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
307
            
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
308
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
309
        self.message_callback = message_callback
310
        self.timestamp = timestamp
311
        self.timezone = timezone
312
        self.committer = committer
313
        self.strict = strict
314
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
315
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
316
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
317
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
318
        self.parents = self.work_tree.get_parent_ids()
319
        # We can use record_iter_changes IFF iter_changes is compatible with
320
        # the command line parameters, and the repository has fast delta
321
        # generation. See bug 347649.
322
        self.use_record_iter_changes = (
323
            not self.exclude and 
324
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
325
            (self.branch.repository._format.fast_deltas or
326
             len(self.parents) < 2))
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
327
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
328
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
329
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
330
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
331
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
332
        operation.add_cleanup(self.basis_tree.unlock)
333
        # Cannot commit with conflicts present.
334
        if len(self.work_tree.conflicts()) > 0:
335
            raise ConflictsInTree
336
337
        # Setup the bound branch variables as needed.
338
        self._check_bound_branch(operation, possible_master_transports)
339
340
        # Check that the working tree is up to date
341
        old_revno, new_revno = self._check_out_of_date_tree()
342
343
        # Complete configuration setup
344
        if reporter is not None:
345
            self.reporter = reporter
346
        elif self.reporter is None:
347
            self.reporter = self._select_reporter()
348
        if self.config is None:
349
            self.config = self.branch.get_config()
350
351
        self._set_specific_file_ids()
352
353
        # Setup the progress bar. As the number of files that need to be
354
        # committed in unknown, progress is reported as stages.
355
        # We keep track of entries separately though and include that
356
        # information in the progress bar during the relevant stages.
357
        self.pb_stage_name = ""
358
        self.pb_stage_count = 0
359
        self.pb_stage_total = 5
360
        if self.bound_branch:
361
            self.pb_stage_total += 1
362
        self.pb.show_pct = False
363
        self.pb.show_spinner = False
364
        self.pb.show_eta = False
365
        self.pb.show_count = True
366
        self.pb.show_bar = True
367
368
        self._gather_parents()
369
        # After a merge, a selected file commit is not supported.
370
        # See 'bzr help merge' for an explanation as to why.
371
        if len(self.parents) > 1 and self.specific_files is not None:
372
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
373
        # Excludes are a form of selected file commit.
374
        if len(self.parents) > 1 and self.exclude:
375
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
376
377
        # Collect the changes
378
        self._set_progress_stage("Collecting changes", counter=True)
379
        self.builder = self.branch.get_commit_builder(self.parents,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
380
            self.config, timestamp, timezone, committer, self.revprops, rev_id)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
381
1189 by Martin Pool
- BROKEN: partial support for commit into weave
382
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
383
            self.builder.will_record_deletes()
384
            # find the location being committed to
385
            if self.bound_branch:
386
                master_location = self.master_branch.base
387
            else:
388
                master_location = self.branch.base
389
390
            # report the start of the commit
391
            self.reporter.started(new_revno, self.rev_id, master_location)
392
393
            self._update_builder_with_changes()
394
            self._check_pointless()
395
396
            # TODO: Now the new inventory is known, check for conflicts.
397
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
398
            # weave lines, because nothing should be recorded until it is known
399
            # that commit will succeed.
400
            self._set_progress_stage("Saving data locally")
401
            self.builder.finish_inventory()
402
403
            # Prompt the user for a commit message if none provided
404
            message = message_callback(self)
405
            self.message = message
406
407
            # Add revision data to the local branch
408
            self.rev_id = self.builder.commit(self.message)
409
410
        except Exception, e:
411
            mutter("aborting commit write group because of exception:")
412
            trace.log_exception_quietly()
413
            note("aborting commit write group: %r" % (e,))
414
            self.builder.abort()
415
            raise
416
417
        self._process_pre_hooks(old_revno, new_revno)
418
419
        # Upload revision data to the master.
420
        # this will propagate merged revisions too if needed.
421
        if self.bound_branch:
422
            self._set_progress_stage("Uploading data to master branch")
423
            # 'commit' to the master first so a timeout here causes the
424
            # local branch to be out of date
425
            self.master_branch.import_last_revision_info(
426
                self.branch.repository, new_revno, self.rev_id)
427
428
        # and now do the commit locally.
429
        self.branch.set_last_revision_info(new_revno, self.rev_id)
430
431
        # Make the working tree be up to date with the branch. This
432
        # includes automatic changes scheduled to be made to the tree, such
433
        # as updating its basis and unversioning paths that were missing.
434
        self.work_tree.unversion(self.deleted_ids)
435
        self._set_progress_stage("Updating the working tree")
436
        self.work_tree.update_basis_by_delta(self.rev_id,
437
             self.builder.get_basis_delta())
438
        self.reporter.completed(new_revno, self.rev_id)
439
        self._process_post_hooks(old_revno, new_revno)
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
440
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
441
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
442
    def _select_reporter(self):
443
        """Select the CommitReporter to use."""
444
        if is_quiet():
445
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
446
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
447
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
448
    def _check_pointless(self):
449
        if self.allow_pointless:
450
            return
451
        # A merge with no effect on files
452
        if len(self.parents) > 1:
453
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
454
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
455
2921.4.6 by Robert Collins
Typos found by Rob Weir.
456
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
457
        # a worthwhile commit.
458
        if (self.basis_revid == revision.NULL_REVISION and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
459
            ((self.builder.new_inventory is not None and
460
             len(self.builder.new_inventory) == 1) or
461
            len(self.builder._basis_delta) == 1)):
1731.1.49 by Aaron Bentley
Merge bzr.dev
462
            raise PointlessCommit()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
463
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
464
            return
465
        raise PointlessCommit()
466
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
467
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
468
        """Check to see if the local branch is bound.
469
470
        If it is bound, then most of the commit will actually be
471
        done using the remote branch as the target branch.
472
        Only at the end will the local branch be updated.
473
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
474
        if self.local and not self.branch.get_bound_location():
475
            raise errors.LocalRequiresBoundBranch()
476
477
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
478
            self.master_branch = self.branch.get_master_branch(
479
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
480
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
481
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
482
            # make this branch the reference branch for out of date checks.
483
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
484
            return
485
486
        # If the master branch is bound, we must fail
487
        master_bound_location = self.master_branch.get_bound_location()
488
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
489
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
490
                    self.master_branch, master_bound_location)
491
492
        # TODO: jam 20051230 We could automatically push local
493
        #       commits to the remote branch if they would fit.
494
        #       But for now, just require remote to be identical
495
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
496
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
497
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
498
        master_info = self.master_branch.last_revision_info()
499
        local_info = self.branch.last_revision_info()
500
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
501
            raise errors.BoundBranchOutOfDate(self.branch,
502
                    self.master_branch)
503
504
        # Now things are ready to change the master branch
505
        # so grab the lock
506
        self.bound_branch = self.branch
507
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
508
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
509
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
510
    def _check_out_of_date_tree(self):
511
        """Check that the working tree is up to date.
512
513
        :return: old_revision_number,new_revision_number tuple
514
        """
515
        try:
516
            first_tree_parent = self.work_tree.get_parent_ids()[0]
517
        except IndexError:
518
            # if there are no parents, treat our parent as 'None'
519
            # this is so that we still consider the master branch
520
            # - in a checkout scenario the tree may have no
521
            # parents but the branch may do.
522
            first_tree_parent = bzrlib.revision.NULL_REVISION
523
        old_revno, master_last = self.master_branch.last_revision_info()
524
        if master_last != first_tree_parent:
525
            if master_last != bzrlib.revision.NULL_REVISION:
526
                raise errors.OutOfDateTree(self.work_tree)
527
        if self.branch.repository.has_revision(first_tree_parent):
528
            new_revno = old_revno + 1
529
        else:
530
            # ghost parents never appear in revision history.
531
            new_revno = 1
532
        return old_revno,new_revno
533
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
534
    def _process_pre_hooks(self, old_revno, new_revno):
535
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
536
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
537
        self._process_hooks("pre_commit", old_revno, new_revno)
538
539
    def _process_post_hooks(self, old_revno, new_revno):
540
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
541
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
542
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
543
        # old style commit hooks - should be deprecated ? (obsoleted in
544
        # 0.15)
545
        if self.config.post_commit() is not None:
546
            hooks = self.config.post_commit().split(' ')
547
            # this would be nicer with twisted.python.reflect.namedAny
548
            for hook in hooks:
549
                result = eval(hook + '(branch, rev_id)',
550
                              {'branch':self.branch,
551
                               'bzrlib':bzrlib,
552
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
553
        # process new style post commit hooks
554
        self._process_hooks("post_commit", old_revno, new_revno)
555
556
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
557
        if not Branch.hooks[hook_name]:
558
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
559
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
560
        # new style commit hooks:
561
        if not self.bound_branch:
562
            hook_master = self.branch
563
            hook_local = None
564
        else:
565
            hook_master = self.master_branch
566
            hook_local = self.branch
567
        # With bound branches, when the master is behind the local branch,
568
        # the 'old_revno' and old_revid values here are incorrect.
569
        # XXX: FIXME ^. RBC 20060206
570
        if self.parents:
571
            old_revid = self.parents[0]
572
        else:
573
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
574
2659.3.9 by NamNguyen
branch.py:
575
        if hook_name == "pre_commit":
576
            future_tree = self.builder.revision_tree()
577
            tree_delta = future_tree.changes_from(self.basis_tree,
578
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
579
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
580
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
581
            # show the running hook in the progress bar. As hooks may
582
            # end up doing nothing (e.g. because they are not configured by
583
            # the user) this is still showing progress, not showing overall
584
            # actions - its up to each plugin to show a UI if it want's to
585
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
586
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
587
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
588
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
589
            if 'hooks' in debug.debug_flags:
590
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
591
            if hook_name == "post_commit":
592
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
593
                     self.rev_id)
594
            elif hook_name == "pre_commit":
595
                hook(hook_local, hook_master,
596
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
597
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
598
1223 by Martin Pool
- store inventories in weave
599
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
600
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
601
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
602
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
603
        if self.use_record_iter_changes:
604
            return
605
        self.basis_inv = self.basis_tree.inventory
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
606
        self.parent_invs = [self.basis_inv]
607
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
608
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
609
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
610
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
611
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
612
            else:
613
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
614
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
615
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
616
        """Update the commit builder with the data about what has changed.
617
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
618
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
619
        specific_files = self.specific_files
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
620
        mutter("Selecting files for commit with filter %s", specific_files)
621
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
622
        self._check_strict()
623
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
624
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
625
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
626
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
627
            for file_id, path, fs_hash in self.builder.record_iter_changes(
628
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
629
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
630
        else:
631
            # Build the new inventory
632
            self._populate_from_inventory()
633
            self._record_unselected()
634
            self._report_and_accumulate_deletes()
635
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
636
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
637
        """Process iter_changes.
638
639
        This method reports on the changes in iter_changes to the user, and 
640
        converts 'missing' entries in the iter_changes iterator to 'deleted'
641
        entries. 'missing' entries have their
642
643
        :param iter_changes: An iter_changes to process.
644
        :return: A generator of changes.
645
        """
646
        reporter = self.reporter
647
        report_changes = reporter.is_verbose()
648
        deleted_ids = []
649
        for change in iter_changes:
650
            if report_changes:
651
                old_path = change[1][0]
652
                new_path = change[1][1]
653
                versioned = change[3][1]
654
            kind = change[6][1]
655
            versioned = change[3][1]
656
            if kind is None and versioned:
657
                # 'missing' path
658
                if report_changes:
659
                    reporter.missing(new_path)
660
                deleted_ids.append(change[0])
661
                # Reset the new path (None) and new versioned flag (False)
662
                change = (change[0], (change[1][0], None), change[2],
663
                    (change[3][0], False)) + change[4:]
664
            elif kind == 'tree-reference':
665
                if self.recursive == 'down':
666
                    self._commit_nested_tree(change[0], change[1][1])
667
            if change[3][0] or change[3][1]:
668
                yield change
669
                if report_changes:
670
                    if new_path is None:
671
                        reporter.deleted(old_path)
672
                    elif old_path is None:
673
                        reporter.snapshot_change('added', new_path)
674
                    elif old_path != new_path:
675
                        reporter.renamed('renamed', old_path, new_path)
676
                    else:
677
                        if (new_path or 
678
                            self.work_tree.branch.repository._format.rich_root_data):
679
                            # Don't report on changes to '' in non rich root
680
                            # repositories.
681
                            reporter.snapshot_change('modified', new_path)
682
            self._next_progress_entry()
683
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
684
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
685
686
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
687
        # If specific files are selected, then all un-selected files must be
688
        # recorded in their previous state. For more details, see
689
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
690
        if self.specific_files or self.exclude:
691
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
692
            for path, old_ie in self.basis_inv.iter_entries():
693
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
694
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
695
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
696
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
697
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
698
                    # was inside the selected path, and not excluded - if not
699
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
700
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
701
                # From here down it was either not selected, or was excluded:
702
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
703
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
704
                # Note: specific file commits after a merge are currently
705
                # prohibited. This test is for sanity/safety in case it's
706
                # required after that changes.
707
                if len(self.parents) > 1:
708
                    ie.revision = None
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
709
                self.builder.record_entry_contents(ie, self.parent_invs, path,
710
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
711
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
712
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
713
        if (isinstance(self.basis_inv, Inventory)
714
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
715
            # the older Inventory classes provide a _byid dict, and building a
716
            # set from the keys of this dict is substantially faster than even
717
            # getting a set of ids from the inventory
718
            #
719
            # <lifeless> set(dict) is roughly the same speed as
720
            # set(iter(dict)) and both are significantly slower than
721
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
722
            deleted_ids = set(self.basis_inv._byid.keys()) - \
723
               set(self.builder.new_inventory._byid.keys())
724
        else:
725
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
726
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
727
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
728
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
729
                for file_id in deleted_ids]
730
            deleted.sort()
731
            # XXX: this is not quite directory-order sorting
732
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
733
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
734
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
735
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
736
    def _check_strict(self):
737
        # XXX: when we use iter_changes this would likely be faster if
738
        # iter_changes would check for us (even in the presence of
739
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
740
        if self.strict:
741
            # raise an exception as soon as we find a single unknown.
742
            for unknown in self.work_tree.unknowns():
743
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
744
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
745
    def _populate_from_inventory(self):
746
        """Populate the CommitBuilder by walking the working tree inventory."""
747
        # Build the revision inventory.
748
        #
749
        # This starts by creating a new empty inventory. Depending on
750
        # which files are selected for commit, and what is present in the
751
        # current tree, the new inventory is populated. inventory entries
752
        # which are candidates for modification have their revision set to
753
        # None; inventory entries that are carried over untouched have their
754
        # revision set to their prior value.
755
        #
756
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
757
        # results to create a new inventory at the same time, which results
758
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
759
        # ADHB 11-07-2006
760
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
761
        specific_files = self.specific_files
762
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
763
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
764
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
765
        # A tree of paths that have been deleted. E.g. if foo/bar has been
766
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
767
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
768
        # XXX: Note that entries may have the wrong kind because the entry does
769
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
770
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
771
        # NB: entries will include entries within the excluded ids/paths
772
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
773
        entries = work_inv.iter_entries_by_dir(
774
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
775
        for path, existing_ie in entries:
776
            file_id = existing_ie.file_id
777
            name = existing_ie.name
778
            parent_id = existing_ie.parent_id
779
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
780
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
781
            # The deleted path ids are also recorded so they can be explicitly
782
            # unversioned later.
783
            if deleted_paths:
784
                path_segments = splitpath(path)
785
                deleted_dict = deleted_paths
786
                for segment in path_segments:
787
                    deleted_dict = deleted_dict.get(segment, None)
788
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
789
                        # We either took a path not present in the dict
790
                        # (deleted_dict was None), or we've reached an empty
791
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
792
                        break
793
                else:
794
                    deleted_dict = None
795
                if deleted_dict is not None:
796
                    # the path has a deleted parent, do not add it.
797
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
798
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
799
                # Skip excluded paths. Excluded paths are processed by
800
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
801
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
802
            content_summary = self.work_tree.path_content_summary(path)
803
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
804
            # Note that when a filter of specific files is given, we must only
805
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
806
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
807
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
808
                    if not deleted_paths:
809
                        # path won't have been split yet.
810
                        path_segments = splitpath(path)
811
                    deleted_dict = deleted_paths
812
                    for segment in path_segments:
813
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
814
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
815
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
816
                    deleted_ids.append(file_id)
817
                    continue
4595.11.14 by Martin Pool
Small code cleanups
818
            # TODO: have the builder do the nested commit just-in-time IF and
819
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
820
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
821
                # enforce repository nested tree policy.
822
                if (not self.work_tree.supports_tree_reference() or
823
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
824
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
825
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
826
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
827
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
828
                    nested_revision_id = self._commit_nested_tree(
829
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
830
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
831
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
832
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
833
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
834
835
            # Record an entry for this item
836
            # Note: I don't particularly want to have the existing_ie
837
            # parameter but the test suite currently (28-Jun-07) breaks
838
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
839
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
840
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
841
                parent_id, definitely_changed, existing_ie, report_changes,
842
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
843
844
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
845
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
846
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
847
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
848
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
849
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
850
        # FIXME: be more comprehensive here:
851
        # this works when both trees are in --trees repository,
852
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
853
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
854
        # finally implement the explicit-caches approach design
855
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
856
        if sub_tree.branch.repository.has_same_location(
857
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
858
            sub_tree.branch.repository = \
859
                self.work_tree.branch.repository
860
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
861
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
862
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
863
                message_callback=self.message_callback,
864
                timestamp=self.timestamp, timezone=self.timezone,
865
                committer=self.committer,
866
                allow_pointless=self.allow_pointless,
867
                strict=self.strict, verbose=self.verbose,
868
                local=self.local, reporter=self.reporter)
869
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
870
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
871
872
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
873
        parent_id, definitely_changed, existing_ie, report_changes,
874
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
875
        "Record the new inventory entry for a path if any."
876
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
877
        # mutter('%s selected for commit', path)
878
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
879
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
880
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
881
            ie = existing_ie.copy()
882
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
883
        # For carried over entries we don't care about the fs hash - the repo
884
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
885
        _, _, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
886
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
887
        if report_changes:
888
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
889
        if fs_hash:
890
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
891
        return ie
892
893
    def _report_change(self, ie, path):
894
        """Report a change to the user.
895
896
        The change that has occurred is described relative to the basis
897
        inventory.
898
        """
899
        if (self.basis_inv.has_id(ie.file_id)):
900
            basis_ie = self.basis_inv[ie.file_id]
901
        else:
902
            basis_ie = None
903
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
904
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
905
            InventoryEntry.MODIFIED_AND_RENAMED):
906
            old_path = self.basis_inv.id2path(ie.file_id)
907
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
908
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
909
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
910
            if change == 'unchanged':
911
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
912
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
913
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
914
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
915
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
916
        """Set the progress stage and emit an update to the progress bar."""
917
        self.pb_stage_name = name
918
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
919
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
920
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
921
        else:
922
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
923
        self._emit_progress()
924
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
925
    def _next_progress_entry(self):
926
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
927
        self.pb_entries_count += 1
928
        self._emit_progress()
929
930
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
931
        if self.pb_entries_count is not None:
932
            text = "%s [%d] - Stage" % (self.pb_stage_name,
933
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
934
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
935
            text = "%s - Stage" % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
936
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
937
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
938
    def _set_specific_file_ids(self):
939
        """populate self.specific_file_ids if we will use it."""
940
        if not self.use_record_iter_changes:
941
            # If provided, ensure the specified files are versioned
942
            if self.specific_files is not None:
943
                # Note: This routine is being called because it raises
944
                # PathNotVersionedError as a side effect of finding the IDs. We
945
                # later use the ids we found as input to the working tree
946
                # inventory iterator, so we only consider those ids rather than
947
                # examining the whole tree again.
948
                # XXX: Dont we have filter_unversioned to do this more
949
                # cheaply?
950
                self.specific_file_ids = tree.find_ids_across_trees(
951
                    self.specific_files, [self.basis_tree, self.work_tree])
952
            else:
953
                self.specific_file_ids = None