~bzr-pqm/bzr/bzr.dev

4763.2.4 by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry.
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1551.8.30 by Aaron Bentley
Tweak from review comments
52
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
53
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
54
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
55
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
1551.8.30 by Aaron Bentley
Tweak from review comments
57
    tree,
58
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
59
from bzrlib.branch import Branch
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
60
from bzrlib.cleanup import OperationWithCleanups
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
61
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
62
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
63
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
64
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
65
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
66
from bzrlib.osutils import (get_user_encoding,
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
67
                            is_inside_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
68
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
69
                            splitpath,
70
                            )
5121.2.4 by Jelmer Vernooij
Remove more unused imports.
71
from bzrlib.trace import mutter, note, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
72
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
73
from bzrlib import symbol_versioning
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
74
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
75
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
77
78
class NullCommitReporter(object):
79
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
80
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
81
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
82
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
83
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
84
                                   "to started.", DeprecationWarning,
85
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
86
        pass
87
88
    def snapshot_change(self, change, path):
89
        pass
90
91
    def completed(self, revno, rev_id):
92
        pass
93
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
94
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
95
        pass
96
97
    def missing(self, path):
98
        pass
99
100
    def renamed(self, change, old_path, new_path):
101
        pass
102
2789.2.11 by Ian Clatworthy
remove more reporting stuff
103
    def is_verbose(self):
104
        return False
105
106
107
class ReportCommitToLog(NullCommitReporter):
108
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
109
    def _note(self, format, *args):
110
        """Output a message.
111
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
112
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
113
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
114
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
115
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
116
    def snapshot_change(self, change, path):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
117
        if path == '' and change in ('added', 'modified'):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
118
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
119
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
120
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
121
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
122
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
123
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
124
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
125
            # When started was added, location was only made optional by
126
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
127
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
128
                                   "to started.", DeprecationWarning,
129
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
130
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
131
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
132
133
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
134
        self._note('Committed revision %d.', revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
135
        # self._note goes to the console too; so while we want to log the
136
        # rev_id, we can't trivially only log it. (See bug 526425). Long
137
        # term we should rearrange the reporting structure, but for now
138
        # we just mutter seperately. We mutter the revid and revno together
139
        # so that concurrent bzr invocations won't lead to confusion.
140
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
141
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
142
    def deleted(self, path):
143
        self._note('deleted %s', path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
144
145
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
146
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
148
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
149
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
150
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
151
    def is_verbose(self):
152
        return True
153
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
154
1189 by Martin Pool
- BROKEN: partial support for commit into weave
155
class Commit(object):
156
    """Task of committing a new revision.
157
158
    This is a MethodObject: it accumulates state as the commit is
159
    prepared, and then it is discarded.  It doesn't represent
160
    historical revisions, just the act of recording a new one.
161
162
            missing_ids
163
            Modified to hold a list of files that have been deleted from
164
            the working directory; these should be removed from the
165
            working inventory.
485 by Martin Pool
- move commit code into its own module
166
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
167
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
168
                 reporter=None,
169
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
170
        """Create a Commit object.
171
172
        :param reporter: the default reporter to use or None to decide later
173
        """
174
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
175
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
176
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
177
    @staticmethod
178
    def update_revprops(revprops, branch, authors=None, author=None,
179
                        local=False, possible_master_transports=None):
180
        if revprops is None:
181
            revprops = {}
182
        if possible_master_transports is None:
183
            possible_master_transports = []
184
        if not 'branch-nick' in revprops:
185
            revprops['branch-nick'] = branch._get_nick(
186
                local,
187
                possible_master_transports)
188
        if authors is not None:
189
            if author is not None:
190
                raise AssertionError('Specifying both author and authors '
191
                        'is not allowed. Specify just authors instead')
192
            if 'author' in revprops or 'authors' in revprops:
193
                # XXX: maybe we should just accept one of them?
194
                raise AssertionError('author property given twice')
195
            if authors:
196
                for individual in authors:
197
                    if '\n' in individual:
198
                        raise AssertionError('\\n is not a valid character '
199
                                'in an author identity')
200
                revprops['authors'] = '\n'.join(authors)
201
        if author is not None:
202
            symbol_versioning.warn('The parameter author was deprecated'
203
                   ' in version 1.13. Use authors instead',
204
                   DeprecationWarning)
205
            if 'author' in revprops or 'authors' in revprops:
206
                # XXX: maybe we should just accept one of them?
207
                raise AssertionError('author property given twice')
208
            if '\n' in author:
209
                raise AssertionError('\\n is not a valid character '
210
                        'in an author identity')
211
            revprops['authors'] = author
212
        return revprops
213
1189 by Martin Pool
- BROKEN: partial support for commit into weave
214
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
215
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
216
               timestamp=None,
217
               timezone=None,
218
               committer=None,
219
               specific_files=None,
220
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
221
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
222
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
223
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
224
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
225
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
226
               local=False,
227
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
228
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
229
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
230
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
231
               exclude=None,
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
232
               possible_master_transports=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
233
        """Commit working copy as a new revision.
234
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
235
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
236
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
237
238
        :param timestamp: if not None, seconds-since-epoch for a
239
            postdated/predated commit.
240
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
241
        :param specific_files: If not None, commit only those files. An empty
242
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
243
244
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
245
            Useful for test or import commands that need to tightly
246
            control what revisions are assigned.  If you duplicate
247
            a revision id that exists elsewhere it is your own fault.
248
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
249
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
250
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
251
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
252
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
253
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
254
            contains unknown files.
255
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
256
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
257
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
258
        :param reporter: the reporter to use or None for the default
259
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
260
        :param recursive: If set to 'down', commit in any subtrees that have
261
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
262
        :param exclude: None or a list of relative paths to exclude from the
263
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
264
            commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
265
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
266
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
267
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
268
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
269
        self.config = config or self.config
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
270
        return operation.run(
271
               message=message,
272
               timestamp=timestamp,
273
               timezone=timezone,
274
               committer=committer,
275
               specific_files=specific_files,
276
               rev_id=rev_id,
277
               allow_pointless=allow_pointless,
278
               strict=strict,
279
               verbose=verbose,
280
               working_tree=working_tree,
281
               local=local,
282
               reporter=reporter,
283
               message_callback=message_callback,
284
               recursive=recursive,
285
               exclude=exclude,
286
               possible_master_transports=possible_master_transports)
287
288
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
289
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
290
            working_tree, local, reporter, message_callback, recursive,
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
291
            exclude, possible_master_transports):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
292
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
293
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
294
        if working_tree is None:
295
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
296
        else:
297
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
298
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
299
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
300
                if not self.branch.repository.supports_rich_root():
301
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
302
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
303
            if message is not None:
304
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
305
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
306
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
307
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
308
                raise BzrError("The message or message_callback keyword"
309
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
310
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
311
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
312
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
313
        if exclude is not None:
314
            self.exclude = sorted(
315
                minimum_path_selection(exclude))
316
        else:
317
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
318
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
319
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
320
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
321
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
322
        # self.specific_files is None to indicate no filter, or any iterable to
323
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
324
        if specific_files is not None:
325
            self.specific_files = sorted(
326
                minimum_path_selection(specific_files))
327
        else:
328
            self.specific_files = None
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
329
            
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
330
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
331
        self.message_callback = message_callback
332
        self.timestamp = timestamp
333
        self.timezone = timezone
334
        self.committer = committer
335
        self.strict = strict
336
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
337
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
338
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
339
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
340
        self.parents = self.work_tree.get_parent_ids()
341
        # We can use record_iter_changes IFF iter_changes is compatible with
342
        # the command line parameters, and the repository has fast delta
343
        # generation. See bug 347649.
344
        self.use_record_iter_changes = (
345
            not self.exclude and 
346
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
347
            (self.branch.repository._format.fast_deltas or
348
             len(self.parents) < 2))
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
349
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
350
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
351
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
352
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
353
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
354
        operation.add_cleanup(self.basis_tree.unlock)
355
        # Cannot commit with conflicts present.
356
        if len(self.work_tree.conflicts()) > 0:
357
            raise ConflictsInTree
358
359
        # Setup the bound branch variables as needed.
360
        self._check_bound_branch(operation, possible_master_transports)
361
362
        # Check that the working tree is up to date
363
        old_revno, new_revno = self._check_out_of_date_tree()
364
365
        # Complete configuration setup
366
        if reporter is not None:
367
            self.reporter = reporter
368
        elif self.reporter is None:
369
            self.reporter = self._select_reporter()
370
        if self.config is None:
371
            self.config = self.branch.get_config()
372
373
        self._set_specific_file_ids()
374
375
        # Setup the progress bar. As the number of files that need to be
376
        # committed in unknown, progress is reported as stages.
377
        # We keep track of entries separately though and include that
378
        # information in the progress bar during the relevant stages.
379
        self.pb_stage_name = ""
380
        self.pb_stage_count = 0
381
        self.pb_stage_total = 5
382
        if self.bound_branch:
383
            self.pb_stage_total += 1
384
        self.pb.show_pct = False
385
        self.pb.show_spinner = False
386
        self.pb.show_eta = False
387
        self.pb.show_count = True
388
        self.pb.show_bar = True
389
390
        self._gather_parents()
391
        # After a merge, a selected file commit is not supported.
392
        # See 'bzr help merge' for an explanation as to why.
393
        if len(self.parents) > 1 and self.specific_files is not None:
394
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
395
        # Excludes are a form of selected file commit.
396
        if len(self.parents) > 1 and self.exclude:
397
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
398
399
        # Collect the changes
400
        self._set_progress_stage("Collecting changes", counter=True)
401
        self.builder = self.branch.get_commit_builder(self.parents,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
402
            self.config, timestamp, timezone, committer, self.revprops, rev_id)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
403
1189 by Martin Pool
- BROKEN: partial support for commit into weave
404
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
405
            self.builder.will_record_deletes()
406
            # find the location being committed to
407
            if self.bound_branch:
408
                master_location = self.master_branch.base
409
            else:
410
                master_location = self.branch.base
411
412
            # report the start of the commit
413
            self.reporter.started(new_revno, self.rev_id, master_location)
414
415
            self._update_builder_with_changes()
416
            self._check_pointless()
417
418
            # TODO: Now the new inventory is known, check for conflicts.
419
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
420
            # weave lines, because nothing should be recorded until it is known
421
            # that commit will succeed.
422
            self._set_progress_stage("Saving data locally")
423
            self.builder.finish_inventory()
424
425
            # Prompt the user for a commit message if none provided
426
            message = message_callback(self)
427
            self.message = message
428
429
            # Add revision data to the local branch
430
            self.rev_id = self.builder.commit(self.message)
431
432
        except Exception, e:
433
            mutter("aborting commit write group because of exception:")
434
            trace.log_exception_quietly()
435
            note("aborting commit write group: %r" % (e,))
436
            self.builder.abort()
437
            raise
438
439
        self._process_pre_hooks(old_revno, new_revno)
440
441
        # Upload revision data to the master.
442
        # this will propagate merged revisions too if needed.
443
        if self.bound_branch:
444
            self._set_progress_stage("Uploading data to master branch")
445
            # 'commit' to the master first so a timeout here causes the
446
            # local branch to be out of date
447
            self.master_branch.import_last_revision_info(
448
                self.branch.repository, new_revno, self.rev_id)
449
450
        # and now do the commit locally.
451
        self.branch.set_last_revision_info(new_revno, self.rev_id)
452
453
        # Make the working tree be up to date with the branch. This
454
        # includes automatic changes scheduled to be made to the tree, such
455
        # as updating its basis and unversioning paths that were missing.
456
        self.work_tree.unversion(self.deleted_ids)
457
        self._set_progress_stage("Updating the working tree")
458
        self.work_tree.update_basis_by_delta(self.rev_id,
459
             self.builder.get_basis_delta())
460
        self.reporter.completed(new_revno, self.rev_id)
461
        self._process_post_hooks(old_revno, new_revno)
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
462
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
463
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
464
    def _select_reporter(self):
465
        """Select the CommitReporter to use."""
466
        if is_quiet():
467
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
468
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
469
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
470
    def _check_pointless(self):
471
        if self.allow_pointless:
472
            return
473
        # A merge with no effect on files
474
        if len(self.parents) > 1:
475
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
476
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
477
2921.4.6 by Robert Collins
Typos found by Rob Weir.
478
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
479
        # a worthwhile commit.
480
        if (self.basis_revid == revision.NULL_REVISION and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
481
            ((self.builder.new_inventory is not None and
482
             len(self.builder.new_inventory) == 1) or
483
            len(self.builder._basis_delta) == 1)):
1731.1.49 by Aaron Bentley
Merge bzr.dev
484
            raise PointlessCommit()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
485
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
486
            return
487
        raise PointlessCommit()
488
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
489
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
490
        """Check to see if the local branch is bound.
491
492
        If it is bound, then most of the commit will actually be
493
        done using the remote branch as the target branch.
494
        Only at the end will the local branch be updated.
495
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
496
        if self.local and not self.branch.get_bound_location():
497
            raise errors.LocalRequiresBoundBranch()
498
499
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
500
            self.master_branch = self.branch.get_master_branch(
501
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
502
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
503
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
504
            # make this branch the reference branch for out of date checks.
505
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
506
            return
507
508
        # If the master branch is bound, we must fail
509
        master_bound_location = self.master_branch.get_bound_location()
510
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
511
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
512
                    self.master_branch, master_bound_location)
513
514
        # TODO: jam 20051230 We could automatically push local
515
        #       commits to the remote branch if they would fit.
516
        #       But for now, just require remote to be identical
517
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
518
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
519
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
520
        master_info = self.master_branch.last_revision_info()
521
        local_info = self.branch.last_revision_info()
522
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
523
            raise errors.BoundBranchOutOfDate(self.branch,
524
                    self.master_branch)
525
526
        # Now things are ready to change the master branch
527
        # so grab the lock
528
        self.bound_branch = self.branch
529
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
530
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
531
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
532
    def _check_out_of_date_tree(self):
533
        """Check that the working tree is up to date.
534
535
        :return: old_revision_number,new_revision_number tuple
536
        """
537
        try:
538
            first_tree_parent = self.work_tree.get_parent_ids()[0]
539
        except IndexError:
540
            # if there are no parents, treat our parent as 'None'
541
            # this is so that we still consider the master branch
542
            # - in a checkout scenario the tree may have no
543
            # parents but the branch may do.
544
            first_tree_parent = bzrlib.revision.NULL_REVISION
545
        old_revno, master_last = self.master_branch.last_revision_info()
546
        if master_last != first_tree_parent:
547
            if master_last != bzrlib.revision.NULL_REVISION:
548
                raise errors.OutOfDateTree(self.work_tree)
549
        if self.branch.repository.has_revision(first_tree_parent):
550
            new_revno = old_revno + 1
551
        else:
552
            # ghost parents never appear in revision history.
553
            new_revno = 1
554
        return old_revno,new_revno
555
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
556
    def _process_pre_hooks(self, old_revno, new_revno):
557
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
558
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
559
        self._process_hooks("pre_commit", old_revno, new_revno)
560
561
    def _process_post_hooks(self, old_revno, new_revno):
562
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
563
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
564
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
565
        # old style commit hooks - should be deprecated ? (obsoleted in
566
        # 0.15)
567
        if self.config.post_commit() is not None:
568
            hooks = self.config.post_commit().split(' ')
569
            # this would be nicer with twisted.python.reflect.namedAny
570
            for hook in hooks:
571
                result = eval(hook + '(branch, rev_id)',
572
                              {'branch':self.branch,
573
                               'bzrlib':bzrlib,
574
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
575
        # process new style post commit hooks
576
        self._process_hooks("post_commit", old_revno, new_revno)
577
578
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
579
        if not Branch.hooks[hook_name]:
580
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
581
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
582
        # new style commit hooks:
583
        if not self.bound_branch:
584
            hook_master = self.branch
585
            hook_local = None
586
        else:
587
            hook_master = self.master_branch
588
            hook_local = self.branch
589
        # With bound branches, when the master is behind the local branch,
590
        # the 'old_revno' and old_revid values here are incorrect.
591
        # XXX: FIXME ^. RBC 20060206
592
        if self.parents:
593
            old_revid = self.parents[0]
594
        else:
595
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
596
2659.3.9 by NamNguyen
branch.py:
597
        if hook_name == "pre_commit":
598
            future_tree = self.builder.revision_tree()
599
            tree_delta = future_tree.changes_from(self.basis_tree,
600
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
601
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
602
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
603
            # show the running hook in the progress bar. As hooks may
604
            # end up doing nothing (e.g. because they are not configured by
605
            # the user) this is still showing progress, not showing overall
606
            # actions - its up to each plugin to show a UI if it want's to
607
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
608
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
609
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
610
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
611
            if 'hooks' in debug.debug_flags:
612
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
613
            if hook_name == "post_commit":
614
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
615
                     self.rev_id)
616
            elif hook_name == "pre_commit":
617
                hook(hook_local, hook_master,
618
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
619
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
620
1223 by Martin Pool
- store inventories in weave
621
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
622
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
623
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
624
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
625
        if self.use_record_iter_changes:
626
            return
627
        self.basis_inv = self.basis_tree.inventory
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
628
        self.parent_invs = [self.basis_inv]
629
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
630
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
631
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
632
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
633
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
634
            else:
635
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
636
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
637
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
638
        """Update the commit builder with the data about what has changed.
639
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
640
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
641
        specific_files = self.specific_files
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
642
        mutter("Selecting files for commit with filter %s", specific_files)
643
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
644
        self._check_strict()
645
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
646
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
647
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
648
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
649
            for file_id, path, fs_hash in self.builder.record_iter_changes(
650
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
651
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
652
        else:
653
            # Build the new inventory
654
            self._populate_from_inventory()
655
            self._record_unselected()
656
            self._report_and_accumulate_deletes()
657
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
658
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
659
        """Process iter_changes.
660
661
        This method reports on the changes in iter_changes to the user, and 
662
        converts 'missing' entries in the iter_changes iterator to 'deleted'
663
        entries. 'missing' entries have their
664
665
        :param iter_changes: An iter_changes to process.
666
        :return: A generator of changes.
667
        """
668
        reporter = self.reporter
669
        report_changes = reporter.is_verbose()
670
        deleted_ids = []
671
        for change in iter_changes:
672
            if report_changes:
673
                old_path = change[1][0]
674
                new_path = change[1][1]
675
                versioned = change[3][1]
676
            kind = change[6][1]
677
            versioned = change[3][1]
678
            if kind is None and versioned:
679
                # 'missing' path
680
                if report_changes:
681
                    reporter.missing(new_path)
682
                deleted_ids.append(change[0])
683
                # Reset the new path (None) and new versioned flag (False)
684
                change = (change[0], (change[1][0], None), change[2],
685
                    (change[3][0], False)) + change[4:]
686
            elif kind == 'tree-reference':
687
                if self.recursive == 'down':
688
                    self._commit_nested_tree(change[0], change[1][1])
689
            if change[3][0] or change[3][1]:
690
                yield change
691
                if report_changes:
692
                    if new_path is None:
693
                        reporter.deleted(old_path)
694
                    elif old_path is None:
695
                        reporter.snapshot_change('added', new_path)
696
                    elif old_path != new_path:
697
                        reporter.renamed('renamed', old_path, new_path)
698
                    else:
699
                        if (new_path or 
700
                            self.work_tree.branch.repository._format.rich_root_data):
701
                            # Don't report on changes to '' in non rich root
702
                            # repositories.
703
                            reporter.snapshot_change('modified', new_path)
704
            self._next_progress_entry()
705
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
706
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
707
708
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
709
        # If specific files are selected, then all un-selected files must be
710
        # recorded in their previous state. For more details, see
711
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
712
        if self.specific_files or self.exclude:
713
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
714
            for path, old_ie in self.basis_inv.iter_entries():
715
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
716
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
717
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
718
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
719
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
720
                    # was inside the selected path, and not excluded - if not
721
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
722
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
723
                # From here down it was either not selected, or was excluded:
724
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
725
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
726
                # Note: specific file commits after a merge are currently
727
                # prohibited. This test is for sanity/safety in case it's
728
                # required after that changes.
729
                if len(self.parents) > 1:
730
                    ie.revision = None
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
731
                self.builder.record_entry_contents(ie, self.parent_invs, path,
732
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
733
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
734
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
735
        if (isinstance(self.basis_inv, Inventory)
736
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
737
            # the older Inventory classes provide a _byid dict, and building a
738
            # set from the keys of this dict is substantially faster than even
739
            # getting a set of ids from the inventory
740
            #
741
            # <lifeless> set(dict) is roughly the same speed as
742
            # set(iter(dict)) and both are significantly slower than
743
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
744
            deleted_ids = set(self.basis_inv._byid.keys()) - \
745
               set(self.builder.new_inventory._byid.keys())
746
        else:
747
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
748
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
749
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
750
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
751
                for file_id in deleted_ids]
752
            deleted.sort()
753
            # XXX: this is not quite directory-order sorting
754
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
755
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
756
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
757
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
758
    def _check_strict(self):
759
        # XXX: when we use iter_changes this would likely be faster if
760
        # iter_changes would check for us (even in the presence of
761
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
762
        if self.strict:
763
            # raise an exception as soon as we find a single unknown.
764
            for unknown in self.work_tree.unknowns():
765
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
766
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
767
    def _populate_from_inventory(self):
768
        """Populate the CommitBuilder by walking the working tree inventory."""
769
        # Build the revision inventory.
770
        #
771
        # This starts by creating a new empty inventory. Depending on
772
        # which files are selected for commit, and what is present in the
773
        # current tree, the new inventory is populated. inventory entries
774
        # which are candidates for modification have their revision set to
775
        # None; inventory entries that are carried over untouched have their
776
        # revision set to their prior value.
777
        #
778
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
779
        # results to create a new inventory at the same time, which results
780
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
781
        # ADHB 11-07-2006
782
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
783
        specific_files = self.specific_files
784
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
785
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
786
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
787
        # A tree of paths that have been deleted. E.g. if foo/bar has been
788
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
789
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
790
        # XXX: Note that entries may have the wrong kind because the entry does
791
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
792
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
793
        # NB: entries will include entries within the excluded ids/paths
794
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
795
        entries = work_inv.iter_entries_by_dir(
796
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
797
        for path, existing_ie in entries:
798
            file_id = existing_ie.file_id
799
            name = existing_ie.name
800
            parent_id = existing_ie.parent_id
801
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
802
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
803
            # The deleted path ids are also recorded so they can be explicitly
804
            # unversioned later.
805
            if deleted_paths:
806
                path_segments = splitpath(path)
807
                deleted_dict = deleted_paths
808
                for segment in path_segments:
809
                    deleted_dict = deleted_dict.get(segment, None)
810
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
811
                        # We either took a path not present in the dict
812
                        # (deleted_dict was None), or we've reached an empty
813
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
814
                        break
815
                else:
816
                    deleted_dict = None
817
                if deleted_dict is not None:
818
                    # the path has a deleted parent, do not add it.
819
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
820
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
821
                # Skip excluded paths. Excluded paths are processed by
822
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
823
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
824
            content_summary = self.work_tree.path_content_summary(path)
825
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
826
            # Note that when a filter of specific files is given, we must only
827
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
828
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
829
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
830
                    if not deleted_paths:
831
                        # path won't have been split yet.
832
                        path_segments = splitpath(path)
833
                    deleted_dict = deleted_paths
834
                    for segment in path_segments:
835
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
836
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
837
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
838
                    deleted_ids.append(file_id)
839
                    continue
4595.11.14 by Martin Pool
Small code cleanups
840
            # TODO: have the builder do the nested commit just-in-time IF and
841
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
842
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
843
                # enforce repository nested tree policy.
844
                if (not self.work_tree.supports_tree_reference() or
845
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
846
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
847
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
848
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
849
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
850
                    nested_revision_id = self._commit_nested_tree(
851
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
852
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
853
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
854
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
855
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
856
857
            # Record an entry for this item
858
            # Note: I don't particularly want to have the existing_ie
859
            # parameter but the test suite currently (28-Jun-07) breaks
860
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
861
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
862
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
863
                parent_id, definitely_changed, existing_ie, report_changes,
864
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
865
866
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
867
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
868
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
869
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
870
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
871
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
872
        # FIXME: be more comprehensive here:
873
        # this works when both trees are in --trees repository,
874
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
875
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
876
        # finally implement the explicit-caches approach design
877
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
878
        if sub_tree.branch.repository.has_same_location(
879
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
880
            sub_tree.branch.repository = \
881
                self.work_tree.branch.repository
882
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
883
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
884
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
885
                message_callback=self.message_callback,
886
                timestamp=self.timestamp, timezone=self.timezone,
887
                committer=self.committer,
888
                allow_pointless=self.allow_pointless,
889
                strict=self.strict, verbose=self.verbose,
890
                local=self.local, reporter=self.reporter)
891
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
892
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
893
894
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
895
        parent_id, definitely_changed, existing_ie, report_changes,
896
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
897
        "Record the new inventory entry for a path if any."
898
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
899
        # mutter('%s selected for commit', path)
900
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
901
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
902
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
903
            ie = existing_ie.copy()
904
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
905
        # For carried over entries we don't care about the fs hash - the repo
906
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
907
        _, _, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
908
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
909
        if report_changes:
910
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
911
        if fs_hash:
912
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
913
        return ie
914
915
    def _report_change(self, ie, path):
916
        """Report a change to the user.
917
918
        The change that has occurred is described relative to the basis
919
        inventory.
920
        """
921
        if (self.basis_inv.has_id(ie.file_id)):
922
            basis_ie = self.basis_inv[ie.file_id]
923
        else:
924
            basis_ie = None
925
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
926
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
927
            InventoryEntry.MODIFIED_AND_RENAMED):
928
            old_path = self.basis_inv.id2path(ie.file_id)
929
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
930
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
931
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
932
            if change == 'unchanged':
933
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
934
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
935
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
936
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
937
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
938
        """Set the progress stage and emit an update to the progress bar."""
939
        self.pb_stage_name = name
940
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
941
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
942
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
943
        else:
944
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
945
        self._emit_progress()
946
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
947
    def _next_progress_entry(self):
948
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
949
        self.pb_entries_count += 1
950
        self._emit_progress()
951
952
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
953
        if self.pb_entries_count is not None:
954
            text = "%s [%d] - Stage" % (self.pb_stage_name,
955
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
956
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
957
            text = "%s - Stage" % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
958
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
959
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
960
    def _set_specific_file_ids(self):
961
        """populate self.specific_file_ids if we will use it."""
962
        if not self.use_record_iter_changes:
963
            # If provided, ensure the specified files are versioned
964
            if self.specific_files is not None:
965
                # Note: This routine is being called because it raises
966
                # PathNotVersionedError as a side effect of finding the IDs. We
967
                # later use the ids we found as input to the working tree
968
                # inventory iterator, so we only consider those ids rather than
969
                # examining the whole tree again.
970
                # XXX: Dont we have filter_unversioned to do this more
971
                # cheaply?
972
                self.specific_file_ids = tree.find_ids_across_trees(
973
                    self.specific_files, [self.basis_tree, self.work_tree])
974
            else:
975
                self.specific_file_ids = None