4763.2.4
by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry. |
1 |
# Copyright (C) 2005-2010 Canonical Ltd
|
1185.33.9
by Martin Pool
Add new selftest module. |
2 |
#
|
3 |
# This program is free software; you can redistribute it and/or modify
|
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
7 |
#
|
|
8 |
# This program is distributed in the hope that it will be useful,
|
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
12 |
#
|
|
13 |
# You should have received a copy of the GNU General Public License
|
|
14 |
# along with this program; if not, write to the Free Software
|
|
4183.7.1
by Sabin Iacob
update FSF mailing address |
15 |
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
1185.33.9
by Martin Pool
Add new selftest module. |
16 |
|
17 |
# "weren't nothing promised to you. do i look like i got a promise face?"
|
|
18 |
||
19 |
"""Tests for trace library"""
|
|
20 |
||
1948.1.5
by John Arbash Meinel
Make sure BzrCommandError can handle unicode arguments |
21 |
from cStringIO import StringIO |
1740.5.7
by Martin Pool
Add test for formatting of EPIPE |
22 |
import errno |
1185.33.9
by Martin Pool
Add new selftest module. |
23 |
import os |
3195.1.1
by Andrew Bennetts
Always include timestamps in the trace file (i.e. remove -Dtimes in favour of having it switched on permanently) |
24 |
import re |
1185.33.9
by Martin Pool
Add new selftest module. |
25 |
import sys |
3173.1.12
by Martin Pool
Add test_push_log_file |
26 |
import tempfile |
1185.33.9
by Martin Pool
Add new selftest module. |
27 |
|
1948.1.5
by John Arbash Meinel
Make sure BzrCommandError can handle unicode arguments |
28 |
from bzrlib import ( |
29 |
errors, |
|
4634.118.1
by John Arbash Meinel
Fix bug #503886, errors setting up logging go to stderr. |
30 |
trace, |
1948.1.5
by John Arbash Meinel
Make sure BzrCommandError can handle unicode arguments |
31 |
)
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
32 |
from bzrlib.tests import TestCaseInTempDir, TestCase |
2768.1.10
by Ian Clatworthy
Add tests for new methods in trace.py |
33 |
from bzrlib.trace import ( |
34 |
mutter, mutter_callsite, report_exception, |
|
35 |
set_verbosity_level, get_verbosity_level, is_quiet, is_verbose, be_quiet, |
|
3173.1.12
by Martin Pool
Add test_push_log_file |
36 |
pop_log_file, |
37 |
push_log_file, |
|
2851.3.1
by Martin Pool
Add unit test for _rollover_trace_maybe |
38 |
_rollover_trace_maybe, |
2768.1.10
by Ian Clatworthy
Add tests for new methods in trace.py |
39 |
)
|
1185.33.9
by Martin Pool
Add new selftest module. |
40 |
|
1740.5.2
by Martin Pool
Improved tests for display of exceptions. |
41 |
|
42 |
def _format_exception(): |
|
43 |
"""Format an exception as it would normally be displayed to the user"""
|
|
44 |
buf = StringIO() |
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
45 |
report_exception(sys.exc_info(), buf) |
46 |
return buf.getvalue() |
|
1740.5.2
by Martin Pool
Improved tests for display of exceptions. |
47 |
|
48 |
||
1185.33.9
by Martin Pool
Add new selftest module. |
49 |
class TestTrace(TestCase): |
1740.5.2
by Martin Pool
Improved tests for display of exceptions. |
50 |
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
51 |
def test_format_sys_exception(self): |
4584.3.20
by Martin Pool
Tweak trace tests to cope without the traceback being printed |
52 |
# Test handling of an internal/unexpected error that probably
|
53 |
# indicates a bug in bzr. The details of the message may vary
|
|
54 |
# depending on whether apport is available or not. See test_crash for
|
|
55 |
# more.
|
|
1185.33.9
by Martin Pool
Add new selftest module. |
56 |
try: |
57 |
raise NotImplementedError, "time travel" |
|
58 |
except NotImplementedError: |
|
59 |
pass
|
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
60 |
err = _format_exception() |
1740.5.2
by Martin Pool
Improved tests for display of exceptions. |
61 |
self.assertEqualDiff(err.splitlines()[0], |
1740.5.3
by Martin Pool
Cleanup more exception-formatting code |
62 |
'bzr: ERROR: exceptions.NotImplementedError: time travel') |
1740.5.2
by Martin Pool
Improved tests for display of exceptions. |
63 |
self.assertContainsRe(err, |
4584.3.20
by Martin Pool
Tweak trace tests to cope without the traceback being printed |
64 |
'Bazaar has encountered an internal error.') |
1185.33.9
by Martin Pool
Add new selftest module. |
65 |
|
1740.5.3
by Martin Pool
Cleanup more exception-formatting code |
66 |
def test_format_interrupt_exception(self): |
67 |
try: |
|
68 |
raise KeyboardInterrupt() |
|
1740.5.5
by Martin Pool
Show short form for OSError and IOError too |
69 |
except KeyboardInterrupt: |
1740.5.3
by Martin Pool
Cleanup more exception-formatting code |
70 |
# XXX: Some risk that a *real* keyboard interrupt won't be seen
|
71 |
pass
|
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
72 |
msg = _format_exception() |
1740.5.3
by Martin Pool
Cleanup more exception-formatting code |
73 |
self.assertTrue(len(msg) > 0) |
74 |
self.assertEqualDiff(msg, 'bzr: interrupted\n') |
|
75 |
||
4634.26.1
by Martin Pool
Cleaner message when out of memory |
76 |
def test_format_memory_error(self): |
77 |
try: |
|
78 |
raise MemoryError() |
|
79 |
except MemoryError: |
|
80 |
pass
|
|
81 |
msg = _format_exception() |
|
82 |
self.assertEquals(msg, |
|
83 |
"bzr: out of memory\n") |
|
84 |
||
1740.5.5
by Martin Pool
Show short form for OSError and IOError too |
85 |
def test_format_os_error(self): |
86 |
try: |
|
4095.1.1
by Martin Pool
Add more distinct tests for IOError and OSError |
87 |
os.rmdir('nosuchfile22222') |
4789.22.1
by John Arbash Meinel
Fix a test_trace failure on Windows. |
88 |
except OSError, e: |
89 |
e_str = str(e) |
|
4095.1.1
by Martin Pool
Add more distinct tests for IOError and OSError |
90 |
msg = _format_exception() |
4789.22.1
by John Arbash Meinel
Fix a test_trace failure on Windows. |
91 |
# Linux seems to give "No such file" but Windows gives "The system
|
92 |
# cannot find the file specified".
|
|
93 |
self.assertEqual('bzr: ERROR: %s\n' % (e_str,), msg) |
|
4095.1.1
by Martin Pool
Add more distinct tests for IOError and OSError |
94 |
|
95 |
def test_format_io_error(self): |
|
96 |
try: |
|
1740.5.5
by Martin Pool
Show short form for OSError and IOError too |
97 |
file('nosuchfile22222') |
4095.1.1
by Martin Pool
Add more distinct tests for IOError and OSError |
98 |
except IOError: |
1740.5.5
by Martin Pool
Show short form for OSError and IOError too |
99 |
pass
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
100 |
msg = _format_exception() |
4789.22.1
by John Arbash Meinel
Fix a test_trace failure on Windows. |
101 |
# Even though Windows and Linux differ for 'os.rmdir', they both give
|
102 |
# 'No such file' for open()
|
|
103 |
self.assertContainsRe(msg, |
|
104 |
r'^bzr: ERROR: \[Errno .*\] No such file.*nosuchfile') |
|
1740.5.5
by Martin Pool
Show short form for OSError and IOError too |
105 |
|
1948.1.5
by John Arbash Meinel
Make sure BzrCommandError can handle unicode arguments |
106 |
def test_format_unicode_error(self): |
107 |
try: |
|
108 |
raise errors.BzrCommandError(u'argument foo\xb5 does not exist') |
|
109 |
except errors.BzrCommandError: |
|
110 |
pass
|
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
111 |
msg = _format_exception() |
1740.5.5
by Martin Pool
Show short form for OSError and IOError too |
112 |
|
1185.33.9
by Martin Pool
Add new selftest module. |
113 |
def test_format_exception(self): |
1740.5.2
by Martin Pool
Improved tests for display of exceptions. |
114 |
"""Short formatting of bzr exceptions"""
|
1185.33.9
by Martin Pool
Add new selftest module. |
115 |
try: |
2067.3.1
by Martin Pool
Clean up BzrNewError, other exception classes and users. |
116 |
raise errors.NotBranchError('wibble') |
1948.1.5
by John Arbash Meinel
Make sure BzrCommandError can handle unicode arguments |
117 |
except errors.NotBranchError: |
1185.33.9
by Martin Pool
Add new selftest module. |
118 |
pass
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
119 |
msg = _format_exception() |
1740.5.2
by Martin Pool
Improved tests for display of exceptions. |
120 |
self.assertTrue(len(msg) > 0) |
2745.3.2
by Daniel Watkins
Updated tests to reflect new error text. |
121 |
self.assertEqualDiff(msg, 'bzr: ERROR: Not a branch: \"wibble\".\n') |
1185.33.63
by Martin Pool
Better display of BzrError classes that are not BzrNewErrors. |
122 |
|
3497.3.2
by Martin Pool
Show short error for missing libraries |
123 |
def test_report_external_import_error(self): |
124 |
"""Short friendly message for missing system modules."""
|
|
125 |
try: |
|
126 |
import ImaginaryModule |
|
127 |
except ImportError, e: |
|
128 |
pass
|
|
129 |
else: |
|
130 |
self.fail("somehow succeeded in importing %r" % ImaginaryModule) |
|
131 |
msg = _format_exception() |
|
132 |
self.assertEqual(msg, |
|
133 |
'bzr: ERROR: No module named ImaginaryModule\n' |
|
134 |
'You may need to install this Python library separately.\n') |
|
135 |
||
136 |
def test_report_import_syntax_error(self): |
|
137 |
try: |
|
138 |
raise ImportError("syntax error") |
|
139 |
except ImportError, e: |
|
140 |
pass
|
|
141 |
msg = _format_exception() |
|
142 |
self.assertContainsRe(msg, |
|
4584.3.20
by Martin Pool
Tweak trace tests to cope without the traceback being printed |
143 |
r'Bazaar has encountered an internal error') |
3497.3.2
by Martin Pool
Show short error for missing libraries |
144 |
|
1185.33.51
by Martin Pool
Fix trace of non-ascii messages, and add test. |
145 |
def test_trace_unicode(self): |
146 |
"""Write Unicode to trace log"""
|
|
147 |
self.log(u'the unicode character for benzene is \N{BENZENE RING}') |
|
4794.1.15
by Robert Collins
Review feedback. |
148 |
log = self.get_log() |
4794.1.8
by Robert Collins
Move the passing of test logs to the result to be via the getDetails API and remove all public use of TestCase._get_log. |
149 |
self.assertContainsRe(log, "the unicode character for benzene is") |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
150 |
|
1948.1.2
by John Arbash Meinel
Fix the test_trace functions to actually test that things are written to the log |
151 |
def test_trace_argument_unicode(self): |
152 |
"""Write a Unicode argument to the trace log"""
|
|
153 |
mutter(u'the unicode character for benzene is %s', u'\N{BENZENE RING}') |
|
4794.1.15
by Robert Collins
Review feedback. |
154 |
log = self.get_log() |
4794.1.8
by Robert Collins
Move the passing of test logs to the result to be via the getDetails API and remove all public use of TestCase._get_log. |
155 |
self.assertContainsRe(log, 'the unicode character') |
1185.85.5
by John Arbash Meinel
mutter() should not fail because of unicode errors |
156 |
|
1948.1.3
by John Arbash Meinel
Fix mutter() so even if args are invalid, it still works |
157 |
def test_trace_argument_utf8(self): |
158 |
"""Write a Unicode argument to the trace log"""
|
|
159 |
mutter(u'the unicode character for benzene is %s', |
|
160 |
u'\N{BENZENE RING}'.encode('utf-8')) |
|
4794.1.15
by Robert Collins
Review feedback. |
161 |
log = self.get_log() |
4794.1.8
by Robert Collins
Move the passing of test logs to the result to be via the getDetails API and remove all public use of TestCase._get_log. |
162 |
self.assertContainsRe(log, 'the unicode character') |
1948.1.3
by John Arbash Meinel
Fix mutter() so even if args are invalid, it still works |
163 |
|
1740.5.7
by Martin Pool
Add test for formatting of EPIPE |
164 |
def test_report_broken_pipe(self): |
165 |
try: |
|
166 |
raise IOError(errno.EPIPE, 'broken pipe foofofo') |
|
167 |
except IOError, e: |
|
1551.9.3
by Aaron Bentley
Revert buggy apport changes |
168 |
msg = _format_exception() |
1740.5.7
by Martin Pool
Add test for formatting of EPIPE |
169 |
self.assertEquals(msg, "bzr: broken pipe\n") |
170 |
else: |
|
171 |
self.fail("expected error not raised") |
|
1740.5.9
by Martin Pool
[merge] bzr.dev |
172 |
|
3195.1.1
by Andrew Bennetts
Always include timestamps in the trace file (i.e. remove -Dtimes in favour of having it switched on permanently) |
173 |
def assertLogStartsWith(self, log, string): |
174 |
"""Like assertStartsWith, but skips the log timestamp."""
|
|
175 |
self.assertContainsRe(log, |
|
176 |
'^\\d+\\.\\d+ ' + re.escape(string)) |
|
177 |
||
2725.1.1
by Robert Collins
Add -Devil flag to highlight the use of problematic API calls. |
178 |
def test_mutter_callsite_1(self): |
179 |
"""mutter_callsite can capture 1 level of stack frame."""
|
|
180 |
mutter_callsite(1, "foo %s", "a string") |
|
4794.1.15
by Robert Collins
Review feedback. |
181 |
log = self.get_log() |
2725.1.1
by Robert Collins
Add -Devil flag to highlight the use of problematic API calls. |
182 |
# begin with the message
|
3195.1.1
by Andrew Bennetts
Always include timestamps in the trace file (i.e. remove -Dtimes in favour of having it switched on permanently) |
183 |
self.assertLogStartsWith(log, 'foo a string\nCalled from:\n') |
2725.1.1
by Robert Collins
Add -Devil flag to highlight the use of problematic API calls. |
184 |
# should show two frame: this frame and the one above
|
185 |
self.assertContainsRe(log, |
|
3195.1.1
by Andrew Bennetts
Always include timestamps in the trace file (i.e. remove -Dtimes in favour of having it switched on permanently) |
186 |
'test_trace\\.py", line \\d+, in test_mutter_callsite_1\n') |
2725.1.1
by Robert Collins
Add -Devil flag to highlight the use of problematic API calls. |
187 |
# this frame should be the final one
|
188 |
self.assertEndsWith(log, ' "a string")\n') |
|
189 |
||
190 |
def test_mutter_callsite_2(self): |
|
191 |
"""mutter_callsite can capture 2 levels of stack frame."""
|
|
192 |
mutter_callsite(2, "foo %s", "a string") |
|
4794.1.15
by Robert Collins
Review feedback. |
193 |
log = self.get_log() |
2725.1.1
by Robert Collins
Add -Devil flag to highlight the use of problematic API calls. |
194 |
# begin with the message
|
3195.1.1
by Andrew Bennetts
Always include timestamps in the trace file (i.e. remove -Dtimes in favour of having it switched on permanently) |
195 |
self.assertLogStartsWith(log, 'foo a string\nCalled from:\n') |
2725.1.1
by Robert Collins
Add -Devil flag to highlight the use of problematic API calls. |
196 |
# should show two frame: this frame and the one above
|
197 |
self.assertContainsRe(log, |
|
198 |
'test_trace.py", line \d+, in test_mutter_callsite_2\n') |
|
199 |
# this frame should be the final one
|
|
200 |
self.assertEndsWith(log, ' "a string")\n') |
|
201 |
||
1185.85.5
by John Arbash Meinel
mutter() should not fail because of unicode errors |
202 |
def test_mutter_never_fails(self): |
203 |
# Even if the decode/encode stage fails, mutter should not
|
|
204 |
# raise an exception
|
|
4794.1.8
by Robert Collins
Move the passing of test logs to the result to be via the getDetails API and remove all public use of TestCase._get_log. |
205 |
# This test checks that mutter doesn't fail; the current behaviour
|
206 |
# is that it doesn't fail *and writes non-utf8*.
|
|
1185.85.5
by John Arbash Meinel
mutter() should not fail because of unicode errors |
207 |
mutter(u'Writing a greek mu (\xb5) works in a unicode string') |
208 |
mutter('But fails in an ascii string \xb5') |
|
1948.1.4
by John Arbash Meinel
Update test_never_fails, to cover one of the failure points |
209 |
mutter('and in an ascii argument: %s', '\xb5') |
4794.1.15
by Robert Collins
Review feedback. |
210 |
log = self.get_log() |
1185.85.5
by John Arbash Meinel
mutter() should not fail because of unicode errors |
211 |
self.assertContainsRe(log, 'Writing a greek mu') |
1948.1.9
by John Arbash Meinel
Change mutter() so that it doesn't try so hard to write out perfect utf8, instead, rather than using a utf8 file, it changes unicode to utf8 manually |
212 |
self.assertContainsRe(log, "But fails in an ascii string") |
4794.1.8
by Robert Collins
Move the passing of test logs to the result to be via the getDetails API and remove all public use of TestCase._get_log. |
213 |
# However, the log content object does unicode replacement on reading
|
214 |
# to let it get unicode back where good data has been written. So we
|
|
215 |
# have to do a replaceent here as well.
|
|
216 |
self.assertContainsRe(log, "ascii argument: \xb5".decode('utf8', |
|
217 |
'replace')) |
|
2725.1.1
by Robert Collins
Add -Devil flag to highlight the use of problematic API calls. |
218 |
|
3173.1.12
by Martin Pool
Add test_push_log_file |
219 |
def test_push_log_file(self): |
220 |
"""Can push and pop log file, and this catches mutter messages.
|
|
221 |
||
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
222 |
This is primarily for use in the test framework.
|
3173.1.12
by Martin Pool
Add test_push_log_file |
223 |
"""
|
224 |
tmp1 = tempfile.NamedTemporaryFile() |
|
225 |
tmp2 = tempfile.NamedTemporaryFile() |
|
226 |
try: |
|
227 |
memento1 = push_log_file(tmp1) |
|
228 |
mutter("comment to file1") |
|
229 |
try: |
|
230 |
memento2 = push_log_file(tmp2) |
|
231 |
try: |
|
232 |
mutter("comment to file2") |
|
233 |
finally: |
|
234 |
pop_log_file(memento2) |
|
235 |
mutter("again to file1") |
|
236 |
finally: |
|
237 |
pop_log_file(memento1) |
|
238 |
# the files were opened in binary mode, so should have exactly
|
|
239 |
# these bytes. and removing the file as the log target should
|
|
3173.1.15
by Martin Pool
Update test_push_log_file to handle there always being timestamps at the start of the trace messages |
240 |
# have caused them to be flushed out. need to match using regexps
|
241 |
# as there's a timestamp at the front.
|
|
242 |
tmp1.seek(0) |
|
243 |
self.assertContainsRe(tmp1.read(), |
|
244 |
r"\d+\.\d+ comment to file1\n\d+\.\d+ again to file1\n") |
|
245 |
tmp2.seek(0) |
|
246 |
self.assertContainsRe(tmp2.read(), |
|
247 |
r"\d+\.\d+ comment to file2\n") |
|
3173.1.12
by Martin Pool
Add test_push_log_file |
248 |
finally: |
249 |
tmp1.close() |
|
250 |
tmp2.close() |
|
251 |
||
4634.118.1
by John Arbash Meinel
Fix bug #503886, errors setting up logging go to stderr. |
252 |
def test__open_bzr_log_uses_stderr_for_failures(self): |
253 |
# If _open_bzr_log cannot open the file, then we should write the
|
|
254 |
# warning to stderr. Since this is normally happening before logging is
|
|
255 |
# set up.
|
|
4985.1.5
by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity |
256 |
self.overrideAttr(sys, 'stderr', StringIO()) |
4634.118.1
by John Arbash Meinel
Fix bug #503886, errors setting up logging go to stderr. |
257 |
# Set the log file to something that cannot exist
|
4985.1.5
by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity |
258 |
# FIXME: A bit dangerous: we are not in an isolated dir here -- vilajam
|
259 |
# 20100125
|
|
4634.118.1
by John Arbash Meinel
Fix bug #503886, errors setting up logging go to stderr. |
260 |
os.environ['BZR_LOG'] = os.getcwd() + '/no-dir/bzr.log' |
4985.1.5
by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity |
261 |
self.overrideAttr(trace, '_bzr_log_filename') |
4634.118.1
by John Arbash Meinel
Fix bug #503886, errors setting up logging go to stderr. |
262 |
logf = trace._open_bzr_log() |
263 |
self.assertIs(None, logf) |
|
264 |
self.assertContainsRe(sys.stderr.getvalue(), |
|
265 |
'failed to open trace file: .*/no-dir/bzr.log') |
|
2768.1.10
by Ian Clatworthy
Add tests for new methods in trace.py |
266 |
|
4985.1.5
by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity |
267 |
|
2768.1.10
by Ian Clatworthy
Add tests for new methods in trace.py |
268 |
class TestVerbosityLevel(TestCase): |
269 |
||
270 |
def test_verbosity_level(self): |
|
271 |
set_verbosity_level(1) |
|
272 |
self.assertEqual(1, get_verbosity_level()) |
|
273 |
self.assertTrue(is_verbose()) |
|
274 |
self.assertFalse(is_quiet()) |
|
275 |
set_verbosity_level(-1) |
|
276 |
self.assertEqual(-1, get_verbosity_level()) |
|
277 |
self.assertFalse(is_verbose()) |
|
278 |
self.assertTrue(is_quiet()) |
|
279 |
set_verbosity_level(0) |
|
280 |
self.assertEqual(0, get_verbosity_level()) |
|
281 |
self.assertFalse(is_verbose()) |
|
282 |
self.assertFalse(is_quiet()) |
|
283 |
||
284 |
def test_be_quiet(self): |
|
285 |
# Confirm the old API still works
|
|
286 |
be_quiet(True) |
|
287 |
self.assertEqual(-1, get_verbosity_level()) |
|
288 |
be_quiet(False) |
|
289 |
self.assertEqual(0, get_verbosity_level()) |
|
2851.3.1
by Martin Pool
Add unit test for _rollover_trace_maybe |
290 |
|
291 |
||
292 |
class TestBzrLog(TestCaseInTempDir): |
|
293 |
||
294 |
def test_log_rollover(self): |
|
295 |
temp_log_name = 'test-log' |
|
296 |
trace_file = open(temp_log_name, 'at') |
|
4789.22.2
by John Arbash Meinel
Speed up a slow memory-hungry test that doesn't need to be. |
297 |
trace_file.writelines(['test_log_rollover padding\n'] * 200000) |
2851.3.1
by Martin Pool
Add unit test for _rollover_trace_maybe |
298 |
trace_file.close() |
299 |
_rollover_trace_maybe(temp_log_name) |
|
300 |
# should have been rolled over
|
|
301 |
self.assertFalse(os.access(temp_log_name, os.R_OK)) |