~bzr-pqm/bzr/bzr.dev

4763.2.4 by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry.
1
# Copyright (C) 2006-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1553.5.12 by Martin Pool
New LockDir locking mechanism
16
17
"""Tests for LockDir"""
18
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
19
from cStringIO import StringIO
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
20
import os
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
21
from threading import Thread, Lock
1553.5.12 by Martin Pool
New LockDir locking mechanism
22
import time
23
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
24
import bzrlib
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
25
from bzrlib import (
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
26
    config,
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
27
    errors,
3331.3.13 by Martin Pool
Fix up imports
28
    lock,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
29
    osutils,
1551.10.4 by Aaron Bentley
Update to skip on win32
30
    tests,
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
31
    transport,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
32
    )
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
33
from bzrlib.errors import (
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
34
    LockBreakMismatch,
35
    LockBroken,
36
    LockContention,
37
    LockError,
38
    LockFailed,
39
    LockNotHeld,
40
    )
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
41
from bzrlib.lockdir import LockDir
1553.5.33 by Martin Pool
LockDir review comment fixes
42
from bzrlib.tests import TestCaseWithTransport
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
43
from bzrlib.trace import note
1553.5.12 by Martin Pool
New LockDir locking mechanism
44
45
# These tests sometimes use threads to test the behaviour of lock files with
46
# concurrent actors.  This is not a typical (or necessarily supported) use;
47
# they're really meant for guarding between processes.
48
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
49
# These tests are run on the default transport provided by the test framework
50
# (typically a local disk transport).  That can be changed by the --transport
51
# option to bzr selftest.  The required properties of the transport
52
# implementation are tested separately.  (The main requirement is just that
53
# they don't allow overwriting nonempty directories.)
54
1553.5.12 by Martin Pool
New LockDir locking mechanism
55
class TestLockDir(TestCaseWithTransport):
56
    """Test LockDir operations"""
57
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
58
    def logging_report_function(self, fmt, *args):
59
        self._logged_reports.append((fmt, args))
60
61
    def setup_log_reporter(self, lock_dir):
62
        self._logged_reports = []
63
        lock_dir._report_function = self.logging_report_function
64
1553.5.12 by Martin Pool
New LockDir locking mechanism
65
    def test_00_lock_creation(self):
66
        """Creation of lock file on a transport"""
67
        t = self.get_transport()
68
        lf = LockDir(t, 'test_lock')
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
69
        self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
70
71
    def test_01_lock_repr(self):
72
        """Lock string representation"""
73
        lf = LockDir(self.get_transport(), 'test_lock')
74
        r = repr(lf)
75
        self.assertContainsRe(r, r'^LockDir\(.*/test_lock\)$')
76
77
    def test_02_unlocked_peek(self):
78
        lf = LockDir(self.get_transport(), 'test_lock')
79
        self.assertEqual(lf.peek(), None)
80
1687.1.3 by Robert Collins
Make LockDir.unlock check the lock is still intact.
81
    def get_lock(self):
82
        return LockDir(self.get_transport(), 'test_lock')
83
84
    def test_unlock_after_break_raises(self):
85
        ld = self.get_lock()
86
        ld2 = self.get_lock()
87
        ld.create()
88
        ld.attempt_lock()
89
        ld2.force_break(ld2.peek())
90
        self.assertRaises(LockBroken, ld.unlock)
91
1553.5.12 by Martin Pool
New LockDir locking mechanism
92
    def test_03_readonly_peek(self):
93
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
94
        self.assertEqual(lf.peek(), None)
95
96
    def test_10_lock_uncontested(self):
97
        """Acquire and release a lock"""
98
        t = self.get_transport()
99
        lf = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
100
        lf.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
101
        lf.attempt_lock()
102
        try:
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
103
            self.assertTrue(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
104
        finally:
105
            lf.unlock()
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
106
            self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
107
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
108
    def test_11_create_readonly_transport(self):
109
        """Fail to create lock on readonly transport"""
110
        t = self.get_readonly_transport()
111
        lf = LockDir(t, 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
112
        self.assertRaises(LockFailed, lf.create)
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
113
114
    def test_12_lock_readonly_transport(self):
1553.5.12 by Martin Pool
New LockDir locking mechanism
115
        """Fail to lock on readonly transport"""
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
116
        lf = LockDir(self.get_transport(), 'test_lock')
117
        lf.create()
118
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
119
        self.assertRaises(LockFailed, lf.attempt_lock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
120
121
    def test_20_lock_contested(self):
122
        """Contention to get a lock"""
123
        t = self.get_transport()
124
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
125
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
126
        lf1.attempt_lock()
127
        lf2 = LockDir(t, 'test_lock')
128
        try:
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
129
            # locking is between LockDir instances; aliases within
1553.5.12 by Martin Pool
New LockDir locking mechanism
130
            # a single process are not detected
131
            lf2.attempt_lock()
132
            self.fail('Failed to detect lock collision')
133
        except LockContention, e:
134
            self.assertEqual(e.lock, lf2)
135
            self.assertContainsRe(str(e),
136
                    r'^Could not acquire.*test_lock.*$')
137
        lf1.unlock()
138
139
    def test_20_lock_peek(self):
140
        """Peek at the state of a lock"""
141
        t = self.get_transport()
142
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
143
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
144
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
145
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
146
        # lock is held, should get some info on it
147
        info1 = lf1.peek()
148
        self.assertEqual(set(info1.keys()),
149
                         set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
150
        # should get the same info if we look at it through a different
151
        # instance
152
        info2 = LockDir(t, 'test_lock').peek()
153
        self.assertEqual(info1, info2)
154
        # locks which are never used should be not-held
155
        self.assertEqual(LockDir(t, 'other_lock').peek(), None)
156
157
    def test_21_peek_readonly(self):
158
        """Peek over a readonly transport"""
159
        t = self.get_transport()
160
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
161
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
162
        lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
163
        self.assertEqual(lf2.peek(), None)
164
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
165
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
166
        info2 = lf2.peek()
167
        self.assertTrue(info2)
168
        self.assertEqual(info2['nonce'], lf1.nonce)
169
170
    def test_30_lock_wait_fail(self):
171
        """Wait on a lock, then fail
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
172
1553.5.12 by Martin Pool
New LockDir locking mechanism
173
        We ask to wait up to 400ms; this should fail within at most one
174
        second.  (Longer times are more realistic but we don't want the test
175
        suite to take too long, and this should do for now.)
176
        """
177
        t = self.get_transport()
178
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
179
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
180
        lf2 = LockDir(t, 'test_lock')
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
181
        self.setup_log_reporter(lf2)
1553.5.12 by Martin Pool
New LockDir locking mechanism
182
        lf1.attempt_lock()
183
        try:
184
            before = time.time()
185
            self.assertRaises(LockContention, lf2.wait_lock,
186
                              timeout=0.4, poll=0.1)
187
            after = time.time()
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
188
            # it should only take about 0.4 seconds, but we allow more time in
189
            # case the machine is heavily loaded
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
190
            self.assertTrue(after - before <= 8.0,
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
191
                    "took %f seconds to detect lock contention" % (after - before))
1553.5.12 by Martin Pool
New LockDir locking mechanism
192
        finally:
193
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
194
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
195
        self.assertEqual(1, len(self._logged_reports))
3441.4.2 by Martin Albisetti
Fixed failing tests
196
        lock_url = lf2.transport.abspath(lf2.path)
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
197
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
198
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
199
                         'Will continue to try until %s, unless '
4960.2.2 by Martin Pool
Tweak Lockdir contention message to suggest reading help break-lock.
200
                         'you press Ctrl-C.\n'
201
                         'See "bzr help break-lock" for more.',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
202
                         self._logged_reports[0][0])
203
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
204
        self.assertEqual('Unable to obtain', args[0])
205
        self.assertEqual('lock %s' % (lock_base,), args[1])
206
        self.assertStartsWith(args[2], 'held by ')
207
        self.assertStartsWith(args[3], 'locked ')
208
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
209
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1553.5.12 by Martin Pool
New LockDir locking mechanism
210
211
    def test_31_lock_wait_easy(self):
212
        """Succeed when waiting on a lock with no contention.
213
        """
214
        t = self.get_transport()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
215
        lf1 = LockDir(t, 'test_lock')
216
        lf1.create()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
217
        self.setup_log_reporter(lf1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
218
        try:
219
            before = time.time()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
220
            lf1.wait_lock(timeout=0.4, poll=0.1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
221
            after = time.time()
222
            self.assertTrue(after - before <= 1.0)
223
        finally:
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
224
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
225
        self.assertEqual([], self._logged_reports)
1553.5.12 by Martin Pool
New LockDir locking mechanism
226
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
227
    def test_32_lock_wait_succeed(self):
228
        """Succeed when trying to acquire a lock that gets released
229
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
230
        One thread holds on a lock and then releases it; another
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
231
        tries to lock it.
232
        """
1551.15.22 by Aaron Bentley
Redo test skip
233
        # This test sometimes fails like this:
234
        # Traceback (most recent call last):
235
236
        #   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/
237
        # test_lockdir.py", line 247, in test_32_lock_wait_succeed
238
        #     self.assertEqual(1, len(self._logged_reports))
239
        # AssertionError: not equal:
240
        # a = 1
241
        # b = 0
242
        raise tests.TestSkipped("Test fails intermittently")
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
243
        t = self.get_transport()
244
        lf1 = LockDir(t, 'test_lock')
245
        lf1.create()
246
        lf1.attempt_lock()
247
248
        def wait_and_unlock():
249
            time.sleep(0.1)
250
            lf1.unlock()
251
        unlocker = Thread(target=wait_and_unlock)
252
        unlocker.start()
253
        try:
254
            lf2 = LockDir(t, 'test_lock')
255
            self.setup_log_reporter(lf2)
256
            before = time.time()
257
            # wait and then lock
258
            lf2.wait_lock(timeout=0.4, poll=0.1)
259
            after = time.time()
260
            self.assertTrue(after - before <= 1.0)
261
        finally:
262
            unlocker.join()
263
264
        # There should be only 1 report, even though it should have to
265
        # wait for a while
266
        lock_base = lf2.transport.abspath(lf2.path)
267
        self.assertEqual(1, len(self._logged_reports))
268
        self.assertEqual('%s %s\n'
269
                         '%s\n%s\n'
270
                         'Will continue to try until %s\n',
271
                         self._logged_reports[0][0])
272
        args = self._logged_reports[0][1]
273
        self.assertEqual('Unable to obtain', args[0])
274
        self.assertEqual('lock %s' % (lock_base,), args[1])
275
        self.assertStartsWith(args[2], 'held by ')
276
        self.assertStartsWith(args[3], 'locked ')
277
        self.assertEndsWith(args[3], ' ago')
278
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
279
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
280
    def test_34_lock_write_waits(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
281
        """LockDir.lock_write() will wait for the lock."""
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
282
        # the test suite sets the default to 0 to make deadlocks fail fast.
283
        # change it for this test, as we want to try a manual deadlock.
2631.1.4 by Aaron Bentley
Fix test skip
284
        raise tests.TestSkipped('Timing-sensitive test')
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
285
        bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
286
        t = self.get_transport()
287
        lf1 = LockDir(t, 'test_lock')
288
        lf1.create()
289
        lf1.attempt_lock()
290
291
        def wait_and_unlock():
292
            time.sleep(0.1)
293
            lf1.unlock()
294
        unlocker = Thread(target=wait_and_unlock)
295
        unlocker.start()
296
        try:
297
            lf2 = LockDir(t, 'test_lock')
298
            self.setup_log_reporter(lf2)
299
            before = time.time()
300
            # wait and then lock
301
            lf2.lock_write()
302
            after = time.time()
303
        finally:
304
            unlocker.join()
305
306
        # There should be only 1 report, even though it should have to
307
        # wait for a while
308
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
309
        self.assertEqual(1, len(self._logged_reports))
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
310
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
311
                         '%s\n%s\n'
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
312
                         'Will continue to try until %s\n',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
313
                         self._logged_reports[0][0])
314
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
315
        self.assertEqual('Unable to obtain', args[0])
316
        self.assertEqual('lock %s' % (lock_base,), args[1])
317
        self.assertStartsWith(args[2], 'held by ')
318
        self.assertStartsWith(args[3], 'locked ')
319
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
320
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
321
322
    def test_35_wait_lock_changing(self):
323
        """LockDir.wait_lock() will report if the lock changes underneath.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
324
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
325
        This is the stages we want to happen:
326
327
        0) Synchronization locks are created and locked.
328
        1) Lock1 obtains the lockdir, and releases the 'check' lock.
329
        2) Lock2 grabs the 'check' lock, and checks the lockdir.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
330
           It sees the lockdir is already acquired, reports the fact,
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
331
           and unsets the 'checked' lock.
332
        3) Thread1 blocks on acquiring the 'checked' lock, and then tells
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
333
           Lock1 to release and acquire the lockdir. This resets the 'check'
334
           lock.
335
        4) Lock2 acquires the 'check' lock, and checks again. It notices
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
336
           that the holder of the lock has changed, and so reports a new
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
337
           lock holder.
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
338
        5) Thread1 blocks on the 'checked' lock, this time, it completely
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
339
           unlocks the lockdir, allowing Lock2 to acquire the lock.
340
        """
341
3497.1.1 by Martin Pool
xfail test_35_wait_lock_changing
342
        raise tests.KnownFailure(
343
            "timing dependency in lock tests (#213182)")
344
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
345
        wait_to_check_lock = Lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
346
        wait_until_checked_lock = Lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
347
348
        wait_to_check_lock.acquire()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
349
        wait_until_checked_lock.acquire()
350
        note('locked check and checked locks')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
351
352
        class LockDir1(LockDir):
353
            """Use the synchronization points for the first lock."""
354
355
            def attempt_lock(self):
356
                # Once we have acquired the lock, it is okay for
357
                # the other lock to check it
358
                try:
359
                    return super(LockDir1, self).attempt_lock()
360
                finally:
361
                    note('lock1: releasing check lock')
362
                    wait_to_check_lock.release()
363
364
        class LockDir2(LockDir):
365
            """Use the synchronization points for the second lock."""
366
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
367
            def attempt_lock(self):
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
368
                note('lock2: waiting for check lock')
369
                wait_to_check_lock.acquire()
370
                note('lock2: acquired check lock')
371
                try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
372
                    return super(LockDir2, self).attempt_lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
373
                finally:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
374
                    note('lock2: releasing checked lock')
375
                    wait_until_checked_lock.release()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
376
377
        t = self.get_transport()
378
        lf1 = LockDir1(t, 'test_lock')
379
        lf1.create()
380
381
        lf2 = LockDir2(t, 'test_lock')
382
        self.setup_log_reporter(lf2)
383
384
        def wait_and_switch():
385
            lf1.attempt_lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
386
            # Block until lock2 has had a chance to check
387
            note('lock1: waiting 1 for checked lock')
388
            wait_until_checked_lock.acquire()
389
            note('lock1: acquired for checked lock')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
390
            note('lock1: released lockdir')
391
            lf1.unlock()
392
            note('lock1: acquiring lockdir')
393
            # Create a new nonce, so the lock looks different.
394
            lf1.nonce = osutils.rand_chars(20)
395
            lf1.lock_write()
396
            note('lock1: acquired lockdir')
397
398
            # Block until lock2 has peeked again
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
399
            note('lock1: waiting 2 for checked lock')
400
            wait_until_checked_lock.acquire()
401
            note('lock1: acquired for checked lock')
402
            # Now unlock, and let lock 2 grab the lock
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
403
            lf1.unlock()
404
            wait_to_check_lock.release()
405
406
        unlocker = Thread(target=wait_and_switch)
407
        unlocker.start()
408
        try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
409
            # Wait and play against the other thread
2709.1.1 by Martin Pool
Make TestLockDir.test_35_wait_lock_changing less timing-sensitive
410
            lf2.wait_lock(timeout=20.0, poll=0.01)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
411
        finally:
412
            unlocker.join()
413
        lf2.unlock()
414
415
        # There should be 2 reports, because the lock changed
416
        lock_base = lf2.transport.abspath(lf2.path)
417
        self.assertEqual(2, len(self._logged_reports))
3441.4.2 by Martin Albisetti
Fixed failing tests
418
        lock_url = lf2.transport.abspath(lf2.path)
1957.1.15 by John Arbash Meinel
Review feedback from Robert
419
        self.assertEqual('%s %s\n'
420
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
421
                         'Will continue to try until %s, unless '
4960.2.2 by Martin Pool
Tweak Lockdir contention message to suggest reading help break-lock.
422
                         'you press Ctrl-C.\n'
423
                         'See "bzr help break-lock" for more.',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
424
                         self._logged_reports[0][0])
425
        args = self._logged_reports[0][1]
426
        self.assertEqual('Unable to obtain', args[0])
427
        self.assertEqual('lock %s' % (lock_base,), args[1])
428
        self.assertStartsWith(args[2], 'held by ')
429
        self.assertStartsWith(args[3], 'locked ')
430
        self.assertEndsWith(args[3], ' ago')
431
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
432
1957.1.15 by John Arbash Meinel
Review feedback from Robert
433
        self.assertEqual('%s %s\n'
434
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
435
                         'Will continue to try until %s, unless '
4960.2.2 by Martin Pool
Tweak Lockdir contention message to suggest reading help break-lock.
436
                         'you press Ctrl-C.\n'
437
                         'See "bzr help break-lock" for more.',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
438
                         self._logged_reports[1][0])
439
        args = self._logged_reports[1][1]
440
        self.assertEqual('Lock owner changed for', args[0])
441
        self.assertEqual('lock %s' % (lock_base,), args[1])
442
        self.assertStartsWith(args[2], 'held by ')
443
        self.assertStartsWith(args[3], 'locked ')
444
        self.assertEndsWith(args[3], ' ago')
445
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
446
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
447
    def test_40_confirm_easy(self):
448
        """Confirm a lock that's already held"""
449
        t = self.get_transport()
450
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
451
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
452
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
453
        self.addCleanup(lf1.unlock)
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
454
        lf1.confirm()
455
456
    def test_41_confirm_not_held(self):
457
        """Confirm a lock that's already held"""
458
        t = self.get_transport()
459
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
460
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
461
        self.assertRaises(LockNotHeld, lf1.confirm)
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
462
463
    def test_42_confirm_broken_manually(self):
464
        """Confirm a lock broken by hand"""
465
        t = self.get_transport()
466
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
467
        lf1.create()
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
468
        lf1.attempt_lock()
469
        t.move('test_lock', 'lock_gone_now')
470
        self.assertRaises(LockBroken, lf1.confirm)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
471
        # Clean up
472
        t.move('lock_gone_now', 'test_lock')
473
        lf1.unlock()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
474
475
    def test_43_break(self):
476
        """Break a lock whose caller has forgotten it"""
477
        t = self.get_transport()
478
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
479
        lf1.create()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
480
        lf1.attempt_lock()
481
        # we incorrectly discard the lock object without unlocking it
482
        del lf1
483
        # someone else sees it's still locked
484
        lf2 = LockDir(t, 'test_lock')
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
485
        holder_info = lf2.peek()
486
        self.assertTrue(holder_info)
487
        lf2.force_break(holder_info)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
488
        # now we should be able to take it
489
        lf2.attempt_lock()
4327.1.4 by Vincent Ladeuil
Fix lock test failures by taking lock breaking into account.
490
        self.addCleanup(lf2.unlock)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
491
        lf2.confirm()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
492
493
    def test_44_break_already_released(self):
494
        """Lock break races with regular release"""
495
        t = self.get_transport()
496
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
497
        lf1.create()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
498
        lf1.attempt_lock()
499
        # someone else sees it's still locked
500
        lf2 = LockDir(t, 'test_lock')
501
        holder_info = lf2.peek()
502
        # in the interim the lock is released
503
        lf1.unlock()
504
        # break should succeed
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
505
        lf2.force_break(holder_info)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
506
        # now we should be able to take it
507
        lf2.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
508
        self.addCleanup(lf2.unlock)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
509
        lf2.confirm()
510
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
511
    def test_45_break_mismatch(self):
512
        """Lock break races with someone else acquiring it"""
513
        t = self.get_transport()
514
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
515
        lf1.create()
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
516
        lf1.attempt_lock()
517
        # someone else sees it's still locked
518
        lf2 = LockDir(t, 'test_lock')
519
        holder_info = lf2.peek()
520
        # in the interim the lock is released
521
        lf1.unlock()
522
        lf3 = LockDir(t, 'test_lock')
523
        lf3.attempt_lock()
524
        # break should now *fail*
525
        self.assertRaises(LockBreakMismatch, lf2.force_break,
526
                          holder_info)
527
        lf3.unlock()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
528
529
    def test_46_fake_read_lock(self):
530
        t = self.get_transport()
531
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
532
        lf1.create()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
533
        lf1.lock_read()
534
        lf1.unlock()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
535
536
    def test_50_lockdir_representation(self):
537
        """Check the on-disk representation of LockDirs is as expected.
538
539
        There should always be a top-level directory named by the lock.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
540
        When the lock is held, there should be a lockname/held directory
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
541
        containing an info file.
542
        """
543
        t = self.get_transport()
544
        lf1 = LockDir(t, 'test_lock')
545
        lf1.create()
546
        self.assertTrue(t.has('test_lock'))
547
        lf1.lock_write()
548
        self.assertTrue(t.has('test_lock/held/info'))
549
        lf1.unlock()
550
        self.assertFalse(t.has('test_lock/held/info'))
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
551
552
    def test_break_lock(self):
553
        # the ui based break_lock routine should Just Work (tm)
554
        ld1 = self.get_lock()
555
        ld2 = self.get_lock()
556
        ld1.create()
557
        ld1.lock_write()
1687.1.6 by Robert Collins
Extend LockableFiles to support break_lock() calls.
558
        # do this without IO redirection to ensure it doesn't prompt.
559
        self.assertRaises(AssertionError, ld1.break_lock)
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
560
        orig_factory = bzrlib.ui.ui_factory
4449.3.27 by Martin Pool
More test updates to use CannedInputUIFactory
561
        bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
562
        try:
563
            ld2.break_lock()
564
            self.assertRaises(LockBroken, ld1.unlock)
565
        finally:
566
            bzrlib.ui.ui_factory = orig_factory
1955.1.1 by John Arbash Meinel
LockDir can create the root directory if it fails to create a pending directory due to NoSuchFile.
567
568
    def test_create_missing_base_directory(self):
569
        """If LockDir.path doesn't exist, it can be created
570
571
        Some people manually remove the entire lock/ directory trying
572
        to unlock a stuck repository/branch/etc. Rather than failing
573
        after that, just create the lock directory when needed.
574
        """
575
        t = self.get_transport()
576
        lf1 = LockDir(t, 'test_lock')
577
578
        lf1.create()
579
        self.failUnless(t.has('test_lock'))
580
581
        t.rmdir('test_lock')
582
        self.failIf(t.has('test_lock'))
583
584
        # This will create 'test_lock' if it needs to
585
        lf1.lock_write()
586
        self.failUnless(t.has('test_lock'))
587
        self.failUnless(t.has('test_lock/held/info'))
588
589
        lf1.unlock()
590
        self.failIf(t.has('test_lock/held/info'))
1957.1.6 by John Arbash Meinel
[merge] bzr.dev 2009
591
1957.1.5 by John Arbash Meinel
Create a helper function for formatting lock information
592
    def test__format_lock_info(self):
593
        ld1 = self.get_lock()
594
        ld1.create()
595
        ld1.lock_write()
596
        try:
597
            info_list = ld1._format_lock_info(ld1.peek())
598
        finally:
599
            ld1.unlock()
600
        self.assertEqual('lock %s' % (ld1.transport.abspath(ld1.path),),
601
                         info_list[0])
602
        self.assertContainsRe(info_list[1],
603
                              r'^held by .* on host .* \[process #\d*\]$')
604
        self.assertContainsRe(info_list[2], r'locked \d+ seconds? ago$')
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
605
606
    def test_lock_without_email(self):
607
        global_config = config.GlobalConfig()
608
        # Intentionally has no email address
609
        global_config.set_user_option('email', 'User Identity')
610
        ld1 = self.get_lock()
611
        ld1.create()
612
        ld1.lock_write()
613
        ld1.unlock()
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
614
615
    def test_lock_permission(self):
1551.10.4 by Aaron Bentley
Update to skip on win32
616
        if not osutils.supports_posix_readonly():
3107.2.2 by John Arbash Meinel
feedback from Martin.
617
            raise tests.TestSkipped('Cannot induce a permission failure')
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
618
        ld1 = self.get_lock()
619
        lock_path = ld1.transport.local_abspath('test_lock')
620
        os.mkdir(lock_path)
621
        osutils.make_readonly(lock_path)
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
622
        self.assertRaises(errors.LockFailed, ld1.attempt_lock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
623
624
    def test_lock_by_token(self):
625
        ld1 = self.get_lock()
626
        token = ld1.lock_write()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
627
        self.addCleanup(ld1.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
628
        self.assertNotEqual(None, token)
629
        ld2 = self.get_lock()
630
        t2 = ld2.lock_write(token)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
631
        self.addCleanup(ld2.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
632
        self.assertEqual(token, t2)
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
633
634
    def test_lock_with_buggy_rename(self):
635
        # test that lock acquisition handles servers which pretend they
636
        # renamed correctly but that actually fail
637
        t = transport.get_transport('brokenrename+' + self.get_url())
638
        ld1 = LockDir(t, 'test_lock')
639
        ld1.create()
640
        ld1.attempt_lock()
641
        ld2 = LockDir(t, 'test_lock')
2555.3.14 by Martin Pool
Better handling in LockDir of rename that moves one directory within another
642
        # we should fail to lock
643
        e = self.assertRaises(errors.LockContention, ld2.attempt_lock)
644
        # now the original caller should succeed in unlocking
645
        ld1.unlock()
646
        # and there should be nothing left over
647
        self.assertEquals([], t.list_dir('test_lock'))
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
648
649
    def test_failed_lock_leaves_no_trash(self):
650
        # if we fail to acquire the lock, we don't leave pending directories
651
        # behind -- https://bugs.launchpad.net/bzr/+bug/109169
652
        ld1 = self.get_lock()
653
        ld2 = self.get_lock()
654
        # should be nothing before we start
655
        ld1.create()
656
        t = self.get_transport().clone('test_lock')
657
        def check_dir(a):
658
            self.assertEquals(a, t.list_dir('.'))
659
        check_dir([])
660
        # when held, that's all we see
661
        ld1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
662
        self.addCleanup(ld1.unlock)
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
663
        check_dir(['held'])
664
        # second guy should fail
665
        self.assertRaises(errors.LockContention, ld2.attempt_lock)
666
        # no kibble
667
        check_dir(['held'])
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
668
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
669
670
class TestLockDirHooks(TestCaseWithTransport):
671
672
    def setUp(self):
673
        super(TestLockDirHooks, self).setUp()
674
        self._calls = []
675
676
    def get_lock(self):
677
        return LockDir(self.get_transport(), 'test_lock')
678
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
679
    def record_hook(self, result):
680
        self._calls.append(result)
681
3331.3.12 by Martin Pool
Remove PhysicalLock class
682
    def test_LockDir_acquired_success(self):
683
        # the LockDir.lock_acquired hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
684
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
685
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
686
        ld = self.get_lock()
687
        ld.create()
688
        self.assertEqual([], self._calls)
689
        result = ld.attempt_lock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
690
        lock_path = ld.transport.abspath(ld.path)
691
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
692
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
693
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
694
3331.3.12 by Martin Pool
Remove PhysicalLock class
695
    def test_LockDir_acquired_fail(self):
696
        # the LockDir.lock_acquired hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
697
        ld = self.get_lock()
698
        ld.create()
699
        ld2 = self.get_lock()
700
        ld2.attempt_lock()
701
        # install a lock hook now, when the disk lock is locked
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
702
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
703
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
704
        self.assertRaises(errors.LockContention, ld.attempt_lock)
705
        self.assertEqual([], self._calls)
706
        ld2.unlock()
707
        self.assertEqual([], self._calls)
708
3331.3.12 by Martin Pool
Remove PhysicalLock class
709
    def test_LockDir_released_success(self):
710
        # the LockDir.lock_released hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
711
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
712
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
713
        ld = self.get_lock()
714
        ld.create()
715
        self.assertEqual([], self._calls)
716
        result = ld.attempt_lock()
717
        self.assertEqual([], self._calls)
718
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
719
        lock_path = ld.transport.abspath(ld.path)
720
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
721
3331.3.12 by Martin Pool
Remove PhysicalLock class
722
    def test_LockDir_released_fail(self):
723
        # the LockDir.lock_released hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
724
        ld = self.get_lock()
725
        ld.create()
726
        ld2 = self.get_lock()
727
        ld.attempt_lock()
728
        ld2.force_break(ld2.peek())
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
729
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
730
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
731
        self.assertRaises(LockBroken, ld.unlock)
732
        self.assertEqual([], self._calls)
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
733
734
    def test_LockDir_broken_success(self):
735
        # the LockDir.lock_broken hook fires when a lock is broken.
736
        ld = self.get_lock()
737
        ld.create()
738
        ld2 = self.get_lock()
739
        result = ld.attempt_lock()
740
        LockDir.hooks.install_named_hook('lock_broken',
741
                                         self.record_hook, 'record_hook')
742
        ld2.force_break(ld2.peek())
743
        lock_path = ld.transport.abspath(ld.path)
744
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
745
746
    def test_LockDir_broken_failure(self):
747
        # the LockDir.lock_broken hook does not fires when a lock is already
748
        # released.
749
        ld = self.get_lock()
750
        ld.create()
751
        ld2 = self.get_lock()
752
        result = ld.attempt_lock()
753
        holder_info = ld2.peek()
754
        ld.unlock()
755
        LockDir.hooks.install_named_hook('lock_broken',
756
                                         self.record_hook, 'record_hook')
757
        ld2.force_break(holder_info)
758
        lock_path = ld.transport.abspath(ld.path)
759
        self.assertEqual([], self._calls)