~bzr-pqm/bzr/bzr.dev

4763.2.4 by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry.
1
# Copyright (C) 2007-2010 Canonical Ltd
2553.1.1 by Robert Collins
Give Hooks names.
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2553.1.1 by Robert Collins
Give Hooks names.
16
17
"""Tests for the core Hooks logic."""
18
4781.1.1 by Vincent Ladeuil
Hooks daughter classes should always call the base constructor
19
from bzrlib import (
20
    branch,
21
    errors,
22
    tests,
23
    )
2553.1.1 by Robert Collins
Give Hooks names.
24
from bzrlib.hooks import (
4098.2.2 by Robert Collins
Review feedback.
25
    HookPoint,
2553.1.1 by Robert Collins
Give Hooks names.
26
    Hooks,
4119.3.1 by Robert Collins
Create a single registry of all Hooks classes, removing the test suite knowledge of such hooks and allowing plugins to sensibly and safely define new hooks.
27
    known_hooks,
28
    known_hooks_key_to_object,
29
    known_hooks_key_to_parent_and_attribute,
2553.1.1 by Robert Collins
Give Hooks names.
30
    )
4781.1.1 by Vincent Ladeuil
Hooks daughter classes should always call the base constructor
31
32
33
class TestHooks(tests.TestCase):
2553.1.1 by Robert Collins
Give Hooks names.
34
4098.2.1 by Robert Collins
Allow self documenting hooks.
35
    def test_create_hook_first(self):
36
        hooks = Hooks()
37
        doc = ("Invoked after changing the tip of a branch object. Called with"
38
            "a bzrlib.branch.PostChangeBranchTipParams object")
4098.2.2 by Robert Collins
Review feedback.
39
        hook = HookPoint("post_tip_change", doc, (0, 15), None)
4098.2.1 by Robert Collins
Allow self documenting hooks.
40
        hooks.create_hook(hook)
41
        self.assertEqual(hook, hooks['post_tip_change'])
42
43
    def test_create_hook_name_collision_errors(self):
44
        hooks = Hooks()
45
        doc = ("Invoked after changing the tip of a branch object. Called with"
46
            "a bzrlib.branch.PostChangeBranchTipParams object")
4098.2.2 by Robert Collins
Review feedback.
47
        hook = HookPoint("post_tip_change", doc, (0, 15), None)
48
        hook2 = HookPoint("post_tip_change", None, None, None)
4098.2.1 by Robert Collins
Allow self documenting hooks.
49
        hooks.create_hook(hook)
50
        self.assertRaises(errors.DuplicateKey, hooks.create_hook, hook2)
51
        self.assertEqual(hook, hooks['post_tip_change'])
52
53
    def test_docs(self):
54
        """docs() should return something reasonable about the Hooks."""
4108.3.1 by Robert Collins
Include the Hooks class in the Hooks docs.
55
        class MyHooks(Hooks):
56
            pass
57
        hooks = MyHooks()
4098.2.1 by Robert Collins
Allow self documenting hooks.
58
        hooks['legacy'] = []
4098.2.2 by Robert Collins
Review feedback.
59
        hook1 = HookPoint('post_tip_change',
4098.2.1 by Robert Collins
Allow self documenting hooks.
60
            "Invoked after the tip of a branch changes. Called with "
61
            "a ChangeBranchTipParams object.", (1, 4), None)
4098.2.2 by Robert Collins
Review feedback.
62
        hook2 = HookPoint('pre_tip_change',
4098.2.1 by Robert Collins
Allow self documenting hooks.
63
            "Invoked before the tip of a branch changes. Called with "
64
            "a ChangeBranchTipParams object. Hooks should raise "
65
            "TipChangeRejected to signal that a tip change is not permitted.",
66
            (1, 6), None)
67
        hooks.create_hook(hook1)
68
        hooks.create_hook(hook2)
4108.3.1 by Robert Collins
Include the Hooks class in the Hooks docs.
69
        self.assertEqualDiff(
70
            "MyHooks\n"
4119.3.2 by Robert Collins
Migrate existing hooks over to the new HookPoint infrastructure.
71
            "-------\n"
4108.3.1 by Robert Collins
Include the Hooks class in the Hooks docs.
72
            "\n"
4098.2.1 by Robert Collins
Allow self documenting hooks.
73
            "legacy\n"
4119.3.2 by Robert Collins
Migrate existing hooks over to the new HookPoint infrastructure.
74
            "~~~~~~\n"
4098.2.1 by Robert Collins
Allow self documenting hooks.
75
            "\n"
4108.3.1 by Robert Collins
Include the Hooks class in the Hooks docs.
76
            "An old-style hook. For documentation see the __init__ method of 'MyHooks'\n"
4098.2.1 by Robert Collins
Allow self documenting hooks.
77
            "\n"
78
            "post_tip_change\n"
4119.3.2 by Robert Collins
Migrate existing hooks over to the new HookPoint infrastructure.
79
            "~~~~~~~~~~~~~~~\n"
4098.2.1 by Robert Collins
Allow self documenting hooks.
80
            "\n"
81
            "Introduced in: 1.4\n"
82
            "\n"
83
            "Invoked after the tip of a branch changes. Called with a\n"
84
            "ChangeBranchTipParams object.\n"
85
            "\n"
86
            "pre_tip_change\n"
4119.3.2 by Robert Collins
Migrate existing hooks over to the new HookPoint infrastructure.
87
            "~~~~~~~~~~~~~~\n"
4098.2.1 by Robert Collins
Allow self documenting hooks.
88
            "\n"
89
            "Introduced in: 1.6\n"
90
            "\n"
91
            "Invoked before the tip of a branch changes. Called with a\n"
92
            "ChangeBranchTipParams object. Hooks should raise TipChangeRejected to\n"
93
            "signal that a tip change is not permitted.\n", hooks.docs())
94
3256.2.4 by Daniel Watkins
Modified tests to reflect install_named_hook becoming a separate method.
95
    def test_install_named_hook_raises_unknown_hook(self):
96
        hooks = Hooks()
4781.1.1 by Vincent Ladeuil
Hooks daughter classes should always call the base constructor
97
        self.assertRaises(errors.UnknownHook, hooks.install_named_hook, 'silly',
3256.2.4 by Daniel Watkins
Modified tests to reflect install_named_hook becoming a separate method.
98
                          None, "")
99
100
    def test_install_named_hook_appends_known_hook(self):
101
        hooks = Hooks()
3256.2.32 by Ian Clatworthy
tweak hook tests to init the set_rh test when needed
102
        hooks['set_rh'] = []
3256.2.4 by Daniel Watkins
Modified tests to reflect install_named_hook becoming a separate method.
103
        hooks.install_named_hook('set_rh', None, "demo")
104
        self.assertEqual(hooks['set_rh'], [None])
105
106
    def test_install_named_hook_and_retrieve_name(self):
107
        hooks = Hooks()
3256.2.32 by Ian Clatworthy
tweak hook tests to init the set_rh test when needed
108
        hooks['set_rh'] = []
3256.2.4 by Daniel Watkins
Modified tests to reflect install_named_hook becoming a separate method.
109
        hooks.install_named_hook('set_rh', None, "demo")
3256.2.1 by Daniel Watkins
Added tests from Hooks.install_hook with an optional name parameter.
110
        self.assertEqual("demo", hooks.get_hook_name(None))
111
4098.2.1 by Robert Collins
Allow self documenting hooks.
112
4781.1.1 by Vincent Ladeuil
Hooks daughter classes should always call the base constructor
113
class TestHook(tests.TestCase):
4098.2.1 by Robert Collins
Allow self documenting hooks.
114
115
    def test___init__(self):
116
        doc = ("Invoked after changing the tip of a branch object. Called with"
117
            "a bzrlib.branch.PostChangeBranchTipParams object")
4098.2.2 by Robert Collins
Review feedback.
118
        hook = HookPoint("post_tip_change", doc, (0, 15), None)
4098.2.1 by Robert Collins
Allow self documenting hooks.
119
        self.assertEqual(doc, hook.__doc__)
120
        self.assertEqual("post_tip_change", hook.name)
121
        self.assertEqual((0, 15), hook.introduced)
122
        self.assertEqual(None, hook.deprecated)
123
        self.assertEqual([], list(hook))
124
125
    def test_docs(self):
126
        doc = ("Invoked after changing the tip of a branch object. Called with"
127
            " a bzrlib.branch.PostChangeBranchTipParams object")
4098.2.2 by Robert Collins
Review feedback.
128
        hook = HookPoint("post_tip_change", doc, (0, 15), None)
4098.2.1 by Robert Collins
Allow self documenting hooks.
129
        self.assertEqual("post_tip_change\n"
4119.3.2 by Robert Collins
Migrate existing hooks over to the new HookPoint infrastructure.
130
            "~~~~~~~~~~~~~~~\n"
4098.2.1 by Robert Collins
Allow self documenting hooks.
131
            "\n"
132
            "Introduced in: 0.15\n"
133
            "\n"
134
            "Invoked after changing the tip of a branch object. Called with a\n"
135
            "bzrlib.branch.PostChangeBranchTipParams object\n", hook.docs())
136
137
    def test_hook(self):
4098.2.2 by Robert Collins
Review feedback.
138
        hook = HookPoint("foo", "no docs", None, None)
4098.2.1 by Robert Collins
Allow self documenting hooks.
139
        def callback():
140
            pass
141
        hook.hook(callback, "my callback")
142
        self.assertEqual([callback], list(hook))
143
144
    def test___repr(self):
145
        # The repr should list all the callbacks, with names.
4098.2.2 by Robert Collins
Review feedback.
146
        hook = HookPoint("foo", "no docs", None, None)
4098.2.1 by Robert Collins
Allow self documenting hooks.
147
        def callback():
148
            pass
149
        hook.hook(callback, "my callback")
150
        callback_repr = repr(callback)
151
        self.assertEqual(
4098.2.2 by Robert Collins
Review feedback.
152
            '<HookPoint(foo), callbacks=[%s(my callback)]>' %
4098.2.1 by Robert Collins
Allow self documenting hooks.
153
            callback_repr, repr(hook))
4119.3.1 by Robert Collins
Create a single registry of all Hooks classes, removing the test suite knowledge of such hooks and allowing plugins to sensibly and safely define new hooks.
154
155
4781.1.1 by Vincent Ladeuil
Hooks daughter classes should always call the base constructor
156
class TestHookRegistry(tests.TestCase):
4119.3.1 by Robert Collins
Create a single registry of all Hooks classes, removing the test suite knowledge of such hooks and allowing plugins to sensibly and safely define new hooks.
157
158
    def test_items_are_reasonable_keys(self):
159
        # All the items in the known_hooks registry need to map from
160
        # (module_name, member_name) tuples to the callable used to get an
4230.1.2 by James Westby
Update the comments based on those in the test.
161
        # empty Hooks for that attribute. This is used to support the test
4119.3.1 by Robert Collins
Create a single registry of all Hooks classes, removing the test suite knowledge of such hooks and allowing plugins to sensibly and safely define new hooks.
162
        # suite which needs to generate empty hooks (and HookPoints) to ensure
163
        # isolation and prevent tests failing spuriously.
164
        for key, factory in known_hooks.items():
165
            self.assertTrue(callable(factory),
166
                "The factory(%r) for %r is not callable" % (factory, key))
167
            obj = known_hooks_key_to_object(key)
168
            self.assertIsInstance(obj, Hooks)
169
            new_hooks = factory()
170
            self.assertIsInstance(obj, Hooks)
171
            self.assertEqual(type(obj), type(new_hooks))
4781.1.1 by Vincent Ladeuil
Hooks daughter classes should always call the base constructor
172
            self.assertEqual("No hook name", new_hooks.get_hook_name(None))
4119.3.1 by Robert Collins
Create a single registry of all Hooks classes, removing the test suite knowledge of such hooks and allowing plugins to sensibly and safely define new hooks.
173
174
    def test_known_hooks_key_to_object(self):
175
        self.assertIs(branch.Branch.hooks,
176
            known_hooks_key_to_object(('bzrlib.branch', 'Branch.hooks')))
177
178
    def test_known_hooks_key_to_parent_and_attribute(self):
179
        self.assertEqual((branch.Branch, 'hooks'),
180
            known_hooks_key_to_parent_and_attribute(
181
            ('bzrlib.branch', 'Branch.hooks')))
182
        self.assertEqual((branch, 'Branch'),
183
            known_hooks_key_to_parent_and_attribute(
184
            ('bzrlib.branch', 'Branch')))