~bzr-pqm/bzr/bzr.dev

3331.3.5 by Martin Pool
Move physical lock hooks onto new PhysicalLock class variable
1
# Copyright (C) 2006, 2007, 2008 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1553.5.12 by Martin Pool
New LockDir locking mechanism
16
17
"""Tests for LockDir"""
18
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
19
from cStringIO import StringIO
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
20
import os
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
21
from threading import Thread, Lock
1553.5.12 by Martin Pool
New LockDir locking mechanism
22
import time
23
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
24
import bzrlib
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
25
from bzrlib import (
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
26
    config,
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
27
    errors,
3331.3.13 by Martin Pool
Fix up imports
28
    lock,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
29
    osutils,
1551.10.4 by Aaron Bentley
Update to skip on win32
30
    tests,
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
31
    transport,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
32
    )
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
33
from bzrlib.errors import (
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
34
    LockBreakMismatch,
35
    LockBroken,
36
    LockContention,
37
    LockError,
38
    LockFailed,
39
    LockNotHeld,
40
    )
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
41
from bzrlib.lockdir import LockDir
1553.5.33 by Martin Pool
LockDir review comment fixes
42
from bzrlib.tests import TestCaseWithTransport
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
43
from bzrlib.trace import note
1553.5.12 by Martin Pool
New LockDir locking mechanism
44
45
# These tests sometimes use threads to test the behaviour of lock files with
46
# concurrent actors.  This is not a typical (or necessarily supported) use;
47
# they're really meant for guarding between processes.
48
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
49
# These tests are run on the default transport provided by the test framework
50
# (typically a local disk transport).  That can be changed by the --transport
51
# option to bzr selftest.  The required properties of the transport
52
# implementation are tested separately.  (The main requirement is just that
53
# they don't allow overwriting nonempty directories.)
54
1553.5.12 by Martin Pool
New LockDir locking mechanism
55
class TestLockDir(TestCaseWithTransport):
56
    """Test LockDir operations"""
57
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
58
    def logging_report_function(self, fmt, *args):
59
        self._logged_reports.append((fmt, args))
60
61
    def setup_log_reporter(self, lock_dir):
62
        self._logged_reports = []
63
        lock_dir._report_function = self.logging_report_function
64
1553.5.12 by Martin Pool
New LockDir locking mechanism
65
    def test_00_lock_creation(self):
66
        """Creation of lock file on a transport"""
67
        t = self.get_transport()
68
        lf = LockDir(t, 'test_lock')
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
69
        self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
70
71
    def test_01_lock_repr(self):
72
        """Lock string representation"""
73
        lf = LockDir(self.get_transport(), 'test_lock')
74
        r = repr(lf)
75
        self.assertContainsRe(r, r'^LockDir\(.*/test_lock\)$')
76
77
    def test_02_unlocked_peek(self):
78
        lf = LockDir(self.get_transport(), 'test_lock')
79
        self.assertEqual(lf.peek(), None)
80
1687.1.3 by Robert Collins
Make LockDir.unlock check the lock is still intact.
81
    def get_lock(self):
82
        return LockDir(self.get_transport(), 'test_lock')
83
84
    def test_unlock_after_break_raises(self):
85
        ld = self.get_lock()
86
        ld2 = self.get_lock()
87
        ld.create()
88
        ld.attempt_lock()
89
        ld2.force_break(ld2.peek())
90
        self.assertRaises(LockBroken, ld.unlock)
91
1553.5.12 by Martin Pool
New LockDir locking mechanism
92
    def test_03_readonly_peek(self):
93
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
94
        self.assertEqual(lf.peek(), None)
95
96
    def test_10_lock_uncontested(self):
97
        """Acquire and release a lock"""
98
        t = self.get_transport()
99
        lf = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
100
        lf.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
101
        lf.attempt_lock()
102
        try:
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
103
            self.assertTrue(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
104
        finally:
105
            lf.unlock()
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
106
            self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
107
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
108
    def test_11_create_readonly_transport(self):
109
        """Fail to create lock on readonly transport"""
110
        t = self.get_readonly_transport()
111
        lf = LockDir(t, 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
112
        self.assertRaises(LockFailed, lf.create)
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
113
114
    def test_12_lock_readonly_transport(self):
1553.5.12 by Martin Pool
New LockDir locking mechanism
115
        """Fail to lock on readonly transport"""
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
116
        lf = LockDir(self.get_transport(), 'test_lock')
117
        lf.create()
118
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
119
        self.assertRaises(LockFailed, lf.attempt_lock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
120
121
    def test_20_lock_contested(self):
122
        """Contention to get a lock"""
123
        t = self.get_transport()
124
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
125
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
126
        lf1.attempt_lock()
127
        lf2 = LockDir(t, 'test_lock')
128
        try:
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
129
            # locking is between LockDir instances; aliases within
1553.5.12 by Martin Pool
New LockDir locking mechanism
130
            # a single process are not detected
131
            lf2.attempt_lock()
132
            self.fail('Failed to detect lock collision')
133
        except LockContention, e:
134
            self.assertEqual(e.lock, lf2)
135
            self.assertContainsRe(str(e),
136
                    r'^Could not acquire.*test_lock.*$')
137
        lf1.unlock()
138
139
    def test_20_lock_peek(self):
140
        """Peek at the state of a lock"""
141
        t = self.get_transport()
142
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
143
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
144
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
145
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
146
        # lock is held, should get some info on it
147
        info1 = lf1.peek()
148
        self.assertEqual(set(info1.keys()),
149
                         set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
150
        # should get the same info if we look at it through a different
151
        # instance
152
        info2 = LockDir(t, 'test_lock').peek()
153
        self.assertEqual(info1, info2)
154
        # locks which are never used should be not-held
155
        self.assertEqual(LockDir(t, 'other_lock').peek(), None)
156
157
    def test_21_peek_readonly(self):
158
        """Peek over a readonly transport"""
159
        t = self.get_transport()
160
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
161
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
162
        lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
163
        self.assertEqual(lf2.peek(), None)
164
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
165
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
166
        info2 = lf2.peek()
167
        self.assertTrue(info2)
168
        self.assertEqual(info2['nonce'], lf1.nonce)
169
170
    def test_30_lock_wait_fail(self):
171
        """Wait on a lock, then fail
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
172
1553.5.12 by Martin Pool
New LockDir locking mechanism
173
        We ask to wait up to 400ms; this should fail within at most one
174
        second.  (Longer times are more realistic but we don't want the test
175
        suite to take too long, and this should do for now.)
176
        """
177
        t = self.get_transport()
178
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
179
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
180
        lf2 = LockDir(t, 'test_lock')
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
181
        self.setup_log_reporter(lf2)
1553.5.12 by Martin Pool
New LockDir locking mechanism
182
        lf1.attempt_lock()
183
        try:
184
            before = time.time()
185
            self.assertRaises(LockContention, lf2.wait_lock,
186
                              timeout=0.4, poll=0.1)
187
            after = time.time()
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
188
            # it should only take about 0.4 seconds, but we allow more time in
189
            # case the machine is heavily loaded
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
190
            self.assertTrue(after - before <= 8.0,
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
191
                    "took %f seconds to detect lock contention" % (after - before))
1553.5.12 by Martin Pool
New LockDir locking mechanism
192
        finally:
193
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
194
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
195
        self.assertEqual(1, len(self._logged_reports))
3441.4.2 by Martin Albisetti
Fixed failing tests
196
        lock_url = lf2.transport.abspath(lf2.path)
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
197
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
198
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
199
                         'Will continue to try until %s, unless '
200
                         'you press Ctrl-C\n'
201
                         'If you\'re sure that it\'s not being '
202
                         'modified, use bzr break-lock %s',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
203
                         self._logged_reports[0][0])
204
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
205
        self.assertEqual('Unable to obtain', args[0])
206
        self.assertEqual('lock %s' % (lock_base,), args[1])
207
        self.assertStartsWith(args[2], 'held by ')
208
        self.assertStartsWith(args[3], 'locked ')
209
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
210
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1553.5.12 by Martin Pool
New LockDir locking mechanism
211
212
    def test_31_lock_wait_easy(self):
213
        """Succeed when waiting on a lock with no contention.
214
        """
215
        t = self.get_transport()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
216
        lf1 = LockDir(t, 'test_lock')
217
        lf1.create()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
218
        self.setup_log_reporter(lf1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
219
        try:
220
            before = time.time()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
221
            lf1.wait_lock(timeout=0.4, poll=0.1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
222
            after = time.time()
223
            self.assertTrue(after - before <= 1.0)
224
        finally:
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
225
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
226
        self.assertEqual([], self._logged_reports)
1553.5.12 by Martin Pool
New LockDir locking mechanism
227
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
228
    def test_32_lock_wait_succeed(self):
229
        """Succeed when trying to acquire a lock that gets released
230
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
231
        One thread holds on a lock and then releases it; another
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
232
        tries to lock it.
233
        """
1551.15.22 by Aaron Bentley
Redo test skip
234
        # This test sometimes fails like this:
235
        # Traceback (most recent call last):
236
237
        #   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/
238
        # test_lockdir.py", line 247, in test_32_lock_wait_succeed
239
        #     self.assertEqual(1, len(self._logged_reports))
240
        # AssertionError: not equal:
241
        # a = 1
242
        # b = 0
243
        raise tests.TestSkipped("Test fails intermittently")
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
244
        t = self.get_transport()
245
        lf1 = LockDir(t, 'test_lock')
246
        lf1.create()
247
        lf1.attempt_lock()
248
249
        def wait_and_unlock():
250
            time.sleep(0.1)
251
            lf1.unlock()
252
        unlocker = Thread(target=wait_and_unlock)
253
        unlocker.start()
254
        try:
255
            lf2 = LockDir(t, 'test_lock')
256
            self.setup_log_reporter(lf2)
257
            before = time.time()
258
            # wait and then lock
259
            lf2.wait_lock(timeout=0.4, poll=0.1)
260
            after = time.time()
261
            self.assertTrue(after - before <= 1.0)
262
        finally:
263
            unlocker.join()
264
265
        # There should be only 1 report, even though it should have to
266
        # wait for a while
267
        lock_base = lf2.transport.abspath(lf2.path)
268
        self.assertEqual(1, len(self._logged_reports))
269
        self.assertEqual('%s %s\n'
270
                         '%s\n%s\n'
271
                         'Will continue to try until %s\n',
272
                         self._logged_reports[0][0])
273
        args = self._logged_reports[0][1]
274
        self.assertEqual('Unable to obtain', args[0])
275
        self.assertEqual('lock %s' % (lock_base,), args[1])
276
        self.assertStartsWith(args[2], 'held by ')
277
        self.assertStartsWith(args[3], 'locked ')
278
        self.assertEndsWith(args[3], ' ago')
279
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
280
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
281
    def test_34_lock_write_waits(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
282
        """LockDir.lock_write() will wait for the lock."""
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
283
        # the test suite sets the default to 0 to make deadlocks fail fast.
284
        # change it for this test, as we want to try a manual deadlock.
2631.1.4 by Aaron Bentley
Fix test skip
285
        raise tests.TestSkipped('Timing-sensitive test')
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
286
        bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
287
        t = self.get_transport()
288
        lf1 = LockDir(t, 'test_lock')
289
        lf1.create()
290
        lf1.attempt_lock()
291
292
        def wait_and_unlock():
293
            time.sleep(0.1)
294
            lf1.unlock()
295
        unlocker = Thread(target=wait_and_unlock)
296
        unlocker.start()
297
        try:
298
            lf2 = LockDir(t, 'test_lock')
299
            self.setup_log_reporter(lf2)
300
            before = time.time()
301
            # wait and then lock
302
            lf2.lock_write()
303
            after = time.time()
304
        finally:
305
            unlocker.join()
306
307
        # There should be only 1 report, even though it should have to
308
        # wait for a while
309
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
310
        self.assertEqual(1, len(self._logged_reports))
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
311
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
312
                         '%s\n%s\n'
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
313
                         'Will continue to try until %s\n',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
314
                         self._logged_reports[0][0])
315
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
316
        self.assertEqual('Unable to obtain', args[0])
317
        self.assertEqual('lock %s' % (lock_base,), args[1])
318
        self.assertStartsWith(args[2], 'held by ')
319
        self.assertStartsWith(args[3], 'locked ')
320
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
321
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
322
323
    def test_35_wait_lock_changing(self):
324
        """LockDir.wait_lock() will report if the lock changes underneath.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
325
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
326
        This is the stages we want to happen:
327
328
        0) Synchronization locks are created and locked.
329
        1) Lock1 obtains the lockdir, and releases the 'check' lock.
330
        2) Lock2 grabs the 'check' lock, and checks the lockdir.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
331
           It sees the lockdir is already acquired, reports the fact,
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
332
           and unsets the 'checked' lock.
333
        3) Thread1 blocks on acquiring the 'checked' lock, and then tells
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
334
           Lock1 to release and acquire the lockdir. This resets the 'check'
335
           lock.
336
        4) Lock2 acquires the 'check' lock, and checks again. It notices
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
337
           that the holder of the lock has changed, and so reports a new
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
338
           lock holder.
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
339
        5) Thread1 blocks on the 'checked' lock, this time, it completely
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
340
           unlocks the lockdir, allowing Lock2 to acquire the lock.
341
        """
342
3497.1.1 by Martin Pool
xfail test_35_wait_lock_changing
343
        raise tests.KnownFailure(
344
            "timing dependency in lock tests (#213182)")
345
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
346
        wait_to_check_lock = Lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
347
        wait_until_checked_lock = Lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
348
349
        wait_to_check_lock.acquire()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
350
        wait_until_checked_lock.acquire()
351
        note('locked check and checked locks')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
352
353
        class LockDir1(LockDir):
354
            """Use the synchronization points for the first lock."""
355
356
            def attempt_lock(self):
357
                # Once we have acquired the lock, it is okay for
358
                # the other lock to check it
359
                try:
360
                    return super(LockDir1, self).attempt_lock()
361
                finally:
362
                    note('lock1: releasing check lock')
363
                    wait_to_check_lock.release()
364
365
        class LockDir2(LockDir):
366
            """Use the synchronization points for the second lock."""
367
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
368
            def attempt_lock(self):
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
369
                note('lock2: waiting for check lock')
370
                wait_to_check_lock.acquire()
371
                note('lock2: acquired check lock')
372
                try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
373
                    return super(LockDir2, self).attempt_lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
374
                finally:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
375
                    note('lock2: releasing checked lock')
376
                    wait_until_checked_lock.release()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
377
378
        t = self.get_transport()
379
        lf1 = LockDir1(t, 'test_lock')
380
        lf1.create()
381
382
        lf2 = LockDir2(t, 'test_lock')
383
        self.setup_log_reporter(lf2)
384
385
        def wait_and_switch():
386
            lf1.attempt_lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
387
            # Block until lock2 has had a chance to check
388
            note('lock1: waiting 1 for checked lock')
389
            wait_until_checked_lock.acquire()
390
            note('lock1: acquired for checked lock')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
391
            note('lock1: released lockdir')
392
            lf1.unlock()
393
            note('lock1: acquiring lockdir')
394
            # Create a new nonce, so the lock looks different.
395
            lf1.nonce = osutils.rand_chars(20)
396
            lf1.lock_write()
397
            note('lock1: acquired lockdir')
398
399
            # Block until lock2 has peeked again
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
400
            note('lock1: waiting 2 for checked lock')
401
            wait_until_checked_lock.acquire()
402
            note('lock1: acquired for checked lock')
403
            # Now unlock, and let lock 2 grab the lock
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
404
            lf1.unlock()
405
            wait_to_check_lock.release()
406
407
        unlocker = Thread(target=wait_and_switch)
408
        unlocker.start()
409
        try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
410
            # Wait and play against the other thread
2709.1.1 by Martin Pool
Make TestLockDir.test_35_wait_lock_changing less timing-sensitive
411
            lf2.wait_lock(timeout=20.0, poll=0.01)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
412
        finally:
413
            unlocker.join()
414
        lf2.unlock()
415
416
        # There should be 2 reports, because the lock changed
417
        lock_base = lf2.transport.abspath(lf2.path)
418
        self.assertEqual(2, len(self._logged_reports))
3441.4.2 by Martin Albisetti
Fixed failing tests
419
        lock_url = lf2.transport.abspath(lf2.path)
1957.1.15 by John Arbash Meinel
Review feedback from Robert
420
        self.assertEqual('%s %s\n'
421
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
422
                         'Will continue to try until %s, unless '
423
                         'you press Ctrl-C\n'
424
                         'If you\'re sure that it\'s not being '
425
                         'modified, use bzr break-lock %s',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
426
                         self._logged_reports[0][0])
427
        args = self._logged_reports[0][1]
428
        self.assertEqual('Unable to obtain', args[0])
429
        self.assertEqual('lock %s' % (lock_base,), args[1])
430
        self.assertStartsWith(args[2], 'held by ')
431
        self.assertStartsWith(args[3], 'locked ')
432
        self.assertEndsWith(args[3], ' ago')
433
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
434
1957.1.15 by John Arbash Meinel
Review feedback from Robert
435
        self.assertEqual('%s %s\n'
436
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
437
                         'Will continue to try until %s, unless '
438
                         'you press Ctrl-C\n'
439
                         'If you\'re sure that it\'s not being '
440
                         'modified, use bzr break-lock %s',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
441
                         self._logged_reports[1][0])
442
        args = self._logged_reports[1][1]
443
        self.assertEqual('Lock owner changed for', args[0])
444
        self.assertEqual('lock %s' % (lock_base,), args[1])
445
        self.assertStartsWith(args[2], 'held by ')
446
        self.assertStartsWith(args[3], 'locked ')
447
        self.assertEndsWith(args[3], ' ago')
448
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
449
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
450
    def test_40_confirm_easy(self):
451
        """Confirm a lock that's already held"""
452
        t = self.get_transport()
453
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
454
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
455
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
456
        self.addCleanup(lf1.unlock)
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
457
        lf1.confirm()
458
459
    def test_41_confirm_not_held(self):
460
        """Confirm a lock that's already held"""
461
        t = self.get_transport()
462
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
463
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
464
        self.assertRaises(LockNotHeld, lf1.confirm)
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
465
466
    def test_42_confirm_broken_manually(self):
467
        """Confirm a lock broken by hand"""
468
        t = self.get_transport()
469
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
470
        lf1.create()
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
471
        lf1.attempt_lock()
472
        t.move('test_lock', 'lock_gone_now')
473
        self.assertRaises(LockBroken, lf1.confirm)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
474
        # Clean up
475
        t.move('lock_gone_now', 'test_lock')
476
        lf1.unlock()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
477
478
    def test_43_break(self):
479
        """Break a lock whose caller has forgotten it"""
480
        t = self.get_transport()
481
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
482
        lf1.create()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
483
        lf1.attempt_lock()
484
        # we incorrectly discard the lock object without unlocking it
485
        del lf1
486
        # someone else sees it's still locked
487
        lf2 = LockDir(t, 'test_lock')
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
488
        holder_info = lf2.peek()
489
        self.assertTrue(holder_info)
490
        lf2.force_break(holder_info)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
491
        # now we should be able to take it
492
        lf2.attempt_lock()
4327.1.4 by Vincent Ladeuil
Fix lock test failures by taking lock breaking into account.
493
        self.addCleanup(lf2.unlock)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
494
        lf2.confirm()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
495
496
    def test_44_break_already_released(self):
497
        """Lock break races with regular release"""
498
        t = self.get_transport()
499
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
500
        lf1.create()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
501
        lf1.attempt_lock()
502
        # someone else sees it's still locked
503
        lf2 = LockDir(t, 'test_lock')
504
        holder_info = lf2.peek()
505
        # in the interim the lock is released
506
        lf1.unlock()
507
        # break should succeed
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
508
        lf2.force_break(holder_info)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
509
        # now we should be able to take it
510
        lf2.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
511
        self.addCleanup(lf2.unlock)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
512
        lf2.confirm()
513
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
514
    def test_45_break_mismatch(self):
515
        """Lock break races with someone else acquiring it"""
516
        t = self.get_transport()
517
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
518
        lf1.create()
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
519
        lf1.attempt_lock()
520
        # someone else sees it's still locked
521
        lf2 = LockDir(t, 'test_lock')
522
        holder_info = lf2.peek()
523
        # in the interim the lock is released
524
        lf1.unlock()
525
        lf3 = LockDir(t, 'test_lock')
526
        lf3.attempt_lock()
527
        # break should now *fail*
528
        self.assertRaises(LockBreakMismatch, lf2.force_break,
529
                          holder_info)
530
        lf3.unlock()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
531
532
    def test_46_fake_read_lock(self):
533
        t = self.get_transport()
534
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
535
        lf1.create()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
536
        lf1.lock_read()
537
        lf1.unlock()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
538
539
    def test_50_lockdir_representation(self):
540
        """Check the on-disk representation of LockDirs is as expected.
541
542
        There should always be a top-level directory named by the lock.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
543
        When the lock is held, there should be a lockname/held directory
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
544
        containing an info file.
545
        """
546
        t = self.get_transport()
547
        lf1 = LockDir(t, 'test_lock')
548
        lf1.create()
549
        self.assertTrue(t.has('test_lock'))
550
        lf1.lock_write()
551
        self.assertTrue(t.has('test_lock/held/info'))
552
        lf1.unlock()
553
        self.assertFalse(t.has('test_lock/held/info'))
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
554
555
    def test_break_lock(self):
556
        # the ui based break_lock routine should Just Work (tm)
557
        ld1 = self.get_lock()
558
        ld2 = self.get_lock()
559
        ld1.create()
560
        ld1.lock_write()
1687.1.6 by Robert Collins
Extend LockableFiles to support break_lock() calls.
561
        # do this without IO redirection to ensure it doesn't prompt.
562
        self.assertRaises(AssertionError, ld1.break_lock)
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
563
        orig_factory = bzrlib.ui.ui_factory
4449.3.27 by Martin Pool
More test updates to use CannedInputUIFactory
564
        bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
565
        try:
566
            ld2.break_lock()
567
            self.assertRaises(LockBroken, ld1.unlock)
568
        finally:
569
            bzrlib.ui.ui_factory = orig_factory
1955.1.1 by John Arbash Meinel
LockDir can create the root directory if it fails to create a pending directory due to NoSuchFile.
570
571
    def test_create_missing_base_directory(self):
572
        """If LockDir.path doesn't exist, it can be created
573
574
        Some people manually remove the entire lock/ directory trying
575
        to unlock a stuck repository/branch/etc. Rather than failing
576
        after that, just create the lock directory when needed.
577
        """
578
        t = self.get_transport()
579
        lf1 = LockDir(t, 'test_lock')
580
581
        lf1.create()
582
        self.failUnless(t.has('test_lock'))
583
584
        t.rmdir('test_lock')
585
        self.failIf(t.has('test_lock'))
586
587
        # This will create 'test_lock' if it needs to
588
        lf1.lock_write()
589
        self.failUnless(t.has('test_lock'))
590
        self.failUnless(t.has('test_lock/held/info'))
591
592
        lf1.unlock()
593
        self.failIf(t.has('test_lock/held/info'))
1957.1.6 by John Arbash Meinel
[merge] bzr.dev 2009
594
1957.1.5 by John Arbash Meinel
Create a helper function for formatting lock information
595
    def test__format_lock_info(self):
596
        ld1 = self.get_lock()
597
        ld1.create()
598
        ld1.lock_write()
599
        try:
600
            info_list = ld1._format_lock_info(ld1.peek())
601
        finally:
602
            ld1.unlock()
603
        self.assertEqual('lock %s' % (ld1.transport.abspath(ld1.path),),
604
                         info_list[0])
605
        self.assertContainsRe(info_list[1],
606
                              r'^held by .* on host .* \[process #\d*\]$')
607
        self.assertContainsRe(info_list[2], r'locked \d+ seconds? ago$')
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
608
609
    def test_lock_without_email(self):
610
        global_config = config.GlobalConfig()
611
        # Intentionally has no email address
612
        global_config.set_user_option('email', 'User Identity')
613
        ld1 = self.get_lock()
614
        ld1.create()
615
        ld1.lock_write()
616
        ld1.unlock()
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
617
618
    def test_lock_permission(self):
1551.10.4 by Aaron Bentley
Update to skip on win32
619
        if not osutils.supports_posix_readonly():
3107.2.2 by John Arbash Meinel
feedback from Martin.
620
            raise tests.TestSkipped('Cannot induce a permission failure')
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
621
        ld1 = self.get_lock()
622
        lock_path = ld1.transport.local_abspath('test_lock')
623
        os.mkdir(lock_path)
624
        osutils.make_readonly(lock_path)
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
625
        self.assertRaises(errors.LockFailed, ld1.attempt_lock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
626
627
    def test_lock_by_token(self):
628
        ld1 = self.get_lock()
629
        token = ld1.lock_write()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
630
        self.addCleanup(ld1.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
631
        self.assertNotEqual(None, token)
632
        ld2 = self.get_lock()
633
        t2 = ld2.lock_write(token)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
634
        self.addCleanup(ld2.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
635
        self.assertEqual(token, t2)
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
636
637
    def test_lock_with_buggy_rename(self):
638
        # test that lock acquisition handles servers which pretend they
639
        # renamed correctly but that actually fail
640
        t = transport.get_transport('brokenrename+' + self.get_url())
641
        ld1 = LockDir(t, 'test_lock')
642
        ld1.create()
643
        ld1.attempt_lock()
644
        ld2 = LockDir(t, 'test_lock')
2555.3.14 by Martin Pool
Better handling in LockDir of rename that moves one directory within another
645
        # we should fail to lock
646
        e = self.assertRaises(errors.LockContention, ld2.attempt_lock)
647
        # now the original caller should succeed in unlocking
648
        ld1.unlock()
649
        # and there should be nothing left over
650
        self.assertEquals([], t.list_dir('test_lock'))
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
651
652
    def test_failed_lock_leaves_no_trash(self):
653
        # if we fail to acquire the lock, we don't leave pending directories
654
        # behind -- https://bugs.launchpad.net/bzr/+bug/109169
655
        ld1 = self.get_lock()
656
        ld2 = self.get_lock()
657
        # should be nothing before we start
658
        ld1.create()
659
        t = self.get_transport().clone('test_lock')
660
        def check_dir(a):
661
            self.assertEquals(a, t.list_dir('.'))
662
        check_dir([])
663
        # when held, that's all we see
664
        ld1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
665
        self.addCleanup(ld1.unlock)
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
666
        check_dir(['held'])
667
        # second guy should fail
668
        self.assertRaises(errors.LockContention, ld2.attempt_lock)
669
        # no kibble
670
        check_dir(['held'])
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
671
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
672
673
class TestLockDirHooks(TestCaseWithTransport):
674
675
    def setUp(self):
676
        super(TestLockDirHooks, self).setUp()
677
        self._calls = []
678
679
    def get_lock(self):
680
        return LockDir(self.get_transport(), 'test_lock')
681
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
682
    def record_hook(self, result):
683
        self._calls.append(result)
684
3331.3.12 by Martin Pool
Remove PhysicalLock class
685
    def test_LockDir_acquired_success(self):
686
        # the LockDir.lock_acquired hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
687
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
688
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
689
        ld = self.get_lock()
690
        ld.create()
691
        self.assertEqual([], self._calls)
692
        result = ld.attempt_lock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
693
        lock_path = ld.transport.abspath(ld.path)
694
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
695
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
696
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
697
3331.3.12 by Martin Pool
Remove PhysicalLock class
698
    def test_LockDir_acquired_fail(self):
699
        # the LockDir.lock_acquired hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
700
        ld = self.get_lock()
701
        ld.create()
702
        ld2 = self.get_lock()
703
        ld2.attempt_lock()
704
        # install a lock hook now, when the disk lock is locked
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
705
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
706
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
707
        self.assertRaises(errors.LockContention, ld.attempt_lock)
708
        self.assertEqual([], self._calls)
709
        ld2.unlock()
710
        self.assertEqual([], self._calls)
711
3331.3.12 by Martin Pool
Remove PhysicalLock class
712
    def test_LockDir_released_success(self):
713
        # the LockDir.lock_released hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
714
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
715
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
716
        ld = self.get_lock()
717
        ld.create()
718
        self.assertEqual([], self._calls)
719
        result = ld.attempt_lock()
720
        self.assertEqual([], self._calls)
721
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
722
        lock_path = ld.transport.abspath(ld.path)
723
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
724
3331.3.12 by Martin Pool
Remove PhysicalLock class
725
    def test_LockDir_released_fail(self):
726
        # the LockDir.lock_released hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
727
        ld = self.get_lock()
728
        ld.create()
729
        ld2 = self.get_lock()
730
        ld.attempt_lock()
731
        ld2.force_break(ld2.peek())
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
732
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
733
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
734
        self.assertRaises(LockBroken, ld.unlock)
735
        self.assertEqual([], self._calls)
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
736
737
    def test_LockDir_broken_success(self):
738
        # the LockDir.lock_broken hook fires when a lock is broken.
739
        ld = self.get_lock()
740
        ld.create()
741
        ld2 = self.get_lock()
742
        result = ld.attempt_lock()
743
        LockDir.hooks.install_named_hook('lock_broken',
744
                                         self.record_hook, 'record_hook')
745
        ld2.force_break(ld2.peek())
746
        lock_path = ld.transport.abspath(ld.path)
747
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
748
749
    def test_LockDir_broken_failure(self):
750
        # the LockDir.lock_broken hook does not fires when a lock is already
751
        # released.
752
        ld = self.get_lock()
753
        ld.create()
754
        ld2 = self.get_lock()
755
        result = ld.attempt_lock()
756
        holder_info = ld2.peek()
757
        ld.unlock()
758
        LockDir.hooks.install_named_hook('lock_broken',
759
                                         self.record_hook, 'record_hook')
760
        ld2.force_break(holder_info)
761
        lock_path = ld.transport.abspath(ld.path)
762
        self.assertEqual([], self._calls)