~bzr-pqm/bzr/bzr.dev

4763.2.4 by John Arbash Meinel
merge bzr.2.1 in preparation for NEWS entry.
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
62
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
63
    trace,
1551.8.30 by Aaron Bentley
Tweak from review comments
64
    tree,
4222.1.1 by Jelmer Vernooij
Make function for escaping invalid XML characters public.
65
    xml_serializer,
1551.8.30 by Aaron Bentley
Tweak from review comments
66
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
67
from bzrlib.branch import Branch
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
68
from bzrlib.cleanup import OperationWithCleanups
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
69
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
70
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
71
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
72
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
73
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
74
from bzrlib.osutils import (get_user_encoding,
75
                            kind_marker, isdir,isfile, is_inside_any,
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
76
                            is_inside_or_parent_of_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
77
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
78
                            quotefn, sha_file, split_lines,
79
                            splitpath,
80
                            )
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
81
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
82
from bzrlib.trace import mutter, note, warning, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
83
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
84
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
85
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
86
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
87
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
88
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
89
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
90
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
91
92
93
class NullCommitReporter(object):
94
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
95
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
96
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
97
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
98
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
99
                                   "to started.", DeprecationWarning,
100
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
101
        pass
102
103
    def snapshot_change(self, change, path):
104
        pass
105
106
    def completed(self, revno, rev_id):
107
        pass
108
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
109
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
110
        pass
111
112
    def missing(self, path):
113
        pass
114
115
    def renamed(self, change, old_path, new_path):
116
        pass
117
2789.2.11 by Ian Clatworthy
remove more reporting stuff
118
    def is_verbose(self):
119
        return False
120
121
122
class ReportCommitToLog(NullCommitReporter):
123
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
124
    def _note(self, format, *args):
125
        """Output a message.
126
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
127
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
128
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
129
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
130
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
131
    def snapshot_change(self, change, path):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
132
        if path == '' and change in ('added', 'modified'):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
133
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
134
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
135
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
136
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
137
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
138
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
139
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
140
            # When started was added, location was only made optional by
141
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
142
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
143
                                   "to started.", DeprecationWarning,
144
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
145
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
146
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
147
148
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
149
        self._note('Committed revision %d.', revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
150
        # self._note goes to the console too; so while we want to log the
151
        # rev_id, we can't trivially only log it. (See bug 526425). Long
152
        # term we should rearrange the reporting structure, but for now
153
        # we just mutter seperately. We mutter the revid and revno together
154
        # so that concurrent bzr invocations won't lead to confusion.
155
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
156
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
157
    def deleted(self, path):
158
        self._note('deleted %s', path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
159
160
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
161
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
162
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
163
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
164
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
165
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
166
    def is_verbose(self):
167
        return True
168
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
169
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
class Commit(object):
171
    """Task of committing a new revision.
172
173
    This is a MethodObject: it accumulates state as the commit is
174
    prepared, and then it is discarded.  It doesn't represent
175
    historical revisions, just the act of recording a new one.
176
177
            missing_ids
178
            Modified to hold a list of files that have been deleted from
179
            the working directory; these should be removed from the
180
            working inventory.
485 by Martin Pool
- move commit code into its own module
181
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
183
                 reporter=None,
184
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
185
        """Create a Commit object.
186
187
        :param reporter: the default reporter to use or None to decide later
188
        """
189
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
190
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
191
1189 by Martin Pool
- BROKEN: partial support for commit into weave
192
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
193
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
194
               timestamp=None,
195
               timezone=None,
196
               committer=None,
197
               specific_files=None,
198
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
199
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
200
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
201
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
202
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
203
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
204
               local=False,
205
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
206
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
207
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
208
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
209
               exclude=None,
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
210
               possible_master_transports=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
211
        """Commit working copy as a new revision.
212
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
213
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
214
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
215
216
        :param timestamp: if not None, seconds-since-epoch for a
217
            postdated/predated commit.
218
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
219
        :param specific_files: If not None, commit only those files. An empty
220
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
221
222
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
223
            Useful for test or import commands that need to tightly
224
            control what revisions are assigned.  If you duplicate
225
            a revision id that exists elsewhere it is your own fault.
226
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
227
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
228
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
229
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
230
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
231
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
232
            contains unknown files.
233
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
234
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
235
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
236
        :param reporter: the reporter to use or None for the default
237
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
238
        :param recursive: If set to 'down', commit in any subtrees that have
239
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
240
        :param exclude: None or a list of relative paths to exclude from the
241
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
242
            commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
243
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
244
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
245
        self.revprops = revprops or {}
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
246
        return operation.run(
247
               message=message,
248
               timestamp=timestamp,
249
               timezone=timezone,
250
               committer=committer,
251
               specific_files=specific_files,
252
               rev_id=rev_id,
253
               allow_pointless=allow_pointless,
254
               strict=strict,
255
               verbose=verbose,
256
               working_tree=working_tree,
257
               local=local,
258
               reporter=reporter,
259
               config=config,
260
               message_callback=message_callback,
261
               recursive=recursive,
262
               exclude=exclude,
263
               possible_master_transports=possible_master_transports)
264
265
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
266
            specific_files, rev_id, allow_pointless, strict, verbose,
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
267
            working_tree, local, reporter, config, message_callback, recursive,
268
            exclude, possible_master_transports):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
269
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
270
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
271
        if working_tree is None:
272
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
273
        else:
274
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
275
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
276
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
277
                if not self.branch.repository.supports_rich_root():
278
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
279
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
280
            if message is not None:
281
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
282
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
283
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
284
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
285
                raise BzrError("The message or message_callback keyword"
286
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
287
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
288
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
289
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
290
        if exclude is not None:
291
            self.exclude = sorted(
292
                minimum_path_selection(exclude))
293
        else:
294
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
295
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
296
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
297
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
298
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
299
        # self.specific_files is None to indicate no filter, or any iterable to
300
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
301
        if specific_files is not None:
302
            self.specific_files = sorted(
303
                minimum_path_selection(specific_files))
304
        else:
305
            self.specific_files = None
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
306
            
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
307
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
308
        self.message_callback = message_callback
309
        self.timestamp = timestamp
310
        self.timezone = timezone
311
        self.committer = committer
312
        self.strict = strict
313
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
314
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
315
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
316
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
317
        self.parents = self.work_tree.get_parent_ids()
318
        # We can use record_iter_changes IFF iter_changes is compatible with
319
        # the command line parameters, and the repository has fast delta
320
        # generation. See bug 347649.
321
        self.use_record_iter_changes = (
322
            not self.exclude and 
323
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
324
            (self.branch.repository._format.fast_deltas or
325
             len(self.parents) < 2))
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
326
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
327
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
328
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
329
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
330
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
331
        operation.add_cleanup(self.basis_tree.unlock)
332
        # Cannot commit with conflicts present.
333
        if len(self.work_tree.conflicts()) > 0:
334
            raise ConflictsInTree
335
336
        # Setup the bound branch variables as needed.
337
        self._check_bound_branch(operation, possible_master_transports)
338
339
        # Check that the working tree is up to date
340
        old_revno, new_revno = self._check_out_of_date_tree()
341
342
        # Complete configuration setup
343
        if reporter is not None:
344
            self.reporter = reporter
345
        elif self.reporter is None:
346
            self.reporter = self._select_reporter()
347
        if self.config is None:
348
            self.config = self.branch.get_config()
349
350
        self._set_specific_file_ids()
351
352
        # Setup the progress bar. As the number of files that need to be
353
        # committed in unknown, progress is reported as stages.
354
        # We keep track of entries separately though and include that
355
        # information in the progress bar during the relevant stages.
356
        self.pb_stage_name = ""
357
        self.pb_stage_count = 0
358
        self.pb_stage_total = 5
359
        if self.bound_branch:
360
            self.pb_stage_total += 1
361
        self.pb.show_pct = False
362
        self.pb.show_spinner = False
363
        self.pb.show_eta = False
364
        self.pb.show_count = True
365
        self.pb.show_bar = True
366
367
        self._gather_parents()
368
        # After a merge, a selected file commit is not supported.
369
        # See 'bzr help merge' for an explanation as to why.
370
        if len(self.parents) > 1 and self.specific_files is not None:
371
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
372
        # Excludes are a form of selected file commit.
373
        if len(self.parents) > 1 and self.exclude:
374
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
375
376
        # Collect the changes
377
        self._set_progress_stage("Collecting changes", counter=True)
378
        self.builder = self.branch.get_commit_builder(self.parents,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
379
            self.config, timestamp, timezone, committer, self.revprops, rev_id)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
380
1189 by Martin Pool
- BROKEN: partial support for commit into weave
381
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
382
            self.builder.will_record_deletes()
383
            # find the location being committed to
384
            if self.bound_branch:
385
                master_location = self.master_branch.base
386
            else:
387
                master_location = self.branch.base
388
389
            # report the start of the commit
390
            self.reporter.started(new_revno, self.rev_id, master_location)
391
392
            self._update_builder_with_changes()
393
            self._check_pointless()
394
395
            # TODO: Now the new inventory is known, check for conflicts.
396
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
397
            # weave lines, because nothing should be recorded until it is known
398
            # that commit will succeed.
399
            self._set_progress_stage("Saving data locally")
400
            self.builder.finish_inventory()
401
402
            # Prompt the user for a commit message if none provided
403
            message = message_callback(self)
404
            self.message = message
405
406
            # Add revision data to the local branch
407
            self.rev_id = self.builder.commit(self.message)
408
409
        except Exception, e:
410
            mutter("aborting commit write group because of exception:")
411
            trace.log_exception_quietly()
412
            note("aborting commit write group: %r" % (e,))
413
            self.builder.abort()
414
            raise
415
416
        self._process_pre_hooks(old_revno, new_revno)
417
418
        # Upload revision data to the master.
419
        # this will propagate merged revisions too if needed.
420
        if self.bound_branch:
421
            self._set_progress_stage("Uploading data to master branch")
422
            # 'commit' to the master first so a timeout here causes the
423
            # local branch to be out of date
424
            self.master_branch.import_last_revision_info(
425
                self.branch.repository, new_revno, self.rev_id)
426
427
        # and now do the commit locally.
428
        self.branch.set_last_revision_info(new_revno, self.rev_id)
429
430
        # Make the working tree be up to date with the branch. This
431
        # includes automatic changes scheduled to be made to the tree, such
432
        # as updating its basis and unversioning paths that were missing.
433
        self.work_tree.unversion(self.deleted_ids)
434
        self._set_progress_stage("Updating the working tree")
435
        self.work_tree.update_basis_by_delta(self.rev_id,
436
             self.builder.get_basis_delta())
437
        self.reporter.completed(new_revno, self.rev_id)
438
        self._process_post_hooks(old_revno, new_revno)
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
439
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
440
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
441
    def _select_reporter(self):
442
        """Select the CommitReporter to use."""
443
        if is_quiet():
444
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
445
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
446
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
447
    def _check_pointless(self):
448
        if self.allow_pointless:
449
            return
450
        # A merge with no effect on files
451
        if len(self.parents) > 1:
452
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
453
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
454
2921.4.6 by Robert Collins
Typos found by Rob Weir.
455
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
456
        # a worthwhile commit.
457
        if (self.basis_revid == revision.NULL_REVISION and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
458
            ((self.builder.new_inventory is not None and
459
             len(self.builder.new_inventory) == 1) or
460
            len(self.builder._basis_delta) == 1)):
1731.1.49 by Aaron Bentley
Merge bzr.dev
461
            raise PointlessCommit()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
462
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
463
            return
464
        raise PointlessCommit()
465
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
466
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
467
        """Check to see if the local branch is bound.
468
469
        If it is bound, then most of the commit will actually be
470
        done using the remote branch as the target branch.
471
        Only at the end will the local branch be updated.
472
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
473
        if self.local and not self.branch.get_bound_location():
474
            raise errors.LocalRequiresBoundBranch()
475
476
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
477
            self.master_branch = self.branch.get_master_branch(
478
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
479
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
480
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
481
            # make this branch the reference branch for out of date checks.
482
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
483
            return
484
485
        # If the master branch is bound, we must fail
486
        master_bound_location = self.master_branch.get_bound_location()
487
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
488
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
489
                    self.master_branch, master_bound_location)
490
491
        # TODO: jam 20051230 We could automatically push local
492
        #       commits to the remote branch if they would fit.
493
        #       But for now, just require remote to be identical
494
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
495
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
496
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
497
        master_info = self.master_branch.last_revision_info()
498
        local_info = self.branch.last_revision_info()
499
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
500
            raise errors.BoundBranchOutOfDate(self.branch,
501
                    self.master_branch)
502
503
        # Now things are ready to change the master branch
504
        # so grab the lock
505
        self.bound_branch = self.branch
506
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
507
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
508
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
509
    def _check_out_of_date_tree(self):
510
        """Check that the working tree is up to date.
511
512
        :return: old_revision_number,new_revision_number tuple
513
        """
514
        try:
515
            first_tree_parent = self.work_tree.get_parent_ids()[0]
516
        except IndexError:
517
            # if there are no parents, treat our parent as 'None'
518
            # this is so that we still consider the master branch
519
            # - in a checkout scenario the tree may have no
520
            # parents but the branch may do.
521
            first_tree_parent = bzrlib.revision.NULL_REVISION
522
        old_revno, master_last = self.master_branch.last_revision_info()
523
        if master_last != first_tree_parent:
524
            if master_last != bzrlib.revision.NULL_REVISION:
525
                raise errors.OutOfDateTree(self.work_tree)
526
        if self.branch.repository.has_revision(first_tree_parent):
527
            new_revno = old_revno + 1
528
        else:
529
            # ghost parents never appear in revision history.
530
            new_revno = 1
531
        return old_revno,new_revno
532
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
533
    def _process_pre_hooks(self, old_revno, new_revno):
534
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
535
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
536
        self._process_hooks("pre_commit", old_revno, new_revno)
537
538
    def _process_post_hooks(self, old_revno, new_revno):
539
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
540
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
541
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
542
        # old style commit hooks - should be deprecated ? (obsoleted in
543
        # 0.15)
544
        if self.config.post_commit() is not None:
545
            hooks = self.config.post_commit().split(' ')
546
            # this would be nicer with twisted.python.reflect.namedAny
547
            for hook in hooks:
548
                result = eval(hook + '(branch, rev_id)',
549
                              {'branch':self.branch,
550
                               'bzrlib':bzrlib,
551
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
552
        # process new style post commit hooks
553
        self._process_hooks("post_commit", old_revno, new_revno)
554
555
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
556
        if not Branch.hooks[hook_name]:
557
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
558
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
559
        # new style commit hooks:
560
        if not self.bound_branch:
561
            hook_master = self.branch
562
            hook_local = None
563
        else:
564
            hook_master = self.master_branch
565
            hook_local = self.branch
566
        # With bound branches, when the master is behind the local branch,
567
        # the 'old_revno' and old_revid values here are incorrect.
568
        # XXX: FIXME ^. RBC 20060206
569
        if self.parents:
570
            old_revid = self.parents[0]
571
        else:
572
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
573
2659.3.9 by NamNguyen
branch.py:
574
        if hook_name == "pre_commit":
575
            future_tree = self.builder.revision_tree()
576
            tree_delta = future_tree.changes_from(self.basis_tree,
577
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
578
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
579
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
580
            # show the running hook in the progress bar. As hooks may
581
            # end up doing nothing (e.g. because they are not configured by
582
            # the user) this is still showing progress, not showing overall
583
            # actions - its up to each plugin to show a UI if it want's to
584
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
585
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
586
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
587
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
588
            if 'hooks' in debug.debug_flags:
589
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
590
            if hook_name == "post_commit":
591
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
592
                     self.rev_id)
593
            elif hook_name == "pre_commit":
594
                hook(hook_local, hook_master,
595
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
596
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
597
1223 by Martin Pool
- store inventories in weave
598
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
599
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
600
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
601
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
602
        if self.use_record_iter_changes:
603
            return
604
        self.basis_inv = self.basis_tree.inventory
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
605
        self.parent_invs = [self.basis_inv]
606
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
607
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
608
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
609
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
610
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
611
            else:
612
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
613
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
614
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
615
        """Update the commit builder with the data about what has changed.
616
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
617
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
618
        specific_files = self.specific_files
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
619
        mutter("Selecting files for commit with filter %s", specific_files)
620
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
621
        self._check_strict()
622
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
623
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
624
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
625
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
626
            for file_id, path, fs_hash in self.builder.record_iter_changes(
627
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
628
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
629
        else:
630
            # Build the new inventory
631
            self._populate_from_inventory()
632
            self._record_unselected()
633
            self._report_and_accumulate_deletes()
634
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
635
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
636
        """Process iter_changes.
637
638
        This method reports on the changes in iter_changes to the user, and 
639
        converts 'missing' entries in the iter_changes iterator to 'deleted'
640
        entries. 'missing' entries have their
641
642
        :param iter_changes: An iter_changes to process.
643
        :return: A generator of changes.
644
        """
645
        reporter = self.reporter
646
        report_changes = reporter.is_verbose()
647
        deleted_ids = []
648
        for change in iter_changes:
649
            if report_changes:
650
                old_path = change[1][0]
651
                new_path = change[1][1]
652
                versioned = change[3][1]
653
            kind = change[6][1]
654
            versioned = change[3][1]
655
            if kind is None and versioned:
656
                # 'missing' path
657
                if report_changes:
658
                    reporter.missing(new_path)
659
                deleted_ids.append(change[0])
660
                # Reset the new path (None) and new versioned flag (False)
661
                change = (change[0], (change[1][0], None), change[2],
662
                    (change[3][0], False)) + change[4:]
663
            elif kind == 'tree-reference':
664
                if self.recursive == 'down':
665
                    self._commit_nested_tree(change[0], change[1][1])
666
            if change[3][0] or change[3][1]:
667
                yield change
668
                if report_changes:
669
                    if new_path is None:
670
                        reporter.deleted(old_path)
671
                    elif old_path is None:
672
                        reporter.snapshot_change('added', new_path)
673
                    elif old_path != new_path:
674
                        reporter.renamed('renamed', old_path, new_path)
675
                    else:
676
                        if (new_path or 
677
                            self.work_tree.branch.repository._format.rich_root_data):
678
                            # Don't report on changes to '' in non rich root
679
                            # repositories.
680
                            reporter.snapshot_change('modified', new_path)
681
            self._next_progress_entry()
682
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
683
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
684
685
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
686
        # If specific files are selected, then all un-selected files must be
687
        # recorded in their previous state. For more details, see
688
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
689
        if self.specific_files or self.exclude:
690
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
691
            for path, old_ie in self.basis_inv.iter_entries():
692
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
693
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
694
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
695
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
696
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
697
                    # was inside the selected path, and not excluded - if not
698
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
699
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
700
                # From here down it was either not selected, or was excluded:
701
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
702
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
703
                # Note: specific file commits after a merge are currently
704
                # prohibited. This test is for sanity/safety in case it's
705
                # required after that changes.
706
                if len(self.parents) > 1:
707
                    ie.revision = None
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
708
                self.builder.record_entry_contents(ie, self.parent_invs, path,
709
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
710
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
711
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
712
        if (isinstance(self.basis_inv, Inventory)
713
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
714
            # the older Inventory classes provide a _byid dict, and building a
715
            # set from the keys of this dict is substantially faster than even
716
            # getting a set of ids from the inventory
717
            #
718
            # <lifeless> set(dict) is roughly the same speed as
719
            # set(iter(dict)) and both are significantly slower than
720
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
721
            deleted_ids = set(self.basis_inv._byid.keys()) - \
722
               set(self.builder.new_inventory._byid.keys())
723
        else:
724
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
725
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
726
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
727
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
728
                for file_id in deleted_ids]
729
            deleted.sort()
730
            # XXX: this is not quite directory-order sorting
731
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
732
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
733
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
734
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
735
    def _check_strict(self):
736
        # XXX: when we use iter_changes this would likely be faster if
737
        # iter_changes would check for us (even in the presence of
738
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
739
        if self.strict:
740
            # raise an exception as soon as we find a single unknown.
741
            for unknown in self.work_tree.unknowns():
742
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
743
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
744
    def _populate_from_inventory(self):
745
        """Populate the CommitBuilder by walking the working tree inventory."""
746
        # Build the revision inventory.
747
        #
748
        # This starts by creating a new empty inventory. Depending on
749
        # which files are selected for commit, and what is present in the
750
        # current tree, the new inventory is populated. inventory entries
751
        # which are candidates for modification have their revision set to
752
        # None; inventory entries that are carried over untouched have their
753
        # revision set to their prior value.
754
        #
755
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
756
        # results to create a new inventory at the same time, which results
757
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
758
        # ADHB 11-07-2006
759
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
760
        specific_files = self.specific_files
761
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
762
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
763
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
764
        # A tree of paths that have been deleted. E.g. if foo/bar has been
765
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
766
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
767
        # XXX: Note that entries may have the wrong kind because the entry does
768
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
769
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
770
        # NB: entries will include entries within the excluded ids/paths
771
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
772
        entries = work_inv.iter_entries_by_dir(
773
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
774
        for path, existing_ie in entries:
775
            file_id = existing_ie.file_id
776
            name = existing_ie.name
777
            parent_id = existing_ie.parent_id
778
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
779
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
780
            # The deleted path ids are also recorded so they can be explicitly
781
            # unversioned later.
782
            if deleted_paths:
783
                path_segments = splitpath(path)
784
                deleted_dict = deleted_paths
785
                for segment in path_segments:
786
                    deleted_dict = deleted_dict.get(segment, None)
787
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
788
                        # We either took a path not present in the dict
789
                        # (deleted_dict was None), or we've reached an empty
790
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
791
                        break
792
                else:
793
                    deleted_dict = None
794
                if deleted_dict is not None:
795
                    # the path has a deleted parent, do not add it.
796
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
797
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
798
                # Skip excluded paths. Excluded paths are processed by
799
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
800
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
801
            content_summary = self.work_tree.path_content_summary(path)
802
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
803
            # Note that when a filter of specific files is given, we must only
804
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
805
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
806
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
807
                    if not deleted_paths:
808
                        # path won't have been split yet.
809
                        path_segments = splitpath(path)
810
                    deleted_dict = deleted_paths
811
                    for segment in path_segments:
812
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
813
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
814
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
815
                    deleted_ids.append(file_id)
816
                    continue
4595.11.14 by Martin Pool
Small code cleanups
817
            # TODO: have the builder do the nested commit just-in-time IF and
818
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
819
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
820
                # enforce repository nested tree policy.
821
                if (not self.work_tree.supports_tree_reference() or
822
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
823
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
824
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
825
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
826
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
827
                    nested_revision_id = self._commit_nested_tree(
828
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
829
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
830
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
831
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
832
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
833
834
            # Record an entry for this item
835
            # Note: I don't particularly want to have the existing_ie
836
            # parameter but the test suite currently (28-Jun-07) breaks
837
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
838
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
839
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
840
                parent_id, definitely_changed, existing_ie, report_changes,
841
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
842
843
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
844
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
845
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
846
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
847
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
848
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
849
        # FIXME: be more comprehensive here:
850
        # this works when both trees are in --trees repository,
851
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
852
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
853
        # finally implement the explicit-caches approach design
854
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
855
        if sub_tree.branch.repository.has_same_location(
856
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
857
            sub_tree.branch.repository = \
858
                self.work_tree.branch.repository
859
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
860
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
861
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
862
                message_callback=self.message_callback,
863
                timestamp=self.timestamp, timezone=self.timezone,
864
                committer=self.committer,
865
                allow_pointless=self.allow_pointless,
866
                strict=self.strict, verbose=self.verbose,
867
                local=self.local, reporter=self.reporter)
868
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
869
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
870
871
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
872
        parent_id, definitely_changed, existing_ie, report_changes,
873
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
874
        "Record the new inventory entry for a path if any."
875
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
876
        # mutter('%s selected for commit', path)
877
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
878
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
879
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
880
            ie = existing_ie.copy()
881
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
882
        # For carried over entries we don't care about the fs hash - the repo
883
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
884
        _, _, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
885
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
886
        if report_changes:
887
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
888
        if fs_hash:
889
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
890
        return ie
891
892
    def _report_change(self, ie, path):
893
        """Report a change to the user.
894
895
        The change that has occurred is described relative to the basis
896
        inventory.
897
        """
898
        if (self.basis_inv.has_id(ie.file_id)):
899
            basis_ie = self.basis_inv[ie.file_id]
900
        else:
901
            basis_ie = None
902
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
903
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
904
            InventoryEntry.MODIFIED_AND_RENAMED):
905
            old_path = self.basis_inv.id2path(ie.file_id)
906
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
907
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
908
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
909
            if change == 'unchanged':
910
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
911
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
912
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
913
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
914
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
915
        """Set the progress stage and emit an update to the progress bar."""
916
        self.pb_stage_name = name
917
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
918
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
919
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
920
        else:
921
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
922
        self._emit_progress()
923
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
924
    def _next_progress_entry(self):
925
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
926
        self.pb_entries_count += 1
927
        self._emit_progress()
928
929
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
930
        if self.pb_entries_count is not None:
931
            text = "%s [%d] - Stage" % (self.pb_stage_name,
932
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
933
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
934
            text = "%s - Stage" % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
935
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
936
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
937
    def _set_specific_file_ids(self):
938
        """populate self.specific_file_ids if we will use it."""
939
        if not self.use_record_iter_changes:
940
            # If provided, ensure the specified files are versioned
941
            if self.specific_files is not None:
942
                # Note: This routine is being called because it raises
943
                # PathNotVersionedError as a side effect of finding the IDs. We
944
                # later use the ids we found as input to the working tree
945
                # inventory iterator, so we only consider those ids rather than
946
                # examining the whole tree again.
947
                # XXX: Dont we have filter_unversioned to do this more
948
                # cheaply?
949
                self.specific_file_ids = tree.find_ids_across_trees(
950
                    self.specific_files, [self.basis_tree, self.work_tree])
951
            else:
952
                self.specific_file_ids = None