~bzr-pqm/bzr/bzr.dev

2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
1
# Copyright (C) 2007 Canonical Ltd
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
16
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
17
from bzrlib import registry, help_topics
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
18
from bzrlib.lazy_import import lazy_import
19
lazy_import(globals(), """
2376.4.17 by Jonathan Lange
Use urlutils.join instead of ugly, buggy, string mashing
20
from bzrlib import errors, urlutils
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
21
""")
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
22
23
2376.4.7 by jml at canonical
- Add docstrings to tests.
24
"""Provides a shorthand for referring to bugs on a variety of bug trackers.
25
26
'commit --fixes' stores references to bugs as a <bug_url> -> <bug_status>
27
mapping in the properties for that revision.
28
29
However, it's inconvenient to type out full URLs for bugs on the command line,
30
particularly given that many users will be using only a single bug tracker per
31
branch.
32
33
Thus, this module provides a registry of types of bug tracker (e.g. Launchpad,
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
34
Trac). Given an abbreviated name (e.g. 'lp', 'twisted') and a branch with
2376.4.7 by jml at canonical
- Add docstrings to tests.
35
configuration information, these tracker types can return an instance capable
36
of converting bug IDs into URLs.
37
"""
38
39
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
40
_bugs_help = \
41
"""When making a commit, metadata about bugs fixed by that change can be
42
recorded by using the --fixes option. For each bug marked as fixed, an
43
entry is included in the 'bugs' revision property stating '<url> <status>'.
3154.1.1 by Ian Clatworthy
Minor tweaks to bug tracker integration documentation
44
(The only ``status`` value currently supported is ``fixed.``)
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
45
46
The --fixes option allows you to specify a bug tracker and a bug identifier
47
rather than a full URL. This looks like
48
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
49
    bzr commit --fixes <tracker>:<id>
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
50
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
51
where "<tracker>" is an identifier for the bug tracker, and "<id>" is the
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
52
identifier for that bug within the bugtracker, usually the bug number.
53
3535.10.5 by James Westby
Don't say "well-known" as suggested by Robert.
54
Bazaar knows about a few bug trackers that have many users. If
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
55
you use one of these bug trackers then there is no setup required to
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
56
use this feature, you just need to know the tracker identifier to use.
57
These are the bugtrackers that are built in:
58
3535.10.10 by James Westby
Change "Tracker id" to "Abbreviation" to be less ambiguous.
59
     URL                          | Abbreviation | Example
60
     https://bugs.launchpad.net/  | lp           | lp:12345
61
     http://bugs.debian.org/      | deb          | deb:12345
62
     http://bugzilla.gnome.org/   | gnome        | gnome:12345
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
63
3535.10.5 by James Westby
Don't say "well-known" as suggested by Robert.
64
For the bug trackers not listed above configuration is required.
65
Support for generating the URLs for any project using Bugzilla or Trac
66
is built in, along with a template mechanism for other bugtrackers with
3535.10.6 by James Westby
Mention that the a plugin can support their tracker as the last resort.
67
simple URL schemes. If your bug tracker can't be described by one
68
of the schemes described below then you can write a plugin to support
69
it.
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
70
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
71
If you use Bugzilla or Trac, then you only need to set a configuration
72
variable which contains the base URL of the bug tracker. These options
73
can go into ``bazaar.conf``, ``branch.conf`` or into a branch-specific
74
configuration section in ``locations.conf``.  You can set up these values
75
for each of the projects you work on.
76
77
Note: As you provide a short name for each tracker, you can specify one or
78
more bugs in one or more trackers at commit time if you wish.
79
3860.2.1 by Martin Pool
Mention in 'help bugs' the syntax for Launchpad
80
Launchpad
81
---------
82
83
Use ``bzr commit --fixes lp:2`` to record that this commit fixes bug 2.
84
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
85
bugzilla_<tracker_abbreviation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
86
-----------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
87
88
If present, the location of the Bugzilla bug tracker referred to by
89
<tracker_abbreviation>. This option can then be used together with ``bzr commit
90
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
91
example::
92
93
    bugzilla_squid_url = http://www.squid-cache.org/bugs
94
95
would allow ``bzr commit --fixes squid:1234`` to mark Squid's bug 1234 as
96
fixed.
97
98
trac_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
99
------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
100
101
If present, the location of the Trac instance referred to by
102
<tracker_abbreviation>. This option can then be used together with ``bzr commit
103
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
104
example::
105
106
    trac_twisted_url = http://www.twistedmatrix.com/trac
107
108
would allow ``bzr commit --fixes twisted:1234`` to mark Twisted's bug 1234 as
109
fixed.
110
111
bugtracker_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
112
------------------------------------
113
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
114
If present, the location of a generic bug tracker instance referred to by
115
<tracker_abbreviation>. The location must contain an ``{id}`` placeholder,
116
which will be replaced by a specific bug ID. This option can then be used
117
together with ``bzr commit --fixes`` to mark bugs in that tracker as being
118
fixed by that commit. For example::
119
120
    bugtracker_python_url = http://bugs.python.org/issue{id}
121
122
would allow ``bzr commit --fixes python:1234`` to mark bug 1234 in Python's
123
Roundup bug tracker as fixed, or::
124
125
    bugtracker_cpan_url = http://rt.cpan.org/Public/Bug/Display.html?id={id}
126
127
for CPAN's RT bug tracker.
128
"""
129
130
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
131
def get_bug_url(abbreviated_bugtracker_name, branch, bug_id):
132
    """Return a URL pointing to the canonical web page of the bug identified by
133
    'bug_id'.
134
    """
135
    tracker = tracker_registry.get_tracker(abbreviated_bugtracker_name, branch)
136
    return tracker.get_bug_url(bug_id)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
137
138
139
class TrackerRegistry(registry.Registry):
140
    """Registry of bug tracker types."""
141
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
142
    def get_tracker(self, abbreviated_bugtracker_name, branch):
143
        """Return the first registered tracker that understands
144
        'abbreviated_bugtracker_name'.
2376.4.7 by jml at canonical
- Add docstrings to tests.
145
146
        If no such tracker is found, raise KeyError.
147
        """
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
148
        for tracker_name in self.keys():
149
            tracker_type = self.get(tracker_name)
150
            tracker = tracker_type.get(abbreviated_bugtracker_name, branch)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
151
            if tracker is not None:
152
                return tracker
2376.4.28 by Jonathan Lange
Focus the tests better and clean up some dodgy bits in UnknownBugTrackerAbbreviation
153
        raise errors.UnknownBugTrackerAbbreviation(abbreviated_bugtracker_name,
154
                                                   branch)
2376.4.7 by jml at canonical
- Add docstrings to tests.
155
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
156
    def help_topic(self, topic):
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
157
        return _bugs_help
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
158
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
159
160
tracker_registry = TrackerRegistry()
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
161
"""Registry of bug trackers."""
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
162
2376.4.15 by Jonathan Lange
Whitespace cleanup
163
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
164
class BugTracker(object):
165
    """Base class for bug trackers."""
166
167
    def check_bug_id(self, bug_id):
168
        """Check that the bug_id is valid.
169
170
        The base implementation assumes that all bug_ids are valid.
171
        """
172
173
    def get_bug_url(self, bug_id):
174
        """Return the URL for bug_id. Raise an error if bug ID is malformed."""
175
        self.check_bug_id(bug_id)
176
        return self._get_bug_url(bug_id)
177
178
    def _get_bug_url(self, bug_id):
179
        """Given a validated bug_id, return the bug's web page's URL."""
180
181
182
class IntegerBugTracker(BugTracker):
183
    """A bug tracker that only allows integer bug IDs."""
184
185
    def check_bug_id(self, bug_id):
186
        try:
187
            int(bug_id)
188
        except ValueError:
189
            raise errors.MalformedBugIdentifier(bug_id, "Must be an integer")
190
191
192
class UniqueIntegerBugTracker(IntegerBugTracker):
2376.4.19 by Jonathan Lange
Rename SimpleBugTracker to UniqueBugTracker
193
    """A style of bug tracker that exists in one place only, such as Launchpad.
2376.4.15 by Jonathan Lange
Whitespace cleanup
194
2376.4.41 by Jonathan Lange
Update UniqueIntegerBugTracker docstring for new API
195
    If you have one of these trackers then register an instance passing in an
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
196
    abbreviated name for the bug tracker and a base URL. The bug ids are
197
    appended directly to the URL.
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
198
    """
199
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
200
    def __init__(self, abbreviated_bugtracker_name, base_url):
201
        self.abbreviation = abbreviated_bugtracker_name
202
        self.base_url = base_url
203
204
    def get(self, abbreviated_bugtracker_name, branch):
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
205
        """Returns the tracker if the abbreviation matches. Returns None
206
        otherwise."""
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
207
        if abbreviated_bugtracker_name != self.abbreviation:
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
208
            return None
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
209
        return self
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
210
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
211
    def _get_bug_url(self, bug_id):
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
212
        """Return the URL for bug_id."""
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
213
        return self.base_url + bug_id
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
214
215
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
216
tracker_registry.register(
217
    'launchpad', UniqueIntegerBugTracker('lp', 'https://launchpad.net/bugs/'))
218
219
220
tracker_registry.register(
2376.4.29 by Jonathan Lange
Tests for builtin trackers.
221
    'debian', UniqueIntegerBugTracker('deb', 'http://bugs.debian.org/'))
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
222
2376.4.15 by Jonathan Lange
Whitespace cleanup
223
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
224
tracker_registry.register('gnome',
225
    UniqueIntegerBugTracker('gnome', 'http://bugzilla.gnome.org/show_bug.cgi?id='))
226
227
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
228
class URLParametrizedIntegerBugTracker(IntegerBugTracker):
229
    """A type of bug tracker that can be found on a variety of different sites,
230
    and thus needs to have the base URL configured.
231
232
    Looks for a config setting in the form '<type_name>_<abbreviation>_url'.
233
    `type_name` is the name of the type of tracker (e.g. 'bugzilla' or 'trac')
234
    and `abbreviation` is a short name for the particular instance (e.g.
235
    'squid' or 'apache').
236
    """
237
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
238
    def get(self, abbreviation, branch):
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
239
        config = branch.get_config()
240
        url = config.get_user_option(
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
241
            "%s_%s_url" % (self.type_name, abbreviation))
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
242
        if url is None:
243
            return None
244
        self._base_url = url
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
245
        return self
246
247
    def __init__(self, type_name, bug_area):
248
        self.type_name = type_name
249
        self._bug_area = bug_area
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
250
251
    def _get_bug_url(self, bug_id):
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
252
        """Return a URL for a bug on this Trac instance."""
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
253
        return urlutils.join(self._base_url, self._bug_area) + str(bug_id)
254
255
256
tracker_registry.register(
257
    'trac', URLParametrizedIntegerBugTracker('trac', 'ticket/'))
258
259
tracker_registry.register(
260
    'bugzilla',
261
    URLParametrizedIntegerBugTracker('bugzilla', 'show_bug.cgi?id='))
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
262
263
264
class GenericBugTracker(URLParametrizedIntegerBugTracker):
265
    """Generic bug tracker specified by an URL template."""
266
267
    def __init__(self):
3035.3.2 by Lukáš Lalinský
Add tests for InvalidBugTrackerURL.
268
        super(GenericBugTracker, self).__init__('bugtracker', None)
269
270
    def get(self, abbreviation, branch):
271
        self._abbreviation = abbreviation
272
        return super(GenericBugTracker, self).get(abbreviation, branch)
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
273
274
    def _get_bug_url(self, bug_id):
275
        """Given a validated bug_id, return the bug's web page's URL."""
276
        if '{id}' not in self._base_url:
277
            raise errors.InvalidBugTrackerURL(self._abbreviation,
278
                                              self._base_url)
279
        return self._base_url.replace('{id}', str(bug_id))
280
281
282
tracker_registry.register('generic', GenericBugTracker())
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
283
284
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
285
FIXED = 'fixed'
286
4119.4.3 by Jonathan Lange
Add Revision.iter_bugs.
287
ALLOWED_BUG_STATUSES = set([FIXED])
288
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
289
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
290
def encode_fixes_bug_urls(bug_urls):
4119.4.5 by Jonathan Lange
Fix the docstring.
291
    """Get the revision property value for a commit that fixes bugs.
292
293
    :param bug_urls: An iterable of escaped URLs to bugs. These normally
294
        come from `get_bug_url`.
295
    :return: A string that will be set as the 'bugs' property of a revision
296
        as part of a commit.
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
297
    """
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
298
    return '\n'.join(('%s %s' % (url, FIXED)) for url in bug_urls)