~bzr-pqm/bzr/bzr.dev

3735.5.1 by Martin Pool
commit code should not rely on inventory._byid
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
62
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
63
    trace,
1551.8.30 by Aaron Bentley
Tweak from review comments
64
    tree,
4222.1.1 by Jelmer Vernooij
Make function for escaping invalid XML characters public.
65
    xml_serializer,
1551.8.30 by Aaron Bentley
Tweak from review comments
66
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
67
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
68
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
69
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
70
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
71
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
72
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
73
from bzrlib.osutils import (get_user_encoding,
74
                            kind_marker, isdir,isfile, is_inside_any,
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
75
                            is_inside_or_parent_of_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
76
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
77
                            quotefn, sha_file, split_lines,
78
                            splitpath,
79
                            )
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
80
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
81
from bzrlib.trace import mutter, note, warning, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
82
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
83
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
84
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
85
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
86
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
87
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
88
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
89
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
90
91
92
class NullCommitReporter(object):
93
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
94
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
95
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
96
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
97
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
98
                                   "to started.", DeprecationWarning,
99
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
100
        pass
101
102
    def snapshot_change(self, change, path):
103
        pass
104
105
    def completed(self, revno, rev_id):
106
        pass
107
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
108
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
109
        pass
110
111
    def missing(self, path):
112
        pass
113
114
    def renamed(self, change, old_path, new_path):
115
        pass
116
2789.2.11 by Ian Clatworthy
remove more reporting stuff
117
    def is_verbose(self):
118
        return False
119
120
121
class ReportCommitToLog(NullCommitReporter):
122
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
123
    def _note(self, format, *args):
124
        """Output a message.
125
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
126
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
127
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
128
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
129
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
130
    def snapshot_change(self, change, path):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
131
        if path == '' and change in ('added', 'modified'):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
132
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
133
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
134
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
135
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
136
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
137
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
138
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
139
            # When started was added, location was only made optional by
140
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
141
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
142
                                   "to started.", DeprecationWarning,
143
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
144
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
145
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
146
147
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
148
        self._note('Committed revision %d.', revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
149
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
150
    def deleted(self, path):
151
        self._note('deleted %s', path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
152
153
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
154
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
155
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
156
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
157
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
158
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
159
    def is_verbose(self):
160
        return True
161
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
162
1189 by Martin Pool
- BROKEN: partial support for commit into weave
163
class Commit(object):
164
    """Task of committing a new revision.
165
166
    This is a MethodObject: it accumulates state as the commit is
167
    prepared, and then it is discarded.  It doesn't represent
168
    historical revisions, just the act of recording a new one.
169
170
            missing_ids
171
            Modified to hold a list of files that have been deleted from
172
            the working directory; these should be removed from the
173
            working inventory.
485 by Martin Pool
- move commit code into its own module
174
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
175
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
176
                 reporter=None,
177
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
178
        """Create a Commit object.
179
180
        :param reporter: the default reporter to use or None to decide later
181
        """
182
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
183
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
184
1189 by Martin Pool
- BROKEN: partial support for commit into weave
185
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
186
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
187
               timestamp=None,
188
               timezone=None,
189
               committer=None,
190
               specific_files=None,
191
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
192
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
193
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
194
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
195
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
196
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
197
               local=False,
198
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
199
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
200
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
201
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
202
               exclude=None,
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
203
               possible_master_transports=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
204
        """Commit working copy as a new revision.
205
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
206
        :param message: the commit message (it or message_callback is required)
207
208
        :param timestamp: if not None, seconds-since-epoch for a
209
            postdated/predated commit.
210
211
        :param specific_files: If true, commit only those files.
212
213
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
214
            Useful for test or import commands that need to tightly
215
            control what revisions are assigned.  If you duplicate
216
            a revision id that exists elsewhere it is your own fault.
217
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
218
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
219
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
220
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
221
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
222
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
223
            contains unknown files.
224
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
225
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
226
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
227
        :param reporter: the reporter to use or None for the default
228
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
229
        :param recursive: If set to 'down', commit in any subtrees that have
230
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
231
        :param exclude: None or a list of relative paths to exclude from the
232
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
233
            commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
234
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
235
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
236
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
237
        if working_tree is None:
238
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
239
        else:
240
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
241
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
242
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
243
                if not self.branch.repository.supports_rich_root():
244
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
245
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
246
            if message is not None:
247
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
248
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
249
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
250
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
251
                raise BzrError("The message or message_callback keyword"
252
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
253
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
254
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
255
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
256
        if exclude is not None:
257
            self.exclude = sorted(
258
                minimum_path_selection(exclude))
259
        else:
260
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
261
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
262
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
263
        self.master_locked = False
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
264
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
265
        self.rev_id = None
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
266
        if specific_files is not None:
267
            self.specific_files = sorted(
268
                minimum_path_selection(specific_files))
269
        else:
270
            self.specific_files = None
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
271
            
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
272
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
273
        self.revprops = revprops
274
        self.message_callback = message_callback
275
        self.timestamp = timestamp
276
        self.timezone = timezone
277
        self.committer = committer
278
        self.strict = strict
279
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
280
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
281
        self.work_tree.lock_write()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
282
        self.parents = self.work_tree.get_parent_ids()
283
        # We can use record_iter_changes IFF iter_changes is compatible with
284
        # the command line parameters, and the repository has fast delta
285
        # generation. See bug 347649.
286
        self.use_record_iter_changes = (
287
            not self.specific_files and
288
            not self.exclude and 
289
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
290
            (self.branch.repository._format.fast_deltas or
291
             len(self.parents) < 2))
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
292
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
293
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
294
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
295
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
296
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
297
            # Cannot commit with conflicts present.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
298
            if len(self.work_tree.conflicts()) > 0:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
299
                raise ConflictsInTree
300
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
301
            # Setup the bound branch variables as needed.
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
302
            self._check_bound_branch(possible_master_transports)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
303
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
304
            # Check that the working tree is up to date
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
305
            old_revno, new_revno = self._check_out_of_date_tree()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
306
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
307
            # Complete configuration setup
308
            if reporter is not None:
309
                self.reporter = reporter
310
            elif self.reporter is None:
311
                self.reporter = self._select_reporter()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
312
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
313
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
314
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
315
            self._set_specific_file_ids()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
316
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
317
            # Setup the progress bar. As the number of files that need to be
318
            # committed in unknown, progress is reported as stages.
319
            # We keep track of entries separately though and include that
320
            # information in the progress bar during the relevant stages.
321
            self.pb_stage_name = ""
322
            self.pb_stage_count = 0
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
323
            self.pb_stage_total = 5
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
324
            if self.bound_branch:
325
                self.pb_stage_total += 1
326
            self.pb.show_pct = False
327
            self.pb.show_spinner = False
328
            self.pb.show_eta = False
329
            self.pb.show_count = True
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
330
            self.pb.show_bar = True
1189 by Martin Pool
- BROKEN: partial support for commit into weave
331
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
332
            self._gather_parents()
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
333
            # After a merge, a selected file commit is not supported.
334
            # See 'bzr help merge' for an explanation as to why.
1344 by Martin Pool
- disallow selected-file commit of merges
335
            if len(self.parents) > 1 and self.specific_files:
1551.15.9 by Aaron Bentley
Better error for selected-file commit of merges
336
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
337
            # Excludes are a form of selected file commit.
338
            if len(self.parents) > 1 and self.exclude:
339
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
340
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
341
            # Collect the changes
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
342
            self._set_progress_stage("Collecting changes", counter=True)
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
343
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
344
                self.config, timestamp, timezone, committer, revprops, rev_id)
3879.2.3 by John Arbash Meinel
Hide the .basis_delta variable, and require callers to use .get_basis_delta()
345
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
346
            try:
3879.2.3 by John Arbash Meinel
Hide the .basis_delta variable, and require callers to use .get_basis_delta()
347
                self.builder.will_record_deletes()
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
348
                # find the location being committed to
349
                if self.bound_branch:
350
                    master_location = self.master_branch.base
351
                else:
352
                    master_location = self.branch.base
353
354
                # report the start of the commit
355
                self.reporter.started(new_revno, self.rev_id, master_location)
356
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
357
                self._update_builder_with_changes()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
358
                self._check_pointless()
359
360
                # TODO: Now the new inventory is known, check for conflicts.
361
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
362
                # weave lines, because nothing should be recorded until it is known
363
                # that commit will succeed.
2592.3.49 by Robert Collins
Merge bzr.dev.
364
                self._set_progress_stage("Saving data locally")
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
365
                self.builder.finish_inventory()
366
367
                # Prompt the user for a commit message if none provided
368
                message = message_callback(self)
369
                self.message = message
370
371
                # Add revision data to the local branch
372
                self.rev_id = self.builder.commit(self.message)
2659.3.5 by NamNguyen
merge with bzr.dev
373
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
374
            except Exception, e:
375
                mutter("aborting commit write group because of exception:")
376
                trace.log_exception_quietly()
377
                note("aborting commit write group: %r" % (e,))
2749.3.1 by Jelmer Vernooij
Add CommitBuilder.abort().
378
                self.builder.abort()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
379
                raise
380
2659.3.6 by NamNguyen
branch_implementations/test_commit.py:
381
            self._process_pre_hooks(old_revno, new_revno)
382
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
383
            # Upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
384
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
385
            if self.bound_branch:
4048.2.1 by Jelmer Vernooij
Use Branch.pull() to update master branch.
386
                self._set_progress_stage("Uploading data to master branch")
4048.2.2 by Jelmer Vernooij
New Branch.import_last_Revision_info() function used to pull revisions into the master branch during commit.
387
                # 'commit' to the master first so a timeout here causes the
388
                # local branch to be out of date
389
                self.master_branch.import_last_revision_info(
390
                    self.branch.repository, new_revno, self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
391
392
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
393
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
394
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
395
            # Make the working tree up to date with the branch
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
396
            self._set_progress_stage("Updating the working tree")
397
            self.work_tree.update_basis_by_delta(self.rev_id,
398
                 self.builder.get_basis_delta())
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
399
            self.reporter.completed(new_revno, self.rev_id)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
400
            self._process_post_hooks(old_revno, new_revno)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
401
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
402
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
403
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
404
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
405
    def _select_reporter(self):
406
        """Select the CommitReporter to use."""
407
        if is_quiet():
408
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
409
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
410
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
411
    def _check_pointless(self):
412
        if self.allow_pointless:
413
            return
414
        # A merge with no effect on files
415
        if len(self.parents) > 1:
416
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
417
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
418
2921.4.6 by Robert Collins
Typos found by Rob Weir.
419
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
420
        # a worthwhile commit.
421
        if (self.basis_revid == revision.NULL_REVISION and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
422
            ((self.builder.new_inventory is not None and
423
             len(self.builder.new_inventory) == 1) or
424
            len(self.builder._basis_delta) == 1)):
1731.1.49 by Aaron Bentley
Merge bzr.dev
425
            raise PointlessCommit()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
426
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
427
            return
428
        raise PointlessCommit()
429
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
430
    def _check_bound_branch(self, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
431
        """Check to see if the local branch is bound.
432
433
        If it is bound, then most of the commit will actually be
434
        done using the remote branch as the target branch.
435
        Only at the end will the local branch be updated.
436
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
437
        if self.local and not self.branch.get_bound_location():
438
            raise errors.LocalRequiresBoundBranch()
439
440
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
441
            self.master_branch = self.branch.get_master_branch(
442
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
443
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
444
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
445
            # make this branch the reference branch for out of date checks.
446
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
447
            return
448
449
        # If the master branch is bound, we must fail
450
        master_bound_location = self.master_branch.get_bound_location()
451
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
452
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
453
                    self.master_branch, master_bound_location)
454
455
        # TODO: jam 20051230 We could automatically push local
456
        #       commits to the remote branch if they would fit.
457
        #       But for now, just require remote to be identical
458
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
459
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
460
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
461
        master_info = self.master_branch.last_revision_info()
462
        local_info = self.branch.last_revision_info()
463
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
464
            raise errors.BoundBranchOutOfDate(self.branch,
465
                    self.master_branch)
466
467
        # Now things are ready to change the master branch
468
        # so grab the lock
469
        self.bound_branch = self.branch
470
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
471
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
472
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
473
    def _check_out_of_date_tree(self):
474
        """Check that the working tree is up to date.
475
476
        :return: old_revision_number,new_revision_number tuple
477
        """
478
        try:
479
            first_tree_parent = self.work_tree.get_parent_ids()[0]
480
        except IndexError:
481
            # if there are no parents, treat our parent as 'None'
482
            # this is so that we still consider the master branch
483
            # - in a checkout scenario the tree may have no
484
            # parents but the branch may do.
485
            first_tree_parent = bzrlib.revision.NULL_REVISION
486
        old_revno, master_last = self.master_branch.last_revision_info()
487
        if master_last != first_tree_parent:
488
            if master_last != bzrlib.revision.NULL_REVISION:
489
                raise errors.OutOfDateTree(self.work_tree)
490
        if self.branch.repository.has_revision(first_tree_parent):
491
            new_revno = old_revno + 1
492
        else:
493
            # ghost parents never appear in revision history.
494
            new_revno = 1
495
        return old_revno,new_revno
496
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
497
    def _process_pre_hooks(self, old_revno, new_revno):
498
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
499
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
500
        self._process_hooks("pre_commit", old_revno, new_revno)
501
502
    def _process_post_hooks(self, old_revno, new_revno):
503
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
504
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
505
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
506
        # old style commit hooks - should be deprecated ? (obsoleted in
507
        # 0.15)
508
        if self.config.post_commit() is not None:
509
            hooks = self.config.post_commit().split(' ')
510
            # this would be nicer with twisted.python.reflect.namedAny
511
            for hook in hooks:
512
                result = eval(hook + '(branch, rev_id)',
513
                              {'branch':self.branch,
514
                               'bzrlib':bzrlib,
515
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
516
        # process new style post commit hooks
517
        self._process_hooks("post_commit", old_revno, new_revno)
518
519
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
520
        if not Branch.hooks[hook_name]:
521
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
522
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
523
        # new style commit hooks:
524
        if not self.bound_branch:
525
            hook_master = self.branch
526
            hook_local = None
527
        else:
528
            hook_master = self.master_branch
529
            hook_local = self.branch
530
        # With bound branches, when the master is behind the local branch,
531
        # the 'old_revno' and old_revid values here are incorrect.
532
        # XXX: FIXME ^. RBC 20060206
533
        if self.parents:
534
            old_revid = self.parents[0]
535
        else:
536
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
537
2659.3.9 by NamNguyen
branch.py:
538
        if hook_name == "pre_commit":
539
            future_tree = self.builder.revision_tree()
540
            tree_delta = future_tree.changes_from(self.basis_tree,
541
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
542
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
543
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
544
            # show the running hook in the progress bar. As hooks may
545
            # end up doing nothing (e.g. because they are not configured by
546
            # the user) this is still showing progress, not showing overall
547
            # actions - its up to each plugin to show a UI if it want's to
548
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
549
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
550
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
551
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
552
            if 'hooks' in debug.debug_flags:
553
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
554
            if hook_name == "post_commit":
555
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
556
                     self.rev_id)
557
            elif hook_name == "pre_commit":
558
                hook(hook_local, hook_master,
559
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
560
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
561
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
562
    def _cleanup(self):
563
        """Cleanup any open locks, progress bars etc."""
564
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
565
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
566
                    self.work_tree.unlock,
567
                    self.pb.finished]
568
        found_exception = None
569
        for cleanup in cleanups:
570
            try:
571
                cleanup()
572
            # we want every cleanup to run no matter what.
573
            # so we have a catchall here, but we will raise the
574
            # last encountered exception up the stack: and
575
            # typically this will be useful enough.
576
            except Exception, e:
577
                found_exception = e
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
578
        if found_exception is not None:
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
579
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
580
            # trashed, e is our sure-to-work exception even though it loses the
581
            # full traceback. XXX: RBC 20060421 perhaps we could check the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
582
            # exc_info and if its the same one do a plain raise otherwise
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
583
            # 'raise e' as we do now.
584
            raise e
585
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
586
    def _cleanup_bound_branch(self):
587
        """Executed at the end of a try/finally to cleanup a bound branch.
588
589
        If the branch wasn't bound, this is a no-op.
590
        If it was, it resents self.branch to the local branch, instead
591
        of being the master.
592
        """
593
        if not self.bound_branch:
594
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
595
        if self.master_locked:
596
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
597
1223 by Martin Pool
- store inventories in weave
598
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
599
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
600
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
601
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
602
        if self.use_record_iter_changes:
603
            return
604
        self.basis_inv = self.basis_tree.inventory
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
605
        self.parent_invs = [self.basis_inv]
606
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
607
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
608
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
609
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
610
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
611
            else:
612
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
613
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
614
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
615
        """Update the commit builder with the data about what has changed.
616
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
617
        exclude = self.exclude
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
618
        specific_files = self.specific_files or []
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
619
        mutter("Selecting files for commit with filter %s", specific_files)
620
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
621
        self._check_strict()
622
        if self.use_record_iter_changes:
623
            iter_changes = self.work_tree.iter_changes(self.basis_tree)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
624
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
625
            for file_id, path, fs_hash in self.builder.record_iter_changes(
626
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
627
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
628
        else:
629
            # Build the new inventory
630
            self._populate_from_inventory()
631
            self._record_unselected()
632
            self._report_and_accumulate_deletes()
633
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
634
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
635
        """Process iter_changes.
636
637
        This method reports on the changes in iter_changes to the user, and 
638
        converts 'missing' entries in the iter_changes iterator to 'deleted'
639
        entries. 'missing' entries have their
640
641
        :param iter_changes: An iter_changes to process.
642
        :return: A generator of changes.
643
        """
644
        reporter = self.reporter
645
        report_changes = reporter.is_verbose()
646
        deleted_ids = []
647
        for change in iter_changes:
648
            if report_changes:
649
                old_path = change[1][0]
650
                new_path = change[1][1]
651
                versioned = change[3][1]
652
            kind = change[6][1]
653
            versioned = change[3][1]
654
            if kind is None and versioned:
655
                # 'missing' path
656
                if report_changes:
657
                    reporter.missing(new_path)
658
                deleted_ids.append(change[0])
659
                # Reset the new path (None) and new versioned flag (False)
660
                change = (change[0], (change[1][0], None), change[2],
661
                    (change[3][0], False)) + change[4:]
662
            elif kind == 'tree-reference':
663
                if self.recursive == 'down':
664
                    self._commit_nested_tree(change[0], change[1][1])
665
            if change[3][0] or change[3][1]:
666
                yield change
667
                if report_changes:
668
                    if new_path is None:
669
                        reporter.deleted(old_path)
670
                    elif old_path is None:
671
                        reporter.snapshot_change('added', new_path)
672
                    elif old_path != new_path:
673
                        reporter.renamed('renamed', old_path, new_path)
674
                    else:
675
                        if (new_path or 
676
                            self.work_tree.branch.repository._format.rich_root_data):
677
                            # Don't report on changes to '' in non rich root
678
                            # repositories.
679
                            reporter.snapshot_change('modified', new_path)
680
            self._next_progress_entry()
681
        # Unversion IDs that were found to be deleted
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
682
        self.work_tree.unversion(deleted_ids)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
683
684
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
685
        # If specific files are selected, then all un-selected files must be
686
        # recorded in their previous state. For more details, see
687
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
688
        if self.specific_files or self.exclude:
689
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
690
            for path, old_ie in self.basis_inv.iter_entries():
691
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
692
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
693
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
694
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
695
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
696
                    # was inside the selected path, and not excluded - if not
697
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
698
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
699
                # From here down it was either not selected, or was excluded:
700
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
701
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
702
                # Note: specific file commits after a merge are currently
703
                # prohibited. This test is for sanity/safety in case it's
704
                # required after that changes.
705
                if len(self.parents) > 1:
706
                    ie.revision = None
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
707
                self.builder.record_entry_contents(ie, self.parent_invs, path,
708
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
709
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
710
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
711
        if (isinstance(self.basis_inv, Inventory)
712
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
713
            # the older Inventory classes provide a _byid dict, and building a
714
            # set from the keys of this dict is substantially faster than even
715
            # getting a set of ids from the inventory
716
            #
717
            # <lifeless> set(dict) is roughly the same speed as
718
            # set(iter(dict)) and both are significantly slower than
719
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
720
            deleted_ids = set(self.basis_inv._byid.keys()) - \
721
               set(self.builder.new_inventory._byid.keys())
722
        else:
723
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
724
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
725
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
726
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
727
                for file_id in deleted_ids]
728
            deleted.sort()
729
            # XXX: this is not quite directory-order sorting
730
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
731
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
732
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
733
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
734
    def _check_strict(self):
735
        # XXX: when we use iter_changes this would likely be faster if
736
        # iter_changes would check for us (even in the presence of
737
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
738
        if self.strict:
739
            # raise an exception as soon as we find a single unknown.
740
            for unknown in self.work_tree.unknowns():
741
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
742
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
743
    def _populate_from_inventory(self):
744
        """Populate the CommitBuilder by walking the working tree inventory."""
745
        # Build the revision inventory.
746
        #
747
        # This starts by creating a new empty inventory. Depending on
748
        # which files are selected for commit, and what is present in the
749
        # current tree, the new inventory is populated. inventory entries
750
        # which are candidates for modification have their revision set to
751
        # None; inventory entries that are carried over untouched have their
752
        # revision set to their prior value.
753
        #
754
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
755
        # results to create a new inventory at the same time, which results
756
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
757
        # ADHB 11-07-2006
758
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
759
        specific_files = self.specific_files
760
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
761
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
762
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
763
        # A tree of paths that have been deleted. E.g. if foo/bar has been
764
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
765
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
766
        # XXX: Note that entries may have the wrong kind because the entry does
767
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
768
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
769
        # NB: entries will include entries within the excluded ids/paths
770
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
771
        entries = work_inv.iter_entries_by_dir(
772
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
773
        for path, existing_ie in entries:
774
            file_id = existing_ie.file_id
775
            name = existing_ie.name
776
            parent_id = existing_ie.parent_id
777
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
778
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
779
            # The deleted path ids are also recorded so they can be explicitly
780
            # unversioned later.
781
            if deleted_paths:
782
                path_segments = splitpath(path)
783
                deleted_dict = deleted_paths
784
                for segment in path_segments:
785
                    deleted_dict = deleted_dict.get(segment, None)
786
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
787
                        # We either took a path not present in the dict
788
                        # (deleted_dict was None), or we've reached an empty
789
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
790
                        break
791
                else:
792
                    deleted_dict = None
793
                if deleted_dict is not None:
794
                    # the path has a deleted parent, do not add it.
795
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
796
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
797
                # Skip excluded paths. Excluded paths are processed by
798
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
799
                continue
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
800
            content_summary = self.work_tree.path_content_summary(path)
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
801
            # Note that when a filter of specific files is given, we must only
802
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
803
            if not specific_files or is_inside_any(specific_files, path):
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
804
                if content_summary[0] == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
805
                    if not deleted_paths:
806
                        # path won't have been split yet.
807
                        path_segments = splitpath(path)
808
                    deleted_dict = deleted_paths
809
                    for segment in path_segments:
810
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
811
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
812
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
813
                    deleted_ids.append(file_id)
814
                    continue
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
815
            # TODO: have the builder do the nested commit just-in-time IF and
816
            # only if needed.
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
817
            if content_summary[0] == 'tree-reference':
818
                # enforce repository nested tree policy.
819
                if (not self.work_tree.supports_tree_reference() or
820
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
821
                    not self.branch.repository._format.supports_tree_reference):
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
822
                    content_summary = ('directory',) + content_summary[1:]
823
            kind = content_summary[0]
824
            # TODO: specific_files filtering before nested tree processing
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
825
            if kind == 'tree-reference':
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
826
                if self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
827
                    nested_revision_id = self._commit_nested_tree(
828
                        file_id, path)
829
                    content_summary = content_summary[:3] + (
830
                        nested_revision_id,)
831
                else:
832
                    content_summary = content_summary[:3] + (
833
                        self.work_tree.get_reference_revision(file_id),)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
834
835
            # Record an entry for this item
836
            # Note: I don't particularly want to have the existing_ie
837
            # parameter but the test suite currently (28-Jun-07) breaks
838
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
839
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
840
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
841
                parent_id, definitely_changed, existing_ie, report_changes,
842
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
843
844
        # Unversion IDs that were found to be deleted
845
        self.work_tree.unversion(deleted_ids)
846
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
847
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
848
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
849
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
850
        # FIXME: be more comprehensive here:
851
        # this works when both trees are in --trees repository,
852
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
853
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
854
        # finally implement the explicit-caches approach design
855
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
856
        if sub_tree.branch.repository.has_same_location(
857
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
858
            sub_tree.branch.repository = \
859
                self.work_tree.branch.repository
860
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
861
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
862
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
863
                message_callback=self.message_callback,
864
                timestamp=self.timestamp, timezone=self.timezone,
865
                committer=self.committer,
866
                allow_pointless=self.allow_pointless,
867
                strict=self.strict, verbose=self.verbose,
868
                local=self.local, reporter=self.reporter)
869
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
870
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
871
872
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
873
        parent_id, definitely_changed, existing_ie, report_changes,
874
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
875
        "Record the new inventory entry for a path if any."
876
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
877
        # mutter('%s selected for commit', path)
878
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
879
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
880
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
881
            ie = existing_ie.copy()
882
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
883
        # For carried over entries we don't care about the fs hash - the repo
884
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
885
        _, _, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
886
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
887
        if report_changes:
888
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
889
        if fs_hash:
890
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
891
        return ie
892
893
    def _report_change(self, ie, path):
894
        """Report a change to the user.
895
896
        The change that has occurred is described relative to the basis
897
        inventory.
898
        """
899
        if (self.basis_inv.has_id(ie.file_id)):
900
            basis_ie = self.basis_inv[ie.file_id]
901
        else:
902
            basis_ie = None
903
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
904
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
905
            InventoryEntry.MODIFIED_AND_RENAMED):
906
            old_path = self.basis_inv.id2path(ie.file_id)
907
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
908
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
909
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
910
            if change == 'unchanged':
911
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
912
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
913
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
914
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
915
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
916
        """Set the progress stage and emit an update to the progress bar."""
917
        self.pb_stage_name = name
918
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
919
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
920
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
921
        else:
922
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
923
        self._emit_progress()
924
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
925
    def _next_progress_entry(self):
926
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
927
        self.pb_entries_count += 1
928
        self._emit_progress()
929
930
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
931
        if self.pb_entries_count is not None:
932
            text = "%s [%d] - Stage" % (self.pb_stage_name,
933
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
934
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
935
            text = "%s - Stage" % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
936
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
937
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
938
    def _set_specific_file_ids(self):
939
        """populate self.specific_file_ids if we will use it."""
940
        if not self.use_record_iter_changes:
941
            # If provided, ensure the specified files are versioned
942
            if self.specific_files is not None:
943
                # Note: This routine is being called because it raises
944
                # PathNotVersionedError as a side effect of finding the IDs. We
945
                # later use the ids we found as input to the working tree
946
                # inventory iterator, so we only consider those ids rather than
947
                # examining the whole tree again.
948
                # XXX: Dont we have filter_unversioned to do this more
949
                # cheaply?
950
                self.specific_file_ids = tree.find_ids_across_trees(
951
                    self.specific_files, [self.basis_tree, self.work_tree])
952
            else:
953
                self.specific_file_ids = None