~bzr-pqm/bzr/bzr.dev

2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
1
# Copyright (C) 2007 Canonical Ltd
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
16
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
17
import textwrap
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
18
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
19
from bzrlib import registry, help_topics
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
20
from bzrlib.lazy_import import lazy_import
21
lazy_import(globals(), """
2376.4.17 by Jonathan Lange
Use urlutils.join instead of ugly, buggy, string mashing
22
from bzrlib import errors, urlutils
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
23
""")
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
24
25
2376.4.7 by jml at canonical
- Add docstrings to tests.
26
"""Provides a shorthand for referring to bugs on a variety of bug trackers.
27
28
'commit --fixes' stores references to bugs as a <bug_url> -> <bug_status>
29
mapping in the properties for that revision.
30
31
However, it's inconvenient to type out full URLs for bugs on the command line,
32
particularly given that many users will be using only a single bug tracker per
33
branch.
34
35
Thus, this module provides a registry of types of bug tracker (e.g. Launchpad,
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
36
Trac). Given an abbreviated name (e.g. 'lp', 'twisted') and a branch with
2376.4.7 by jml at canonical
- Add docstrings to tests.
37
configuration information, these tracker types can return an instance capable
38
of converting bug IDs into URLs.
39
"""
40
41
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
42
_bugs_help = \
43
"""When making a commit, metadata about bugs fixed by that change can be
44
recorded by using the --fixes option. For each bug marked as fixed, an
45
entry is included in the 'bugs' revision property stating '<url> <status>'.
3154.1.1 by Ian Clatworthy
Minor tweaks to bug tracker integration documentation
46
(The only ``status`` value currently supported is ``fixed.``)
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
47
48
The --fixes option allows you to specify a bug tracker and a bug identifier
49
rather than a full URL. This looks like
50
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
51
    bzr commit --fixes <tracker>:<id>
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
52
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
53
where "<tracker>" is an identifier for the bug tracker, and "<id>" is the
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
54
identifier for that bug within the bugtracker, usually the bug number.
55
3535.10.5 by James Westby
Don't say "well-known" as suggested by Robert.
56
Bazaar knows about a few bug trackers that have many users. If
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
57
you use one of these bug trackers then there is no setup required to
3535.10.3 by James Westby
Talk about "trackers" rather than "tags" as it may be less confusing.
58
use this feature, you just need to know the tracker identifier to use.
59
These are the bugtrackers that are built in:
60
3535.10.10 by James Westby
Change "Tracker id" to "Abbreviation" to be less ambiguous.
61
     URL                          | Abbreviation | Example
62
     https://bugs.launchpad.net/  | lp           | lp:12345
63
     http://bugs.debian.org/      | deb          | deb:12345
64
     http://bugzilla.gnome.org/   | gnome        | gnome:12345
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
65
3535.10.5 by James Westby
Don't say "well-known" as suggested by Robert.
66
For the bug trackers not listed above configuration is required.
67
Support for generating the URLs for any project using Bugzilla or Trac
68
is built in, along with a template mechanism for other bugtrackers with
3535.10.6 by James Westby
Mention that the a plugin can support their tracker as the last resort.
69
simple URL schemes. If your bug tracker can't be described by one
70
of the schemes described below then you can write a plugin to support
71
it.
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
72
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
73
If you use Bugzilla or Trac, then you only need to set a configuration
74
variable which contains the base URL of the bug tracker. These options
75
can go into ``bazaar.conf``, ``branch.conf`` or into a branch-specific
76
configuration section in ``locations.conf``.  You can set up these values
77
for each of the projects you work on.
78
79
Note: As you provide a short name for each tracker, you can specify one or
80
more bugs in one or more trackers at commit time if you wish.
81
3860.2.1 by Martin Pool
Mention in 'help bugs' the syntax for Launchpad
82
Launchpad
83
---------
84
85
Use ``bzr commit --fixes lp:2`` to record that this commit fixes bug 2.
86
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
87
bugzilla_<tracker_abbreviation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
88
-----------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
89
90
If present, the location of the Bugzilla bug tracker referred to by
91
<tracker_abbreviation>. This option can then be used together with ``bzr commit
92
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
93
example::
94
95
    bugzilla_squid_url = http://www.squid-cache.org/bugs
96
97
would allow ``bzr commit --fixes squid:1234`` to mark Squid's bug 1234 as
98
fixed.
99
100
trac_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
101
------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
102
103
If present, the location of the Trac instance referred to by
104
<tracker_abbreviation>. This option can then be used together with ``bzr commit
105
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
106
example::
107
108
    trac_twisted_url = http://www.twistedmatrix.com/trac
109
110
would allow ``bzr commit --fixes twisted:1234`` to mark Twisted's bug 1234 as
111
fixed.
112
113
bugtracker_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
114
------------------------------------
115
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
116
If present, the location of a generic bug tracker instance referred to by
117
<tracker_abbreviation>. The location must contain an ``{id}`` placeholder,
118
which will be replaced by a specific bug ID. This option can then be used
119
together with ``bzr commit --fixes`` to mark bugs in that tracker as being
120
fixed by that commit. For example::
121
122
    bugtracker_python_url = http://bugs.python.org/issue{id}
123
124
would allow ``bzr commit --fixes python:1234`` to mark bug 1234 in Python's
125
Roundup bug tracker as fixed, or::
126
127
    bugtracker_cpan_url = http://rt.cpan.org/Public/Bug/Display.html?id={id}
128
129
for CPAN's RT bug tracker.
130
"""
131
132
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
133
def get_bug_url(abbreviated_bugtracker_name, branch, bug_id):
134
    """Return a URL pointing to the canonical web page of the bug identified by
135
    'bug_id'.
136
    """
137
    tracker = tracker_registry.get_tracker(abbreviated_bugtracker_name, branch)
138
    return tracker.get_bug_url(bug_id)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
139
140
141
class TrackerRegistry(registry.Registry):
142
    """Registry of bug tracker types."""
143
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
144
    def get_tracker(self, abbreviated_bugtracker_name, branch):
145
        """Return the first registered tracker that understands
146
        'abbreviated_bugtracker_name'.
2376.4.7 by jml at canonical
- Add docstrings to tests.
147
148
        If no such tracker is found, raise KeyError.
149
        """
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
150
        for tracker_name in self.keys():
151
            tracker_type = self.get(tracker_name)
152
            tracker = tracker_type.get(abbreviated_bugtracker_name, branch)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
153
            if tracker is not None:
154
                return tracker
2376.4.28 by Jonathan Lange
Focus the tests better and clean up some dodgy bits in UnknownBugTrackerAbbreviation
155
        raise errors.UnknownBugTrackerAbbreviation(abbreviated_bugtracker_name,
156
                                                   branch)
2376.4.7 by jml at canonical
- Add docstrings to tests.
157
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
158
    def help_topic(self, topic):
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
159
        return _bugs_help
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
160
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
161
162
tracker_registry = TrackerRegistry()
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
163
"""Registry of bug trackers."""
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
164
2376.4.15 by Jonathan Lange
Whitespace cleanup
165
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
166
class BugTracker(object):
167
    """Base class for bug trackers."""
168
169
    def check_bug_id(self, bug_id):
170
        """Check that the bug_id is valid.
171
172
        The base implementation assumes that all bug_ids are valid.
173
        """
174
175
    def get_bug_url(self, bug_id):
176
        """Return the URL for bug_id. Raise an error if bug ID is malformed."""
177
        self.check_bug_id(bug_id)
178
        return self._get_bug_url(bug_id)
179
180
    def _get_bug_url(self, bug_id):
181
        """Given a validated bug_id, return the bug's web page's URL."""
182
183
184
class IntegerBugTracker(BugTracker):
185
    """A bug tracker that only allows integer bug IDs."""
186
187
    def check_bug_id(self, bug_id):
188
        try:
189
            int(bug_id)
190
        except ValueError:
191
            raise errors.MalformedBugIdentifier(bug_id, "Must be an integer")
192
193
194
class UniqueIntegerBugTracker(IntegerBugTracker):
2376.4.19 by Jonathan Lange
Rename SimpleBugTracker to UniqueBugTracker
195
    """A style of bug tracker that exists in one place only, such as Launchpad.
2376.4.15 by Jonathan Lange
Whitespace cleanup
196
2376.4.41 by Jonathan Lange
Update UniqueIntegerBugTracker docstring for new API
197
    If you have one of these trackers then register an instance passing in an
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
198
    abbreviated name for the bug tracker and a base URL. The bug ids are
199
    appended directly to the URL.
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
200
    """
201
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
202
    def __init__(self, abbreviated_bugtracker_name, base_url):
203
        self.abbreviation = abbreviated_bugtracker_name
204
        self.base_url = base_url
205
206
    def get(self, abbreviated_bugtracker_name, branch):
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
207
        """Returns the tracker if the abbreviation matches. Returns None
208
        otherwise."""
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
209
        if abbreviated_bugtracker_name != self.abbreviation:
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
210
            return None
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
211
        return self
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
212
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
213
    def _get_bug_url(self, bug_id):
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
214
        """Return the URL for bug_id."""
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
215
        return self.base_url + bug_id
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
216
217
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
218
tracker_registry.register(
219
    'launchpad', UniqueIntegerBugTracker('lp', 'https://launchpad.net/bugs/'))
220
221
222
tracker_registry.register(
2376.4.29 by Jonathan Lange
Tests for builtin trackers.
223
    'debian', UniqueIntegerBugTracker('deb', 'http://bugs.debian.org/'))
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
224
2376.4.15 by Jonathan Lange
Whitespace cleanup
225
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
226
tracker_registry.register('gnome',
227
    UniqueIntegerBugTracker('gnome', 'http://bugzilla.gnome.org/show_bug.cgi?id='))
228
229
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
230
class URLParametrizedIntegerBugTracker(IntegerBugTracker):
231
    """A type of bug tracker that can be found on a variety of different sites,
232
    and thus needs to have the base URL configured.
233
234
    Looks for a config setting in the form '<type_name>_<abbreviation>_url'.
235
    `type_name` is the name of the type of tracker (e.g. 'bugzilla' or 'trac')
236
    and `abbreviation` is a short name for the particular instance (e.g.
237
    'squid' or 'apache').
238
    """
239
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
240
    def get(self, abbreviation, branch):
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
241
        config = branch.get_config()
242
        url = config.get_user_option(
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
243
            "%s_%s_url" % (self.type_name, abbreviation))
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
244
        if url is None:
245
            return None
246
        self._base_url = url
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
247
        return self
248
249
    def __init__(self, type_name, bug_area):
250
        self.type_name = type_name
251
        self._bug_area = bug_area
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
252
253
    def _get_bug_url(self, bug_id):
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
254
        """Return a URL for a bug on this Trac instance."""
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
255
        return urlutils.join(self._base_url, self._bug_area) + str(bug_id)
256
257
258
tracker_registry.register(
259
    'trac', URLParametrizedIntegerBugTracker('trac', 'ticket/'))
260
261
tracker_registry.register(
262
    'bugzilla',
263
    URLParametrizedIntegerBugTracker('bugzilla', 'show_bug.cgi?id='))
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
264
265
266
class GenericBugTracker(URLParametrizedIntegerBugTracker):
267
    """Generic bug tracker specified by an URL template."""
268
269
    def __init__(self):
3035.3.2 by Lukáš Lalinský
Add tests for InvalidBugTrackerURL.
270
        super(GenericBugTracker, self).__init__('bugtracker', None)
271
272
    def get(self, abbreviation, branch):
273
        self._abbreviation = abbreviation
274
        return super(GenericBugTracker, self).get(abbreviation, branch)
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
275
276
    def _get_bug_url(self, bug_id):
277
        """Given a validated bug_id, return the bug's web page's URL."""
278
        if '{id}' not in self._base_url:
279
            raise errors.InvalidBugTrackerURL(self._abbreviation,
280
                                              self._base_url)
281
        return self._base_url.replace('{id}', str(bug_id))
282
283
284
tracker_registry.register('generic', GenericBugTracker())
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
285
286
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
287
FIXED = 'fixed'
288
4119.4.3 by Jonathan Lange
Add Revision.iter_bugs.
289
ALLOWED_BUG_STATUSES = set([FIXED])
290
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
291
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
292
def encode_fixes_bug_urls(bug_urls):
4119.4.5 by Jonathan Lange
Fix the docstring.
293
    """Get the revision property value for a commit that fixes bugs.
294
295
    :param bug_urls: An iterable of escaped URLs to bugs. These normally
296
        come from `get_bug_url`.
297
    :return: A string that will be set as the 'bugs' property of a revision
298
        as part of a commit.
4119.4.1 by Jonathan Lange
Extract bug fix encoding logic from commit.
299
    """
4119.4.2 by Jonathan Lange
Some refactoring, some unit tests.
300
    return '\n'.join(('%s %s' % (url, FIXED)) for url in bug_urls)