~bzr-pqm/bzr/bzr.dev

2052.3.2 by John Arbash Meinel
Change Copyright .. by Canonical to Copyright ... Canonical
1
# Copyright (C) 2006 Canonical Ltd
1908.5.2 by Robert Collins
Create and test set_parent_trees.
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1908.5.2 by Robert Collins
Create and test set_parent_trees.
16
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
17
"""Tests of the parent related functions of WorkingTrees."""
18
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
19
from errno import EEXIST
1908.5.2 by Robert Collins
Create and test set_parent_trees.
20
import os
21
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
22
from bzrlib import (
23
    errors,
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
24
    osutils,
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
25
    revision as _mod_revision,
26
    symbol_versioning,
4095.3.4 by Vincent Ladeuil
Some trivial cleanups, related to fix for bug #272444.
27
    tests,
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
28
    )
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
29
from bzrlib.inventory import (
30
    Inventory,
31
    InventoryFile,
32
    InventoryDirectory,
33
    InventoryLink,
34
    )
35
from bzrlib.revision import Revision
1908.5.2 by Robert Collins
Create and test set_parent_trees.
36
from bzrlib.tests.workingtree_implementations import TestCaseWithWorkingTree
37
from bzrlib.uncommit import uncommit
38
39
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
40
class TestParents(TestCaseWithWorkingTree):
41
42
    def assertConsistentParents(self, expected, tree):
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
43
        """Check that the parents found are as expected.
44
45
        This test helper also checks that they are consistent with
46
        the pre-get_parent_ids() api - which is now deprecated.
47
        """
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
48
        self.assertEqual(expected, tree.get_parent_ids())
49
        if expected == []:
2598.5.7 by Aaron Bentley
Updates from review
50
            self.assertEqual(_mod_revision.NULL_REVISION,
51
                             _mod_revision.ensure_null(tree.last_revision()))
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
52
        else:
1908.7.11 by Robert Collins
Merge bzr.dev and undeprecated WorkingTree.last_revision as per review feedback.
53
            self.assertEqual(expected[0], tree.last_revision())
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
54
55
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
56
class TestGetParents(TestParents):
57
58
    def test_get_parents(self):
59
        t = self.make_branch_and_tree('.')
60
        self.assertEqual([], t.get_parent_ids())
61
62
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
63
class TestSetParents(TestParents):
1908.5.2 by Robert Collins
Create and test set_parent_trees.
64
65
    def test_set_no_parents(self):
66
        t = self.make_branch_and_tree('.')
67
        t.set_parent_trees([])
68
        self.assertEqual([], t.get_parent_ids())
69
        # now give it a real parent, and then set it to no parents again.
70
        t.commit('first post')
71
        t.set_parent_trees([])
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
72
        self.assertConsistentParents([], t)
1908.5.2 by Robert Collins
Create and test set_parent_trees.
73
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
74
    def test_set_null_parent(self):
75
        t = self.make_branch_and_tree('.')
76
        self.assertRaises(errors.ReservedId, t.set_parent_ids, ['null:'],
77
                          allow_leftmost_as_ghost=True)
78
        self.assertRaises(errors.ReservedId, t.set_parent_trees,
79
                          [('null:', None)], allow_leftmost_as_ghost=True)
80
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
81
    def test_set_one_ghost_parent_rejects(self):
82
        t = self.make_branch_and_tree('.')
1908.5.12 by Robert Collins
Apply review feedback - paired with Martin.
83
        self.assertRaises(errors.GhostRevisionUnusableHere,
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
84
            t.set_parent_trees, [('missing-revision-id', None)])
85
86
    def test_set_one_ghost_parent_force(self):
87
        t = self.make_branch_and_tree('.')
88
        t.set_parent_trees([('missing-revision-id', None)],
89
            allow_leftmost_as_ghost=True)
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
90
        self.assertConsistentParents(['missing-revision-id'], t)
1908.5.2 by Robert Collins
Create and test set_parent_trees.
91
92
    def test_set_two_parents_one_ghost(self):
93
        t = self.make_branch_and_tree('.')
94
        revision_in_repo = t.commit('first post')
95
        # remove the tree's history
96
        uncommit(t.branch, tree=t)
97
        rev_tree = t.branch.repository.revision_tree(revision_in_repo)
98
        t.set_parent_trees([(revision_in_repo, rev_tree),
99
            ('another-missing', None)])
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
100
        self.assertConsistentParents([revision_in_repo, 'another-missing'], t)
1908.5.2 by Robert Collins
Create and test set_parent_trees.
101
102
    def test_set_three_parents(self):
103
        t = self.make_branch_and_tree('.')
104
        first_revision = t.commit('first post')
105
        uncommit(t.branch, tree=t)
106
        second_revision = t.commit('second post')
107
        uncommit(t.branch, tree=t)
108
        third_revision = t.commit('third post')
109
        uncommit(t.branch, tree=t)
110
        rev_tree1 = t.branch.repository.revision_tree(first_revision)
111
        rev_tree2 = t.branch.repository.revision_tree(second_revision)
112
        rev_tree3 = t.branch.repository.revision_tree(third_revision)
113
        t.set_parent_trees([(first_revision, rev_tree1),
114
            (second_revision, rev_tree2),
115
            (third_revision, rev_tree3)])
1908.5.3 by Robert Collins
Rename the tree.set_parents tests to tree.parents - preparing to add related function tests. Also remove duplication within the tests by factoring out a helper assert.
116
        self.assertConsistentParents(
117
            [first_revision, second_revision, third_revision], t)
1908.5.4 by Robert Collins
Add add_parent_tree_id WorkingTree helper api.
118
1908.5.5 by Robert Collins
Add WorkingTree.set_parent_ids.
119
    def test_set_no_parents_ids(self):
120
        t = self.make_branch_and_tree('.')
121
        t.set_parent_ids([])
122
        self.assertEqual([], t.get_parent_ids())
123
        # now give it a real parent, and then set it to no parents again.
124
        t.commit('first post')
125
        t.set_parent_ids([])
126
        self.assertConsistentParents([], t)
127
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
128
    def test_set_one_ghost_parent_ids_rejects(self):
129
        t = self.make_branch_and_tree('.')
1908.5.12 by Robert Collins
Apply review feedback - paired with Martin.
130
        self.assertRaises(errors.GhostRevisionUnusableHere,
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
131
            t.set_parent_ids, ['missing-revision-id'])
132
133
    def test_set_one_ghost_parent_ids_force(self):
134
        t = self.make_branch_and_tree('.')
135
        t.set_parent_ids(['missing-revision-id'],
136
            allow_leftmost_as_ghost=True)
1908.5.5 by Robert Collins
Add WorkingTree.set_parent_ids.
137
        self.assertConsistentParents(['missing-revision-id'], t)
138
139
    def test_set_two_parents_one_ghost_ids(self):
140
        t = self.make_branch_and_tree('.')
141
        revision_in_repo = t.commit('first post')
142
        # remove the tree's history
143
        uncommit(t.branch, tree=t)
144
        rev_tree = t.branch.repository.revision_tree(revision_in_repo)
145
        t.set_parent_ids([revision_in_repo, 'another-missing'])
146
        self.assertConsistentParents([revision_in_repo, 'another-missing'], t)
147
148
    def test_set_three_parents_ids(self):
149
        t = self.make_branch_and_tree('.')
150
        first_revision = t.commit('first post')
151
        uncommit(t.branch, tree=t)
152
        second_revision = t.commit('second post')
153
        uncommit(t.branch, tree=t)
154
        third_revision = t.commit('third post')
155
        uncommit(t.branch, tree=t)
156
        rev_tree1 = t.branch.repository.revision_tree(first_revision)
157
        rev_tree2 = t.branch.repository.revision_tree(second_revision)
158
        rev_tree3 = t.branch.repository.revision_tree(third_revision)
159
        t.set_parent_ids([first_revision, second_revision, third_revision])
160
        self.assertConsistentParents(
161
            [first_revision, second_revision, third_revision], t)
162
3462.1.2 by John Arbash Meinel
Change WT.set_parent_(ids/trees) to filter out ancestors.
163
    def test_set_duplicate_parent_ids(self):
164
        t = self.make_branch_and_tree('.')
165
        rev1 = t.commit('first post')
166
        uncommit(t.branch, tree=t)
167
        rev2 = t.commit('second post')
168
        uncommit(t.branch, tree=t)
169
        rev3 = t.commit('third post')
170
        uncommit(t.branch, tree=t)
171
        t.set_parent_ids([rev1, rev2, rev2, rev3])
172
        # We strip the duplicate, but preserve the ordering
173
        self.assertConsistentParents([rev1, rev2, rev3], t)
174
175
    def test_set_duplicate_parent_trees(self):
176
        t = self.make_branch_and_tree('.')
177
        rev1 = t.commit('first post')
178
        uncommit(t.branch, tree=t)
179
        rev2 = t.commit('second post')
180
        uncommit(t.branch, tree=t)
181
        rev3 = t.commit('third post')
182
        uncommit(t.branch, tree=t)
183
        rev_tree1 = t.branch.repository.revision_tree(rev1)
184
        rev_tree2 = t.branch.repository.revision_tree(rev2)
185
        rev_tree3 = t.branch.repository.revision_tree(rev3)
186
        t.set_parent_trees([(rev1, rev_tree1), (rev2, rev_tree2),
187
                            (rev2, rev_tree2), (rev3, rev_tree3)])
188
        # We strip the duplicate, but preserve the ordering
189
        self.assertConsistentParents([rev1, rev2, rev3], t)
190
191
    def test_set_parent_ids_in_ancestry(self):
192
        t = self.make_branch_and_tree('.')
193
        rev1 = t.commit('first post')
194
        rev2 = t.commit('second post')
195
        rev3 = t.commit('third post')
196
        # Reset the tree, back to rev1
197
        t.set_parent_ids([rev1])
198
        t.branch.set_last_revision_info(1, rev1)
199
        self.assertConsistentParents([rev1], t)
200
        t.set_parent_ids([rev1, rev2, rev3])
201
        # rev2 is in the ancestry of rev3, so it will be filtered out
202
        self.assertConsistentParents([rev1, rev3], t)
203
        # Order should be preserved, and the first revision should always be
204
        # kept
205
        t.set_parent_ids([rev2, rev3, rev1])
206
        self.assertConsistentParents([rev2, rev3], t)
207
208
    def test_set_parent_trees_in_ancestry(self):
209
        t = self.make_branch_and_tree('.')
210
        rev1 = t.commit('first post')
211
        rev2 = t.commit('second post')
212
        rev3 = t.commit('third post')
213
        # Reset the tree, back to rev1
214
        t.set_parent_ids([rev1])
215
        t.branch.set_last_revision_info(1, rev1)
216
        self.assertConsistentParents([rev1], t)
217
        rev_tree1 = t.branch.repository.revision_tree(rev1)
218
        rev_tree2 = t.branch.repository.revision_tree(rev2)
219
        rev_tree3 = t.branch.repository.revision_tree(rev3)
220
        t.set_parent_trees([(rev1, rev_tree1), (rev2, rev_tree2),
221
                            (rev3, rev_tree3)])
222
        # rev2 is in the ancestry of rev3, so it will be filtered out
223
        self.assertConsistentParents([rev1, rev3], t)
224
        # Order should be preserved, and the first revision should always be
225
        # kept
226
        t.set_parent_trees([(rev2, rev_tree2), (rev1, rev_tree1),
227
                            (rev3, rev_tree3)])
228
        self.assertConsistentParents([rev2, rev3], t)
229
3763.9.7 by Daniel Clemente
Tested Unicode target rather than always trying to create it in UTF-8. Test renamed
230
    def test_unicode_symlink(self):
3763.9.1 by Daniel Clemente
New testcase for bug 272444 (support symlinks to non-ASCII files)
231
        # this tests bug #272444
4095.3.4 by Vincent Ladeuil
Some trivial cleanups, related to fix for bug #272444.
232
        self.requireFeature(tests.SymlinkFeature)
233
        self.requireFeature(tests.UnicodeFilenameFeature)
3763.9.1 by Daniel Clemente
New testcase for bug 272444 (support symlinks to non-ASCII files)
234
3763.9.3 by Daniel Clemente
Clearer test with better names and just one parent
235
        tree = self.make_branch_and_tree('tree1')
3763.9.2 by Daniel Clemente
Adapted test to use set_parent_ids and raise KnownFailure
236
3763.9.9 by Daniel Clemente
Used a greek omega instead of an accented 'o' to avoid combining characters
237
        # The link points to a file whose name is an omega
238
        # U+03A9 GREEK CAPITAL LETTER OMEGA
239
        # UTF-8: ce a9  UTF-16BE: 03a9  Decimal: Ω
4241.14.12 by Vincent Ladeuil
Far too many modifications for a single commit, need to restart.
240
        target = u'\u03a9'
241
        link_name = u'\N{Euro Sign}link'
242
        os.symlink(target, 'tree1/' + link_name)
243
        tree.add([link_name],['link-id'])
3763.9.2 by Daniel Clemente
Adapted test to use set_parent_ids and raise KnownFailure
244
4095.3.1 by Vincent Ladeuil
Fix #339055 and #277444 by handling non ascii symlink targets.
245
        revision1 = tree.commit('added a link to a Unicode target')
246
        revision2 = tree.commit('this revision will be discarded')
247
        tree.set_parent_ids([revision1])
4241.14.12 by Vincent Ladeuil
Far too many modifications for a single commit, need to restart.
248
        tree.lock_read()
249
        self.addCleanup(tree.unlock)
250
        # Check that the symlink target is safely round-tripped in the trees.
251
        self.assertEqual(target, tree.get_symlink_target('link-id'))
252
        basis = tree.basis_tree()
253
        self.assertEqual(target, basis.get_symlink_target('link-id'))
3763.9.1 by Daniel Clemente
New testcase for bug 272444 (support symlinks to non-ASCII files)
254
1908.5.4 by Robert Collins
Add add_parent_tree_id WorkingTree helper api.
255
1908.5.6 by Robert Collins
Add add_parent_tree to WorkingTree.
256
class TestAddParent(TestParents):
1908.5.4 by Robert Collins
Add add_parent_tree_id WorkingTree helper api.
257
258
    def test_add_first_parent_id(self):
259
        """Test adding the first parent id"""
260
        tree = self.make_branch_and_tree('.')
261
        first_revision = tree.commit('first post')
262
        uncommit(tree.branch, tree=tree)
263
        tree.add_parent_tree_id(first_revision)
264
        self.assertConsistentParents([first_revision], tree)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
265
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
266
    def test_add_first_parent_id_ghost_rejects(self):
267
        """Test adding the first parent id - as a ghost"""
268
        tree = self.make_branch_and_tree('.')
1908.5.12 by Robert Collins
Apply review feedback - paired with Martin.
269
        self.assertRaises(errors.GhostRevisionUnusableHere,
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
270
            tree.add_parent_tree_id, 'first-revision')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
271
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
272
    def test_add_first_parent_id_ghost_force(self):
273
        """Test adding the first parent id - as a ghost"""
274
        tree = self.make_branch_and_tree('.')
275
        tree.add_parent_tree_id('first-revision', allow_leftmost_as_ghost=True)
1908.5.4 by Robert Collins
Add add_parent_tree_id WorkingTree helper api.
276
        self.assertConsistentParents(['first-revision'], tree)
1908.5.13 by Robert Collins
Adding a parent when the first is a ghost already should not require forcing it.
277
278
    def test_add_second_parent_id_with_ghost_first(self):
279
        """Test adding the second parent when the first is a ghost."""
280
        tree = self.make_branch_and_tree('.')
281
        tree.add_parent_tree_id('first-revision', allow_leftmost_as_ghost=True)
282
        tree.add_parent_tree_id('second')
283
        self.assertConsistentParents(['first-revision', 'second'], tree)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
284
1908.5.4 by Robert Collins
Add add_parent_tree_id WorkingTree helper api.
285
    def test_add_second_parent_id(self):
286
        """Test adding the second parent id"""
287
        tree = self.make_branch_and_tree('.')
288
        first_revision = tree.commit('first post')
289
        uncommit(tree.branch, tree=tree)
290
        second_revision = tree.commit('second post')
291
        tree.add_parent_tree_id(first_revision)
292
        self.assertConsistentParents([second_revision, first_revision], tree)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
293
1908.5.4 by Robert Collins
Add add_parent_tree_id WorkingTree helper api.
294
    def test_add_second_parent_id_ghost(self):
295
        """Test adding the second parent id - as a ghost"""
296
        tree = self.make_branch_and_tree('.')
297
        first_revision = tree.commit('first post')
298
        tree.add_parent_tree_id('second')
299
        self.assertConsistentParents([first_revision, 'second'], tree)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
300
1908.5.6 by Robert Collins
Add add_parent_tree to WorkingTree.
301
    def test_add_first_parent_tree(self):
302
        """Test adding the first parent id"""
303
        tree = self.make_branch_and_tree('.')
304
        first_revision = tree.commit('first post')
305
        uncommit(tree.branch, tree=tree)
306
        tree.add_parent_tree((first_revision,
307
            tree.branch.repository.revision_tree(first_revision)))
308
        self.assertConsistentParents([first_revision], tree)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
309
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
310
    def test_add_first_parent_tree_ghost_rejects(self):
311
        """Test adding the first parent id - as a ghost"""
312
        tree = self.make_branch_and_tree('.')
1908.5.12 by Robert Collins
Apply review feedback - paired with Martin.
313
        self.assertRaises(errors.GhostRevisionUnusableHere,
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
314
            tree.add_parent_tree, ('first-revision', None))
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
315
1908.5.9 by Robert Collins
Add a guard against setting the tree last-revision value to a ghost in the new tree parent management api.
316
    def test_add_first_parent_tree_ghost_force(self):
317
        """Test adding the first parent id - as a ghost"""
318
        tree = self.make_branch_and_tree('.')
319
        tree.add_parent_tree(('first-revision', None),
320
            allow_leftmost_as_ghost=True)
1908.5.6 by Robert Collins
Add add_parent_tree to WorkingTree.
321
        self.assertConsistentParents(['first-revision'], tree)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
322
1908.5.6 by Robert Collins
Add add_parent_tree to WorkingTree.
323
    def test_add_second_parent_tree(self):
324
        """Test adding the second parent id"""
325
        tree = self.make_branch_and_tree('.')
326
        first_revision = tree.commit('first post')
327
        uncommit(tree.branch, tree=tree)
328
        second_revision = tree.commit('second post')
329
        tree.add_parent_tree((first_revision,
330
            tree.branch.repository.revision_tree(first_revision)))
331
        self.assertConsistentParents([second_revision, first_revision], tree)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
332
1908.5.6 by Robert Collins
Add add_parent_tree to WorkingTree.
333
    def test_add_second_parent_tree_ghost(self):
334
        """Test adding the second parent id - as a ghost"""
335
        tree = self.make_branch_and_tree('.')
336
        first_revision = tree.commit('first post')
337
        tree.add_parent_tree(('second', None))
338
        self.assertConsistentParents([first_revision, 'second'], tree)
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
339
340
3253.2.1 by John Arbash Meinel
Fix moving directories to root nodes.
341
class UpdateToOneParentViaDeltaTests(TestCaseWithWorkingTree):
2903.2.7 by Martin Pool
Rename update_to_one_parent_via_delta to more wieldy update_basis_by_delta
342
    """Tests for the update_basis_by_delta call.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
343
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
344
    This is intuitively defined as 'apply an inventory delta to the basis and
345
    discard other parents', but for trees that have an inventory that is not
346
    managed as a tree-by-id, the implementation requires roughly duplicated
347
    tests with those for apply_inventory_delta on the main tree.
348
    """
349
350
    def assertDeltaApplicationResultsInExpectedBasis(self, tree, revid, delta,
351
        expected_inventory):
2929.2.1 by Robert Collins
* Commit updates the state of the working tree via a delta rather than
352
        tree.lock_write()
353
        try:
354
            tree.update_basis_by_delta(revid, delta)
355
        finally:
356
            tree.unlock()
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
357
        # check the last revision was adjusted to rev_id
358
        self.assertEqual(revid, tree.last_revision())
359
        # check the parents are what we expect
360
        self.assertEqual([revid], tree.get_parent_ids())
361
        # check that the basis tree has the inventory we expect from applying
362
        # the delta.
363
        result_basis = tree.basis_tree()
364
        result_basis.lock_read()
3619.6.6 by Mark Hammond
eagerly unlock the result_basis to prevent handles staying open.
365
        try:
366
            self.assertEqual(expected_inventory, result_basis.inventory)
367
        finally:
368
            result_basis.unlock()
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
369
370
    def make_inv_delta(self, old, new):
371
        """Make an inventory delta from two inventories."""
372
        old_ids = set(old._byid.iterkeys())
373
        new_ids = set(new._byid.iterkeys())
374
        adds = new_ids - old_ids
375
        deletes = old_ids - new_ids
376
        common = old_ids.intersection(new_ids)
377
        delta = []
378
        for file_id in deletes:
379
            delta.append((old.id2path(file_id), None, file_id, None))
380
        for file_id in adds:
381
            delta.append((None, new.id2path(file_id), file_id, new[file_id]))
382
        for file_id in common:
383
            if old[file_id] != new[file_id]:
384
                delta.append((old.id2path(file_id), new.id2path(file_id),
385
                    file_id, new[file_id]))
386
        return delta
387
388
    def fake_up_revision(self, tree, revid, shape):
389
        tree.lock_write()
390
        try:
391
            tree.branch.repository.start_write_group()
392
            try:
393
                if shape.root.revision is None:
394
                    shape.root.revision = revid
395
                sha1 = tree.branch.repository.add_inventory(revid, shape, [])
396
                rev = Revision(timestamp=0,
397
                               timezone=None,
398
                               committer="Foo Bar <foo@example.com>",
399
                               message="Message",
400
                               inventory_sha1=sha1,
401
                               revision_id=revid)
402
                tree.branch.repository.add_revision(revid, rev)
403
            except:
404
                tree.branch.repository.abort_write_group()
405
                raise
406
            else:
407
                tree.branch.repository.commit_write_group()
408
        finally:
409
            tree.unlock()
410
411
    def add_entry(self, inv, rev_id, entry):
412
        entry.revision = rev_id
413
        inv.add(entry)
414
415
    def add_dir(self, inv, rev_id, file_id, parent_id, name):
416
        new_dir = InventoryDirectory(file_id, name, parent_id)
417
        self.add_entry(inv, rev_id, new_dir)
418
419
    def add_file(self, inv, rev_id, file_id, parent_id, name, sha, size):
420
        new_file = InventoryFile(file_id, name, parent_id)
421
        new_file.text_sha1 = sha
422
        new_file.text_size = size
423
        self.add_entry(inv, rev_id, new_file)
424
425
    def add_link(self, inv, rev_id, file_id, parent_id, name, target):
426
        new_link = InventoryLink(file_id, name, parent_id)
427
        new_link.symlink_target = target
428
        self.add_entry(inv, rev_id, new_link)
429
430
    def add_new_root(self, new_shape, old_revid, new_revid):
431
        if self.bzrdir_format.repository_format.rich_root_data:
432
            self.add_dir(new_shape, old_revid, 'root-id', None, '')
433
        else:
434
            self.add_dir(new_shape, new_revid, 'root-id', None, '')
435
436
    def assertTransitionFromBasisToShape(self, basis_shape, basis_revid,
437
        new_shape, new_revid, extra_parent=None):
2889.1.1 by Robert Collins
* The class ``bzrlib.repofmt.knitrepo.KnitRepository3`` has been folded into
438
        # set the inventory revision ids.
439
        basis_shape.revision_id = basis_revid
440
        new_shape.revision_id = new_revid
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
441
        delta = self.make_inv_delta(basis_shape, new_shape)
442
        tree = self.make_branch_and_tree('tree')
443
        # the shapes need to be in the tree's repository to be able to set them
444
        # as a parent, but the file content is not needed.
445
        if basis_revid is not None:
446
            self.fake_up_revision(tree, basis_revid, basis_shape)
447
            parents = [basis_revid]
448
            if extra_parent is not None:
449
                parents.append(extra_parent)
450
            tree.set_parent_ids(parents)
451
        self.fake_up_revision(tree, new_revid, new_shape)
2929.2.1 by Robert Collins
* Commit updates the state of the working tree via a delta rather than
452
        # give tree an inventory of new_shape
453
        tree._write_inventory(new_shape)
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
454
        self.assertDeltaApplicationResultsInExpectedBasis(tree, new_revid,
455
            delta, new_shape)
2929.2.2 by Robert Collins
Review feedback on dirstate update_basis_via_delta logic.
456
        # The tree should be internally consistent; while this is a moderately
457
        # large hammer, this is a particularly sensitive area of code, so the
458
        # extra assurance is well worth it.
459
        tree._validate()
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
460
        osutils.rmtree('tree')
461
462
    def test_no_parents_just_root(self):
463
        """Test doing an empty commit - no parent, set a root only."""
464
        basis_shape = Inventory(root_id=None) # empty tree
465
        new_shape = Inventory() # tree with a root
466
        self.assertTransitionFromBasisToShape(basis_shape, None, new_shape,
467
            'new_parent')
468
469
    def test_no_parents_full_tree(self):
470
        """Test doing a regular initial commit with files and dirs."""
471
        basis_shape = Inventory(root_id=None) # empty tree
472
        revid = 'new-parent'
473
        new_shape = Inventory(root_id=None)
474
        self.add_dir(new_shape, revid, 'root-id', None, '')
475
        self.add_link(new_shape, revid, 'link-id', 'root-id', 'link', 'target')
476
        self.add_file(new_shape, revid, 'file-id', 'root-id', 'file', '1' * 32,
477
            12)
478
        self.add_dir(new_shape, revid, 'dir-id', 'root-id', 'dir')
479
        self.add_file(new_shape, revid, 'subfile-id', 'dir-id', 'subfile',
480
            '2' * 32, 24)
481
        self.assertTransitionFromBasisToShape(basis_shape, None, new_shape,
482
            revid)
483
484
    def test_file_content_change(self):
485
        old_revid = 'old-parent'
486
        basis_shape = Inventory(root_id=None)
487
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
488
        self.add_file(basis_shape, old_revid, 'file-id', 'root-id', 'file',
489
            '1' * 32, 12)
490
        new_revid = 'new-parent'
491
        new_shape = Inventory(root_id=None)
492
        self.add_new_root(new_shape, old_revid, new_revid)
493
        self.add_file(new_shape, new_revid, 'file-id', 'root-id', 'file',
494
            '2' * 32, 24)
495
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
496
            new_shape, new_revid)
497
498
    def test_link_content_change(self):
499
        old_revid = 'old-parent'
500
        basis_shape = Inventory(root_id=None)
501
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
502
        self.add_link(basis_shape, old_revid, 'link-id', 'root-id', 'link',
503
            'old-target')
504
        new_revid = 'new-parent'
505
        new_shape = Inventory(root_id=None)
506
        self.add_new_root(new_shape, old_revid, new_revid)
507
        self.add_link(new_shape, new_revid, 'link-id', 'root-id', 'link',
508
            'new-target')
509
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
510
            new_shape, new_revid)
511
512
    def test_kind_changes(self):
513
        def do_file(inv, revid):
514
            self.add_file(inv, revid, 'path-id', 'root-id', 'path', '1' * 32,
515
                12)
516
        def do_link(inv, revid):
517
            self.add_link(inv, revid, 'path-id', 'root-id', 'path', 'target')
518
        def do_dir(inv, revid):
519
            self.add_dir(inv, revid, 'path-id', 'root-id', 'path')
520
        for old_factory in (do_file, do_link, do_dir):
521
            for new_factory in (do_file, do_link, do_dir):
522
                if old_factory == new_factory:
523
                    continue
524
                old_revid = 'old-parent'
525
                basis_shape = Inventory(root_id=None)
526
                self.add_dir(basis_shape, old_revid, 'root-id', None, '')
527
                old_factory(basis_shape, old_revid)
528
                new_revid = 'new-parent'
529
                new_shape = Inventory(root_id=None)
530
                self.add_new_root(new_shape, old_revid, new_revid)
531
                new_factory(new_shape, new_revid)
532
                self.assertTransitionFromBasisToShape(basis_shape, old_revid,
533
                    new_shape, new_revid)
534
535
    def test_content_from_second_parent_is_dropped(self):
536
        left_revid = 'left-parent'
537
        basis_shape = Inventory(root_id=None)
538
        self.add_dir(basis_shape, left_revid, 'root-id', None, '')
539
        self.add_link(basis_shape, left_revid, 'link-id', 'root-id', 'link',
540
            'left-target')
541
        # the right shape has content - file, link, subdir with a child,
542
        # that should all be discarded by the call.
543
        right_revid = 'right-parent'
544
        right_shape = Inventory(root_id=None)
545
        self.add_dir(right_shape, left_revid, 'root-id', None, '')
546
        self.add_link(right_shape, right_revid, 'link-id', 'root-id', 'link',
2865.1.3 by Robert Collins
Review feedback.
547
            'some-target')
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
548
        self.add_dir(right_shape, right_revid, 'subdir-id', 'root-id', 'dir')
549
        self.add_file(right_shape, right_revid, 'file-id', 'subdir-id', 'file',
550
            '2' * 32, 24)
551
        new_revid = 'new-parent'
552
        new_shape = Inventory(root_id=None)
553
        self.add_new_root(new_shape, left_revid, new_revid)
554
        self.add_link(new_shape, new_revid, 'link-id', 'root-id', 'link',
555
            'new-target')
556
        self.assertTransitionFromBasisToShape(basis_shape, left_revid,
557
            new_shape, new_revid, right_revid)
558
559
    def test_parent_id_changed(self):
2865.1.3 by Robert Collins
Review feedback.
560
        # test that when the only change to an entry is its parent id changing
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
561
        # that it is handled correctly (that is it keeps the same path)
562
        old_revid = 'old-parent'
563
        basis_shape = Inventory(root_id=None)
564
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
565
        self.add_dir(basis_shape, old_revid, 'orig-parent-id', 'root-id', 'dir')
566
        self.add_dir(basis_shape, old_revid, 'dir-id', 'orig-parent-id', 'dir')
567
        new_revid = 'new-parent'
568
        new_shape = Inventory(root_id=None)
569
        self.add_new_root(new_shape, old_revid, new_revid)
570
        self.add_dir(new_shape, new_revid, 'new-parent-id', 'root-id', 'dir')
571
        self.add_dir(new_shape, new_revid, 'dir-id', 'new-parent-id', 'dir')
572
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
573
            new_shape, new_revid)
574
575
    def test_name_changed(self):
2865.1.3 by Robert Collins
Review feedback.
576
        # test that when the only change to an entry is its name changing that
577
        # it is handled correctly (that is it keeps the same parent id)
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
578
        old_revid = 'old-parent'
579
        basis_shape = Inventory(root_id=None)
580
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
581
        self.add_dir(basis_shape, old_revid, 'parent-id', 'root-id', 'origdir')
582
        self.add_dir(basis_shape, old_revid, 'dir-id', 'parent-id', 'olddir')
583
        new_revid = 'new-parent'
584
        new_shape = Inventory(root_id=None)
585
        self.add_new_root(new_shape, old_revid, new_revid)
586
        self.add_dir(new_shape, new_revid, 'parent-id', 'root-id', 'newdir')
587
        self.add_dir(new_shape, new_revid, 'dir-id', 'parent-id', 'newdir')
588
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
589
            new_shape, new_revid)
590
2929.2.2 by Robert Collins
Review feedback on dirstate update_basis_via_delta logic.
591
    def test_parent_child_swap(self):
592
        # test a A->A/B and A/B->A path swap.
593
        old_revid = 'old-parent'
594
        basis_shape = Inventory(root_id=None)
595
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
596
        self.add_dir(basis_shape, old_revid, 'dir-id-A', 'root-id', 'A')
597
        self.add_dir(basis_shape, old_revid, 'dir-id-B', 'dir-id-A', 'B')
598
        self.add_link(basis_shape, old_revid, 'link-id-C', 'dir-id-B', 'C', 'C')
599
        new_revid = 'new-parent'
600
        new_shape = Inventory(root_id=None)
601
        self.add_new_root(new_shape, old_revid, new_revid)
602
        self.add_dir(new_shape, new_revid, 'dir-id-B', 'root-id', 'A')
603
        self.add_dir(new_shape, new_revid, 'dir-id-A', 'dir-id-B', 'B')
604
        self.add_link(new_shape, new_revid, 'link-id-C', 'dir-id-A', 'C', 'C')
605
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
606
            new_shape, new_revid)
607
3253.2.1 by John Arbash Meinel
Fix moving directories to root nodes.
608
    def test_parent_deleted_child_renamed(self):
609
        # test a A->None and A/B->A.
610
        old_revid = 'old-parent'
611
        basis_shape = Inventory(root_id=None)
612
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
613
        self.add_dir(basis_shape, old_revid, 'dir-id-A', 'root-id', 'A')
614
        self.add_dir(basis_shape, old_revid, 'dir-id-B', 'dir-id-A', 'B')
615
        self.add_link(basis_shape, old_revid, 'link-id-C', 'dir-id-B', 'C', 'C')
616
        new_revid = 'new-parent'
617
        new_shape = Inventory(root_id=None)
618
        self.add_new_root(new_shape, old_revid, new_revid)
619
        self.add_dir(new_shape, new_revid, 'dir-id-B', 'root-id', 'A')
620
        self.add_link(new_shape, old_revid, 'link-id-C', 'dir-id-B', 'C', 'C')
621
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
622
            new_shape, new_revid)
623
624
    def test_dir_to_root(self):
625
        # test a A->''.
626
        old_revid = 'old-parent'
627
        basis_shape = Inventory(root_id=None)
628
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
629
        self.add_dir(basis_shape, old_revid, 'dir-id-A', 'root-id', 'A')
630
        self.add_link(basis_shape, old_revid, 'link-id-B', 'dir-id-A', 'B', 'B')
631
        new_revid = 'new-parent'
632
        new_shape = Inventory(root_id=None)
633
        self.add_dir(new_shape, new_revid, 'dir-id-A', None, '')
634
        self.add_link(new_shape, old_revid, 'link-id-B', 'dir-id-A', 'B', 'B')
635
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
636
            new_shape, new_revid)
637
2865.1.1 by Robert Collins
Create new mutable tree method update_to_one_parent_via_delta for eventual use by commit.
638
    def test_path_swap(self):
639
        # test a A->B and B->A path swap.
640
        old_revid = 'old-parent'
641
        basis_shape = Inventory(root_id=None)
642
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
643
        self.add_dir(basis_shape, old_revid, 'dir-id-A', 'root-id', 'A')
644
        self.add_dir(basis_shape, old_revid, 'dir-id-B', 'root-id', 'B')
645
        self.add_link(basis_shape, old_revid, 'link-id-C', 'root-id', 'C', 'C')
646
        self.add_link(basis_shape, old_revid, 'link-id-D', 'root-id', 'D', 'D')
647
        self.add_file(basis_shape, old_revid, 'file-id-E', 'root-id', 'E',
648
            '1' * 32, 12)
649
        self.add_file(basis_shape, old_revid, 'file-id-F', 'root-id', 'F',
650
            '2' * 32, 24)
651
        new_revid = 'new-parent'
652
        new_shape = Inventory(root_id=None)
653
        self.add_new_root(new_shape, old_revid, new_revid)
654
        self.add_dir(new_shape, new_revid, 'dir-id-A', 'root-id', 'B')
655
        self.add_dir(new_shape, new_revid, 'dir-id-B', 'root-id', 'A')
656
        self.add_link(new_shape, new_revid, 'link-id-C', 'root-id', 'D', 'C')
657
        self.add_link(new_shape, new_revid, 'link-id-D', 'root-id', 'C', 'D')
658
        self.add_file(new_shape, new_revid, 'file-id-E', 'root-id', 'F',
659
            '1' * 32, 12)
660
        self.add_file(new_shape, new_revid, 'file-id-F', 'root-id', 'E',
661
            '2' * 32, 24)
662
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
663
            new_shape, new_revid)
664
665
    def test_adds(self):
666
        # test adding paths and dirs, including adding to a newly added dir.
667
        old_revid = 'old-parent'
668
        basis_shape = Inventory(root_id=None)
669
        # with a root, so its a commit after the first.
670
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
671
        new_revid = 'new-parent'
672
        new_shape = Inventory(root_id=None)
673
        self.add_new_root(new_shape, old_revid, new_revid)
674
        self.add_dir(new_shape, new_revid, 'dir-id-A', 'root-id', 'A')
675
        self.add_link(new_shape, new_revid, 'link-id-B', 'root-id', 'B', 'C')
676
        self.add_file(new_shape, new_revid, 'file-id-C', 'root-id', 'C',
677
            '1' * 32, 12)
678
        self.add_file(new_shape, new_revid, 'file-id-D', 'dir-id-A', 'D',
679
            '2' * 32, 24)
680
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
681
            new_shape, new_revid)
682
683
    def test_removes(self):
684
        # test removing paths, including paths that are within other also
685
        # removed paths.
686
        old_revid = 'old-parent'
687
        basis_shape = Inventory(root_id=None)
688
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
689
        self.add_dir(basis_shape, old_revid, 'dir-id-A', 'root-id', 'A')
690
        self.add_link(basis_shape, old_revid, 'link-id-B', 'root-id', 'B', 'C')
691
        self.add_file(basis_shape, old_revid, 'file-id-C', 'root-id', 'C',
692
            '1' * 32, 12)
693
        self.add_file(basis_shape, old_revid, 'file-id-D', 'dir-id-A', 'D',
694
            '2' * 32, 24)
695
        new_revid = 'new-parent'
696
        new_shape = Inventory(root_id=None)
697
        self.add_new_root(new_shape, old_revid, new_revid)
698
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
699
            new_shape, new_revid)
700
701
    def test_move_to_added_dir(self):
702
        old_revid = 'old-parent'
703
        basis_shape = Inventory(root_id=None)
704
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
705
        self.add_link(basis_shape, old_revid, 'link-id-B', 'root-id', 'B', 'C')
706
        new_revid = 'new-parent'
707
        new_shape = Inventory(root_id=None)
708
        self.add_new_root(new_shape, old_revid, new_revid)
709
        self.add_dir(new_shape, new_revid, 'dir-id-A', 'root-id', 'A')
710
        self.add_link(new_shape, new_revid, 'link-id-B', 'dir-id-A', 'B', 'C')
711
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
712
            new_shape, new_revid)
713
714
    def test_move_from_removed_dir(self):
715
        old_revid = 'old-parent'
716
        basis_shape = Inventory(root_id=None)
717
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
718
        self.add_dir(basis_shape, old_revid, 'dir-id-A', 'root-id', 'A')
719
        self.add_link(basis_shape, old_revid, 'link-id-B', 'dir-id-A', 'B', 'C')
720
        new_revid = 'new-parent'
721
        new_shape = Inventory(root_id=None)
722
        self.add_new_root(new_shape, old_revid, new_revid)
723
        self.add_link(new_shape, new_revid, 'link-id-B', 'root-id', 'B', 'C')
724
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
725
            new_shape, new_revid)
2929.2.1 by Robert Collins
* Commit updates the state of the working tree via a delta rather than
726
727
    def test_move_moves_children_recursively(self):
728
        old_revid = 'old-parent'
729
        basis_shape = Inventory(root_id=None)
730
        self.add_dir(basis_shape, old_revid, 'root-id', None, '')
731
        self.add_dir(basis_shape, old_revid, 'dir-id-A', 'root-id', 'A')
732
        self.add_dir(basis_shape, old_revid, 'dir-id-B', 'dir-id-A', 'B')
733
        self.add_link(basis_shape, old_revid, 'link-id-C', 'dir-id-B', 'C', 'D')
734
        new_revid = 'new-parent'
735
        new_shape = Inventory(root_id=None)
736
        self.add_new_root(new_shape, old_revid, new_revid)
737
        # the moved path:
738
        self.add_dir(new_shape, new_revid, 'dir-id-A', 'root-id', 'B')
739
        # unmoved children.
740
        self.add_dir(new_shape, old_revid, 'dir-id-B', 'dir-id-A', 'B')
741
        self.add_link(new_shape, old_revid, 'link-id-C', 'dir-id-B', 'C', 'D')
742
        self.assertTransitionFromBasisToShape(basis_shape, old_revid,
743
            new_shape, new_revid)