~bzr-pqm/bzr/bzr.dev

3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
62
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
63
    trace,
1551.8.30 by Aaron Bentley
Tweak from review comments
64
    tree,
65
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
66
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
67
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
68
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
69
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
70
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
71
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
72
from bzrlib.osutils import (get_user_encoding,
73
                            kind_marker, isdir,isfile, is_inside_any,
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
74
                            is_inside_or_parent_of_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
75
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
76
                            quotefn, sha_file, split_lines,
77
                            splitpath,
78
                            )
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
79
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
80
from bzrlib.trace import mutter, note, warning, is_quiet
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
81
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
82
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
83
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
84
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
85
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
86
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
87
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
88
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
89
90
91
class NullCommitReporter(object):
92
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
93
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
94
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
95
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
96
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
97
                                   "to started.", DeprecationWarning,
98
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
99
        pass
100
101
    def snapshot_change(self, change, path):
102
        pass
103
104
    def completed(self, revno, rev_id):
105
        pass
106
107
    def deleted(self, file_id):
108
        pass
109
110
    def escaped(self, escape_count, message):
111
        pass
112
113
    def missing(self, path):
114
        pass
115
116
    def renamed(self, change, old_path, new_path):
117
        pass
118
2789.2.11 by Ian Clatworthy
remove more reporting stuff
119
    def is_verbose(self):
120
        return False
121
122
123
class ReportCommitToLog(NullCommitReporter):
124
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
125
    def _note(self, format, *args):
126
        """Output a message.
127
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
128
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
129
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
130
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
131
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
132
    def snapshot_change(self, change, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
133
        if change == 'unchanged':
134
            return
135
        if change == 'added' and path == '':
136
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
137
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
138
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
139
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
140
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
141
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
142
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
143
            # When started was added, location was only made optional by
144
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
145
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
146
                                   "to started.", DeprecationWarning,
147
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
148
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
149
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
150
151
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
152
        self._note('Committed revision %d.', revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
153
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
154
    def deleted(self, file_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
155
        self._note('deleted %s', file_id)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
156
157
    def escaped(self, escape_count, message):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
158
        self._note("replaced %d control characters in message", escape_count)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
159
160
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
161
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
162
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
163
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
164
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
165
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
166
    def is_verbose(self):
167
        return True
168
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
169
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
class Commit(object):
171
    """Task of committing a new revision.
172
173
    This is a MethodObject: it accumulates state as the commit is
174
    prepared, and then it is discarded.  It doesn't represent
175
    historical revisions, just the act of recording a new one.
176
177
            missing_ids
178
            Modified to hold a list of files that have been deleted from
179
            the working directory; these should be removed from the
180
            working inventory.
485 by Martin Pool
- move commit code into its own module
181
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
183
                 reporter=None,
184
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
185
        """Create a Commit object.
186
187
        :param reporter: the default reporter to use or None to decide later
188
        """
189
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
190
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
191
1189 by Martin Pool
- BROKEN: partial support for commit into weave
192
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
193
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
194
               timestamp=None,
195
               timezone=None,
196
               committer=None,
197
               specific_files=None,
198
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
199
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
200
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
201
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
202
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
203
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
204
               local=False,
205
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
206
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
207
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
208
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
209
               exclude=None,
210
               possible_master_transports=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
211
        """Commit working copy as a new revision.
212
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
213
        :param message: the commit message (it or message_callback is required)
214
215
        :param timestamp: if not None, seconds-since-epoch for a
216
            postdated/predated commit.
217
218
        :param specific_files: If true, commit only those files.
219
220
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
221
            Useful for test or import commands that need to tightly
222
            control what revisions are assigned.  If you duplicate
223
            a revision id that exists elsewhere it is your own fault.
224
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
225
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
226
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
227
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
228
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
229
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
230
            contains unknown files.
231
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
232
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
233
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
234
        :param reporter: the reporter to use or None for the default
235
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
236
        :param recursive: If set to 'down', commit in any subtrees that have
237
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
238
        :param exclude: None or a list of relative paths to exclude from the
239
            commit. Pending changes to excluded files will be ignored by the
240
            commit. 
1189 by Martin Pool
- BROKEN: partial support for commit into weave
241
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
242
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
243
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
244
        if working_tree is None:
245
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
246
        else:
247
            self.work_tree = working_tree
248
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
249
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
250
                if not self.branch.repository.supports_rich_root():
251
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
252
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
253
            if message is not None:
254
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
255
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
256
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
257
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
258
                raise BzrError("The message or message_callback keyword"
259
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
260
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
261
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
262
        self.any_entries_changed = False
263
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
264
        if exclude is not None:
265
            self.exclude = sorted(
266
                minimum_path_selection(exclude))
267
        else:
268
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
269
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
270
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
271
        self.master_locked = False
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
272
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
273
        self.rev_id = None
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
274
        if specific_files is not None:
275
            self.specific_files = sorted(
276
                minimum_path_selection(specific_files))
277
        else:
278
            self.specific_files = None
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
279
        self.specific_file_ids = None
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
280
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
281
        self.revprops = revprops
282
        self.message_callback = message_callback
283
        self.timestamp = timestamp
284
        self.timezone = timezone
285
        self.committer = committer
286
        self.strict = strict
287
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
288
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
289
        self.work_tree.lock_write()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
290
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
291
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
292
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
293
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
294
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
295
            # Cannot commit with conflicts present.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
296
            if len(self.work_tree.conflicts()) > 0:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
297
                raise ConflictsInTree
298
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
299
            # Setup the bound branch variables as needed.
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
300
            self._check_bound_branch(possible_master_transports)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
301
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
302
            # Check that the working tree is up to date
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
303
            old_revno, new_revno = self._check_out_of_date_tree()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
304
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
305
            # Complete configuration setup
306
            if reporter is not None:
307
                self.reporter = reporter
308
            elif self.reporter is None:
309
                self.reporter = self._select_reporter()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
310
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
311
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
312
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
313
            # If provided, ensure the specified files are versioned
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
314
            if self.specific_files is not None:
2776.4.13 by Robert Collins
Merge bzr.dev.
315
                # Note: This routine is being called because it raises
2776.4.14 by Robert Collins
Merge bzr.dev.
316
                # PathNotVersionedError as a side effect of finding the IDs. We
2776.4.13 by Robert Collins
Merge bzr.dev.
317
                # later use the ids we found as input to the working tree
318
                # inventory iterator, so we only consider those ids rather than
319
                # examining the whole tree again.
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
320
                # XXX: Dont we have filter_unversioned to do this more
321
                # cheaply?
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
322
                self.specific_file_ids = tree.find_ids_across_trees(
323
                    specific_files, [self.basis_tree, self.work_tree])
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
324
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
325
            # Setup the progress bar. As the number of files that need to be
326
            # committed in unknown, progress is reported as stages.
327
            # We keep track of entries separately though and include that
328
            # information in the progress bar during the relevant stages.
329
            self.pb_stage_name = ""
330
            self.pb_stage_count = 0
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
331
            self.pb_stage_total = 5
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
332
            if self.bound_branch:
333
                self.pb_stage_total += 1
334
            self.pb.show_pct = False
335
            self.pb.show_spinner = False
336
            self.pb.show_eta = False
337
            self.pb.show_count = True
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
338
            self.pb.show_bar = True
1189 by Martin Pool
- BROKEN: partial support for commit into weave
339
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
340
            self.basis_inv = self.basis_tree.inventory
341
            self._gather_parents()
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
342
            # After a merge, a selected file commit is not supported.
343
            # See 'bzr help merge' for an explanation as to why.
1344 by Martin Pool
- disallow selected-file commit of merges
344
            if len(self.parents) > 1 and self.specific_files:
1551.15.9 by Aaron Bentley
Better error for selected-file commit of merges
345
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
346
            # Excludes are a form of selected file commit.
347
            if len(self.parents) > 1 and self.exclude:
348
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
349
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
350
            # Collect the changes
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
351
            self._set_progress_stage("Collecting changes",
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
352
                    entries_title="Directory")
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
353
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
354
                self.config, timestamp, timezone, committer, revprops, rev_id)
3879.2.3 by John Arbash Meinel
Hide the .basis_delta variable, and require callers to use .get_basis_delta()
355
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
356
            try:
3879.2.3 by John Arbash Meinel
Hide the .basis_delta variable, and require callers to use .get_basis_delta()
357
                self.builder.will_record_deletes()
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
358
                # find the location being committed to
359
                if self.bound_branch:
360
                    master_location = self.master_branch.base
361
                else:
362
                    master_location = self.branch.base
363
364
                # report the start of the commit
365
                self.reporter.started(new_revno, self.rev_id, master_location)
366
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
367
                self._update_builder_with_changes()
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
368
                self._report_and_accumulate_deletes()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
369
                self._check_pointless()
370
371
                # TODO: Now the new inventory is known, check for conflicts.
372
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
373
                # weave lines, because nothing should be recorded until it is known
374
                # that commit will succeed.
2592.3.49 by Robert Collins
Merge bzr.dev.
375
                self._set_progress_stage("Saving data locally")
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
376
                self.builder.finish_inventory()
377
378
                # Prompt the user for a commit message if none provided
379
                message = message_callback(self)
380
                self.message = message
381
                self._escape_commit_message()
382
383
                # Add revision data to the local branch
384
                self.rev_id = self.builder.commit(self.message)
2659.3.5 by NamNguyen
merge with bzr.dev
385
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
386
            except Exception, e:
387
                mutter("aborting commit write group because of exception:")
388
                trace.log_exception_quietly()
389
                note("aborting commit write group: %r" % (e,))
2749.3.1 by Jelmer Vernooij
Add CommitBuilder.abort().
390
                self.builder.abort()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
391
                raise
392
2659.3.6 by NamNguyen
branch_implementations/test_commit.py:
393
            self._process_pre_hooks(old_revno, new_revno)
394
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
395
            # Upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
396
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
397
            if self.bound_branch:
3113.6.7 by Aaron Bentley
Fix commit for a checkout sharing a repo with its branch (abentley, #177592)
398
                if not self.master_branch.repository.has_same_location(
399
                        self.branch.repository):
400
                    self._set_progress_stage("Uploading data to master branch")
401
                    self.master_branch.repository.fetch(self.branch.repository,
402
                        revision_id=self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
403
                # now the master has the revision data
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
404
                # 'commit' to the master first so a timeout here causes the
405
                # local branch to be out of date
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
406
                self.master_branch.set_last_revision_info(new_revno,
407
                                                          self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
408
409
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
410
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
411
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
412
            # Make the working tree up to date with the branch
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
413
            self._set_progress_stage("Updating the working tree")
2929.2.1 by Robert Collins
* Commit updates the state of the working tree via a delta rather than
414
            self.work_tree.update_basis_by_delta(self.rev_id,
3879.2.3 by John Arbash Meinel
Hide the .basis_delta variable, and require callers to use .get_basis_delta()
415
                 self.builder.get_basis_delta())
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
416
            self.reporter.completed(new_revno, self.rev_id)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
417
            self._process_post_hooks(old_revno, new_revno)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
418
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
419
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
420
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
421
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
422
    def _select_reporter(self):
423
        """Select the CommitReporter to use."""
424
        if is_quiet():
425
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
426
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
427
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
428
    def _check_pointless(self):
429
        if self.allow_pointless:
430
            return
431
        # A merge with no effect on files
432
        if len(self.parents) > 1:
433
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
434
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
435
2921.4.6 by Robert Collins
Typos found by Rob Weir.
436
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
437
        # a worthwhile commit.
438
        if (self.basis_revid == revision.NULL_REVISION and
439
            len(self.builder.new_inventory) == 1):
1731.1.49 by Aaron Bentley
Merge bzr.dev
440
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
441
        # If length == 1, then we only have the root entry. Which means
442
        # that there is no real difference (only the root could be different)
2921.4.7 by Robert Collins
Correct the check_pointless change to pass all tests.
443
        # unless deletes occured, in which case the length is irrelevant.
444
        if (self.any_entries_deleted or 
445
            (len(self.builder.new_inventory) != 1 and
446
             self.any_entries_changed)):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
447
            return
448
        raise PointlessCommit()
449
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
450
    def _check_bound_branch(self, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
451
        """Check to see if the local branch is bound.
452
453
        If it is bound, then most of the commit will actually be
454
        done using the remote branch as the target branch.
455
        Only at the end will the local branch be updated.
456
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
457
        if self.local and not self.branch.get_bound_location():
458
            raise errors.LocalRequiresBoundBranch()
459
460
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
461
            self.master_branch = self.branch.get_master_branch(
462
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
463
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
464
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
465
            # make this branch the reference branch for out of date checks.
466
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
467
            return
468
469
        # If the master branch is bound, we must fail
470
        master_bound_location = self.master_branch.get_bound_location()
471
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
472
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
473
                    self.master_branch, master_bound_location)
474
475
        # TODO: jam 20051230 We could automatically push local
476
        #       commits to the remote branch if they would fit.
477
        #       But for now, just require remote to be identical
478
        #       to local.
479
        
480
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
481
        master_info = self.master_branch.last_revision_info()
482
        local_info = self.branch.last_revision_info()
483
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
484
            raise errors.BoundBranchOutOfDate(self.branch,
485
                    self.master_branch)
486
487
        # Now things are ready to change the master branch
488
        # so grab the lock
489
        self.bound_branch = self.branch
490
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
491
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
492
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
493
    def _check_out_of_date_tree(self):
494
        """Check that the working tree is up to date.
495
496
        :return: old_revision_number,new_revision_number tuple
497
        """
498
        try:
499
            first_tree_parent = self.work_tree.get_parent_ids()[0]
500
        except IndexError:
501
            # if there are no parents, treat our parent as 'None'
502
            # this is so that we still consider the master branch
503
            # - in a checkout scenario the tree may have no
504
            # parents but the branch may do.
505
            first_tree_parent = bzrlib.revision.NULL_REVISION
506
        old_revno, master_last = self.master_branch.last_revision_info()
507
        if master_last != first_tree_parent:
508
            if master_last != bzrlib.revision.NULL_REVISION:
509
                raise errors.OutOfDateTree(self.work_tree)
510
        if self.branch.repository.has_revision(first_tree_parent):
511
            new_revno = old_revno + 1
512
        else:
513
            # ghost parents never appear in revision history.
514
            new_revno = 1
515
        return old_revno,new_revno
516
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
517
    def _process_pre_hooks(self, old_revno, new_revno):
518
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
519
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
520
        self._process_hooks("pre_commit", old_revno, new_revno)
521
522
    def _process_post_hooks(self, old_revno, new_revno):
523
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
524
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
525
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
526
        # old style commit hooks - should be deprecated ? (obsoleted in
527
        # 0.15)
528
        if self.config.post_commit() is not None:
529
            hooks = self.config.post_commit().split(' ')
530
            # this would be nicer with twisted.python.reflect.namedAny
531
            for hook in hooks:
532
                result = eval(hook + '(branch, rev_id)',
533
                              {'branch':self.branch,
534
                               'bzrlib':bzrlib,
535
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
536
        # process new style post commit hooks
537
        self._process_hooks("post_commit", old_revno, new_revno)
538
539
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
540
        if not Branch.hooks[hook_name]:
541
            return
542
        
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
543
        # new style commit hooks:
544
        if not self.bound_branch:
545
            hook_master = self.branch
546
            hook_local = None
547
        else:
548
            hook_master = self.master_branch
549
            hook_local = self.branch
550
        # With bound branches, when the master is behind the local branch,
551
        # the 'old_revno' and old_revid values here are incorrect.
552
        # XXX: FIXME ^. RBC 20060206
553
        if self.parents:
554
            old_revid = self.parents[0]
555
        else:
556
            old_revid = bzrlib.revision.NULL_REVISION
2659.3.9 by NamNguyen
branch.py:
557
        
558
        if hook_name == "pre_commit":
559
            future_tree = self.builder.revision_tree()
560
            tree_delta = future_tree.changes_from(self.basis_tree,
561
                                             include_root=True)
562
        
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
563
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
564
            # show the running hook in the progress bar. As hooks may
565
            # end up doing nothing (e.g. because they are not configured by
566
            # the user) this is still showing progress, not showing overall
567
            # actions - its up to each plugin to show a UI if it want's to
568
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
569
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
570
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
571
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
572
            if 'hooks' in debug.debug_flags:
573
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
574
            if hook_name == "post_commit":
575
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
576
                     self.rev_id)
577
            elif hook_name == "pre_commit":
578
                hook(hook_local, hook_master,
579
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
580
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
581
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
582
    def _cleanup(self):
583
        """Cleanup any open locks, progress bars etc."""
584
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
585
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
586
                    self.work_tree.unlock,
587
                    self.pb.finished]
588
        found_exception = None
589
        for cleanup in cleanups:
590
            try:
591
                cleanup()
592
            # we want every cleanup to run no matter what.
593
            # so we have a catchall here, but we will raise the
594
            # last encountered exception up the stack: and
595
            # typically this will be useful enough.
596
            except Exception, e:
597
                found_exception = e
598
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
599
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
600
            # trashed, e is our sure-to-work exception even though it loses the
601
            # full traceback. XXX: RBC 20060421 perhaps we could check the
602
            # exc_info and if its the same one do a plain raise otherwise 
603
            # 'raise e' as we do now.
604
            raise e
605
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
606
    def _cleanup_bound_branch(self):
607
        """Executed at the end of a try/finally to cleanup a bound branch.
608
609
        If the branch wasn't bound, this is a no-op.
610
        If it was, it resents self.branch to the local branch, instead
611
        of being the master.
612
        """
613
        if not self.bound_branch:
614
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
615
        if self.master_locked:
616
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
617
1390 by Robert Collins
pair programming worx... merge integration and weave
618
    def _escape_commit_message(self):
619
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
620
        # FIXME: RBC 20060419 this should be done by the revision
621
        # serialiser not by commit. Then we can also add an unescaper
622
        # in the deserializer and start roundtripping revision messages
623
        # precisely. See repository_implementations/test_repository.py
624
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
625
        # Python strings can include characters that can't be
626
        # represented in well-formed XML; escape characters that
627
        # aren't listed in the XML specification
628
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
629
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
630
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
631
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
632
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
633
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
634
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
635
636
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
637
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
638
        # TODO: Make sure that this list doesn't contain duplicate 
639
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
640
        self.parents = self.work_tree.get_parent_ids()
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
641
        self.parent_invs = [self.basis_inv]
642
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
643
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
644
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
645
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
646
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
647
            else:
648
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
649
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
650
    def _update_builder_with_changes(self):
651
        """Update the commit builder with the data about what has changed.
652
        """
653
        # Build the revision inventory.
654
        #
655
        # This starts by creating a new empty inventory. Depending on
656
        # which files are selected for commit, and what is present in the
657
        # current tree, the new inventory is populated. inventory entries 
658
        # which are candidates for modification have their revision set to
659
        # None; inventory entries that are carried over untouched have their
660
        # revision set to their prior value.
661
        #
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
662
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
663
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
664
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
665
        # ADHB 11-07-2006
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
666
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
667
        exclude = self.exclude
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
668
        specific_files = self.specific_files or []
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
669
        mutter("Selecting files for commit with filter %s", specific_files)
670
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
671
        # Build the new inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
672
        self._populate_from_inventory()
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
673
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
674
        # If specific files are selected, then all un-selected files must be
675
        # recorded in their previous state. For more details, see
676
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
677
        if specific_files or exclude:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
678
            for path, old_ie in self.basis_inv.iter_entries():
679
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
680
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
681
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
682
                if (is_inside_any(specific_files, path)
683
                    and not is_inside_any(exclude, path)):
684
                    # was inside the selected path, and not excluded - if not
685
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
686
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
687
                # From here down it was either not selected, or was excluded:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
688
                if old_ie.kind == 'directory':
689
                    self._next_progress_entry()
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
690
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
691
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
692
                # Note: specific file commits after a merge are currently
693
                # prohibited. This test is for sanity/safety in case it's
694
                # required after that changes.
695
                if len(self.parents) > 1:
696
                    ie.revision = None
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
697
                _, version_recorded, _ = self.builder.record_entry_contents(
2871.1.4 by Robert Collins
Merge bzr.dev.
698
                    ie, self.parent_invs, path, self.basis_tree, None)
2871.1.3 by Robert Collins
* The CommitBuilder method ``record_entry_contents`` now returns summary
699
                if version_recorded:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
700
                    self.any_entries_changed = True
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
701
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
702
    def _report_and_accumulate_deletes(self):
2903.2.6 by Martin Pool
Remove unnecessary double handling of deletions
703
        # XXX: Could the list of deleted paths and ids be instead taken from
704
        # _populate_from_inventory?
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
705
        if (isinstance(self.basis_inv, Inventory)
706
            and isinstance(self.builder.new_inventory, Inventory)):
707
            # the older Inventory classes provide a _byid dict, and building a
708
            # set from the keys of this dict is substantially faster than even
709
            # getting a set of ids from the inventory
710
            #
711
            # <lifeless> set(dict) is roughly the same speed as
712
            # set(iter(dict)) and both are significantly slower than
713
            # set(dict.keys())
714
            deleted_ids = set(self.basis_inv._byid.keys()) - \
715
               set(self.builder.new_inventory._byid.keys())
716
        else:
717
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
718
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
719
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
720
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
721
                for file_id in deleted_ids]
722
            deleted.sort()
723
            # XXX: this is not quite directory-order sorting
724
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
725
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
726
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
727
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
728
    def _populate_from_inventory(self):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
729
        """Populate the CommitBuilder by walking the working tree inventory."""
730
        if self.strict:
731
            # raise an exception as soon as we find a single unknown.
732
            for unknown in self.work_tree.unknowns():
733
                raise StrictCommitFailed()
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
734
        
735
        specific_files = self.specific_files
736
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
737
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
738
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
739
        # A tree of paths that have been deleted. E.g. if foo/bar has been
740
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
741
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
742
        # XXX: Note that entries may have the wrong kind because the entry does
743
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
744
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
745
        # NB: entries will include entries within the excluded ids/paths
746
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
747
        entries = work_inv.iter_entries_by_dir(
748
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
749
        for path, existing_ie in entries:
750
            file_id = existing_ie.file_id
751
            name = existing_ie.name
752
            parent_id = existing_ie.parent_id
753
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
754
            if kind == 'directory':
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
755
                self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
756
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
757
            # The deleted path ids are also recorded so they can be explicitly
758
            # unversioned later.
759
            if deleted_paths:
760
                path_segments = splitpath(path)
761
                deleted_dict = deleted_paths
762
                for segment in path_segments:
763
                    deleted_dict = deleted_dict.get(segment, None)
764
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
765
                        # We either took a path not present in the dict
766
                        # (deleted_dict was None), or we've reached an empty
767
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
768
                        break
769
                else:
770
                    deleted_dict = None
771
                if deleted_dict is not None:
772
                    # the path has a deleted parent, do not add it.
773
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
774
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
775
                # Skip excluded paths. Excluded paths are processed by
776
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
777
                continue
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
778
            content_summary = self.work_tree.path_content_summary(path)
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
779
            # Note that when a filter of specific files is given, we must only
780
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
781
            if not specific_files or is_inside_any(specific_files, path):
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
782
                if content_summary[0] == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
783
                    if not deleted_paths:
784
                        # path won't have been split yet.
785
                        path_segments = splitpath(path)
786
                    deleted_dict = deleted_paths
787
                    for segment in path_segments:
788
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
789
                    self.reporter.missing(path)
790
                    deleted_ids.append(file_id)
791
                    continue
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
792
            # TODO: have the builder do the nested commit just-in-time IF and
793
            # only if needed.
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
794
            if content_summary[0] == 'tree-reference':
795
                # enforce repository nested tree policy.
796
                if (not self.work_tree.supports_tree_reference() or
797
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
798
                    not self.branch.repository._format.supports_tree_reference):
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
799
                    content_summary = ('directory',) + content_summary[1:]
800
            kind = content_summary[0]
801
            # TODO: specific_files filtering before nested tree processing
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
802
            if kind == 'tree-reference':
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
803
                if self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
804
                    nested_revision_id = self._commit_nested_tree(
805
                        file_id, path)
806
                    content_summary = content_summary[:3] + (
807
                        nested_revision_id,)
808
                else:
809
                    content_summary = content_summary[:3] + (
810
                        self.work_tree.get_reference_revision(file_id),)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
811
812
            # Record an entry for this item
813
            # Note: I don't particularly want to have the existing_ie
814
            # parameter but the test suite currently (28-Jun-07) breaks
815
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
816
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
817
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
818
                parent_id, definitely_changed, existing_ie, report_changes,
819
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
820
821
        # Unversion IDs that were found to be deleted
822
        self.work_tree.unversion(deleted_ids)
823
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
824
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
825
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
826
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
827
        # FIXME: be more comprehensive here:
828
        # this works when both trees are in --trees repository,
829
        # but when both are bound to a different repository,
830
        # it fails; a better way of approaching this is to 
831
        # finally implement the explicit-caches approach design
832
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
833
        if sub_tree.branch.repository.has_same_location(
834
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
835
            sub_tree.branch.repository = \
836
                self.work_tree.branch.repository
837
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
838
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
839
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
840
                message_callback=self.message_callback,
841
                timestamp=self.timestamp, timezone=self.timezone,
842
                committer=self.committer,
843
                allow_pointless=self.allow_pointless,
844
                strict=self.strict, verbose=self.verbose,
845
                local=self.local, reporter=self.reporter)
846
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
847
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
848
849
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
850
        parent_id, definitely_changed, existing_ie, report_changes,
851
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
852
        "Record the new inventory entry for a path if any."
853
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
854
        # mutter('%s selected for commit', path)
855
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
856
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
857
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
858
            ie = existing_ie.copy()
859
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
860
        # For carried over entries we don't care about the fs hash - the repo
861
        # isn't generating a sha, so we're not saving computation time.
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
862
        _, version_recorded, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
863
            ie, self.parent_invs, path, self.work_tree, content_summary)
2871.1.3 by Robert Collins
* The CommitBuilder method ``record_entry_contents`` now returns summary
864
        if version_recorded:
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
865
            self.any_entries_changed = True
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
866
        if report_changes:
867
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
868
        if fs_hash:
869
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
870
        return ie
871
872
    def _report_change(self, ie, path):
873
        """Report a change to the user.
874
875
        The change that has occurred is described relative to the basis
876
        inventory.
877
        """
878
        if (self.basis_inv.has_id(ie.file_id)):
879
            basis_ie = self.basis_inv[ie.file_id]
880
        else:
881
            basis_ie = None
882
        change = ie.describe_change(basis_ie, ie)
883
        if change in (InventoryEntry.RENAMED, 
884
            InventoryEntry.MODIFIED_AND_RENAMED):
885
            old_path = self.basis_inv.id2path(ie.file_id)
886
            self.reporter.renamed(change, old_path, path)
887
        else:
888
            self.reporter.snapshot_change(change, path)
889
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
890
    def _set_progress_stage(self, name, entries_title=None):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
891
        """Set the progress stage and emit an update to the progress bar."""
892
        self.pb_stage_name = name
893
        self.pb_stage_count += 1
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
894
        self.pb_entries_title = entries_title
895
        if entries_title is not None:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
896
            self.pb_entries_count = 0
897
            self.pb_entries_total = '?'
898
        self._emit_progress()
899
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
900
    def _next_progress_entry(self):
901
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
902
        self.pb_entries_count += 1
903
        self._emit_progress()
904
905
    def _emit_progress(self):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
906
        if self.pb_entries_title:
907
            if self.pb_entries_total == '?':
908
                text = "%s [%s %d] - Stage" % (self.pb_stage_name,
909
                    self.pb_entries_title, self.pb_entries_count)
910
            else:
911
                text = "%s [%s %d/%s] - Stage" % (self.pb_stage_name,
912
                    self.pb_entries_title, self.pb_entries_count,
913
                    str(self.pb_entries_total))
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
914
        else:
915
            text = "%s - Stage" % (self.pb_stage_name)
916
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
917