~bzr-pqm/bzr/bzr.dev

3224.5.8 by Andrew Bennetts
Fix failing tests.
1
# Copyright (C) 2006, 2007 Canonical Ltd
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
17
"""Basic server-side logic for dealing with requests.
18
19
**XXX**:
20
21
The class names are a little confusing: the protocol will instantiate a
22
SmartServerRequestHandler, whose dispatch_command method creates an instance of
23
a SmartServerRequest subclass.
24
25
The request_handlers registry tracks SmartServerRequest classes (rather than
26
SmartServerRequestHandler).
27
"""
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
28
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
29
import tempfile
30
2402.1.2 by Andrew Bennetts
Deal with review comments.
31
from bzrlib import (
32
    bzrdir,
33
    errors,
34
    registry,
35
    revision,
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
36
    urlutils,
2402.1.2 by Andrew Bennetts
Deal with review comments.
37
    )
3224.5.6 by Andrew Bennetts
Don't import bzrlib.bundle in bzrlib.smart.request until it's needed.
38
from bzrlib.lazy_import import lazy_import
39
lazy_import(globals(), """
40
from bzrlib.bundle import serializer
41
""")
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
42
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
43
44
class SmartServerRequest(object):
2692.1.10 by Andrew Bennetts
More docstring polish
45
    """Base class for request handlers.
46
    
47
    To define a new request, subclass this class and override the `do` method
48
    (and if appropriate, `do_body` as well).  Request implementors should take
49
    care to call `translate_client_path` and `transport_from_client_path` as
50
    appropriate when dealing with paths received from the client.
51
    """
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
52
    # XXX: rename this class to BaseSmartServerRequestHandler ?  A request
53
    # *handler* is a different concept to the request.
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
54
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
55
    def __init__(self, backing_transport, root_client_path='/'):
2402.1.2 by Andrew Bennetts
Deal with review comments.
56
        """Constructor.
57
58
        :param backing_transport: the base transport to be used when performing
59
            this request.
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
60
        :param root_client_path: the client path that maps to the root of
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
61
            backing_transport.  This is used to interpret relpaths received
62
            from the client.  Clients will not be able to refer to paths above
2692.1.16 by Andrew Bennetts
Improve comments.
63
            this root.  If root_client_path is None, then no translation will
64
            be performed on client paths.  Default is '/'.
2402.1.2 by Andrew Bennetts
Deal with review comments.
65
        """
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
66
        self._backing_transport = backing_transport
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
67
        if root_client_path is not None:
68
            if not root_client_path.startswith('/'):
69
                root_client_path = '/' + root_client_path
70
            if not root_client_path.endswith('/'):
71
                root_client_path += '/'
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
72
        self._root_client_path = root_client_path
2018.5.5 by Andrew Bennetts
Pass body_bytes directly to SmartServerRequest.do_body
73
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
74
    def _check_enabled(self):
75
        """Raises DisabledMethod if this method is disabled."""
76
        pass
77
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
78
    def do(self, *args):
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
79
        """Mandatory extension point for SmartServerRequest subclasses.
80
        
81
        Subclasses must implement this.
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
82
        
83
        This should return a SmartServerResponse if this command expects to
84
        receive no body.
85
        """
2018.5.5 by Andrew Bennetts
Pass body_bytes directly to SmartServerRequest.do_body
86
        raise NotImplementedError(self.do)
87
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
88
    def execute(self, *args):
89
        """Public entry point to execute this request.
90
91
        It will return a SmartServerResponse if the command does not expect a
92
        body.
93
94
        :param *args: the arguments of the request.
95
        """
96
        self._check_enabled()
97
        return self.do(*args)
98
2018.5.5 by Andrew Bennetts
Pass body_bytes directly to SmartServerRequest.do_body
99
    def do_body(self, body_bytes):
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
100
        """Called if the client sends a body with the request.
3184.1.10 by Robert Collins
Change the smart server verb for Repository.stream_revisions_chunked to use SearchResults as the request mechanism for downloads.
101
102
        The do() method is still called, and must have returned None.
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
103
        
104
        Must return a SmartServerResponse.
105
        """
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
106
        raise NotImplementedError(self.do_body)
107
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
108
    def do_chunk(self, chunk_bytes):
109
        """Called with each body chunk if the request has a streamed body.
110
111
        The do() method is still called, and must have returned None.
112
        """
113
        raise NotImplementedError(self.do_chunk)
114
115
    def do_end(self):
116
        """Called when the end of the request has been received."""
117
        pass
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
118
    
119
    def translate_client_path(self, client_path):
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
120
        """Translate a path received from a network client into a local
121
        relpath.
122
123
        All paths received from the client *must* be translated.
124
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
125
        :param client_path: the path from the client.
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
126
        :returns: a relpath that may be used with self._backing_transport
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
127
            (unlike the untranslated client_path, which must not be used with
128
            the backing transport).
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
129
        """
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
130
        if self._root_client_path is None:
131
            # no translation necessary!
132
            return client_path
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
133
        if not client_path.startswith('/'):
134
            client_path = '/' + client_path
135
        if client_path.startswith(self._root_client_path):
136
            path = client_path[len(self._root_client_path):]
137
            relpath = urlutils.joinpath('/', path)
3376.2.4 by Martin Pool
Remove every assert statement from bzrlib!
138
            if not relpath.startswith('/'):
139
                raise ValueError(relpath)
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
140
            return '.' + relpath
141
        else:
142
            raise errors.PathNotChild(client_path, self._root_client_path)
143
144
    def transport_from_client_path(self, client_path):
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
145
        """Get a backing transport corresponding to the location referred to by
146
        a network client.
147
148
        :seealso: translate_client_path
149
        :returns: a transport cloned from self._backing_transport
150
        """
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
151
        relpath = self.translate_client_path(client_path)
2692.1.16 by Andrew Bennetts
Improve comments.
152
        return self._backing_transport.clone(relpath)
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
153
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
154
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
155
class SmartServerResponse(object):
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
156
    """A response to a client request.
157
    
158
    This base class should not be used. Instead use
159
    SuccessfulSmartServerResponse and FailedSmartServerResponse as appropriate.
160
    """
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
161
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
162
    def __init__(self, args, body=None, body_stream=None):
163
        """Constructor.
164
165
        :param args: tuple of response arguments.
166
        :param body: string of a response body.
167
        :param body_stream: iterable of bytestrings to be streamed to the
168
            client.
169
        """
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
170
        self.args = args
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
171
        if body is not None and body_stream is not None:
172
            raise errors.BzrError(
173
                "'body' and 'body_stream' are mutually exclusive.")
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
174
        self.body = body
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
175
        self.body_stream = body_stream
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
176
2402.1.1 by Andrew Bennetts
Use the Command pattern for handling smart server commands.
177
    def __eq__(self, other):
178
        if other is None:
179
            return False
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
180
        return (other.args == self.args and
181
                other.body == self.body and
182
                other.body_stream is self.body_stream)
2402.1.1 by Andrew Bennetts
Use the Command pattern for handling smart server commands.
183
184
    def __repr__(self):
3691.2.6 by Martin Pool
Disable RemoteBranch stacking, but get get_stacked_on_url working, and passing back exceptions
185
        return "<%s args=%r body=%r>" % (self.__class__.__name__,
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
186
            self.args, self.body)
2402.1.1 by Andrew Bennetts
Use the Command pattern for handling smart server commands.
187
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
188
2432.4.2 by Robert Collins
Add FailedSmartServerResponse.
189
class FailedSmartServerResponse(SmartServerResponse):
190
    """A SmartServerResponse for a request which failed."""
191
192
    def is_successful(self):
193
        """FailedSmartServerResponse are not successful."""
194
        return False
195
196
2432.4.1 by Robert Collins
Add SuccessfulSmartServerResponse.
197
class SuccessfulSmartServerResponse(SmartServerResponse):
198
    """A SmartServerResponse for a successfully completed request."""
199
200
    def is_successful(self):
201
        """SuccessfulSmartServerResponse are successful."""
202
        return True
203
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
204
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
205
class SmartServerRequestHandler(object):
206
    """Protocol logic for smart server.
207
    
208
    This doesn't handle serialization at all, it just processes requests and
209
    creates responses.
210
    """
211
212
    # IMPORTANT FOR IMPLEMENTORS: It is important that SmartServerRequestHandler
213
    # not contain encoding or decoding logic to allow the wire protocol to vary
214
    # from the object protocol: we will want to tweak the wire protocol separate
215
    # from the object model, and ideally we will be able to do that without
216
    # having a SmartServerRequestHandler subclass for each wire protocol, rather
217
    # just a Protocol subclass.
218
219
    # TODO: Better way of representing the body for commands that take it,
220
    # and allow it to be streamed into the server.
221
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
222
    def __init__(self, backing_transport, commands, root_client_path):
2018.5.17 by Andrew Bennetts
Paramaterise the commands handled by SmartServerRequestHandler.
223
        """Constructor.
224
225
        :param backing_transport: a Transport to handle requests for.
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
226
        :param commands: a registry mapping command names to SmartServerRequest
2018.5.17 by Andrew Bennetts
Paramaterise the commands handled by SmartServerRequestHandler.
227
            subclasses. e.g. bzrlib.transport.smart.vfs.vfs_commands.
228
        """
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
229
        self._backing_transport = backing_transport
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
230
        self._root_client_path = root_client_path
2018.5.17 by Andrew Bennetts
Paramaterise the commands handled by SmartServerRequestHandler.
231
        self._commands = commands
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
232
        self._body_bytes = ''
233
        self.response = None
234
        self.finished_reading = False
235
        self._command = None
236
237
    def accept_body(self, bytes):
238
        """Accept body data."""
239
240
        # TODO: This should be overriden for each command that desired body data
241
        # to handle the right format of that data, i.e. plain bytes, a bundle,
242
        # etc.  The deserialisation into that format should be done in the
243
        # Protocol object.
244
245
        # default fallback is to accumulate bytes.
246
        self._body_bytes += bytes
247
        
248
    def end_of_body(self):
249
        """No more body data will be received."""
250
        self._run_handler_code(self._command.do_body, (self._body_bytes,), {})
251
        # cannot read after this.
252
        self.finished_reading = True
253
254
    def dispatch_command(self, cmd, args):
255
        """Deprecated compatibility method.""" # XXX XXX
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
256
        try:
257
            command = self._commands.get(cmd)
258
        except LookupError:
3245.4.29 by Andrew Bennetts
Add/tidy some comments, remove dud test_errors_are_logged test, add explicit UnknownSmartMethod to v3.
259
            raise errors.UnknownSmartMethod(cmd)
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
260
        self._command = command(self._backing_transport, self._root_client_path)
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
261
        self._run_handler_code(self._command.execute, args, {})
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
262
263
    def _run_handler_code(self, callable, args, kwargs):
264
        """Run some handler specific code 'callable'.
265
266
        If a result is returned, it is considered to be the commands response,
267
        and finished_reading is set true, and its assigned to self.response.
268
269
        Any exceptions caught are translated and a response object created
270
        from them.
271
        """
272
        result = self._call_converting_errors(callable, args, kwargs)
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
273
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
274
        if result is not None:
275
            self.response = result
276
            self.finished_reading = True
277
278
    def _call_converting_errors(self, callable, args, kwargs):
279
        """Call callable converting errors to Response objects."""
280
        # XXX: most of this error conversion is VFS-related, and thus ought to
281
        # be in SmartServerVFSRequestHandler somewhere.
282
        try:
283
            return callable(*args, **kwargs)
284
        except errors.NoSuchFile, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
285
            return FailedSmartServerResponse(('NoSuchFile', e.path))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
286
        except errors.FileExists, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
287
            return FailedSmartServerResponse(('FileExists', e.path))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
288
        except errors.DirectoryNotEmpty, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
289
            return FailedSmartServerResponse(('DirectoryNotEmpty', e.path))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
290
        except errors.ShortReadvError, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
291
            return FailedSmartServerResponse(('ShortReadvError',
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
292
                e.path, str(e.offset), str(e.length), str(e.actual)))
3691.2.6 by Martin Pool
Disable RemoteBranch stacking, but get get_stacked_on_url working, and passing back exceptions
293
        except errors.UnstackableRepositoryFormat, e:
294
            return FailedSmartServerResponse(('UnstackableRepositoryFormat',
295
                str(e.format), e.url))
296
        except errors.UnstackableBranchFormat, e:
297
            return FailedSmartServerResponse(('UnstackableBranchFormat',
298
                str(e.format), e.url))
299
        except errors.NotStacked, e:
300
            return FailedSmartServerResponse(('NotStacked',))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
301
        except UnicodeError, e:
302
            # If it is a DecodeError, than most likely we are starting
303
            # with a plain string
304
            str_or_unicode = e.object
305
            if isinstance(str_or_unicode, unicode):
306
                # XXX: UTF-8 might have \x01 (our seperator byte) in it.  We
307
                # should escape it somehow.
308
                val = 'u:' + str_or_unicode.encode('utf-8')
309
            else:
310
                val = 's:' + str_or_unicode.encode('base64')
311
            # This handles UnicodeEncodeError or UnicodeDecodeError
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
312
            return FailedSmartServerResponse((e.__class__.__name__,
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
313
                    e.encoding, val, str(e.start), str(e.end), e.reason))
314
        except errors.TransportNotPossible, e:
315
            if e.msg == "readonly transport":
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
316
                return FailedSmartServerResponse(('ReadOnlyError', ))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
317
            else:
318
                raise
319
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
320
    def headers_received(self, headers):
3245.4.33 by Andrew Bennetts
Remove unused no_body_received method on SmartServerRequestHandler.
321
        # Just a no-op at the moment.
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
322
        pass
323
324
    def args_received(self, args):
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
325
        cmd = args[0]
326
        args = args[1:]
327
        try:
328
            command = self._commands.get(cmd)
329
        except LookupError:
3245.4.48 by Andrew Bennetts
raise UnknownSmartMethod from dispatch_command.
330
            raise errors.UnknownSmartMethod(cmd)
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
331
        self._command = command(self._backing_transport)
332
        self._run_handler_code(self._command.execute, args, {})
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
333
334
    def prefixed_body_received(self, body_bytes):
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
335
        """No more body data will be received."""
336
        self._run_handler_code(self._command.do_body, (body_bytes,), {})
337
        # cannot read after this.
338
        self.finished_reading = True
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
339
340
    def body_chunk_received(self, chunk_bytes):
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
341
        self._run_handler_code(self._command.do_chunk, (chunk_bytes,), {})
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
342
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
343
    def end_received(self):
344
        self._run_handler_code(self._command.do_end, (), {})
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
345
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
346
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
347
class HelloRequest(SmartServerRequest):
2432.2.6 by Andrew Bennetts
Improve HelloRequest's docstring.
348
    """Answer a version request with the highest protocol version this server
349
    supports.
350
    """
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
351
352
    def do(self):
3245.4.59 by Andrew Bennetts
Various tweaks in response to Martin's review.
353
        return SuccessfulSmartServerResponse(('ok', '2'))
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
354
355
356
class GetBundleRequest(SmartServerRequest):
2402.1.2 by Andrew Bennetts
Deal with review comments.
357
    """Get a bundle of from the null revision to the specified revision."""
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
358
359
    def do(self, path, revision_id):
360
        # open transport relative to our base
2692.1.7 by Andrew Bennetts
Translate path in GetBundleRequest too.
361
        t = self.transport_from_client_path(path)
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
362
        control, extra_path = bzrdir.BzrDir.open_containing_from_transport(t)
363
        repo = control.open_repository()
364
        tmpf = tempfile.TemporaryFile()
365
        base_revision = revision.NULL_REVISION
3224.5.6 by Andrew Bennetts
Don't import bzrlib.bundle in bzrlib.smart.request until it's needed.
366
        serializer.write_bundle(repo, revision_id, base_revision, tmpf)
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
367
        tmpf.seek(0)
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
368
        return SuccessfulSmartServerResponse((), tmpf.read())
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
369
370
2018.5.95 by Andrew Bennetts
Add a Transport.is_readonly remote call, let {Branch,Repository}.lock_write remote call return UnlockableTransport, and miscellaneous test fixes.
371
class SmartServerIsReadonly(SmartServerRequest):
372
    # XXX: this request method belongs somewhere else.
373
374
    def do(self):
375
        if self._backing_transport.is_readonly():
376
            answer = 'yes'
377
        else:
378
            answer = 'no'
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
379
        return SuccessfulSmartServerResponse((answer,))
2018.5.95 by Andrew Bennetts
Add a Transport.is_readonly remote call, let {Branch,Repository}.lock_write remote call return UnlockableTransport, and miscellaneous test fixes.
380
381
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
382
request_handlers = registry.Registry()
383
request_handlers.register_lazy(
384
    'append', 'bzrlib.smart.vfs', 'AppendRequest')
385
request_handlers.register_lazy(
2018.5.59 by Robert Collins
Get BranchConfig working somewhat on RemoteBranches (Robert Collins, Vincent Ladeuil).
386
    'Branch.get_config_file', 'bzrlib.smart.branch', 'SmartServerBranchGetConfigFile')
387
request_handlers.register_lazy(
3691.2.5 by Martin Pool
Add Branch.get_stacked_on_url rpc and tests for same
388
    'Branch.get_stacked_on_url', 'bzrlib.smart.branch', 'SmartServerBranchRequestGetStackedOnURL')
389
request_handlers.register_lazy(
2018.5.51 by Wouter van Heyst
Test and implement RemoteBranch.last_revision_info()
390
    'Branch.last_revision_info', 'bzrlib.smart.branch', 'SmartServerBranchRequestLastRevisionInfo')
391
request_handlers.register_lazy(
2018.5.79 by Andrew Bennetts
Implement RemoteBranch.lock_write/unlock as smart operations.
392
    'Branch.lock_write', 'bzrlib.smart.branch', 'SmartServerBranchRequestLockWrite')
393
request_handlers.register_lazy(
2018.5.38 by Robert Collins
Implement RemoteBranch.revision_history().
394
    'Branch.revision_history', 'bzrlib.smart.branch', 'SmartServerRequestRevisionHistory')
395
request_handlers.register_lazy(
2018.5.77 by Wouter van Heyst
Fix typo in request_handlers registration of Branch.set_last_revision, and test that registration
396
    'Branch.set_last_revision', 'bzrlib.smart.branch', 'SmartServerBranchRequestSetLastRevision')
2018.12.3 by Andrew Bennetts
Add a Branch.set_last_revision smart method, and make RemoteBranch.set_revision_history use it.
397
request_handlers.register_lazy(
2892.2.1 by Andrew Bennetts
Add Branch.set_last_revision_info smart method, and make the RemoteBranch client use it.
398
    'Branch.set_last_revision_info', 'bzrlib.smart.branch',
399
    'SmartServerBranchRequestSetLastRevisionInfo')
400
request_handlers.register_lazy(
3441.5.25 by Andrew Bennetts
Rename Branch.set_last_revision_descendant verb to Branch.set_last_revision_ex. It's a cop out, but at least it's not misleading.
401
    'Branch.set_last_revision_ex', 'bzrlib.smart.branch',
402
    'SmartServerBranchRequestSetLastRevisionEx')
3441.5.6 by Andrew Bennetts
Greatly simplify RemoteBranch.update_revisions. Still needs more tests.
403
request_handlers.register_lazy(
2018.5.79 by Andrew Bennetts
Implement RemoteBranch.lock_write/unlock as smart operations.
404
    'Branch.unlock', 'bzrlib.smart.branch', 'SmartServerBranchRequestUnlock')
405
request_handlers.register_lazy(
3221.3.2 by Robert Collins
* New remote method ``RemoteBzrDir.find_repositoryV2`` adding support for
406
    'BzrDir.find_repository', 'bzrlib.smart.bzrdir', 'SmartServerRequestFindRepositoryV1')
407
request_handlers.register_lazy(
408
    'BzrDir.find_repositoryV2', 'bzrlib.smart.bzrdir', 'SmartServerRequestFindRepositoryV2')
2018.5.34 by Robert Collins
Get test_remote.BasicRemoteObjectTests.test_open_remote_branch passing by implementing a remote method BzrDir.find_repository.
409
request_handlers.register_lazy(
2018.5.42 by Robert Collins
Various hopefully improvements, but wsgi is broken, handing over to spiv :).
410
    'BzrDirFormat.initialize', 'bzrlib.smart.bzrdir', 'SmartServerRequestInitializeBzrDir')
411
request_handlers.register_lazy(
2018.6.1 by Robert Collins
Implement a BzrDir.open_branch smart server method for opening a branch without VFS.
412
    'BzrDir.open_branch', 'bzrlib.smart.bzrdir', 'SmartServerRequestOpenBranch')
413
request_handlers.register_lazy(
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
414
    'delete', 'bzrlib.smart.vfs', 'DeleteRequest')
415
request_handlers.register_lazy(
416
    'get', 'bzrlib.smart.vfs', 'GetRequest')
417
request_handlers.register_lazy(
418
    'get_bundle', 'bzrlib.smart.request', 'GetBundleRequest')
419
request_handlers.register_lazy(
420
    'has', 'bzrlib.smart.vfs', 'HasRequest')
421
request_handlers.register_lazy(
422
    'hello', 'bzrlib.smart.request', 'HelloRequest')
423
request_handlers.register_lazy(
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
424
    'iter_files_recursive', 'bzrlib.smart.vfs', 'IterFilesRecursiveRequest')
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
425
request_handlers.register_lazy(
426
    'list_dir', 'bzrlib.smart.vfs', 'ListDirRequest')
427
request_handlers.register_lazy(
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
428
    'mkdir', 'bzrlib.smart.vfs', 'MkdirRequest')
429
request_handlers.register_lazy(
430
    'move', 'bzrlib.smart.vfs', 'MoveRequest')
431
request_handlers.register_lazy(
432
    'put', 'bzrlib.smart.vfs', 'PutRequest')
433
request_handlers.register_lazy(
434
    'put_non_atomic', 'bzrlib.smart.vfs', 'PutNonAtomicRequest')
435
request_handlers.register_lazy(
436
    'readv', 'bzrlib.smart.vfs', 'ReadvRequest')
437
request_handlers.register_lazy(
438
    'rename', 'bzrlib.smart.vfs', 'RenameRequest')
2018.10.2 by v.ladeuil+lp at free
gather_stats server side and request registration
439
request_handlers.register_lazy('Repository.gather_stats',
440
                               'bzrlib.smart.repository',
441
                               'SmartServerRepositoryGatherStats')
3172.5.6 by Robert Collins
Create new smart server verb Repository.get_parent_map.
442
request_handlers.register_lazy('Repository.get_parent_map',
443
                               'bzrlib.smart.repository',
444
                               'SmartServerRepositoryGetParentMap')
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
445
request_handlers.register_lazy(
2018.5.67 by Wouter van Heyst
Implement RemoteRepository.get_revision_graph (Wouter van Heyst, Robert Collins)
446
    'Repository.get_revision_graph', 'bzrlib.smart.repository', 'SmartServerRepositoryGetRevisionGraph')
447
request_handlers.register_lazy(
2018.5.40 by Robert Collins
Implement a remote Repository.has_revision method.
448
    'Repository.has_revision', 'bzrlib.smart.repository', 'SmartServerRequestHasRevision')
449
request_handlers.register_lazy(
2018.5.57 by Robert Collins
Implement RemoteRepository.is_shared (Robert Collins, Vincent Ladeuil).
450
    'Repository.is_shared', 'bzrlib.smart.repository', 'SmartServerRepositoryIsShared')
451
request_handlers.register_lazy(
2018.5.78 by Andrew Bennetts
Implement RemoteRepository.lock_write/unlock to expect and send tokens over the
452
    'Repository.lock_write', 'bzrlib.smart.repository', 'SmartServerRepositoryLockWrite')
453
request_handlers.register_lazy(
454
    'Repository.unlock', 'bzrlib.smart.repository', 'SmartServerRepositoryUnlock')
455
request_handlers.register_lazy(
2018.18.1 by Martin Pool
Add stub Repository.tarball smart method
456
    'Repository.tarball', 'bzrlib.smart.repository',
457
    'SmartServerRepositoryTarball')
458
request_handlers.register_lazy(
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
459
    'rmdir', 'bzrlib.smart.vfs', 'RmdirRequest')
460
request_handlers.register_lazy(
461
    'stat', 'bzrlib.smart.vfs', 'StatRequest')
2018.5.26 by Andrew Bennetts
Extract a simple SmartClient class from RemoteTransport, and a hack to avoid VFS operations when probing for a bzrdir over a smart transport.
462
request_handlers.register_lazy(
2018.5.95 by Andrew Bennetts
Add a Transport.is_readonly remote call, let {Branch,Repository}.lock_write remote call return UnlockableTransport, and miscellaneous test fixes.
463
    'Transport.is_readonly', 'bzrlib.smart.request', 'SmartServerIsReadonly')
464
request_handlers.register_lazy(
2018.5.163 by Andrew Bennetts
Deal with various review comments from Robert.
465
    'BzrDir.open', 'bzrlib.smart.bzrdir', 'SmartServerRequestOpenBzrDir')