~bzr-pqm/bzr/bzr.dev

3221.1.3 by Martin Pool
Review cleanups for CorruptDirstate: use the path everywhere rather than the object, and use more standard phrasing.
1
# Copyright (C) 2006, 2007, 2008 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
2018.18.22 by Martin Pool
merge bzr.dev
3
#            and others
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
4
#
5
# This program is free software; you can redistribute it and/or modify
6
# it under the terms of the GNU General Public License as published by
7
# the Free Software Foundation; either version 2 of the License, or
8
# (at your option) any later version.
9
#
10
# This program is distributed in the hope that it will be useful,
11
# but WITHOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
13
# GNU General Public License for more details.
14
#
15
# You should have received a copy of the GNU General Public License
16
# along with this program; if not, write to the Free Software
17
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18
19
"""Tests for the formatting and construction of errors."""
20
3577.1.1 by Andrew Bennetts
Cherry-pick TipChangeRejected changes from pre-branch-tip-changed-hook loom.
21
import sys
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
22
from bzrlib import (
23
    bzrdir,
24
    errors,
3234.2.6 by Alexander Belchenko
because every mail client has different rules to compose command line we should encode arguments to 8 bit string only when needed.
25
    osutils,
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
26
    symbol_versioning,
3200.2.1 by Robert Collins
* The ``register-branch`` command will now use the public url of the branch
27
    urlutils,
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
28
    )
29
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
30
31
32
class TestErrors(TestCaseWithTransport):
33
3287.20.2 by John Arbash Meinel
Raise a clear error about the offending filename when there is a filename with bad characters.
34
    def test_bad_filename_encoding(self):
35
        error = errors.BadFilenameEncoding('bad/filen\xe5me', 'UTF-8')
36
        self.assertEqualDiff(
37
            "Filename 'bad/filen\\xe5me' is not valid in your current"
38
            " filesystem encoding UTF-8",
39
            str(error))
40
3207.2.1 by jameinel
Add a test that _iter_changes raises a clearer error when we encounter an invalid rename.
41
    def test_corrupt_dirstate(self):
42
        error = errors.CorruptDirstate('path/to/dirstate', 'the reason why')
3221.1.3 by Martin Pool
Review cleanups for CorruptDirstate: use the path everywhere rather than the object, and use more standard phrasing.
43
        self.assertEqualDiff(
44
            "Inconsistency in dirstate file path/to/dirstate.\n"
45
            "Error: the reason why",
46
            str(error))
3207.2.1 by jameinel
Add a test that _iter_changes raises a clearer error when we encounter an invalid rename.
47
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
48
    def test_disabled_method(self):
49
        error = errors.DisabledMethod("class name")
50
        self.assertEqualDiff(
51
            "The smart server method 'class name' is disabled.", str(error))
52
2255.7.16 by John Arbash Meinel
Make sure adding a duplicate file_id raises DuplicateFileId.
53
    def test_duplicate_file_id(self):
54
        error = errors.DuplicateFileId('a_file_id', 'foo')
55
        self.assertEqualDiff('File id {a_file_id} already exists in inventory'
56
                             ' as foo', str(error))
57
2432.1.19 by Robert Collins
Ensure each HelpIndex has a unique prefix.
58
    def test_duplicate_help_prefix(self):
59
        error = errors.DuplicateHelpPrefix('foo')
60
        self.assertEqualDiff('The prefix foo is in the help search path twice.',
61
            str(error))
62
3445.1.1 by John Arbash Meinel
Start working on a new Graph api to make finding revision numbers faster.
63
    def test_ghost_revisions_have_no_revno(self):
64
        error = errors.GhostRevisionsHaveNoRevno('target', 'ghost_rev')
65
        self.assertEqualDiff("Could not determine revno for {target} because"
66
                             " its ancestry shows a ghost at {ghost_rev}",
67
                             str(error))
68
2550.2.3 by Robert Collins
Add require_api API.
69
    def test_incompatibleAPI(self):
70
        error = errors.IncompatibleAPI("module", (1, 2, 3), (4, 5, 6), (7, 8, 9))
71
        self.assertEqualDiff(
72
            'The API for "module" is not compatible with "(1, 2, 3)". '
73
            'It supports versions "(4, 5, 6)" to "(7, 8, 9)".',
74
            str(error))
75
3207.2.2 by John Arbash Meinel
Fix bug #187169, when an invalid delta is supplied to update_basis_by_delta
76
    def test_inconsistent_delta(self):
77
        error = errors.InconsistentDelta('path', 'file-id', 'reason for foo')
78
        self.assertEqualDiff(
3221.1.8 by Martin Pool
Update error format in test_inconsistent_delta
79
            "An inconsistent delta was supplied involving 'path', 'file-id'\n"
3207.2.2 by John Arbash Meinel
Fix bug #187169, when an invalid delta is supplied to update_basis_by_delta
80
            "reason: reason for foo",
81
            str(error))
82
2634.1.1 by Robert Collins
(robertc) Reinstate the accidentally backed out external_url patch.
83
    def test_in_process_transport(self):
84
        error = errors.InProcessTransport('fpp')
85
        self.assertEqualDiff(
86
            "The transport 'fpp' is only accessible within this process.",
87
            str(error))
88
3059.2.12 by Vincent Ladeuil
Spiv review feedback.
89
    def test_invalid_http_range(self):
90
        error = errors.InvalidHttpRange('path',
91
                                        'Content-Range: potatoes 0-00/o0oo0',
92
                                        'bad range')
93
        self.assertEquals("Invalid http range"
94
                          " 'Content-Range: potatoes 0-00/o0oo0'"
95
                          " for path: bad range",
96
                          str(error))
97
98
    def test_invalid_range(self):
99
        error = errors.InvalidRange('path', 12, 'bad range')
100
        self.assertEquals("Invalid range access in path at 12: bad range",
101
                          str(error))
102
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
103
    def test_inventory_modified(self):
104
        error = errors.InventoryModified("a tree to be repred")
105
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
106
            "be repred' has been modified, so a clean inventory cannot be "
107
            "read without data loss.",
108
            str(error))
109
2116.3.1 by John Arbash Meinel
Cleanup error tests
110
    def test_install_failed(self):
111
        error = errors.InstallFailed(['rev-one'])
112
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
113
        error = errors.InstallFailed(['rev-one', 'rev-two'])
114
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
115
                         str(error))
116
        error = errors.InstallFailed([None])
117
        self.assertEqual("Could not install revisions:\nNone", str(error))
118
2255.2.145 by Robert Collins
Support unbreakable locks for trees.
119
    def test_lock_active(self):
120
        error = errors.LockActive("lock description")
121
        self.assertEqualDiff("The lock for 'lock description' is in use and "
122
            "cannot be broken.",
123
            str(error))
124
2535.3.4 by Andrew Bennetts
Simple implementation of Knit.insert_data_stream.
125
    def test_knit_data_stream_incompatible(self):
126
        error = errors.KnitDataStreamIncompatible(
127
            'stream format', 'target format')
128
        self.assertEqual('Cannot insert knit data stream of format '
129
                         '"stream format" into knit of format '
130
                         '"target format".', str(error))
131
3052.2.1 by Robert Collins
Add a new KnitDataStreamUnknown error class for showing formats we can't understand.
132
    def test_knit_data_stream_unknown(self):
133
        error = errors.KnitDataStreamUnknown(
134
            'stream format')
135
        self.assertEqual('Cannot parse knit data stream of format '
136
                         '"stream format".', str(error))
137
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
138
    def test_knit_header_error(self):
139
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
140
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
2745.3.2 by Daniel Watkins
Updated tests to reflect new error text.
141
                         " for file \"path/to/file\".", str(error))
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
142
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
143
    def test_knit_index_unknown_method(self):
144
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
145
                                              ['bad', 'no-eol'])
146
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
147
                         " known method in options: ['bad', 'no-eol']",
148
                         str(error))
149
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
150
    def test_medium_not_connected(self):
151
        error = errors.MediumNotConnected("a medium")
152
        self.assertEqualDiff(
153
            "The medium 'a medium' is not connected.", str(error))
3200.2.1 by Robert Collins
* The ``register-branch`` command will now use the public url of the branch
154
 
155
    def test_no_public_branch(self):
156
        b = self.make_branch('.')
157
        error = errors.NoPublicBranch(b)
158
        url = urlutils.unescape_for_display(b.base, 'ascii')
159
        self.assertEqualDiff(
160
            'There is no public branch set for "%s".' % url, str(error))
161
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
162
    def test_no_repo(self):
163
        dir = bzrdir.BzrDir.create(self.get_url())
164
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
165
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
166
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
167
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
168
    def test_no_smart_medium(self):
169
        error = errors.NoSmartMedium("a transport")
170
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
171
            "smart protocol.",
172
            str(error))
173
2432.1.4 by Robert Collins
Add an explicit error for missing help topics.
174
    def test_no_help_topic(self):
175
        error = errors.NoHelpTopic("topic")
176
        self.assertEqualDiff("No help could be found for 'topic'. "
177
            "Please use 'bzr help topics' to obtain a list of topics.",
178
            str(error))
179
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
180
    def test_no_such_id(self):
181
        error = errors.NoSuchId("atree", "anid")
2745.3.2 by Daniel Watkins
Updated tests to reflect new error text.
182
        self.assertEqualDiff("The file id \"anid\" is not present in the tree "
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
183
            "atree.",
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
184
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
185
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
186
    def test_no_such_revision_in_tree(self):
187
        error = errors.NoSuchRevisionInTree("atree", "anid")
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
188
        self.assertEqualDiff("The revision id {anid} is not present in the"
189
                             " tree atree.", str(error))
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
190
        self.assertIsInstance(error, errors.NoSuchRevision)
191
3221.11.2 by Robert Collins
Create basic stackable branch facility.
192
    def test_not_stacked(self):
193
        error = errors.NotStacked('a branch')
194
        self.assertEqualDiff("The branch 'a branch' is not stacked.",
195
            str(error))
196
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
197
    def test_not_write_locked(self):
198
        error = errors.NotWriteLocked('a thing to repr')
199
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
200
            "to be.",
201
            str(error))
202
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
203
    def test_lock_failed(self):
204
        error = errors.LockFailed('http://canonical.com/', 'readonly transport')
205
        self.assertEqualDiff("Cannot lock http://canonical.com/: readonly transport",
206
            str(error))
207
        self.assertFalse(error.internal_error)
208
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
209
    def test_too_many_concurrent_requests(self):
210
        error = errors.TooManyConcurrentRequests("a medium")
211
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
212
            "request limit. Be sure to finish_writing and finish_reading on "
2018.5.134 by Andrew Bennetts
Fix the TooManyConcurrentRequests error message.
213
            "the currently open request.",
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
214
            str(error))
215
3350.3.3 by Robert Collins
Functional get_record_stream interface tests covering full interface.
216
    def test_unavailable_representation(self):
217
        error = errors.UnavailableRepresentation(('key',), "mpdiff", "fulltext")
218
        self.assertEqualDiff("The encoding 'mpdiff' is not available for key "
219
            "('key',) which is encoded as 'fulltext'.",
220
            str(error))
221
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
222
    def test_unknown_hook(self):
223
        error = errors.UnknownHook("branch", "foo")
224
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
225
            " of bzrlib.",
226
            str(error))
227
        error = errors.UnknownHook("tree", "bar")
228
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
229
            " of bzrlib.",
230
            str(error))
231
3221.11.2 by Robert Collins
Create basic stackable branch facility.
232
    def test_unstackable_branch_format(self):
233
        format = u'foo'
234
        url = "/foo"
235
        error = errors.UnstackableBranchFormat(format, url)
236
        self.assertEqualDiff(
237
            "The branch '/foo'(foo) is not a stackable format. "
238
            "You will need to upgrade the branch to permit branch stacking.",
239
            str(error))
240
241
    def test_unstackable_repository_format(self):
242
        format = u'foo'
243
        url = "/foo"
244
        error = errors.UnstackableRepositoryFormat(format, url)
245
        self.assertEqualDiff(
246
            "The repository '/foo'(foo) is not a stackable format. "
247
            "You will need to upgrade the repository to permit branch stacking.",
248
            str(error))
249
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
250
    def test_up_to_date(self):
251
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
252
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
253
                             "format 0.0.4 is already at the most "
254
                             "recent format.",
255
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
256
257
    def test_corrupt_repository(self):
258
        repo = self.make_repository('.')
259
        error = errors.CorruptRepository(repo)
260
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
261
                             "Please run bzr reconcile on this repository." %
262
                             repo.bzrdir.root_transport.base,
263
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
264
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
265
    def test_read_error(self):
266
        # a unicode path to check that %r is being used.
267
        path = u'a path'
268
        error = errors.ReadError(path)
269
        self.assertEqualDiff("Error reading from u'a path'.", str(error))
270
2592.1.7 by Robert Collins
A validate that goes boom.
271
    def test_bad_index_format_signature(self):
272
        error = errors.BadIndexFormatSignature("foo", "bar")
273
        self.assertEqual("foo is not an index of type bar.",
274
            str(error))
2052.6.2 by Robert Collins
Merge bzr.dev.
275
2592.1.11 by Robert Collins
Detect truncated indices.
276
    def test_bad_index_data(self):
277
        error = errors.BadIndexData("foo")
278
        self.assertEqual("Error in data for index foo.",
279
            str(error))
280
2592.1.15 by Robert Collins
Detect duplicate key insertion.
281
    def test_bad_index_duplicate_key(self):
282
        error = errors.BadIndexDuplicateKey("foo", "bar")
283
        self.assertEqual("The key 'foo' is already in index 'bar'.",
284
            str(error))
285
2592.1.12 by Robert Collins
Handle basic node adds.
286
    def test_bad_index_key(self):
287
        error = errors.BadIndexKey("foo")
288
        self.assertEqual("The key 'foo' is not a valid key.",
289
            str(error))
290
2592.1.10 by Robert Collins
Make validate detect node reference parsing errors.
291
    def test_bad_index_options(self):
292
        error = errors.BadIndexOptions("foo")
293
        self.assertEqual("Could not parse options for index foo.",
294
            str(error))
295
2592.1.12 by Robert Collins
Handle basic node adds.
296
    def test_bad_index_value(self):
297
        error = errors.BadIndexValue("foo")
298
        self.assertEqual("The value 'foo' is not a valid value.",
299
            str(error))
300
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
301
    def test_bzrnewerror_is_deprecated(self):
302
        class DeprecatedError(errors.BzrNewError):
303
            pass
2067.3.6 by Martin Pool
Update deprecation version
304
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
305
             'please convert DeprecatedError to use BzrError instead'],
306
            DeprecatedError)
307
308
    def test_bzrerror_from_literal_string(self):
309
        # Some code constructs BzrError from a literal string, in which case
310
        # no further formatting is done.  (I'm not sure raising the base class
311
        # is a great idea, but if the exception is not intended to be caught
312
        # perhaps no more is needed.)
313
        try:
314
            raise errors.BzrError('this is my errors; %d is not expanded')
315
        except errors.BzrError, e:
316
            self.assertEqual('this is my errors; %d is not expanded', str(e))
317
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
318
    def test_reading_completed(self):
319
        error = errors.ReadingCompleted("a request")
320
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
321
            "finish_reading called upon it - the request has been completed and"
322
            " no more data may be read.",
323
            str(error))
324
325
    def test_writing_completed(self):
326
        error = errors.WritingCompleted("a request")
327
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
328
            "finish_writing called upon it - accept bytes may not be called "
329
            "anymore.",
330
            str(error))
331
332
    def test_writing_not_completed(self):
333
        error = errors.WritingNotComplete("a request")
334
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
335
            "finish_writing called upon it - until the write phase is complete"
336
            " no data may be read.",
337
            str(error))
338
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
339
    def test_transport_not_possible(self):
340
        error = errors.TransportNotPossible('readonly', 'original error')
341
        self.assertEqualDiff('Transport operation not possible:'
342
                         ' readonly original error', str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
343
344
    def assertSocketConnectionError(self, expected, *args, **kwargs):
345
        """Check the formatting of a SocketConnectionError exception"""
346
        e = errors.SocketConnectionError(*args, **kwargs)
347
        self.assertEqual(expected, str(e))
348
349
    def test_socket_connection_error(self):
350
        """Test the formatting of SocketConnectionError"""
351
352
        # There should be a default msg about failing to connect
353
        # we only require a host name.
354
        self.assertSocketConnectionError(
355
            'Failed to connect to ahost',
356
            'ahost')
357
358
        # If port is None, we don't put :None
359
        self.assertSocketConnectionError(
360
            'Failed to connect to ahost',
361
            'ahost', port=None)
362
        # But if port is supplied we include it
363
        self.assertSocketConnectionError(
364
            'Failed to connect to ahost:22',
365
            'ahost', port=22)
366
367
        # We can also supply extra information about the error
368
        # with or without a port
369
        self.assertSocketConnectionError(
370
            'Failed to connect to ahost:22; bogus error',
371
            'ahost', port=22, orig_error='bogus error')
372
        self.assertSocketConnectionError(
373
            'Failed to connect to ahost; bogus error',
374
            'ahost', orig_error='bogus error')
375
        # An exception object can be passed rather than a string
376
        orig_error = ValueError('bad value')
377
        self.assertSocketConnectionError(
378
            'Failed to connect to ahost; %s' % (str(orig_error),),
379
            host='ahost', orig_error=orig_error)
380
381
        # And we can supply a custom failure message
382
        self.assertSocketConnectionError(
383
            'Unable to connect to ssh host ahost:444; my_error',
384
            host='ahost', port=444, msg='Unable to connect to ssh host',
385
            orig_error='my_error')
386
3535.8.2 by James Westby
Incorporate spiv's feedback.
387
    def test_target_not_branch(self):
388
        """Test the formatting of TargetNotBranch."""
389
        error = errors.TargetNotBranch('foo')
390
        self.assertEqual(
391
            "Your branch does not have all of the revisions required in "
3535.8.4 by James Westby
Replace "however" with "and" at John's request.
392
            "order to merge this merge directive and the target "
3535.8.3 by James Westby
Use location instead of branch as suggested by Robert.
393
            "location specified in the merge directive is not a branch: "
3535.8.2 by James Westby
Incorporate spiv's feedback.
394
            "foo.", str(error))
395
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
396
    def test_malformed_bug_identifier(self):
397
        """Test the formatting of MalformedBugIdentifier."""
398
        error = errors.MalformedBugIdentifier('bogus', 'reason for bogosity')
399
        self.assertEqual(
400
            "Did not understand bug identifier bogus: reason for bogosity",
401
            str(error))
402
403
    def test_unknown_bug_tracker_abbreviation(self):
404
        """Test the formatting of UnknownBugTrackerAbbreviation."""
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
405
        branch = self.make_branch('some_branch')
406
        error = errors.UnknownBugTrackerAbbreviation('xxx', branch)
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
407
        self.assertEqual(
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
408
            "Cannot find registered bug tracker called xxx on %s" % branch,
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
409
            str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
410
2018.5.163 by Andrew Bennetts
Deal with various review comments from Robert.
411
    def test_unexpected_smart_server_response(self):
412
        e = errors.UnexpectedSmartServerResponse(('not yes',))
413
        self.assertEqual(
414
            "Could not understand response from smart server: ('not yes',)",
415
            str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
416
2506.2.1 by Andrew Bennetts
Start implementing container format reading and writing.
417
    def test_unknown_container_format(self):
418
        """Test the formatting of UnknownContainerFormatError."""
419
        e = errors.UnknownContainerFormatError('bad format string')
420
        self.assertEqual(
421
            "Unrecognised container format: 'bad format string'",
422
            str(e))
423
424
    def test_unexpected_end_of_container(self):
425
        """Test the formatting of UnexpectedEndOfContainerError."""
426
        e = errors.UnexpectedEndOfContainerError()
427
        self.assertEqual(
428
            "Unexpected end of container stream", str(e))
429
430
    def test_unknown_record_type(self):
431
        """Test the formatting of UnknownRecordTypeError."""
432
        e = errors.UnknownRecordTypeError("X")
433
        self.assertEqual(
434
            "Unknown record type: 'X'",
435
            str(e))
436
2506.3.1 by Andrew Bennetts
More progress:
437
    def test_invalid_record(self):
438
        """Test the formatting of InvalidRecordError."""
439
        e = errors.InvalidRecordError("xxx")
440
        self.assertEqual(
441
            "Invalid record: xxx",
442
            str(e))
443
2506.2.6 by Andrew Bennetts
Add validate method to ContainerReader and BytesRecordReader.
444
    def test_container_has_excess_data(self):
445
        """Test the formatting of ContainerHasExcessDataError."""
446
        e = errors.ContainerHasExcessDataError("excess bytes")
447
        self.assertEqual(
448
            "Container has data after end marker: 'excess bytes'",
449
            str(e))
450
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
451
    def test_duplicate_record_name_error(self):
452
        """Test the formatting of DuplicateRecordNameError."""
453
        e = errors.DuplicateRecordNameError(u"n\xe5me".encode('utf-8'))
454
        self.assertEqual(
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
455
            "Container has multiple records with the same name: n\xc3\xa5me",
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
456
            str(e))
2854.1.1 by Martin Pool
Fix "unprintable error" message for BzrCheckError and others
457
        
458
    def test_check_error(self):
459
        # This has a member called 'message', which is problematic in
460
        # python2.5 because that is a slot on the base Exception class
461
        e = errors.BzrCheckError('example check failure')
462
        self.assertEqual(
463
            "Internal check failed: example check failure",
464
            str(e))
465
        self.assertTrue(e.internal_error)
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
466
2535.3.40 by Andrew Bennetts
Tidy up more XXXs.
467
    def test_repository_data_stream_error(self):
468
        """Test the formatting of RepositoryDataStreamError."""
469
        e = errors.RepositoryDataStreamError(u"my reason")
470
        self.assertEqual(
471
            "Corrupt or incompatible data stream: my reason", str(e))
472
2978.2.1 by Alexander Belchenko
fix formatting of ImmortalPendingDeletion error message.
473
    def test_immortal_pending_deletion_message(self):
474
        err = errors.ImmortalPendingDeletion('foo')
475
        self.assertEquals(
476
            "Unable to delete transform temporary directory foo.  "
477
            "Please examine foo to see if it contains any files "
478
            "you wish to keep, and delete it when you are done.",
479
            str(err))
480
3006.2.2 by Alexander Belchenko
tests added.
481
    def test_unable_create_symlink(self):
482
        err = errors.UnableCreateSymlink()
483
        self.assertEquals(
484
            "Unable to create symlink on this platform",
485
            str(err))
486
        err = errors.UnableCreateSymlink(path=u'foo')
487
        self.assertEquals(
488
            "Unable to create symlink 'foo' on this platform",
489
            str(err))
490
        err = errors.UnableCreateSymlink(path=u'\xb5')
491
        self.assertEquals(
492
            "Unable to create symlink u'\\xb5' on this platform",
493
            str(err))
494
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
495
    def test_invalid_url_join(self):
496
        """Test the formatting of InvalidURLJoin."""
497
        e = errors.InvalidURLJoin('Reason', 'base path', ('args',))
498
        self.assertEqual(
499
            "Invalid URL join request: Reason: 'base path' + ('args',)",
500
            str(e))
501
3035.3.2 by Lukáš Lalinský
Add tests for InvalidBugTrackerURL.
502
    def test_incorrect_url(self):
503
        err = errors.InvalidBugTrackerURL('foo', 'http://bug.com/')
504
        self.assertEquals(
505
            ("The URL for bug tracker \"foo\" doesn't contain {id}: "
506
             "http://bug.com/"),
507
            str(err))
508
3234.2.6 by Alexander Belchenko
because every mail client has different rules to compose command line we should encode arguments to 8 bit string only when needed.
509
    def test_unable_encode_path(self):
510
        err = errors.UnableEncodePath('foo', 'executable')
3234.2.8 by Alexander Belchenko
fix grammar in formatting string of UnableEncodePath error.
511
        self.assertEquals("Unable to encode executable path 'foo' in "
3234.2.6 by Alexander Belchenko
because every mail client has different rules to compose command line we should encode arguments to 8 bit string only when needed.
512
            "user encoding " + osutils.get_user_encoding(),
513
            str(err))
514
3246.3.4 by Daniel Watkins
Added test.
515
    def test_unknown_format(self):
516
        err = errors.UnknownFormatError('bar', kind='foo')
517
        self.assertEquals("Unknown foo format: 'bar'", str(err))
518
3398.1.29 by Ian Clatworthy
add UnknownRules class & test
519
    def test_unknown_rules(self):
520
        err = errors.UnknownRules(['foo', 'bar'])
521
        self.assertEquals("Unknown rules detected: foo, bar.", str(err))
522
3577.1.1 by Andrew Bennetts
Cherry-pick TipChangeRejected changes from pre-branch-tip-changed-hook loom.
523
    def test_hook_failed(self):
524
        # Create an exc_info tuple by raising and catching an exception.
525
        try:
526
            1/0
527
        except ZeroDivisionError:
528
            exc_info = sys.exc_info()
529
        err = errors.HookFailed('hook stage', 'hook name', exc_info)
530
        self.assertStartsWith(
531
            str(err), 'Hook \'hook name\' during hook stage failed:\n')
532
        self.assertEndsWith(
533
            str(err), 'integer division or modulo by zero')
534
535
    def test_tip_change_rejected(self):
536
        err = errors.TipChangeRejected(u'Unicode message\N{INTERROBANG}')
537
        self.assertEquals(
538
            u'Tip change rejected: Unicode message\N{INTERROBANG}',
539
            unicode(err))
540
        self.assertEquals(
541
            'Tip change rejected: Unicode message\xe2\x80\xbd',
542
            str(err))
543
2116.3.1 by John Arbash Meinel
Cleanup error tests
544
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
545
class PassThroughError(errors.BzrError):
546
    
547
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
548
549
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
550
        errors.BzrError.__init__(self, foo=foo, bar=bar)
551
552
553
class ErrorWithBadFormat(errors.BzrError):
554
555
    _fmt = """One format specifier: %(thing)s"""
556
557
558
class ErrorWithNoFormat(errors.BzrError):
559
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
560
561
562
class TestErrorFormatting(TestCase):
563
    
564
    def test_always_str(self):
565
        e = PassThroughError(u'\xb5', 'bar')
566
        self.assertIsInstance(e.__str__(), str)
567
        # In Python str(foo) *must* return a real byte string
568
        # not a Unicode string. The following line would raise a
569
        # Unicode error, because it tries to call str() on the string
570
        # returned from e.__str__(), and it has non ascii characters
571
        s = str(e)
572
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
573
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
574
    def test_missing_format_string(self):
575
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
576
        s = self.callDeprecated(
577
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
578
                lambda x: str(x), e)
579
        ## s = str(e)
580
        self.assertEqual(s, 
581
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
582
2116.3.1 by John Arbash Meinel
Cleanup error tests
583
    def test_mismatched_format_args(self):
584
        # Even though ErrorWithBadFormat's format string does not match the
585
        # arguments we constructing it with, we can still stringify an instance
586
        # of this exception. The resulting string will say its unprintable.
587
        e = ErrorWithBadFormat(not_thing='x')
588
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
589
            str(e), 'Unprintable exception ErrorWithBadFormat')