~bzr-pqm/bzr/bzr.dev

3173.1.3 by Martin Pool
Deprecate disable_default_logging and add 1.2 deprecation marker
1
# Copyright (C) 2006, 2007, 2008 Canonical Ltd
2227.1.5 by mbp at sourcefrog
doc cleanup
2
#   Authors: Robert Collins <robert.collins@canonical.com> and others
1534.2.1 by Robert Collins
Implement deprecated_method
3
#
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
8
#
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
# GNU General Public License for more details.
13
#
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
16
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
17
18
"""Symbol versioning
19
20
The methods here allow for api symbol versioning.
21
"""
22
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
23
__all__ = ['deprecated_function',
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
24
           'deprecated_list',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
25
           'deprecated_method',
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
26
           'DEPRECATED_PARAMETER',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
27
           'deprecated_passed',
28
           'warn', 'set_warning_method', 'zero_seven',
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
29
           'zero_eight',
1732.2.2 by Martin Pool
Add zero_nine deprecation
30
           'zero_nine',
1852.11.1 by Robert Collins
Deprecate compare_trees and move its body to InterTree.changes_from.
31
           'zero_ten',
1711.9.6 by John Arbash Meinel
Add a deprecation symbol for bzr-0.11
32
           'zero_eleven',
2037.1.2 by Robert Collins
(Robert Collins) Add 0.12 deprecation symbol.
33
           'zero_twelve',
2101.1.2 by John Arbash Meinel
Create the 0.13 deprecation symbol
34
           'zero_thirteen',
2150.1.1 by Wouter van Heyst
bzr 0.13rc1 has branch, bump bzr.dev version to 0.14
35
           'zero_fourteen',
2234.1.1 by Wouter van Heyst
0.14rc1 has branch, bump bzr.dev version to 0.15
36
           'zero_fifteen',
2363.5.1 by Aaron Bentley
Unify info display into show_component_info
37
           'zero_sixteen',
2483.1.2 by John Arbash Meinel
Updates for bzr-0.17-dev
38
           'zero_seventeen',
2524.1.1 by Aaron Bentley
Revert broken changes
39
           'zero_eighteen',
2687.2.1 by Martin Pool
Rename upcoming release from 0.19 to 0.90
40
           'zero_ninety',
2697.1.1 by John Arbash Meinel
Switch bzr.dev to 0.91 development
41
           'zero_ninetyone',
2830.2.5 by Martin Pool
Deprecated ``run_bzr_decode``; use the new ``output_encoding`` parameter to
42
           'zero_ninetytwo',
2955.3.1 by Alexander Belchenko
start 0.93 development cycle; deprecate osutils.backup_file
43
           'zero_ninetythree',
3123.1.1 by John Arbash Meinel
Update from deprecating 0.93 to 1.0, and add a 1.1 deprecation.
44
           'one_zero',
45
           'one_one',
3173.1.3 by Martin Pool
Deprecate disable_default_logging and add 1.2 deprecation marker
46
           'one_two',
3221.2.1 by Martin Pool
Open 1.3 development
47
           'one_three',
3287.5.5 by Robert Collins
Refactor internals of knit implementations to implement get_parents_with_ghosts in terms of get_parent_map.
48
           'one_four',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
49
           ]
1534.2.1 by Robert Collins
Implement deprecated_method
50
51
from warnings import warn
52
53
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
54
DEPRECATED_PARAMETER = "A deprecated parameter marker."
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
55
zero_seven = "%s was deprecated in version 0.7."
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
56
zero_eight = "%s was deprecated in version 0.8."
1732.1.1 by John Arbash Meinel
deprecating appendpath, it does exactly what pathjoin does
57
zero_nine = "%s was deprecated in version 0.9."
1852.11.1 by Robert Collins
Deprecate compare_trees and move its body to InterTree.changes_from.
58
zero_ten = "%s was deprecated in version 0.10."
1711.9.6 by John Arbash Meinel
Add a deprecation symbol for bzr-0.11
59
zero_eleven = "%s was deprecated in version 0.11."
2037.1.2 by Robert Collins
(Robert Collins) Add 0.12 deprecation symbol.
60
zero_twelve = "%s was deprecated in version 0.12."
2116.1.1 by James Westby
Fix string for deprecation warning for 0.13
61
zero_thirteen = "%s was deprecated in version 0.13."
2150.1.1 by Wouter van Heyst
bzr 0.13rc1 has branch, bump bzr.dev version to 0.14
62
zero_fourteen = "%s was deprecated in version 0.14."
2234.1.1 by Wouter van Heyst
0.14rc1 has branch, bump bzr.dev version to 0.15
63
zero_fifteen = "%s was deprecated in version 0.15."
2363.5.1 by Aaron Bentley
Unify info display into show_component_info
64
zero_sixteen = "%s was deprecated in version 0.16."
2483.1.2 by John Arbash Meinel
Updates for bzr-0.17-dev
65
zero_seventeen = "%s was deprecated in version 0.17."
2524.1.1 by Aaron Bentley
Revert broken changes
66
zero_eighteen = "%s was deprecated in version 0.18."
2687.2.2 by Martin Pool
Fix up other references to 0.19
67
zero_ninety = "%s was deprecated in version 0.90."
2697.1.1 by John Arbash Meinel
Switch bzr.dev to 0.91 development
68
zero_ninetyone = "%s was deprecated in version 0.91."
2830.2.5 by Martin Pool
Deprecated ``run_bzr_decode``; use the new ``output_encoding`` parameter to
69
zero_ninetytwo = "%s was deprecated in version 0.92."
3123.1.1 by John Arbash Meinel
Update from deprecating 0.93 to 1.0, and add a 1.1 deprecation.
70
one_zero = "%s was deprecated in version 1.0."
71
zero_ninetythree = one_zero # Maintained for backwards compatibility
72
one_one = "%s was deprecated in version 1.1."
3173.1.3 by Martin Pool
Deprecate disable_default_logging and add 1.2 deprecation marker
73
one_two = "%s was deprecated in version 1.2."
3221.2.1 by Martin Pool
Open 1.3 development
74
one_three = "%s was deprecated in version 1.3."
3293.1.1 by Martin Pool
Add one_four deprecation
75
one_four = "%s was deprecated in version 1.4."
1534.2.1 by Robert Collins
Implement deprecated_method
76
77
def set_warning_method(method):
78
    """Set the warning method to be used by this module.
79
80
    It should take a message and a warning category as warnings.warn does.
81
    """
82
    global warn
83
    warn = method
84
85
1534.2.2 by Robert Collins
Implement deprecated_function.
86
# TODO - maybe this would be easier to use as one 'smart' method that
87
# guess if it is a method or a class or an attribute ? If so, we can
88
# add that on top of the primitives, once we have all three written
89
# - RBC 20050105
90
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
91
92
def deprecation_string(a_callable, deprecation_version):
93
    """Generate an automatic deprecation string for a_callable.
94
95
    :param a_callable: The callable to substitute into deprecation_version.
96
    :param deprecation_version: A deprecation format warning string. This should
97
        have a single %s operator in it. a_callable will be turned into a nice
98
        python symbol and then substituted into deprecation_version.
99
    """
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
100
    # We also want to handle old-style classes, in particular exception, and
101
    # they don't have an im_class attribute.
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
102
    if getattr(a_callable, 'im_class', None) is None:
103
        symbol = "%s.%s" % (a_callable.__module__,
104
                            a_callable.__name__)
105
    else:
106
        symbol = "%s.%s.%s" % (a_callable.im_class.__module__,
107
                               a_callable.im_class.__name__,
108
                               a_callable.__name__
109
                               )
110
    return deprecation_version % symbol
111
112
1534.2.2 by Robert Collins
Implement deprecated_function.
113
def deprecated_function(deprecation_version):
114
    """Decorate a function so that use of it will trigger a warning."""
115
116
    def function_decorator(callable):
117
        """This is the function python calls to perform the decoration."""
118
        
119
        def decorated_function(*args, **kwargs):
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
120
            """This is the decorated function."""
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
121
            warn(deprecation_string(callable, deprecation_version),
122
                DeprecationWarning, stacklevel=2)
1534.2.2 by Robert Collins
Implement deprecated_function.
123
            return callable(*args, **kwargs)
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
124
        _populate_decorated(callable, deprecation_version, "function",
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
125
                            decorated_function)
1534.2.2 by Robert Collins
Implement deprecated_function.
126
        return decorated_function
127
    return function_decorator
128
129
1534.2.1 by Robert Collins
Implement deprecated_method
130
def deprecated_method(deprecation_version):
131
    """Decorate a method so that use of it will trigger a warning.
2825.3.2 by Martin Pool
doc
132
133
    To deprecate a static or class method, use 
134
135
        @staticmethod
136
        @deprecated_function
137
        def ...
1534.2.1 by Robert Collins
Implement deprecated_method
138
    
139
    To deprecate an entire class, decorate __init__.
140
    """
141
142
    def method_decorator(callable):
143
        """This is the function python calls to perform the decoration."""
144
        
145
        def decorated_method(self, *args, **kwargs):
146
            """This is the decorated method."""
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
147
            if callable.__name__ == '__init__':
148
                symbol = "%s.%s" % (self.__class__.__module__,
149
                                    self.__class__.__name__,
150
                                    )
151
            else:
152
                symbol = "%s.%s.%s" % (self.__class__.__module__,
153
                                       self.__class__.__name__,
154
                                       callable.__name__
155
                                       )
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
156
            warn(deprecation_version % symbol, DeprecationWarning, stacklevel=2)
1534.2.1 by Robert Collins
Implement deprecated_method
157
            return callable(self, *args, **kwargs)
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
158
        _populate_decorated(callable, deprecation_version, "method",
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
159
                            decorated_method)
1534.2.1 by Robert Collins
Implement deprecated_method
160
        return decorated_method
161
    return method_decorator
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
162
163
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
164
def deprecated_passed(parameter_value):
165
    """Return True if parameter_value was used."""
166
    # FIXME: it might be nice to have a parameter deprecation decorator. 
167
    # it would need to handle positional and *args and **kwargs parameters,
168
    # which means some mechanism to describe how the parameter was being
169
    # passed before deprecation, and some way to deprecate parameters that
170
    # were not at the end of the arg list. Thats needed for __init__ where
171
    # we cannot just forward to a new method name.I.e. in the following
172
    # examples we would want to have callers that pass any value to 'bad' be
173
    # given a warning - because we have applied:
174
    # @deprecated_parameter('bad', zero_seven)
175
    #
176
    # def __init__(self, bad=None)
177
    # def __init__(self, bad, other)
178
    # def __init__(self, **kwargs)
179
    # RBC 20060116
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
180
    return not parameter_value is DEPRECATED_PARAMETER
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
181
182
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
183
def _decorate_docstring(callable, deprecation_version, label,
184
                        decorated_callable):
1732.1.1 by John Arbash Meinel
deprecating appendpath, it does exactly what pathjoin does
185
    if callable.__doc__:
186
        docstring_lines = callable.__doc__.split('\n')
187
    else:
188
        docstring_lines = []
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
189
    if len(docstring_lines) == 0:
190
        decorated_callable.__doc__ = deprecation_version % ("This " + label)
191
    elif len(docstring_lines) == 1:
192
        decorated_callable.__doc__ = (callable.__doc__ 
193
                                    + "\n"
194
                                    + "\n"
195
                                    + deprecation_version % ("This " + label)
196
                                    + "\n")
197
    else:
198
        spaces = len(docstring_lines[-1])
199
        new_doc = callable.__doc__
200
        new_doc += "\n" + " " * spaces
201
        new_doc += deprecation_version % ("This " + label)
202
        new_doc += "\n" + " " * spaces
203
        decorated_callable.__doc__ = new_doc
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
204
205
206
def _populate_decorated(callable, deprecation_version, label,
207
                        decorated_callable):
208
    """Populate attributes like __name__ and __doc__ on the decorated callable.
209
    """
210
    _decorate_docstring(callable, deprecation_version, label,
211
                        decorated_callable)
1534.1.3 by Robert Collins
Bugfix the symbol_versioning deprecation decorators to update the
212
    decorated_callable.__module__ = callable.__module__
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
213
    decorated_callable.__name__ = callable.__name__
1581.1.1 by Robert Collins
Bugfix aliases to be backwards compatible with plugins providing command.run_argv.
214
    decorated_callable.is_deprecated = True
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
215
216
2227.1.5 by mbp at sourcefrog
doc cleanup
217
def _dict_deprecation_wrapper(wrapped_method):
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
218
    """Returns a closure that emits a warning and calls the superclass"""
219
    def cb(dep_dict, *args, **kwargs):
220
        msg = 'access to %s' % (dep_dict._variable_name, )
221
        msg = dep_dict._deprecation_version % (msg,)
222
        if dep_dict._advice:
223
            msg += ' ' + dep_dict._advice
224
        warn(msg, DeprecationWarning, stacklevel=2)
2227.1.5 by mbp at sourcefrog
doc cleanup
225
        return wrapped_method(dep_dict, *args, **kwargs)
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
226
    return cb
227
228
229
class DeprecatedDict(dict):
230
    """A dictionary that complains when read or written."""
231
232
    is_deprecated = True
233
234
    def __init__(self,
235
        deprecation_version,
236
        variable_name,
237
        initial_value,
238
        advice,
239
        ):
240
        """Create a dict that warns when read or modified.
241
242
        :param deprecation_version: something like zero_nine
243
        :param initial_value: The contents of the dict
244
        :param variable_name: This allows better warnings to be printed
245
        :param advice: String of advice on what callers should do instead 
246
            of using this variable.
247
        """
248
        self._deprecation_version = deprecation_version
249
        self._variable_name = variable_name
250
        self._advice = advice
251
        dict.__init__(self, initial_value)
252
253
    # This isn't every possible method but it should trap anyone using the
254
    # dict -- add more if desired
255
    __len__ = _dict_deprecation_wrapper(dict.__len__)
256
    __getitem__ = _dict_deprecation_wrapper(dict.__getitem__)
257
    __setitem__ = _dict_deprecation_wrapper(dict.__setitem__)
258
    __delitem__ = _dict_deprecation_wrapper(dict.__delitem__)
259
    keys = _dict_deprecation_wrapper(dict.keys)
260
    __contains__ = _dict_deprecation_wrapper(dict.__contains__)
261
262
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
263
def deprecated_list(deprecation_version, variable_name,
264
                    initial_value, extra=None):
265
    """Create a list that warns when modified
266
267
    :param deprecation_version: something like zero_nine
268
    :param initial_value: The contents of the list
269
    :param variable_name: This allows better warnings to be printed
270
    :param extra: Extra info to print when printing a warning
271
    """
272
273
    subst_text = 'Modifying %s' % (variable_name,)
274
    msg = deprecation_version % (subst_text,)
275
    if extra:
276
        msg += ' ' + extra
277
278
    class _DeprecatedList(list):
279
        __doc__ = list.__doc__ + msg
280
281
        is_deprecated = True
282
283
        def _warn_deprecated(self, func, *args, **kwargs):
284
            warn(msg, DeprecationWarning, stacklevel=3)
285
            return func(self, *args, **kwargs)
286
            
287
        def append(self, obj):
288
            """appending to %s is deprecated""" % (variable_name,)
289
            return self._warn_deprecated(list.append, obj)
290
291
        def insert(self, index, obj):
292
            """inserting to %s is deprecated""" % (variable_name,)
293
            return self._warn_deprecated(list.insert, index, obj)
294
295
        def extend(self, iterable):
296
            """extending %s is deprecated""" % (variable_name,)
297
            return self._warn_deprecated(list.extend, iterable)
298
299
        def remove(self, value):
300
            """removing from %s is deprecated""" % (variable_name,)
301
            return self._warn_deprecated(list.remove, value)
302
303
        def pop(self, index=None):
304
            """pop'ing from from %s is deprecated""" % (variable_name,)
305
            if index:
306
                return self._warn_deprecated(list.pop, index)
307
            else:
308
                # Can't pass None
309
                return self._warn_deprecated(list.pop)
310
311
    return _DeprecatedList(initial_value)