~bzr-pqm/bzr/bzr.dev

2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
1
# Copyright (C) 2007 Canonical Ltd
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
17
import textwrap
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
18
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
19
from bzrlib import registry, help_topics
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
20
from bzrlib.lazy_import import lazy_import
21
lazy_import(globals(), """
2376.4.17 by Jonathan Lange
Use urlutils.join instead of ugly, buggy, string mashing
22
from bzrlib import errors, urlutils
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
23
""")
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
24
25
2376.4.7 by jml at canonical
- Add docstrings to tests.
26
"""Provides a shorthand for referring to bugs on a variety of bug trackers.
27
28
'commit --fixes' stores references to bugs as a <bug_url> -> <bug_status>
29
mapping in the properties for that revision.
30
31
However, it's inconvenient to type out full URLs for bugs on the command line,
32
particularly given that many users will be using only a single bug tracker per
33
branch.
34
35
Thus, this module provides a registry of types of bug tracker (e.g. Launchpad,
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
36
Trac). Given an abbreviated name (e.g. 'lp', 'twisted') and a branch with
2376.4.7 by jml at canonical
- Add docstrings to tests.
37
configuration information, these tracker types can return an instance capable
38
of converting bug IDs into URLs.
39
"""
40
41
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
42
_bugs_help = \
43
"""When making a commit, metadata about bugs fixed by that change can be
44
recorded by using the --fixes option. For each bug marked as fixed, an
45
entry is included in the 'bugs' revision property stating '<url> <status>'.
46
Support for Launchpad's central bug tracker is built in. For other bug
47
trackers, configuration is required in advance so that the correct URL
48
can be recorded.
49
50
In addition to Launchpad, Bazaar directly supports the generation of
51
URLs appropriate for Bugzilla and Trac. If your project uses a different
52
bug tracker, it is easy to add support for it by writing a plugin, say.
53
If you use Bugzilla or Trac, then you only need to set a configuration
54
variable which contains the base URL of the bug tracker. These options
55
can go into ``bazaar.conf``, ``branch.conf`` or into a branch-specific
56
configuration section in ``locations.conf``.  You can set up these values
57
for each of the projects you work on.
58
59
Note: As you provide a short name for each tracker, you can specify one or
60
more bugs in one or more trackers at commit time if you wish.
61
62
bugzilla_<tracker_abbreviation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
63
-----------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
64
65
If present, the location of the Bugzilla bug tracker referred to by
66
<tracker_abbreviation>. This option can then be used together with ``bzr commit
67
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
68
example::
69
70
    bugzilla_squid_url = http://www.squid-cache.org/bugs
71
72
would allow ``bzr commit --fixes squid:1234`` to mark Squid's bug 1234 as
73
fixed.
74
75
trac_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
76
------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
77
78
If present, the location of the Trac instance referred to by
79
<tracker_abbreviation>. This option can then be used together with ``bzr commit
80
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
81
example::
82
83
    trac_twisted_url = http://www.twistedmatrix.com/trac
84
85
would allow ``bzr commit --fixes twisted:1234`` to mark Twisted's bug 1234 as
86
fixed.
87
88
bugtracker_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
89
------------------------------------
90
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
91
If present, the location of a generic bug tracker instance referred to by
92
<tracker_abbreviation>. The location must contain an ``{id}`` placeholder,
93
which will be replaced by a specific bug ID. This option can then be used
94
together with ``bzr commit --fixes`` to mark bugs in that tracker as being
95
fixed by that commit. For example::
96
97
    bugtracker_python_url = http://bugs.python.org/issue{id}
98
99
would allow ``bzr commit --fixes python:1234`` to mark bug 1234 in Python's
100
Roundup bug tracker as fixed, or::
101
102
    bugtracker_cpan_url = http://rt.cpan.org/Public/Bug/Display.html?id={id}
103
104
for CPAN's RT bug tracker.
105
"""
106
107
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
108
def get_bug_url(abbreviated_bugtracker_name, branch, bug_id):
109
    """Return a URL pointing to the canonical web page of the bug identified by
110
    'bug_id'.
111
    """
112
    tracker = tracker_registry.get_tracker(abbreviated_bugtracker_name, branch)
113
    return tracker.get_bug_url(bug_id)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
114
115
116
class TrackerRegistry(registry.Registry):
117
    """Registry of bug tracker types."""
118
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
119
    def get_tracker(self, abbreviated_bugtracker_name, branch):
120
        """Return the first registered tracker that understands
121
        'abbreviated_bugtracker_name'.
2376.4.7 by jml at canonical
- Add docstrings to tests.
122
123
        If no such tracker is found, raise KeyError.
124
        """
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
125
        for tracker_name in self.keys():
126
            tracker_type = self.get(tracker_name)
127
            tracker = tracker_type.get(abbreviated_bugtracker_name, branch)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
128
            if tracker is not None:
129
                return tracker
2376.4.28 by Jonathan Lange
Focus the tests better and clean up some dodgy bits in UnknownBugTrackerAbbreviation
130
        raise errors.UnknownBugTrackerAbbreviation(abbreviated_bugtracker_name,
131
                                                   branch)
2376.4.7 by jml at canonical
- Add docstrings to tests.
132
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
133
    def help_topic(self, topic):
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
134
        return _bugs_help
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
135
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
136
137
tracker_registry = TrackerRegistry()
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
138
"""Registry of bug trackers."""
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
139
2376.4.15 by Jonathan Lange
Whitespace cleanup
140
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
141
class BugTracker(object):
142
    """Base class for bug trackers."""
143
144
    def check_bug_id(self, bug_id):
145
        """Check that the bug_id is valid.
146
147
        The base implementation assumes that all bug_ids are valid.
148
        """
149
150
    def get_bug_url(self, bug_id):
151
        """Return the URL for bug_id. Raise an error if bug ID is malformed."""
152
        self.check_bug_id(bug_id)
153
        return self._get_bug_url(bug_id)
154
155
    def _get_bug_url(self, bug_id):
156
        """Given a validated bug_id, return the bug's web page's URL."""
157
158
159
class IntegerBugTracker(BugTracker):
160
    """A bug tracker that only allows integer bug IDs."""
161
162
    def check_bug_id(self, bug_id):
163
        try:
164
            int(bug_id)
165
        except ValueError:
166
            raise errors.MalformedBugIdentifier(bug_id, "Must be an integer")
167
168
169
class UniqueIntegerBugTracker(IntegerBugTracker):
2376.4.19 by Jonathan Lange
Rename SimpleBugTracker to UniqueBugTracker
170
    """A style of bug tracker that exists in one place only, such as Launchpad.
2376.4.15 by Jonathan Lange
Whitespace cleanup
171
2376.4.41 by Jonathan Lange
Update UniqueIntegerBugTracker docstring for new API
172
    If you have one of these trackers then register an instance passing in an
173
    abbreviated name for the bug tracker and a base URL.
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
174
    """
175
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
176
    def __init__(self, abbreviated_bugtracker_name, base_url):
177
        self.abbreviation = abbreviated_bugtracker_name
178
        self.base_url = base_url
179
180
    def get(self, abbreviated_bugtracker_name, branch):
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
181
        """Returns the tracker if the abbreviation matches. Returns None
182
        otherwise."""
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
183
        if abbreviated_bugtracker_name != self.abbreviation:
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
184
            return None
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
185
        return self
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
186
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
187
    def _get_bug_url(self, bug_id):
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
188
        """Return the URL for bug_id."""
2376.4.17 by Jonathan Lange
Use urlutils.join instead of ugly, buggy, string mashing
189
        return urlutils.join(self.base_url, bug_id)
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
190
191
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
192
tracker_registry.register(
193
    'launchpad', UniqueIntegerBugTracker('lp', 'https://launchpad.net/bugs/'))
194
195
196
tracker_registry.register(
2376.4.29 by Jonathan Lange
Tests for builtin trackers.
197
    'debian', UniqueIntegerBugTracker('deb', 'http://bugs.debian.org/'))
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
198
2376.4.15 by Jonathan Lange
Whitespace cleanup
199
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
200
class URLParametrizedIntegerBugTracker(IntegerBugTracker):
201
    """A type of bug tracker that can be found on a variety of different sites,
202
    and thus needs to have the base URL configured.
203
204
    Looks for a config setting in the form '<type_name>_<abbreviation>_url'.
205
    `type_name` is the name of the type of tracker (e.g. 'bugzilla' or 'trac')
206
    and `abbreviation` is a short name for the particular instance (e.g.
207
    'squid' or 'apache').
208
    """
209
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
210
    def get(self, abbreviation, branch):
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
211
        config = branch.get_config()
212
        url = config.get_user_option(
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
213
            "%s_%s_url" % (self.type_name, abbreviation))
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
214
        if url is None:
215
            return None
216
        self._base_url = url
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
217
        return self
218
219
    def __init__(self, type_name, bug_area):
220
        self.type_name = type_name
221
        self._bug_area = bug_area
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
222
223
    def _get_bug_url(self, bug_id):
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
224
        """Return a URL for a bug on this Trac instance."""
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
225
        return urlutils.join(self._base_url, self._bug_area) + str(bug_id)
226
227
228
tracker_registry.register(
229
    'trac', URLParametrizedIntegerBugTracker('trac', 'ticket/'))
230
231
tracker_registry.register(
232
    'bugzilla',
233
    URLParametrizedIntegerBugTracker('bugzilla', 'show_bug.cgi?id='))
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
234
235
236
class GenericBugTracker(URLParametrizedIntegerBugTracker):
237
    """Generic bug tracker specified by an URL template."""
238
239
    def __init__(self):
3035.3.2 by Lukáš Lalinský
Add tests for InvalidBugTrackerURL.
240
        super(GenericBugTracker, self).__init__('bugtracker', None)
241
242
    def get(self, abbreviation, branch):
243
        self._abbreviation = abbreviation
244
        return super(GenericBugTracker, self).get(abbreviation, branch)
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
245
246
    def _get_bug_url(self, bug_id):
247
        """Given a validated bug_id, return the bug's web page's URL."""
248
        if '{id}' not in self._base_url:
249
            raise errors.InvalidBugTrackerURL(self._abbreviation,
250
                                              self._base_url)
251
        return self._base_url.replace('{id}', str(bug_id))
252
253
254
tracker_registry.register('generic', GenericBugTracker())