~bzr-pqm/bzr/bzr.dev

2374.2.2 by John Arbash Meinel
Fix the small bug that ie.snapshot() didn't think about kind changes.
1
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
62
    revision,
1551.8.30 by Aaron Bentley
Tweak from review comments
63
    tree,
64
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
65
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
66
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
67
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
68
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
69
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
70
                           )
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
71
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any,
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
72
                            is_inside_or_parent_of_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
73
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
74
                            quotefn, sha_file, split_lines,
75
                            splitpath,
76
                            )
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
77
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
78
from bzrlib.trace import mutter, note, warning, is_quiet
1189 by Martin Pool
- BROKEN: partial support for commit into weave
79
from bzrlib.xml5 import serializer_v5
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
80
from bzrlib.inventory import InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
81
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
82
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
83
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
84
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
85
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
86
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
87
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
88
89
90
class NullCommitReporter(object):
91
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
92
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
93
    def started(self, revno, revid, location=None):
94
        pass
95
96
    def snapshot_change(self, change, path):
97
        pass
98
99
    def completed(self, revno, rev_id):
100
        pass
101
102
    def deleted(self, file_id):
103
        pass
104
105
    def escaped(self, escape_count, message):
106
        pass
107
108
    def missing(self, path):
109
        pass
110
111
    def renamed(self, change, old_path, new_path):
112
        pass
113
2789.2.11 by Ian Clatworthy
remove more reporting stuff
114
    def is_verbose(self):
115
        return False
116
117
118
class ReportCommitToLog(NullCommitReporter):
119
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
120
    def _note(self, format, *args):
121
        """Output a message.
122
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
123
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
124
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
125
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
126
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
127
    def snapshot_change(self, change, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
128
        if change == 'unchanged':
129
            return
130
        if change == 'added' and path == '':
131
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
132
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
133
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
134
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
135
        if location is not None:
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
136
            location = ' to "' + unescape_for_display(location, 'utf-8') + '"'
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
137
        else:
138
            location = ''
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
139
        self._note('Committing revision %d%s.', revno, location)
140
141
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
142
        self._note('Committed revision %d.', revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
143
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
144
    def deleted(self, file_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
145
        self._note('deleted %s', file_id)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
146
147
    def escaped(self, escape_count, message):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
148
        self._note("replaced %d control characters in message", escape_count)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
149
150
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
151
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
152
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
153
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
154
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
155
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
156
    def is_verbose(self):
157
        return True
158
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
159
1189 by Martin Pool
- BROKEN: partial support for commit into weave
160
class Commit(object):
161
    """Task of committing a new revision.
162
163
    This is a MethodObject: it accumulates state as the commit is
164
    prepared, and then it is discarded.  It doesn't represent
165
    historical revisions, just the act of recording a new one.
166
167
            missing_ids
168
            Modified to hold a list of files that have been deleted from
169
            the working directory; these should be removed from the
170
            working inventory.
485 by Martin Pool
- move commit code into its own module
171
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
172
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
173
                 reporter=None,
174
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
175
        """Create a Commit object.
176
177
        :param reporter: the default reporter to use or None to decide later
178
        """
179
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
180
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
181
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
183
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
184
               timestamp=None,
185
               timezone=None,
186
               committer=None,
187
               specific_files=None,
188
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
189
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
190
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
191
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
192
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
193
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
194
               local=False,
195
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
196
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
197
               message_callback=None,
198
               recursive='down'):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
199
        """Commit working copy as a new revision.
200
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
201
        :param message: the commit message (it or message_callback is required)
202
203
        :param timestamp: if not None, seconds-since-epoch for a
204
            postdated/predated commit.
205
206
        :param specific_files: If true, commit only those files.
207
208
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
209
            Useful for test or import commands that need to tightly
210
            control what revisions are assigned.  If you duplicate
211
            a revision id that exists elsewhere it is your own fault.
212
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
213
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
214
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
215
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
216
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
217
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
218
            contains unknown files.
219
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
220
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
221
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
222
        :param reporter: the reporter to use or None for the default
223
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
224
        :param recursive: If set to 'down', commit in any subtrees that have
225
            pending changes of any sort during this commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
226
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
227
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
228
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
229
        if working_tree is None:
230
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
231
        else:
232
            self.work_tree = working_tree
233
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
234
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
235
                if not self.branch.repository.supports_rich_root():
236
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
237
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
238
            if message is not None:
239
                if isinstance(message, str):
240
                    message = message.decode(bzrlib.user_encoding)
241
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
242
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
243
                raise BzrError("The message or message_callback keyword"
244
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
245
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
246
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
247
        self.any_entries_changed = False
248
        self.any_entries_deleted = False
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
249
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
250
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
251
        self.master_locked = False
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
252
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
253
        self.rev_id = None
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
254
        if specific_files is not None:
255
            self.specific_files = sorted(
256
                minimum_path_selection(specific_files))
257
        else:
258
            self.specific_files = None
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
259
        self.specific_file_ids = None
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
260
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
261
        self.revprops = revprops
262
        self.message_callback = message_callback
263
        self.timestamp = timestamp
264
        self.timezone = timezone
265
        self.committer = committer
266
        self.strict = strict
267
        self.verbose = verbose
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
268
        # accumulates an inventory delta to the basis entry, so we can make
269
        # just the necessary updates to the workingtree's cached basis.
2903.2.10 by Martin Pool
make Commit.basis_delta private
270
        self._basis_delta = []
1189 by Martin Pool
- BROKEN: partial support for commit into weave
271
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
272
        self.work_tree.lock_write()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
273
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
274
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
275
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
276
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
277
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
278
            # Cannot commit with conflicts present.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
279
            if len(self.work_tree.conflicts()) > 0:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
280
                raise ConflictsInTree
281
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
282
            # Setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
283
            self._check_bound_branch()
284
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
285
            # Check that the working tree is up to date
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
286
            old_revno, new_revno = self._check_out_of_date_tree()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
287
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
288
            # Complete configuration setup
289
            if reporter is not None:
290
                self.reporter = reporter
291
            elif self.reporter is None:
292
                self.reporter = self._select_reporter()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
293
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
294
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
295
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
296
            # If provided, ensure the specified files are versioned
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
297
            if self.specific_files is not None:
2776.4.13 by Robert Collins
Merge bzr.dev.
298
                # Note: This routine is being called because it raises
2776.4.14 by Robert Collins
Merge bzr.dev.
299
                # PathNotVersionedError as a side effect of finding the IDs. We
2776.4.13 by Robert Collins
Merge bzr.dev.
300
                # later use the ids we found as input to the working tree
301
                # inventory iterator, so we only consider those ids rather than
302
                # examining the whole tree again.
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
303
                # XXX: Dont we have filter_unversioned to do this more
304
                # cheaply?
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
305
                self.specific_file_ids = tree.find_ids_across_trees(
306
                    specific_files, [self.basis_tree, self.work_tree])
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
307
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
308
            # Setup the progress bar. As the number of files that need to be
309
            # committed in unknown, progress is reported as stages.
310
            # We keep track of entries separately though and include that
311
            # information in the progress bar during the relevant stages.
312
            self.pb_stage_name = ""
313
            self.pb_stage_count = 0
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
314
            self.pb_stage_total = 5
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
315
            if self.bound_branch:
316
                self.pb_stage_total += 1
317
            self.pb.show_pct = False
318
            self.pb.show_spinner = False
319
            self.pb.show_eta = False
320
            self.pb.show_count = True
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
321
            self.pb.show_bar = True
1189 by Martin Pool
- BROKEN: partial support for commit into weave
322
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
323
            # After a merge, a selected file commit is not supported.
324
            # See 'bzr help merge' for an explanation as to why.
325
            self.basis_inv = self.basis_tree.inventory
1223 by Martin Pool
- store inventories in weave
326
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
327
            if len(self.parents) > 1 and self.specific_files:
1551.15.9 by Aaron Bentley
Better error for selected-file commit of merges
328
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
329
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
330
            # Collect the changes
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
331
            self._set_progress_stage("Collecting changes",
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
332
                    entries_title="Directory")
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
333
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
334
                self.config, timestamp, timezone, committer, revprops, rev_id)
2659.3.5 by NamNguyen
merge with bzr.dev
335
            
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
336
            try:
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
337
                # find the location being committed to
338
                if self.bound_branch:
339
                    master_location = self.master_branch.base
340
                else:
341
                    master_location = self.branch.base
342
343
                # report the start of the commit
344
                self.reporter.started(new_revno, self.rev_id, master_location)
345
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
346
                self._update_builder_with_changes()
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
347
                self._report_and_accumulate_deletes()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
348
                self._check_pointless()
349
350
                # TODO: Now the new inventory is known, check for conflicts.
351
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
352
                # weave lines, because nothing should be recorded until it is known
353
                # that commit will succeed.
2592.3.49 by Robert Collins
Merge bzr.dev.
354
                self._set_progress_stage("Saving data locally")
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
355
                self.builder.finish_inventory()
356
357
                # Prompt the user for a commit message if none provided
358
                message = message_callback(self)
359
                assert isinstance(message, unicode), type(message)
360
                self.message = message
361
                self._escape_commit_message()
362
363
                # Add revision data to the local branch
364
                self.rev_id = self.builder.commit(self.message)
2659.3.5 by NamNguyen
merge with bzr.dev
365
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
366
            except:
2749.3.1 by Jelmer Vernooij
Add CommitBuilder.abort().
367
                self.builder.abort()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
368
                raise
369
2659.3.6 by NamNguyen
branch_implementations/test_commit.py:
370
            self._process_pre_hooks(old_revno, new_revno)
371
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
372
            # Upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
373
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
374
            if self.bound_branch:
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
375
                self._set_progress_stage("Uploading data to master branch")
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
376
                self.master_branch.repository.fetch(self.branch.repository,
377
                                                    revision_id=self.rev_id)
378
                # now the master has the revision data
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
379
                # 'commit' to the master first so a timeout here causes the
380
                # local branch to be out of date
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
381
                self.master_branch.set_last_revision_info(new_revno,
382
                                                          self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
383
384
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
385
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
386
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
387
            # Make the working tree up to date with the branch
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
388
            self._set_progress_stage("Updating the working tree")
2929.2.1 by Robert Collins
* Commit updates the state of the working tree via a delta rather than
389
            self.work_tree.update_basis_by_delta(self.rev_id,
390
                 self._basis_delta)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
391
            self.reporter.completed(new_revno, self.rev_id)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
392
            self._process_post_hooks(old_revno, new_revno)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
393
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
394
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
395
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
396
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
397
    def _select_reporter(self):
398
        """Select the CommitReporter to use."""
399
        if is_quiet():
400
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
401
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
402
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
403
    def _check_pointless(self):
404
        if self.allow_pointless:
405
            return
406
        # A merge with no effect on files
407
        if len(self.parents) > 1:
408
            return
2903.2.10 by Martin Pool
make Commit.basis_delta private
409
        # TODO: we could simplify this by using self._basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
410
2921.4.6 by Robert Collins
Typos found by Rob Weir.
411
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
412
        # a worthwhile commit.
413
        if (self.basis_revid == revision.NULL_REVISION and
414
            len(self.builder.new_inventory) == 1):
1731.1.49 by Aaron Bentley
Merge bzr.dev
415
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
416
        # If length == 1, then we only have the root entry. Which means
417
        # that there is no real difference (only the root could be different)
2921.4.7 by Robert Collins
Correct the check_pointless change to pass all tests.
418
        # unless deletes occured, in which case the length is irrelevant.
419
        if (self.any_entries_deleted or 
420
            (len(self.builder.new_inventory) != 1 and
421
             self.any_entries_changed)):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
422
            return
423
        raise PointlessCommit()
424
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
425
    def _check_bound_branch(self):
426
        """Check to see if the local branch is bound.
427
428
        If it is bound, then most of the commit will actually be
429
        done using the remote branch as the target branch.
430
        Only at the end will the local branch be updated.
431
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
432
        if self.local and not self.branch.get_bound_location():
433
            raise errors.LocalRequiresBoundBranch()
434
435
        if not self.local:
436
            self.master_branch = self.branch.get_master_branch()
437
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
438
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
439
            # make this branch the reference branch for out of date checks.
440
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
441
            return
442
443
        # If the master branch is bound, we must fail
444
        master_bound_location = self.master_branch.get_bound_location()
445
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
446
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
447
                    self.master_branch, master_bound_location)
448
449
        # TODO: jam 20051230 We could automatically push local
450
        #       commits to the remote branch if they would fit.
451
        #       But for now, just require remote to be identical
452
        #       to local.
453
        
454
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
455
        master_info = self.master_branch.last_revision_info()
456
        local_info = self.branch.last_revision_info()
457
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
458
            raise errors.BoundBranchOutOfDate(self.branch,
459
                    self.master_branch)
460
461
        # Now things are ready to change the master branch
462
        # so grab the lock
463
        self.bound_branch = self.branch
464
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
465
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
466
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
467
    def _check_out_of_date_tree(self):
468
        """Check that the working tree is up to date.
469
470
        :return: old_revision_number,new_revision_number tuple
471
        """
472
        try:
473
            first_tree_parent = self.work_tree.get_parent_ids()[0]
474
        except IndexError:
475
            # if there are no parents, treat our parent as 'None'
476
            # this is so that we still consider the master branch
477
            # - in a checkout scenario the tree may have no
478
            # parents but the branch may do.
479
            first_tree_parent = bzrlib.revision.NULL_REVISION
480
        old_revno, master_last = self.master_branch.last_revision_info()
481
        if master_last != first_tree_parent:
482
            if master_last != bzrlib.revision.NULL_REVISION:
483
                raise errors.OutOfDateTree(self.work_tree)
484
        if self.branch.repository.has_revision(first_tree_parent):
485
            new_revno = old_revno + 1
486
        else:
487
            # ghost parents never appear in revision history.
488
            new_revno = 1
489
        return old_revno,new_revno
490
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
491
    def _process_pre_hooks(self, old_revno, new_revno):
492
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
493
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
494
        self._process_hooks("pre_commit", old_revno, new_revno)
495
496
    def _process_post_hooks(self, old_revno, new_revno):
497
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
498
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
499
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
500
        # old style commit hooks - should be deprecated ? (obsoleted in
501
        # 0.15)
502
        if self.config.post_commit() is not None:
503
            hooks = self.config.post_commit().split(' ')
504
            # this would be nicer with twisted.python.reflect.namedAny
505
            for hook in hooks:
506
                result = eval(hook + '(branch, rev_id)',
507
                              {'branch':self.branch,
508
                               'bzrlib':bzrlib,
509
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
510
        # process new style post commit hooks
511
        self._process_hooks("post_commit", old_revno, new_revno)
512
513
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
514
        if not Branch.hooks[hook_name]:
515
            return
516
        
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
517
        # new style commit hooks:
518
        if not self.bound_branch:
519
            hook_master = self.branch
520
            hook_local = None
521
        else:
522
            hook_master = self.master_branch
523
            hook_local = self.branch
524
        # With bound branches, when the master is behind the local branch,
525
        # the 'old_revno' and old_revid values here are incorrect.
526
        # XXX: FIXME ^. RBC 20060206
527
        if self.parents:
528
            old_revid = self.parents[0]
529
        else:
530
            old_revid = bzrlib.revision.NULL_REVISION
2659.3.9 by NamNguyen
branch.py:
531
        
532
        if hook_name == "pre_commit":
533
            future_tree = self.builder.revision_tree()
534
            tree_delta = future_tree.changes_from(self.basis_tree,
535
                                             include_root=True)
536
        
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
537
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
538
            # show the running hook in the progress bar. As hooks may
539
            # end up doing nothing (e.g. because they are not configured by
540
            # the user) this is still showing progress, not showing overall
541
            # actions - its up to each plugin to show a UI if it want's to
542
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
543
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
544
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
545
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
546
            if 'hooks' in debug.debug_flags:
547
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
548
            if hook_name == "post_commit":
549
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
550
                     self.rev_id)
551
            elif hook_name == "pre_commit":
552
                hook(hook_local, hook_master,
553
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
554
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
555
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
556
    def _cleanup(self):
557
        """Cleanup any open locks, progress bars etc."""
558
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
559
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
560
                    self.work_tree.unlock,
561
                    self.pb.finished]
562
        found_exception = None
563
        for cleanup in cleanups:
564
            try:
565
                cleanup()
566
            # we want every cleanup to run no matter what.
567
            # so we have a catchall here, but we will raise the
568
            # last encountered exception up the stack: and
569
            # typically this will be useful enough.
570
            except Exception, e:
571
                found_exception = e
572
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
573
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
574
            # trashed, e is our sure-to-work exception even though it loses the
575
            # full traceback. XXX: RBC 20060421 perhaps we could check the
576
            # exc_info and if its the same one do a plain raise otherwise 
577
            # 'raise e' as we do now.
578
            raise e
579
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
580
    def _cleanup_bound_branch(self):
581
        """Executed at the end of a try/finally to cleanup a bound branch.
582
583
        If the branch wasn't bound, this is a no-op.
584
        If it was, it resents self.branch to the local branch, instead
585
        of being the master.
586
        """
587
        if not self.bound_branch:
588
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
589
        if self.master_locked:
590
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
591
1390 by Robert Collins
pair programming worx... merge integration and weave
592
    def _escape_commit_message(self):
593
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
594
        # FIXME: RBC 20060419 this should be done by the revision
595
        # serialiser not by commit. Then we can also add an unescaper
596
        # in the deserializer and start roundtripping revision messages
597
        # precisely. See repository_implementations/test_repository.py
598
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
599
        # Python strings can include characters that can't be
600
        # represented in well-formed XML; escape characters that
601
        # aren't listed in the XML specification
602
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
603
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
604
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
605
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
606
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
607
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
608
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
609
610
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
611
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
612
        # TODO: Make sure that this list doesn't contain duplicate 
613
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
614
        self.parents = self.work_tree.get_parent_ids()
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
615
        self.parent_invs = [self.basis_inv]
616
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
617
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
618
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
619
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
620
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
621
            else:
622
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
623
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
624
    def _update_builder_with_changes(self):
625
        """Update the commit builder with the data about what has changed.
626
        """
627
        # Build the revision inventory.
628
        #
629
        # This starts by creating a new empty inventory. Depending on
630
        # which files are selected for commit, and what is present in the
631
        # current tree, the new inventory is populated. inventory entries 
632
        # which are candidates for modification have their revision set to
633
        # None; inventory entries that are carried over untouched have their
634
        # revision set to their prior value.
635
        #
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
636
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
637
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
638
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
639
        # ADHB 11-07-2006
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
640
641
        specific_files = self.specific_files
642
        mutter("Selecting files for commit with filter %s", specific_files)
643
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
644
        # Build the new inventory
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
645
        self._populate_from_inventory(specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
646
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
647
        # If specific files are selected, then all un-selected files must be
648
        # recorded in their previous state. For more details, see
649
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
650
        if specific_files:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
651
            for path, old_ie in self.basis_inv.iter_entries():
652
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
653
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
654
                    continue
655
                if is_inside_any(specific_files, path):
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
656
                    # was inside the selected path, if not present it has been
657
                    # deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
658
                    continue
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
659
                if old_ie.kind == 'directory':
660
                    self._next_progress_entry()
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
661
                # not in final inv yet, was not in the selected files, so is an
662
                # entry to be preserved unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
663
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
664
                # Note: specific file commits after a merge are currently
665
                # prohibited. This test is for sanity/safety in case it's
666
                # required after that changes.
667
                if len(self.parents) > 1:
668
                    ie.revision = None
2871.1.3 by Robert Collins
* The CommitBuilder method ``record_entry_contents`` now returns summary
669
                delta, version_recorded = self.builder.record_entry_contents(
2871.1.4 by Robert Collins
Merge bzr.dev.
670
                    ie, self.parent_invs, path, self.basis_tree, None)
2871.1.3 by Robert Collins
* The CommitBuilder method ``record_entry_contents`` now returns summary
671
                if version_recorded:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
672
                    self.any_entries_changed = True
2903.2.10 by Martin Pool
make Commit.basis_delta private
673
                if delta: self._basis_delta.append(delta)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
674
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
675
    def _report_and_accumulate_deletes(self):
2903.2.6 by Martin Pool
Remove unnecessary double handling of deletions
676
        # XXX: Could the list of deleted paths and ids be instead taken from
677
        # _populate_from_inventory?
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
678
        deleted_ids = set(self.basis_inv._byid.keys()) - \
679
            set(self.builder.new_inventory._byid.keys())
680
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
681
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
682
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
683
                for file_id in deleted_ids]
684
            deleted.sort()
685
            # XXX: this is not quite directory-order sorting
686
            for path, file_id in deleted:
2903.2.10 by Martin Pool
make Commit.basis_delta private
687
                self._basis_delta.append((path, None, file_id, None))
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
688
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
689
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
690
    def _populate_from_inventory(self, specific_files):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
691
        """Populate the CommitBuilder by walking the working tree inventory."""
692
        if self.strict:
693
            # raise an exception as soon as we find a single unknown.
694
            for unknown in self.work_tree.unknowns():
695
                raise StrictCommitFailed()
696
               
2789.2.11 by Ian Clatworthy
remove more reporting stuff
697
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
698
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
699
        # A tree of paths that have been deleted. E.g. if foo/bar has been
700
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
701
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
702
        # XXX: Note that entries may have the wrong kind because the entry does
703
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
704
        work_inv = self.work_tree.inventory
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
705
        entries = work_inv.iter_entries_by_dir(
706
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
707
        for path, existing_ie in entries:
708
            file_id = existing_ie.file_id
709
            name = existing_ie.name
710
            parent_id = existing_ie.parent_id
711
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
712
            if kind == 'directory':
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
713
                self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
714
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
715
            # The deleted path ids are also recorded so they can be explicitly
716
            # unversioned later.
717
            if deleted_paths:
718
                path_segments = splitpath(path)
719
                deleted_dict = deleted_paths
720
                for segment in path_segments:
721
                    deleted_dict = deleted_dict.get(segment, None)
722
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
723
                        # We either took a path not present in the dict
724
                        # (deleted_dict was None), or we've reached an empty
725
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
726
                        break
727
                else:
728
                    deleted_dict = None
729
                if deleted_dict is not None:
730
                    # the path has a deleted parent, do not add it.
731
                    continue
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
732
            content_summary = self.work_tree.path_content_summary(path)
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
733
            # Note that when a filter of specific files is given, we must only
734
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
735
            if not specific_files or is_inside_any(specific_files, path):
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
736
                if content_summary[0] == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
737
                    if not deleted_paths:
738
                        # path won't have been split yet.
739
                        path_segments = splitpath(path)
740
                    deleted_dict = deleted_paths
741
                    for segment in path_segments:
742
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
743
                    self.reporter.missing(path)
744
                    deleted_ids.append(file_id)
745
                    continue
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
746
            # TODO: have the builder do the nested commit just-in-time IF and
747
            # only if needed.
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
748
            if content_summary[0] == 'tree-reference':
749
                # enforce repository nested tree policy.
750
                if (not self.work_tree.supports_tree_reference() or
751
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
752
                    not self.branch.repository._format.supports_tree_reference):
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
753
                    content_summary = ('directory',) + content_summary[1:]
754
            kind = content_summary[0]
755
            # TODO: specific_files filtering before nested tree processing
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
756
            if kind == 'tree-reference':
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
757
                if self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
758
                    nested_revision_id = self._commit_nested_tree(
759
                        file_id, path)
760
                    content_summary = content_summary[:3] + (
761
                        nested_revision_id,)
762
                else:
763
                    content_summary = content_summary[:3] + (
764
                        self.work_tree.get_reference_revision(file_id),)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
765
766
            # Record an entry for this item
767
            # Note: I don't particularly want to have the existing_ie
768
            # parameter but the test suite currently (28-Jun-07) breaks
769
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
770
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
771
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
772
                parent_id, definitely_changed, existing_ie, report_changes,
773
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
774
775
        # Unversion IDs that were found to be deleted
776
        self.work_tree.unversion(deleted_ids)
777
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
778
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
779
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
780
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
781
        # FIXME: be more comprehensive here:
782
        # this works when both trees are in --trees repository,
783
        # but when both are bound to a different repository,
784
        # it fails; a better way of approaching this is to 
785
        # finally implement the explicit-caches approach design
786
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
787
        if sub_tree.branch.repository.has_same_location(
788
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
789
            sub_tree.branch.repository = \
790
                self.work_tree.branch.repository
791
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
792
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
793
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
794
                message_callback=self.message_callback,
795
                timestamp=self.timestamp, timezone=self.timezone,
796
                committer=self.committer,
797
                allow_pointless=self.allow_pointless,
798
                strict=self.strict, verbose=self.verbose,
799
                local=self.local, reporter=self.reporter)
800
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
801
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
802
803
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
804
        parent_id, definitely_changed, existing_ie, report_changes,
805
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
806
        "Record the new inventory entry for a path if any."
807
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
808
        # mutter('%s selected for commit', path)
809
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
810
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
811
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
812
            ie = existing_ie.copy()
813
            ie.revision = None
2871.1.3 by Robert Collins
* The CommitBuilder method ``record_entry_contents`` now returns summary
814
        delta, version_recorded = self.builder.record_entry_contents(ie,
2871.1.4 by Robert Collins
Merge bzr.dev.
815
            self.parent_invs, path, self.work_tree, content_summary)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
816
        if delta:
2903.2.10 by Martin Pool
make Commit.basis_delta private
817
            self._basis_delta.append(delta)
2871.1.3 by Robert Collins
* The CommitBuilder method ``record_entry_contents`` now returns summary
818
        if version_recorded:
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
819
            self.any_entries_changed = True
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
820
        if report_changes:
821
            self._report_change(ie, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
822
        return ie
823
824
    def _report_change(self, ie, path):
825
        """Report a change to the user.
826
827
        The change that has occurred is described relative to the basis
828
        inventory.
829
        """
830
        if (self.basis_inv.has_id(ie.file_id)):
831
            basis_ie = self.basis_inv[ie.file_id]
832
        else:
833
            basis_ie = None
834
        change = ie.describe_change(basis_ie, ie)
835
        if change in (InventoryEntry.RENAMED, 
836
            InventoryEntry.MODIFIED_AND_RENAMED):
837
            old_path = self.basis_inv.id2path(ie.file_id)
838
            self.reporter.renamed(change, old_path, path)
839
        else:
840
            self.reporter.snapshot_change(change, path)
841
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
842
    def _set_progress_stage(self, name, entries_title=None):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
843
        """Set the progress stage and emit an update to the progress bar."""
844
        self.pb_stage_name = name
845
        self.pb_stage_count += 1
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
846
        self.pb_entries_title = entries_title
847
        if entries_title is not None:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
848
            self.pb_entries_count = 0
849
            self.pb_entries_total = '?'
850
        self._emit_progress()
851
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
852
    def _next_progress_entry(self):
853
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
854
        self.pb_entries_count += 1
855
        self._emit_progress()
856
857
    def _emit_progress(self):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
858
        if self.pb_entries_title:
859
            if self.pb_entries_total == '?':
860
                text = "%s [%s %d] - Stage" % (self.pb_stage_name,
861
                    self.pb_entries_title, self.pb_entries_count)
862
            else:
863
                text = "%s [%s %d/%s] - Stage" % (self.pb_stage_name,
864
                    self.pb_entries_title, self.pb_entries_count,
865
                    str(self.pb_entries_total))
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
866
        else:
867
            text = "%s - Stage" % (self.pb_stage_name)
868
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
869