~bzr-pqm/bzr/bzr.dev

2018.18.22 by Martin Pool
merge bzr.dev
1
# Copyright (C) 2006, 2007 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
2018.18.22 by Martin Pool
merge bzr.dev
3
#            and others
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
4
#
5
# This program is free software; you can redistribute it and/or modify
6
# it under the terms of the GNU General Public License as published by
7
# the Free Software Foundation; either version 2 of the License, or
8
# (at your option) any later version.
9
#
10
# This program is distributed in the hope that it will be useful,
11
# but WITHOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
13
# GNU General Public License for more details.
14
#
15
# You should have received a copy of the GNU General Public License
16
# along with this program; if not, write to the Free Software
17
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18
19
"""Tests for the formatting and construction of errors."""
20
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
21
from bzrlib import (
22
    bzrdir,
23
    errors,
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
24
    symbol_versioning,
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
25
    )
26
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
27
28
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
29
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
30
class TestErrors(TestCaseWithTransport):
31
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
32
    def test_disabled_method(self):
33
        error = errors.DisabledMethod("class name")
34
        self.assertEqualDiff(
35
            "The smart server method 'class name' is disabled.", str(error))
36
2255.7.16 by John Arbash Meinel
Make sure adding a duplicate file_id raises DuplicateFileId.
37
    def test_duplicate_file_id(self):
38
        error = errors.DuplicateFileId('a_file_id', 'foo')
39
        self.assertEqualDiff('File id {a_file_id} already exists in inventory'
40
                             ' as foo', str(error))
41
2432.1.19 by Robert Collins
Ensure each HelpIndex has a unique prefix.
42
    def test_duplicate_help_prefix(self):
43
        error = errors.DuplicateHelpPrefix('foo')
44
        self.assertEqualDiff('The prefix foo is in the help search path twice.',
45
            str(error))
46
2550.2.3 by Robert Collins
Add require_api API.
47
    def test_incompatibleAPI(self):
48
        error = errors.IncompatibleAPI("module", (1, 2, 3), (4, 5, 6), (7, 8, 9))
49
        self.assertEqualDiff(
50
            'The API for "module" is not compatible with "(1, 2, 3)". '
51
            'It supports versions "(4, 5, 6)" to "(7, 8, 9)".',
52
            str(error))
53
2634.1.1 by Robert Collins
(robertc) Reinstate the accidentally backed out external_url patch.
54
    def test_in_process_transport(self):
55
        error = errors.InProcessTransport('fpp')
56
        self.assertEqualDiff(
57
            "The transport 'fpp' is only accessible within this process.",
58
            str(error))
59
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
60
    def test_inventory_modified(self):
61
        error = errors.InventoryModified("a tree to be repred")
62
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
63
            "be repred' has been modified, so a clean inventory cannot be "
64
            "read without data loss.",
65
            str(error))
66
2116.3.1 by John Arbash Meinel
Cleanup error tests
67
    def test_install_failed(self):
68
        error = errors.InstallFailed(['rev-one'])
69
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
70
        error = errors.InstallFailed(['rev-one', 'rev-two'])
71
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
72
                         str(error))
73
        error = errors.InstallFailed([None])
74
        self.assertEqual("Could not install revisions:\nNone", str(error))
75
2255.2.145 by Robert Collins
Support unbreakable locks for trees.
76
    def test_lock_active(self):
77
        error = errors.LockActive("lock description")
78
        self.assertEqualDiff("The lock for 'lock description' is in use and "
79
            "cannot be broken.",
80
            str(error))
81
2535.3.4 by Andrew Bennetts
Simple implementation of Knit.insert_data_stream.
82
    def test_knit_data_stream_incompatible(self):
83
        error = errors.KnitDataStreamIncompatible(
84
            'stream format', 'target format')
85
        self.assertEqual('Cannot insert knit data stream of format '
86
                         '"stream format" into knit of format '
87
                         '"target format".', str(error))
88
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
89
    def test_knit_header_error(self):
90
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
91
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
2745.3.2 by Daniel Watkins
Updated tests to reflect new error text.
92
                         " for file \"path/to/file\".", str(error))
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
93
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
94
    def test_knit_index_unknown_method(self):
95
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
96
                                              ['bad', 'no-eol'])
97
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
98
                         " known method in options: ['bad', 'no-eol']",
99
                         str(error))
100
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
101
    def test_medium_not_connected(self):
102
        error = errors.MediumNotConnected("a medium")
103
        self.assertEqualDiff(
104
            "The medium 'a medium' is not connected.", str(error))
105
        
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
106
    def test_no_repo(self):
107
        dir = bzrdir.BzrDir.create(self.get_url())
108
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
109
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
110
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
111
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
112
    def test_no_smart_medium(self):
113
        error = errors.NoSmartMedium("a transport")
114
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
115
            "smart protocol.",
116
            str(error))
117
2432.1.4 by Robert Collins
Add an explicit error for missing help topics.
118
    def test_no_help_topic(self):
119
        error = errors.NoHelpTopic("topic")
120
        self.assertEqualDiff("No help could be found for 'topic'. "
121
            "Please use 'bzr help topics' to obtain a list of topics.",
122
            str(error))
123
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
124
    def test_no_such_id(self):
125
        error = errors.NoSuchId("atree", "anid")
2745.3.2 by Daniel Watkins
Updated tests to reflect new error text.
126
        self.assertEqualDiff("The file id \"anid\" is not present in the tree "
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
127
            "atree.",
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
128
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
129
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
130
    def test_no_such_revision_in_tree(self):
131
        error = errors.NoSuchRevisionInTree("atree", "anid")
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
132
        self.assertEqualDiff("The revision id {anid} is not present in the"
133
                             " tree atree.", str(error))
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
134
        self.assertIsInstance(error, errors.NoSuchRevision)
135
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
136
    def test_not_write_locked(self):
137
        error = errors.NotWriteLocked('a thing to repr')
138
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
139
            "to be.",
140
            str(error))
141
2353.3.10 by John Arbash Meinel
Cleanup errors, and change ReadOnlyLockError to pass around more details.
142
    def test_read_only_lock_error(self):
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
143
        error = self.applyDeprecated(symbol_versioning.zero_ninetytwo,
144
            errors.ReadOnlyLockError, 'filename', 'error message')
2353.3.10 by John Arbash Meinel
Cleanup errors, and change ReadOnlyLockError to pass around more details.
145
        self.assertEqualDiff("Cannot acquire write lock on filename."
146
                             " error message", str(error))
147
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
148
    def test_lock_failed(self):
149
        error = errors.LockFailed('http://canonical.com/', 'readonly transport')
150
        self.assertEqualDiff("Cannot lock http://canonical.com/: readonly transport",
151
            str(error))
152
        self.assertFalse(error.internal_error)
153
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
154
    def test_too_many_concurrent_requests(self):
155
        error = errors.TooManyConcurrentRequests("a medium")
156
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
157
            "request limit. Be sure to finish_writing and finish_reading on "
2018.5.134 by Andrew Bennetts
Fix the TooManyConcurrentRequests error message.
158
            "the currently open request.",
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
159
            str(error))
160
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
161
    def test_unknown_hook(self):
162
        error = errors.UnknownHook("branch", "foo")
163
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
164
            " of bzrlib.",
165
            str(error))
166
        error = errors.UnknownHook("tree", "bar")
167
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
168
            " of bzrlib.",
169
            str(error))
170
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
171
    def test_up_to_date(self):
172
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
173
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
174
                             "format 0.0.4 is already at the most "
175
                             "recent format.",
176
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
177
178
    def test_corrupt_repository(self):
179
        repo = self.make_repository('.')
180
        error = errors.CorruptRepository(repo)
181
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
182
                             "Please run bzr reconcile on this repository." %
183
                             repo.bzrdir.root_transport.base,
184
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
185
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
186
    def test_read_error(self):
187
        # a unicode path to check that %r is being used.
188
        path = u'a path'
189
        error = errors.ReadError(path)
190
        self.assertEqualDiff("Error reading from u'a path'.", str(error))
191
2592.1.7 by Robert Collins
A validate that goes boom.
192
    def test_bad_index_format_signature(self):
193
        error = errors.BadIndexFormatSignature("foo", "bar")
194
        self.assertEqual("foo is not an index of type bar.",
195
            str(error))
2052.6.2 by Robert Collins
Merge bzr.dev.
196
2592.1.11 by Robert Collins
Detect truncated indices.
197
    def test_bad_index_data(self):
198
        error = errors.BadIndexData("foo")
199
        self.assertEqual("Error in data for index foo.",
200
            str(error))
201
2592.1.15 by Robert Collins
Detect duplicate key insertion.
202
    def test_bad_index_duplicate_key(self):
203
        error = errors.BadIndexDuplicateKey("foo", "bar")
204
        self.assertEqual("The key 'foo' is already in index 'bar'.",
205
            str(error))
206
2592.1.12 by Robert Collins
Handle basic node adds.
207
    def test_bad_index_key(self):
208
        error = errors.BadIndexKey("foo")
209
        self.assertEqual("The key 'foo' is not a valid key.",
210
            str(error))
211
2592.1.10 by Robert Collins
Make validate detect node reference parsing errors.
212
    def test_bad_index_options(self):
213
        error = errors.BadIndexOptions("foo")
214
        self.assertEqual("Could not parse options for index foo.",
215
            str(error))
216
2592.1.12 by Robert Collins
Handle basic node adds.
217
    def test_bad_index_value(self):
218
        error = errors.BadIndexValue("foo")
219
        self.assertEqual("The value 'foo' is not a valid value.",
220
            str(error))
221
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
222
    def test_bzrnewerror_is_deprecated(self):
223
        class DeprecatedError(errors.BzrNewError):
224
            pass
2067.3.6 by Martin Pool
Update deprecation version
225
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
226
             'please convert DeprecatedError to use BzrError instead'],
227
            DeprecatedError)
228
229
    def test_bzrerror_from_literal_string(self):
230
        # Some code constructs BzrError from a literal string, in which case
231
        # no further formatting is done.  (I'm not sure raising the base class
232
        # is a great idea, but if the exception is not intended to be caught
233
        # perhaps no more is needed.)
234
        try:
235
            raise errors.BzrError('this is my errors; %d is not expanded')
236
        except errors.BzrError, e:
237
            self.assertEqual('this is my errors; %d is not expanded', str(e))
238
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
239
    def test_reading_completed(self):
240
        error = errors.ReadingCompleted("a request")
241
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
242
            "finish_reading called upon it - the request has been completed and"
243
            " no more data may be read.",
244
            str(error))
245
246
    def test_writing_completed(self):
247
        error = errors.WritingCompleted("a request")
248
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
249
            "finish_writing called upon it - accept bytes may not be called "
250
            "anymore.",
251
            str(error))
252
253
    def test_writing_not_completed(self):
254
        error = errors.WritingNotComplete("a request")
255
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
256
            "finish_writing called upon it - until the write phase is complete"
257
            " no data may be read.",
258
            str(error))
259
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
260
    def test_transport_not_possible(self):
261
        error = errors.TransportNotPossible('readonly', 'original error')
262
        self.assertEqualDiff('Transport operation not possible:'
263
                         ' readonly original error', str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
264
265
    def assertSocketConnectionError(self, expected, *args, **kwargs):
266
        """Check the formatting of a SocketConnectionError exception"""
267
        e = errors.SocketConnectionError(*args, **kwargs)
268
        self.assertEqual(expected, str(e))
269
270
    def test_socket_connection_error(self):
271
        """Test the formatting of SocketConnectionError"""
272
273
        # There should be a default msg about failing to connect
274
        # we only require a host name.
275
        self.assertSocketConnectionError(
276
            'Failed to connect to ahost',
277
            'ahost')
278
279
        # If port is None, we don't put :None
280
        self.assertSocketConnectionError(
281
            'Failed to connect to ahost',
282
            'ahost', port=None)
283
        # But if port is supplied we include it
284
        self.assertSocketConnectionError(
285
            'Failed to connect to ahost:22',
286
            'ahost', port=22)
287
288
        # We can also supply extra information about the error
289
        # with or without a port
290
        self.assertSocketConnectionError(
291
            'Failed to connect to ahost:22; bogus error',
292
            'ahost', port=22, orig_error='bogus error')
293
        self.assertSocketConnectionError(
294
            'Failed to connect to ahost; bogus error',
295
            'ahost', orig_error='bogus error')
296
        # An exception object can be passed rather than a string
297
        orig_error = ValueError('bad value')
298
        self.assertSocketConnectionError(
299
            'Failed to connect to ahost; %s' % (str(orig_error),),
300
            host='ahost', orig_error=orig_error)
301
302
        # And we can supply a custom failure message
303
        self.assertSocketConnectionError(
304
            'Unable to connect to ssh host ahost:444; my_error',
305
            host='ahost', port=444, msg='Unable to connect to ssh host',
306
            orig_error='my_error')
307
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
308
    def test_malformed_bug_identifier(self):
309
        """Test the formatting of MalformedBugIdentifier."""
310
        error = errors.MalformedBugIdentifier('bogus', 'reason for bogosity')
311
        self.assertEqual(
312
            "Did not understand bug identifier bogus: reason for bogosity",
313
            str(error))
314
315
    def test_unknown_bug_tracker_abbreviation(self):
316
        """Test the formatting of UnknownBugTrackerAbbreviation."""
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
317
        branch = self.make_branch('some_branch')
318
        error = errors.UnknownBugTrackerAbbreviation('xxx', branch)
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
319
        self.assertEqual(
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
320
            "Cannot find registered bug tracker called xxx on %s" % branch,
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
321
            str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
322
2018.5.163 by Andrew Bennetts
Deal with various review comments from Robert.
323
    def test_unexpected_smart_server_response(self):
324
        e = errors.UnexpectedSmartServerResponse(('not yes',))
325
        self.assertEqual(
326
            "Could not understand response from smart server: ('not yes',)",
327
            str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
328
2506.2.1 by Andrew Bennetts
Start implementing container format reading and writing.
329
    def test_unknown_container_format(self):
330
        """Test the formatting of UnknownContainerFormatError."""
331
        e = errors.UnknownContainerFormatError('bad format string')
332
        self.assertEqual(
333
            "Unrecognised container format: 'bad format string'",
334
            str(e))
335
336
    def test_unexpected_end_of_container(self):
337
        """Test the formatting of UnexpectedEndOfContainerError."""
338
        e = errors.UnexpectedEndOfContainerError()
339
        self.assertEqual(
340
            "Unexpected end of container stream", str(e))
341
342
    def test_unknown_record_type(self):
343
        """Test the formatting of UnknownRecordTypeError."""
344
        e = errors.UnknownRecordTypeError("X")
345
        self.assertEqual(
346
            "Unknown record type: 'X'",
347
            str(e))
348
2506.3.1 by Andrew Bennetts
More progress:
349
    def test_invalid_record(self):
350
        """Test the formatting of InvalidRecordError."""
351
        e = errors.InvalidRecordError("xxx")
352
        self.assertEqual(
353
            "Invalid record: xxx",
354
            str(e))
355
2506.2.6 by Andrew Bennetts
Add validate method to ContainerReader and BytesRecordReader.
356
    def test_container_has_excess_data(self):
357
        """Test the formatting of ContainerHasExcessDataError."""
358
        e = errors.ContainerHasExcessDataError("excess bytes")
359
        self.assertEqual(
360
            "Container has data after end marker: 'excess bytes'",
361
            str(e))
362
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
363
    def test_duplicate_record_name_error(self):
364
        """Test the formatting of DuplicateRecordNameError."""
365
        e = errors.DuplicateRecordNameError(u"n\xe5me".encode('utf-8'))
366
        self.assertEqual(
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
367
            "Container has multiple records with the same name: n\xc3\xa5me",
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
368
            str(e))
2854.1.1 by Martin Pool
Fix "unprintable error" message for BzrCheckError and others
369
        
370
    def test_check_error(self):
371
        # This has a member called 'message', which is problematic in
372
        # python2.5 because that is a slot on the base Exception class
373
        e = errors.BzrCheckError('example check failure')
374
        self.assertEqual(
375
            "Internal check failed: example check failure",
376
            str(e))
377
        self.assertTrue(e.internal_error)
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
378
2535.3.40 by Andrew Bennetts
Tidy up more XXXs.
379
    def test_repository_data_stream_error(self):
380
        """Test the formatting of RepositoryDataStreamError."""
381
        e = errors.RepositoryDataStreamError(u"my reason")
382
        self.assertEqual(
383
            "Corrupt or incompatible data stream: my reason", str(e))
384
2978.2.1 by Alexander Belchenko
fix formatting of ImmortalPendingDeletion error message.
385
    def test_immortal_pending_deletion_message(self):
386
        err = errors.ImmortalPendingDeletion('foo')
387
        self.assertEquals(
388
            "Unable to delete transform temporary directory foo.  "
389
            "Please examine foo to see if it contains any files "
390
            "you wish to keep, and delete it when you are done.",
391
            str(err))
392
2116.3.1 by John Arbash Meinel
Cleanup error tests
393
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
394
class PassThroughError(errors.BzrError):
395
    
396
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
397
398
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
399
        errors.BzrError.__init__(self, foo=foo, bar=bar)
400
401
402
class ErrorWithBadFormat(errors.BzrError):
403
404
    _fmt = """One format specifier: %(thing)s"""
405
406
407
class ErrorWithNoFormat(errors.BzrError):
408
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
409
410
411
class TestErrorFormatting(TestCase):
412
    
413
    def test_always_str(self):
414
        e = PassThroughError(u'\xb5', 'bar')
415
        self.assertIsInstance(e.__str__(), str)
416
        # In Python str(foo) *must* return a real byte string
417
        # not a Unicode string. The following line would raise a
418
        # Unicode error, because it tries to call str() on the string
419
        # returned from e.__str__(), and it has non ascii characters
420
        s = str(e)
421
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
422
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
423
    def test_missing_format_string(self):
424
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
425
        s = self.callDeprecated(
426
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
427
                lambda x: str(x), e)
428
        ## s = str(e)
429
        self.assertEqual(s, 
430
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
431
2116.3.1 by John Arbash Meinel
Cleanup error tests
432
    def test_mismatched_format_args(self):
433
        # Even though ErrorWithBadFormat's format string does not match the
434
        # arguments we constructing it with, we can still stringify an instance
435
        # of this exception. The resulting string will say its unprintable.
436
        e = ErrorWithBadFormat(not_thing='x')
437
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
438
            str(e), 'Unprintable exception ErrorWithBadFormat')