~bzr-pqm/bzr/bzr.dev

2374.2.2 by John Arbash Meinel
Fix the small bug that ie.snapshot() didn't think about kind changes.
1
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# The newly committed revision is going to have a shape corresponding
19
# to that of the working inventory.  Files that are not in the
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
28
# recorded.  For each parent revision inventory, we check to see what
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
1959.4.2 by Aaron Bentley
Merge bzr.dev
62
    inventory,
1551.8.30 by Aaron Bentley
Tweak from review comments
63
    tree,
64
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
65
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
66
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
67
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
68
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
69
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
70
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
71
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
72
                            is_inside_or_parent_of_any,
73
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
74
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
75
from bzrlib.trace import mutter, note, warning, is_quiet
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
from bzrlib.xml5 import serializer_v5
1731.1.33 by Aaron Bentley
Revert no-special-root changes
77
from bzrlib.inventory import Inventory, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
78
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
79
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
80
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
81
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
82
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
83
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
84
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
85
86
87
class NullCommitReporter(object):
88
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
89
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
90
    def started(self, revno, revid, location=None):
91
        pass
92
93
    def snapshot_change(self, change, path):
94
        pass
95
96
    def completed(self, revno, rev_id):
97
        pass
98
99
    def deleted(self, file_id):
100
        pass
101
102
    def escaped(self, escape_count, message):
103
        pass
104
105
    def missing(self, path):
106
        pass
107
108
    def renamed(self, change, old_path, new_path):
109
        pass
110
2789.2.11 by Ian Clatworthy
remove more reporting stuff
111
    def is_verbose(self):
112
        return False
113
114
115
class ReportCommitToLog(NullCommitReporter):
116
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
117
    def _note(self, format, *args):
118
        """Output a message.
119
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
120
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
121
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
122
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
123
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
124
    def snapshot_change(self, change, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
125
        if change == 'unchanged':
126
            return
127
        if change == 'added' and path == '':
128
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
129
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
130
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
131
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
132
        if location is not None:
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
133
            location = ' to "' + unescape_for_display(location, 'utf-8') + '"'
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
134
        else:
135
            location = ''
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
136
        self._note('Committing revision %d%s.', revno, location)
137
138
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
139
        self._note('Committed revision %d.', revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
140
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
141
    def deleted(self, file_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
142
        self._note('deleted %s', file_id)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
143
144
    def escaped(self, escape_count, message):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
145
        self._note("replaced %d control characters in message", escape_count)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
146
147
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
148
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
149
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
150
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
151
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
152
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
153
    def is_verbose(self):
154
        return True
155
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
156
1189 by Martin Pool
- BROKEN: partial support for commit into weave
157
class Commit(object):
158
    """Task of committing a new revision.
159
160
    This is a MethodObject: it accumulates state as the commit is
161
    prepared, and then it is discarded.  It doesn't represent
162
    historical revisions, just the act of recording a new one.
163
164
            missing_ids
165
            Modified to hold a list of files that have been deleted from
166
            the working directory; these should be removed from the
167
            working inventory.
485 by Martin Pool
- move commit code into its own module
168
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
169
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
170
                 reporter=None,
171
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
172
        """Create a Commit object.
173
174
        :param reporter: the default reporter to use or None to decide later
175
        """
176
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
177
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
178
1189 by Martin Pool
- BROKEN: partial support for commit into weave
179
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
180
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
181
               timestamp=None,
182
               timezone=None,
183
               committer=None,
184
               specific_files=None,
185
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
186
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
187
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
188
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
189
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
190
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
191
               local=False,
192
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
193
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
194
               message_callback=None,
195
               recursive='down'):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
196
        """Commit working copy as a new revision.
197
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
198
        :param message: the commit message (it or message_callback is required)
199
200
        :param timestamp: if not None, seconds-since-epoch for a
201
            postdated/predated commit.
202
203
        :param specific_files: If true, commit only those files.
204
205
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
206
            Useful for test or import commands that need to tightly
207
            control what revisions are assigned.  If you duplicate
208
            a revision id that exists elsewhere it is your own fault.
209
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
210
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
211
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
212
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
213
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
214
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
215
            contains unknown files.
216
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
217
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
218
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
219
        :param reporter: the reporter to use or None for the default
220
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
221
        :param recursive: If set to 'down', commit in any subtrees that have
222
            pending changes of any sort during this commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
223
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
224
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
225
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
226
        if working_tree is None:
227
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
228
        else:
229
            self.work_tree = working_tree
230
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
231
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
232
                if not self.branch.repository.supports_rich_root():
233
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
234
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
235
            if message is not None:
236
                if isinstance(message, str):
237
                    message = message.decode(bzrlib.user_encoding)
238
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
239
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
240
                raise BzrError("The message or message_callback keyword"
241
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
242
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
243
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
244
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
245
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
246
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
247
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
248
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
249
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
250
        self.recursive = recursive
251
        self.revprops = revprops
252
        self.message_callback = message_callback
253
        self.timestamp = timestamp
254
        self.timezone = timezone
255
        self.committer = committer
256
        self.strict = strict
257
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
258
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
259
        self.work_tree.lock_write()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
260
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
261
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
262
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
263
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
264
            # Cannot commit with conflicts present.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
265
            if len(self.work_tree.conflicts()) > 0:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
266
                raise ConflictsInTree
267
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
268
            # Setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
269
            self._check_bound_branch()
270
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
271
            # Check that the working tree is up to date
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
272
            old_revno, new_revno = self._check_out_of_date_tree()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
273
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
274
            # Complete configuration setup
275
            if reporter is not None:
276
                self.reporter = reporter
277
            elif self.reporter is None:
278
                self.reporter = self._select_reporter()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
279
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
280
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
281
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
282
            # If provided, ensure the specified files are versioned
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
283
            if specific_files is not None:
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
284
                # Note: We don't actually need the IDs here. This routine
285
                # is being called because it raises PathNotVerisonedError
286
                # as a side effect of finding the IDs.
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
287
                # XXX: Dont we have filter_unversioned to do this more
288
                # cheaply?
289
                tree.find_ids_across_trees(specific_files,
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
290
                                           [self.basis_tree, self.work_tree])
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
291
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
292
            # Setup the progress bar. As the number of files that need to be
293
            # committed in unknown, progress is reported as stages.
294
            # We keep track of entries separately though and include that
295
            # information in the progress bar during the relevant stages.
296
            self.pb_stage_name = ""
297
            self.pb_stage_count = 0
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
298
            self.pb_stage_total = 5
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
299
            if self.bound_branch:
300
                self.pb_stage_total += 1
301
            self.pb.show_pct = False
302
            self.pb.show_spinner = False
303
            self.pb.show_eta = False
304
            self.pb.show_count = True
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
305
            self.pb.show_bar = True
1189 by Martin Pool
- BROKEN: partial support for commit into weave
306
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
307
            # After a merge, a selected file commit is not supported.
308
            # See 'bzr help merge' for an explanation as to why.
309
            self.basis_inv = self.basis_tree.inventory
1223 by Martin Pool
- store inventories in weave
310
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
311
            if len(self.parents) > 1 and self.specific_files:
1551.15.9 by Aaron Bentley
Better error for selected-file commit of merges
312
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
313
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
314
            # Collect the changes
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
315
            self._set_progress_stage("Collecting changes",
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
316
                    entries_title="Directory")
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
317
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
318
                self.config, timestamp, timezone, committer, revprops, rev_id)
2659.3.5 by NamNguyen
merge with bzr.dev
319
            
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
320
            try:
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
321
                # find the location being committed to
322
                if self.bound_branch:
323
                    master_location = self.master_branch.base
324
                else:
325
                    master_location = self.branch.base
326
327
                # report the start of the commit
328
                self.reporter.started(new_revno, self.rev_id, master_location)
329
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
330
                self._update_builder_with_changes()
331
                self._check_pointless()
332
333
                # TODO: Now the new inventory is known, check for conflicts.
334
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
335
                # weave lines, because nothing should be recorded until it is known
336
                # that commit will succeed.
2617.6.9 by Robert Collins
Merge bzr.dev.
337
                self._set_progress_stage("Saving data locally")
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
338
                self.builder.finish_inventory()
339
340
                # Prompt the user for a commit message if none provided
341
                message = message_callback(self)
342
                assert isinstance(message, unicode), type(message)
343
                self.message = message
344
                self._escape_commit_message()
345
346
                # Add revision data to the local branch
347
                self.rev_id = self.builder.commit(self.message)
2659.3.5 by NamNguyen
merge with bzr.dev
348
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
349
            except:
2749.3.1 by Jelmer Vernooij
Add CommitBuilder.abort().
350
                self.builder.abort()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
351
                raise
352
2659.3.6 by NamNguyen
branch_implementations/test_commit.py:
353
            self._process_pre_hooks(old_revno, new_revno)
354
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
355
            # Upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
356
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
357
            if self.bound_branch:
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
358
                self._set_progress_stage("Uploading data to master branch")
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
359
                self.master_branch.repository.fetch(self.branch.repository,
360
                                                    revision_id=self.rev_id)
361
                # now the master has the revision data
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
362
                # 'commit' to the master first so a timeout here causes the
363
                # local branch to be out of date
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
364
                self.master_branch.set_last_revision_info(new_revno,
365
                                                          self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
366
367
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
368
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
369
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
370
            # Make the working tree up to date with the branch
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
371
            self._set_progress_stage("Updating the working tree")
2041.1.5 by John Arbash Meinel
CommitBuilder.get_tree => CommitBuilder.revision_tree
372
            rev_tree = self.builder.revision_tree()
2041.1.2 by John Arbash Meinel
Update WorkingTree.set_parent_trees() to directly cache inv.
373
            self.work_tree.set_parent_trees([(self.rev_id, rev_tree)])
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
374
            self.reporter.completed(new_revno, self.rev_id)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
375
            self._process_post_hooks(old_revno, new_revno)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
376
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
377
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
378
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
379
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
380
    def _select_reporter(self):
381
        """Select the CommitReporter to use."""
382
        if is_quiet():
383
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
384
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
385
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
386
    def _any_real_changes(self):
387
        """Are there real changes between new_inventory and basis?
388
389
        For trees without rich roots, inv.root.revision changes every commit.
390
        But if that is the only change, we want to treat it as though there
391
        are *no* changes.
392
        """
393
        new_entries = self.builder.new_inventory.iter_entries()
394
        basis_entries = self.basis_inv.iter_entries()
395
        new_path, new_root_ie = new_entries.next()
396
        basis_path, basis_root_ie = basis_entries.next()
397
398
        # This is a copy of InventoryEntry.__eq__ only leaving out .revision
399
        def ie_equal_no_revision(this, other):
400
            return ((this.file_id == other.file_id)
401
                    and (this.name == other.name)
402
                    and (this.symlink_target == other.symlink_target)
403
                    and (this.text_sha1 == other.text_sha1)
404
                    and (this.text_size == other.text_size)
405
                    and (this.text_id == other.text_id)
406
                    and (this.parent_id == other.parent_id)
407
                    and (this.kind == other.kind)
408
                    and (this.executable == other.executable)
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
409
                    and (this.reference_revision == other.reference_revision)
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
410
                    )
411
        if not ie_equal_no_revision(new_root_ie, basis_root_ie):
412
            return True
413
414
        for new_ie, basis_ie in zip(new_entries, basis_entries):
415
            if new_ie != basis_ie:
416
                return True
417
418
        # No actual changes present
419
        return False
420
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
421
    def _check_pointless(self):
422
        if self.allow_pointless:
423
            return
424
        # A merge with no effect on files
425
        if len(self.parents) > 1:
426
            return
427
        # work around the fact that a newly-initted tree does differ from its
428
        # basis
1731.1.49 by Aaron Bentley
Merge bzr.dev
429
        if len(self.basis_inv) == 0 and len(self.builder.new_inventory) == 1:
430
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
431
        # Shortcut, if the number of entries changes, then we obviously have
432
        # a change
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
433
        if len(self.builder.new_inventory) != len(self.basis_inv):
434
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
435
        # If length == 1, then we only have the root entry. Which means
436
        # that there is no real difference (only the root could be different)
437
        if (len(self.builder.new_inventory) != 1 and self._any_real_changes()):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
438
            return
439
        raise PointlessCommit()
440
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
441
    def _check_bound_branch(self):
442
        """Check to see if the local branch is bound.
443
444
        If it is bound, then most of the commit will actually be
445
        done using the remote branch as the target branch.
446
        Only at the end will the local branch be updated.
447
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
448
        if self.local and not self.branch.get_bound_location():
449
            raise errors.LocalRequiresBoundBranch()
450
451
        if not self.local:
452
            self.master_branch = self.branch.get_master_branch()
453
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
454
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
455
            # make this branch the reference branch for out of date checks.
456
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
457
            return
458
459
        # If the master branch is bound, we must fail
460
        master_bound_location = self.master_branch.get_bound_location()
461
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
462
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
463
                    self.master_branch, master_bound_location)
464
465
        # TODO: jam 20051230 We could automatically push local
466
        #       commits to the remote branch if they would fit.
467
        #       But for now, just require remote to be identical
468
        #       to local.
469
        
470
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
471
        master_info = self.master_branch.last_revision_info()
472
        local_info = self.branch.last_revision_info()
473
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
474
            raise errors.BoundBranchOutOfDate(self.branch,
475
                    self.master_branch)
476
477
        # Now things are ready to change the master branch
478
        # so grab the lock
479
        self.bound_branch = self.branch
480
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
481
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
482
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
483
    def _check_out_of_date_tree(self):
484
        """Check that the working tree is up to date.
485
486
        :return: old_revision_number,new_revision_number tuple
487
        """
488
        try:
489
            first_tree_parent = self.work_tree.get_parent_ids()[0]
490
        except IndexError:
491
            # if there are no parents, treat our parent as 'None'
492
            # this is so that we still consider the master branch
493
            # - in a checkout scenario the tree may have no
494
            # parents but the branch may do.
495
            first_tree_parent = bzrlib.revision.NULL_REVISION
496
        old_revno, master_last = self.master_branch.last_revision_info()
497
        if master_last != first_tree_parent:
498
            if master_last != bzrlib.revision.NULL_REVISION:
499
                raise errors.OutOfDateTree(self.work_tree)
500
        if self.branch.repository.has_revision(first_tree_parent):
501
            new_revno = old_revno + 1
502
        else:
503
            # ghost parents never appear in revision history.
504
            new_revno = 1
505
        return old_revno,new_revno
506
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
507
    def _process_pre_hooks(self, old_revno, new_revno):
508
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
509
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
510
        self._process_hooks("pre_commit", old_revno, new_revno)
511
512
    def _process_post_hooks(self, old_revno, new_revno):
513
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
514
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
515
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
516
        # old style commit hooks - should be deprecated ? (obsoleted in
517
        # 0.15)
518
        if self.config.post_commit() is not None:
519
            hooks = self.config.post_commit().split(' ')
520
            # this would be nicer with twisted.python.reflect.namedAny
521
            for hook in hooks:
522
                result = eval(hook + '(branch, rev_id)',
523
                              {'branch':self.branch,
524
                               'bzrlib':bzrlib,
525
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
526
        # process new style post commit hooks
527
        self._process_hooks("post_commit", old_revno, new_revno)
528
529
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
530
        if not Branch.hooks[hook_name]:
531
            return
532
        
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
533
        # new style commit hooks:
534
        if not self.bound_branch:
535
            hook_master = self.branch
536
            hook_local = None
537
        else:
538
            hook_master = self.master_branch
539
            hook_local = self.branch
540
        # With bound branches, when the master is behind the local branch,
541
        # the 'old_revno' and old_revid values here are incorrect.
542
        # XXX: FIXME ^. RBC 20060206
543
        if self.parents:
544
            old_revid = self.parents[0]
545
        else:
546
            old_revid = bzrlib.revision.NULL_REVISION
2659.3.9 by NamNguyen
branch.py:
547
        
548
        if hook_name == "pre_commit":
549
            future_tree = self.builder.revision_tree()
550
            tree_delta = future_tree.changes_from(self.basis_tree,
551
                                             include_root=True)
552
        
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
553
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
554
            # show the running hook in the progress bar. As hooks may
555
            # end up doing nothing (e.g. because they are not configured by
556
            # the user) this is still showing progress, not showing overall
557
            # actions - its up to each plugin to show a UI if it want's to
558
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
559
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
560
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
561
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
562
            if 'hooks' in debug.debug_flags:
563
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
564
            if hook_name == "post_commit":
565
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
566
                     self.rev_id)
567
            elif hook_name == "pre_commit":
568
                hook(hook_local, hook_master,
569
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
570
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
571
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
572
    def _cleanup(self):
573
        """Cleanup any open locks, progress bars etc."""
574
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
575
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
576
                    self.work_tree.unlock,
577
                    self.pb.finished]
578
        found_exception = None
579
        for cleanup in cleanups:
580
            try:
581
                cleanup()
582
            # we want every cleanup to run no matter what.
583
            # so we have a catchall here, but we will raise the
584
            # last encountered exception up the stack: and
585
            # typically this will be useful enough.
586
            except Exception, e:
587
                found_exception = e
588
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
589
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
590
            # trashed, e is our sure-to-work exception even though it loses the
591
            # full traceback. XXX: RBC 20060421 perhaps we could check the
592
            # exc_info and if its the same one do a plain raise otherwise 
593
            # 'raise e' as we do now.
594
            raise e
595
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
596
    def _cleanup_bound_branch(self):
597
        """Executed at the end of a try/finally to cleanup a bound branch.
598
599
        If the branch wasn't bound, this is a no-op.
600
        If it was, it resents self.branch to the local branch, instead
601
        of being the master.
602
        """
603
        if not self.bound_branch:
604
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
605
        if self.master_locked:
606
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
607
1390 by Robert Collins
pair programming worx... merge integration and weave
608
    def _escape_commit_message(self):
609
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
610
        # FIXME: RBC 20060419 this should be done by the revision
611
        # serialiser not by commit. Then we can also add an unescaper
612
        # in the deserializer and start roundtripping revision messages
613
        # precisely. See repository_implementations/test_repository.py
614
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
615
        # Python strings can include characters that can't be
616
        # represented in well-formed XML; escape characters that
617
        # aren't listed in the XML specification
618
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
619
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
620
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
621
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
622
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
623
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
624
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
625
626
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
627
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
628
        # TODO: Make sure that this list doesn't contain duplicate 
629
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
630
        self.parents = self.work_tree.get_parent_ids()
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
631
        self.parent_invs = [self.basis_inv]
632
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
633
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
634
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
635
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
636
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
637
            else:
638
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
639
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
640
    def _update_builder_with_changes(self):
641
        """Update the commit builder with the data about what has changed.
642
        """
643
        # Build the revision inventory.
644
        #
645
        # This starts by creating a new empty inventory. Depending on
646
        # which files are selected for commit, and what is present in the
647
        # current tree, the new inventory is populated. inventory entries 
648
        # which are candidates for modification have their revision set to
649
        # None; inventory entries that are carried over untouched have their
650
        # revision set to their prior value.
651
        #
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
652
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
653
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
654
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
655
        # ADHB 11-07-2006
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
656
657
        specific_files = self.specific_files
658
        mutter("Selecting files for commit with filter %s", specific_files)
659
660
        # Check and warn about old CommitBuilders
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
661
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
662
            symbol_versioning.warn('CommitBuilders should support recording'
663
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
664
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
665
            self.builder.new_inventory.add(self.basis_inv.root.copy())
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
666
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
667
        # Build the new inventory
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
668
        self._populate_from_inventory(specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
669
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
670
        # If specific files are selected, then all un-selected files must be
671
        # recorded in their previous state. For more details, see
672
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
673
        if specific_files:
674
            for path, new_ie in self.basis_inv.iter_entries():
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
675
                if new_ie.file_id in self.builder.new_inventory:
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
676
                    continue
677
                if is_inside_any(specific_files, path):
678
                    continue
679
                ie = new_ie.copy()
680
                ie.revision = None
681
                self.builder.record_entry_contents(ie, self.parent_invs, path,
682
                                                   self.basis_tree)
683
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
684
        # Report what was deleted.
685
        if self.reporter.is_verbose():
686
            for path, ie in self.basis_inv.iter_entries():
687
                if ie.file_id not in self.builder.new_inventory:
688
                    self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
689
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
690
    def _populate_from_inventory(self, specific_files):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
691
        """Populate the CommitBuilder by walking the working tree inventory."""
692
        if self.strict:
693
            # raise an exception as soon as we find a single unknown.
694
            for unknown in self.work_tree.unknowns():
695
                raise StrictCommitFailed()
696
               
2789.2.11 by Ian Clatworthy
remove more reporting stuff
697
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
698
        deleted_ids = []
699
        deleted_paths = set()
700
        work_inv = self.work_tree.inventory
701
        assert work_inv.root is not None
2829.1.1 by Ian Clatworthy
re-apply Aaron's fix for #94975 (Ian Clatworthy)
702
        entries = work_inv.iter_entries_by_dir()
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
703
        if not self.builder.record_root_entry:
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
704
            entries.next()
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
705
        for path, existing_ie in entries:
706
            file_id = existing_ie.file_id
707
            name = existing_ie.name
708
            parent_id = existing_ie.parent_id
709
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
710
            if kind == 'directory':
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
711
                self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
712
713
            # Skip files that have been deleted from the working tree.
714
            # The deleted files/directories are also recorded so they
715
            # can be explicitly unversioned later. Note that when a
716
            # filter of specific files is given, we must only skip/record
717
            # deleted files matching that filter.
718
            if is_inside_any(deleted_paths, path):
719
                continue
720
            if not specific_files or is_inside_any(specific_files, path):
721
                if not self.work_tree.has_filename(path):
722
                    deleted_paths.add(path)
723
                    self.reporter.missing(path)
724
                    deleted_ids.append(file_id)
725
                    continue
726
            try:
727
                kind = self.work_tree.kind(file_id)
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
728
                # TODO: specific_files filtering before nested tree processing
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
729
                if kind == 'tree-reference' and self.recursive == 'down':
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
730
                    self._commit_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
731
            except errors.NoSuchFile:
732
                pass
733
734
            # Record an entry for this item
735
            # Note: I don't particularly want to have the existing_ie
736
            # parameter but the test suite currently (28-Jun-07) breaks
737
            # without it thanks to a unicode normalisation issue. :-(
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
738
            definitely_changed = kind != existing_ie.kind 
2789.2.12 by Ian Clatworthy
reduce conditionals
739
            self._record_entry(path, file_id, specific_files, kind, name,
740
                parent_id, definitely_changed, existing_ie, report_changes)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
741
742
        # Unversion IDs that were found to be deleted
743
        self.work_tree.unversion(deleted_ids)
744
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
745
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
746
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
747
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
748
        # FIXME: be more comprehensive here:
749
        # this works when both trees are in --trees repository,
750
        # but when both are bound to a different repository,
751
        # it fails; a better way of approaching this is to 
752
        # finally implement the explicit-caches approach design
753
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
754
        if sub_tree.branch.repository.has_same_location(
755
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
756
            sub_tree.branch.repository = \
757
                self.work_tree.branch.repository
758
        try:
759
            sub_tree.commit(message=None, revprops=self.revprops,
760
                recursive=self.recursive,
761
                message_callback=self.message_callback,
762
                timestamp=self.timestamp, timezone=self.timezone,
763
                committer=self.committer,
764
                allow_pointless=self.allow_pointless,
765
                strict=self.strict, verbose=self.verbose,
766
                local=self.local, reporter=self.reporter)
767
        except errors.PointlessCommit:
768
            pass
769
770
    def _record_entry(self, path, file_id, specific_files, kind, name,
2789.2.12 by Ian Clatworthy
reduce conditionals
771
            parent_id, definitely_changed, existing_ie=None,
772
            report_changes=True):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
773
        "Record the new inventory entry for a path if any."
774
        # mutter('check %s {%s}', path, file_id)
775
        if (not specific_files or 
776
            is_inside_or_parent_of_any(specific_files, path)):
777
                # mutter('%s selected for commit', path)
778
                if definitely_changed or existing_ie is None:
779
                    ie = inventory.make_entry(kind, name, parent_id, file_id)
780
                else:
781
                    ie = existing_ie.copy()
782
                    ie.revision = None
783
        else:
784
            # mutter('%s not selected for commit', path)
785
            if self.basis_inv.has_id(file_id):
786
                ie = self.basis_inv[file_id].copy()
787
            else:
788
                # this entry is new and not being committed
789
                ie = None
790
        if ie is not None:
791
            self.builder.record_entry_contents(ie, self.parent_invs, 
792
                path, self.work_tree)
2789.2.12 by Ian Clatworthy
reduce conditionals
793
            if report_changes:
794
                self._report_change(ie, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
795
        return ie
796
797
    def _report_change(self, ie, path):
798
        """Report a change to the user.
799
800
        The change that has occurred is described relative to the basis
801
        inventory.
802
        """
803
        if (self.basis_inv.has_id(ie.file_id)):
804
            basis_ie = self.basis_inv[ie.file_id]
805
        else:
806
            basis_ie = None
807
        change = ie.describe_change(basis_ie, ie)
808
        if change in (InventoryEntry.RENAMED, 
809
            InventoryEntry.MODIFIED_AND_RENAMED):
810
            old_path = self.basis_inv.id2path(ie.file_id)
811
            self.reporter.renamed(change, old_path, path)
812
        else:
813
            self.reporter.snapshot_change(change, path)
814
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
815
    def _set_progress_stage(self, name, entries_title=None):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
816
        """Set the progress stage and emit an update to the progress bar."""
817
        self.pb_stage_name = name
818
        self.pb_stage_count += 1
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
819
        self.pb_entries_title = entries_title
820
        if entries_title is not None:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
821
            self.pb_entries_count = 0
822
            self.pb_entries_total = '?'
823
        self._emit_progress()
824
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
825
    def _next_progress_entry(self):
826
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
827
        self.pb_entries_count += 1
828
        self._emit_progress()
829
830
    def _emit_progress(self):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
831
        if self.pb_entries_title:
832
            if self.pb_entries_total == '?':
833
                text = "%s [%s %d] - Stage" % (self.pb_stage_name,
834
                    self.pb_entries_title, self.pb_entries_count)
835
            else:
836
                text = "%s [%s %d/%s] - Stage" % (self.pb_stage_name,
837
                    self.pb_entries_title, self.pb_entries_count,
838
                    str(self.pb_entries_total))
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
839
        else:
840
            text = "%s - Stage" % (self.pb_stage_name)
841
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
842