~bzr-pqm/bzr/bzr.dev

2374.2.2 by John Arbash Meinel
Fix the small bug that ie.snapshot() didn't think about kind changes.
1
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# The newly committed revision is going to have a shape corresponding
19
# to that of the working inventory.  Files that are not in the
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
28
# recorded.  For each parent revision inventory, we check to see what
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
1959.4.2 by Aaron Bentley
Merge bzr.dev
62
    inventory,
1551.8.30 by Aaron Bentley
Tweak from review comments
63
    tree,
64
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
65
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
66
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
67
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
68
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
69
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
70
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
71
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
72
                            is_inside_or_parent_of_any,
73
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
74
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
75
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
from bzrlib.xml5 import serializer_v5
1731.1.33 by Aaron Bentley
Revert no-special-root changes
77
from bzrlib.inventory import Inventory, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
78
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
79
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
80
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
81
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
82
from bzrlib.workingtree import WorkingTree
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
83
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
84
85
86
class NullCommitReporter(object):
87
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
88
89
    def snapshot_change(self, change, path):
90
        pass
91
92
    def completed(self, revno, rev_id):
93
        pass
94
95
    def deleted(self, file_id):
96
        pass
97
98
    def escaped(self, escape_count, message):
99
        pass
100
101
    def missing(self, path):
102
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
103
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
104
    def renamed(self, change, old_path, new_path):
105
        pass
106
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
107
1189 by Martin Pool
- BROKEN: partial support for commit into weave
108
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
109
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
110
    def _note(self, format, *args):
111
        """Output a message.
112
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
113
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
114
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
115
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
116
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
117
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
118
        if change == 'unchanged':
119
            return
1731.1.45 by Aaron Bentley
Merge bzr.dev
120
        if change == 'added' and path == '':
121
            return
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
122
        self._note("%s %s", change, path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
123
124
    def completed(self, revno, rev_id):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
125
        self._note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
126
    
127
    def deleted(self, file_id):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
128
        self._note('deleted %s', file_id)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
129
130
    def escaped(self, escape_count, message):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
131
        self._note("replaced %d control characters in message", escape_count)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
132
133
    def missing(self, path):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
134
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
135
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
136
    def renamed(self, change, old_path, new_path):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
137
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
138
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
139
1189 by Martin Pool
- BROKEN: partial support for commit into weave
140
class Commit(object):
141
    """Task of committing a new revision.
142
143
    This is a MethodObject: it accumulates state as the commit is
144
    prepared, and then it is discarded.  It doesn't represent
145
    historical revisions, just the act of recording a new one.
146
147
            missing_ids
148
            Modified to hold a list of files that have been deleted from
149
            the working directory; these should be removed from the
150
            working inventory.
485 by Martin Pool
- move commit code into its own module
151
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
152
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
153
                 reporter=None,
154
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
155
        if reporter is not None:
156
            self.reporter = reporter
157
        else:
158
            self.reporter = NullCommitReporter()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
159
        self.config = config
1189 by Martin Pool
- BROKEN: partial support for commit into weave
160
        
161
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
162
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
163
               timestamp=None,
164
               timezone=None,
165
               committer=None,
166
               specific_files=None,
167
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
168
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
169
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
170
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
171
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
172
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
173
               local=False,
174
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
175
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
176
               message_callback=None,
177
               recursive='down'):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
178
        """Commit working copy as a new revision.
179
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
180
        :param message: the commit message (it or message_callback is required)
181
182
        :param timestamp: if not None, seconds-since-epoch for a
183
            postdated/predated commit.
184
185
        :param specific_files: If true, commit only those files.
186
187
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
188
            Useful for test or import commands that need to tightly
189
            control what revisions are assigned.  If you duplicate
190
            a revision id that exists elsewhere it is your own fault.
191
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
192
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
193
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
194
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
195
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
196
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
197
            contains unknown files.
198
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
199
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
200
        :param local: Perform a local only commit.
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
201
        :param recursive: If set to 'down', commit in any subtrees that have
202
            pending changes of any sort during this commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
203
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
204
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
205
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
206
        if working_tree is None:
207
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
208
        else:
209
            self.work_tree = working_tree
210
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
211
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
212
                if not self.branch.repository.supports_rich_root():
213
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
214
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
215
            if message is not None:
216
                if isinstance(message, str):
217
                    message = message.decode(bzrlib.user_encoding)
218
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
219
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
220
                raise BzrError("The message or message_callback keyword"
221
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
222
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
223
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
224
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
225
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
226
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
227
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
228
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
229
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
230
        self.recursive = recursive
231
        self.revprops = revprops
232
        self.message_callback = message_callback
233
        self.timestamp = timestamp
234
        self.timezone = timezone
235
        self.committer = committer
236
        self.strict = strict
237
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
238
1607.1.5 by Robert Collins
Make commit verbose mode work!.
239
        if reporter is None and self.reporter is None:
240
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
241
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
242
            self.reporter = reporter
243
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
244
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
245
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
246
        self.basis_tree = self.work_tree.basis_tree()
247
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
248
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
249
            # Cannot commit with conflicts present.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
250
            if len(self.work_tree.conflicts()) > 0:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
251
                raise ConflictsInTree
252
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
253
            # Setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
254
            self._check_bound_branch()
255
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
256
            # Check that the working tree is up to date
257
            old_revno,new_revno = self._check_out_of_date_tree()
258
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
259
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
260
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
261
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
262
            # If provided, ensure the specified files are versioned
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
263
            if specific_files is not None:
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
264
                # Note: We don't actually need the IDs here. This routine
265
                # is being called because it raises PathNotVerisonedError
266
                # as a side effect of finding the IDs.
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
267
                # XXX: Dont we have filter_unversioned to do this more
268
                # cheaply?
269
                tree.find_ids_across_trees(specific_files,
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
270
                                           [self.basis_tree, self.work_tree])
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
271
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
272
            # Setup the progress bar. As the number of files that need to be
273
            # committed in unknown, progress is reported as stages.
274
            # We keep track of entries separately though and include that
275
            # information in the progress bar during the relevant stages.
276
            self.pb_stage_name = ""
277
            self.pb_stage_count = 0
278
            self.pb_stage_total = 4
279
            if self.bound_branch:
280
                self.pb_stage_total += 1
281
            self.pb.show_pct = False
282
            self.pb.show_spinner = False
283
            self.pb.show_eta = False
284
            self.pb.show_count = True
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
285
            self.pb.show_bar = True
1189 by Martin Pool
- BROKEN: partial support for commit into weave
286
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
287
            # After a merge, a selected file commit is not supported.
288
            # See 'bzr help merge' for an explanation as to why.
289
            self.basis_inv = self.basis_tree.inventory
1223 by Martin Pool
- store inventories in weave
290
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
291
            if len(self.parents) > 1 and self.specific_files:
1551.15.9 by Aaron Bentley
Better error for selected-file commit of merges
292
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
293
            
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
294
            # Collect the changes
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
295
            self._set_progress_stage("Collecting changes",
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
296
                    entries_title="Directory")
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
297
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
298
                self.config, timestamp, timezone, committer, revprops, rev_id)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
299
            self._update_builder_with_changes()
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
300
            self._check_pointless()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
301
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
302
            # TODO: Now the new inventory is known, check for conflicts.
1910.2.3 by Aaron Bentley
All tests pass
303
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
304
            # weave lines, because nothing should be recorded until it is known
305
            # that commit will succeed.
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
306
            self._set_progress_stage("Saving data locally")
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
307
            self.builder.finish_inventory()
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
308
309
            # Prompt the user for a commit message if none provided
2149.1.3 by Aaron Bentley
Updates from review comments
310
            message = message_callback(self)
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
311
            assert isinstance(message, unicode), type(message)
312
            self.message = message
313
            self._escape_commit_message()
314
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
315
            # Add revision data to the local branch
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
316
            self.rev_id = self.builder.commit(self.message)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
317
            
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
318
            # Upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
319
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
320
            if self.bound_branch:
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
321
                self._set_progress_stage("Uploading data to master branch")
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
322
                self.master_branch.repository.fetch(self.branch.repository,
323
                                                    revision_id=self.rev_id)
324
                # now the master has the revision data
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
325
                # 'commit' to the master first so a timeout here causes the
326
                # local branch to be out of date
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
327
                self.master_branch.set_last_revision_info(new_revno,
328
                                                          self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
329
330
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
331
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
332
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
333
            # Make the working tree up to date with the branch
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
334
            self._set_progress_stage("Updating the working tree")
2041.1.5 by John Arbash Meinel
CommitBuilder.get_tree => CommitBuilder.revision_tree
335
            rev_tree = self.builder.revision_tree()
2041.1.2 by John Arbash Meinel
Update WorkingTree.set_parent_trees() to directly cache inv.
336
            self.work_tree.set_parent_trees([(self.rev_id, rev_tree)])
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
337
            self.reporter.completed(new_revno, self.rev_id)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
338
            self._process_hooks(old_revno, new_revno)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
339
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
340
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
341
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
342
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
343
    def _any_real_changes(self):
344
        """Are there real changes between new_inventory and basis?
345
346
        For trees without rich roots, inv.root.revision changes every commit.
347
        But if that is the only change, we want to treat it as though there
348
        are *no* changes.
349
        """
350
        new_entries = self.builder.new_inventory.iter_entries()
351
        basis_entries = self.basis_inv.iter_entries()
352
        new_path, new_root_ie = new_entries.next()
353
        basis_path, basis_root_ie = basis_entries.next()
354
355
        # This is a copy of InventoryEntry.__eq__ only leaving out .revision
356
        def ie_equal_no_revision(this, other):
357
            return ((this.file_id == other.file_id)
358
                    and (this.name == other.name)
359
                    and (this.symlink_target == other.symlink_target)
360
                    and (this.text_sha1 == other.text_sha1)
361
                    and (this.text_size == other.text_size)
362
                    and (this.text_id == other.text_id)
363
                    and (this.parent_id == other.parent_id)
364
                    and (this.kind == other.kind)
365
                    and (this.executable == other.executable)
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
366
                    and (this.reference_revision == other.reference_revision)
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
367
                    )
368
        if not ie_equal_no_revision(new_root_ie, basis_root_ie):
369
            return True
370
371
        for new_ie, basis_ie in zip(new_entries, basis_entries):
372
            if new_ie != basis_ie:
373
                return True
374
375
        # No actual changes present
376
        return False
377
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
378
    def _check_pointless(self):
379
        if self.allow_pointless:
380
            return
381
        # A merge with no effect on files
382
        if len(self.parents) > 1:
383
            return
384
        # work around the fact that a newly-initted tree does differ from its
385
        # basis
1731.1.49 by Aaron Bentley
Merge bzr.dev
386
        if len(self.basis_inv) == 0 and len(self.builder.new_inventory) == 1:
387
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
388
        # Shortcut, if the number of entries changes, then we obviously have
389
        # a change
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
390
        if len(self.builder.new_inventory) != len(self.basis_inv):
391
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
392
        # If length == 1, then we only have the root entry. Which means
393
        # that there is no real difference (only the root could be different)
394
        if (len(self.builder.new_inventory) != 1 and self._any_real_changes()):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
395
            return
396
        raise PointlessCommit()
397
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
398
    def _check_bound_branch(self):
399
        """Check to see if the local branch is bound.
400
401
        If it is bound, then most of the commit will actually be
402
        done using the remote branch as the target branch.
403
        Only at the end will the local branch be updated.
404
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
405
        if self.local and not self.branch.get_bound_location():
406
            raise errors.LocalRequiresBoundBranch()
407
408
        if not self.local:
409
            self.master_branch = self.branch.get_master_branch()
410
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
411
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
412
            # make this branch the reference branch for out of date checks.
413
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
414
            return
415
416
        # If the master branch is bound, we must fail
417
        master_bound_location = self.master_branch.get_bound_location()
418
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
419
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
420
                    self.master_branch, master_bound_location)
421
422
        # TODO: jam 20051230 We could automatically push local
423
        #       commits to the remote branch if they would fit.
424
        #       But for now, just require remote to be identical
425
        #       to local.
426
        
427
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
428
        master_info = self.master_branch.last_revision_info()
429
        local_info = self.branch.last_revision_info()
430
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
431
            raise errors.BoundBranchOutOfDate(self.branch,
432
                    self.master_branch)
433
434
        # Now things are ready to change the master branch
435
        # so grab the lock
436
        self.bound_branch = self.branch
437
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
438
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
439
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
440
    def _check_out_of_date_tree(self):
441
        """Check that the working tree is up to date.
442
443
        :return: old_revision_number,new_revision_number tuple
444
        """
445
        try:
446
            first_tree_parent = self.work_tree.get_parent_ids()[0]
447
        except IndexError:
448
            # if there are no parents, treat our parent as 'None'
449
            # this is so that we still consider the master branch
450
            # - in a checkout scenario the tree may have no
451
            # parents but the branch may do.
452
            first_tree_parent = bzrlib.revision.NULL_REVISION
453
        old_revno, master_last = self.master_branch.last_revision_info()
454
        if master_last != first_tree_parent:
455
            if master_last != bzrlib.revision.NULL_REVISION:
456
                raise errors.OutOfDateTree(self.work_tree)
457
        if self.branch.repository.has_revision(first_tree_parent):
458
            new_revno = old_revno + 1
459
        else:
460
            # ghost parents never appear in revision history.
461
            new_revno = 1
462
        return old_revno,new_revno
463
464
    def _process_hooks(self, old_revno, new_revno):
465
        """Process any registered commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
466
        # Process the post commit hooks, if any
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
467
        self._set_progress_stage("Running post commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
468
        # old style commit hooks - should be deprecated ? (obsoleted in
469
        # 0.15)
470
        if self.config.post_commit() is not None:
471
            hooks = self.config.post_commit().split(' ')
472
            # this would be nicer with twisted.python.reflect.namedAny
473
            for hook in hooks:
474
                result = eval(hook + '(branch, rev_id)',
475
                              {'branch':self.branch,
476
                               'bzrlib':bzrlib,
477
                               'rev_id':self.rev_id})
478
        # new style commit hooks:
479
        if not self.bound_branch:
480
            hook_master = self.branch
481
            hook_local = None
482
        else:
483
            hook_master = self.master_branch
484
            hook_local = self.branch
485
        # With bound branches, when the master is behind the local branch,
486
        # the 'old_revno' and old_revid values here are incorrect.
487
        # XXX: FIXME ^. RBC 20060206
488
        if self.parents:
489
            old_revid = self.parents[0]
490
        else:
491
            old_revid = bzrlib.revision.NULL_REVISION
492
        for hook in Branch.hooks['post_commit']:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
493
            # show the running hook in the progress bar. As hooks may
494
            # end up doing nothing (e.g. because they are not configured by
495
            # the user) this is still showing progress, not showing overall
496
            # actions - its up to each plugin to show a UI if it want's to
497
            # (such as 'Emailing diff to foo@example.com').
2553.1.2 by Robert Collins
Show hook names during commit.
498
            self.pb_stage_name = "Running post commit hooks [%s]" % \
499
                Branch.hooks.get_hook_name(hook)
500
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
501
            if 'hooks' in debug.debug_flags:
502
                mutter("Invoking commit hook: %r", hook)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
503
            hook(hook_local, hook_master, old_revno, old_revid, new_revno,
504
                self.rev_id)
505
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
506
    def _cleanup(self):
507
        """Cleanup any open locks, progress bars etc."""
508
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
509
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
510
                    self.work_tree.unlock,
511
                    self.pb.finished]
512
        found_exception = None
513
        for cleanup in cleanups:
514
            try:
515
                cleanup()
516
            # we want every cleanup to run no matter what.
517
            # so we have a catchall here, but we will raise the
518
            # last encountered exception up the stack: and
519
            # typically this will be useful enough.
520
            except Exception, e:
521
                found_exception = e
522
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
523
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
524
            # trashed, e is our sure-to-work exception even though it loses the
525
            # full traceback. XXX: RBC 20060421 perhaps we could check the
526
            # exc_info and if its the same one do a plain raise otherwise 
527
            # 'raise e' as we do now.
528
            raise e
529
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
530
    def _cleanup_bound_branch(self):
531
        """Executed at the end of a try/finally to cleanup a bound branch.
532
533
        If the branch wasn't bound, this is a no-op.
534
        If it was, it resents self.branch to the local branch, instead
535
        of being the master.
536
        """
537
        if not self.bound_branch:
538
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
539
        if self.master_locked:
540
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
541
1390 by Robert Collins
pair programming worx... merge integration and weave
542
    def _escape_commit_message(self):
543
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
544
        # FIXME: RBC 20060419 this should be done by the revision
545
        # serialiser not by commit. Then we can also add an unescaper
546
        # in the deserializer and start roundtripping revision messages
547
        # precisely. See repository_implementations/test_repository.py
548
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
549
        # Python strings can include characters that can't be
550
        # represented in well-formed XML; escape characters that
551
        # aren't listed in the XML specification
552
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
553
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
554
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
555
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
556
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
557
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
558
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
559
560
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
561
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
562
        # TODO: Make sure that this list doesn't contain duplicate 
563
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
564
        self.parents = self.work_tree.get_parent_ids()
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
565
        self.parent_invs = [self.basis_inv]
566
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
567
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
568
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
569
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
570
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
571
            else:
572
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
573
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
574
    def _update_builder_with_changes(self):
575
        """Update the commit builder with the data about what has changed.
576
        """
577
        # Build the revision inventory.
578
        #
579
        # This starts by creating a new empty inventory. Depending on
580
        # which files are selected for commit, and what is present in the
581
        # current tree, the new inventory is populated. inventory entries 
582
        # which are candidates for modification have their revision set to
583
        # None; inventory entries that are carried over untouched have their
584
        # revision set to their prior value.
585
        #
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
586
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
587
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
588
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
589
        # ADHB 11-07-2006
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
590
591
        specific_files = self.specific_files
592
        mutter("Selecting files for commit with filter %s", specific_files)
593
594
        # Check and warn about old CommitBuilders
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
595
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
596
            symbol_versioning.warn('CommitBuilders should support recording'
597
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
598
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
599
            self.builder.new_inventory.add(self.basis_inv.root.copy())
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
600
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
601
        # Build the new inventory
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
602
        self._populate_from_inventory(specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
603
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
604
        # If specific files are selected, then all un-selected files must be
605
        # recorded in their previous state. For more details, see
606
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
607
        if specific_files:
608
            for path, new_ie in self.basis_inv.iter_entries():
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
609
                if new_ie.file_id in self.builder.new_inventory:
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
610
                    continue
611
                if is_inside_any(specific_files, path):
612
                    continue
613
                ie = new_ie.copy()
614
                ie.revision = None
615
                self.builder.record_entry_contents(ie, self.parent_invs, path,
616
                                                   self.basis_tree)
617
618
        # Report what was deleted. We could skip this when no deletes are
619
        # detected to gain a performance win, but it arguably serves as a
620
        # 'safety check' by informing the user whenever anything disappears.
621
        for path, ie in self.basis_inv.iter_entries():
622
            if ie.file_id not in self.builder.new_inventory:
623
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
624
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
625
    def _populate_from_inventory(self, specific_files):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
626
        """Populate the CommitBuilder by walking the working tree inventory."""
627
        if self.strict:
628
            # raise an exception as soon as we find a single unknown.
629
            for unknown in self.work_tree.unknowns():
630
                raise StrictCommitFailed()
631
               
632
        deleted_ids = []
633
        deleted_paths = set()
634
        work_inv = self.work_tree.inventory
635
        assert work_inv.root is not None
636
        entries = work_inv.iter_entries()
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
637
        if not self.builder.record_root_entry:
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
638
            entries.next()
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
639
        for path, existing_ie in entries:
640
            file_id = existing_ie.file_id
641
            name = existing_ie.name
642
            parent_id = existing_ie.parent_id
643
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
644
            if kind == 'directory':
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
645
                self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
646
647
            # Skip files that have been deleted from the working tree.
648
            # The deleted files/directories are also recorded so they
649
            # can be explicitly unversioned later. Note that when a
650
            # filter of specific files is given, we must only skip/record
651
            # deleted files matching that filter.
652
            if is_inside_any(deleted_paths, path):
653
                continue
654
            if not specific_files or is_inside_any(specific_files, path):
655
                if not self.work_tree.has_filename(path):
656
                    deleted_paths.add(path)
657
                    self.reporter.missing(path)
658
                    deleted_ids.append(file_id)
659
                    continue
660
            try:
661
                kind = self.work_tree.kind(file_id)
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
662
                # TODO: specific_files filtering before nested tree processing
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
663
                if kind == 'tree-reference' and self.recursive == 'down':
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
664
                    self._commit_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
665
            except errors.NoSuchFile:
666
                pass
667
668
            # Record an entry for this item
669
            # Note: I don't particularly want to have the existing_ie
670
            # parameter but the test suite currently (28-Jun-07) breaks
671
            # without it thanks to a unicode normalisation issue. :-(
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
672
            definitely_changed = kind != existing_ie.kind 
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
673
            self._record_entry(path, file_id, specific_files, kind, name,
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
674
                parent_id, definitely_changed, existing_ie)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
675
676
        # Unversion IDs that were found to be deleted
677
        self.work_tree.unversion(deleted_ids)
678
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
679
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
680
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
681
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
682
        # FIXME: be more comprehensive here:
683
        # this works when both trees are in --trees repository,
684
        # but when both are bound to a different repository,
685
        # it fails; a better way of approaching this is to 
686
        # finally implement the explicit-caches approach design
687
        # a while back - RBC 20070306.
688
        if (sub_tree.branch.repository.bzrdir.root_transport.base
689
            ==
690
            self.work_tree.branch.repository.bzrdir.root_transport.base):
691
            sub_tree.branch.repository = \
692
                self.work_tree.branch.repository
693
        try:
694
            sub_tree.commit(message=None, revprops=self.revprops,
695
                recursive=self.recursive,
696
                message_callback=self.message_callback,
697
                timestamp=self.timestamp, timezone=self.timezone,
698
                committer=self.committer,
699
                allow_pointless=self.allow_pointless,
700
                strict=self.strict, verbose=self.verbose,
701
                local=self.local, reporter=self.reporter)
702
        except errors.PointlessCommit:
703
            pass
704
705
    def _record_entry(self, path, file_id, specific_files, kind, name,
706
                      parent_id, definitely_changed, existing_ie=None):
707
        "Record the new inventory entry for a path if any."
708
        # mutter('check %s {%s}', path, file_id)
709
        if (not specific_files or 
710
            is_inside_or_parent_of_any(specific_files, path)):
711
                # mutter('%s selected for commit', path)
712
                if definitely_changed or existing_ie is None:
713
                    ie = inventory.make_entry(kind, name, parent_id, file_id)
714
                else:
715
                    ie = existing_ie.copy()
716
                    ie.revision = None
717
        else:
718
            # mutter('%s not selected for commit', path)
719
            if self.basis_inv.has_id(file_id):
720
                ie = self.basis_inv[file_id].copy()
721
            else:
722
                # this entry is new and not being committed
723
                ie = None
724
        if ie is not None:
725
            self.builder.record_entry_contents(ie, self.parent_invs, 
726
                path, self.work_tree)
727
            self._report_change(ie, path)
728
        return ie
729
730
    def _report_change(self, ie, path):
731
        """Report a change to the user.
732
733
        The change that has occurred is described relative to the basis
734
        inventory.
735
        """
736
        if (self.basis_inv.has_id(ie.file_id)):
737
            basis_ie = self.basis_inv[ie.file_id]
738
        else:
739
            basis_ie = None
740
        change = ie.describe_change(basis_ie, ie)
741
        if change in (InventoryEntry.RENAMED, 
742
            InventoryEntry.MODIFIED_AND_RENAMED):
743
            old_path = self.basis_inv.id2path(ie.file_id)
744
            self.reporter.renamed(change, old_path, path)
745
        else:
746
            self.reporter.snapshot_change(change, path)
747
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
748
    def _set_progress_stage(self, name, entries_title=None):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
749
        """Set the progress stage and emit an update to the progress bar."""
750
        self.pb_stage_name = name
751
        self.pb_stage_count += 1
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
752
        self.pb_entries_title = entries_title
753
        if entries_title is not None:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
754
            self.pb_entries_count = 0
755
            self.pb_entries_total = '?'
756
        self._emit_progress()
757
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
758
    def _next_progress_entry(self):
759
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
760
        self.pb_entries_count += 1
761
        self._emit_progress()
762
763
    def _emit_progress(self):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
764
        if self.pb_entries_title:
765
            if self.pb_entries_total == '?':
766
                text = "%s [%s %d] - Stage" % (self.pb_stage_name,
767
                    self.pb_entries_title, self.pb_entries_count)
768
            else:
769
                text = "%s [%s %d/%s] - Stage" % (self.pb_stage_name,
770
                    self.pb_entries_title, self.pb_entries_count,
771
                    str(self.pb_entries_total))
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
772
        else:
773
            text = "%s - Stage" % (self.pb_stage_name)
774
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
775