~bzr-pqm/bzr/bzr.dev

2052.3.2 by John Arbash Meinel
Change Copyright .. by Canonical to Copyright ... Canonical
1
# Copyright (C) 2006 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
3
#
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
8
#
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
# GNU General Public License for more details.
13
#
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
16
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
17
18
"""Tests for the formatting and construction of errors."""
19
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
20
from bzrlib import (
21
    bzrdir,
22
    errors,
23
    )
24
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
25
26
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
27
# TODO: Make sure builtin exception class formats are consistent - e.g. should
28
# or shouldn't end with a full stop, etc.
29
30
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
31
class TestErrors(TestCaseWithTransport):
32
2402.1.1 by Andrew Bennetts
Use the Command pattern for handling smart server commands.
33
    def test_disabled_method(self):
34
        error = errors.DisabledMethod("class name")
35
        self.assertEqualDiff(
36
            "The smart server method 'class name' is disabled.", str(error))
37
2255.7.16 by John Arbash Meinel
Make sure adding a duplicate file_id raises DuplicateFileId.
38
    def test_duplicate_file_id(self):
39
        error = errors.DuplicateFileId('a_file_id', 'foo')
40
        self.assertEqualDiff('File id {a_file_id} already exists in inventory'
41
                             ' as foo', str(error))
42
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
43
    def test_inventory_modified(self):
44
        error = errors.InventoryModified("a tree to be repred")
45
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
46
            "be repred' has been modified, so a clean inventory cannot be "
47
            "read without data loss.",
48
            str(error))
49
2116.3.1 by John Arbash Meinel
Cleanup error tests
50
    def test_install_failed(self):
51
        error = errors.InstallFailed(['rev-one'])
52
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
53
        error = errors.InstallFailed(['rev-one', 'rev-two'])
54
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
55
                         str(error))
56
        error = errors.InstallFailed([None])
57
        self.assertEqual("Could not install revisions:\nNone", str(error))
58
2255.2.145 by Robert Collins
Support unbreakable locks for trees.
59
    def test_lock_active(self):
60
        error = errors.LockActive("lock description")
61
        self.assertEqualDiff("The lock for 'lock description' is in use and "
62
            "cannot be broken.",
63
            str(error))
64
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
65
    def test_knit_header_error(self):
66
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
67
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
68
                         " for file path/to/file", str(error))
69
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
70
    def test_knit_index_unknown_method(self):
71
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
72
                                              ['bad', 'no-eol'])
73
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
74
                         " known method in options: ['bad', 'no-eol']",
75
                         str(error))
76
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
77
    def test_medium_not_connected(self):
78
        error = errors.MediumNotConnected("a medium")
79
        self.assertEqualDiff(
80
            "The medium 'a medium' is not connected.", str(error))
81
        
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
82
    def test_no_repo(self):
83
        dir = bzrdir.BzrDir.create(self.get_url())
84
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
85
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
86
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
87
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
88
    def test_no_smart_medium(self):
89
        error = errors.NoSmartMedium("a transport")
90
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
91
            "smart protocol.",
92
            str(error))
93
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
94
    def test_no_such_id(self):
95
        error = errors.NoSuchId("atree", "anid")
96
        self.assertEqualDiff("The file id anid is not present in the tree "
97
            "atree.",
98
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
99
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
100
    def test_no_such_revision_in_tree(self):
101
        error = errors.NoSuchRevisionInTree("atree", "anid")
102
        self.assertEqualDiff("The revision id anid is not present in the tree "
103
            "atree.",
104
            str(error))
105
        self.assertIsInstance(error, errors.NoSuchRevision)
106
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
107
    def test_not_write_locked(self):
108
        error = errors.NotWriteLocked('a thing to repr')
109
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
110
            "to be.",
111
            str(error))
112
2353.3.10 by John Arbash Meinel
Cleanup errors, and change ReadOnlyLockError to pass around more details.
113
    def test_read_only_lock_error(self):
114
        error = errors.ReadOnlyLockError('filename', 'error message')
115
        self.assertEqualDiff("Cannot acquire write lock on filename."
116
                             " error message", str(error))
117
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
118
    def test_too_many_concurrent_requests(self):
119
        error = errors.TooManyConcurrentRequests("a medium")
120
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
121
            "request limit. Be sure to finish_writing and finish_reading on "
122
            "the current request that is open.",
123
            str(error))
124
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
125
    def test_unknown_hook(self):
126
        error = errors.UnknownHook("branch", "foo")
127
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
128
            " of bzrlib.",
129
            str(error))
130
        error = errors.UnknownHook("tree", "bar")
131
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
132
            " of bzrlib.",
133
            str(error))
134
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
135
    def test_up_to_date(self):
136
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
137
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
138
                             "format 0.0.4 is already at the most "
139
                             "recent format.",
140
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
141
142
    def test_corrupt_repository(self):
143
        repo = self.make_repository('.')
144
        error = errors.CorruptRepository(repo)
145
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
146
                             "Please run bzr reconcile on this repository." %
147
                             repo.bzrdir.root_transport.base,
148
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
149
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
150
    def test_bzrnewerror_is_deprecated(self):
151
        class DeprecatedError(errors.BzrNewError):
152
            pass
2067.3.6 by Martin Pool
Update deprecation version
153
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
154
             'please convert DeprecatedError to use BzrError instead'],
155
            DeprecatedError)
156
157
    def test_bzrerror_from_literal_string(self):
158
        # Some code constructs BzrError from a literal string, in which case
159
        # no further formatting is done.  (I'm not sure raising the base class
160
        # is a great idea, but if the exception is not intended to be caught
161
        # perhaps no more is needed.)
162
        try:
163
            raise errors.BzrError('this is my errors; %d is not expanded')
164
        except errors.BzrError, e:
165
            self.assertEqual('this is my errors; %d is not expanded', str(e))
166
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
167
    def test_reading_completed(self):
168
        error = errors.ReadingCompleted("a request")
169
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
170
            "finish_reading called upon it - the request has been completed and"
171
            " no more data may be read.",
172
            str(error))
173
174
    def test_writing_completed(self):
175
        error = errors.WritingCompleted("a request")
176
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
177
            "finish_writing called upon it - accept bytes may not be called "
178
            "anymore.",
179
            str(error))
180
181
    def test_writing_not_completed(self):
182
        error = errors.WritingNotComplete("a request")
183
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
184
            "finish_writing called upon it - until the write phase is complete"
185
            " no data may be read.",
186
            str(error))
187
2045.1.3 by John Arbash Meinel
Lukáš Lalinský: TransportNotPossible has a bad docstring
188
    def test_transport_not_possible(self):
189
        e = errors.TransportNotPossible('readonly', 'original error')
190
        self.assertEqual('Transport operation not possible:'
191
                         ' readonly original error', str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
192
193
    def assertSocketConnectionError(self, expected, *args, **kwargs):
194
        """Check the formatting of a SocketConnectionError exception"""
195
        e = errors.SocketConnectionError(*args, **kwargs)
196
        self.assertEqual(expected, str(e))
197
198
    def test_socket_connection_error(self):
199
        """Test the formatting of SocketConnectionError"""
200
201
        # There should be a default msg about failing to connect
202
        # we only require a host name.
203
        self.assertSocketConnectionError(
204
            'Failed to connect to ahost',
205
            'ahost')
206
207
        # If port is None, we don't put :None
208
        self.assertSocketConnectionError(
209
            'Failed to connect to ahost',
210
            'ahost', port=None)
211
        # But if port is supplied we include it
212
        self.assertSocketConnectionError(
213
            'Failed to connect to ahost:22',
214
            'ahost', port=22)
215
216
        # We can also supply extra information about the error
217
        # with or without a port
218
        self.assertSocketConnectionError(
219
            'Failed to connect to ahost:22; bogus error',
220
            'ahost', port=22, orig_error='bogus error')
221
        self.assertSocketConnectionError(
222
            'Failed to connect to ahost; bogus error',
223
            'ahost', orig_error='bogus error')
224
        # An exception object can be passed rather than a string
225
        orig_error = ValueError('bad value')
226
        self.assertSocketConnectionError(
227
            'Failed to connect to ahost; %s' % (str(orig_error),),
228
            host='ahost', orig_error=orig_error)
229
230
        # And we can supply a custom failure message
231
        self.assertSocketConnectionError(
232
            'Unable to connect to ssh host ahost:444; my_error',
233
            host='ahost', port=444, msg='Unable to connect to ssh host',
234
            orig_error='my_error')
235
236
2116.3.1 by John Arbash Meinel
Cleanup error tests
237
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
238
class PassThroughError(errors.BzrError):
239
    
240
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
241
242
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
243
        errors.BzrError.__init__(self, foo=foo, bar=bar)
244
245
246
class ErrorWithBadFormat(errors.BzrError):
247
248
    _fmt = """One format specifier: %(thing)s"""
249
250
251
class ErrorWithNoFormat(errors.BzrError):
252
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
253
254
255
class TestErrorFormatting(TestCase):
256
    
257
    def test_always_str(self):
258
        e = PassThroughError(u'\xb5', 'bar')
259
        self.assertIsInstance(e.__str__(), str)
260
        # In Python str(foo) *must* return a real byte string
261
        # not a Unicode string. The following line would raise a
262
        # Unicode error, because it tries to call str() on the string
263
        # returned from e.__str__(), and it has non ascii characters
264
        s = str(e)
265
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
266
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
267
    def test_missing_format_string(self):
268
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
269
        s = self.callDeprecated(
270
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
271
                lambda x: str(x), e)
272
        ## s = str(e)
273
        self.assertEqual(s, 
274
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
275
2116.3.1 by John Arbash Meinel
Cleanup error tests
276
    def test_mismatched_format_args(self):
277
        # Even though ErrorWithBadFormat's format string does not match the
278
        # arguments we constructing it with, we can still stringify an instance
279
        # of this exception. The resulting string will say its unprintable.
280
        e = ErrorWithBadFormat(not_thing='x')
281
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
282
            str(e), 'Unprintable exception ErrorWithBadFormat')
2116.3.1 by John Arbash Meinel
Cleanup error tests
283