~bzr-pqm/bzr/bzr.dev

1704.2.14 by Martin Pool
[merge] work from 0.8 fixes
1
# Copyright (C) 2005, 2006 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# The newly committed revision is going to have a shape corresponding
19
# to that of the working inventory.  Files that are not in the
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
28
# recorded.  For each parent revision inventory, we check to see what
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
60
    errors,
1959.4.2 by Aaron Bentley
Merge bzr.dev
61
    inventory,
1551.8.30 by Aaron Bentley
Tweak from review comments
62
    tree,
63
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
64
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
65
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
66
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
67
                           ConflictsInTree,
68
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
69
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
70
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
71
                            is_inside_or_parent_of_any,
72
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
73
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
74
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
75
from bzrlib.xml5 import serializer_v5
1731.1.33 by Aaron Bentley
Revert no-special-root changes
76
from bzrlib.inventory import Inventory, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
77
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
78
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
79
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
80
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
81
from bzrlib.workingtree import WorkingTree
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
82
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
83
84
85
class NullCommitReporter(object):
86
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
87
88
    def snapshot_change(self, change, path):
89
        pass
90
91
    def completed(self, revno, rev_id):
92
        pass
93
94
    def deleted(self, file_id):
95
        pass
96
97
    def escaped(self, escape_count, message):
98
        pass
99
100
    def missing(self, path):
101
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
102
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
103
    def renamed(self, change, old_path, new_path):
104
        pass
105
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
106
1189 by Martin Pool
- BROKEN: partial support for commit into weave
107
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
108
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
109
    # this may be more useful if 'note' was replaced by an overridable
110
    # method on self, which would allow more trivial subclassing.
111
    # alternative, a callable could be passed in, allowing really trivial
112
    # reuse for some uis. RBC 20060511
113
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
114
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
115
        if change == 'unchanged':
116
            return
1731.1.45 by Aaron Bentley
Merge bzr.dev
117
        if change == 'added' and path == '':
118
            return
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
119
        note("%s %s", change, path)
120
121
    def completed(self, revno, rev_id):
1607.1.5 by Robert Collins
Make commit verbose mode work!.
122
        note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
123
    
124
    def deleted(self, file_id):
125
        note('deleted %s', file_id)
126
127
    def escaped(self, escape_count, message):
128
        note("replaced %d control characters in message", escape_count)
129
130
    def missing(self, path):
131
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
132
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
133
    def renamed(self, change, old_path, new_path):
134
        note('%s %s => %s', change, old_path, new_path)
135
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
136
1189 by Martin Pool
- BROKEN: partial support for commit into weave
137
class Commit(object):
138
    """Task of committing a new revision.
139
140
    This is a MethodObject: it accumulates state as the commit is
141
    prepared, and then it is discarded.  It doesn't represent
142
    historical revisions, just the act of recording a new one.
143
144
            missing_ids
145
            Modified to hold a list of files that have been deleted from
146
            the working directory; these should be removed from the
147
            working inventory.
485 by Martin Pool
- move commit code into its own module
148
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
149
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
150
                 reporter=None,
151
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
152
        if reporter is not None:
153
            self.reporter = reporter
154
        else:
155
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
156
        if config is not None:
157
            self.config = config
158
        else:
159
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
160
        
161
    def commit(self,
2149.1.3 by Aaron Bentley
Updates from review comments
162
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
163
               timestamp=None,
164
               timezone=None,
165
               committer=None,
166
               specific_files=None,
167
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
168
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
169
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
170
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
171
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
172
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
173
               local=False,
174
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
175
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
176
               message_callback=None,
177
               recursive='down'):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
178
        """Commit working copy as a new revision.
179
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
180
        branch -- the deprecated branch to commit to. New callers should pass in 
181
                  working_tree instead
182
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
183
        message -- the commit message (it or message_callback is required)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
184
1189 by Martin Pool
- BROKEN: partial support for commit into weave
185
        timestamp -- if not None, seconds-since-epoch for a
186
             postdated/predated commit.
187
1253 by Martin Pool
- test that pointless commits are trapped
188
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
189
1253 by Martin Pool
- test that pointless commits are trapped
190
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
191
            Useful for test or import commands that need to tightly
192
            control what revisions are assigned.  If you duplicate
193
            a revision id that exists elsewhere it is your own fault.
194
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
195
196
        allow_pointless -- If true (default), commit even if nothing
197
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
198
1185.16.65 by mbp at sourcefrog
- new commit --strict option
199
        strict -- If true, don't allow a commit if the working tree
200
            contains unknown files.
201
1185.16.35 by Martin Pool
- stub for revision properties
202
        revprops -- Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
203
        :param local: Perform a local only commit.
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
204
        :param recursive: If set to 'down', commit in any subtrees that have
205
            pending changes of any sort during this commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
206
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
207
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
208
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
209
        if deprecated_passed(branch):
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
210
            symbol_versioning.warn("Commit.commit (branch, ...): The branch parameter is "
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
211
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
212
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
213
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
214
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
215
        elif working_tree is None:
216
            raise BzrError("One of branch and working_tree must be passed into commit().")
217
        else:
218
            self.work_tree = working_tree
219
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
220
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
221
                if not self.branch.repository.supports_rich_root():
222
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
223
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
224
            if message is not None:
225
                if isinstance(message, str):
226
                    message = message.decode(bzrlib.user_encoding)
227
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
228
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
229
                raise BzrError("The message or message_callback keyword"
230
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
231
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
232
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
233
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
234
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
235
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
236
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
237
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
238
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
239
        self.recursive = recursive
240
        self.revprops = revprops
241
        self.message_callback = message_callback
242
        self.timestamp = timestamp
243
        self.timezone = timezone
244
        self.committer = committer
245
        self.specific_files = specific_files
246
        self.strict = strict
247
        self.verbose = verbose
248
        self.local = local
1189 by Martin Pool
- BROKEN: partial support for commit into weave
249
1607.1.5 by Robert Collins
Make commit verbose mode work!.
250
        if reporter is None and self.reporter is None:
251
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
252
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
253
            self.reporter = reporter
254
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
255
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
256
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
257
        self.basis_tree = self.work_tree.basis_tree()
258
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
259
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
260
            # Cannot commit with conflicts present.
261
            if len(self.work_tree.conflicts())>0:
262
                raise ConflictsInTree
263
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
264
            # setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
265
            self._check_bound_branch()
266
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
267
            # check for out of date working trees
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
268
            try:
269
                first_tree_parent = self.work_tree.get_parent_ids()[0]
270
            except IndexError:
271
                # if there are no parents, treat our parent as 'None'
272
                # this is so that we still consier the master branch
273
                # - in a checkout scenario the tree may have no
274
                # parents but the branch may do.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
275
                first_tree_parent = bzrlib.revision.NULL_REVISION
276
            old_revno, master_last = self.master_branch.last_revision_info()
277
            if master_last != first_tree_parent:
278
                if master_last != bzrlib.revision.NULL_REVISION:
279
                    raise errors.OutOfDateTree(self.work_tree)
280
            if self.branch.repository.has_revision(first_tree_parent):
281
                new_revno = old_revno + 1
282
            else:
283
                # ghost parents never appear in revision history.
284
                new_revno = 1
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
285
            if strict:
286
                # raise an exception as soon as we find a single unknown.
287
                for unknown in self.work_tree.unknowns():
288
                    raise StrictCommitFailed()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
289
                   
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
290
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
291
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
292
1189 by Martin Pool
- BROKEN: partial support for commit into weave
293
            self.work_inv = self.work_tree.inventory
294
            self.basis_inv = self.basis_tree.inventory
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
295
            if specific_files is not None:
296
                # Ensure specified files are versioned
297
                # (We don't actually need the ids here)
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
298
                # XXX: Dont we have filter_unversioned to do this more
299
                # cheaply?
300
                tree.find_ids_across_trees(specific_files,
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
301
                                           [self.basis_tree, self.work_tree])
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
302
            # one to finish, one for rev and inventory, and one for each
303
            # inventory entry, and the same for the new inventory.
304
            # note that this estimate is too long when we do a partial tree
305
            # commit which excludes some new files from being considered.
306
            # The estimate is corrected when we populate the new inv.
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
307
            self.pb_total = len(self.work_inv) + 5
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
308
            self.pb_count = 0
1189 by Martin Pool
- BROKEN: partial support for commit into weave
309
1223 by Martin Pool
- store inventories in weave
310
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
311
            if len(self.parents) > 1 and self.specific_files:
1704.2.11 by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges.
312
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
313
                        self.specific_files)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
314
            
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
315
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
316
                self.config, timestamp, timezone, committer, revprops, rev_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
317
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
318
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
319
            self._populate_new_inv()
1248 by Martin Pool
- new weave based cleanup [broken]
320
            self._report_deletes()
1245 by Martin Pool
doc
321
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
322
            self._check_pointless()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
323
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
324
            self._emit_progress_update()
1910.2.3 by Aaron Bentley
All tests pass
325
            # TODO: Now the new inventory is known, check for conflicts and
326
            # prompt the user for a commit message.
327
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
328
            # weave lines, because nothing should be recorded until it is known
329
            # that commit will succeed.
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
330
            self.builder.finish_inventory()
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
331
            self._emit_progress_update()
2149.1.3 by Aaron Bentley
Updates from review comments
332
            message = message_callback(self)
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
333
            assert isinstance(message, unicode), type(message)
334
            self.message = message
335
            self._escape_commit_message()
336
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
337
            self.rev_id = self.builder.commit(self.message)
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
338
            self._emit_progress_update()
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
339
            # revision data is in the local branch now.
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
340
            
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
341
            # upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
342
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
343
            if self.bound_branch:
344
                self.master_branch.repository.fetch(self.branch.repository,
345
                                                    revision_id=self.rev_id)
346
                # now the master has the revision data
347
                # 'commit' to the master first so a timeout here causes the local
348
                # branch to be out of date
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
349
                self.master_branch.set_last_revision_info(new_revno,
350
                                                          self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
351
352
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
353
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
354
2041.1.5 by John Arbash Meinel
CommitBuilder.get_tree => CommitBuilder.revision_tree
355
            rev_tree = self.builder.revision_tree()
2041.1.2 by John Arbash Meinel
Update WorkingTree.set_parent_trees() to directly cache inv.
356
            self.work_tree.set_parent_trees([(self.rev_id, rev_tree)])
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
357
            # now the work tree is up to date with the branch
358
            
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
359
            self.reporter.completed(new_revno, self.rev_id)
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
360
            # old style commit hooks - should be deprecated ? (obsoleted in
361
            # 0.15)
1472 by Robert Collins
post commit hook, first pass implementation
362
            if self.config.post_commit() is not None:
363
                hooks = self.config.post_commit().split(' ')
364
                # this would be nicer with twisted.python.reflect.namedAny
365
                for hook in hooks:
366
                    result = eval(hook + '(branch, rev_id)',
367
                                  {'branch':self.branch,
368
                                   'bzrlib':bzrlib,
369
                                   'rev_id':self.rev_id})
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
370
            # new style commit hooks:
371
            if not self.bound_branch:
372
                hook_master = self.branch
373
                hook_local = None
374
            else:
375
                hook_master = self.master_branch
376
                hook_local = self.branch
377
            # With bound branches, when the master is behind the local branch,
378
            # the 'old_revno' and old_revid values here are incorrect.
379
            # XXX: FIXME ^. RBC 20060206
380
            if self.parents:
381
                old_revid = self.parents[0]
382
            else:
383
                old_revid = bzrlib.revision.NULL_REVISION
384
            for hook in Branch.hooks['post_commit']:
385
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
386
                    self.rev_id)
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
387
            self._emit_progress_update()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
388
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
389
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
390
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
391
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
392
    def _any_real_changes(self):
393
        """Are there real changes between new_inventory and basis?
394
395
        For trees without rich roots, inv.root.revision changes every commit.
396
        But if that is the only change, we want to treat it as though there
397
        are *no* changes.
398
        """
399
        new_entries = self.builder.new_inventory.iter_entries()
400
        basis_entries = self.basis_inv.iter_entries()
401
        new_path, new_root_ie = new_entries.next()
402
        basis_path, basis_root_ie = basis_entries.next()
403
404
        # This is a copy of InventoryEntry.__eq__ only leaving out .revision
405
        def ie_equal_no_revision(this, other):
406
            return ((this.file_id == other.file_id)
407
                    and (this.name == other.name)
408
                    and (this.symlink_target == other.symlink_target)
409
                    and (this.text_sha1 == other.text_sha1)
410
                    and (this.text_size == other.text_size)
411
                    and (this.text_id == other.text_id)
412
                    and (this.parent_id == other.parent_id)
413
                    and (this.kind == other.kind)
414
                    and (this.executable == other.executable)
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
415
                    and (this.reference_revision == other.reference_revision)
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
416
                    )
417
        if not ie_equal_no_revision(new_root_ie, basis_root_ie):
418
            return True
419
420
        for new_ie, basis_ie in zip(new_entries, basis_entries):
421
            if new_ie != basis_ie:
422
                return True
423
424
        # No actual changes present
425
        return False
426
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
427
    def _check_pointless(self):
428
        if self.allow_pointless:
429
            return
430
        # A merge with no effect on files
431
        if len(self.parents) > 1:
432
            return
433
        # work around the fact that a newly-initted tree does differ from its
434
        # basis
1731.1.49 by Aaron Bentley
Merge bzr.dev
435
        if len(self.basis_inv) == 0 and len(self.builder.new_inventory) == 1:
436
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
437
        # Shortcut, if the number of entries changes, then we obviously have
438
        # a change
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
439
        if len(self.builder.new_inventory) != len(self.basis_inv):
440
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
441
        # If length == 1, then we only have the root entry. Which means
442
        # that there is no real difference (only the root could be different)
443
        if (len(self.builder.new_inventory) != 1 and self._any_real_changes()):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
444
            return
445
        raise PointlessCommit()
446
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
447
    def _check_bound_branch(self):
448
        """Check to see if the local branch is bound.
449
450
        If it is bound, then most of the commit will actually be
451
        done using the remote branch as the target branch.
452
        Only at the end will the local branch be updated.
453
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
454
        if self.local and not self.branch.get_bound_location():
455
            raise errors.LocalRequiresBoundBranch()
456
457
        if not self.local:
458
            self.master_branch = self.branch.get_master_branch()
459
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
460
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
461
            # make this branch the reference branch for out of date checks.
462
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
463
            return
464
465
        # If the master branch is bound, we must fail
466
        master_bound_location = self.master_branch.get_bound_location()
467
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
468
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
469
                    self.master_branch, master_bound_location)
470
471
        # TODO: jam 20051230 We could automatically push local
472
        #       commits to the remote branch if they would fit.
473
        #       But for now, just require remote to be identical
474
        #       to local.
475
        
476
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
477
        master_info = self.master_branch.last_revision_info()
478
        local_info = self.branch.last_revision_info()
479
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
480
            raise errors.BoundBranchOutOfDate(self.branch,
481
                    self.master_branch)
482
483
        # Now things are ready to change the master branch
484
        # so grab the lock
485
        self.bound_branch = self.branch
486
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
487
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
488
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
489
    def _cleanup(self):
490
        """Cleanup any open locks, progress bars etc."""
491
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
492
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
493
                    self.work_tree.unlock,
494
                    self.pb.finished]
495
        found_exception = None
496
        for cleanup in cleanups:
497
            try:
498
                cleanup()
499
            # we want every cleanup to run no matter what.
500
            # so we have a catchall here, but we will raise the
501
            # last encountered exception up the stack: and
502
            # typically this will be useful enough.
503
            except Exception, e:
504
                found_exception = e
505
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
506
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
507
            # trashed, e is our sure-to-work exception even though it loses the
508
            # full traceback. XXX: RBC 20060421 perhaps we could check the
509
            # exc_info and if its the same one do a plain raise otherwise 
510
            # 'raise e' as we do now.
511
            raise e
512
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
513
    def _cleanup_bound_branch(self):
514
        """Executed at the end of a try/finally to cleanup a bound branch.
515
516
        If the branch wasn't bound, this is a no-op.
517
        If it was, it resents self.branch to the local branch, instead
518
        of being the master.
519
        """
520
        if not self.bound_branch:
521
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
522
        if self.master_locked:
523
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
524
1390 by Robert Collins
pair programming worx... merge integration and weave
525
    def _escape_commit_message(self):
526
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
527
        # FIXME: RBC 20060419 this should be done by the revision
528
        # serialiser not by commit. Then we can also add an unescaper
529
        # in the deserializer and start roundtripping revision messages
530
        # precisely. See repository_implementations/test_repository.py
531
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
532
        # Python strings can include characters that can't be
533
        # represented in well-formed XML; escape characters that
534
        # aren't listed in the XML specification
535
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
536
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
537
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
538
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
539
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
540
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
541
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
542
543
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
544
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
545
        # TODO: Make sure that this list doesn't contain duplicate 
546
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
547
        self.parents = self.work_tree.get_parent_ids()
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
548
        self.parent_invs = [self.basis_inv]
549
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
550
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
551
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
552
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
553
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
554
            else:
555
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
556
1189 by Martin Pool
- BROKEN: partial support for commit into weave
557
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
558
        """Remove deleted files from the working inventories.
559
560
        This is done prior to taking the working inventory as the
561
        basis for the new committed inventory.
562
563
        This returns true if any files
564
        *that existed in the basis inventory* were deleted.
565
        Files that were added and deleted
566
        in the working copy don't matter.
567
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
568
        specific = self.specific_files
569
        deleted_ids = []
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
570
        deleted_paths = set()
1254 by Martin Pool
- fix handling of selective commit with deleted files
571
        for path, ie in self.work_inv.iter_entries():
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
572
            if is_inside_any(deleted_paths, path):
573
                # The tree will delete the required ids recursively.
574
                continue
1254 by Martin Pool
- fix handling of selective commit with deleted files
575
            if specific and not is_inside_any(specific, path):
576
                continue
577
            if not self.work_tree.has_filename(path):
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
578
                deleted_paths.add(path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
579
                self.reporter.missing(path)
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
580
                deleted_ids.append(ie.file_id)
581
        self.work_tree.unversion(deleted_ids)
1248 by Martin Pool
- new weave based cleanup [broken]
582
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
583
    def _populate_new_inv(self):
584
        """Build revision inventory.
585
586
        This creates a new empty inventory. Depending on
587
        which files are selected for commit, and what is present in the
588
        current tree, the new inventory is populated. inventory entries 
589
        which are candidates for modification have their revision set to
590
        None; inventory entries that are carried over untouched have their
591
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
592
        """
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
593
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
594
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
595
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
596
        # ADHB 11-07-2006
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
597
        mutter("Selecting files for commit with filter %s", self.specific_files)
1731.1.64 by Aaron Bentley
Fix up more memorytree tests
598
        assert self.work_inv.root is not None
1910.2.4 by Aaron Bentley
Support old CommitBuilders
599
        entries = self.work_inv.iter_entries()
600
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
601
            symbol_versioning.warn('CommitBuilders should support recording'
602
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
603
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
604
            self.builder.new_inventory.add(self.basis_inv.root.copy())
605
            entries.next()
606
            self._emit_progress_update()
607
        for path, new_ie in entries:
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
608
            self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
609
            file_id = new_ie.file_id
1959.4.2 by Aaron Bentley
Merge bzr.dev
610
            try:
611
                kind = self.work_tree.kind(file_id)
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
612
                if kind == 'tree-reference' and self.recursive == 'down':
613
                    # nested tree: commit in it
614
                    sub_tree = WorkingTree.open(self.work_tree.abspath(path))
615
                    # FIXME: be more comprehensive here:
616
                    # this works when both trees are in --trees repository,
617
                    # but when both are bound to a different repository,
618
                    # it fails; a better way of approaching this is to 
619
                    # finally implement the explicit-caches approach design
620
                    # a while back - RBC 20070306.
621
                    if (sub_tree.branch.repository.bzrdir.root_transport.base
622
                        ==
623
                        self.work_tree.branch.repository.bzrdir.root_transport.base):
624
                        sub_tree.branch.repository = \
625
                            self.work_tree.branch.repository
626
                    try:
627
                        sub_tree.commit(message=None, revprops=self.revprops,
628
                            recursive=self.recursive,
629
                            message_callback=self.message_callback,
630
                            timestamp=self.timestamp, timezone=self.timezone,
631
                            committer=self.committer,
632
                            allow_pointless=self.allow_pointless,
633
                            strict=self.strict, verbose=self.verbose,
634
                            local=self.local, reporter=self.reporter)
635
                    except errors.PointlessCommit:
636
                        pass
1959.4.2 by Aaron Bentley
Merge bzr.dev
637
                if kind != new_ie.kind:
1959.4.4 by Aaron Bentley
Trim trailing whitespace
638
                    new_ie = inventory.make_entry(kind, new_ie.name,
1959.4.2 by Aaron Bentley
Merge bzr.dev
639
                                                  new_ie.parent_id, file_id)
640
            except errors.NoSuchFile:
641
                pass
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
642
            # mutter('check %s {%s}', path, file_id)
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
643
            if (not self.specific_files or 
644
                is_inside_or_parent_of_any(self.specific_files, path)):
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
645
                    # mutter('%s selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
646
                    ie = new_ie.copy()
647
                    ie.revision = None
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
648
            else:
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
649
                # mutter('%s not selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
650
                if self.basis_inv.has_id(file_id):
651
                    ie = self.basis_inv[file_id].copy()
652
                else:
653
                    # this entry is new and not being committed
654
                    continue
1731.1.62 by Aaron Bentley
Changes from review comments
655
            self.builder.record_entry_contents(ie, self.parent_invs, 
656
                path, self.work_tree)
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
657
            # describe the nature of the change that has occurred relative to
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
658
            # the basis inventory.
659
            if (self.basis_inv.has_id(ie.file_id)):
660
                basis_ie = self.basis_inv[ie.file_id]
661
            else:
662
                basis_ie = None
663
            change = ie.describe_change(basis_ie, ie)
664
            if change in (InventoryEntry.RENAMED, 
665
                InventoryEntry.MODIFIED_AND_RENAMED):
666
                old_path = self.basis_inv.id2path(ie.file_id)
667
                self.reporter.renamed(change, old_path, path)
668
            else:
669
                self.reporter.snapshot_change(change, path)
1416 by Robert Collins
when committing a specific file, include all its parents
670
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
671
        if not self.specific_files:
672
            return
673
674
        # ignore removals that don't match filespec
675
        for path, new_ie in self.basis_inv.iter_entries():
676
            if new_ie.file_id in self.work_inv:
677
                continue
678
            if is_inside_any(self.specific_files, path):
679
                continue
680
            ie = new_ie.copy()
681
            ie.revision = None
682
            self.builder.record_entry_contents(ie, self.parent_invs, path,
683
                                               self.basis_tree)
684
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
685
    def _emit_progress_update(self):
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
686
        """Emit an update to the progress bar."""
687
        self.pb.update("Committing", self.pb_count, self.pb_total)
688
        self.pb_count += 1
689
1248 by Martin Pool
- new weave based cleanup [broken]
690
    def _report_deletes(self):
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
691
        for path, ie in self.basis_inv.iter_entries():
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
692
            if ie.file_id not in self.builder.new_inventory:
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
693
                self.reporter.deleted(path)
1248 by Martin Pool
- new weave based cleanup [broken]
694
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
695