~bzr-pqm/bzr/bzr.dev

2052.3.2 by John Arbash Meinel
Change Copyright .. by Canonical to Copyright ... Canonical
1
# Copyright (C) 2006 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
3
#
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
8
#
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
# GNU General Public License for more details.
13
#
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
16
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
17
18
"""Tests for the formatting and construction of errors."""
19
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
20
from bzrlib import (
21
    bzrdir,
22
    errors,
23
    )
24
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
25
26
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
27
# TODO: Make sure builtin exception class formats are consistent - e.g. should
28
# or shouldn't end with a full stop, etc.
29
30
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
31
class TestErrors(TestCaseWithTransport):
32
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
33
    def test_inventory_modified(self):
34
        error = errors.InventoryModified("a tree to be repred")
35
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
36
            "be repred' has been modified, so a clean inventory cannot be "
37
            "read without data loss.",
38
            str(error))
39
2116.3.1 by John Arbash Meinel
Cleanup error tests
40
    def test_install_failed(self):
41
        error = errors.InstallFailed(['rev-one'])
42
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
43
        error = errors.InstallFailed(['rev-one', 'rev-two'])
44
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
45
                         str(error))
46
        error = errors.InstallFailed([None])
47
        self.assertEqual("Could not install revisions:\nNone", str(error))
48
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
49
    def test_knit_header_error(self):
50
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
51
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
52
                         " for file path/to/file", str(error))
53
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
54
    def test_knit_index_unknown_method(self):
55
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
56
                                              ['bad', 'no-eol'])
57
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
58
                         " known method in options: ['bad', 'no-eol']",
59
                         str(error))
60
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
61
    def test_medium_not_connected(self):
62
        error = errors.MediumNotConnected("a medium")
63
        self.assertEqualDiff(
64
            "The medium 'a medium' is not connected.", str(error))
65
        
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
66
    def test_no_repo(self):
67
        dir = bzrdir.BzrDir.create(self.get_url())
68
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
69
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
70
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
71
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
72
    def test_no_smart_medium(self):
73
        error = errors.NoSmartMedium("a transport")
74
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
75
            "smart protocol.",
76
            str(error))
77
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
78
    def test_no_such_id(self):
79
        error = errors.NoSuchId("atree", "anid")
80
        self.assertEqualDiff("The file id anid is not present in the tree "
81
            "atree.",
82
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
83
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
84
    def test_not_write_locked(self):
85
        error = errors.NotWriteLocked('a thing to repr')
86
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
87
            "to be.",
88
            str(error))
89
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
90
    def test_too_many_concurrent_requests(self):
91
        error = errors.TooManyConcurrentRequests("a medium")
92
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
93
            "request limit. Be sure to finish_writing and finish_reading on "
94
            "the current request that is open.",
95
            str(error))
96
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
97
    def test_unknown_hook(self):
98
        error = errors.UnknownHook("branch", "foo")
99
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
100
            " of bzrlib.",
101
            str(error))
102
        error = errors.UnknownHook("tree", "bar")
103
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
104
            " of bzrlib.",
105
            str(error))
106
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
107
    def test_up_to_date(self):
108
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
109
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
110
                             "format 0.0.4 is already at the most "
111
                             "recent format.",
112
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
113
114
    def test_corrupt_repository(self):
115
        repo = self.make_repository('.')
116
        error = errors.CorruptRepository(repo)
117
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
118
                             "Please run bzr reconcile on this repository." %
119
                             repo.bzrdir.root_transport.base,
120
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
121
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
122
    def test_bzrnewerror_is_deprecated(self):
123
        class DeprecatedError(errors.BzrNewError):
124
            pass
2067.3.6 by Martin Pool
Update deprecation version
125
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
126
             'please convert DeprecatedError to use BzrError instead'],
127
            DeprecatedError)
128
129
    def test_bzrerror_from_literal_string(self):
130
        # Some code constructs BzrError from a literal string, in which case
131
        # no further formatting is done.  (I'm not sure raising the base class
132
        # is a great idea, but if the exception is not intended to be caught
133
        # perhaps no more is needed.)
134
        try:
135
            raise errors.BzrError('this is my errors; %d is not expanded')
136
        except errors.BzrError, e:
137
            self.assertEqual('this is my errors; %d is not expanded', str(e))
138
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
139
    def test_reading_completed(self):
140
        error = errors.ReadingCompleted("a request")
141
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
142
            "finish_reading called upon it - the request has been completed and"
143
            " no more data may be read.",
144
            str(error))
145
146
    def test_writing_completed(self):
147
        error = errors.WritingCompleted("a request")
148
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
149
            "finish_writing called upon it - accept bytes may not be called "
150
            "anymore.",
151
            str(error))
152
153
    def test_writing_not_completed(self):
154
        error = errors.WritingNotComplete("a request")
155
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
156
            "finish_writing called upon it - until the write phase is complete"
157
            " no data may be read.",
158
            str(error))
159
2045.1.3 by John Arbash Meinel
Lukáš Lalinský: TransportNotPossible has a bad docstring
160
    def test_transport_not_possible(self):
161
        e = errors.TransportNotPossible('readonly', 'original error')
162
        self.assertEqual('Transport operation not possible:'
163
                         ' readonly original error', str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
164
165
    def assertSocketConnectionError(self, expected, *args, **kwargs):
166
        """Check the formatting of a SocketConnectionError exception"""
167
        e = errors.SocketConnectionError(*args, **kwargs)
168
        self.assertEqual(expected, str(e))
169
170
    def test_socket_connection_error(self):
171
        """Test the formatting of SocketConnectionError"""
172
173
        # There should be a default msg about failing to connect
174
        # we only require a host name.
175
        self.assertSocketConnectionError(
176
            'Failed to connect to ahost',
177
            'ahost')
178
179
        # If port is None, we don't put :None
180
        self.assertSocketConnectionError(
181
            'Failed to connect to ahost',
182
            'ahost', port=None)
183
        # But if port is supplied we include it
184
        self.assertSocketConnectionError(
185
            'Failed to connect to ahost:22',
186
            'ahost', port=22)
187
188
        # We can also supply extra information about the error
189
        # with or without a port
190
        self.assertSocketConnectionError(
191
            'Failed to connect to ahost:22; bogus error',
192
            'ahost', port=22, orig_error='bogus error')
193
        self.assertSocketConnectionError(
194
            'Failed to connect to ahost; bogus error',
195
            'ahost', orig_error='bogus error')
196
        # An exception object can be passed rather than a string
197
        orig_error = ValueError('bad value')
198
        self.assertSocketConnectionError(
199
            'Failed to connect to ahost; %s' % (str(orig_error),),
200
            host='ahost', orig_error=orig_error)
201
202
        # And we can supply a custom failure message
203
        self.assertSocketConnectionError(
204
            'Unable to connect to ssh host ahost:444; my_error',
205
            host='ahost', port=444, msg='Unable to connect to ssh host',
206
            orig_error='my_error')
207
208
2116.3.1 by John Arbash Meinel
Cleanup error tests
209
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
210
class PassThroughError(errors.BzrError):
211
    
212
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
213
214
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
215
        errors.BzrError.__init__(self, foo=foo, bar=bar)
216
217
218
class ErrorWithBadFormat(errors.BzrError):
219
220
    _fmt = """One format specifier: %(thing)s"""
221
222
223
class ErrorWithNoFormat(errors.BzrError):
224
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
225
226
227
class TestErrorFormatting(TestCase):
228
    
229
    def test_always_str(self):
230
        e = PassThroughError(u'\xb5', 'bar')
231
        self.assertIsInstance(e.__str__(), str)
232
        # In Python str(foo) *must* return a real byte string
233
        # not a Unicode string. The following line would raise a
234
        # Unicode error, because it tries to call str() on the string
235
        # returned from e.__str__(), and it has non ascii characters
236
        s = str(e)
237
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
238
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
239
    def test_missing_format_string(self):
240
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
241
        s = self.callDeprecated(
242
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
243
                lambda x: str(x), e)
244
        ## s = str(e)
245
        self.assertEqual(s, 
246
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
247
2116.3.1 by John Arbash Meinel
Cleanup error tests
248
    def test_mismatched_format_args(self):
249
        # Even though ErrorWithBadFormat's format string does not match the
250
        # arguments we constructing it with, we can still stringify an instance
251
        # of this exception. The resulting string will say its unprintable.
252
        e = ErrorWithBadFormat(not_thing='x')
253
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
254
            str(e), 'Unprintable exception ErrorWithBadFormat')
2116.3.1 by John Arbash Meinel
Cleanup error tests
255