~bzr-pqm/bzr/bzr.dev

1704.2.14 by Martin Pool
[merge] work from 0.8 fixes
1
# Copyright (C) 2005, 2006 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# The newly committed revision is going to have a shape corresponding
19
# to that of the working inventory.  Files that are not in the
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
28
# recorded.  For each parent revision inventory, we check to see what
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
60
    errors,
61
    tree,
62
    )
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
63
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
64
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
65
                           ConflictsInTree,
66
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
67
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
68
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
69
                            is_inside_or_parent_of_any,
70
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
71
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
72
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
73
from bzrlib.xml5 import serializer_v5
1731.1.33 by Aaron Bentley
Revert no-special-root changes
74
from bzrlib.inventory import Inventory, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
75
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
76
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
77
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
78
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
79
from bzrlib.workingtree import WorkingTree
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
80
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
81
82
83
class NullCommitReporter(object):
84
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
85
86
    def snapshot_change(self, change, path):
87
        pass
88
89
    def completed(self, revno, rev_id):
90
        pass
91
92
    def deleted(self, file_id):
93
        pass
94
95
    def escaped(self, escape_count, message):
96
        pass
97
98
    def missing(self, path):
99
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
100
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
101
    def renamed(self, change, old_path, new_path):
102
        pass
103
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
104
1189 by Martin Pool
- BROKEN: partial support for commit into weave
105
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
106
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
107
    # this may be more useful if 'note' was replaced by an overridable
108
    # method on self, which would allow more trivial subclassing.
109
    # alternative, a callable could be passed in, allowing really trivial
110
    # reuse for some uis. RBC 20060511
111
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
112
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
113
        if change == 'unchanged':
114
            return
1731.1.45 by Aaron Bentley
Merge bzr.dev
115
        if change == 'added' and path == '':
116
            return
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
117
        note("%s %s", change, path)
118
119
    def completed(self, revno, rev_id):
1607.1.5 by Robert Collins
Make commit verbose mode work!.
120
        note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
121
    
122
    def deleted(self, file_id):
123
        note('deleted %s', file_id)
124
125
    def escaped(self, escape_count, message):
126
        note("replaced %d control characters in message", escape_count)
127
128
    def missing(self, path):
129
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
130
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
131
    def renamed(self, change, old_path, new_path):
132
        note('%s %s => %s', change, old_path, new_path)
133
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
134
1189 by Martin Pool
- BROKEN: partial support for commit into weave
135
class Commit(object):
136
    """Task of committing a new revision.
137
138
    This is a MethodObject: it accumulates state as the commit is
139
    prepared, and then it is discarded.  It doesn't represent
140
    historical revisions, just the act of recording a new one.
141
142
            missing_ids
143
            Modified to hold a list of files that have been deleted from
144
            the working directory; these should be removed from the
145
            working inventory.
485 by Martin Pool
- move commit code into its own module
146
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
148
                 reporter=None,
149
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
150
        if reporter is not None:
151
            self.reporter = reporter
152
        else:
153
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
154
        if config is not None:
155
            self.config = config
156
        else:
157
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
158
        
159
    def commit(self,
2149.1.3 by Aaron Bentley
Updates from review comments
160
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
161
               timestamp=None,
162
               timezone=None,
163
               committer=None,
164
               specific_files=None,
165
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
166
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
167
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
168
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
169
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
170
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
171
               local=False,
172
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
173
               config=None,
174
               message_callback=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
175
        """Commit working copy as a new revision.
176
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
177
        branch -- the deprecated branch to commit to. New callers should pass in 
178
                  working_tree instead
179
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
180
        message -- the commit message (it or message_callback is required)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
181
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
        timestamp -- if not None, seconds-since-epoch for a
183
             postdated/predated commit.
184
1253 by Martin Pool
- test that pointless commits are trapped
185
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
186
1253 by Martin Pool
- test that pointless commits are trapped
187
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
188
            Useful for test or import commands that need to tightly
189
            control what revisions are assigned.  If you duplicate
190
            a revision id that exists elsewhere it is your own fault.
191
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
192
193
        allow_pointless -- If true (default), commit even if nothing
194
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
195
1185.16.65 by mbp at sourcefrog
- new commit --strict option
196
        strict -- If true, don't allow a commit if the working tree
197
            contains unknown files.
198
1185.16.35 by Martin Pool
- stub for revision properties
199
        revprops -- Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
200
        :param local: Perform a local only commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
201
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
202
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
203
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
204
        if deprecated_passed(branch):
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
205
            symbol_versioning.warn("Commit.commit (branch, ...): The branch parameter is "
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
206
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
207
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
208
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
209
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
210
        elif working_tree is None:
211
            raise BzrError("One of branch and working_tree must be passed into commit().")
212
        else:
213
            self.work_tree = working_tree
214
            self.branch = self.work_tree.branch
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
215
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
216
            if message is not None:
217
                if isinstance(message, str):
218
                    message = message.decode(bzrlib.user_encoding)
219
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
220
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
221
                raise BzrError("The message or message_callback keyword"
222
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
223
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
224
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
225
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
226
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
227
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
228
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
229
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
230
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
231
1607.1.5 by Robert Collins
Make commit verbose mode work!.
232
        if reporter is None and self.reporter is None:
233
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
234
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
235
            self.reporter = reporter
236
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
237
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
238
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
239
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
240
            # Cannot commit with conflicts present.
241
            if len(self.work_tree.conflicts())>0:
242
                raise ConflictsInTree
243
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
244
            # setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
245
            self._check_bound_branch()
246
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
247
            # check for out of date working trees
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
248
            try:
249
                first_tree_parent = self.work_tree.get_parent_ids()[0]
250
            except IndexError:
251
                # if there are no parents, treat our parent as 'None'
252
                # this is so that we still consier the master branch
253
                # - in a checkout scenario the tree may have no
254
                # parents but the branch may do.
255
                first_tree_parent = None
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
256
            master_last = self.master_branch.last_revision()
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
257
            if (master_last is not None and
258
                master_last != first_tree_parent):
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
259
                raise errors.OutOfDateTree(self.work_tree)
260
    
261
            if strict:
262
                # raise an exception as soon as we find a single unknown.
263
                for unknown in self.work_tree.unknowns():
264
                    raise StrictCommitFailed()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
265
                   
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
266
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
267
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
268
1189 by Martin Pool
- BROKEN: partial support for commit into weave
269
            self.work_inv = self.work_tree.inventory
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
270
            self.basis_tree = self.work_tree.basis_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
271
            self.basis_inv = self.basis_tree.inventory
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
272
            if specific_files is not None:
273
                # Ensure specified files are versioned
274
                # (We don't actually need the ids here)
275
                tree.find_ids_across_trees(specific_files, 
276
                                           [self.basis_tree, self.work_tree])
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
277
            # one to finish, one for rev and inventory, and one for each
278
            # inventory entry, and the same for the new inventory.
279
            # note that this estimate is too long when we do a partial tree
280
            # commit which excludes some new files from being considered.
281
            # The estimate is corrected when we populate the new inv.
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
282
            self.pb_total = len(self.work_inv) + 5
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
283
            self.pb_count = 0
1189 by Martin Pool
- BROKEN: partial support for commit into weave
284
1223 by Martin Pool
- store inventories in weave
285
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
286
            if len(self.parents) > 1 and self.specific_files:
1704.2.11 by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges.
287
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
288
                        self.specific_files)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
289
            
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
290
            self.builder = self.branch.get_commit_builder(self.parents, 
291
                self.config, timestamp, timezone, committer, revprops, rev_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
292
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
293
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
294
            self._populate_new_inv()
1248 by Martin Pool
- new weave based cleanup [broken]
295
            self._report_deletes()
1245 by Martin Pool
doc
296
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
297
            self._check_pointless()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
298
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
299
            self._emit_progress_update()
1910.2.3 by Aaron Bentley
All tests pass
300
            # TODO: Now the new inventory is known, check for conflicts and
301
            # prompt the user for a commit message.
302
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
303
            # weave lines, because nothing should be recorded until it is known
304
            # that commit will succeed.
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
305
            self.builder.finish_inventory()
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
306
            self._emit_progress_update()
2149.1.3 by Aaron Bentley
Updates from review comments
307
            message = message_callback(self)
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
308
            assert isinstance(message, unicode), type(message)
309
            self.message = message
310
            self._escape_commit_message()
311
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
312
            self.rev_id = self.builder.commit(self.message)
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
313
            self._emit_progress_update()
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
314
            # revision data is in the local branch now.
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
315
            
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
316
            # upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
317
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
318
            if self.bound_branch:
319
                self.master_branch.repository.fetch(self.branch.repository,
320
                                                    revision_id=self.rev_id)
321
                # now the master has the revision data
322
                # 'commit' to the master first so a timeout here causes the local
323
                # branch to be out of date
324
                self.master_branch.append_revision(self.rev_id)
325
326
            # and now do the commit locally.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
327
            self.branch.append_revision(self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
328
2041.1.5 by John Arbash Meinel
CommitBuilder.get_tree => CommitBuilder.revision_tree
329
            rev_tree = self.builder.revision_tree()
2041.1.2 by John Arbash Meinel
Update WorkingTree.set_parent_trees() to directly cache inv.
330
            self.work_tree.set_parent_trees([(self.rev_id, rev_tree)])
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
331
            # now the work tree is up to date with the branch
332
            
1607.1.5 by Robert Collins
Make commit verbose mode work!.
333
            self.reporter.completed(self.branch.revno(), self.rev_id)
1472 by Robert Collins
post commit hook, first pass implementation
334
            if self.config.post_commit() is not None:
335
                hooks = self.config.post_commit().split(' ')
336
                # this would be nicer with twisted.python.reflect.namedAny
337
                for hook in hooks:
338
                    result = eval(hook + '(branch, rev_id)',
339
                                  {'branch':self.branch,
340
                                   'bzrlib':bzrlib,
341
                                   'rev_id':self.rev_id})
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
342
            self._emit_progress_update()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
343
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
344
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
345
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
346
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
347
    def _any_real_changes(self):
348
        """Are there real changes between new_inventory and basis?
349
350
        For trees without rich roots, inv.root.revision changes every commit.
351
        But if that is the only change, we want to treat it as though there
352
        are *no* changes.
353
        """
354
        new_entries = self.builder.new_inventory.iter_entries()
355
        basis_entries = self.basis_inv.iter_entries()
356
        new_path, new_root_ie = new_entries.next()
357
        basis_path, basis_root_ie = basis_entries.next()
358
359
        # This is a copy of InventoryEntry.__eq__ only leaving out .revision
360
        def ie_equal_no_revision(this, other):
361
            return ((this.file_id == other.file_id)
362
                    and (this.name == other.name)
363
                    and (this.symlink_target == other.symlink_target)
364
                    and (this.text_sha1 == other.text_sha1)
365
                    and (this.text_size == other.text_size)
366
                    and (this.text_id == other.text_id)
367
                    and (this.parent_id == other.parent_id)
368
                    and (this.kind == other.kind)
369
                    and (this.executable == other.executable)
370
                    )
371
        if not ie_equal_no_revision(new_root_ie, basis_root_ie):
372
            return True
373
374
        for new_ie, basis_ie in zip(new_entries, basis_entries):
375
            if new_ie != basis_ie:
376
                return True
377
378
        # No actual changes present
379
        return False
380
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
381
    def _check_pointless(self):
382
        if self.allow_pointless:
383
            return
384
        # A merge with no effect on files
385
        if len(self.parents) > 1:
386
            return
387
        # work around the fact that a newly-initted tree does differ from its
388
        # basis
1731.1.49 by Aaron Bentley
Merge bzr.dev
389
        if len(self.basis_inv) == 0 and len(self.builder.new_inventory) == 1:
390
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
391
        # Shortcut, if the number of entries changes, then we obviously have
392
        # a change
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
393
        if len(self.builder.new_inventory) != len(self.basis_inv):
394
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
395
        # If length == 1, then we only have the root entry. Which means
396
        # that there is no real difference (only the root could be different)
397
        if (len(self.builder.new_inventory) != 1 and self._any_real_changes()):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
398
            return
399
        raise PointlessCommit()
400
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
401
    def _check_bound_branch(self):
402
        """Check to see if the local branch is bound.
403
404
        If it is bound, then most of the commit will actually be
405
        done using the remote branch as the target branch.
406
        Only at the end will the local branch be updated.
407
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
408
        if self.local and not self.branch.get_bound_location():
409
            raise errors.LocalRequiresBoundBranch()
410
411
        if not self.local:
412
            self.master_branch = self.branch.get_master_branch()
413
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
414
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
415
            # make this branch the reference branch for out of date checks.
416
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
417
            return
418
419
        # If the master branch is bound, we must fail
420
        master_bound_location = self.master_branch.get_bound_location()
421
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
422
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
423
                    self.master_branch, master_bound_location)
424
425
        # TODO: jam 20051230 We could automatically push local
426
        #       commits to the remote branch if they would fit.
427
        #       But for now, just require remote to be identical
428
        #       to local.
429
        
430
        # Make sure the local branch is identical to the master
431
        master_rh = self.master_branch.revision_history()
432
        local_rh = self.branch.revision_history()
433
        if local_rh != master_rh:
434
            raise errors.BoundBranchOutOfDate(self.branch,
435
                    self.master_branch)
436
437
        # Now things are ready to change the master branch
438
        # so grab the lock
439
        self.bound_branch = self.branch
440
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
441
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
442
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
443
    def _cleanup(self):
444
        """Cleanup any open locks, progress bars etc."""
445
        cleanups = [self._cleanup_bound_branch,
446
                    self.work_tree.unlock,
447
                    self.pb.finished]
448
        found_exception = None
449
        for cleanup in cleanups:
450
            try:
451
                cleanup()
452
            # we want every cleanup to run no matter what.
453
            # so we have a catchall here, but we will raise the
454
            # last encountered exception up the stack: and
455
            # typically this will be useful enough.
456
            except Exception, e:
457
                found_exception = e
458
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
459
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
460
            # trashed, e is our sure-to-work exception even though it loses the
461
            # full traceback. XXX: RBC 20060421 perhaps we could check the
462
            # exc_info and if its the same one do a plain raise otherwise 
463
            # 'raise e' as we do now.
464
            raise e
465
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
466
    def _cleanup_bound_branch(self):
467
        """Executed at the end of a try/finally to cleanup a bound branch.
468
469
        If the branch wasn't bound, this is a no-op.
470
        If it was, it resents self.branch to the local branch, instead
471
        of being the master.
472
        """
473
        if not self.bound_branch:
474
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
475
        if self.master_locked:
476
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
477
1390 by Robert Collins
pair programming worx... merge integration and weave
478
    def _escape_commit_message(self):
479
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
480
        # FIXME: RBC 20060419 this should be done by the revision
481
        # serialiser not by commit. Then we can also add an unescaper
482
        # in the deserializer and start roundtripping revision messages
483
        # precisely. See repository_implementations/test_repository.py
484
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
485
        # Python strings can include characters that can't be
486
        # represented in well-formed XML; escape characters that
487
        # aren't listed in the XML specification
488
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
489
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
490
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
491
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
492
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
493
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
494
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
495
496
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
497
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
498
        # TODO: Make sure that this list doesn't contain duplicate 
499
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
500
        self.parents = self.work_tree.get_parent_ids()
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
501
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
502
        for revision in self.parents:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
503
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
504
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
505
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
506
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
507
            else:
508
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
509
1189 by Martin Pool
- BROKEN: partial support for commit into weave
510
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
511
        """Remove deleted files from the working inventories.
512
513
        This is done prior to taking the working inventory as the
514
        basis for the new committed inventory.
515
516
        This returns true if any files
517
        *that existed in the basis inventory* were deleted.
518
        Files that were added and deleted
519
        in the working copy don't matter.
520
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
521
        specific = self.specific_files
522
        deleted_ids = []
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
523
        deleted_paths = set()
1254 by Martin Pool
- fix handling of selective commit with deleted files
524
        for path, ie in self.work_inv.iter_entries():
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
525
            if is_inside_any(deleted_paths, path):
526
                # The tree will delete the required ids recursively.
527
                continue
1254 by Martin Pool
- fix handling of selective commit with deleted files
528
            if specific and not is_inside_any(specific, path):
529
                continue
530
            if not self.work_tree.has_filename(path):
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
531
                deleted_paths.add(path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
532
                self.reporter.missing(path)
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
533
                deleted_ids.append(ie.file_id)
534
        self.work_tree.unversion(deleted_ids)
1248 by Martin Pool
- new weave based cleanup [broken]
535
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
536
    def _populate_new_inv(self):
537
        """Build revision inventory.
538
539
        This creates a new empty inventory. Depending on
540
        which files are selected for commit, and what is present in the
541
        current tree, the new inventory is populated. inventory entries 
542
        which are candidates for modification have their revision set to
543
        None; inventory entries that are carried over untouched have their
544
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
545
        """
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
546
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
547
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
548
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
549
        # ADHB 11-07-2006
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
550
        mutter("Selecting files for commit with filter %s", self.specific_files)
1731.1.64 by Aaron Bentley
Fix up more memorytree tests
551
        assert self.work_inv.root is not None
1910.2.4 by Aaron Bentley
Support old CommitBuilders
552
        entries = self.work_inv.iter_entries()
553
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
554
            symbol_versioning.warn('CommitBuilders should support recording'
555
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
556
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
557
            self.builder.new_inventory.add(self.basis_inv.root.copy())
558
            entries.next()
559
            self._emit_progress_update()
560
        for path, new_ie in entries:
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
561
            self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
562
            file_id = new_ie.file_id
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
563
            # mutter('check %s {%s}', path, file_id)
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
564
            if (not self.specific_files or 
565
                is_inside_or_parent_of_any(self.specific_files, path)):
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
566
                    # mutter('%s selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
567
                    ie = new_ie.copy()
568
                    ie.revision = None
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
569
            else:
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
570
                # mutter('%s not selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
571
                if self.basis_inv.has_id(file_id):
572
                    ie = self.basis_inv[file_id].copy()
573
                else:
574
                    # this entry is new and not being committed
575
                    continue
1731.1.62 by Aaron Bentley
Changes from review comments
576
            self.builder.record_entry_contents(ie, self.parent_invs, 
577
                path, self.work_tree)
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
578
            # describe the nature of the change that has occurred relative to
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
579
            # the basis inventory.
580
            if (self.basis_inv.has_id(ie.file_id)):
581
                basis_ie = self.basis_inv[ie.file_id]
582
            else:
583
                basis_ie = None
584
            change = ie.describe_change(basis_ie, ie)
585
            if change in (InventoryEntry.RENAMED, 
586
                InventoryEntry.MODIFIED_AND_RENAMED):
587
                old_path = self.basis_inv.id2path(ie.file_id)
588
                self.reporter.renamed(change, old_path, path)
589
            else:
590
                self.reporter.snapshot_change(change, path)
1416 by Robert Collins
when committing a specific file, include all its parents
591
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
592
        if not self.specific_files:
593
            return
594
595
        # ignore removals that don't match filespec
596
        for path, new_ie in self.basis_inv.iter_entries():
597
            if new_ie.file_id in self.work_inv:
598
                continue
599
            if is_inside_any(self.specific_files, path):
600
                continue
601
            ie = new_ie.copy()
602
            ie.revision = None
603
            self.builder.record_entry_contents(ie, self.parent_invs, path,
604
                                               self.basis_tree)
605
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
606
    def _emit_progress_update(self):
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
607
        """Emit an update to the progress bar."""
608
        self.pb.update("Committing", self.pb_count, self.pb_total)
609
        self.pb_count += 1
610
1248 by Martin Pool
- new weave based cleanup [broken]
611
    def _report_deletes(self):
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
612
        for path, ie in self.basis_inv.iter_entries():
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
613
            if ie.file_id not in self.builder.new_inventory:
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
614
                self.reporter.deleted(path)
1248 by Martin Pool
- new weave based cleanup [broken]
615
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
616