~bzr-pqm/bzr/bzr.dev

2052.3.2 by John Arbash Meinel
Change Copyright .. by Canonical to Copyright ... Canonical
1
# Copyright (C) 2006 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
3
#
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
8
#
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
# GNU General Public License for more details.
13
#
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
16
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
17
18
"""Tests for the formatting and construction of errors."""
19
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
20
from bzrlib import (
21
    bzrdir,
22
    errors,
23
    )
24
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
25
26
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
27
# TODO: Make sure builtin exception class formats are consistent - e.g. should
28
# or shouldn't end with a full stop, etc.
29
30
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
31
class TestErrors(TestCaseWithTransport):
32
2255.7.16 by John Arbash Meinel
Make sure adding a duplicate file_id raises DuplicateFileId.
33
    def test_duplicate_file_id(self):
34
        error = errors.DuplicateFileId('a_file_id', 'foo')
35
        self.assertEqualDiff('File id {a_file_id} already exists in inventory'
36
                             ' as foo', str(error))
37
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
38
    def test_inventory_modified(self):
39
        error = errors.InventoryModified("a tree to be repred")
40
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
41
            "be repred' has been modified, so a clean inventory cannot be "
42
            "read without data loss.",
43
            str(error))
44
2116.3.1 by John Arbash Meinel
Cleanup error tests
45
    def test_install_failed(self):
46
        error = errors.InstallFailed(['rev-one'])
47
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
48
        error = errors.InstallFailed(['rev-one', 'rev-two'])
49
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
50
                         str(error))
51
        error = errors.InstallFailed([None])
52
        self.assertEqual("Could not install revisions:\nNone", str(error))
53
2255.2.145 by Robert Collins
Support unbreakable locks for trees.
54
    def test_lock_active(self):
55
        error = errors.LockActive("lock description")
56
        self.assertEqualDiff("The lock for 'lock description' is in use and "
57
            "cannot be broken.",
58
            str(error))
59
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
60
    def test_knit_header_error(self):
61
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
62
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
63
                         " for file path/to/file", str(error))
64
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
65
    def test_knit_index_unknown_method(self):
66
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
67
                                              ['bad', 'no-eol'])
68
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
69
                         " known method in options: ['bad', 'no-eol']",
70
                         str(error))
71
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
72
    def test_medium_not_connected(self):
73
        error = errors.MediumNotConnected("a medium")
74
        self.assertEqualDiff(
75
            "The medium 'a medium' is not connected.", str(error))
76
        
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
77
    def test_no_repo(self):
78
        dir = bzrdir.BzrDir.create(self.get_url())
79
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
80
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
81
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
82
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
83
    def test_no_smart_medium(self):
84
        error = errors.NoSmartMedium("a transport")
85
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
86
            "smart protocol.",
87
            str(error))
88
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
89
    def test_no_such_id(self):
90
        error = errors.NoSuchId("atree", "anid")
91
        self.assertEqualDiff("The file id anid is not present in the tree "
92
            "atree.",
93
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
94
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
95
    def test_no_such_revision_in_tree(self):
96
        error = errors.NoSuchRevisionInTree("atree", "anid")
97
        self.assertEqualDiff("The revision id anid is not present in the tree "
98
            "atree.",
99
            str(error))
100
        self.assertIsInstance(error, errors.NoSuchRevision)
101
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
102
    def test_not_write_locked(self):
103
        error = errors.NotWriteLocked('a thing to repr')
104
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
105
            "to be.",
106
            str(error))
107
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
108
    def test_too_many_concurrent_requests(self):
109
        error = errors.TooManyConcurrentRequests("a medium")
110
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
111
            "request limit. Be sure to finish_writing and finish_reading on "
112
            "the current request that is open.",
113
            str(error))
114
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
115
    def test_unknown_hook(self):
116
        error = errors.UnknownHook("branch", "foo")
117
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
118
            " of bzrlib.",
119
            str(error))
120
        error = errors.UnknownHook("tree", "bar")
121
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
122
            " of bzrlib.",
123
            str(error))
124
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
125
    def test_up_to_date(self):
126
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
127
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
128
                             "format 0.0.4 is already at the most "
129
                             "recent format.",
130
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
131
132
    def test_corrupt_repository(self):
133
        repo = self.make_repository('.')
134
        error = errors.CorruptRepository(repo)
135
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
136
                             "Please run bzr reconcile on this repository." %
137
                             repo.bzrdir.root_transport.base,
138
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
139
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
140
    def test_bzrnewerror_is_deprecated(self):
141
        class DeprecatedError(errors.BzrNewError):
142
            pass
2067.3.6 by Martin Pool
Update deprecation version
143
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
144
             'please convert DeprecatedError to use BzrError instead'],
145
            DeprecatedError)
146
147
    def test_bzrerror_from_literal_string(self):
148
        # Some code constructs BzrError from a literal string, in which case
149
        # no further formatting is done.  (I'm not sure raising the base class
150
        # is a great idea, but if the exception is not intended to be caught
151
        # perhaps no more is needed.)
152
        try:
153
            raise errors.BzrError('this is my errors; %d is not expanded')
154
        except errors.BzrError, e:
155
            self.assertEqual('this is my errors; %d is not expanded', str(e))
156
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
157
    def test_reading_completed(self):
158
        error = errors.ReadingCompleted("a request")
159
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
160
            "finish_reading called upon it - the request has been completed and"
161
            " no more data may be read.",
162
            str(error))
163
164
    def test_writing_completed(self):
165
        error = errors.WritingCompleted("a request")
166
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
167
            "finish_writing called upon it - accept bytes may not be called "
168
            "anymore.",
169
            str(error))
170
171
    def test_writing_not_completed(self):
172
        error = errors.WritingNotComplete("a request")
173
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
174
            "finish_writing called upon it - until the write phase is complete"
175
            " no data may be read.",
176
            str(error))
177
2045.1.3 by John Arbash Meinel
Lukáš Lalinský: TransportNotPossible has a bad docstring
178
    def test_transport_not_possible(self):
179
        e = errors.TransportNotPossible('readonly', 'original error')
180
        self.assertEqual('Transport operation not possible:'
181
                         ' readonly original error', str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
182
183
    def assertSocketConnectionError(self, expected, *args, **kwargs):
184
        """Check the formatting of a SocketConnectionError exception"""
185
        e = errors.SocketConnectionError(*args, **kwargs)
186
        self.assertEqual(expected, str(e))
187
188
    def test_socket_connection_error(self):
189
        """Test the formatting of SocketConnectionError"""
190
191
        # There should be a default msg about failing to connect
192
        # we only require a host name.
193
        self.assertSocketConnectionError(
194
            'Failed to connect to ahost',
195
            'ahost')
196
197
        # If port is None, we don't put :None
198
        self.assertSocketConnectionError(
199
            'Failed to connect to ahost',
200
            'ahost', port=None)
201
        # But if port is supplied we include it
202
        self.assertSocketConnectionError(
203
            'Failed to connect to ahost:22',
204
            'ahost', port=22)
205
206
        # We can also supply extra information about the error
207
        # with or without a port
208
        self.assertSocketConnectionError(
209
            'Failed to connect to ahost:22; bogus error',
210
            'ahost', port=22, orig_error='bogus error')
211
        self.assertSocketConnectionError(
212
            'Failed to connect to ahost; bogus error',
213
            'ahost', orig_error='bogus error')
214
        # An exception object can be passed rather than a string
215
        orig_error = ValueError('bad value')
216
        self.assertSocketConnectionError(
217
            'Failed to connect to ahost; %s' % (str(orig_error),),
218
            host='ahost', orig_error=orig_error)
219
220
        # And we can supply a custom failure message
221
        self.assertSocketConnectionError(
222
            'Unable to connect to ssh host ahost:444; my_error',
223
            host='ahost', port=444, msg='Unable to connect to ssh host',
224
            orig_error='my_error')
225
226
2116.3.1 by John Arbash Meinel
Cleanup error tests
227
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
228
class PassThroughError(errors.BzrError):
229
    
230
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
231
232
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
233
        errors.BzrError.__init__(self, foo=foo, bar=bar)
234
235
236
class ErrorWithBadFormat(errors.BzrError):
237
238
    _fmt = """One format specifier: %(thing)s"""
239
240
241
class ErrorWithNoFormat(errors.BzrError):
242
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
243
244
245
class TestErrorFormatting(TestCase):
246
    
247
    def test_always_str(self):
248
        e = PassThroughError(u'\xb5', 'bar')
249
        self.assertIsInstance(e.__str__(), str)
250
        # In Python str(foo) *must* return a real byte string
251
        # not a Unicode string. The following line would raise a
252
        # Unicode error, because it tries to call str() on the string
253
        # returned from e.__str__(), and it has non ascii characters
254
        s = str(e)
255
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
256
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
257
    def test_missing_format_string(self):
258
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
259
        s = self.callDeprecated(
260
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
261
                lambda x: str(x), e)
262
        ## s = str(e)
263
        self.assertEqual(s, 
264
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
265
2116.3.1 by John Arbash Meinel
Cleanup error tests
266
    def test_mismatched_format_args(self):
267
        # Even though ErrorWithBadFormat's format string does not match the
268
        # arguments we constructing it with, we can still stringify an instance
269
        # of this exception. The resulting string will say its unprintable.
270
        e = ErrorWithBadFormat(not_thing='x')
271
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
272
            str(e), 'Unprintable exception ErrorWithBadFormat')
2116.3.1 by John Arbash Meinel
Cleanup error tests
273