~bzr-pqm/bzr/bzr.dev

1704.2.14 by Martin Pool
[merge] work from 0.8 fixes
1
# Copyright (C) 2005, 2006 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
1755.3.1 by Robert Collins
Tune the time to build our kernel_like tree : make LocalTransport.put faster, AtomicFile faster, LocalTransport.append faster.
19
# nothing?  
1248 by Martin Pool
- new weave based cleanup [broken]
20
21
# TODO: Separate 'prepare' phase where we find a list of potentially
22
# committed files.  We then can then pause the commit to prompt for a
23
# commit message, knowing the summary will be the same as what's
24
# actually used for the commit.  (But perhaps simpler to simply get
25
# the tree status, then use that for a selective commit?)
26
27
# The newly committed revision is going to have a shape corresponding
28
# to that of the working inventory.  Files that are not in the
29
# working tree and that were in the predecessor are reported as
30
# removed --- this can include files that were either removed from the
31
# inventory or deleted in the working tree.  If they were only
32
# deleted from disk, they are removed from the working inventory.
33
34
# We then consider the remaining entries, which will be in the new
35
# version.  Directory entries are simply copied across.  File entries
36
# must be checked to see if a new version of the file should be
37
# recorded.  For each parent revision inventory, we check to see what
38
# version of the file was present.  If the file was present in at
39
# least one tree, and if it was the same version in all the trees,
40
# then we can just refer to that version.  Otherwise, a new version
41
# representing the merger of the file versions must be added.
42
43
# TODO: Update hashcache before and after - or does the WorkingTree
44
# look after that?
1245 by Martin Pool
doc
45
1339 by Martin Pool
- doc
46
# TODO: Rather than mashing together the ancestry and storing it back,
47
# perhaps the weave should have single method which does it all in one
48
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
49
1341 by Martin Pool
- doc
50
# TODO: Perhaps give a warning if one of the revisions marked as
51
# merged is already in the ancestry, and then don't record it as a
52
# distinct parent.
53
1343 by Martin Pool
- fix up test for merge of trees
54
# TODO: If the file is newly merged but unchanged from the version it
55
# merges from, then it should still be reported as newly added
56
# relative to the basis revision.
57
1185.16.66 by mbp at sourcefrog
- todo
58
# TODO: Do checks that the tree can be committed *before* running the 
59
# editor; this should include checks for a pointless commit and for 
60
# unknown or missing files.
61
62
# TODO: If commit fails, leave the message in a file somewhere.
63
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
64
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
65
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
66
1189 by Martin Pool
- BROKEN: partial support for commit into weave
67
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
68
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
69
import sys
1188 by Martin Pool
- clean up imports in commit code
70
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
71
72
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
73
1551.8.30 by Aaron Bentley
Tweak from review comments
74
from bzrlib import (
75
    errors,
76
    tree,
77
    )
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
78
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
79
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
80
                           ConflictsInTree,
81
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
82
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
83
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
84
                            is_inside_or_parent_of_any,
85
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
86
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
87
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
88
from bzrlib.xml5 import serializer_v5
1731.1.33 by Aaron Bentley
Revert no-special-root changes
89
from bzrlib.inventory import Inventory, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
90
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
91
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
92
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
93
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
94
from bzrlib.workingtree import WorkingTree
1189 by Martin Pool
- BROKEN: partial support for commit into weave
95
96
97
class NullCommitReporter(object):
98
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
99
100
    def snapshot_change(self, change, path):
101
        pass
102
103
    def completed(self, revno, rev_id):
104
        pass
105
106
    def deleted(self, file_id):
107
        pass
108
109
    def escaped(self, escape_count, message):
110
        pass
111
112
    def missing(self, path):
113
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
114
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
115
    def renamed(self, change, old_path, new_path):
116
        pass
117
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
118
1189 by Martin Pool
- BROKEN: partial support for commit into weave
119
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
120
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
121
    # this may be more useful if 'note' was replaced by an overridable
122
    # method on self, which would allow more trivial subclassing.
123
    # alternative, a callable could be passed in, allowing really trivial
124
    # reuse for some uis. RBC 20060511
125
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
126
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
127
        if change == 'unchanged':
128
            return
1731.1.45 by Aaron Bentley
Merge bzr.dev
129
        if change == 'added' and path == '':
130
            return
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
131
        note("%s %s", change, path)
132
133
    def completed(self, revno, rev_id):
1607.1.5 by Robert Collins
Make commit verbose mode work!.
134
        note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
135
    
136
    def deleted(self, file_id):
137
        note('deleted %s', file_id)
138
139
    def escaped(self, escape_count, message):
140
        note("replaced %d control characters in message", escape_count)
141
142
    def missing(self, path):
143
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
144
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
145
    def renamed(self, change, old_path, new_path):
146
        note('%s %s => %s', change, old_path, new_path)
147
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
148
1189 by Martin Pool
- BROKEN: partial support for commit into weave
149
class Commit(object):
150
    """Task of committing a new revision.
151
152
    This is a MethodObject: it accumulates state as the commit is
153
    prepared, and then it is discarded.  It doesn't represent
154
    historical revisions, just the act of recording a new one.
155
156
            missing_ids
157
            Modified to hold a list of files that have been deleted from
158
            the working directory; these should be removed from the
159
            working inventory.
485 by Martin Pool
- move commit code into its own module
160
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
161
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
162
                 reporter=None,
163
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
164
        if reporter is not None:
165
            self.reporter = reporter
166
        else:
167
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
168
        if config is not None:
169
            self.config = config
170
        else:
171
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
172
        
173
    def commit(self,
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
174
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
175
               timestamp=None,
176
               timezone=None,
177
               committer=None,
178
               specific_files=None,
179
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
180
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
181
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
182
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
183
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
184
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
185
               local=False,
186
               reporter=None,
187
               config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
188
        """Commit working copy as a new revision.
189
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
190
        branch -- the deprecated branch to commit to. New callers should pass in 
191
                  working_tree instead
192
193
        message -- the commit message, a mandatory parameter
194
1189 by Martin Pool
- BROKEN: partial support for commit into weave
195
        timestamp -- if not None, seconds-since-epoch for a
196
             postdated/predated commit.
197
1253 by Martin Pool
- test that pointless commits are trapped
198
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
199
1253 by Martin Pool
- test that pointless commits are trapped
200
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
201
            Useful for test or import commands that need to tightly
202
            control what revisions are assigned.  If you duplicate
203
            a revision id that exists elsewhere it is your own fault.
204
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
205
206
        allow_pointless -- If true (default), commit even if nothing
207
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
208
1185.16.65 by mbp at sourcefrog
- new commit --strict option
209
        strict -- If true, don't allow a commit if the working tree
210
            contains unknown files.
211
1185.16.35 by Martin Pool
- stub for revision properties
212
        revprops -- Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
213
        :param local: Perform a local only commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
214
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
215
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
216
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
217
        if deprecated_passed(branch):
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
218
            symbol_versioning.warn("Commit.commit (branch, ...): The branch parameter is "
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
219
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
220
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
221
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
222
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
223
        elif working_tree is None:
224
            raise BzrError("One of branch and working_tree must be passed into commit().")
225
        else:
226
            self.work_tree = working_tree
227
            self.branch = self.work_tree.branch
228
        if message is None:
229
            raise BzrError("The message keyword parameter is required for commit().")
230
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
231
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
232
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
233
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
234
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
235
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
236
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
237
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
238
1607.1.5 by Robert Collins
Make commit verbose mode work!.
239
        if reporter is None and self.reporter is None:
240
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
241
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
242
            self.reporter = reporter
243
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
244
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
245
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
246
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
247
            # Cannot commit with conflicts present.
248
            if len(self.work_tree.conflicts())>0:
249
                raise ConflictsInTree
250
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
251
            # setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
252
            self._check_bound_branch()
253
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
254
            # check for out of date working trees
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
255
            try:
256
                first_tree_parent = self.work_tree.get_parent_ids()[0]
257
            except IndexError:
258
                # if there are no parents, treat our parent as 'None'
259
                # this is so that we still consier the master branch
260
                # - in a checkout scenario the tree may have no
261
                # parents but the branch may do.
262
                first_tree_parent = None
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
263
            master_last = self.master_branch.last_revision()
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
264
            if (master_last is not None and
265
                master_last != first_tree_parent):
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
266
                raise errors.OutOfDateTree(self.work_tree)
267
    
268
            if strict:
269
                # raise an exception as soon as we find a single unknown.
270
                for unknown in self.work_tree.unknowns():
271
                    raise StrictCommitFailed()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
272
                   
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
273
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
274
                self.config = self.branch.get_config()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
275
      
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
276
            if isinstance(message, str):
277
                message = message.decode(bzrlib.user_encoding)
278
            assert isinstance(message, unicode), type(message)
279
            self.message = message
280
            self._escape_commit_message()
281
1189 by Martin Pool
- BROKEN: partial support for commit into weave
282
            self.work_inv = self.work_tree.inventory
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
283
            self.basis_tree = self.work_tree.basis_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
284
            self.basis_inv = self.basis_tree.inventory
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
285
            if specific_files is not None:
286
                # Ensure specified files are versioned
287
                # (We don't actually need the ids here)
288
                tree.find_ids_across_trees(specific_files, 
289
                                           [self.basis_tree, self.work_tree])
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
290
            # one to finish, one for rev and inventory, and one for each
291
            # inventory entry, and the same for the new inventory.
292
            # note that this estimate is too long when we do a partial tree
293
            # commit which excludes some new files from being considered.
294
            # The estimate is corrected when we populate the new inv.
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
295
            self.pb_total = len(self.work_inv) + 5
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
296
            self.pb_count = 0
1189 by Martin Pool
- BROKEN: partial support for commit into weave
297
1223 by Martin Pool
- store inventories in weave
298
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
299
            if len(self.parents) > 1 and self.specific_files:
1704.2.11 by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges.
300
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
301
                        self.specific_files)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
302
            
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
303
            self.builder = self.branch.get_commit_builder(self.parents, 
304
                self.config, timestamp, timezone, committer, revprops, rev_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
305
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
306
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
307
            self._populate_new_inv()
1248 by Martin Pool
- new weave based cleanup [broken]
308
            self._report_deletes()
1245 by Martin Pool
doc
309
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
310
            self._check_pointless()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
311
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
312
            self._emit_progress_update()
1910.2.3 by Aaron Bentley
All tests pass
313
            # TODO: Now the new inventory is known, check for conflicts and
314
            # prompt the user for a commit message.
315
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
316
            # weave lines, because nothing should be recorded until it is known
317
            # that commit will succeed.
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
318
            self.builder.finish_inventory()
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
319
            self._emit_progress_update()
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
320
            self.rev_id = self.builder.commit(self.message)
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
321
            self._emit_progress_update()
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
322
            # revision data is in the local branch now.
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
323
            
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
324
            # upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
325
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
326
            if self.bound_branch:
327
                self.master_branch.repository.fetch(self.branch.repository,
328
                                                    revision_id=self.rev_id)
329
                # now the master has the revision data
330
                # 'commit' to the master first so a timeout here causes the local
331
                # branch to be out of date
332
                self.master_branch.append_revision(self.rev_id)
333
334
            # and now do the commit locally.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
335
            self.branch.append_revision(self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
336
2041.1.5 by John Arbash Meinel
CommitBuilder.get_tree => CommitBuilder.revision_tree
337
            rev_tree = self.builder.revision_tree()
2041.1.2 by John Arbash Meinel
Update WorkingTree.set_parent_trees() to directly cache inv.
338
            self.work_tree.set_parent_trees([(self.rev_id, rev_tree)])
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
339
            # now the work tree is up to date with the branch
340
            
1607.1.5 by Robert Collins
Make commit verbose mode work!.
341
            self.reporter.completed(self.branch.revno(), self.rev_id)
1472 by Robert Collins
post commit hook, first pass implementation
342
            if self.config.post_commit() is not None:
343
                hooks = self.config.post_commit().split(' ')
344
                # this would be nicer with twisted.python.reflect.namedAny
345
                for hook in hooks:
346
                    result = eval(hook + '(branch, rev_id)',
347
                                  {'branch':self.branch,
348
                                   'bzrlib':bzrlib,
349
                                   'rev_id':self.rev_id})
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
350
            self._emit_progress_update()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
351
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
352
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
353
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
354
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
355
    def _any_real_changes(self):
356
        """Are there real changes between new_inventory and basis?
357
358
        For trees without rich roots, inv.root.revision changes every commit.
359
        But if that is the only change, we want to treat it as though there
360
        are *no* changes.
361
        """
362
        new_entries = self.builder.new_inventory.iter_entries()
363
        basis_entries = self.basis_inv.iter_entries()
364
        new_path, new_root_ie = new_entries.next()
365
        basis_path, basis_root_ie = basis_entries.next()
366
367
        # This is a copy of InventoryEntry.__eq__ only leaving out .revision
368
        def ie_equal_no_revision(this, other):
369
            return ((this.file_id == other.file_id)
370
                    and (this.name == other.name)
371
                    and (this.symlink_target == other.symlink_target)
372
                    and (this.text_sha1 == other.text_sha1)
373
                    and (this.text_size == other.text_size)
374
                    and (this.text_id == other.text_id)
375
                    and (this.parent_id == other.parent_id)
376
                    and (this.kind == other.kind)
377
                    and (this.executable == other.executable)
378
                    )
379
        if not ie_equal_no_revision(new_root_ie, basis_root_ie):
380
            return True
381
382
        for new_ie, basis_ie in zip(new_entries, basis_entries):
383
            if new_ie != basis_ie:
384
                return True
385
386
        # No actual changes present
387
        return False
388
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
389
    def _check_pointless(self):
390
        if self.allow_pointless:
391
            return
392
        # A merge with no effect on files
393
        if len(self.parents) > 1:
394
            return
395
        # work around the fact that a newly-initted tree does differ from its
396
        # basis
1731.1.49 by Aaron Bentley
Merge bzr.dev
397
        if len(self.basis_inv) == 0 and len(self.builder.new_inventory) == 1:
398
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
399
        # Shortcut, if the number of entries changes, then we obviously have
400
        # a change
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
401
        if len(self.builder.new_inventory) != len(self.basis_inv):
402
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
403
        # If length == 1, then we only have the root entry. Which means
404
        # that there is no real difference (only the root could be different)
405
        if (len(self.builder.new_inventory) != 1 and self._any_real_changes()):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
406
            return
407
        raise PointlessCommit()
408
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
409
    def _check_bound_branch(self):
410
        """Check to see if the local branch is bound.
411
412
        If it is bound, then most of the commit will actually be
413
        done using the remote branch as the target branch.
414
        Only at the end will the local branch be updated.
415
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
416
        if self.local and not self.branch.get_bound_location():
417
            raise errors.LocalRequiresBoundBranch()
418
419
        if not self.local:
420
            self.master_branch = self.branch.get_master_branch()
421
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
422
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
423
            # make this branch the reference branch for out of date checks.
424
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
425
            return
426
427
        # If the master branch is bound, we must fail
428
        master_bound_location = self.master_branch.get_bound_location()
429
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
430
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
431
                    self.master_branch, master_bound_location)
432
433
        # TODO: jam 20051230 We could automatically push local
434
        #       commits to the remote branch if they would fit.
435
        #       But for now, just require remote to be identical
436
        #       to local.
437
        
438
        # Make sure the local branch is identical to the master
439
        master_rh = self.master_branch.revision_history()
440
        local_rh = self.branch.revision_history()
441
        if local_rh != master_rh:
442
            raise errors.BoundBranchOutOfDate(self.branch,
443
                    self.master_branch)
444
445
        # Now things are ready to change the master branch
446
        # so grab the lock
447
        self.bound_branch = self.branch
448
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
449
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
450
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
451
    def _cleanup(self):
452
        """Cleanup any open locks, progress bars etc."""
453
        cleanups = [self._cleanup_bound_branch,
454
                    self.work_tree.unlock,
455
                    self.pb.finished]
456
        found_exception = None
457
        for cleanup in cleanups:
458
            try:
459
                cleanup()
460
            # we want every cleanup to run no matter what.
461
            # so we have a catchall here, but we will raise the
462
            # last encountered exception up the stack: and
463
            # typically this will be useful enough.
464
            except Exception, e:
465
                found_exception = e
466
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
467
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
468
            # trashed, e is our sure-to-work exception even though it loses the
469
            # full traceback. XXX: RBC 20060421 perhaps we could check the
470
            # exc_info and if its the same one do a plain raise otherwise 
471
            # 'raise e' as we do now.
472
            raise e
473
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
474
    def _cleanup_bound_branch(self):
475
        """Executed at the end of a try/finally to cleanup a bound branch.
476
477
        If the branch wasn't bound, this is a no-op.
478
        If it was, it resents self.branch to the local branch, instead
479
        of being the master.
480
        """
481
        if not self.bound_branch:
482
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
483
        if self.master_locked:
484
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
485
1390 by Robert Collins
pair programming worx... merge integration and weave
486
    def _escape_commit_message(self):
487
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
488
        # FIXME: RBC 20060419 this should be done by the revision
489
        # serialiser not by commit. Then we can also add an unescaper
490
        # in the deserializer and start roundtripping revision messages
491
        # precisely. See repository_implementations/test_repository.py
492
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
493
        # Python strings can include characters that can't be
494
        # represented in well-formed XML; escape characters that
495
        # aren't listed in the XML specification
496
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
497
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
498
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
499
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
500
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
501
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
502
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
503
504
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
505
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
506
        # TODO: Make sure that this list doesn't contain duplicate 
507
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
508
        self.parents = self.work_tree.get_parent_ids()
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
509
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
510
        for revision in self.parents:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
511
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
512
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
513
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
514
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
515
            else:
516
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
517
1189 by Martin Pool
- BROKEN: partial support for commit into weave
518
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
519
        """Remove deleted files from the working inventories.
520
521
        This is done prior to taking the working inventory as the
522
        basis for the new committed inventory.
523
524
        This returns true if any files
525
        *that existed in the basis inventory* were deleted.
526
        Files that were added and deleted
527
        in the working copy don't matter.
528
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
529
        specific = self.specific_files
530
        deleted_ids = []
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
531
        deleted_paths = set()
1254 by Martin Pool
- fix handling of selective commit with deleted files
532
        for path, ie in self.work_inv.iter_entries():
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
533
            if is_inside_any(deleted_paths, path):
534
                # The tree will delete the required ids recursively.
535
                continue
1254 by Martin Pool
- fix handling of selective commit with deleted files
536
            if specific and not is_inside_any(specific, path):
537
                continue
538
            if not self.work_tree.has_filename(path):
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
539
                deleted_paths.add(path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
540
                self.reporter.missing(path)
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
541
                deleted_ids.append(ie.file_id)
542
        self.work_tree.unversion(deleted_ids)
1248 by Martin Pool
- new weave based cleanup [broken]
543
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
544
    def _populate_new_inv(self):
545
        """Build revision inventory.
546
547
        This creates a new empty inventory. Depending on
548
        which files are selected for commit, and what is present in the
549
        current tree, the new inventory is populated. inventory entries 
550
        which are candidates for modification have their revision set to
551
        None; inventory entries that are carried over untouched have their
552
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
553
        """
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
554
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
555
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
556
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
557
        # ADHB 11-07-2006
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
558
        mutter("Selecting files for commit with filter %s", self.specific_files)
1731.1.64 by Aaron Bentley
Fix up more memorytree tests
559
        assert self.work_inv.root is not None
1910.2.4 by Aaron Bentley
Support old CommitBuilders
560
        entries = self.work_inv.iter_entries()
561
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
562
            symbol_versioning.warn('CommitBuilders should support recording'
563
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
564
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
565
            self.builder.new_inventory.add(self.basis_inv.root.copy())
566
            entries.next()
567
            self._emit_progress_update()
568
        for path, new_ie in entries:
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
569
            self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
570
            file_id = new_ie.file_id
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
571
            # mutter('check %s {%s}', path, file_id)
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
572
            if (not self.specific_files or 
573
                is_inside_or_parent_of_any(self.specific_files, path)):
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
574
                    # mutter('%s selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
575
                    ie = new_ie.copy()
576
                    ie.revision = None
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
577
            else:
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
578
                # mutter('%s not selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
579
                if self.basis_inv.has_id(file_id):
580
                    ie = self.basis_inv[file_id].copy()
581
                else:
582
                    # this entry is new and not being committed
583
                    continue
1731.1.62 by Aaron Bentley
Changes from review comments
584
            self.builder.record_entry_contents(ie, self.parent_invs, 
585
                path, self.work_tree)
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
586
            # describe the nature of the change that has occurred relative to
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
587
            # the basis inventory.
588
            if (self.basis_inv.has_id(ie.file_id)):
589
                basis_ie = self.basis_inv[ie.file_id]
590
            else:
591
                basis_ie = None
592
            change = ie.describe_change(basis_ie, ie)
593
            if change in (InventoryEntry.RENAMED, 
594
                InventoryEntry.MODIFIED_AND_RENAMED):
595
                old_path = self.basis_inv.id2path(ie.file_id)
596
                self.reporter.renamed(change, old_path, path)
597
            else:
598
                self.reporter.snapshot_change(change, path)
1416 by Robert Collins
when committing a specific file, include all its parents
599
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
600
        if not self.specific_files:
601
            return
602
603
        # ignore removals that don't match filespec
604
        for path, new_ie in self.basis_inv.iter_entries():
605
            if new_ie.file_id in self.work_inv:
606
                continue
607
            if is_inside_any(self.specific_files, path):
608
                continue
609
            ie = new_ie.copy()
610
            ie.revision = None
611
            self.builder.record_entry_contents(ie, self.parent_invs, path,
612
                                               self.basis_tree)
613
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
614
    def _emit_progress_update(self):
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
615
        """Emit an update to the progress bar."""
616
        self.pb.update("Committing", self.pb_count, self.pb_total)
617
        self.pb_count += 1
618
1248 by Martin Pool
- new weave based cleanup [broken]
619
    def _report_deletes(self):
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
620
        for path, ie in self.basis_inv.iter_entries():
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
621
            if ie.file_id not in self.builder.new_inventory:
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
622
                self.reporter.deleted(path)
1248 by Martin Pool
- new weave based cleanup [broken]
623
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
624