~bzr-pqm/bzr/bzr.dev

1704.2.14 by Martin Pool
[merge] work from 0.8 fixes
1
# Copyright (C) 2005, 2006 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
1755.3.1 by Robert Collins
Tune the time to build our kernel_like tree : make LocalTransport.put faster, AtomicFile faster, LocalTransport.append faster.
19
# nothing?  
1248 by Martin Pool
- new weave based cleanup [broken]
20
21
# TODO: Separate 'prepare' phase where we find a list of potentially
22
# committed files.  We then can then pause the commit to prompt for a
23
# commit message, knowing the summary will be the same as what's
24
# actually used for the commit.  (But perhaps simpler to simply get
25
# the tree status, then use that for a selective commit?)
26
27
# The newly committed revision is going to have a shape corresponding
28
# to that of the working inventory.  Files that are not in the
29
# working tree and that were in the predecessor are reported as
30
# removed --- this can include files that were either removed from the
31
# inventory or deleted in the working tree.  If they were only
32
# deleted from disk, they are removed from the working inventory.
33
34
# We then consider the remaining entries, which will be in the new
35
# version.  Directory entries are simply copied across.  File entries
36
# must be checked to see if a new version of the file should be
37
# recorded.  For each parent revision inventory, we check to see what
38
# version of the file was present.  If the file was present in at
39
# least one tree, and if it was the same version in all the trees,
40
# then we can just refer to that version.  Otherwise, a new version
41
# representing the merger of the file versions must be added.
42
43
# TODO: Update hashcache before and after - or does the WorkingTree
44
# look after that?
1245 by Martin Pool
doc
45
1339 by Martin Pool
- doc
46
# TODO: Rather than mashing together the ancestry and storing it back,
47
# perhaps the weave should have single method which does it all in one
48
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
49
1341 by Martin Pool
- doc
50
# TODO: Perhaps give a warning if one of the revisions marked as
51
# merged is already in the ancestry, and then don't record it as a
52
# distinct parent.
53
1343 by Martin Pool
- fix up test for merge of trees
54
# TODO: If the file is newly merged but unchanged from the version it
55
# merges from, then it should still be reported as newly added
56
# relative to the basis revision.
57
1185.16.66 by mbp at sourcefrog
- todo
58
# TODO: Do checks that the tree can be committed *before* running the 
59
# editor; this should include checks for a pointless commit and for 
60
# unknown or missing files.
61
62
# TODO: If commit fails, leave the message in a file somewhere.
63
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
64
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
65
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
66
1189 by Martin Pool
- BROKEN: partial support for commit into weave
67
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
68
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
69
import sys
1188 by Martin Pool
- clean up imports in commit code
70
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
71
72
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
73
1551.8.30 by Aaron Bentley
Tweak from review comments
74
from bzrlib import (
75
    errors,
76
    tree,
77
    )
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
78
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
79
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
80
                           ConflictsInTree,
81
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
82
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
83
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
84
                            is_inside_or_parent_of_any,
85
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
86
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
87
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
88
from bzrlib.xml5 import serializer_v5
1907.1.1 by Aaron Bentley
Unshelved all changes except those related to removing RootEntry
89
from bzrlib.inventory import Inventory, ROOT_ID, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
90
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
91
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
92
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
93
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
94
from bzrlib.workingtree import WorkingTree
1189 by Martin Pool
- BROKEN: partial support for commit into weave
95
96
97
class NullCommitReporter(object):
98
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
99
100
    def snapshot_change(self, change, path):
101
        pass
102
103
    def completed(self, revno, rev_id):
104
        pass
105
106
    def deleted(self, file_id):
107
        pass
108
109
    def escaped(self, escape_count, message):
110
        pass
111
112
    def missing(self, path):
113
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
114
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
115
    def renamed(self, change, old_path, new_path):
116
        pass
117
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
118
1189 by Martin Pool
- BROKEN: partial support for commit into weave
119
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
120
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
121
    # this may be more useful if 'note' was replaced by an overridable
122
    # method on self, which would allow more trivial subclassing.
123
    # alternative, a callable could be passed in, allowing really trivial
124
    # reuse for some uis. RBC 20060511
125
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
126
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
127
        if change == 'unchanged':
128
            return
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
129
        note("%s %s", change, path)
130
131
    def completed(self, revno, rev_id):
1607.1.5 by Robert Collins
Make commit verbose mode work!.
132
        note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
133
    
134
    def deleted(self, file_id):
135
        note('deleted %s', file_id)
136
137
    def escaped(self, escape_count, message):
138
        note("replaced %d control characters in message", escape_count)
139
140
    def missing(self, path):
141
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
142
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
143
    def renamed(self, change, old_path, new_path):
144
        note('%s %s => %s', change, old_path, new_path)
145
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
146
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
class Commit(object):
148
    """Task of committing a new revision.
149
150
    This is a MethodObject: it accumulates state as the commit is
151
    prepared, and then it is discarded.  It doesn't represent
152
    historical revisions, just the act of recording a new one.
153
154
            missing_ids
155
            Modified to hold a list of files that have been deleted from
156
            the working directory; these should be removed from the
157
            working inventory.
485 by Martin Pool
- move commit code into its own module
158
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
159
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
160
                 reporter=None,
161
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
162
        if reporter is not None:
163
            self.reporter = reporter
164
        else:
165
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
166
        if config is not None:
167
            self.config = config
168
        else:
169
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
        
171
    def commit(self,
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
172
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
173
               timestamp=None,
174
               timezone=None,
175
               committer=None,
176
               specific_files=None,
177
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
178
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
179
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
180
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
181
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
182
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
183
               local=False,
184
               reporter=None,
185
               config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
186
        """Commit working copy as a new revision.
187
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
188
        branch -- the deprecated branch to commit to. New callers should pass in 
189
                  working_tree instead
190
191
        message -- the commit message, a mandatory parameter
192
1189 by Martin Pool
- BROKEN: partial support for commit into weave
193
        timestamp -- if not None, seconds-since-epoch for a
194
             postdated/predated commit.
195
1253 by Martin Pool
- test that pointless commits are trapped
196
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
197
1253 by Martin Pool
- test that pointless commits are trapped
198
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
199
            Useful for test or import commands that need to tightly
200
            control what revisions are assigned.  If you duplicate
201
            a revision id that exists elsewhere it is your own fault.
202
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
203
204
        allow_pointless -- If true (default), commit even if nothing
205
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
206
1185.16.65 by mbp at sourcefrog
- new commit --strict option
207
        strict -- If true, don't allow a commit if the working tree
208
            contains unknown files.
209
1185.16.35 by Martin Pool
- stub for revision properties
210
        revprops -- Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
211
        :param local: Perform a local only commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
212
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
213
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
214
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
215
        if deprecated_passed(branch):
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
216
            symbol_versioning.warn("Commit.commit (branch, ...): The branch parameter is "
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
217
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
218
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
219
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
220
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
221
        elif working_tree is None:
222
            raise BzrError("One of branch and working_tree must be passed into commit().")
223
        else:
224
            self.work_tree = working_tree
225
            self.branch = self.work_tree.branch
226
        if message is None:
227
            raise BzrError("The message keyword parameter is required for commit().")
228
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
229
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
230
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
231
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
232
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
233
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
234
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
235
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
236
1607.1.5 by Robert Collins
Make commit verbose mode work!.
237
        if reporter is None and self.reporter is None:
238
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
239
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
240
            self.reporter = reporter
241
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
242
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
243
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
244
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
245
            # Cannot commit with conflicts present.
246
            if len(self.work_tree.conflicts())>0:
247
                raise ConflictsInTree
248
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
249
            # setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
250
            self._check_bound_branch()
251
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
252
            # check for out of date working trees
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
253
            try:
254
                first_tree_parent = self.work_tree.get_parent_ids()[0]
255
            except IndexError:
256
                # if there are no parents, treat our parent as 'None'
257
                # this is so that we still consier the master branch
258
                # - in a checkout scenario the tree may have no
259
                # parents but the branch may do.
260
                first_tree_parent = None
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
261
            master_last = self.master_branch.last_revision()
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
262
            if (master_last is not None and
263
                master_last != first_tree_parent):
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
264
                raise errors.OutOfDateTree(self.work_tree)
265
    
266
            if strict:
267
                # raise an exception as soon as we find a single unknown.
268
                for unknown in self.work_tree.unknowns():
269
                    raise StrictCommitFailed()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
270
                   
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
271
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
272
                self.config = self.branch.get_config()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
273
      
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
274
            if isinstance(message, str):
275
                message = message.decode(bzrlib.user_encoding)
276
            assert isinstance(message, unicode), type(message)
277
            self.message = message
278
            self._escape_commit_message()
279
1189 by Martin Pool
- BROKEN: partial support for commit into weave
280
            self.work_inv = self.work_tree.inventory
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
281
            self.basis_tree = self.work_tree.basis_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
282
            self.basis_inv = self.basis_tree.inventory
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
283
            if specific_files is not None:
284
                # Ensure specified files are versioned
285
                # (We don't actually need the ids here)
286
                tree.find_ids_across_trees(specific_files, 
287
                                           [self.basis_tree, self.work_tree])
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
288
            # one to finish, one for rev and inventory, and one for each
289
            # inventory entry, and the same for the new inventory.
290
            # note that this estimate is too long when we do a partial tree
291
            # commit which excludes some new files from being considered.
292
            # The estimate is corrected when we populate the new inv.
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
293
            self.pb_total = len(self.work_inv) + 5
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
294
            self.pb_count = 0
1189 by Martin Pool
- BROKEN: partial support for commit into weave
295
1223 by Martin Pool
- store inventories in weave
296
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
297
            if len(self.parents) > 1 and self.specific_files:
1704.2.11 by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges.
298
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
299
                        self.specific_files)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
300
            
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
301
            self.builder = self.branch.get_commit_builder(self.parents, 
302
                self.config, timestamp, timezone, committer, revprops, rev_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
303
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
304
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
305
            self._populate_new_inv()
1248 by Martin Pool
- new weave based cleanup [broken]
306
            self._report_deletes()
1245 by Martin Pool
doc
307
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
308
            self._check_pointless()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
309
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
310
            self._emit_progress_update()
1910.2.3 by Aaron Bentley
All tests pass
311
            # TODO: Now the new inventory is known, check for conflicts and
312
            # prompt the user for a commit message.
313
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
314
            # weave lines, because nothing should be recorded until it is known
315
            # that commit will succeed.
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
316
            self.builder.finish_inventory()
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
317
            self._emit_progress_update()
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
318
            self.rev_id = self.builder.commit(self.message)
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
319
            self._emit_progress_update()
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
320
            # revision data is in the local branch now.
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
321
            
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
322
            # upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
323
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
324
            if self.bound_branch:
325
                self.master_branch.repository.fetch(self.branch.repository,
326
                                                    revision_id=self.rev_id)
327
                # now the master has the revision data
328
                # 'commit' to the master first so a timeout here causes the local
329
                # branch to be out of date
330
                self.master_branch.append_revision(self.rev_id)
331
332
            # and now do the commit locally.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
333
            self.branch.append_revision(self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
334
2041.1.5 by John Arbash Meinel
CommitBuilder.get_tree => CommitBuilder.revision_tree
335
            rev_tree = self.builder.revision_tree()
2041.1.2 by John Arbash Meinel
Update WorkingTree.set_parent_trees() to directly cache inv.
336
            self.work_tree.set_parent_trees([(self.rev_id, rev_tree)])
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
337
            # now the work tree is up to date with the branch
338
            
1607.1.5 by Robert Collins
Make commit verbose mode work!.
339
            self.reporter.completed(self.branch.revno(), self.rev_id)
1472 by Robert Collins
post commit hook, first pass implementation
340
            if self.config.post_commit() is not None:
341
                hooks = self.config.post_commit().split(' ')
342
                # this would be nicer with twisted.python.reflect.namedAny
343
                for hook in hooks:
344
                    result = eval(hook + '(branch, rev_id)',
345
                                  {'branch':self.branch,
346
                                   'bzrlib':bzrlib,
347
                                   'rev_id':self.rev_id})
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
348
            self._emit_progress_update()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
349
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
350
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
351
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
352
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
353
    def _any_real_changes(self):
354
        """Are there real changes between new_inventory and basis?
355
356
        For trees without rich roots, inv.root.revision changes every commit.
357
        But if that is the only change, we want to treat it as though there
358
        are *no* changes.
359
        """
360
        new_entries = self.builder.new_inventory.iter_entries()
361
        basis_entries = self.basis_inv.iter_entries()
362
        new_path, new_root_ie = new_entries.next()
363
        basis_path, basis_root_ie = basis_entries.next()
364
365
        # This is a copy of InventoryEntry.__eq__ only leaving out .revision
366
        def ie_equal_no_revision(this, other):
367
            return ((this.file_id == other.file_id)
368
                    and (this.name == other.name)
369
                    and (this.symlink_target == other.symlink_target)
370
                    and (this.text_sha1 == other.text_sha1)
371
                    and (this.text_size == other.text_size)
372
                    and (this.text_id == other.text_id)
373
                    and (this.parent_id == other.parent_id)
374
                    and (this.kind == other.kind)
375
                    and (this.executable == other.executable)
376
                    )
377
        if not ie_equal_no_revision(new_root_ie, basis_root_ie):
378
            return True
379
380
        for new_ie, basis_ie in zip(new_entries, basis_entries):
381
            if new_ie != basis_ie:
382
                return True
383
384
        # No actual changes present
385
        return False
386
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
387
    def _check_pointless(self):
388
        if self.allow_pointless:
389
            return
390
        # A merge with no effect on files
391
        if len(self.parents) > 1:
392
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
393
        # Shortcut, if the number of entries changes, then we obviously have
394
        # a change
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
395
        if len(self.builder.new_inventory) != len(self.basis_inv):
396
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
397
        # If length == 1, then we only have the root entry. Which means
398
        # that there is no real difference (only the root could be different)
399
        if (len(self.builder.new_inventory) != 1 and self._any_real_changes()):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
400
            return
401
        raise PointlessCommit()
402
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
403
    def _check_bound_branch(self):
404
        """Check to see if the local branch is bound.
405
406
        If it is bound, then most of the commit will actually be
407
        done using the remote branch as the target branch.
408
        Only at the end will the local branch be updated.
409
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
410
        if self.local and not self.branch.get_bound_location():
411
            raise errors.LocalRequiresBoundBranch()
412
413
        if not self.local:
414
            self.master_branch = self.branch.get_master_branch()
415
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
416
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
417
            # make this branch the reference branch for out of date checks.
418
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
419
            return
420
421
        # If the master branch is bound, we must fail
422
        master_bound_location = self.master_branch.get_bound_location()
423
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
424
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
425
                    self.master_branch, master_bound_location)
426
427
        # TODO: jam 20051230 We could automatically push local
428
        #       commits to the remote branch if they would fit.
429
        #       But for now, just require remote to be identical
430
        #       to local.
431
        
432
        # Make sure the local branch is identical to the master
433
        master_rh = self.master_branch.revision_history()
434
        local_rh = self.branch.revision_history()
435
        if local_rh != master_rh:
436
            raise errors.BoundBranchOutOfDate(self.branch,
437
                    self.master_branch)
438
439
        # Now things are ready to change the master branch
440
        # so grab the lock
441
        self.bound_branch = self.branch
442
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
443
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
444
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
445
    def _cleanup(self):
446
        """Cleanup any open locks, progress bars etc."""
447
        cleanups = [self._cleanup_bound_branch,
448
                    self.work_tree.unlock,
449
                    self.pb.finished]
450
        found_exception = None
451
        for cleanup in cleanups:
452
            try:
453
                cleanup()
454
            # we want every cleanup to run no matter what.
455
            # so we have a catchall here, but we will raise the
456
            # last encountered exception up the stack: and
457
            # typically this will be useful enough.
458
            except Exception, e:
459
                found_exception = e
460
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
461
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
462
            # trashed, e is our sure-to-work exception even though it loses the
463
            # full traceback. XXX: RBC 20060421 perhaps we could check the
464
            # exc_info and if its the same one do a plain raise otherwise 
465
            # 'raise e' as we do now.
466
            raise e
467
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
468
    def _cleanup_bound_branch(self):
469
        """Executed at the end of a try/finally to cleanup a bound branch.
470
471
        If the branch wasn't bound, this is a no-op.
472
        If it was, it resents self.branch to the local branch, instead
473
        of being the master.
474
        """
475
        if not self.bound_branch:
476
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
477
        if self.master_locked:
478
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
479
1390 by Robert Collins
pair programming worx... merge integration and weave
480
    def _escape_commit_message(self):
481
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
482
        # FIXME: RBC 20060419 this should be done by the revision
483
        # serialiser not by commit. Then we can also add an unescaper
484
        # in the deserializer and start roundtripping revision messages
485
        # precisely. See repository_implementations/test_repository.py
486
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
487
        # Python strings can include characters that can't be
488
        # represented in well-formed XML; escape characters that
489
        # aren't listed in the XML specification
490
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
491
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
492
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
493
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
494
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
495
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
496
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
497
498
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
499
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
500
        # TODO: Make sure that this list doesn't contain duplicate 
501
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
502
        self.parents = self.work_tree.get_parent_ids()
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
503
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
504
        for revision in self.parents:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
505
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
506
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
507
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
508
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
509
            else:
510
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
511
1189 by Martin Pool
- BROKEN: partial support for commit into weave
512
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
513
        """Remove deleted files from the working inventories.
514
515
        This is done prior to taking the working inventory as the
516
        basis for the new committed inventory.
517
518
        This returns true if any files
519
        *that existed in the basis inventory* were deleted.
520
        Files that were added and deleted
521
        in the working copy don't matter.
522
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
523
        specific = self.specific_files
524
        deleted_ids = []
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
525
        deleted_paths = set()
1254 by Martin Pool
- fix handling of selective commit with deleted files
526
        for path, ie in self.work_inv.iter_entries():
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
527
            if is_inside_any(deleted_paths, path):
528
                # The tree will delete the required ids recursively.
529
                continue
1254 by Martin Pool
- fix handling of selective commit with deleted files
530
            if specific and not is_inside_any(specific, path):
531
                continue
532
            if not self.work_tree.has_filename(path):
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
533
                deleted_paths.add(path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
534
                self.reporter.missing(path)
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
535
                deleted_ids.append(ie.file_id)
536
        self.work_tree.unversion(deleted_ids)
1248 by Martin Pool
- new weave based cleanup [broken]
537
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
538
    def _populate_new_inv(self):
539
        """Build revision inventory.
540
541
        This creates a new empty inventory. Depending on
542
        which files are selected for commit, and what is present in the
543
        current tree, the new inventory is populated. inventory entries 
544
        which are candidates for modification have their revision set to
545
        None; inventory entries that are carried over untouched have their
546
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
547
        """
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
548
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
549
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
550
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
551
        # ADHB 11-07-2006
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
552
        mutter("Selecting files for commit with filter %s", self.specific_files)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
553
        entries = self.work_inv.iter_entries()
554
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
555
            symbol_versioning.warn('CommitBuilders should support recording'
556
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
557
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
558
            self.builder.new_inventory.add(self.basis_inv.root.copy())
559
            entries.next()
560
            self._emit_progress_update()
561
        for path, new_ie in entries:
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
562
            self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
563
            file_id = new_ie.file_id
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
564
            # mutter('check %s {%s}', path, file_id)
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
565
            if (not self.specific_files or 
566
                is_inside_or_parent_of_any(self.specific_files, path)):
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
567
                    # mutter('%s selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
568
                    ie = new_ie.copy()
569
                    ie.revision = None
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
570
            else:
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
571
                # mutter('%s not selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
572
                if self.basis_inv.has_id(file_id):
573
                    ie = self.basis_inv[file_id].copy()
574
                else:
575
                    # this entry is new and not being committed
576
                    continue
1907.1.1 by Aaron Bentley
Unshelved all changes except those related to removing RootEntry
577
578
            self.builder.record_entry_contents(ie, self.parent_invs, 
579
                path, self.work_tree)
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
580
            # describe the nature of the change that has occurred relative to
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
581
            # the basis inventory.
582
            if (self.basis_inv.has_id(ie.file_id)):
583
                basis_ie = self.basis_inv[ie.file_id]
584
            else:
585
                basis_ie = None
586
            change = ie.describe_change(basis_ie, ie)
587
            if change in (InventoryEntry.RENAMED, 
588
                InventoryEntry.MODIFIED_AND_RENAMED):
589
                old_path = self.basis_inv.id2path(ie.file_id)
590
                self.reporter.renamed(change, old_path, path)
591
            else:
592
                self.reporter.snapshot_change(change, path)
1416 by Robert Collins
when committing a specific file, include all its parents
593
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
594
        if not self.specific_files:
595
            return
596
597
        # ignore removals that don't match filespec
598
        for path, new_ie in self.basis_inv.iter_entries():
599
            if new_ie.file_id in self.work_inv:
600
                continue
601
            if is_inside_any(self.specific_files, path):
602
                continue
603
            ie = new_ie.copy()
604
            ie.revision = None
605
            self.builder.record_entry_contents(ie, self.parent_invs, path,
606
                                               self.basis_tree)
607
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
608
    def _emit_progress_update(self):
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
609
        """Emit an update to the progress bar."""
610
        self.pb.update("Committing", self.pb_count, self.pb_total)
611
        self.pb_count += 1
612
1248 by Martin Pool
- new weave based cleanup [broken]
613
    def _report_deletes(self):
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
614
        for path, ie in self.basis_inv.iter_entries():
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
615
            if ie.file_id not in self.builder.new_inventory:
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
616
                self.reporter.deleted(path)
1248 by Martin Pool
- new weave based cleanup [broken]
617
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
618