1704.2.14
by Martin Pool
[merge] work from 0.8 fixes |
1 |
# Copyright (C) 2005, 2006 Canonical Ltd
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
2 |
#
|
485
by Martin Pool
- move commit code into its own module |
3 |
# This program is free software; you can redistribute it and/or modify
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
1248
by Martin Pool
- new weave based cleanup [broken] |
7 |
#
|
485
by Martin Pool
- move commit code into its own module |
8 |
# This program is distributed in the hope that it will be useful,
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
1248
by Martin Pool
- new weave based cleanup [broken] |
12 |
#
|
485
by Martin Pool
- move commit code into its own module |
13 |
# You should have received a copy of the GNU General Public License
|
14 |
# along with this program; if not, write to the Free Software
|
|
15 |
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
16 |
||
17 |
||
1248
by Martin Pool
- new weave based cleanup [broken] |
18 |
# XXX: Can we do any better about making interrupted commits change
|
1755.3.1
by Robert Collins
Tune the time to build our kernel_like tree : make LocalTransport.put faster, AtomicFile faster, LocalTransport.append faster. |
19 |
# nothing?
|
1248
by Martin Pool
- new weave based cleanup [broken] |
20 |
|
21 |
# TODO: Separate 'prepare' phase where we find a list of potentially
|
|
22 |
# committed files. We then can then pause the commit to prompt for a
|
|
23 |
# commit message, knowing the summary will be the same as what's
|
|
24 |
# actually used for the commit. (But perhaps simpler to simply get
|
|
25 |
# the tree status, then use that for a selective commit?)
|
|
26 |
||
27 |
# The newly committed revision is going to have a shape corresponding
|
|
28 |
# to that of the working inventory. Files that are not in the
|
|
29 |
# working tree and that were in the predecessor are reported as
|
|
30 |
# removed --- this can include files that were either removed from the
|
|
31 |
# inventory or deleted in the working tree. If they were only
|
|
32 |
# deleted from disk, they are removed from the working inventory.
|
|
33 |
||
34 |
# We then consider the remaining entries, which will be in the new
|
|
35 |
# version. Directory entries are simply copied across. File entries
|
|
36 |
# must be checked to see if a new version of the file should be
|
|
37 |
# recorded. For each parent revision inventory, we check to see what
|
|
38 |
# version of the file was present. If the file was present in at
|
|
39 |
# least one tree, and if it was the same version in all the trees,
|
|
40 |
# then we can just refer to that version. Otherwise, a new version
|
|
41 |
# representing the merger of the file versions must be added.
|
|
42 |
||
43 |
# TODO: Update hashcache before and after - or does the WorkingTree
|
|
44 |
# look after that?
|
|
1245
by Martin Pool
doc |
45 |
|
1339
by Martin Pool
- doc |
46 |
# TODO: Rather than mashing together the ancestry and storing it back,
|
47 |
# perhaps the weave should have single method which does it all in one
|
|
48 |
# go, avoiding a lot of redundant work.
|
|
1335
by Martin Pool
doc |
49 |
|
1341
by Martin Pool
- doc |
50 |
# TODO: Perhaps give a warning if one of the revisions marked as
|
51 |
# merged is already in the ancestry, and then don't record it as a
|
|
52 |
# distinct parent.
|
|
53 |
||
1343
by Martin Pool
- fix up test for merge of trees |
54 |
# TODO: If the file is newly merged but unchanged from the version it
|
55 |
# merges from, then it should still be reported as newly added
|
|
56 |
# relative to the basis revision.
|
|
57 |
||
1185.16.66
by mbp at sourcefrog
- todo |
58 |
# TODO: Do checks that the tree can be committed *before* running the
|
59 |
# editor; this should include checks for a pointless commit and for
|
|
60 |
# unknown or missing files.
|
|
61 |
||
62 |
# TODO: If commit fails, leave the message in a file somewhere.
|
|
63 |
||
1194
by Martin Pool
- [BROKEN] more progress of commit into weaves |
64 |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
65 |
import os |
1390
by Robert Collins
pair programming worx... merge integration and weave |
66 |
import re |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
67 |
import sys |
1188
by Martin Pool
- clean up imports in commit code |
68 |
import time |
1194
by Martin Pool
- [BROKEN] more progress of commit into weaves |
69 |
|
70 |
from cStringIO import StringIO |
|
1188
by Martin Pool
- clean up imports in commit code |
71 |
|
1442.1.2
by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing. |
72 |
import bzrlib.config |
1508.1.22
by Robert Collins
implement out of date working tree checks in commit. |
73 |
import bzrlib.errors as errors |
1264
by Martin Pool
- Raise a better error from commit when a parent is absent |
74 |
from bzrlib.errors import (BzrError, PointlessCommit, |
1185.16.65
by mbp at sourcefrog
- new commit --strict option |
75 |
ConflictsInTree, |
76 |
StrictCommitFailed
|
|
1264
by Martin Pool
- Raise a better error from commit when a parent is absent |
77 |
)
|
1740.3.10
by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m. |
78 |
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, |
79 |
is_inside_or_parent_of_any, |
|
80 |
quotefn, sha_file, split_lines) |
|
1442.1.62
by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions. |
81 |
from bzrlib.testament import Testament |
1264
by Martin Pool
- Raise a better error from commit when a parent is absent |
82 |
from bzrlib.trace import mutter, note, warning |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
83 |
from bzrlib.xml5 import serializer_v5 |
1907.1.1
by Aaron Bentley
Unshelved all changes except those related to removing RootEntry |
84 |
from bzrlib.inventory import Inventory, ROOT_ID, InventoryEntry |
1910.2.9
by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API |
85 |
from bzrlib import symbol_versioning |
1773.4.1
by Martin Pool
Add pyflakes makefile target; fix many warnings |
86 |
from bzrlib.symbol_versioning import (deprecated_passed, |
1773.4.3
by Martin Pool
[merge] bzr.dev |
87 |
deprecated_function, |
1773.4.1
by Martin Pool
Add pyflakes makefile target; fix many warnings |
88 |
DEPRECATED_PARAMETER) |
1508.1.6
by Robert Collins
Move Branch.unknowns() to WorkingTree. |
89 |
from bzrlib.workingtree import WorkingTree |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
90 |
|
91 |
||
92 |
class NullCommitReporter(object): |
|
93 |
"""I report on progress of a commit."""
|
|
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
94 |
|
95 |
def snapshot_change(self, change, path): |
|
96 |
pass
|
|
97 |
||
98 |
def completed(self, revno, rev_id): |
|
99 |
pass
|
|
100 |
||
101 |
def deleted(self, file_id): |
|
102 |
pass
|
|
103 |
||
104 |
def escaped(self, escape_count, message): |
|
105 |
pass
|
|
106 |
||
107 |
def missing(self, path): |
|
108 |
pass
|
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
109 |
|
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
110 |
def renamed(self, change, old_path, new_path): |
111 |
pass
|
|
112 |
||
1508.1.6
by Robert Collins
Move Branch.unknowns() to WorkingTree. |
113 |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
114 |
class ReportCommitToLog(NullCommitReporter): |
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
115 |
|
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
116 |
# this may be more useful if 'note' was replaced by an overridable
|
117 |
# method on self, which would allow more trivial subclassing.
|
|
118 |
# alternative, a callable could be passed in, allowing really trivial
|
|
119 |
# reuse for some uis. RBC 20060511
|
|
120 |
||
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
121 |
def snapshot_change(self, change, path): |
1616.1.4
by Martin Pool
Verbose commit shouldn't talk about every unchanged file. |
122 |
if change == 'unchanged': |
123 |
return
|
|
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
124 |
note("%s %s", change, path) |
125 |
||
126 |
def completed(self, revno, rev_id): |
|
1607.1.5
by Robert Collins
Make commit verbose mode work!. |
127 |
note('Committed revision %d.', revno) |
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
128 |
|
129 |
def deleted(self, file_id): |
|
130 |
note('deleted %s', file_id) |
|
131 |
||
132 |
def escaped(self, escape_count, message): |
|
133 |
note("replaced %d control characters in message", escape_count) |
|
134 |
||
135 |
def missing(self, path): |
|
136 |
note('missing %s', path) |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
137 |
|
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
138 |
def renamed(self, change, old_path, new_path): |
139 |
note('%s %s => %s', change, old_path, new_path) |
|
140 |
||
1508.1.6
by Robert Collins
Move Branch.unknowns() to WorkingTree. |
141 |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
142 |
class Commit(object): |
143 |
"""Task of committing a new revision.
|
|
144 |
||
145 |
This is a MethodObject: it accumulates state as the commit is
|
|
146 |
prepared, and then it is discarded. It doesn't represent
|
|
147 |
historical revisions, just the act of recording a new one.
|
|
148 |
||
149 |
missing_ids
|
|
150 |
Modified to hold a list of files that have been deleted from
|
|
151 |
the working directory; these should be removed from the
|
|
152 |
working inventory.
|
|
485
by Martin Pool
- move commit code into its own module |
153 |
"""
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
154 |
def __init__(self, |
1442.1.60
by Robert Collins
gpg sign commits if the policy says we need to |
155 |
reporter=None, |
156 |
config=None): |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
157 |
if reporter is not None: |
158 |
self.reporter = reporter |
|
159 |
else: |
|
160 |
self.reporter = NullCommitReporter() |
|
1442.1.60
by Robert Collins
gpg sign commits if the policy says we need to |
161 |
if config is not None: |
162 |
self.config = config |
|
163 |
else: |
|
164 |
self.config = None |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
165 |
|
166 |
def commit(self, |
|
1534.4.32
by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER |
167 |
branch=DEPRECATED_PARAMETER, message=None, |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
168 |
timestamp=None, |
169 |
timezone=None, |
|
170 |
committer=None, |
|
171 |
specific_files=None, |
|
172 |
rev_id=None, |
|
1276
by Martin Pool
- make Branch.commit accept (and ignore) verbose argument |
173 |
allow_pointless=True, |
1185.16.65
by mbp at sourcefrog
- new commit --strict option |
174 |
strict=False, |
1185.16.35
by Martin Pool
- stub for revision properties |
175 |
verbose=False, |
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
176 |
revprops=None, |
1587.1.8
by Robert Collins
Local commits on unbound branches fail. |
177 |
working_tree=None, |
1607.1.5
by Robert Collins
Make commit verbose mode work!. |
178 |
local=False, |
179 |
reporter=None, |
|
180 |
config=None): |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
181 |
"""Commit working copy as a new revision.
|
182 |
||
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
183 |
branch -- the deprecated branch to commit to. New callers should pass in
|
184 |
working_tree instead
|
|
185 |
||
186 |
message -- the commit message, a mandatory parameter
|
|
187 |
||
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
188 |
timestamp -- if not None, seconds-since-epoch for a
|
189 |
postdated/predated commit.
|
|
190 |
||
1253
by Martin Pool
- test that pointless commits are trapped |
191 |
specific_files -- If true, commit only those files.
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
192 |
|
1253
by Martin Pool
- test that pointless commits are trapped |
193 |
rev_id -- If set, use this as the new revision id.
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
194 |
Useful for test or import commands that need to tightly
|
195 |
control what revisions are assigned. If you duplicate
|
|
196 |
a revision id that exists elsewhere it is your own fault.
|
|
197 |
If null (default), a time/random revision id is generated.
|
|
1253
by Martin Pool
- test that pointless commits are trapped |
198 |
|
199 |
allow_pointless -- If true (default), commit even if nothing
|
|
200 |
has changed and no merges are recorded.
|
|
1185.16.35
by Martin Pool
- stub for revision properties |
201 |
|
1185.16.65
by mbp at sourcefrog
- new commit --strict option |
202 |
strict -- If true, don't allow a commit if the working tree
|
203 |
contains unknown files.
|
|
204 |
||
1185.16.35
by Martin Pool
- stub for revision properties |
205 |
revprops -- Properties for new revision
|
1587.1.8
by Robert Collins
Local commits on unbound branches fail. |
206 |
:param local: Perform a local only commit.
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
207 |
"""
|
1285
by Martin Pool
- fix bug in committing files that are renamed but not modified |
208 |
mutter('preparing to commit') |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
209 |
|
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
210 |
if deprecated_passed(branch): |
1910.2.9
by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API |
211 |
symbol_versioning.warn("Commit.commit (branch, ...): The branch parameter is " |
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
212 |
"deprecated as of bzr 0.8. Please use working_tree= instead.", |
1534.4.26
by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create. |
213 |
DeprecationWarning, stacklevel=2) |
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
214 |
self.branch = branch |
1508.1.19
by Robert Collins
Give format3 working trees their own last-revision marker. |
215 |
self.work_tree = self.branch.bzrdir.open_workingtree() |
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
216 |
elif working_tree is None: |
217 |
raise BzrError("One of branch and working_tree must be passed into commit().") |
|
218 |
else: |
|
219 |
self.work_tree = working_tree |
|
220 |
self.branch = self.work_tree.branch |
|
221 |
if message is None: |
|
222 |
raise BzrError("The message keyword parameter is required for commit().") |
|
223 |
||
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
224 |
self.bound_branch = None |
1587.1.9
by Robert Collins
Local commits do no alter or access the master branch. |
225 |
self.local = local |
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
226 |
self.master_branch = None |
1614.1.1
by Aaron Bentley
Fixed master locking in commit |
227 |
self.master_locked = False |
1740.3.10
by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m. |
228 |
self.rev_id = None |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
229 |
self.specific_files = specific_files |
1194
by Martin Pool
- [BROKEN] more progress of commit into weaves |
230 |
self.allow_pointless = allow_pointless |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
231 |
|
1607.1.5
by Robert Collins
Make commit verbose mode work!. |
232 |
if reporter is None and self.reporter is None: |
233 |
self.reporter = NullCommitReporter() |
|
1607.1.8
by Robert Collins
Integrate latest bzr.dev. |
234 |
elif reporter is not None: |
1607.1.5
by Robert Collins
Make commit verbose mode work!. |
235 |
self.reporter = reporter |
236 |
||
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
237 |
self.work_tree.lock_write() |
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
238 |
self.pb = bzrlib.ui.ui_factory.nested_progress_bar() |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
239 |
try: |
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
240 |
# Cannot commit with conflicts present.
|
241 |
if len(self.work_tree.conflicts())>0: |
|
242 |
raise ConflictsInTree |
|
243 |
||
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
244 |
# setup the bound branch variables as needed.
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
245 |
self._check_bound_branch() |
246 |
||
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
247 |
# check for out of date working trees
|
1908.7.6
by Robert Collins
Deprecate WorkingTree.last_revision. |
248 |
try: |
249 |
first_tree_parent = self.work_tree.get_parent_ids()[0] |
|
250 |
except IndexError: |
|
251 |
# if there are no parents, treat our parent as 'None'
|
|
252 |
# this is so that we still consier the master branch
|
|
253 |
# - in a checkout scenario the tree may have no
|
|
254 |
# parents but the branch may do.
|
|
255 |
first_tree_parent = None |
|
1927.2.1
by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge. |
256 |
master_last = self.master_branch.last_revision() |
1908.7.6
by Robert Collins
Deprecate WorkingTree.last_revision. |
257 |
if (master_last is not None and |
258 |
master_last != first_tree_parent): |
|
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
259 |
raise errors.OutOfDateTree(self.work_tree) |
260 |
||
261 |
if strict: |
|
262 |
# raise an exception as soon as we find a single unknown.
|
|
263 |
for unknown in self.work_tree.unknowns(): |
|
264 |
raise StrictCommitFailed() |
|
1740.3.7
by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder. |
265 |
|
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
266 |
if self.config is None: |
1770.2.9
by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers |
267 |
self.config = self.branch.get_config() |
1740.3.7
by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder. |
268 |
|
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
269 |
if isinstance(message, str): |
270 |
message = message.decode(bzrlib.user_encoding) |
|
271 |
assert isinstance(message, unicode), type(message) |
|
272 |
self.message = message |
|
273 |
self._escape_commit_message() |
|
274 |
||
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
275 |
self.work_inv = self.work_tree.inventory |
1534.4.35
by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree() |
276 |
self.basis_tree = self.work_tree.basis_tree() |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
277 |
self.basis_inv = self.basis_tree.inventory |
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
278 |
# one to finish, one for rev and inventory, and one for each
|
279 |
# inventory entry, and the same for the new inventory.
|
|
280 |
# note that this estimate is too long when we do a partial tree
|
|
281 |
# commit which excludes some new files from being considered.
|
|
282 |
# The estimate is corrected when we populate the new inv.
|
|
1740.3.10
by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m. |
283 |
self.pb_total = len(self.work_inv) + 5 |
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
284 |
self.pb_count = 0 |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
285 |
|
1223
by Martin Pool
- store inventories in weave |
286 |
self._gather_parents() |
1344
by Martin Pool
- disallow selected-file commit of merges |
287 |
if len(self.parents) > 1 and self.specific_files: |
1704.2.11
by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges. |
288 |
raise NotImplementedError('selected-file commit of merges is not supported yet: files %r', |
289 |
self.specific_files) |
|
1927.2.1
by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge. |
290 |
|
1740.3.7
by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder. |
291 |
self.builder = self.branch.get_commit_builder(self.parents, |
292 |
self.config, timestamp, timezone, committer, revprops, rev_id) |
|
1284
by Martin Pool
- in commit, avoid reading basis inventory twice |
293 |
|
1251
by Martin Pool
- fix up commit in directory with some deleted files |
294 |
self._remove_deleted() |
1092.2.22
by Robert Collins
text_version and name_version unification looking reasonable |
295 |
self._populate_new_inv() |
1248
by Martin Pool
- new weave based cleanup [broken] |
296 |
self._report_deletes() |
1245
by Martin Pool
doc |
297 |
|
1910.2.37
by Aaron Bentley
Handle empty commits, fix test |
298 |
self._check_pointless() |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
299 |
|
1666.1.22
by Robert Collins
Rename Commit._update to _emit_progress_update. |
300 |
self._emit_progress_update() |
1910.2.3
by Aaron Bentley
All tests pass |
301 |
# TODO: Now the new inventory is known, check for conflicts and
|
302 |
# prompt the user for a commit message.
|
|
303 |
# ADHB 2006-08-08: If this is done, populate_new_inv should not add
|
|
304 |
# weave lines, because nothing should be recorded until it is known
|
|
305 |
# that commit will succeed.
|
|
1740.3.8
by Jelmer Vernooij
Move make_revision() to commit builder. |
306 |
self.builder.finish_inventory() |
1666.1.22
by Robert Collins
Rename Commit._update to _emit_progress_update. |
307 |
self._emit_progress_update() |
1740.3.9
by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit(). |
308 |
self.rev_id = self.builder.commit(self.message) |
1740.3.10
by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m. |
309 |
self._emit_progress_update() |
1587.1.7
by Robert Collins
Commit revision data locally first for bound branch commits. |
310 |
# revision data is in the local branch now.
|
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
311 |
|
1587.1.7
by Robert Collins
Commit revision data locally first for bound branch commits. |
312 |
# upload revision data to the master.
|
1759.2.1
by Jelmer Vernooij
Fix some types (found using aspell). |
313 |
# this will propagate merged revisions too if needed.
|
1587.1.7
by Robert Collins
Commit revision data locally first for bound branch commits. |
314 |
if self.bound_branch: |
315 |
self.master_branch.repository.fetch(self.branch.repository, |
|
316 |
revision_id=self.rev_id) |
|
317 |
# now the master has the revision data
|
|
318 |
# 'commit' to the master first so a timeout here causes the local
|
|
319 |
# branch to be out of date
|
|
320 |
self.master_branch.append_revision(self.rev_id) |
|
321 |
||
322 |
# and now do the commit locally.
|
|
1194
by Martin Pool
- [BROKEN] more progress of commit into weaves |
323 |
self.branch.append_revision(self.rev_id) |
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
324 |
|
1908.6.1
by Robert Collins
Change all callers of set_last_revision to use set_parent_trees. |
325 |
# if the builder gave us the revisiontree it created back, we
|
326 |
# could use it straight away here.
|
|
327 |
# TODO: implement this.
|
|
328 |
self.work_tree.set_parent_trees([(self.rev_id, |
|
329 |
self.branch.repository.revision_tree(self.rev_id))]) |
|
1587.1.6
by Robert Collins
Update bound branch implementation to 0.8. |
330 |
# now the work tree is up to date with the branch
|
331 |
||
1607.1.5
by Robert Collins
Make commit verbose mode work!. |
332 |
self.reporter.completed(self.branch.revno(), self.rev_id) |
1472
by Robert Collins
post commit hook, first pass implementation |
333 |
if self.config.post_commit() is not None: |
334 |
hooks = self.config.post_commit().split(' ') |
|
335 |
# this would be nicer with twisted.python.reflect.namedAny
|
|
336 |
for hook in hooks: |
|
337 |
result = eval(hook + '(branch, rev_id)', |
|
338 |
{'branch':self.branch, |
|
339 |
'bzrlib':bzrlib, |
|
340 |
'rev_id':self.rev_id}) |
|
1666.1.22
by Robert Collins
Rename Commit._update to _emit_progress_update. |
341 |
self._emit_progress_update() |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
342 |
finally: |
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
343 |
self._cleanup() |
1773.1.1
by Robert Collins
Teach WorkingTree.commit to return the committed revision id. |
344 |
return self.rev_id |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
345 |
|
1910.2.37
by Aaron Bentley
Handle empty commits, fix test |
346 |
def _check_pointless(self): |
347 |
if self.allow_pointless: |
|
348 |
return
|
|
349 |
# A merge with no effect on files
|
|
350 |
if len(self.parents) > 1: |
|
351 |
return
|
|
352 |
# work around the fact that a newly-initted tree does differ from its
|
|
353 |
# basis
|
|
354 |
if len(self.builder.new_inventory) != len(self.basis_inv): |
|
355 |
return
|
|
356 |
if (len(self.builder.new_inventory) != 1 and |
|
357 |
self.builder.new_inventory != self.basis_inv): |
|
358 |
return
|
|
359 |
raise PointlessCommit() |
|
360 |
||
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
361 |
def _check_bound_branch(self): |
362 |
"""Check to see if the local branch is bound.
|
|
363 |
||
364 |
If it is bound, then most of the commit will actually be
|
|
365 |
done using the remote branch as the target branch.
|
|
366 |
Only at the end will the local branch be updated.
|
|
367 |
"""
|
|
1587.1.9
by Robert Collins
Local commits do no alter or access the master branch. |
368 |
if self.local and not self.branch.get_bound_location(): |
369 |
raise errors.LocalRequiresBoundBranch() |
|
370 |
||
371 |
if not self.local: |
|
372 |
self.master_branch = self.branch.get_master_branch() |
|
373 |
||
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
374 |
if not self.master_branch: |
1587.1.8
by Robert Collins
Local commits on unbound branches fail. |
375 |
# make this branch the reference branch for out of date checks.
|
376 |
self.master_branch = self.branch |
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
377 |
return
|
378 |
||
379 |
# If the master branch is bound, we must fail
|
|
380 |
master_bound_location = self.master_branch.get_bound_location() |
|
381 |
if master_bound_location: |
|
1505.1.27
by John Arbash Meinel
Adding tests against an sftp branch. |
382 |
raise errors.CommitToDoubleBoundBranch(self.branch, |
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
383 |
self.master_branch, master_bound_location) |
384 |
||
385 |
# TODO: jam 20051230 We could automatically push local
|
|
386 |
# commits to the remote branch if they would fit.
|
|
387 |
# But for now, just require remote to be identical
|
|
388 |
# to local.
|
|
389 |
||
390 |
# Make sure the local branch is identical to the master
|
|
391 |
master_rh = self.master_branch.revision_history() |
|
392 |
local_rh = self.branch.revision_history() |
|
393 |
if local_rh != master_rh: |
|
394 |
raise errors.BoundBranchOutOfDate(self.branch, |
|
395 |
self.master_branch) |
|
396 |
||
397 |
# Now things are ready to change the master branch
|
|
398 |
# so grab the lock
|
|
399 |
self.bound_branch = self.branch |
|
400 |
self.master_branch.lock_write() |
|
1614.1.1
by Aaron Bentley
Fixed master locking in commit |
401 |
self.master_locked = True |
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
402 |
|
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
403 |
def _cleanup(self): |
404 |
"""Cleanup any open locks, progress bars etc."""
|
|
405 |
cleanups = [self._cleanup_bound_branch, |
|
406 |
self.work_tree.unlock, |
|
407 |
self.pb.finished] |
|
408 |
found_exception = None |
|
409 |
for cleanup in cleanups: |
|
410 |
try: |
|
411 |
cleanup() |
|
412 |
# we want every cleanup to run no matter what.
|
|
413 |
# so we have a catchall here, but we will raise the
|
|
414 |
# last encountered exception up the stack: and
|
|
415 |
# typically this will be useful enough.
|
|
416 |
except Exception, e: |
|
417 |
found_exception = e |
|
418 |
if found_exception is not None: |
|
1759.2.2
by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron. |
419 |
# don't do a plan raise, because the last exception may have been
|
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
420 |
# trashed, e is our sure-to-work exception even though it loses the
|
421 |
# full traceback. XXX: RBC 20060421 perhaps we could check the
|
|
422 |
# exc_info and if its the same one do a plain raise otherwise
|
|
423 |
# 'raise e' as we do now.
|
|
424 |
raise e |
|
425 |
||
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
426 |
def _cleanup_bound_branch(self): |
427 |
"""Executed at the end of a try/finally to cleanup a bound branch.
|
|
428 |
||
429 |
If the branch wasn't bound, this is a no-op.
|
|
430 |
If it was, it resents self.branch to the local branch, instead
|
|
431 |
of being the master.
|
|
432 |
"""
|
|
433 |
if not self.bound_branch: |
|
434 |
return
|
|
1614.1.1
by Aaron Bentley
Fixed master locking in commit |
435 |
if self.master_locked: |
436 |
self.master_branch.unlock() |
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
437 |
|
1390
by Robert Collins
pair programming worx... merge integration and weave |
438 |
def _escape_commit_message(self): |
439 |
"""Replace xml-incompatible control characters."""
|
|
1666.1.6
by Robert Collins
Make knit the default format. |
440 |
# FIXME: RBC 20060419 this should be done by the revision
|
441 |
# serialiser not by commit. Then we can also add an unescaper
|
|
442 |
# in the deserializer and start roundtripping revision messages
|
|
443 |
# precisely. See repository_implementations/test_repository.py
|
|
444 |
||
1185.11.5
by John Arbash Meinel
Merged up-to-date against mainline, still broken. |
445 |
# Python strings can include characters that can't be
|
446 |
# represented in well-formed XML; escape characters that
|
|
447 |
# aren't listed in the XML specification
|
|
448 |
# (http://www.w3.org/TR/REC-xml/#NT-Char).
|
|
1390
by Robert Collins
pair programming worx... merge integration and weave |
449 |
self.message, escape_count = re.subn( |
1393.4.2
by Harald Meland
Cleanup + better test of commit-msg control character escape code. |
450 |
u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+', |
1185.11.5
by John Arbash Meinel
Merged up-to-date against mainline, still broken. |
451 |
lambda match: match.group(0).encode('unicode_escape'), |
1390
by Robert Collins
pair programming worx... merge integration and weave |
452 |
self.message) |
1185.11.5
by John Arbash Meinel
Merged up-to-date against mainline, still broken. |
453 |
if escape_count: |
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
454 |
self.reporter.escaped(escape_count, self.message) |
1223
by Martin Pool
- store inventories in weave |
455 |
|
456 |
def _gather_parents(self): |
|
1092.2.25
by Robert Collins
support ghosts in commits |
457 |
"""Record the parents of a merge for merge detection."""
|
1740.3.6
by Jelmer Vernooij
Move inventory writing to the commit builder. |
458 |
# TODO: Make sure that this list doesn't contain duplicate
|
459 |
# entries and the order is preserved when doing this.
|
|
1773.2.1
by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids. |
460 |
self.parents = self.work_tree.get_parent_ids() |
1408
by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient |
461 |
self.parent_invs = [] |
1092.2.25
by Robert Collins
support ghosts in commits |
462 |
for revision in self.parents: |
1185.67.2
by Aaron Bentley
Renamed Branch.storage to Branch.repository |
463 |
if self.branch.repository.has_revision(revision): |
1927.2.1
by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge. |
464 |
mutter('commit parent revision {%s}', revision) |
1185.67.2
by Aaron Bentley
Renamed Branch.storage to Branch.repository |
465 |
inventory = self.branch.repository.get_inventory(revision) |
1185.65.1
by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch |
466 |
self.parent_invs.append(inventory) |
1927.2.1
by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge. |
467 |
else: |
468 |
mutter('commit parent ghost revision {%s}', revision) |
|
1284
by Martin Pool
- in commit, avoid reading basis inventory twice |
469 |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
470 |
def _remove_deleted(self): |
1248
by Martin Pool
- new weave based cleanup [broken] |
471 |
"""Remove deleted files from the working inventories.
|
472 |
||
473 |
This is done prior to taking the working inventory as the
|
|
474 |
basis for the new committed inventory.
|
|
475 |
||
476 |
This returns true if any files
|
|
477 |
*that existed in the basis inventory* were deleted.
|
|
478 |
Files that were added and deleted
|
|
479 |
in the working copy don't matter.
|
|
480 |
"""
|
|
1254
by Martin Pool
- fix handling of selective commit with deleted files |
481 |
specific = self.specific_files |
482 |
deleted_ids = [] |
|
1988.2.5
by Robert Collins
When an entire subtree has been deleted, commit will now report that |
483 |
deleted_paths = set() |
1254
by Martin Pool
- fix handling of selective commit with deleted files |
484 |
for path, ie in self.work_inv.iter_entries(): |
1988.2.5
by Robert Collins
When an entire subtree has been deleted, commit will now report that |
485 |
if is_inside_any(deleted_paths, path): |
486 |
# The tree will delete the required ids recursively.
|
|
487 |
continue
|
|
1254
by Martin Pool
- fix handling of selective commit with deleted files |
488 |
if specific and not is_inside_any(specific, path): |
489 |
continue
|
|
490 |
if not self.work_tree.has_filename(path): |
|
1988.2.5
by Robert Collins
When an entire subtree has been deleted, commit will now report that |
491 |
deleted_paths.add(path) |
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
492 |
self.reporter.missing(path) |
1988.2.5
by Robert Collins
When an entire subtree has been deleted, commit will now report that |
493 |
deleted_ids.append(ie.file_id) |
494 |
self.work_tree.unversion(deleted_ids) |
|
1248
by Martin Pool
- new weave based cleanup [broken] |
495 |
|
1092.2.22
by Robert Collins
text_version and name_version unification looking reasonable |
496 |
def _populate_new_inv(self): |
497 |
"""Build revision inventory.
|
|
498 |
||
499 |
This creates a new empty inventory. Depending on
|
|
500 |
which files are selected for commit, and what is present in the
|
|
501 |
current tree, the new inventory is populated. inventory entries
|
|
502 |
which are candidates for modification have their revision set to
|
|
503 |
None; inventory entries that are carried over untouched have their
|
|
504 |
revision set to their prior value.
|
|
1301
by Martin Pool
- more docs in commit code |
505 |
"""
|
1551.7.24
by Aaron Bentley
Ensure commit respects file spec when committing removals |
506 |
# ESEPARATIONOFCONCERNS: this function is diffing and using the diff
|
507 |
# results to create a new inventory at the same time, which results
|
|
1852.10.3
by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib. |
508 |
# in bugs like #46635. Any reason not to use/enhance Tree.changes_from?
|
1551.7.24
by Aaron Bentley
Ensure commit respects file spec when committing removals |
509 |
# ADHB 11-07-2006
|
1092.2.22
by Robert Collins
text_version and name_version unification looking reasonable |
510 |
mutter("Selecting files for commit with filter %s", self.specific_files) |
1910.2.4
by Aaron Bentley
Support old CommitBuilders |
511 |
entries = self.work_inv.iter_entries() |
512 |
if not self.builder.record_root_entry: |
|
1910.2.9
by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API |
513 |
symbol_versioning.warn('CommitBuilders should support recording' |
514 |
' the root entry as of bzr 0.10.', DeprecationWarning, |
|
515 |
stacklevel=1) |
|
1910.2.4
by Aaron Bentley
Support old CommitBuilders |
516 |
self.builder.new_inventory.add(self.basis_inv.root.copy()) |
517 |
entries.next() |
|
518 |
self._emit_progress_update() |
|
519 |
for path, new_ie in entries: |
|
1666.1.22
by Robert Collins
Rename Commit._update to _emit_progress_update. |
520 |
self._emit_progress_update() |
1249
by Martin Pool
- improvements to weave commit [broken] |
521 |
file_id = new_ie.file_id |
1711.2.101
by John Arbash Meinel
Clean up some unnecessary mutter() calls |
522 |
# mutter('check %s {%s}', path, file_id)
|
1740.3.5
by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any() |
523 |
if (not self.specific_files or |
524 |
is_inside_or_parent_of_any(self.specific_files, path)): |
|
1711.2.101
by John Arbash Meinel
Clean up some unnecessary mutter() calls |
525 |
# mutter('%s selected for commit', path)
|
1740.3.6
by Jelmer Vernooij
Move inventory writing to the commit builder. |
526 |
ie = new_ie.copy() |
527 |
ie.revision = None |
|
1740.3.5
by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any() |
528 |
else: |
1711.2.101
by John Arbash Meinel
Clean up some unnecessary mutter() calls |
529 |
# mutter('%s not selected for commit', path)
|
1740.3.6
by Jelmer Vernooij
Move inventory writing to the commit builder. |
530 |
if self.basis_inv.has_id(file_id): |
531 |
ie = self.basis_inv[file_id].copy() |
|
532 |
else: |
|
533 |
# this entry is new and not being committed
|
|
534 |
continue
|
|
1907.1.1
by Aaron Bentley
Unshelved all changes except those related to removing RootEntry |
535 |
|
536 |
self.builder.record_entry_contents(ie, self.parent_invs, |
|
537 |
path, self.work_tree) |
|
1759.2.1
by Jelmer Vernooij
Fix some types (found using aspell). |
538 |
# describe the nature of the change that has occurred relative to
|
1740.3.6
by Jelmer Vernooij
Move inventory writing to the commit builder. |
539 |
# the basis inventory.
|
540 |
if (self.basis_inv.has_id(ie.file_id)): |
|
541 |
basis_ie = self.basis_inv[ie.file_id] |
|
542 |
else: |
|
543 |
basis_ie = None |
|
544 |
change = ie.describe_change(basis_ie, ie) |
|
545 |
if change in (InventoryEntry.RENAMED, |
|
546 |
InventoryEntry.MODIFIED_AND_RENAMED): |
|
547 |
old_path = self.basis_inv.id2path(ie.file_id) |
|
548 |
self.reporter.renamed(change, old_path, path) |
|
549 |
else: |
|
550 |
self.reporter.snapshot_change(change, path) |
|
1416
by Robert Collins
when committing a specific file, include all its parents |
551 |
|
1551.7.24
by Aaron Bentley
Ensure commit respects file spec when committing removals |
552 |
if not self.specific_files: |
553 |
return
|
|
554 |
||
555 |
# ignore removals that don't match filespec
|
|
556 |
for path, new_ie in self.basis_inv.iter_entries(): |
|
557 |
if new_ie.file_id in self.work_inv: |
|
558 |
continue
|
|
559 |
if is_inside_any(self.specific_files, path): |
|
560 |
continue
|
|
561 |
ie = new_ie.copy() |
|
562 |
ie.revision = None |
|
563 |
self.builder.record_entry_contents(ie, self.parent_invs, path, |
|
564 |
self.basis_tree) |
|
565 |
||
1666.1.22
by Robert Collins
Rename Commit._update to _emit_progress_update. |
566 |
def _emit_progress_update(self): |
1666.1.18
by Robert Collins
Add a progress bar during commit operations. |
567 |
"""Emit an update to the progress bar."""
|
568 |
self.pb.update("Committing", self.pb_count, self.pb_total) |
|
569 |
self.pb_count += 1 |
|
570 |
||
1248
by Martin Pool
- new weave based cleanup [broken] |
571 |
def _report_deletes(self): |
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
572 |
for path, ie in self.basis_inv.iter_entries(): |
1740.3.4
by Jelmer Vernooij
Move inventory to commit builder. |
573 |
if ie.file_id not in self.builder.new_inventory: |
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
574 |
self.reporter.deleted(path) |
1248
by Martin Pool
- new weave based cleanup [broken] |
575 |
|
1740.3.7
by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder. |
576 |