~bzr-pqm/bzr/bzr.dev

1704.2.14 by Martin Pool
[merge] work from 0.8 fixes
1
# Copyright (C) 2005, 2006 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
1755.3.1 by Robert Collins
Tune the time to build our kernel_like tree : make LocalTransport.put faster, AtomicFile faster, LocalTransport.append faster.
19
# nothing?  
1248 by Martin Pool
- new weave based cleanup [broken]
20
21
# TODO: Separate 'prepare' phase where we find a list of potentially
22
# committed files.  We then can then pause the commit to prompt for a
23
# commit message, knowing the summary will be the same as what's
24
# actually used for the commit.  (But perhaps simpler to simply get
25
# the tree status, then use that for a selective commit?)
26
27
# The newly committed revision is going to have a shape corresponding
28
# to that of the working inventory.  Files that are not in the
29
# working tree and that were in the predecessor are reported as
30
# removed --- this can include files that were either removed from the
31
# inventory or deleted in the working tree.  If they were only
32
# deleted from disk, they are removed from the working inventory.
33
34
# We then consider the remaining entries, which will be in the new
35
# version.  Directory entries are simply copied across.  File entries
36
# must be checked to see if a new version of the file should be
37
# recorded.  For each parent revision inventory, we check to see what
38
# version of the file was present.  If the file was present in at
39
# least one tree, and if it was the same version in all the trees,
40
# then we can just refer to that version.  Otherwise, a new version
41
# representing the merger of the file versions must be added.
42
43
# TODO: Update hashcache before and after - or does the WorkingTree
44
# look after that?
1245 by Martin Pool
doc
45
1339 by Martin Pool
- doc
46
# TODO: Rather than mashing together the ancestry and storing it back,
47
# perhaps the weave should have single method which does it all in one
48
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
49
1341 by Martin Pool
- doc
50
# TODO: Perhaps give a warning if one of the revisions marked as
51
# merged is already in the ancestry, and then don't record it as a
52
# distinct parent.
53
1343 by Martin Pool
- fix up test for merge of trees
54
# TODO: If the file is newly merged but unchanged from the version it
55
# merges from, then it should still be reported as newly added
56
# relative to the basis revision.
57
1185.16.66 by mbp at sourcefrog
- todo
58
# TODO: Do checks that the tree can be committed *before* running the 
59
# editor; this should include checks for a pointless commit and for 
60
# unknown or missing files.
61
62
# TODO: If commit fails, leave the message in a file somewhere.
63
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
64
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
65
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
66
1189 by Martin Pool
- BROKEN: partial support for commit into weave
67
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
68
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
69
import sys
1188 by Martin Pool
- clean up imports in commit code
70
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
71
72
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
73
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
74
import bzrlib.config
1508.1.22 by Robert Collins
implement out of date working tree checks in commit.
75
import bzrlib.errors as errors
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
76
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
77
                           ConflictsInTree,
78
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
79
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
80
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
81
                            is_inside_or_parent_of_any,
82
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
83
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
84
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
85
from bzrlib.xml5 import serializer_v5
1907.1.1 by Aaron Bentley
Unshelved all changes except those related to removing RootEntry
86
from bzrlib.inventory import Inventory, ROOT_ID, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
87
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
88
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
89
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
90
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
91
from bzrlib.workingtree import WorkingTree
1189 by Martin Pool
- BROKEN: partial support for commit into weave
92
93
94
class NullCommitReporter(object):
95
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
96
97
    def snapshot_change(self, change, path):
98
        pass
99
100
    def completed(self, revno, rev_id):
101
        pass
102
103
    def deleted(self, file_id):
104
        pass
105
106
    def escaped(self, escape_count, message):
107
        pass
108
109
    def missing(self, path):
110
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
111
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
112
    def renamed(self, change, old_path, new_path):
113
        pass
114
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
115
1189 by Martin Pool
- BROKEN: partial support for commit into weave
116
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
117
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
118
    # this may be more useful if 'note' was replaced by an overridable
119
    # method on self, which would allow more trivial subclassing.
120
    # alternative, a callable could be passed in, allowing really trivial
121
    # reuse for some uis. RBC 20060511
122
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
123
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
124
        if change == 'unchanged':
125
            return
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
126
        note("%s %s", change, path)
127
128
    def completed(self, revno, rev_id):
1607.1.5 by Robert Collins
Make commit verbose mode work!.
129
        note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
130
    
131
    def deleted(self, file_id):
132
        note('deleted %s', file_id)
133
134
    def escaped(self, escape_count, message):
135
        note("replaced %d control characters in message", escape_count)
136
137
    def missing(self, path):
138
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
139
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
140
    def renamed(self, change, old_path, new_path):
141
        note('%s %s => %s', change, old_path, new_path)
142
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
143
1189 by Martin Pool
- BROKEN: partial support for commit into weave
144
class Commit(object):
145
    """Task of committing a new revision.
146
147
    This is a MethodObject: it accumulates state as the commit is
148
    prepared, and then it is discarded.  It doesn't represent
149
    historical revisions, just the act of recording a new one.
150
151
            missing_ids
152
            Modified to hold a list of files that have been deleted from
153
            the working directory; these should be removed from the
154
            working inventory.
485 by Martin Pool
- move commit code into its own module
155
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
156
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
157
                 reporter=None,
158
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
159
        if reporter is not None:
160
            self.reporter = reporter
161
        else:
162
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
163
        if config is not None:
164
            self.config = config
165
        else:
166
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
167
        
168
    def commit(self,
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
169
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
               timestamp=None,
171
               timezone=None,
172
               committer=None,
173
               specific_files=None,
174
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
175
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
176
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
177
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
178
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
179
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
180
               local=False,
181
               reporter=None,
182
               config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
183
        """Commit working copy as a new revision.
184
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
185
        branch -- the deprecated branch to commit to. New callers should pass in 
186
                  working_tree instead
187
188
        message -- the commit message, a mandatory parameter
189
1189 by Martin Pool
- BROKEN: partial support for commit into weave
190
        timestamp -- if not None, seconds-since-epoch for a
191
             postdated/predated commit.
192
1253 by Martin Pool
- test that pointless commits are trapped
193
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
194
1253 by Martin Pool
- test that pointless commits are trapped
195
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
196
            Useful for test or import commands that need to tightly
197
            control what revisions are assigned.  If you duplicate
198
            a revision id that exists elsewhere it is your own fault.
199
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
200
201
        allow_pointless -- If true (default), commit even if nothing
202
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
203
1185.16.65 by mbp at sourcefrog
- new commit --strict option
204
        strict -- If true, don't allow a commit if the working tree
205
            contains unknown files.
206
1185.16.35 by Martin Pool
- stub for revision properties
207
        revprops -- Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
208
        :param local: Perform a local only commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
209
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
210
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
211
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
212
        if deprecated_passed(branch):
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
213
            symbol_versioning.warn("Commit.commit (branch, ...): The branch parameter is "
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
214
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
215
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
216
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
217
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
218
        elif working_tree is None:
219
            raise BzrError("One of branch and working_tree must be passed into commit().")
220
        else:
221
            self.work_tree = working_tree
222
            self.branch = self.work_tree.branch
223
        if message is None:
224
            raise BzrError("The message keyword parameter is required for commit().")
225
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
226
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
227
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
228
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
229
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
230
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
231
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
232
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
233
1607.1.5 by Robert Collins
Make commit verbose mode work!.
234
        if reporter is None and self.reporter is None:
235
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
236
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
237
            self.reporter = reporter
238
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
239
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
240
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
241
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
242
            # Cannot commit with conflicts present.
243
            if len(self.work_tree.conflicts())>0:
244
                raise ConflictsInTree
245
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
246
            # setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
247
            self._check_bound_branch()
248
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
249
            # check for out of date working trees
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
250
            try:
251
                first_tree_parent = self.work_tree.get_parent_ids()[0]
252
            except IndexError:
253
                # if there are no parents, treat our parent as 'None'
254
                # this is so that we still consier the master branch
255
                # - in a checkout scenario the tree may have no
256
                # parents but the branch may do.
257
                first_tree_parent = None
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
258
            master_last = self.master_branch.last_revision()
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
259
            if (master_last is not None and
260
                master_last != first_tree_parent):
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
261
                raise errors.OutOfDateTree(self.work_tree)
262
    
263
            if strict:
264
                # raise an exception as soon as we find a single unknown.
265
                for unknown in self.work_tree.unknowns():
266
                    raise StrictCommitFailed()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
267
                   
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
268
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
269
                self.config = self.branch.get_config()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
270
      
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
271
            if isinstance(message, str):
272
                message = message.decode(bzrlib.user_encoding)
273
            assert isinstance(message, unicode), type(message)
274
            self.message = message
275
            self._escape_commit_message()
276
1189 by Martin Pool
- BROKEN: partial support for commit into weave
277
            self.work_inv = self.work_tree.inventory
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
278
            self.basis_tree = self.work_tree.basis_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
279
            self.basis_inv = self.basis_tree.inventory
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
280
            # one to finish, one for rev and inventory, and one for each
281
            # inventory entry, and the same for the new inventory.
282
            # note that this estimate is too long when we do a partial tree
283
            # commit which excludes some new files from being considered.
284
            # The estimate is corrected when we populate the new inv.
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
285
            self.pb_total = len(self.work_inv) + 5
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
286
            self.pb_count = 0
1189 by Martin Pool
- BROKEN: partial support for commit into weave
287
1223 by Martin Pool
- store inventories in weave
288
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
289
            if len(self.parents) > 1 and self.specific_files:
1704.2.11 by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges.
290
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
291
                        self.specific_files)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
292
            
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
293
            self.builder = self.branch.get_commit_builder(self.parents, 
294
                self.config, timestamp, timezone, committer, revprops, rev_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
295
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
296
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
297
            self._populate_new_inv()
1248 by Martin Pool
- new weave based cleanup [broken]
298
            self._report_deletes()
1245 by Martin Pool
doc
299
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
300
            self._check_pointless()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
301
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
302
            self._emit_progress_update()
1910.2.3 by Aaron Bentley
All tests pass
303
            # TODO: Now the new inventory is known, check for conflicts and
304
            # prompt the user for a commit message.
305
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
306
            # weave lines, because nothing should be recorded until it is known
307
            # that commit will succeed.
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
308
            self.builder.finish_inventory()
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
309
            self._emit_progress_update()
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
310
            self.rev_id = self.builder.commit(self.message)
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
311
            self._emit_progress_update()
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
312
            # revision data is in the local branch now.
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
313
            
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
314
            # upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
315
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
316
            if self.bound_branch:
317
                self.master_branch.repository.fetch(self.branch.repository,
318
                                                    revision_id=self.rev_id)
319
                # now the master has the revision data
320
                # 'commit' to the master first so a timeout here causes the local
321
                # branch to be out of date
322
                self.master_branch.append_revision(self.rev_id)
323
324
            # and now do the commit locally.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
325
            self.branch.append_revision(self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
326
1908.6.1 by Robert Collins
Change all callers of set_last_revision to use set_parent_trees.
327
            # if the builder gave us the revisiontree it created back, we
328
            # could use it straight away here.
329
            # TODO: implement this.
330
            self.work_tree.set_parent_trees([(self.rev_id,
331
                self.branch.repository.revision_tree(self.rev_id))])
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
332
            # now the work tree is up to date with the branch
333
            
1607.1.5 by Robert Collins
Make commit verbose mode work!.
334
            self.reporter.completed(self.branch.revno(), self.rev_id)
1472 by Robert Collins
post commit hook, first pass implementation
335
            if self.config.post_commit() is not None:
336
                hooks = self.config.post_commit().split(' ')
337
                # this would be nicer with twisted.python.reflect.namedAny
338
                for hook in hooks:
339
                    result = eval(hook + '(branch, rev_id)',
340
                                  {'branch':self.branch,
341
                                   'bzrlib':bzrlib,
342
                                   'rev_id':self.rev_id})
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
343
            self._emit_progress_update()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
344
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
345
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
346
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
347
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
348
    def _check_pointless(self):
349
        if self.allow_pointless:
350
            return
351
        # A merge with no effect on files
352
        if len(self.parents) > 1:
353
            return
354
        # work around the fact that a newly-initted tree does differ from its
355
        # basis
356
        if len(self.builder.new_inventory) != len(self.basis_inv):
357
            return
358
        if (len(self.builder.new_inventory) != 1 and
359
            self.builder.new_inventory != self.basis_inv):
360
            return
361
        raise PointlessCommit()
362
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
363
    def _check_bound_branch(self):
364
        """Check to see if the local branch is bound.
365
366
        If it is bound, then most of the commit will actually be
367
        done using the remote branch as the target branch.
368
        Only at the end will the local branch be updated.
369
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
370
        if self.local and not self.branch.get_bound_location():
371
            raise errors.LocalRequiresBoundBranch()
372
373
        if not self.local:
374
            self.master_branch = self.branch.get_master_branch()
375
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
376
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
377
            # make this branch the reference branch for out of date checks.
378
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
379
            return
380
381
        # If the master branch is bound, we must fail
382
        master_bound_location = self.master_branch.get_bound_location()
383
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
384
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
385
                    self.master_branch, master_bound_location)
386
387
        # TODO: jam 20051230 We could automatically push local
388
        #       commits to the remote branch if they would fit.
389
        #       But for now, just require remote to be identical
390
        #       to local.
391
        
392
        # Make sure the local branch is identical to the master
393
        master_rh = self.master_branch.revision_history()
394
        local_rh = self.branch.revision_history()
395
        if local_rh != master_rh:
396
            raise errors.BoundBranchOutOfDate(self.branch,
397
                    self.master_branch)
398
399
        # Now things are ready to change the master branch
400
        # so grab the lock
401
        self.bound_branch = self.branch
402
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
403
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
404
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
405
    def _cleanup(self):
406
        """Cleanup any open locks, progress bars etc."""
407
        cleanups = [self._cleanup_bound_branch,
408
                    self.work_tree.unlock,
409
                    self.pb.finished]
410
        found_exception = None
411
        for cleanup in cleanups:
412
            try:
413
                cleanup()
414
            # we want every cleanup to run no matter what.
415
            # so we have a catchall here, but we will raise the
416
            # last encountered exception up the stack: and
417
            # typically this will be useful enough.
418
            except Exception, e:
419
                found_exception = e
420
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
421
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
422
            # trashed, e is our sure-to-work exception even though it loses the
423
            # full traceback. XXX: RBC 20060421 perhaps we could check the
424
            # exc_info and if its the same one do a plain raise otherwise 
425
            # 'raise e' as we do now.
426
            raise e
427
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
428
    def _cleanup_bound_branch(self):
429
        """Executed at the end of a try/finally to cleanup a bound branch.
430
431
        If the branch wasn't bound, this is a no-op.
432
        If it was, it resents self.branch to the local branch, instead
433
        of being the master.
434
        """
435
        if not self.bound_branch:
436
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
437
        if self.master_locked:
438
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
439
1390 by Robert Collins
pair programming worx... merge integration and weave
440
    def _escape_commit_message(self):
441
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
442
        # FIXME: RBC 20060419 this should be done by the revision
443
        # serialiser not by commit. Then we can also add an unescaper
444
        # in the deserializer and start roundtripping revision messages
445
        # precisely. See repository_implementations/test_repository.py
446
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
447
        # Python strings can include characters that can't be
448
        # represented in well-formed XML; escape characters that
449
        # aren't listed in the XML specification
450
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
451
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
452
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
453
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
454
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
455
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
456
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
457
458
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
459
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
460
        # TODO: Make sure that this list doesn't contain duplicate 
461
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
462
        self.parents = self.work_tree.get_parent_ids()
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
463
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
464
        for revision in self.parents:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
465
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
466
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
467
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
468
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
469
            else:
470
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
471
1189 by Martin Pool
- BROKEN: partial support for commit into weave
472
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
473
        """Remove deleted files from the working inventories.
474
475
        This is done prior to taking the working inventory as the
476
        basis for the new committed inventory.
477
478
        This returns true if any files
479
        *that existed in the basis inventory* were deleted.
480
        Files that were added and deleted
481
        in the working copy don't matter.
482
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
483
        specific = self.specific_files
484
        deleted_ids = []
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
485
        deleted_paths = set()
1254 by Martin Pool
- fix handling of selective commit with deleted files
486
        for path, ie in self.work_inv.iter_entries():
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
487
            if is_inside_any(deleted_paths, path):
488
                # The tree will delete the required ids recursively.
489
                continue
1254 by Martin Pool
- fix handling of selective commit with deleted files
490
            if specific and not is_inside_any(specific, path):
491
                continue
492
            if not self.work_tree.has_filename(path):
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
493
                deleted_paths.add(path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
494
                self.reporter.missing(path)
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
495
                deleted_ids.append(ie.file_id)
496
        self.work_tree.unversion(deleted_ids)
1248 by Martin Pool
- new weave based cleanup [broken]
497
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
498
    def _populate_new_inv(self):
499
        """Build revision inventory.
500
501
        This creates a new empty inventory. Depending on
502
        which files are selected for commit, and what is present in the
503
        current tree, the new inventory is populated. inventory entries 
504
        which are candidates for modification have their revision set to
505
        None; inventory entries that are carried over untouched have their
506
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
507
        """
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
508
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
509
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
510
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
511
        # ADHB 11-07-2006
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
512
        mutter("Selecting files for commit with filter %s", self.specific_files)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
513
        entries = self.work_inv.iter_entries()
514
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
515
            symbol_versioning.warn('CommitBuilders should support recording'
516
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
517
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
518
            self.builder.new_inventory.add(self.basis_inv.root.copy())
519
            entries.next()
520
            self._emit_progress_update()
521
        for path, new_ie in entries:
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
522
            self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
523
            file_id = new_ie.file_id
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
524
            # mutter('check %s {%s}', path, file_id)
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
525
            if (not self.specific_files or 
526
                is_inside_or_parent_of_any(self.specific_files, path)):
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
527
                    # mutter('%s selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
528
                    ie = new_ie.copy()
529
                    ie.revision = None
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
530
            else:
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
531
                # mutter('%s not selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
532
                if self.basis_inv.has_id(file_id):
533
                    ie = self.basis_inv[file_id].copy()
534
                else:
535
                    # this entry is new and not being committed
536
                    continue
1907.1.1 by Aaron Bentley
Unshelved all changes except those related to removing RootEntry
537
538
            self.builder.record_entry_contents(ie, self.parent_invs, 
539
                path, self.work_tree)
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
540
            # describe the nature of the change that has occurred relative to
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
541
            # the basis inventory.
542
            if (self.basis_inv.has_id(ie.file_id)):
543
                basis_ie = self.basis_inv[ie.file_id]
544
            else:
545
                basis_ie = None
546
            change = ie.describe_change(basis_ie, ie)
547
            if change in (InventoryEntry.RENAMED, 
548
                InventoryEntry.MODIFIED_AND_RENAMED):
549
                old_path = self.basis_inv.id2path(ie.file_id)
550
                self.reporter.renamed(change, old_path, path)
551
            else:
552
                self.reporter.snapshot_change(change, path)
1416 by Robert Collins
when committing a specific file, include all its parents
553
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
554
        if not self.specific_files:
555
            return
556
557
        # ignore removals that don't match filespec
558
        for path, new_ie in self.basis_inv.iter_entries():
559
            if new_ie.file_id in self.work_inv:
560
                continue
561
            if is_inside_any(self.specific_files, path):
562
                continue
563
            ie = new_ie.copy()
564
            ie.revision = None
565
            self.builder.record_entry_contents(ie, self.parent_invs, path,
566
                                               self.basis_tree)
567
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
568
    def _emit_progress_update(self):
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
569
        """Emit an update to the progress bar."""
570
        self.pb.update("Committing", self.pb_count, self.pb_total)
571
        self.pb_count += 1
572
1248 by Martin Pool
- new weave based cleanup [broken]
573
    def _report_deletes(self):
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
574
        for path, ie in self.basis_inv.iter_entries():
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
575
            if ie.file_id not in self.builder.new_inventory:
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
576
                self.reporter.deleted(path)
1248 by Martin Pool
- new weave based cleanup [broken]
577
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
578