~bzr-pqm/bzr/bzr.dev

1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
2
#
1 by mbp at sourcefrog
import from baz patch-364
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
7
#
1 by mbp at sourcefrog
import from baz patch-364
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
12
#
1 by mbp at sourcefrog
import from baz patch-364
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
17
import errno
18
import os
1899.1.5 by John Arbash Meinel
Always buffer the output of diff, so we can check if retcode==2 is because of Binary files
19
import re
1692.8.7 by James Henstridge
changes suggested by John Meinel
20
import subprocess
1692.8.4 by James Henstridge
move external_diff imports to top of file
21
import sys
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
22
import tempfile
1740.2.5 by Aaron Bentley
Merge from bzr.dev
23
import time
24
1955.2.10 by John Arbash Meinel
Unset a few other LANG type variables when spawning diff
25
from bzrlib import (
26
    errors,
27
    osutils,
28
    )
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
29
# compatability - plugins import compare_trees from diff!!!
30
# deprecated as of 0.10
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
31
from bzrlib.delta import compare_trees
32
from bzrlib.errors import BzrError
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
33
from bzrlib.patiencediff import unified_diff
34
import bzrlib.patiencediff
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
35
from bzrlib.symbol_versioning import (deprecated_function,
36
        zero_eight)
1558.15.2 by Aaron Bentley
Implemented binary file handling for diff
37
from bzrlib.textfile import check_text_lines
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
38
from bzrlib.trace import mutter, warning
1 by mbp at sourcefrog
import from baz patch-364
39
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
40
767 by Martin Pool
- files are only reported as modified if their name or parent has changed,
41
# TODO: Rather than building a changeset object, we should probably
42
# invoke callbacks on an object.  That object can either accumulate a
43
# list, write them out directly, etc etc.
44
1558.15.11 by Aaron Bentley
Apply merge review suggestions
45
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
1711.2.30 by John Arbash Meinel
Fix bug in internal_diff handling of unicode paths
46
                  allow_binary=False, sequence_matcher=None,
47
                  path_encoding='utf8'):
475 by Martin Pool
- rewrite diff using compare_trees()
48
    # FIXME: difflib is wrong if there is no trailing newline.
49
    # The syntax used by patch seems to be "\ No newline at
50
    # end of file" following the last diff line from that
51
    # file.  This is not trivial to insert into the
52
    # unified_diff output and it might be better to just fix
53
    # or replace that function.
54
55
    # In the meantime we at least make sure the patch isn't
56
    # mangled.
57
58
59
    # Special workaround for Python2.3, where difflib fails if
60
    # both sequences are empty.
61
    if not oldlines and not newlines:
62
        return
1558.15.2 by Aaron Bentley
Implemented binary file handling for diff
63
    
1558.15.11 by Aaron Bentley
Apply merge review suggestions
64
    if allow_binary is False:
65
        check_text_lines(oldlines)
66
        check_text_lines(newlines)
475 by Martin Pool
- rewrite diff using compare_trees()
67
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
68
    if sequence_matcher is None:
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
69
        sequence_matcher = bzrlib.patiencediff.PatienceSequenceMatcher
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
70
    ud = unified_diff(oldlines, newlines,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
71
                      fromfile=old_filename.encode(path_encoding),
72
                      tofile=new_filename.encode(path_encoding),
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
73
                      sequencematcher=sequence_matcher)
475 by Martin Pool
- rewrite diff using compare_trees()
74
1092.1.50 by Robert Collins
make diff lsdiff/filterdiff friendly
75
    ud = list(ud)
475 by Martin Pool
- rewrite diff using compare_trees()
76
    # work-around for difflib being too smart for its own good
77
    # if /dev/null is "1,0", patch won't recognize it as /dev/null
78
    if not oldlines:
79
        ud[2] = ud[2].replace('-1,0', '-0,0')
80
    elif not newlines:
81
        ud[2] = ud[2].replace('+1,0', '+0,0')
1092.1.50 by Robert Collins
make diff lsdiff/filterdiff friendly
82
    # work around for difflib emitting random spaces after the label
83
    ud[0] = ud[0][:-2] + '\n'
84
    ud[1] = ud[1][:-2] + '\n'
475 by Martin Pool
- rewrite diff using compare_trees()
85
804 by Martin Pool
Patch from John:
86
    for line in ud:
87
        to_file.write(line)
974.1.5 by Aaron Bentley
Fixed handling of missing newlines in udiffs
88
        if not line.endswith('\n'):
89
            to_file.write("\n\\ No newline at end of file\n")
475 by Martin Pool
- rewrite diff using compare_trees()
90
    print >>to_file
91
92
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
93
def _set_lang_C():
94
    """Set the env var LANG=C"""
1955.2.10 by John Arbash Meinel
Unset a few other LANG type variables when spawning diff
95
    osutils.set_or_unset_env('LANG', 'C')
96
    osutils.set_or_unset_env('LC_ALL', None)
97
    osutils.set_or_unset_env('LC_CTYPE', None)
98
    osutils.set_or_unset_env('LANGUAGE', None)
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
99
100
101
def _spawn_external_diff(diffcmd, capture_errors=True):
102
    """Spawn the externall diff process, and return the child handle.
103
104
    :param diffcmd: The command list to spawn
105
    :param capture_errors: Capture stderr as well as setting LANG=C.
106
        This lets us read and understand the output of diff, and respond 
107
        to any errors.
108
    :return: A Popen object.
109
    """
110
    if capture_errors:
1963.1.8 by John Arbash Meinel
Don't use preexec_fn on win32
111
        if sys.platform == 'win32':
112
            # Win32 doesn't support preexec_fn, but that is
113
            # okay, because it doesn't support LANG either.
114
            preexec_fn = None
115
        else:
116
            preexec_fn = _set_lang_C
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
117
        stderr = subprocess.PIPE
118
    else:
119
        preexec_fn = None
120
        stderr = None
121
122
    try:
123
        pipe = subprocess.Popen(diffcmd,
124
                                stdin=subprocess.PIPE,
125
                                stdout=subprocess.PIPE,
126
                                stderr=stderr,
127
                                preexec_fn=preexec_fn)
128
    except OSError, e:
129
        if e.errno == errno.ENOENT:
130
            raise errors.NoDiff(str(e))
131
        raise
132
133
    return pipe
134
135
1185.35.29 by Aaron Bentley
Support whitespace in diff filenames
136
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
571 by Martin Pool
- new --diff-options to pass options through to external
137
                  diff_opts):
568 by Martin Pool
- start adding support for showing diffs by calling out to
138
    """Display a diff by calling out to the external diff program."""
581 by Martin Pool
- make sure any bzr output is flushed before
139
    # make sure our own output is properly ordered before the diff
140
    to_file.flush()
141
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
142
    oldtmp_fd, old_abspath = tempfile.mkstemp(prefix='bzr-diff-old-')
143
    newtmp_fd, new_abspath = tempfile.mkstemp(prefix='bzr-diff-new-')
144
    oldtmpf = os.fdopen(oldtmp_fd, 'wb')
145
    newtmpf = os.fdopen(newtmp_fd, 'wb')
568 by Martin Pool
- start adding support for showing diffs by calling out to
146
147
    try:
148
        # TODO: perhaps a special case for comparing to or from the empty
149
        # sequence; can just use /dev/null on Unix
150
151
        # TODO: if either of the files being compared already exists as a
152
        # regular named file (e.g. in the working directory) then we can
153
        # compare directly to that, rather than copying it.
154
155
        oldtmpf.writelines(oldlines)
156
        newtmpf.writelines(newlines)
157
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
158
        oldtmpf.close()
159
        newtmpf.close()
568 by Martin Pool
- start adding support for showing diffs by calling out to
160
571 by Martin Pool
- new --diff-options to pass options through to external
161
        if not diff_opts:
162
            diff_opts = []
163
        diffcmd = ['diff',
1740.2.5 by Aaron Bentley
Merge from bzr.dev
164
                   '--label', old_filename,
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
165
                   old_abspath,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
166
                   '--label', new_filename,
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
167
                   new_abspath,
168
                   '--binary',
169
                  ]
571 by Martin Pool
- new --diff-options to pass options through to external
170
171
        # diff only allows one style to be specified; they don't override.
172
        # note that some of these take optargs, and the optargs can be
173
        # directly appended to the options.
174
        # this is only an approximate parser; it doesn't properly understand
175
        # the grammar.
176
        for s in ['-c', '-u', '-C', '-U',
177
                  '-e', '--ed',
178
                  '-q', '--brief',
179
                  '--normal',
180
                  '-n', '--rcs',
181
                  '-y', '--side-by-side',
182
                  '-D', '--ifdef']:
183
            for j in diff_opts:
184
                if j.startswith(s):
185
                    break
186
            else:
187
                continue
188
            break
189
        else:
190
            diffcmd.append('-u')
191
                  
192
        if diff_opts:
193
            diffcmd.extend(diff_opts)
194
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
195
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
196
        out,err = pipe.communicate()
197
        rc = pipe.returncode
571 by Martin Pool
- new --diff-options to pass options through to external
198
        
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
199
        # internal_diff() adds a trailing newline, add one here for consistency
200
        out += '\n'
1899.1.5 by John Arbash Meinel
Always buffer the output of diff, so we can check if retcode==2 is because of Binary files
201
        if rc == 2:
202
            # 'diff' gives retcode == 2 for all sorts of errors
203
            # one of those is 'Binary files differ'.
204
            # Bad options could also be the problem.
1904.1.4 by Marien Zwart
Make external diff in binary mode work with recent versions of diffutils.
205
            # 'Binary files' is not a real error, so we suppress that error.
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
206
            lang_c_out = out
207
208
            # Since we got here, we want to make sure to give an i18n error
209
            pipe = _spawn_external_diff(diffcmd, capture_errors=False)
210
            out, err = pipe.communicate()
211
212
            # Write out the new i18n diff response
213
            to_file.write(out+'\n')
214
            if pipe.returncode != 2:
215
                raise BzrError('external diff failed with exit code 2'
216
                               ' when run with LANG=C, but not when run'
217
                               ' natively: %r' % (diffcmd,))
218
219
            first_line = lang_c_out.split('\n', 1)[0]
1904.1.4 by Marien Zwart
Make external diff in binary mode work with recent versions of diffutils.
220
            # Starting with diffutils 2.8.4 the word "binary" was dropped.
221
            m = re.match('^(binary )?files.*differ$', first_line, re.I)
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
222
            if m is None:
1899.1.5 by John Arbash Meinel
Always buffer the output of diff, so we can check if retcode==2 is because of Binary files
223
                raise BzrError('external diff failed with exit code 2;'
224
                               ' command: %r' % (diffcmd,))
1920.1.1 by John Arbash Meinel
fix bug #56307, handle binary files even when LANG is not english
225
            else:
226
                # Binary files differ, just return
227
                return
228
229
        # If we got to here, we haven't written out the output of diff
230
        # do so now
231
        to_file.write(out)
232
        if rc not in (0, 1):
571 by Martin Pool
- new --diff-options to pass options through to external
233
            # returns 1 if files differ; that's OK
234
            if rc < 0:
235
                msg = 'signal %d' % (-rc)
236
            else:
237
                msg = 'exit code %d' % rc
238
                
1899.1.4 by John Arbash Meinel
Just swallow a return code of 2
239
            raise BzrError('external diff failed with %s; command: %r' 
240
                           % (rc, diffcmd))
1899.1.6 by John Arbash Meinel
internal_diff always adds a trailing \n, make sure external_diff does too
241
242
568 by Martin Pool
- start adding support for showing diffs by calling out to
243
    finally:
244
        oldtmpf.close()                 # and delete
245
        newtmpf.close()
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
246
        # Clean up. Warn in case the files couldn't be deleted
247
        # (in case windows still holds the file open, but not
248
        # if the files have already been deleted)
249
        try:
250
            os.remove(old_abspath)
251
        except OSError, e:
252
            if e.errno not in (errno.ENOENT,):
253
                warning('Failed to delete temporary file: %s %s',
254
                        old_abspath, e)
255
        try:
256
            os.remove(new_abspath)
257
        except OSError:
258
            if e.errno not in (errno.ENOENT,):
259
                warning('Failed to delete temporary file: %s %s',
260
                        new_abspath, e)
568 by Martin Pool
- start adding support for showing diffs by calling out to
261
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
262
263
@deprecated_function(zero_eight)
1432 by Robert Collins
branch: namespace
264
def show_diff(b, from_spec, specific_files, external_diff_options=None,
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
265
              revision2=None, output=None, b2=None):
619 by Martin Pool
doc
266
    """Shortcut for showing the diff to the working tree.
267
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
268
    Please use show_diff_trees instead.
269
619 by Martin Pool
doc
270
    b
271
        Branch.
272
273
    revision
1432 by Robert Collins
branch: namespace
274
        None for 'basis tree', or otherwise the old revision to compare against.
619 by Martin Pool
doc
275
    
276
    The more general form is show_diff_trees(), where the caller
277
    supplies any two trees.
278
    """
1092.1.47 by Robert Collins
make show_diff redirectable
279
    if output is None:
280
        output = sys.stdout
475 by Martin Pool
- rewrite diff using compare_trees()
281
1432 by Robert Collins
branch: namespace
282
    if from_spec is None:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
283
        old_tree = b.bzrdir.open_workingtree()
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
284
        if b2 is None:
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
285
            old_tree = old_tree = old_tree.basis_tree()
329 by Martin Pool
- refactor command functions into command classes
286
    else:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
287
        old_tree = b.repository.revision_tree(from_spec.in_history(b).rev_id)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
288
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
289
    if revision2 is None:
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
290
        if b2 is None:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
291
            new_tree = b.bzrdir.open_workingtree()
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
292
        else:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
293
            new_tree = b2.bzrdir.open_workingtree()
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
294
    else:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
295
        new_tree = b.repository.revision_tree(revision2.in_history(b).rev_id)
329 by Martin Pool
- refactor command functions into command classes
296
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
297
    return show_diff_trees(old_tree, new_tree, output, specific_files,
298
                           external_diff_options)
571 by Martin Pool
- new --diff-options to pass options through to external
299
300
1551.2.15 by Aaron Bentley
Rename cmd_show_diff to diff_cmd_helper
301
def diff_cmd_helper(tree, specific_files, external_diff_options, 
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
302
                    old_revision_spec=None, new_revision_spec=None,
303
                    old_label='a/', new_label='b/'):
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
304
    """Helper for cmd_diff.
305
306
   tree 
307
        A WorkingTree
308
309
    specific_files
310
        The specific files to compare, or None
311
312
    external_diff_options
313
        If non-None, run an external diff, and pass it these options
314
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
315
    old_revision_spec
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
316
        If None, use basis tree as old revision, otherwise use the tree for
317
        the specified revision. 
318
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
319
    new_revision_spec
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
320
        If None, use working tree as new revision, otherwise use the tree for
321
        the specified revision.
322
    
323
    The more general form is show_diff_trees(), where the caller
324
    supplies any two trees.
325
    """
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
326
    def spec_tree(spec):
1732.3.1 by Matthieu Moy
Implementation of -r revno:N:/path/to/branch
327
        if tree:
328
            revision = spec.in_store(tree.branch)
329
        else:
330
            revision = spec.in_store(None)
331
        revision_id = revision.rev_id
332
        branch = revision.branch
333
        return branch.repository.revision_tree(revision_id)
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
334
    if old_revision_spec is None:
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
335
        old_tree = tree.basis_tree()
336
    else:
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
337
        old_tree = spec_tree(old_revision_spec)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
338
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
339
    if new_revision_spec is None:
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
340
        new_tree = tree
341
    else:
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
342
        new_tree = spec_tree(new_revision_spec)
1551.7.19 by Aaron Bentley
Always include working tree when calculating file ids for diff
343
    if new_tree is not tree:
344
        extra_trees = (tree,)
345
    else:
346
        extra_trees = None
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
347
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
348
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
349
                           external_diff_options,
1551.7.19 by Aaron Bentley
Always include working tree when calculating file ids for diff
350
                           old_label=old_label, new_label=new_label,
351
                           extra_trees=extra_trees)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
352
571 by Martin Pool
- new --diff-options to pass options through to external
353
354
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
355
                    external_diff_options=None,
1551.7.17 by Aaron Bentley
Switch to PathsNotVersioned, accept extra_trees
356
                    old_label='a/', new_label='b/',
357
                    extra_trees=None):
550 by Martin Pool
- Refactor diff code into one that works purely on
358
    """Show in text form the changes from one tree to another.
359
360
    to_files
361
        If set, include only changes to these files.
571 by Martin Pool
- new --diff-options to pass options through to external
362
363
    external_diff_options
364
        If set, use an external GNU diff and pass these options.
1551.7.18 by Aaron Bentley
Indentation and documentation fixes
365
366
    extra_trees
367
        If set, more Trees to use for looking up file ids
550 by Martin Pool
- Refactor diff code into one that works purely on
368
    """
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
369
    old_tree.lock_read()
370
    try:
371
        new_tree.lock_read()
372
        try:
373
            return _show_diff_trees(old_tree, new_tree, to_file,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
374
                                    specific_files, external_diff_options,
1551.7.17 by Aaron Bentley
Switch to PathsNotVersioned, accept extra_trees
375
                                    old_label=old_label, new_label=new_label,
376
                                    extra_trees=extra_trees)
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
377
        finally:
378
            new_tree.unlock()
379
    finally:
380
        old_tree.unlock()
381
382
383
def _show_diff_trees(old_tree, new_tree, to_file,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
384
                     specific_files, external_diff_options, 
1551.7.17 by Aaron Bentley
Switch to PathsNotVersioned, accept extra_trees
385
                     old_label='a/', new_label='b/', extra_trees=None):
329 by Martin Pool
- refactor command functions into command classes
386
1740.2.5 by Aaron Bentley
Merge from bzr.dev
387
    # GNU Patch uses the epoch date to detect files that are being added
388
    # or removed in a diff.
389
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
1706.1.2 by James Henstridge
Simplify logic a little
390
329 by Martin Pool
- refactor command functions into command classes
391
    # TODO: Generation of pseudo-diffs for added/deleted files could
392
    # be usefully made into a much faster special case.
393
571 by Martin Pool
- new --diff-options to pass options through to external
394
    if external_diff_options:
395
        assert isinstance(external_diff_options, basestring)
396
        opts = external_diff_options.split()
397
        def diff_file(olab, olines, nlab, nlines, to_file):
398
            external_diff(olab, olines, nlab, nlines, to_file, opts)
399
    else:
400
        diff_file = internal_diff
401
    
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
402
    delta = new_tree.changes_from(old_tree,
403
        specific_files=specific_files,
404
        extra_trees=extra_trees, require_versioned=True)
475 by Martin Pool
- rewrite diff using compare_trees()
405
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
406
    has_changes = 0
475 by Martin Pool
- rewrite diff using compare_trees()
407
    for path, file_id, kind in delta.removed:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
408
        has_changes = 1
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
409
        print >>to_file, '=== removed %s %r' % (kind, path.encode('utf8'))
1740.2.5 by Aaron Bentley
Merge from bzr.dev
410
        old_name = '%s%s\t%s' % (old_label, path,
411
                                 _patch_header_date(old_tree, file_id, path))
412
        new_name = '%s%s\t%s' % (new_label, path, EPOCH_DATE)
413
        old_tree.inventory[file_id].diff(diff_file, old_name, old_tree,
414
                                         new_name, None, None, to_file)
475 by Martin Pool
- rewrite diff using compare_trees()
415
    for path, file_id, kind in delta.added:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
416
        has_changes = 1
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
417
        print >>to_file, '=== added %s %r' % (kind, path.encode('utf8'))
1740.2.5 by Aaron Bentley
Merge from bzr.dev
418
        old_name = '%s%s\t%s' % (old_label, path, EPOCH_DATE)
419
        new_name = '%s%s\t%s' % (new_label, path,
420
                                 _patch_header_date(new_tree, file_id, path))
421
        new_tree.inventory[file_id].diff(diff_file, new_name, new_tree,
422
                                         old_name, None, None, to_file, 
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
423
                                         reverse=True)
1398 by Robert Collins
integrate in Gustavos x-bit patch
424
    for (old_path, new_path, file_id, kind,
425
         text_modified, meta_modified) in delta.renamed:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
426
        has_changes = 1
1398 by Robert Collins
integrate in Gustavos x-bit patch
427
        prop_str = get_prop_change(meta_modified)
428
        print >>to_file, '=== renamed %s %r => %r%s' % (
1711.2.28 by John Arbash Meinel
Fix up bzrlib.diff now that compare_trees is returning unicode paths.
429
                    kind, old_path.encode('utf8'),
430
                    new_path.encode('utf8'), prop_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
431
        old_name = '%s%s\t%s' % (old_label, old_path,
432
                                 _patch_header_date(old_tree, file_id,
433
                                                    old_path))
434
        new_name = '%s%s\t%s' % (new_label, new_path,
435
                                 _patch_header_date(new_tree, file_id,
436
                                                    new_path))
437
        _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
438
                                    new_name, new_tree,
1092.2.9 by Robert Collins
bugfix _maybe_diff, the test was not catching the error
439
                                    text_modified, kind, to_file, diff_file)
1398 by Robert Collins
integrate in Gustavos x-bit patch
440
    for path, file_id, kind, text_modified, meta_modified in delta.modified:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
441
        has_changes = 1
1398 by Robert Collins
integrate in Gustavos x-bit patch
442
        prop_str = get_prop_change(meta_modified)
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
443
        print >>to_file, '=== modified %s %r%s' % (kind, path.encode('utf8'), prop_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
444
        old_name = '%s%s\t%s' % (old_label, path,
445
                                 _patch_header_date(old_tree, file_id, path))
446
        new_name = '%s%s\t%s' % (new_label, path,
447
                                 _patch_header_date(new_tree, file_id, path))
1398 by Robert Collins
integrate in Gustavos x-bit patch
448
        if text_modified:
1740.2.5 by Aaron Bentley
Merge from bzr.dev
449
            _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
450
                                        new_name, new_tree,
1398 by Robert Collins
integrate in Gustavos x-bit patch
451
                                        True, kind, to_file, diff_file)
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
452
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
453
    return has_changes
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
454
455
1740.2.5 by Aaron Bentley
Merge from bzr.dev
456
def _patch_header_date(tree, file_id, path):
457
    """Returns a timestamp suitable for use in a patch header."""
458
    tm = time.gmtime(tree.get_file_mtime(file_id, path))
459
    return time.strftime('%Y-%m-%d %H:%M:%S +0000', tm)
460
461
1662.1.9 by Martin Pool
Give a clear error for bzr status of an unversioned, nonexistent file. (Malone #3619)
462
def _raise_if_nonexistent(paths, old_tree, new_tree):
463
    """Complain if paths are not in either inventory or tree.
464
465
    It's OK with the files exist in either tree's inventory, or 
466
    if they exist in the tree but are not versioned.
467
    
468
    This can be used by operations such as bzr status that can accept
469
    unknown or ignored files.
470
    """
471
    mutter("check paths: %r", paths)
472
    if not paths:
473
        return
474
    s = old_tree.filter_unversioned_files(paths)
475
    s = new_tree.filter_unversioned_files(s)
476
    s = [path for path in s if not new_tree.has_filename(path)]
477
    if s:
478
        raise errors.PathsDoNotExist(sorted(s))
479
480
1398 by Robert Collins
integrate in Gustavos x-bit patch
481
def get_prop_change(meta_modified):
482
    if meta_modified:
483
        return " (properties changed)"
484
    else:
485
        return  ""
486
487
1740.2.5 by Aaron Bentley
Merge from bzr.dev
488
def _maybe_diff_file_or_symlink(old_path, old_tree, file_id,
489
                                new_path, new_tree, text_modified,
1092.2.9 by Robert Collins
bugfix _maybe_diff, the test was not catching the error
490
                                kind, to_file, diff_file):
1092.2.6 by Robert Collins
symlink support updated to work
491
    if text_modified:
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
492
        new_entry = new_tree.inventory[file_id]
493
        old_tree.inventory[file_id].diff(diff_file,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
494
                                         old_path, old_tree,
495
                                         new_path, new_entry, 
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
496
                                         new_tree, to_file)