~bzr-pqm/bzr/bzr.dev

1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
2
#
1 by mbp at sourcefrog
import from baz patch-364
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
7
#
1 by mbp at sourcefrog
import from baz patch-364
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
12
#
1 by mbp at sourcefrog
import from baz patch-364
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
17
import errno
18
import os
1692.8.7 by James Henstridge
changes suggested by John Meinel
19
import subprocess
1692.8.4 by James Henstridge
move external_diff imports to top of file
20
import sys
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
21
import tempfile
1740.2.5 by Aaron Bentley
Merge from bzr.dev
22
import time
23
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
24
from bzrlib.delta import compare_trees
25
from bzrlib.errors import BzrError
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
26
import bzrlib.errors as errors
1711.2.58 by John Arbash Meinel
Use osutils.pumpfile so we don't have to buffer everything in ram
27
import bzrlib.osutils
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
28
from bzrlib.patiencediff import unified_diff
29
import bzrlib.patiencediff
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
30
from bzrlib.symbol_versioning import (deprecated_function,
31
        zero_eight)
1558.15.2 by Aaron Bentley
Implemented binary file handling for diff
32
from bzrlib.textfile import check_text_lines
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
33
from bzrlib.trace import mutter, warning
1 by mbp at sourcefrog
import from baz patch-364
34
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
35
767 by Martin Pool
- files are only reported as modified if their name or parent has changed,
36
# TODO: Rather than building a changeset object, we should probably
37
# invoke callbacks on an object.  That object can either accumulate a
38
# list, write them out directly, etc etc.
39
1558.15.11 by Aaron Bentley
Apply merge review suggestions
40
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
1711.2.30 by John Arbash Meinel
Fix bug in internal_diff handling of unicode paths
41
                  allow_binary=False, sequence_matcher=None,
42
                  path_encoding='utf8'):
475 by Martin Pool
- rewrite diff using compare_trees()
43
    # FIXME: difflib is wrong if there is no trailing newline.
44
    # The syntax used by patch seems to be "\ No newline at
45
    # end of file" following the last diff line from that
46
    # file.  This is not trivial to insert into the
47
    # unified_diff output and it might be better to just fix
48
    # or replace that function.
49
50
    # In the meantime we at least make sure the patch isn't
51
    # mangled.
52
53
54
    # Special workaround for Python2.3, where difflib fails if
55
    # both sequences are empty.
56
    if not oldlines and not newlines:
57
        return
1558.15.2 by Aaron Bentley
Implemented binary file handling for diff
58
    
1558.15.11 by Aaron Bentley
Apply merge review suggestions
59
    if allow_binary is False:
60
        check_text_lines(oldlines)
61
        check_text_lines(newlines)
475 by Martin Pool
- rewrite diff using compare_trees()
62
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
63
    if sequence_matcher is None:
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
64
        sequence_matcher = bzrlib.patiencediff.PatienceSequenceMatcher
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
65
    ud = unified_diff(oldlines, newlines,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
66
                      fromfile=old_filename.encode(path_encoding),
67
                      tofile=new_filename.encode(path_encoding),
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
68
                      sequencematcher=sequence_matcher)
475 by Martin Pool
- rewrite diff using compare_trees()
69
1092.1.50 by Robert Collins
make diff lsdiff/filterdiff friendly
70
    ud = list(ud)
475 by Martin Pool
- rewrite diff using compare_trees()
71
    # work-around for difflib being too smart for its own good
72
    # if /dev/null is "1,0", patch won't recognize it as /dev/null
73
    if not oldlines:
74
        ud[2] = ud[2].replace('-1,0', '-0,0')
75
    elif not newlines:
76
        ud[2] = ud[2].replace('+1,0', '+0,0')
1092.1.50 by Robert Collins
make diff lsdiff/filterdiff friendly
77
    # work around for difflib emitting random spaces after the label
78
    ud[0] = ud[0][:-2] + '\n'
79
    ud[1] = ud[1][:-2] + '\n'
475 by Martin Pool
- rewrite diff using compare_trees()
80
804 by Martin Pool
Patch from John:
81
    for line in ud:
82
        to_file.write(line)
974.1.5 by Aaron Bentley
Fixed handling of missing newlines in udiffs
83
        if not line.endswith('\n'):
84
            to_file.write("\n\\ No newline at end of file\n")
475 by Martin Pool
- rewrite diff using compare_trees()
85
    print >>to_file
86
87
1185.35.29 by Aaron Bentley
Support whitespace in diff filenames
88
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
571 by Martin Pool
- new --diff-options to pass options through to external
89
                  diff_opts):
568 by Martin Pool
- start adding support for showing diffs by calling out to
90
    """Display a diff by calling out to the external diff program."""
1711.2.57 by John Arbash Meinel
Allow external diff to write to a file without a fileno.
91
    if hasattr(to_file, 'fileno'):
92
        out_file = to_file
93
        have_fileno = True
94
    else:
95
        out_file = subprocess.PIPE
96
        have_fileno = False
568 by Martin Pool
- start adding support for showing diffs by calling out to
97
    
581 by Martin Pool
- make sure any bzr output is flushed before
98
    # make sure our own output is properly ordered before the diff
99
    to_file.flush()
100
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
101
    oldtmp_fd, old_abspath = tempfile.mkstemp(prefix='bzr-diff-old-')
102
    newtmp_fd, new_abspath = tempfile.mkstemp(prefix='bzr-diff-new-')
103
    oldtmpf = os.fdopen(oldtmp_fd, 'wb')
104
    newtmpf = os.fdopen(newtmp_fd, 'wb')
568 by Martin Pool
- start adding support for showing diffs by calling out to
105
106
    try:
107
        # TODO: perhaps a special case for comparing to or from the empty
108
        # sequence; can just use /dev/null on Unix
109
110
        # TODO: if either of the files being compared already exists as a
111
        # regular named file (e.g. in the working directory) then we can
112
        # compare directly to that, rather than copying it.
113
114
        oldtmpf.writelines(oldlines)
115
        newtmpf.writelines(newlines)
116
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
117
        oldtmpf.close()
118
        newtmpf.close()
568 by Martin Pool
- start adding support for showing diffs by calling out to
119
571 by Martin Pool
- new --diff-options to pass options through to external
120
        if not diff_opts:
121
            diff_opts = []
122
        diffcmd = ['diff',
1740.2.5 by Aaron Bentley
Merge from bzr.dev
123
                   '--label', old_filename,
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
124
                   old_abspath,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
125
                   '--label', new_filename,
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
126
                   new_abspath,
127
                   '--binary',
128
                  ]
571 by Martin Pool
- new --diff-options to pass options through to external
129
130
        # diff only allows one style to be specified; they don't override.
131
        # note that some of these take optargs, and the optargs can be
132
        # directly appended to the options.
133
        # this is only an approximate parser; it doesn't properly understand
134
        # the grammar.
135
        for s in ['-c', '-u', '-C', '-U',
136
                  '-e', '--ed',
137
                  '-q', '--brief',
138
                  '--normal',
139
                  '-n', '--rcs',
140
                  '-y', '--side-by-side',
141
                  '-D', '--ifdef']:
142
            for j in diff_opts:
143
                if j.startswith(s):
144
                    break
145
            else:
146
                continue
147
            break
148
        else:
149
            diffcmd.append('-u')
150
                  
151
        if diff_opts:
152
            diffcmd.extend(diff_opts)
153
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
154
        try:
155
            pipe = subprocess.Popen(diffcmd,
156
                                    stdin=subprocess.PIPE,
1711.2.57 by John Arbash Meinel
Allow external diff to write to a file without a fileno.
157
                                    stdout=out_file)
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
158
        except OSError, e:
159
            if e.errno == errno.ENOENT:
160
                raise errors.NoDiff(str(e))
161
            raise
1692.8.1 by James Henstridge
add support for redirecting external diff output to a file descriptor
162
        pipe.stdin.close()
1711.2.57 by John Arbash Meinel
Allow external diff to write to a file without a fileno.
163
164
        if not have_fileno:
1711.2.58 by John Arbash Meinel
Use osutils.pumpfile so we don't have to buffer everything in ram
165
            bzrlib.osutils.pumpfile(pipe.stdout, to_file)
1692.8.1 by James Henstridge
add support for redirecting external diff output to a file descriptor
166
        rc = pipe.wait()
571 by Martin Pool
- new --diff-options to pass options through to external
167
        
168
        if rc != 0 and rc != 1:
169
            # returns 1 if files differ; that's OK
170
            if rc < 0:
171
                msg = 'signal %d' % (-rc)
172
            else:
173
                msg = 'exit code %d' % rc
174
                
175
            raise BzrError('external diff failed with %s; command: %r' % (rc, diffcmd))
568 by Martin Pool
- start adding support for showing diffs by calling out to
176
    finally:
177
        oldtmpf.close()                 # and delete
178
        newtmpf.close()
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
179
        # Clean up. Warn in case the files couldn't be deleted
180
        # (in case windows still holds the file open, but not
181
        # if the files have already been deleted)
182
        try:
183
            os.remove(old_abspath)
184
        except OSError, e:
185
            if e.errno not in (errno.ENOENT,):
186
                warning('Failed to delete temporary file: %s %s',
187
                        old_abspath, e)
188
        try:
189
            os.remove(new_abspath)
190
        except OSError:
191
            if e.errno not in (errno.ENOENT,):
192
                warning('Failed to delete temporary file: %s %s',
193
                        new_abspath, e)
568 by Martin Pool
- start adding support for showing diffs by calling out to
194
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
195
196
@deprecated_function(zero_eight)
1432 by Robert Collins
branch: namespace
197
def show_diff(b, from_spec, specific_files, external_diff_options=None,
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
198
              revision2=None, output=None, b2=None):
619 by Martin Pool
doc
199
    """Shortcut for showing the diff to the working tree.
200
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
201
    Please use show_diff_trees instead.
202
619 by Martin Pool
doc
203
    b
204
        Branch.
205
206
    revision
1432 by Robert Collins
branch: namespace
207
        None for 'basis tree', or otherwise the old revision to compare against.
619 by Martin Pool
doc
208
    
209
    The more general form is show_diff_trees(), where the caller
210
    supplies any two trees.
211
    """
1092.1.47 by Robert Collins
make show_diff redirectable
212
    if output is None:
213
        output = sys.stdout
475 by Martin Pool
- rewrite diff using compare_trees()
214
1432 by Robert Collins
branch: namespace
215
    if from_spec is None:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
216
        old_tree = b.bzrdir.open_workingtree()
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
217
        if b2 is None:
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
218
            old_tree = old_tree = old_tree.basis_tree()
329 by Martin Pool
- refactor command functions into command classes
219
    else:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
220
        old_tree = b.repository.revision_tree(from_spec.in_history(b).rev_id)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
221
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
222
    if revision2 is None:
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
223
        if b2 is None:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
224
            new_tree = b.bzrdir.open_workingtree()
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
225
        else:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
226
            new_tree = b2.bzrdir.open_workingtree()
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
227
    else:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
228
        new_tree = b.repository.revision_tree(revision2.in_history(b).rev_id)
329 by Martin Pool
- refactor command functions into command classes
229
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
230
    return show_diff_trees(old_tree, new_tree, output, specific_files,
231
                           external_diff_options)
571 by Martin Pool
- new --diff-options to pass options through to external
232
233
1551.2.15 by Aaron Bentley
Rename cmd_show_diff to diff_cmd_helper
234
def diff_cmd_helper(tree, specific_files, external_diff_options, 
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
235
                    old_revision_spec=None, new_revision_spec=None,
236
                    old_label='a/', new_label='b/'):
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
237
    """Helper for cmd_diff.
238
239
   tree 
240
        A WorkingTree
241
242
    specific_files
243
        The specific files to compare, or None
244
245
    external_diff_options
246
        If non-None, run an external diff, and pass it these options
247
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
248
    old_revision_spec
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
249
        If None, use basis tree as old revision, otherwise use the tree for
250
        the specified revision. 
251
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
252
    new_revision_spec
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
253
        If None, use working tree as new revision, otherwise use the tree for
254
        the specified revision.
255
    
256
    The more general form is show_diff_trees(), where the caller
257
    supplies any two trees.
258
    """
259
    output = sys.stdout
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
260
    def spec_tree(spec):
261
        revision_id = spec.in_store(tree.branch).rev_id
262
        return tree.branch.repository.revision_tree(revision_id)
263
    if old_revision_spec is None:
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
264
        old_tree = tree.basis_tree()
265
    else:
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
266
        old_tree = spec_tree(old_revision_spec)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
267
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
268
    if new_revision_spec is None:
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
269
        new_tree = tree
270
    else:
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
271
        new_tree = spec_tree(new_revision_spec)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
272
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
273
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
274
                           external_diff_options,
275
                           old_label=old_label, new_label=new_label)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
276
571 by Martin Pool
- new --diff-options to pass options through to external
277
278
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
279
                    external_diff_options=None,
280
                    old_label='a/', new_label='b/'):
550 by Martin Pool
- Refactor diff code into one that works purely on
281
    """Show in text form the changes from one tree to another.
282
283
    to_files
284
        If set, include only changes to these files.
571 by Martin Pool
- new --diff-options to pass options through to external
285
286
    external_diff_options
287
        If set, use an external GNU diff and pass these options.
550 by Martin Pool
- Refactor diff code into one that works purely on
288
    """
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
289
    old_tree.lock_read()
290
    try:
291
        new_tree.lock_read()
292
        try:
293
            return _show_diff_trees(old_tree, new_tree, to_file,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
294
                                    specific_files, external_diff_options,
295
                                    old_label=old_label, new_label=new_label)
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
296
        finally:
297
            new_tree.unlock()
298
    finally:
299
        old_tree.unlock()
300
301
302
def _show_diff_trees(old_tree, new_tree, to_file,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
303
                     specific_files, external_diff_options, 
304
                     old_label='a/', new_label='b/' ):
329 by Martin Pool
- refactor command functions into command classes
305
1740.2.5 by Aaron Bentley
Merge from bzr.dev
306
    # GNU Patch uses the epoch date to detect files that are being added
307
    # or removed in a diff.
308
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
1706.1.2 by James Henstridge
Simplify logic a little
309
329 by Martin Pool
- refactor command functions into command classes
310
    # TODO: Generation of pseudo-diffs for added/deleted files could
311
    # be usefully made into a much faster special case.
312
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
313
    _raise_if_doubly_unversioned(specific_files, old_tree, new_tree)
314
571 by Martin Pool
- new --diff-options to pass options through to external
315
    if external_diff_options:
316
        assert isinstance(external_diff_options, basestring)
317
        opts = external_diff_options.split()
318
        def diff_file(olab, olines, nlab, nlines, to_file):
319
            external_diff(olab, olines, nlab, nlines, to_file, opts)
320
    else:
321
        diff_file = internal_diff
322
    
478 by Martin Pool
- put back support for running diff or status on
323
    delta = compare_trees(old_tree, new_tree, want_unchanged=False,
483 by Martin Pool
- change 'file_list' to more explanatory 'specific_files'
324
                          specific_files=specific_files)
475 by Martin Pool
- rewrite diff using compare_trees()
325
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
326
    has_changes = 0
475 by Martin Pool
- rewrite diff using compare_trees()
327
    for path, file_id, kind in delta.removed:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
328
        has_changes = 1
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
329
        print >>to_file, '=== removed %s %r' % (kind, path.encode('utf8'))
1740.2.5 by Aaron Bentley
Merge from bzr.dev
330
        old_name = '%s%s\t%s' % (old_label, path,
331
                                 _patch_header_date(old_tree, file_id, path))
332
        new_name = '%s%s\t%s' % (new_label, path, EPOCH_DATE)
333
        old_tree.inventory[file_id].diff(diff_file, old_name, old_tree,
334
                                         new_name, None, None, to_file)
475 by Martin Pool
- rewrite diff using compare_trees()
335
    for path, file_id, kind in delta.added:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
336
        has_changes = 1
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
337
        print >>to_file, '=== added %s %r' % (kind, path.encode('utf8'))
1740.2.5 by Aaron Bentley
Merge from bzr.dev
338
        old_name = '%s%s\t%s' % (old_label, path, EPOCH_DATE)
339
        new_name = '%s%s\t%s' % (new_label, path,
340
                                 _patch_header_date(new_tree, file_id, path))
341
        new_tree.inventory[file_id].diff(diff_file, new_name, new_tree,
342
                                         old_name, None, None, to_file, 
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
343
                                         reverse=True)
1398 by Robert Collins
integrate in Gustavos x-bit patch
344
    for (old_path, new_path, file_id, kind,
345
         text_modified, meta_modified) in delta.renamed:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
346
        has_changes = 1
1398 by Robert Collins
integrate in Gustavos x-bit patch
347
        prop_str = get_prop_change(meta_modified)
348
        print >>to_file, '=== renamed %s %r => %r%s' % (
1711.2.28 by John Arbash Meinel
Fix up bzrlib.diff now that compare_trees is returning unicode paths.
349
                    kind, old_path.encode('utf8'),
350
                    new_path.encode('utf8'), prop_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
351
        old_name = '%s%s\t%s' % (old_label, old_path,
352
                                 _patch_header_date(old_tree, file_id,
353
                                                    old_path))
354
        new_name = '%s%s\t%s' % (new_label, new_path,
355
                                 _patch_header_date(new_tree, file_id,
356
                                                    new_path))
357
        _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
358
                                    new_name, new_tree,
1092.2.9 by Robert Collins
bugfix _maybe_diff, the test was not catching the error
359
                                    text_modified, kind, to_file, diff_file)
1398 by Robert Collins
integrate in Gustavos x-bit patch
360
    for path, file_id, kind, text_modified, meta_modified in delta.modified:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
361
        has_changes = 1
1398 by Robert Collins
integrate in Gustavos x-bit patch
362
        prop_str = get_prop_change(meta_modified)
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
363
        print >>to_file, '=== modified %s %r%s' % (kind, path.encode('utf8'), prop_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
364
        old_name = '%s%s\t%s' % (old_label, path,
365
                                 _patch_header_date(old_tree, file_id, path))
366
        new_name = '%s%s\t%s' % (new_label, path,
367
                                 _patch_header_date(new_tree, file_id, path))
1398 by Robert Collins
integrate in Gustavos x-bit patch
368
        if text_modified:
1740.2.5 by Aaron Bentley
Merge from bzr.dev
369
            _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
370
                                        new_name, new_tree,
1398 by Robert Collins
integrate in Gustavos x-bit patch
371
                                        True, kind, to_file, diff_file)
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
372
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
373
    return has_changes
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
374
375
1740.2.5 by Aaron Bentley
Merge from bzr.dev
376
def _patch_header_date(tree, file_id, path):
377
    """Returns a timestamp suitable for use in a patch header."""
378
    tm = time.gmtime(tree.get_file_mtime(file_id, path))
379
    return time.strftime('%Y-%m-%d %H:%M:%S +0000', tm)
380
381
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
382
def _raise_if_doubly_unversioned(specific_files, old_tree, new_tree):
383
    """Complain if paths are not versioned in either tree."""
1662.1.12 by Martin Pool
Translate unknown sftp errors to PathError, no NoSuchFile
384
    if not specific_files:
1658.1.10 by Martin Pool
diff on unversiond files should give an error (Malone #3619)
385
        return
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
386
    old_unversioned = old_tree.filter_unversioned_files(specific_files)
387
    new_unversioned = new_tree.filter_unversioned_files(specific_files)
388
    unversioned = old_unversioned.intersection(new_unversioned)
389
    if unversioned:
390
        raise errors.PathsNotVersionedError(sorted(unversioned))
1092.3.4 by Robert Collins
update symlink branch to integration
391
    
1092.2.6 by Robert Collins
symlink support updated to work
392
1662.1.9 by Martin Pool
Give a clear error for bzr status of an unversioned, nonexistent file. (Malone #3619)
393
def _raise_if_nonexistent(paths, old_tree, new_tree):
394
    """Complain if paths are not in either inventory or tree.
395
396
    It's OK with the files exist in either tree's inventory, or 
397
    if they exist in the tree but are not versioned.
398
    
399
    This can be used by operations such as bzr status that can accept
400
    unknown or ignored files.
401
    """
402
    mutter("check paths: %r", paths)
403
    if not paths:
404
        return
405
    s = old_tree.filter_unversioned_files(paths)
406
    s = new_tree.filter_unversioned_files(s)
407
    s = [path for path in s if not new_tree.has_filename(path)]
408
    if s:
409
        raise errors.PathsDoNotExist(sorted(s))
410
411
1398 by Robert Collins
integrate in Gustavos x-bit patch
412
def get_prop_change(meta_modified):
413
    if meta_modified:
414
        return " (properties changed)"
415
    else:
416
        return  ""
417
418
1740.2.5 by Aaron Bentley
Merge from bzr.dev
419
def _maybe_diff_file_or_symlink(old_path, old_tree, file_id,
420
                                new_path, new_tree, text_modified,
1092.2.9 by Robert Collins
bugfix _maybe_diff, the test was not catching the error
421
                                kind, to_file, diff_file):
1092.2.6 by Robert Collins
symlink support updated to work
422
    if text_modified:
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
423
        new_entry = new_tree.inventory[file_id]
424
        old_tree.inventory[file_id].diff(diff_file,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
425
                                         old_path, old_tree,
426
                                         new_path, new_entry, 
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
427
                                         new_tree, to_file)