~bzr-pqm/bzr/bzr.dev

1704.2.14 by Martin Pool
[merge] work from 0.8 fixes
1
# Copyright (C) 2005, 2006 Canonical Ltd
2
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1339 by Martin Pool
- doc
47
# TODO: Rather than mashing together the ancestry and storing it back,
48
# perhaps the weave should have single method which does it all in one
49
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
50
1341 by Martin Pool
- doc
51
# TODO: Perhaps give a warning if one of the revisions marked as
52
# merged is already in the ancestry, and then don't record it as a
53
# distinct parent.
54
1343 by Martin Pool
- fix up test for merge of trees
55
# TODO: If the file is newly merged but unchanged from the version it
56
# merges from, then it should still be reported as newly added
57
# relative to the basis revision.
58
1185.16.66 by mbp at sourcefrog
- todo
59
# TODO: Do checks that the tree can be committed *before* running the 
60
# editor; this should include checks for a pointless commit and for 
61
# unknown or missing files.
62
63
# TODO: If commit fails, leave the message in a file somewhere.
64
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
65
1189 by Martin Pool
- BROKEN: partial support for commit into weave
66
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
67
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
68
import sys
1188 by Martin Pool
- clean up imports in commit code
69
import time
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
70
import warnings
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
71
72
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
73
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
74
from bzrlib.atomicfile import AtomicFile
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
75
import bzrlib.config
1508.1.22 by Robert Collins
implement out of date working tree checks in commit.
76
import bzrlib.errors as errors
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
77
from bzrlib.errors import (BzrError, PointlessCommit,
78
                           HistoryMissing,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
79
                           ConflictsInTree,
80
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
81
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
82
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
83
                            is_inside_or_parent_of_any,
84
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
85
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
86
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
87
from bzrlib.xml5 import serializer_v5
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
88
from bzrlib.inventory import Inventory, ROOT_ID, InventoryEntry
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
89
from bzrlib.symbol_versioning import (deprecated_passed,
90
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
91
from bzrlib.workingtree import WorkingTree
1189 by Martin Pool
- BROKEN: partial support for commit into weave
92
93
94
class NullCommitReporter(object):
95
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
96
97
    def snapshot_change(self, change, path):
98
        pass
99
100
    def completed(self, revno, rev_id):
101
        pass
102
103
    def deleted(self, file_id):
104
        pass
105
106
    def escaped(self, escape_count, message):
107
        pass
108
109
    def missing(self, path):
110
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
111
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
112
    def renamed(self, change, old_path, new_path):
113
        pass
114
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
115
1189 by Martin Pool
- BROKEN: partial support for commit into weave
116
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
117
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
118
    # this may be more useful if 'note' was replaced by an overridable
119
    # method on self, which would allow more trivial subclassing.
120
    # alternative, a callable could be passed in, allowing really trivial
121
    # reuse for some uis. RBC 20060511
122
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
123
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
124
        if change == 'unchanged':
125
            return
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
126
        note("%s %s", change, path)
127
128
    def completed(self, revno, rev_id):
1607.1.5 by Robert Collins
Make commit verbose mode work!.
129
        note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
130
    
131
    def deleted(self, file_id):
132
        note('deleted %s', file_id)
133
134
    def escaped(self, escape_count, message):
135
        note("replaced %d control characters in message", escape_count)
136
137
    def missing(self, path):
138
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
139
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
140
    def renamed(self, change, old_path, new_path):
141
        note('%s %s => %s', change, old_path, new_path)
142
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
143
1189 by Martin Pool
- BROKEN: partial support for commit into weave
144
class Commit(object):
145
    """Task of committing a new revision.
146
147
    This is a MethodObject: it accumulates state as the commit is
148
    prepared, and then it is discarded.  It doesn't represent
149
    historical revisions, just the act of recording a new one.
150
151
            missing_ids
152
            Modified to hold a list of files that have been deleted from
153
            the working directory; these should be removed from the
154
            working inventory.
485 by Martin Pool
- move commit code into its own module
155
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
156
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
157
                 reporter=None,
158
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
159
        if reporter is not None:
160
            self.reporter = reporter
161
        else:
162
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
163
        if config is not None:
164
            self.config = config
165
        else:
166
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
167
        
168
    def commit(self,
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
169
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
               timestamp=None,
171
               timezone=None,
172
               committer=None,
173
               specific_files=None,
174
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
175
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
176
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
177
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
178
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
179
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
180
               local=False,
181
               reporter=None,
182
               config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
183
        """Commit working copy as a new revision.
184
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
185
        branch -- the deprecated branch to commit to. New callers should pass in 
186
                  working_tree instead
187
188
        message -- the commit message, a mandatory parameter
189
1189 by Martin Pool
- BROKEN: partial support for commit into weave
190
        timestamp -- if not None, seconds-since-epoch for a
191
             postdated/predated commit.
192
1253 by Martin Pool
- test that pointless commits are trapped
193
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
194
1253 by Martin Pool
- test that pointless commits are trapped
195
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
196
            Useful for test or import commands that need to tightly
197
            control what revisions are assigned.  If you duplicate
198
            a revision id that exists elsewhere it is your own fault.
199
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
200
201
        allow_pointless -- If true (default), commit even if nothing
202
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
203
1185.16.65 by mbp at sourcefrog
- new commit --strict option
204
        strict -- If true, don't allow a commit if the working tree
205
            contains unknown files.
206
1185.16.35 by Martin Pool
- stub for revision properties
207
        revprops -- Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
208
        :param local: Perform a local only commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
209
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
210
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
211
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
212
        if deprecated_passed(branch):
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
213
            warnings.warn("Commit.commit (branch, ...): The branch parameter is "
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
214
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
215
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
216
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
217
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
218
        elif working_tree is None:
219
            raise BzrError("One of branch and working_tree must be passed into commit().")
220
        else:
221
            self.work_tree = working_tree
222
            self.branch = self.work_tree.branch
223
        if message is None:
224
            raise BzrError("The message keyword parameter is required for commit().")
225
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
226
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
227
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
228
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
229
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
230
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
231
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
232
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
233
1607.1.5 by Robert Collins
Make commit verbose mode work!.
234
        if reporter is None and self.reporter is None:
235
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
236
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
237
            self.reporter = reporter
238
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
239
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
240
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
241
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
242
            # Cannot commit with conflicts present.
243
            if len(self.work_tree.conflicts())>0:
244
                raise ConflictsInTree
245
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
246
            # setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
247
            self._check_bound_branch()
248
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
249
            # check for out of date working trees
250
            # if we are bound, then self.branch is the master branch and this
251
            # test is thus all we need.
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
252
            if self.work_tree.last_revision() != self.master_branch.last_revision():
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
253
                raise errors.OutOfDateTree(self.work_tree)
254
    
255
            if strict:
256
                # raise an exception as soon as we find a single unknown.
257
                for unknown in self.work_tree.unknowns():
258
                    raise StrictCommitFailed()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
259
                   
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
260
            if self.config is None:
261
                self.config = bzrlib.config.BranchConfig(self.branch)
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
262
      
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
263
            if isinstance(message, str):
264
                message = message.decode(bzrlib.user_encoding)
265
            assert isinstance(message, unicode), type(message)
266
            self.message = message
267
            self._escape_commit_message()
268
1189 by Martin Pool
- BROKEN: partial support for commit into weave
269
            self.work_inv = self.work_tree.inventory
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
270
            self.basis_tree = self.work_tree.basis_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
271
            self.basis_inv = self.basis_tree.inventory
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
272
            # one to finish, one for rev and inventory, and one for each
273
            # inventory entry, and the same for the new inventory.
274
            # note that this estimate is too long when we do a partial tree
275
            # commit which excludes some new files from being considered.
276
            # The estimate is corrected when we populate the new inv.
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
277
            self.pb_total = len(self.work_inv) + 5
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
278
            self.pb_count = 0
1189 by Martin Pool
- BROKEN: partial support for commit into weave
279
1223 by Martin Pool
- store inventories in weave
280
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
281
            if len(self.parents) > 1 and self.specific_files:
1704.2.11 by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges.
282
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
283
                        self.specific_files)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
284
            self._check_parents_present()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
285
            self.builder = self.branch.get_commit_builder(self.parents, 
286
                self.config, timestamp, timezone, committer, revprops, rev_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
287
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
288
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
289
            self._populate_new_inv()
1248 by Martin Pool
- new weave based cleanup [broken]
290
            self._report_deletes()
1245 by Martin Pool
doc
291
1248 by Martin Pool
- new weave based cleanup [broken]
292
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
293
                    or len(self.parents) > 1
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
294
                    or self.builder.new_inventory != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
295
                raise PointlessCommit()
296
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
297
            self._emit_progress_update()
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
298
            # TODO: Now the new inventory is known, check for conflicts and prompt the 
299
            # user for a commit message.
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
300
            self.builder.finish_inventory()
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
301
            self._emit_progress_update()
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
302
            self.rev_id = self.builder.commit(self.message)
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
303
            self._emit_progress_update()
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
304
            # revision data is in the local branch now.
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
305
            
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
306
            # upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
307
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
308
            if self.bound_branch:
309
                self.master_branch.repository.fetch(self.branch.repository,
310
                                                    revision_id=self.rev_id)
311
                # now the master has the revision data
312
                # 'commit' to the master first so a timeout here causes the local
313
                # branch to be out of date
314
                self.master_branch.append_revision(self.rev_id)
315
316
            # and now do the commit locally.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
317
            self.branch.append_revision(self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
318
1185.33.59 by Martin Pool
[patch] keep a cached basis inventory (Johan Rydberg)
319
            self.work_tree.set_pending_merges([])
1638.1.2 by Robert Collins
Change the basis-inventory file to not have the revision-id in the file name.
320
            self.work_tree.set_last_revision(self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
321
            # now the work tree is up to date with the branch
322
            
1607.1.5 by Robert Collins
Make commit verbose mode work!.
323
            self.reporter.completed(self.branch.revno(), self.rev_id)
1472 by Robert Collins
post commit hook, first pass implementation
324
            if self.config.post_commit() is not None:
325
                hooks = self.config.post_commit().split(' ')
326
                # this would be nicer with twisted.python.reflect.namedAny
327
                for hook in hooks:
328
                    result = eval(hook + '(branch, rev_id)',
329
                                  {'branch':self.branch,
330
                                   'bzrlib':bzrlib,
331
                                   'rev_id':self.rev_id})
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
332
            self._emit_progress_update()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
333
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
334
            self._cleanup()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
335
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
336
    def _check_bound_branch(self):
337
        """Check to see if the local branch is bound.
338
339
        If it is bound, then most of the commit will actually be
340
        done using the remote branch as the target branch.
341
        Only at the end will the local branch be updated.
342
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
343
        if self.local and not self.branch.get_bound_location():
344
            raise errors.LocalRequiresBoundBranch()
345
346
        if not self.local:
347
            self.master_branch = self.branch.get_master_branch()
348
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
349
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
350
            # make this branch the reference branch for out of date checks.
351
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
352
            return
353
354
        # If the master branch is bound, we must fail
355
        master_bound_location = self.master_branch.get_bound_location()
356
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
357
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
358
                    self.master_branch, master_bound_location)
359
360
        # TODO: jam 20051230 We could automatically push local
361
        #       commits to the remote branch if they would fit.
362
        #       But for now, just require remote to be identical
363
        #       to local.
364
        
365
        # Make sure the local branch is identical to the master
366
        master_rh = self.master_branch.revision_history()
367
        local_rh = self.branch.revision_history()
368
        if local_rh != master_rh:
369
            raise errors.BoundBranchOutOfDate(self.branch,
370
                    self.master_branch)
371
372
        # Now things are ready to change the master branch
373
        # so grab the lock
374
        self.bound_branch = self.branch
375
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
376
        self.master_locked = True
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
377
####        
378
####        # Check to see if we have any pending merges. If we do
379
####        # those need to be pushed into the master branch
380
####        pending_merges = self.work_tree.pending_merges()
381
####        if pending_merges:
382
####            for revision_id in pending_merges:
383
####                self.master_branch.repository.fetch(self.bound_branch.repository,
384
####                                                    revision_id=revision_id)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
385
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
386
    def _cleanup(self):
387
        """Cleanup any open locks, progress bars etc."""
388
        cleanups = [self._cleanup_bound_branch,
389
                    self.work_tree.unlock,
390
                    self.pb.finished]
391
        found_exception = None
392
        for cleanup in cleanups:
393
            try:
394
                cleanup()
395
            # we want every cleanup to run no matter what.
396
            # so we have a catchall here, but we will raise the
397
            # last encountered exception up the stack: and
398
            # typically this will be useful enough.
399
            except Exception, e:
400
                found_exception = e
401
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
402
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
403
            # trashed, e is our sure-to-work exception even though it loses the
404
            # full traceback. XXX: RBC 20060421 perhaps we could check the
405
            # exc_info and if its the same one do a plain raise otherwise 
406
            # 'raise e' as we do now.
407
            raise e
408
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
409
    def _cleanup_bound_branch(self):
410
        """Executed at the end of a try/finally to cleanup a bound branch.
411
412
        If the branch wasn't bound, this is a no-op.
413
        If it was, it resents self.branch to the local branch, instead
414
        of being the master.
415
        """
416
        if not self.bound_branch:
417
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
418
        if self.master_locked:
419
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
420
1390 by Robert Collins
pair programming worx... merge integration and weave
421
    def _escape_commit_message(self):
422
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
423
        # FIXME: RBC 20060419 this should be done by the revision
424
        # serialiser not by commit. Then we can also add an unescaper
425
        # in the deserializer and start roundtripping revision messages
426
        # precisely. See repository_implementations/test_repository.py
427
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
428
        # Python strings can include characters that can't be
429
        # represented in well-formed XML; escape characters that
430
        # aren't listed in the XML specification
431
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
432
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
433
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
434
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
435
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
436
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
437
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
438
439
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
440
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
441
        # TODO: Make sure that this list doesn't contain duplicate 
442
        # entries and the order is preserved when doing this.
1457.1.14 by Robert Collins
Move pending_merges() to WorkingTree.
443
        pending_merges = self.work_tree.pending_merges()
1223 by Martin Pool
- store inventories in weave
444
        self.parents = []
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
445
        self.parent_invs = []
1241 by Martin Pool
- rename last_patch to last_revision
446
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
447
        if precursor_id:
448
            self.parents.append(precursor_id)
449
        self.parents += pending_merges
1092.2.25 by Robert Collins
support ghosts in commits
450
        for revision in self.parents:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
451
            if self.branch.repository.has_revision(revision):
452
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
453
                self.parent_invs.append(inventory)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
454
455
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
456
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
457
            mutter('commit parent revision {%s}', parent_id)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
458
            if not self.branch.repository.has_revision(parent_id):
1092.2.25 by Robert Collins
support ghosts in commits
459
                if parent_id == self.branch.last_revision():
1185.12.9 by Aaron Bentley
Removed crude language
460
                    warning("parent is missing %r", parent_id)
1092.2.25 by Robert Collins
support ghosts in commits
461
                    raise HistoryMissing(self.branch, 'revision', parent_id)
462
                else:
463
                    mutter("commit will ghost revision %r", parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
464
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
465
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
466
        """Remove deleted files from the working inventories.
467
468
        This is done prior to taking the working inventory as the
469
        basis for the new committed inventory.
470
471
        This returns true if any files
472
        *that existed in the basis inventory* were deleted.
473
        Files that were added and deleted
474
        in the working copy don't matter.
475
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
476
        specific = self.specific_files
477
        deleted_ids = []
478
        for path, ie in self.work_inv.iter_entries():
479
            if specific and not is_inside_any(specific, path):
480
                continue
481
            if not self.work_tree.has_filename(path):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
482
                self.reporter.missing(path)
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
483
                deleted_ids.append((path, ie.file_id))
1254 by Martin Pool
- fix handling of selective commit with deleted files
484
        if deleted_ids:
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
485
            deleted_ids.sort(reverse=True)
486
            for path, file_id in deleted_ids:
1248 by Martin Pool
- new weave based cleanup [broken]
487
                del self.work_inv[file_id]
1457.1.11 by Robert Collins
Move _write_inventory to WorkingTree.
488
            self.work_tree._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
489
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
490
    def _populate_new_inv(self):
491
        """Build revision inventory.
492
493
        This creates a new empty inventory. Depending on
494
        which files are selected for commit, and what is present in the
495
        current tree, the new inventory is populated. inventory entries 
496
        which are candidates for modification have their revision set to
497
        None; inventory entries that are carried over untouched have their
498
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
499
        """
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
500
        mutter("Selecting files for commit with filter %s", self.specific_files)
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
501
        # iter_entries does not visit the ROOT_ID node so we need to call
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
502
        # self._emit_progress_update once by hand.
503
        self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
504
        for path, new_ie in self.work_inv.iter_entries():
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
505
            self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
506
            file_id = new_ie.file_id
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
507
            mutter('check %s {%s}', path, file_id)
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
508
            if (not self.specific_files or 
509
                is_inside_or_parent_of_any(self.specific_files, path)):
510
                    mutter('%s selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
511
                    ie = new_ie.copy()
512
                    ie.revision = None
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
513
            else:
514
                mutter('%s not selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
515
                if self.basis_inv.has_id(file_id):
516
                    ie = self.basis_inv[file_id].copy()
517
                else:
518
                    # this entry is new and not being committed
519
                    continue
520
521
            self.builder.record_entry_contents(ie, self.parent_invs, 
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
522
                path, self.work_tree)
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
523
            # describe the nature of the change that has occurred relative to
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
524
            # the basis inventory.
525
            if (self.basis_inv.has_id(ie.file_id)):
526
                basis_ie = self.basis_inv[ie.file_id]
527
            else:
528
                basis_ie = None
529
            change = ie.describe_change(basis_ie, ie)
530
            if change in (InventoryEntry.RENAMED, 
531
                InventoryEntry.MODIFIED_AND_RENAMED):
532
                old_path = self.basis_inv.id2path(ie.file_id)
533
                self.reporter.renamed(change, old_path, path)
534
            else:
535
                self.reporter.snapshot_change(change, path)
1416 by Robert Collins
when committing a specific file, include all its parents
536
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
537
    def _emit_progress_update(self):
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
538
        """Emit an update to the progress bar."""
539
        self.pb.update("Committing", self.pb_count, self.pb_total)
540
        self.pb_count += 1
541
1248 by Martin Pool
- new weave based cleanup [broken]
542
    def _report_deletes(self):
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
543
        for path, ie in self.basis_inv.iter_entries():
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
544
            if ie.file_id not in self.builder.new_inventory:
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
545
                self.reporter.deleted(path)
1248 by Martin Pool
- new weave based cleanup [broken]
546
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
547