~bzr-pqm/bzr/bzr.dev

184 by mbp at sourcefrog
pychecker fixups
1
# (C) 2005 Canonical
1 by mbp at sourcefrog
import from baz patch-364
2
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
1185.16.40 by Martin Pool
todo
17
# TODO: Some kind of command-line display of revision properties: 
18
# perhaps show them in log -v and allow them as options to the commit command.
1 by mbp at sourcefrog
import from baz patch-364
19
1590.1.1 by Robert Collins
Improve common_ancestor performance.
20
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
21
import bzrlib.errors
1590.1.1 by Robert Collins
Improve common_ancestor performance.
22
import bzrlib.errors as errors
1594.2.15 by Robert Collins
Unfuck performance.
23
from bzrlib.graph import node_distances, select_farthest, all_descendants, Graph
1185.16.39 by Martin Pool
- constraints on revprops
24
from bzrlib.osutils import contains_whitespace
1534.9.1 by Aaron Bentley
Added progress bars to merge
25
from bzrlib.progress import DummyProgress
1649.1.1 by Robert Collins
* 'pull' and 'push' now normalise the revision history, so that any two
26
from bzrlib.symbol_versioning import *
8 by mbp at sourcefrog
store committer's timezone in revision and show
27
974.1.90 by Aaron Bentley
Switched NULL revision ID to 'null:' per robertc's suggestion
28
NULL_REVISION="null:"
974.1.89 by Aaron Bentley
Fixed merging with multiple roots, by using null as graph root.
29
802 by Martin Pool
- Remove XMLMixin class in favour of simple pack_xml, unpack_xml functions
30
class Revision(object):
1 by mbp at sourcefrog
import from baz patch-364
31
    """Single revision on a branch.
32
33
    Revisions may know their revision_hash, but only once they've been
34
    written out.  This is not stored because you cannot write the hash
35
    into the file it describes.
36
697 by Martin Pool
- write out parent list for new revisions
37
    After bzr 0.0.5 revisions are allowed to have multiple parents.
696 by Martin Pool
- Refactor revision deserialization code
38
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
39
    parent_ids
40
        List of parent revision_ids
1185.16.39 by Martin Pool
- constraints on revprops
41
42
    properties
43
        Dictionary of revision properties.  These are attached to the
44
        revision as extra metadata.  The name must be a single 
45
        word; the value can be an arbitrary string.
1 by mbp at sourcefrog
import from baz patch-364
46
    """
696 by Martin Pool
- Refactor revision deserialization code
47
    
1185.16.35 by Martin Pool
- stub for revision properties
48
    def __init__(self, revision_id, properties=None, **args):
1092.2.25 by Robert Collins
support ghosts in commits
49
        self.revision_id = revision_id
1185.16.35 by Martin Pool
- stub for revision properties
50
        self.properties = properties or {}
1185.16.39 by Martin Pool
- constraints on revprops
51
        self._check_properties()
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
52
        self.parent_ids = []
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
53
        self.parent_sha1s = []
1733.1.4 by Robert Collins
Cosmetic niceties for debugging, extra comments etc.
54
        """Not used anymore - legacy from for 4."""
1185.42.6 by Jelmer Vernooij
Don't clear Revision.parent_ids after it has been set from the arguments
55
        self.__dict__.update(args)
696 by Martin Pool
- Refactor revision deserialization code
56
1 by mbp at sourcefrog
import from baz patch-364
57
    def __repr__(self):
184 by mbp at sourcefrog
pychecker fixups
58
        return "<Revision id %s>" % self.revision_id
1 by mbp at sourcefrog
import from baz patch-364
59
1185 by Martin Pool
- add xml round-trip test for revisions
60
    def __eq__(self, other):
61
        if not isinstance(other, Revision):
62
            return False
1092.2.20 by Robert Collins
symlink and weaves, whaddya know
63
        # FIXME: rbc 20050930 parent_ids are not being compared
64
        return (
65
                self.inventory_sha1 == other.inventory_sha1
1185 by Martin Pool
- add xml round-trip test for revisions
66
                and self.revision_id == other.revision_id
67
                and self.timestamp == other.timestamp
68
                and self.message == other.message
69
                and self.timezone == other.timezone
1185.16.35 by Martin Pool
- stub for revision properties
70
                and self.committer == other.committer
71
                and self.properties == other.properties)
1185 by Martin Pool
- add xml round-trip test for revisions
72
73
    def __ne__(self, other):
74
        return not self.__eq__(other)
75
1185.16.39 by Martin Pool
- constraints on revprops
76
    def _check_properties(self):
77
        """Verify that all revision properties are OK.
78
        """
79
        for name, value in self.properties.iteritems():
80
            if not isinstance(name, basestring) or contains_whitespace(name):
81
                raise ValueError("invalid property name %r" % name)
82
            if not isinstance(value, basestring):
83
                raise ValueError("invalid property value %r for %r" % 
84
                                 (name, value))
85
1534.4.49 by Robert Collins
Provide a revision.get_history(repository) method for generating a synthetic revision history.
86
    def get_history(self, repository):
87
        """Return the canonical line-of-history for this revision.
88
89
        If ghosts are present this may differ in result from a ghost-free
90
        repository.
91
        """
92
        current_revision = self
93
        reversed_result = []
94
        while current_revision is not None:
95
            reversed_result.append(current_revision.revision_id)
96
            if not len (current_revision.parent_ids):
97
                reversed_result.append(None)
98
                current_revision = None
99
            else:
100
                next_revision_id = current_revision.parent_ids[0]
101
                current_revision = repository.get_revision(next_revision_id)
102
        reversed_result.reverse()
103
        return reversed_result
104
1740.2.5 by Aaron Bentley
Merge from bzr.dev
105
    def get_summary(self):
106
        """Get the first line of the log message for this revision.
107
        """
108
        return self.message.split('\n', 1)[0]
109
1268 by Martin Pool
- is_ancestor now works by looking at the Branch's stored ancestry
110
111
def is_ancestor(revision_id, candidate_id, branch):
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
112
    """Return true if candidate_id is an ancestor of revision_id.
1268 by Martin Pool
- is_ancestor now works by looking at the Branch's stored ancestry
113
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
114
    A false negative will be returned if any intermediate descendent of
115
    candidate_id is not present in any of the revision_sources.
810 by Martin Pool
- New validate_revision_id function
116
    
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
117
    revisions_source is an object supporting a get_revision operation that
118
    behaves like Branch's.
119
    """
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
120
    return candidate_id in branch.repository.get_ancestry(revision_id)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
121
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
122
123
def iter_ancestors(revision_id, revision_source, only_present=False):
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
124
    ancestors = (revision_id,)
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
125
    distance = 0
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
126
    while len(ancestors) > 0:
127
        new_ancestors = []
128
        for ancestor in ancestors:
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
129
            if not only_present:
130
                yield ancestor, distance
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
131
            try:
132
                revision = revision_source.get_revision(ancestor)
133
            except bzrlib.errors.NoSuchRevision, e:
134
                if e.revision == revision_id:
135
                    raise 
136
                else:
137
                    continue
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
138
            if only_present:
139
                yield ancestor, distance
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
140
            new_ancestors.extend(revision.parent_ids)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
141
        ancestors = new_ancestors
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
142
        distance += 1
143
144
145
def find_present_ancestors(revision_id, revision_source):
1133 by Martin Pool
doc
146
    """Return the ancestors of a revision present in a branch.
147
148
    It's possible that a branch won't have the complete ancestry of
149
    one of its revisions.  
150
151
    """
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
152
    found_ancestors = {}
153
    anc_iter = enumerate(iter_ancestors(revision_id, revision_source,
154
                         only_present=True))
155
    for anc_order, (anc_id, anc_distance) in anc_iter:
156
        if not found_ancestors.has_key(anc_id):
157
            found_ancestors[anc_id] = (anc_order, anc_distance)
158
    return found_ancestors
159
    
1153 by Martin Pool
- clean up some code in revision.py
160
161
def __get_closest(intersection):
162
    intersection.sort()
163
    matches = [] 
164
    for entry in intersection:
165
        if entry[0] == intersection[0][0]:
166
            matches.append(entry[2])
167
    return matches
168
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
169
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
170
def revision_graph(revision, revision_source):
974.1.66 by Aaron Bentley
more cleanups, docs, sorting stuff
171
    """Produce a graph of the ancestry of the specified revision.
1590.1.1 by Robert Collins
Improve common_ancestor performance.
172
    
173
    :return: root, ancestors map, descendants map
974.1.66 by Aaron Bentley
more cleanups, docs, sorting stuff
174
    """
1587.1.4 by Robert Collins
Quick, urgent fix for common_ancestor performance.
175
    revision_source.lock_read()
176
    try:
177
        return _revision_graph(revision, revision_source)
178
    finally:
179
        revision_source.unlock()
180
1590.1.1 by Robert Collins
Improve common_ancestor performance.
181
1587.1.4 by Robert Collins
Quick, urgent fix for common_ancestor performance.
182
def _revision_graph(revision, revision_source):
183
    """See revision_graph."""
1590.1.1 by Robert Collins
Improve common_ancestor performance.
184
    from bzrlib.tsort import topo_sort
185
    graph = revision_source.get_revision_graph(revision)
186
    # mark all no-parent revisions as being NULL_REVISION parentage.
187
    for node, parents in graph.items():
188
        if len(parents) == 0:
189
            graph[node] = [NULL_REVISION]
190
    # add NULL_REVISION to the graph
191
    graph[NULL_REVISION] = []
192
193
    # pick a root. If there are multiple roots
194
    # this could pick a random one.
195
    topo_order = topo_sort(graph.items())
196
    root = topo_order[0]
197
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
198
    ancestors = {}
199
    descendants = {}
1590.1.1 by Robert Collins
Improve common_ancestor performance.
200
201
    # map the descendants of the graph.
202
    # and setup our set based return graph.
203
    for node in graph.keys():
204
        descendants[node] = {}
205
    for node, parents in graph.items():
206
        for parent in parents:
207
            descendants[parent][node] = 1
208
        ancestors[node] = set(parents)
209
974.1.63 by Aaron Bentley
Fixed graph-generation
210
    assert root not in descendants[root]
211
    assert root not in ancestors[root]
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
212
    return root, ancestors, descendants
213
1092.3.4 by Robert Collins
update symlink branch to integration
214
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
215
def combined_graph(revision_a, revision_b, revision_source):
974.1.66 by Aaron Bentley
more cleanups, docs, sorting stuff
216
    """Produce a combined ancestry graph.
217
    Return graph root, ancestors map, descendants map, set of common nodes"""
1590.1.1 by Robert Collins
Improve common_ancestor performance.
218
    root, ancestors, descendants = revision_graph(
219
        revision_a, revision_source)
220
    root_b, ancestors_b, descendants_b = revision_graph(
221
        revision_b, revision_source)
974.1.80 by Aaron Bentley
Improved merge error handling and testing
222
    if root != root_b:
223
        raise bzrlib.errors.NoCommonRoot(revision_a, revision_b)
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
224
    common = set()
225
    for node, node_anc in ancestors_b.iteritems():
226
        if node in ancestors:
227
            common.add(node)
228
        else:
229
            ancestors[node] = set()
230
        ancestors[node].update(node_anc)
231
    for node, node_dec in descendants_b.iteritems():
232
        if node not in descendants:
1185.8.1 by Aaron Bentley
Ensured combined_graph is order-insensitive
233
            descendants[node] = {}
974.1.63 by Aaron Bentley
Fixed graph-generation
234
        descendants[node].update(node_dec)
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
235
    return root, ancestors, descendants, common
236
1092.3.4 by Robert Collins
update symlink branch to integration
237
1534.9.1 by Aaron Bentley
Added progress bars to merge
238
def common_ancestor(revision_a, revision_b, revision_source, 
239
                    pb=DummyProgress()):
1587.1.11 by Robert Collins
Local commits appear to be working properly.
240
    if None in (revision_a, revision_b):
241
        return None
1594.2.15 by Robert Collins
Unfuck performance.
242
    # trivial optimisation
243
    if revision_a == revision_b:
244
        return revision_a
974.1.80 by Aaron Bentley
Improved merge error handling and testing
245
    try:
1534.9.1 by Aaron Bentley
Added progress bars to merge
246
        try:
247
            pb.update('Picking ancestor', 1, 3)
1594.2.15 by Robert Collins
Unfuck performance.
248
            graph = revision_source.get_revision_graph_with_ghosts(
249
                [revision_a, revision_b])
250
            # convert to a NULL_REVISION based graph.
251
            ancestors = graph.get_ancestors()
252
            descendants = graph.get_descendants()
253
            common = set(graph.get_ancestry(revision_a)).intersection(
254
                     set(graph.get_ancestry(revision_b)))
255
            descendants[NULL_REVISION] = {}
256
            ancestors[NULL_REVISION] = []
257
            for root in graph.roots:
258
                descendants[NULL_REVISION][root] = 1
259
                ancestors[root].append(NULL_REVISION)
1607.1.12 by Robert Collins
Fix common_ancestor to still calculate a common ancestor when ghosts are
260
            for ghost in graph.ghosts:
261
                # ghosts act as roots for the purpose of finding 
262
                # the longest paths from the root: any ghost *might*
263
                # be directly attached to the root, so we treat them
264
                # as being such.
265
                # ghost now descends from NULL
266
                descendants[NULL_REVISION][ghost] = 1
267
                # that is it has an ancestor of NULL
268
                ancestors[ghost] = [NULL_REVISION]
269
                # ghost is common if any of ghosts descendants are common:
270
                for ghost_descendant in descendants[ghost]:
271
                    if ghost_descendant in common:
272
                        common.add(ghost)
273
                
1594.2.15 by Robert Collins
Unfuck performance.
274
            root = NULL_REVISION
275
            common.add(NULL_REVISION)
1534.9.1 by Aaron Bentley
Added progress bars to merge
276
        except bzrlib.errors.NoCommonRoot:
277
            raise bzrlib.errors.NoCommonAncestor(revision_a, revision_b)
278
            
279
        pb.update('Picking ancestor', 2, 3)
280
        distances = node_distances (descendants, ancestors, root)
281
        pb.update('Picking ancestor', 3, 2)
282
        farthest = select_farthest(distances, common)
283
        if farthest is None or farthest == NULL_REVISION:
284
            raise bzrlib.errors.NoCommonAncestor(revision_a, revision_b)
285
    finally:
286
        pb.clear()
974.1.87 by Aaron Bentley
Refactored and documented graph stuff
287
    return farthest
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
288
289
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
290
class MultipleRevisionSources(object):
1153 by Martin Pool
- clean up some code in revision.py
291
    """Proxy that looks in multiple branches for revisions."""
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
292
    def __init__(self, *args):
293
        object.__init__(self)
294
        assert len(args) != 0
295
        self._revision_sources = args
296
1590.1.1 by Robert Collins
Improve common_ancestor performance.
297
    def revision_parents(self, revision_id):
298
        for source in self._revision_sources:
299
            try:
300
                return source.revision_parents(revision_id)
301
            except (errors.WeaveRevisionNotPresent, errors.NoSuchRevision), e:
302
                pass
303
        raise e
304
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
305
    def get_revision(self, revision_id):
306
        for source in self._revision_sources:
307
            try:
308
                return source.get_revision(revision_id)
309
            except bzrlib.errors.NoSuchRevision, e:
310
                pass
311
        raise e
974.2.7 by aaron.bentley at utoronto
Merged from bzr.24
312
1590.1.1 by Robert Collins
Improve common_ancestor performance.
313
    def get_revision_graph(self, revision_id):
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
314
        # we could probe incrementally until the pending
315
        # ghosts list stop growing, but its cheaper for now
316
        # to just ask for the complete graph for each repository.
317
        graphs = []
318
        for source in self._revision_sources:
319
            ghost_graph = source.get_revision_graph_with_ghosts()
320
            graphs.append(ghost_graph)
321
        absent = 0
322
        for graph in graphs:
323
            if not revision_id in graph.get_ancestors():
324
                absent += 1
325
        if absent == len(graphs):
326
            raise errors.NoSuchRevision(self._revision_sources[0], revision_id)
327
328
        # combine the graphs
1590.1.1 by Robert Collins
Improve common_ancestor performance.
329
        result = {}
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
330
        pending = set([revision_id])
331
        def find_parents(node_id):
332
            """find the parents for node_id."""
333
            for graph in graphs:
334
                ancestors = graph.get_ancestors()
335
                try:
336
                    return ancestors[node_id]
337
                except KeyError:
338
                    pass
339
            raise errors.NoSuchRevision(self._revision_sources[0], node_id)
340
        while len(pending):
341
            # all the graphs should have identical parent lists
342
            node_id = pending.pop()
1590.1.1 by Robert Collins
Improve common_ancestor performance.
343
            try:
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
344
                result[node_id] = find_parents(node_id)
345
                for parent_node in result[node_id]:
346
                    if not parent_node in result:
347
                        pending.add(parent_node)
348
            except errors.NoSuchRevision:
349
                # ghost, ignore it.
1590.1.1 by Robert Collins
Improve common_ancestor performance.
350
                pass
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
351
        return result
1590.1.1 by Robert Collins
Improve common_ancestor performance.
352
1594.2.15 by Robert Collins
Unfuck performance.
353
    def get_revision_graph_with_ghosts(self, revision_ids):
354
        # query all the sources for their entire graphs 
355
        # and then build a combined graph for just
356
        # revision_ids.
357
        graphs = []
358
        for source in self._revision_sources:
359
            ghost_graph = source.get_revision_graph_with_ghosts()
360
            graphs.append(ghost_graph.get_ancestors())
361
        for revision_id in revision_ids:
362
            absent = 0
363
            for graph in graphs:
364
                    if not revision_id in graph:
365
                        absent += 1
366
            if absent == len(graphs):
367
                raise errors.NoSuchRevision(self._revision_sources[0],
368
                                            revision_id)
369
370
        # combine the graphs
371
        result = Graph()
372
        pending = set(revision_ids)
373
        done = set()
374
        def find_parents(node_id):
375
            """find the parents for node_id."""
376
            for graph in graphs:
377
                try:
378
                    return graph[node_id]
379
                except KeyError:
380
                    pass
381
            raise errors.NoSuchRevision(self._revision_sources[0], node_id)
382
        while len(pending):
383
            # all the graphs should have identical parent lists
384
            node_id = pending.pop()
385
            try:
386
                parents = find_parents(node_id)
387
                for parent_node in parents:
388
                    # queued or done? 
389
                    if (parent_node not in pending and
390
                        parent_node not in done):
391
                        # no, queue
392
                        pending.add(parent_node)
393
                result.add_node(node_id, parents)
394
                done.add(node_id)
395
            except errors.NoSuchRevision:
396
                # ghost
397
                result.add_ghost(node_id)
398
                continue
399
        return result
400
1587.1.4 by Robert Collins
Quick, urgent fix for common_ancestor performance.
401
    def lock_read(self):
402
        for source in self._revision_sources:
403
            source.lock_read()
404
405
    def unlock(self):
406
        for source in self._revision_sources:
407
            source.unlock()
408
1590.1.1 by Robert Collins
Improve common_ancestor performance.
409
1685.1.65 by Martin Pool
[broken] Use deprecated_function not deprecated_method
410
@deprecated_function(zero_eight)
411
def get_intervening_revisions(ancestor_id, rev_id, rev_source,
974.2.7 by aaron.bentley at utoronto
Merged from bzr.24
412
                              revision_history=None):
413
    """Find the longest line of descent from maybe_ancestor to revision.
414
    Revision history is followed where possible.
415
416
    If ancestor_id == rev_id, list will be empty.
417
    Otherwise, rev_id will be the last entry.  ancestor_id will never appear.
418
    If ancestor_id is not an ancestor, NotAncestor will be thrown
419
    """
974.1.73 by Aaron Bentley
Reimplemented get_intervening_revisions for better scalability
420
    root, ancestors, descendants = revision_graph(rev_id, rev_source)
421
    if len(descendants) == 0:
422
        raise NoSuchRevision(rev_source, rev_id)
423
    if ancestor_id not in descendants:
424
        rev_source.get_revision(ancestor_id)
425
        raise bzrlib.errors.NotAncestor(rev_id, ancestor_id)
426
    root_descendants = all_descendants(descendants, ancestor_id)
427
    root_descendants.add(ancestor_id)
428
    if rev_id not in root_descendants:
429
        raise bzrlib.errors.NotAncestor(rev_id, ancestor_id)
430
    distances = node_distances(descendants, ancestors, ancestor_id,
431
                               root_descendants=root_descendants)
432
433
    def best_ancestor(rev_id):
434
        best = None
435
        for anc_id in ancestors[rev_id]:
436
            try:
437
                distance = distances[anc_id]
438
            except KeyError:
439
                continue
440
            if revision_history is not None and anc_id in revision_history:
441
                return anc_id
442
            elif best is None or distance > best[1]:
443
                best = (anc_id, distance)
444
        return best[0]
445
446
    next = rev_id
447
    path = []
448
    while next != ancestor_id:
449
        path.append(next)
450
        next = best_ancestor(next)
451
    path.reverse()
452
    return path