~bzr-pqm/bzr/bzr.dev

1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
2
#
1 by mbp at sourcefrog
import from baz patch-364
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
7
#
1 by mbp at sourcefrog
import from baz patch-364
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
12
#
1 by mbp at sourcefrog
import from baz patch-364
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
17
import errno
18
import os
1692.8.7 by James Henstridge
changes suggested by John Meinel
19
import subprocess
1692.8.4 by James Henstridge
move external_diff imports to top of file
20
import sys
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
21
import tempfile
1740.2.5 by Aaron Bentley
Merge from bzr.dev
22
import time
23
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
24
from bzrlib.delta import compare_trees
25
from bzrlib.errors import BzrError
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
26
import bzrlib.errors as errors
1711.2.58 by John Arbash Meinel
Use osutils.pumpfile so we don't have to buffer everything in ram
27
import bzrlib.osutils
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
28
from bzrlib.patiencediff import unified_diff
29
import bzrlib.patiencediff
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
30
from bzrlib.symbol_versioning import *
1558.15.2 by Aaron Bentley
Implemented binary file handling for diff
31
from bzrlib.textfile import check_text_lines
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
32
from bzrlib.trace import mutter, warning
1 by mbp at sourcefrog
import from baz patch-364
33
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
34
767 by Martin Pool
- files are only reported as modified if their name or parent has changed,
35
# TODO: Rather than building a changeset object, we should probably
36
# invoke callbacks on an object.  That object can either accumulate a
37
# list, write them out directly, etc etc.
38
1558.15.11 by Aaron Bentley
Apply merge review suggestions
39
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
1711.2.30 by John Arbash Meinel
Fix bug in internal_diff handling of unicode paths
40
                  allow_binary=False, sequence_matcher=None,
41
                  path_encoding='utf8'):
475 by Martin Pool
- rewrite diff using compare_trees()
42
    # FIXME: difflib is wrong if there is no trailing newline.
43
    # The syntax used by patch seems to be "\ No newline at
44
    # end of file" following the last diff line from that
45
    # file.  This is not trivial to insert into the
46
    # unified_diff output and it might be better to just fix
47
    # or replace that function.
48
49
    # In the meantime we at least make sure the patch isn't
50
    # mangled.
51
52
53
    # Special workaround for Python2.3, where difflib fails if
54
    # both sequences are empty.
55
    if not oldlines and not newlines:
56
        return
1558.15.2 by Aaron Bentley
Implemented binary file handling for diff
57
    
1558.15.11 by Aaron Bentley
Apply merge review suggestions
58
    if allow_binary is False:
59
        check_text_lines(oldlines)
60
        check_text_lines(newlines)
475 by Martin Pool
- rewrite diff using compare_trees()
61
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
62
    if sequence_matcher is None:
1711.2.24 by John Arbash Meinel
Late bind to PatienceSequenceMatcher to allow plugin to override.
63
        sequence_matcher = bzrlib.patiencediff.PatienceSequenceMatcher
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
64
    ud = unified_diff(oldlines, newlines,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
65
                      fromfile=old_filename.encode(path_encoding),
66
                      tofile=new_filename.encode(path_encoding),
1185.81.8 by John Arbash Meinel
Updating unified_diff to take a factory, using the new diff algorithm in the code.
67
                      sequencematcher=sequence_matcher)
475 by Martin Pool
- rewrite diff using compare_trees()
68
1092.1.50 by Robert Collins
make diff lsdiff/filterdiff friendly
69
    ud = list(ud)
475 by Martin Pool
- rewrite diff using compare_trees()
70
    # work-around for difflib being too smart for its own good
71
    # if /dev/null is "1,0", patch won't recognize it as /dev/null
72
    if not oldlines:
73
        ud[2] = ud[2].replace('-1,0', '-0,0')
74
    elif not newlines:
75
        ud[2] = ud[2].replace('+1,0', '+0,0')
1092.1.50 by Robert Collins
make diff lsdiff/filterdiff friendly
76
    # work around for difflib emitting random spaces after the label
77
    ud[0] = ud[0][:-2] + '\n'
78
    ud[1] = ud[1][:-2] + '\n'
475 by Martin Pool
- rewrite diff using compare_trees()
79
804 by Martin Pool
Patch from John:
80
    for line in ud:
81
        to_file.write(line)
974.1.5 by Aaron Bentley
Fixed handling of missing newlines in udiffs
82
        if not line.endswith('\n'):
83
            to_file.write("\n\\ No newline at end of file\n")
475 by Martin Pool
- rewrite diff using compare_trees()
84
    print >>to_file
85
86
1185.35.29 by Aaron Bentley
Support whitespace in diff filenames
87
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
571 by Martin Pool
- new --diff-options to pass options through to external
88
                  diff_opts):
568 by Martin Pool
- start adding support for showing diffs by calling out to
89
    """Display a diff by calling out to the external diff program."""
1711.2.57 by John Arbash Meinel
Allow external diff to write to a file without a fileno.
90
    if hasattr(to_file, 'fileno'):
91
        out_file = to_file
92
        have_fileno = True
93
    else:
94
        out_file = subprocess.PIPE
95
        have_fileno = False
568 by Martin Pool
- start adding support for showing diffs by calling out to
96
    
581 by Martin Pool
- make sure any bzr output is flushed before
97
    # make sure our own output is properly ordered before the diff
98
    to_file.flush()
99
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
100
    oldtmp_fd, old_abspath = tempfile.mkstemp(prefix='bzr-diff-old-')
101
    newtmp_fd, new_abspath = tempfile.mkstemp(prefix='bzr-diff-new-')
102
    oldtmpf = os.fdopen(oldtmp_fd, 'wb')
103
    newtmpf = os.fdopen(newtmp_fd, 'wb')
568 by Martin Pool
- start adding support for showing diffs by calling out to
104
105
    try:
106
        # TODO: perhaps a special case for comparing to or from the empty
107
        # sequence; can just use /dev/null on Unix
108
109
        # TODO: if either of the files being compared already exists as a
110
        # regular named file (e.g. in the working directory) then we can
111
        # compare directly to that, rather than copying it.
112
113
        oldtmpf.writelines(oldlines)
114
        newtmpf.writelines(newlines)
115
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
116
        oldtmpf.close()
117
        newtmpf.close()
568 by Martin Pool
- start adding support for showing diffs by calling out to
118
571 by Martin Pool
- new --diff-options to pass options through to external
119
        if not diff_opts:
120
            diff_opts = []
121
        diffcmd = ['diff',
1740.2.5 by Aaron Bentley
Merge from bzr.dev
122
                   '--label', old_filename,
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
123
                   old_abspath,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
124
                   '--label', new_filename,
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
125
                   new_abspath,
126
                   '--binary',
127
                  ]
571 by Martin Pool
- new --diff-options to pass options through to external
128
129
        # diff only allows one style to be specified; they don't override.
130
        # note that some of these take optargs, and the optargs can be
131
        # directly appended to the options.
132
        # this is only an approximate parser; it doesn't properly understand
133
        # the grammar.
134
        for s in ['-c', '-u', '-C', '-U',
135
                  '-e', '--ed',
136
                  '-q', '--brief',
137
                  '--normal',
138
                  '-n', '--rcs',
139
                  '-y', '--side-by-side',
140
                  '-D', '--ifdef']:
141
            for j in diff_opts:
142
                if j.startswith(s):
143
                    break
144
            else:
145
                continue
146
            break
147
        else:
148
            diffcmd.append('-u')
149
                  
150
        if diff_opts:
151
            diffcmd.extend(diff_opts)
152
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
153
        try:
154
            pipe = subprocess.Popen(diffcmd,
155
                                    stdin=subprocess.PIPE,
1711.2.57 by John Arbash Meinel
Allow external diff to write to a file without a fileno.
156
                                    stdout=out_file)
1711.2.56 by John Arbash Meinel
Raise NoDiff if 'diff' not present.
157
        except OSError, e:
158
            if e.errno == errno.ENOENT:
159
                raise errors.NoDiff(str(e))
160
            raise
1692.8.1 by James Henstridge
add support for redirecting external diff output to a file descriptor
161
        pipe.stdin.close()
1711.2.57 by John Arbash Meinel
Allow external diff to write to a file without a fileno.
162
163
        if not have_fileno:
1711.2.58 by John Arbash Meinel
Use osutils.pumpfile so we don't have to buffer everything in ram
164
            bzrlib.osutils.pumpfile(pipe.stdout, to_file)
1692.8.1 by James Henstridge
add support for redirecting external diff output to a file descriptor
165
        rc = pipe.wait()
571 by Martin Pool
- new --diff-options to pass options through to external
166
        
167
        if rc != 0 and rc != 1:
168
            # returns 1 if files differ; that's OK
169
            if rc < 0:
170
                msg = 'signal %d' % (-rc)
171
            else:
172
                msg = 'exit code %d' % rc
173
                
174
            raise BzrError('external diff failed with %s; command: %r' % (rc, diffcmd))
568 by Martin Pool
- start adding support for showing diffs by calling out to
175
    finally:
176
        oldtmpf.close()                 # and delete
177
        newtmpf.close()
1711.2.54 by John Arbash Meinel
Use mkstemp instead of NamedTemporary file for external diff.
178
        # Clean up. Warn in case the files couldn't be deleted
179
        # (in case windows still holds the file open, but not
180
        # if the files have already been deleted)
181
        try:
182
            os.remove(old_abspath)
183
        except OSError, e:
184
            if e.errno not in (errno.ENOENT,):
185
                warning('Failed to delete temporary file: %s %s',
186
                        old_abspath, e)
187
        try:
188
            os.remove(new_abspath)
189
        except OSError:
190
            if e.errno not in (errno.ENOENT,):
191
                warning('Failed to delete temporary file: %s %s',
192
                        new_abspath, e)
568 by Martin Pool
- start adding support for showing diffs by calling out to
193
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
194
195
@deprecated_function(zero_eight)
1432 by Robert Collins
branch: namespace
196
def show_diff(b, from_spec, specific_files, external_diff_options=None,
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
197
              revision2=None, output=None, b2=None):
619 by Martin Pool
doc
198
    """Shortcut for showing the diff to the working tree.
199
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
200
    Please use show_diff_trees instead.
201
619 by Martin Pool
doc
202
    b
203
        Branch.
204
205
    revision
1432 by Robert Collins
branch: namespace
206
        None for 'basis tree', or otherwise the old revision to compare against.
619 by Martin Pool
doc
207
    
208
    The more general form is show_diff_trees(), where the caller
209
    supplies any two trees.
210
    """
1092.1.47 by Robert Collins
make show_diff redirectable
211
    if output is None:
212
        output = sys.stdout
475 by Martin Pool
- rewrite diff using compare_trees()
213
1432 by Robert Collins
branch: namespace
214
    if from_spec is None:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
215
        old_tree = b.bzrdir.open_workingtree()
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
216
        if b2 is None:
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
217
            old_tree = old_tree = old_tree.basis_tree()
329 by Martin Pool
- refactor command functions into command classes
218
    else:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
219
        old_tree = b.repository.revision_tree(from_spec.in_history(b).rev_id)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
220
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
221
    if revision2 is None:
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
222
        if b2 is None:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
223
            new_tree = b.bzrdir.open_workingtree()
1185.35.28 by Aaron Bentley
Support diff with two branches as input.
224
        else:
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
225
            new_tree = b2.bzrdir.open_workingtree()
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
226
    else:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
227
        new_tree = b.repository.revision_tree(revision2.in_history(b).rev_id)
329 by Martin Pool
- refactor command functions into command classes
228
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
229
    return show_diff_trees(old_tree, new_tree, output, specific_files,
230
                           external_diff_options)
571 by Martin Pool
- new --diff-options to pass options through to external
231
232
1551.2.15 by Aaron Bentley
Rename cmd_show_diff to diff_cmd_helper
233
def diff_cmd_helper(tree, specific_files, external_diff_options, 
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
234
                    old_revision_spec=None, new_revision_spec=None,
235
                    old_label='a/', new_label='b/'):
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
236
    """Helper for cmd_diff.
237
238
   tree 
239
        A WorkingTree
240
241
    specific_files
242
        The specific files to compare, or None
243
244
    external_diff_options
245
        If non-None, run an external diff, and pass it these options
246
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
247
    old_revision_spec
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
248
        If None, use basis tree as old revision, otherwise use the tree for
249
        the specified revision. 
250
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
251
    new_revision_spec
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
252
        If None, use working tree as new revision, otherwise use the tree for
253
        the specified revision.
254
    
255
    The more general form is show_diff_trees(), where the caller
256
    supplies any two trees.
257
    """
258
    output = sys.stdout
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
259
    def spec_tree(spec):
260
        revision_id = spec.in_store(tree.branch).rev_id
261
        return tree.branch.repository.revision_tree(revision_id)
262
    if old_revision_spec is None:
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
263
        old_tree = tree.basis_tree()
264
    else:
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
265
        old_tree = spec_tree(old_revision_spec)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
266
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
267
    if new_revision_spec is None:
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
268
        new_tree = tree
269
    else:
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
270
        new_tree = spec_tree(new_revision_spec)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
271
1551.2.14 by Aaron Bentley
Updated argument names, DRY fixes.
272
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
273
                           external_diff_options,
274
                           old_label=old_label, new_label=new_label)
1551.2.13 by Aaron Bentley
Got diff working properly with checkouts
275
571 by Martin Pool
- new --diff-options to pass options through to external
276
277
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
278
                    external_diff_options=None,
279
                    old_label='a/', new_label='b/'):
550 by Martin Pool
- Refactor diff code into one that works purely on
280
    """Show in text form the changes from one tree to another.
281
282
    to_files
283
        If set, include only changes to these files.
571 by Martin Pool
- new --diff-options to pass options through to external
284
285
    external_diff_options
286
        If set, use an external GNU diff and pass these options.
550 by Martin Pool
- Refactor diff code into one that works purely on
287
    """
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
288
    old_tree.lock_read()
289
    try:
290
        new_tree.lock_read()
291
        try:
292
            return _show_diff_trees(old_tree, new_tree, to_file,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
293
                                    specific_files, external_diff_options,
294
                                    old_label=old_label, new_label=new_label)
1543.1.1 by Denys Duchier
lock operations for trees - use them for diff
295
        finally:
296
            new_tree.unlock()
297
    finally:
298
        old_tree.unlock()
299
300
301
def _show_diff_trees(old_tree, new_tree, to_file,
1684.1.6 by Martin Pool
(patch) --diff-prefix option (goffredo, alexander)
302
                     specific_files, external_diff_options, 
303
                     old_label='a/', new_label='b/' ):
329 by Martin Pool
- refactor command functions into command classes
304
1740.2.5 by Aaron Bentley
Merge from bzr.dev
305
    # GNU Patch uses the epoch date to detect files that are being added
306
    # or removed in a diff.
307
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
1706.1.2 by James Henstridge
Simplify logic a little
308
329 by Martin Pool
- refactor command functions into command classes
309
    # TODO: Generation of pseudo-diffs for added/deleted files could
310
    # be usefully made into a much faster special case.
311
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
312
    _raise_if_doubly_unversioned(specific_files, old_tree, new_tree)
313
571 by Martin Pool
- new --diff-options to pass options through to external
314
    if external_diff_options:
315
        assert isinstance(external_diff_options, basestring)
316
        opts = external_diff_options.split()
317
        def diff_file(olab, olines, nlab, nlines, to_file):
318
            external_diff(olab, olines, nlab, nlines, to_file, opts)
319
    else:
320
        diff_file = internal_diff
321
    
478 by Martin Pool
- put back support for running diff or status on
322
    delta = compare_trees(old_tree, new_tree, want_unchanged=False,
483 by Martin Pool
- change 'file_list' to more explanatory 'specific_files'
323
                          specific_files=specific_files)
475 by Martin Pool
- rewrite diff using compare_trees()
324
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
325
    has_changes = 0
475 by Martin Pool
- rewrite diff using compare_trees()
326
    for path, file_id, kind in delta.removed:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
327
        has_changes = 1
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
328
        print >>to_file, '=== removed %s %r' % (kind, path.encode('utf8'))
1740.2.5 by Aaron Bentley
Merge from bzr.dev
329
        old_name = '%s%s\t%s' % (old_label, path,
330
                                 _patch_header_date(old_tree, file_id, path))
331
        new_name = '%s%s\t%s' % (new_label, path, EPOCH_DATE)
332
        old_tree.inventory[file_id].diff(diff_file, old_name, old_tree,
333
                                         new_name, None, None, to_file)
475 by Martin Pool
- rewrite diff using compare_trees()
334
    for path, file_id, kind in delta.added:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
335
        has_changes = 1
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
336
        print >>to_file, '=== added %s %r' % (kind, path.encode('utf8'))
1740.2.5 by Aaron Bentley
Merge from bzr.dev
337
        old_name = '%s%s\t%s' % (old_label, path, EPOCH_DATE)
338
        new_name = '%s%s\t%s' % (new_label, path,
339
                                 _patch_header_date(new_tree, file_id, path))
340
        new_tree.inventory[file_id].diff(diff_file, new_name, new_tree,
341
                                         old_name, None, None, to_file, 
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
342
                                         reverse=True)
1398 by Robert Collins
integrate in Gustavos x-bit patch
343
    for (old_path, new_path, file_id, kind,
344
         text_modified, meta_modified) in delta.renamed:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
345
        has_changes = 1
1398 by Robert Collins
integrate in Gustavos x-bit patch
346
        prop_str = get_prop_change(meta_modified)
347
        print >>to_file, '=== renamed %s %r => %r%s' % (
1711.2.28 by John Arbash Meinel
Fix up bzrlib.diff now that compare_trees is returning unicode paths.
348
                    kind, old_path.encode('utf8'),
349
                    new_path.encode('utf8'), prop_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
350
        old_name = '%s%s\t%s' % (old_label, old_path,
351
                                 _patch_header_date(old_tree, file_id,
352
                                                    old_path))
353
        new_name = '%s%s\t%s' % (new_label, new_path,
354
                                 _patch_header_date(new_tree, file_id,
355
                                                    new_path))
356
        _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
357
                                    new_name, new_tree,
1092.2.9 by Robert Collins
bugfix _maybe_diff, the test was not catching the error
358
                                    text_modified, kind, to_file, diff_file)
1398 by Robert Collins
integrate in Gustavos x-bit patch
359
    for path, file_id, kind, text_modified, meta_modified in delta.modified:
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
360
        has_changes = 1
1398 by Robert Collins
integrate in Gustavos x-bit patch
361
        prop_str = get_prop_change(meta_modified)
1732.1.7 by John Arbash Meinel
Instead of iterating randomly in both trees, _compare_trees now iterates in order on both trees simultaneously.
362
        print >>to_file, '=== modified %s %r%s' % (kind, path.encode('utf8'), prop_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
363
        old_name = '%s%s\t%s' % (old_label, path,
364
                                 _patch_header_date(old_tree, file_id, path))
365
        new_name = '%s%s\t%s' % (new_label, path,
366
                                 _patch_header_date(new_tree, file_id, path))
1398 by Robert Collins
integrate in Gustavos x-bit patch
367
        if text_modified:
1740.2.5 by Aaron Bentley
Merge from bzr.dev
368
            _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
369
                                        new_name, new_tree,
1398 by Robert Collins
integrate in Gustavos x-bit patch
370
                                        True, kind, to_file, diff_file)
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
371
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
372
    return has_changes
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
373
374
1740.2.5 by Aaron Bentley
Merge from bzr.dev
375
def _patch_header_date(tree, file_id, path):
376
    """Returns a timestamp suitable for use in a patch header."""
377
    tm = time.gmtime(tree.get_file_mtime(file_id, path))
378
    return time.strftime('%Y-%m-%d %H:%M:%S +0000', tm)
379
380
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
381
def _raise_if_doubly_unversioned(specific_files, old_tree, new_tree):
382
    """Complain if paths are not versioned in either tree."""
1662.1.12 by Martin Pool
Translate unknown sftp errors to PathError, no NoSuchFile
383
    if not specific_files:
1658.1.10 by Martin Pool
diff on unversiond files should give an error (Malone #3619)
384
        return
1658.1.9 by Martin Pool
Give an error for bzr diff on an nonexistent file (Malone #3619)
385
    old_unversioned = old_tree.filter_unversioned_files(specific_files)
386
    new_unversioned = new_tree.filter_unversioned_files(specific_files)
387
    unversioned = old_unversioned.intersection(new_unversioned)
388
    if unversioned:
389
        raise errors.PathsNotVersionedError(sorted(unversioned))
1092.3.4 by Robert Collins
update symlink branch to integration
390
    
1092.2.6 by Robert Collins
symlink support updated to work
391
1662.1.9 by Martin Pool
Give a clear error for bzr status of an unversioned, nonexistent file. (Malone #3619)
392
def _raise_if_nonexistent(paths, old_tree, new_tree):
393
    """Complain if paths are not in either inventory or tree.
394
395
    It's OK with the files exist in either tree's inventory, or 
396
    if they exist in the tree but are not versioned.
397
    
398
    This can be used by operations such as bzr status that can accept
399
    unknown or ignored files.
400
    """
401
    mutter("check paths: %r", paths)
402
    if not paths:
403
        return
404
    s = old_tree.filter_unversioned_files(paths)
405
    s = new_tree.filter_unversioned_files(s)
406
    s = [path for path in s if not new_tree.has_filename(path)]
407
    if s:
408
        raise errors.PathsDoNotExist(sorted(s))
409
410
1398 by Robert Collins
integrate in Gustavos x-bit patch
411
def get_prop_change(meta_modified):
412
    if meta_modified:
413
        return " (properties changed)"
414
    else:
415
        return  ""
416
417
1740.2.5 by Aaron Bentley
Merge from bzr.dev
418
def _maybe_diff_file_or_symlink(old_path, old_tree, file_id,
419
                                new_path, new_tree, text_modified,
1092.2.9 by Robert Collins
bugfix _maybe_diff, the test was not catching the error
420
                                kind, to_file, diff_file):
1092.2.6 by Robert Collins
symlink support updated to work
421
    if text_modified:
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
422
        new_entry = new_tree.inventory[file_id]
423
        old_tree.inventory[file_id].diff(diff_file,
1740.2.5 by Aaron Bentley
Merge from bzr.dev
424
                                         old_path, old_tree,
425
                                         new_path, new_entry, 
1399.1.4 by Robert Collins
move diff and symlink conditionals into inventory.py from diff.py
426
                                         new_tree, to_file)