1553.5.12
by Martin Pool
New LockDir locking mechanism |
1 |
# Copyright (C) 2006 Canonical Ltd
|
2 |
||
3 |
# This program is free software; you can redistribute it and/or modify
|
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
7 |
||
8 |
# This program is distributed in the hope that it will be useful,
|
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
12 |
||
13 |
# You should have received a copy of the GNU General Public License
|
|
14 |
# along with this program; if not, write to the Free Software
|
|
15 |
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
16 |
||
1553.5.31
by Martin Pool
LockDir doc corrections |
17 |
"""On-disk mutex protecting a resource
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
18 |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
19 |
bzr on-disk objects are locked by the existence of a directory with a
|
20 |
particular name within the control directory. We use this rather than OS
|
|
21 |
internal locks (such as flock etc) because they can be seen across all
|
|
22 |
transports, including http.
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
23 |
|
24 |
Objects can be read if there is only physical read access; therefore
|
|
25 |
readers can never be required to create a lock, though they will
|
|
26 |
check whether a writer is using the lock. Writers can't detect
|
|
27 |
whether anyone else is reading from the resource as they write.
|
|
28 |
This works because of ordering constraints that make sure readers
|
|
29 |
see a consistent view of existing data.
|
|
30 |
||
31 |
Waiting for a lock must be done by polling; this can be aborted after
|
|
32 |
a timeout.
|
|
33 |
||
34 |
Locks must always be explicitly released, typically from a try/finally
|
|
35 |
block -- they are not released from a finalizer or when Python
|
|
36 |
exits.
|
|
37 |
||
38 |
Locks may fail to be released if the process is abruptly terminated
|
|
39 |
(machine stop, SIGKILL) or if a remote transport becomes permanently
|
|
40 |
disconnected. There is therefore a method to break an existing lock.
|
|
41 |
This should rarely be used, and generally only with user approval.
|
|
42 |
Locks contain some information on when the lock was taken and by who
|
|
43 |
which may guide in deciding whether it can safely be broken. (This is
|
|
44 |
similar to the messages displayed by emacs and vim.) Note that if the
|
|
45 |
lock holder is still alive they will get no notification that the lock
|
|
46 |
has been broken and will continue their work -- so it is important to be
|
|
47 |
sure they are actually dead.
|
|
48 |
||
49 |
A lock is represented on disk by a directory of a particular name,
|
|
50 |
containing an information file. Taking a lock is done by renaming a
|
|
51 |
temporary directory into place. We use temporary directories because
|
|
52 |
for all known transports and filesystems we believe that exactly one
|
|
53 |
attempt to claim the lock will succeed and the others will fail. (Files
|
|
54 |
won't do because some filesystems or transports only have
|
|
55 |
rename-and-overwrite, making it hard to tell who won.)
|
|
56 |
||
57 |
The desired characteristics are:
|
|
58 |
||
59 |
* Locks are not reentrant. (That is, a client that tries to take a
|
|
60 |
lock it already holds may deadlock or fail.)
|
|
61 |
* Stale locks can be guessed at by a heuristic
|
|
62 |
* Lost locks can be broken by any client
|
|
63 |
* Failed lock operations leave little or no mess
|
|
64 |
* Deadlocks are avoided by having a timeout always in use, clients
|
|
65 |
desiring indefinite waits can retry or set a silly big timeout.
|
|
66 |
||
67 |
Storage formats use the locks, and also need to consider concurrency
|
|
68 |
issues underneath the lock. A format may choose not to use a lock
|
|
69 |
at all for some operations.
|
|
70 |
||
71 |
LockDirs always operate over a Transport. The transport may be readonly, in
|
|
72 |
which case the lock can be queried but not acquired.
|
|
73 |
||
74 |
Locks are identified by a path name, relative to a base transport.
|
|
75 |
||
76 |
Calling code will typically want to make sure there is exactly one LockDir
|
|
77 |
object per actual lock on disk. This module does nothing to prevent aliasing
|
|
78 |
and deadlocks will likely occur if the locks are aliased.
|
|
79 |
||
80 |
In the future we may add a "freshen" method which can be called
|
|
81 |
by a lock holder to check that their lock has not been broken, and to
|
|
82 |
update the timestamp within it.
|
|
83 |
||
1553.5.18
by Martin Pool
LockDir should use Transport.rename when releasing locks too. |
84 |
Example usage:
|
85 |
||
86 |
>>> from bzrlib.transport.memory import MemoryTransport
|
|
87 |
>>> # typically will be obtained from a BzrDir, Branch, etc
|
|
88 |
>>> t = MemoryTransport()
|
|
89 |
>>> l = LockDir(t, 'sample-lock')
|
|
1553.5.61
by Martin Pool
Locks protecting LockableFiles must now be explicitly created before use. |
90 |
>>> l.create()
|
1553.5.18
by Martin Pool
LockDir should use Transport.rename when releasing locks too. |
91 |
>>> l.wait_lock()
|
92 |
>>> # do something here
|
|
93 |
>>> l.unlock()
|
|
94 |
||
1553.5.12
by Martin Pool
New LockDir locking mechanism |
95 |
"""
|
96 |
||
97 |
import os |
|
98 |
import time |
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
99 |
from warnings import warn |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
100 |
from StringIO import StringIO |
101 |
||
102 |
import bzrlib.config |
|
103 |
from bzrlib.errors import ( |
|
104 |
DirectoryNotEmpty, |
|
105 |
FileExists, |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
106 |
LockBreakMismatch, |
1553.5.23
by Martin Pool
Start LockDir.confirm method and LockBroken exception |
107 |
LockBroken, |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
108 |
LockContention, |
109 |
LockError, |
|
110 |
LockNotHeld, |
|
111 |
NoSuchFile, |
|
1558.10.1
by Aaron Bentley
Handle lockdirs over NFS properly |
112 |
ResourceBusy, |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
113 |
UnlockableTransport, |
114 |
)
|
|
115 |
from bzrlib.transport import Transport |
|
116 |
from bzrlib.osutils import rand_chars |
|
117 |
from bzrlib.rio import RioWriter, read_stanza, Stanza |
|
118 |
||
119 |
# XXX: At the moment there is no consideration of thread safety on LockDir
|
|
120 |
# objects. This should perhaps be updated - e.g. if two threads try to take a
|
|
121 |
# lock at the same time they should *both* get it. But then that's unlikely
|
|
122 |
# to be a good idea.
|
|
123 |
||
124 |
# TODO: Transport could offer a simpler put() method that avoids the
|
|
125 |
# rename-into-place for cases like creating the lock template, where there is
|
|
126 |
# no chance that the file already exists.
|
|
127 |
||
128 |
# TODO: Perhaps store some kind of note like the bzr command line in the lock
|
|
129 |
# info?
|
|
130 |
||
131 |
# TODO: Some kind of callback run while polling a lock to show progress
|
|
132 |
# indicators.
|
|
133 |
||
1553.5.59
by Martin Pool
Pass file/mode bits through to creation of lock files/dirs |
134 |
# TODO: Make sure to pass the right file and directory mode bits to all
|
135 |
# files/dirs created.
|
|
136 |
||
1553.5.21
by Martin Pool
Put default LockDir timeouts in variables; increase timeout to 3min |
137 |
_DEFAULT_TIMEOUT_SECONDS = 300 |
138 |
_DEFAULT_POLL_SECONDS = 0.5 |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
139 |
|
140 |
class LockDir(object): |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
141 |
"""Write-lock guarding access to data."""
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
142 |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
143 |
__INFO_NAME = '/info' |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
144 |
|
1553.5.59
by Martin Pool
Pass file/mode bits through to creation of lock files/dirs |
145 |
def __init__(self, transport, path, file_modebits=0644, dir_modebits=0755): |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
146 |
"""Create a new LockDir object.
|
147 |
||
148 |
The LockDir is initially unlocked - this just creates the object.
|
|
149 |
||
150 |
:param transport: Transport which will contain the lock
|
|
151 |
||
152 |
:param path: Path to the lock within the base directory of the
|
|
153 |
transport.
|
|
154 |
"""
|
|
155 |
assert isinstance(transport, Transport), \ |
|
156 |
("not a transport: %r" % transport) |
|
157 |
self.transport = transport |
|
158 |
self.path = path |
|
159 |
self._lock_held = False |
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
160 |
self._fake_read_lock = False |
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
161 |
self._held_dir = path + '/held' |
162 |
self._held_info_path = self._held_dir + self.__INFO_NAME |
|
1553.5.59
by Martin Pool
Pass file/mode bits through to creation of lock files/dirs |
163 |
self._file_modebits = file_modebits |
164 |
self._dir_modebits = dir_modebits |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
165 |
self.nonce = rand_chars(20) |
166 |
||
167 |
def __repr__(self): |
|
168 |
return '%s(%s%s)' % (self.__class__.__name__, |
|
169 |
self.transport.base, |
|
170 |
self.path) |
|
171 |
||
1553.5.13
by Martin Pool
New Transport.rename that mustn't overwrite |
172 |
is_held = property(lambda self: self._lock_held) |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
173 |
|
1666.1.4
by Robert Collins
* 'Metadir' is now the default disk format. This improves behaviour in |
174 |
def create(self, mode=None): |
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
175 |
"""Create the on-disk lock.
|
176 |
||
177 |
This is typically only called when the object/directory containing the
|
|
178 |
directory is first created. The lock is not held when it's created.
|
|
179 |
"""
|
|
180 |
if self.transport.is_readonly(): |
|
181 |
raise UnlockableTransport(self.transport) |
|
1666.1.4
by Robert Collins
* 'Metadir' is now the default disk format. This improves behaviour in |
182 |
self.transport.mkdir(self.path, mode=mode) |
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
183 |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
184 |
def attempt_lock(self): |
1553.5.33
by Martin Pool
LockDir review comment fixes |
185 |
"""Take the lock; fail if it's already held.
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
186 |
|
187 |
If you wish to block until the lock can be obtained, call wait_lock()
|
|
188 |
instead.
|
|
189 |
"""
|
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
190 |
if self._fake_read_lock: |
191 |
raise LockContention(self) |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
192 |
if self.transport.is_readonly(): |
193 |
raise UnlockableTransport(self.transport) |
|
194 |
try: |
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
195 |
tmpname = '%s/pending.%s.tmp' % (self.path, rand_chars(20)) |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
196 |
self.transport.mkdir(tmpname) |
197 |
sio = StringIO() |
|
198 |
self._prepare_info(sio) |
|
199 |
sio.seek(0) |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
200 |
self.transport.put(tmpname + self.__INFO_NAME, sio) |
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
201 |
self.transport.rename(tmpname, self._held_dir) |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
202 |
self._lock_held = True |
1553.5.33
by Martin Pool
LockDir review comment fixes |
203 |
self.confirm() |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
204 |
return
|
1558.10.1
by Aaron Bentley
Handle lockdirs over NFS properly |
205 |
except (DirectoryNotEmpty, FileExists, ResourceBusy), e: |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
206 |
pass
|
207 |
# fall through to here on contention
|
|
208 |
raise LockContention(self) |
|
209 |
||
210 |
def unlock(self): |
|
1553.5.30
by Martin Pool
docstring for LockDir.unlock |
211 |
"""Release a held lock
|
212 |
"""
|
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
213 |
if self._fake_read_lock: |
214 |
self._fake_read_lock = False |
|
215 |
return
|
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
216 |
if not self._lock_held: |
217 |
raise LockNotHeld(self) |
|
218 |
# rename before deleting, because we can't atomically remove the whole
|
|
219 |
# tree
|
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
220 |
tmpname = '%s/releasing.%s.tmp' % (self.path, rand_chars(20)) |
221 |
self.transport.rename(self._held_dir, tmpname) |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
222 |
self._lock_held = False |
1553.5.33
by Martin Pool
LockDir review comment fixes |
223 |
self.transport.delete(tmpname + self.__INFO_NAME) |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
224 |
self.transport.rmdir(tmpname) |
225 |
||
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
226 |
def force_break(self, dead_holder_info): |
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
227 |
"""Release a lock held by another process.
|
228 |
||
229 |
WARNING: This should only be used when the other process is dead; if
|
|
230 |
it still thinks it has the lock there will be two concurrent writers.
|
|
231 |
In general the user's approval should be sought for lock breaks.
|
|
232 |
||
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
233 |
dead_holder_info must be the result of a previous LockDir.peek() call;
|
234 |
this is used to check that it's still held by the same process that
|
|
235 |
the user decided was dead. If this is not the current holder,
|
|
236 |
LockBreakMismatch is raised.
|
|
237 |
||
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
238 |
After the lock is broken it will not be held by any process.
|
239 |
It is possible that another process may sneak in and take the
|
|
240 |
lock before the breaking process acquires it.
|
|
241 |
"""
|
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
242 |
if not isinstance(dead_holder_info, dict): |
243 |
raise ValueError("dead_holder_info: %r" % dead_holder_info) |
|
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
244 |
if self._lock_held: |
245 |
raise AssertionError("can't break own lock: %r" % self) |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
246 |
current_info = self.peek() |
247 |
if current_info is None: |
|
1553.5.26
by Martin Pool
Breaking an already-released lock should just succeed |
248 |
# must have been recently released
|
249 |
return
|
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
250 |
if current_info != dead_holder_info: |
251 |
raise LockBreakMismatch(self, current_info, dead_holder_info) |
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
252 |
tmpname = '%s/broken.%s.tmp' % (self.path, rand_chars(20)) |
253 |
self.transport.rename(self._held_dir, tmpname) |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
254 |
# check that we actually broke the right lock, not someone else;
|
255 |
# there's a small race window between checking it and doing the
|
|
256 |
# rename.
|
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
257 |
broken_info_path = tmpname + self.__INFO_NAME |
258 |
broken_info = self._read_info_file(broken_info_path) |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
259 |
if broken_info != dead_holder_info: |
260 |
raise LockBreakMismatch(self, broken_info, dead_holder_info) |
|
261 |
self.transport.delete(broken_info_path) |
|
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
262 |
self.transport.rmdir(tmpname) |
263 |
||
1553.5.20
by Martin Pool
Start adding LockDir.confirm() method |
264 |
def confirm(self): |
265 |
"""Make sure that the lock is still held by this locker.
|
|
266 |
||
267 |
This should only fail if the lock was broken by user intervention,
|
|
268 |
or if the lock has been affected by a bug.
|
|
269 |
||
270 |
If the lock is not thought to be held, raises LockNotHeld. If
|
|
271 |
the lock is thought to be held but has been broken, raises
|
|
272 |
LockBroken.
|
|
273 |
"""
|
|
274 |
if not self._lock_held: |
|
275 |
raise LockNotHeld(self) |
|
1553.5.23
by Martin Pool
Start LockDir.confirm method and LockBroken exception |
276 |
info = self.peek() |
277 |
if info is None: |
|
278 |
# no lock there anymore!
|
|
279 |
raise LockBroken(self) |
|
280 |
if info.get('nonce') != self.nonce: |
|
281 |
# there is a lock, but not ours
|
|
282 |
raise LockBroken(self) |
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
283 |
|
284 |
def _read_info_file(self, path): |
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
285 |
"""Read one given info file.
|
286 |
||
287 |
peek() reads the info file of the lock holder, if any.
|
|
288 |
"""
|
|
1553.5.33
by Martin Pool
LockDir review comment fixes |
289 |
return self._parse_info(self.transport.get(path)) |
1553.5.20
by Martin Pool
Start adding LockDir.confirm() method |
290 |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
291 |
def peek(self): |
292 |
"""Check if the lock is held by anyone.
|
|
293 |
|
|
294 |
If it is held, this returns the lock info structure as a rio Stanza,
|
|
295 |
which contains some information about the current lock holder.
|
|
296 |
Otherwise returns None.
|
|
297 |
"""
|
|
298 |
try: |
|
1553.5.58
by Martin Pool
Change LockDirs to format "lock-name/held/info" |
299 |
info = self._read_info_file(self._held_info_path) |
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
300 |
assert isinstance(info, dict), \ |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
301 |
"bad parse result %r" % info |
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
302 |
return info |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
303 |
except NoSuchFile, e: |
304 |
return None |
|
305 |
||
306 |
def _prepare_info(self, outf): |
|
307 |
"""Write information about a pending lock to a temporary file.
|
|
308 |
"""
|
|
309 |
import socket |
|
310 |
# XXX: is creating this here inefficient?
|
|
311 |
config = bzrlib.config.GlobalConfig() |
|
312 |
s = Stanza(hostname=socket.gethostname(), |
|
313 |
pid=str(os.getpid()), |
|
314 |
start_time=str(int(time.time())), |
|
315 |
nonce=self.nonce, |
|
316 |
user=config.user_email(), |
|
317 |
)
|
|
318 |
RioWriter(outf).write_stanza(s) |
|
319 |
||
320 |
def _parse_info(self, info_file): |
|
1553.5.27
by Martin Pool
Confirm that only the intended holder of a lock was broken. |
321 |
return read_stanza(info_file.readlines()).as_dict() |
1553.5.12
by Martin Pool
New LockDir locking mechanism |
322 |
|
1553.5.21
by Martin Pool
Put default LockDir timeouts in variables; increase timeout to 3min |
323 |
def wait_lock(self, timeout=_DEFAULT_TIMEOUT_SECONDS, |
324 |
poll=_DEFAULT_POLL_SECONDS): |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
325 |
"""Wait a certain period for a lock.
|
326 |
||
327 |
If the lock can be acquired within the bounded time, it
|
|
328 |
is taken and this returns. Otherwise, LockContention
|
|
329 |
is raised. Either way, this function should return within
|
|
330 |
approximately `timeout` seconds. (It may be a bit more if
|
|
331 |
a transport operation takes a long time to complete.)
|
|
332 |
"""
|
|
333 |
# XXX: the transport interface doesn't let us guard
|
|
334 |
# against operations there taking a long time.
|
|
335 |
deadline = time.time() + timeout |
|
336 |
while True: |
|
337 |
try: |
|
338 |
self.attempt_lock() |
|
339 |
return
|
|
340 |
except LockContention: |
|
341 |
pass
|
|
342 |
if time.time() + poll < deadline: |
|
343 |
time.sleep(poll) |
|
344 |
else: |
|
345 |
raise LockContention(self) |
|
346 |
||
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
347 |
def lock_write(self): |
348 |
"""Wait for and acquire the lock."""
|
|
349 |
self.attempt_lock() |
|
350 |
||
351 |
def lock_read(self): |
|
352 |
"""Compatability-mode shared lock.
|
|
353 |
||
354 |
LockDir doesn't support shared read-only locks, so this
|
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
355 |
just pretends that the lock is taken but really does nothing.
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
356 |
"""
|
357 |
# At the moment Branches are commonly locked for read, but
|
|
358 |
# we can't rely on that remotely. Once this is cleaned up,
|
|
359 |
# reenable this warning to prevent it coming back in
|
|
360 |
# -- mbp 20060303
|
|
361 |
## warn("LockDir.lock_read falls back to write lock")
|
|
1553.5.54
by Martin Pool
Add LockDir.read_lock fake method |
362 |
if self._lock_held or self._fake_read_lock: |
363 |
raise LockContention(self) |
|
364 |
self._fake_read_lock = True |
|
1553.5.44
by Martin Pool
LockableFiles can now call LockDir directly |
365 |
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
366 |
def wait(self, timeout=20, poll=0.5): |
1553.5.33
by Martin Pool
LockDir review comment fixes |
367 |
"""Wait a certain period for a lock to be released."""
|
1553.5.12
by Martin Pool
New LockDir locking mechanism |
368 |
# XXX: the transport interface doesn't let us guard
|
369 |
# against operations there taking a long time.
|
|
370 |
deadline = time.time() + timeout |
|
371 |
while True: |
|
372 |
if self.peek(): |
|
373 |
return
|
|
374 |
if time.time() + poll < deadline: |
|
375 |
time.sleep(poll) |
|
376 |
else: |
|
377 |
raise LockContention(self) |
|
1553.5.25
by Martin Pool
New LockDir.force_break and simple test case |
378 |