~bzr-pqm/bzr/bzr.dev

485 by Martin Pool
- move commit code into its own module
1
# Copyright (C) 2005 Canonical Ltd
1248 by Martin Pool
- new weave based cleanup [broken]
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1339 by Martin Pool
- doc
47
# TODO: Rather than mashing together the ancestry and storing it back,
48
# perhaps the weave should have single method which does it all in one
49
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
50
1341 by Martin Pool
- doc
51
# TODO: Perhaps give a warning if one of the revisions marked as
52
# merged is already in the ancestry, and then don't record it as a
53
# distinct parent.
54
1343 by Martin Pool
- fix up test for merge of trees
55
# TODO: If the file is newly merged but unchanged from the version it
56
# merges from, then it should still be reported as newly added
57
# relative to the basis revision.
58
1185.16.66 by mbp at sourcefrog
- todo
59
# TODO: Do checks that the tree can be committed *before* running the 
60
# editor; this should include checks for a pointless commit and for 
61
# unknown or missing files.
62
63
# TODO: If commit fails, leave the message in a file somewhere.
64
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
65
1189 by Martin Pool
- BROKEN: partial support for commit into weave
66
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
67
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
68
import sys
1188 by Martin Pool
- clean up imports in commit code
69
import time
1248 by Martin Pool
- new weave based cleanup [broken]
70
import pdb
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
71
1188 by Martin Pool
- clean up imports in commit code
72
from binascii import hexlify
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
73
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
74
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
75
from bzrlib.atomicfile import AtomicFile
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
76
from bzrlib.osutils import (local_time_offset,
77
                            rand_bytes, compact_date,
1188 by Martin Pool
- clean up imports in commit code
78
                            kind_marker, is_inside_any, quotefn,
1248 by Martin Pool
- new weave based cleanup [broken]
79
                            sha_string, sha_strings, sha_file, isdir, isfile,
80
                            split_lines)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
81
import bzrlib.config
1508.1.22 by Robert Collins
implement out of date working tree checks in commit.
82
import bzrlib.errors as errors
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
83
from bzrlib.errors import (BzrError, PointlessCommit,
84
                           HistoryMissing,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
85
                           ConflictsInTree,
86
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
87
                           )
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
88
import bzrlib.gpg as gpg
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
89
from bzrlib.revision import Revision
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
90
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
91
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
92
from bzrlib.xml5 import serializer_v5
1416 by Robert Collins
when committing a specific file, include all its parents
93
from bzrlib.inventory import Inventory, ROOT_ID
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
94
from bzrlib.symbol_versioning import *
1189 by Martin Pool
- BROKEN: partial support for commit into weave
95
from bzrlib.weave import Weave
96
from bzrlib.weavefile import read_weave, write_weave_v5
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
97
from bzrlib.workingtree import WorkingTree
1189 by Martin Pool
- BROKEN: partial support for commit into weave
98
99
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
100
@deprecated_function(zero_seven)
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
101
def commit(*args, **kwargs):
102
    """Commit a new revision to a branch.
103
104
    Function-style interface for convenience of old callers.
105
106
    New code should use the Commit class instead.
107
    """
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
108
    ## XXX: Remove this in favor of Branch.commit?
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
109
    Commit().commit(*args, **kwargs)
110
111
1189 by Martin Pool
- BROKEN: partial support for commit into weave
112
class NullCommitReporter(object):
113
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
114
115
    def snapshot_change(self, change, path):
116
        pass
117
118
    def completed(self, revno, rev_id):
119
        pass
120
121
    def deleted(self, file_id):
122
        pass
123
124
    def escaped(self, escape_count, message):
125
        pass
126
127
    def missing(self, path):
128
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
129
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
130
1189 by Martin Pool
- BROKEN: partial support for commit into weave
131
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
132
133
    def snapshot_change(self, change, path):
134
        note("%s %s", change, path)
135
136
    def completed(self, revno, rev_id):
137
        note('committed r%d {%s}', revno, rev_id)
138
    
139
    def deleted(self, file_id):
140
        note('deleted %s', file_id)
141
142
    def escaped(self, escape_count, message):
143
        note("replaced %d control characters in message", escape_count)
144
145
    def missing(self, path):
146
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
148
1189 by Martin Pool
- BROKEN: partial support for commit into weave
149
class Commit(object):
150
    """Task of committing a new revision.
151
152
    This is a MethodObject: it accumulates state as the commit is
153
    prepared, and then it is discarded.  It doesn't represent
154
    historical revisions, just the act of recording a new one.
155
156
            missing_ids
157
            Modified to hold a list of files that have been deleted from
158
            the working directory; these should be removed from the
159
            working inventory.
485 by Martin Pool
- move commit code into its own module
160
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
161
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
162
                 reporter=None,
163
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
164
        if reporter is not None:
165
            self.reporter = reporter
166
        else:
167
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
168
        if config is not None:
169
            self.config = config
170
        else:
171
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
172
        
173
    def commit(self,
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
174
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
175
               timestamp=None,
176
               timezone=None,
177
               committer=None,
178
               specific_files=None,
179
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
180
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
181
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
182
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
183
               revprops=None,
184
               working_tree=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
185
        """Commit working copy as a new revision.
186
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
187
        branch -- the deprecated branch to commit to. New callers should pass in 
188
                  working_tree instead
189
190
        message -- the commit message, a mandatory parameter
191
1189 by Martin Pool
- BROKEN: partial support for commit into weave
192
        timestamp -- if not None, seconds-since-epoch for a
193
             postdated/predated commit.
194
1253 by Martin Pool
- test that pointless commits are trapped
195
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
196
1253 by Martin Pool
- test that pointless commits are trapped
197
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
198
            Useful for test or import commands that need to tightly
199
            control what revisions are assigned.  If you duplicate
200
            a revision id that exists elsewhere it is your own fault.
201
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
202
203
        allow_pointless -- If true (default), commit even if nothing
204
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
205
1185.16.65 by mbp at sourcefrog
- new commit --strict option
206
        strict -- If true, don't allow a commit if the working tree
207
            contains unknown files.
208
1185.16.35 by Martin Pool
- stub for revision properties
209
        revprops -- Properties for new revision
1189 by Martin Pool
- BROKEN: partial support for commit into weave
210
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
211
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
212
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
213
        if deprecated_passed(branch):
214
            warn("Commit.commit (branch, ...): The branch parameter is "
215
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
216
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
217
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
218
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
219
        elif working_tree is None:
220
            raise BzrError("One of branch and working_tree must be passed into commit().")
221
        else:
222
            self.work_tree = working_tree
223
            self.branch = self.work_tree.branch
224
        if message is None:
225
            raise BzrError("The message keyword parameter is required for commit().")
226
1534.4.28 by Robert Collins
first cut at merge from integration.
227
        self.weave_store = self.branch.repository.weave_store
1189 by Martin Pool
- BROKEN: partial support for commit into weave
228
        self.rev_id = rev_id
229
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
230
        self.allow_pointless = allow_pointless
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
231
        self.revprops = {'branch-nick': self.branch.nick}
1185.35.15 by Aaron Bentley
Added branch nicks to revisions
232
        if revprops:
233
            self.revprops.update(revprops)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
234
1508.1.22 by Robert Collins
implement out of date working tree checks in commit.
235
        # check for out of date working trees
236
        if self.work_tree.last_revision() != self.branch.last_revision():
1508.1.25 by Robert Collins
Update per review comments.
237
            raise errors.OutOfDateTree(self.work_tree)
1508.1.22 by Robert Collins
implement out of date working tree checks in commit.
238
1185.22.4 by Michael Ellerman
Strict commit was a little .. ah .. too strict, oops :}
239
        if strict:
240
            # raise an exception as soon as we find a single unknown.
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
241
            for unknown in self.work_tree.unknowns():
1185.22.4 by Michael Ellerman
Strict commit was a little .. ah .. too strict, oops :}
242
                raise StrictCommitFailed()
1185.16.65 by mbp at sourcefrog
- new commit --strict option
243
1189 by Martin Pool
- BROKEN: partial support for commit into weave
244
        if timestamp is None:
245
            self.timestamp = time.time()
246
        else:
247
            self.timestamp = long(timestamp)
248
            
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
249
        if self.config is None:
250
            self.config = bzrlib.config.BranchConfig(self.branch)
251
1248 by Martin Pool
- new weave based cleanup [broken]
252
        if rev_id is None:
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
253
            self.rev_id = _gen_revision_id(self.config, self.timestamp)
1248 by Martin Pool
- new weave based cleanup [broken]
254
        else:
255
            self.rev_id = rev_id
256
1189 by Martin Pool
- BROKEN: partial support for commit into weave
257
        if committer is None:
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
258
            self.committer = self.config.username()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
259
        else:
260
            assert isinstance(committer, basestring), type(committer)
261
            self.committer = committer
262
263
        if timezone is None:
264
            self.timezone = local_time_offset()
265
        else:
266
            self.timezone = int(timezone)
267
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
268
        if isinstance(message, str):
269
            message = message.decode(bzrlib.user_encoding)
270
        assert isinstance(message, unicode), type(message)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
271
        self.message = message
1390 by Robert Collins
pair programming worx... merge integration and weave
272
        self._escape_commit_message()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
273
1245 by Martin Pool
doc
274
        self.branch.lock_write()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
275
        try:
276
            self.work_inv = self.work_tree.inventory
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
277
            self.basis_tree = self.work_tree.basis_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
278
            self.basis_inv = self.basis_tree.inventory
279
1223 by Martin Pool
- store inventories in weave
280
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
281
            if len(self.parents) > 1 and self.specific_files:
282
                raise NotImplementedError('selected-file commit of merges is not supported yet')
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
283
            self._check_parents_present()
284
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
285
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
286
            self._populate_new_inv()
287
            self._store_snapshot()
1248 by Martin Pool
- new weave based cleanup [broken]
288
            self._report_deletes()
1245 by Martin Pool
doc
289
1248 by Martin Pool
- new weave based cleanup [broken]
290
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
291
                    or len(self.parents) > 1
1249 by Martin Pool
- improvements to weave commit [broken]
292
                    or self.new_inv != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
293
                raise PointlessCommit()
294
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
295
            if len(list(self.work_tree.iter_conflicts()))>0:
296
                raise ConflictsInTree
297
1189 by Martin Pool
- BROKEN: partial support for commit into weave
298
            self._record_inventory()
299
            self._make_revision()
1185.33.59 by Martin Pool
[patch] keep a cached basis inventory (Johan Rydberg)
300
            self.work_tree.set_pending_merges([])
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
301
            self.branch.append_revision(self.rev_id)
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
302
            if len(self.parents):
303
                precursor = self.parents[0]
304
            else:
305
                precursor = None
306
            self.work_tree.set_last_revision(self.rev_id, precursor)
1472 by Robert Collins
post commit hook, first pass implementation
307
            self.reporter.completed(self.branch.revno()+1, self.rev_id)
308
            if self.config.post_commit() is not None:
309
                hooks = self.config.post_commit().split(' ')
310
                # this would be nicer with twisted.python.reflect.namedAny
311
                for hook in hooks:
312
                    result = eval(hook + '(branch, rev_id)',
313
                                  {'branch':self.branch,
314
                                   'bzrlib':bzrlib,
315
                                   'rev_id':self.rev_id})
1189 by Martin Pool
- BROKEN: partial support for commit into weave
316
        finally:
317
            self.branch.unlock()
318
319
    def _record_inventory(self):
1223 by Martin Pool
- store inventories in weave
320
        """Store the inventory for the new revision."""
1248 by Martin Pool
- new weave based cleanup [broken]
321
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
322
        self.inv_sha1 = sha_string(inv_text)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
323
        s = self.branch.repository.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
324
        s.add_text('inventory', self.rev_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
325
                   split_lines(inv_text), self.present_parents,
326
                   self.branch.get_transaction())
1223 by Martin Pool
- store inventories in weave
327
1390 by Robert Collins
pair programming worx... merge integration and weave
328
    def _escape_commit_message(self):
329
        """Replace xml-incompatible control characters."""
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
330
        # Python strings can include characters that can't be
331
        # represented in well-formed XML; escape characters that
332
        # aren't listed in the XML specification
333
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
334
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
335
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
336
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
337
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
338
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
339
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
340
341
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
342
        """Record the parents of a merge for merge detection."""
1457.1.14 by Robert Collins
Move pending_merges() to WorkingTree.
343
        pending_merges = self.work_tree.pending_merges()
1223 by Martin Pool
- store inventories in weave
344
        self.parents = []
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
345
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
346
        self.present_parents = []
1241 by Martin Pool
- rename last_patch to last_revision
347
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
348
        if precursor_id:
349
            self.parents.append(precursor_id)
350
        self.parents += pending_merges
1092.2.25 by Robert Collins
support ghosts in commits
351
        for revision in self.parents:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
352
            if self.branch.repository.has_revision(revision):
353
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
354
                self.parent_invs.append(inventory)
1092.2.25 by Robert Collins
support ghosts in commits
355
                self.present_parents.append(revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
356
357
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
358
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
359
            mutter('commit parent revision {%s}', parent_id)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
360
            if not self.branch.repository.has_revision(parent_id):
1092.2.25 by Robert Collins
support ghosts in commits
361
                if parent_id == self.branch.last_revision():
1185.12.9 by Aaron Bentley
Removed crude language
362
                    warning("parent is missing %r", parent_id)
1092.2.25 by Robert Collins
support ghosts in commits
363
                    raise HistoryMissing(self.branch, 'revision', parent_id)
364
                else:
365
                    mutter("commit will ghost revision %r", parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
366
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
367
    def _make_revision(self):
368
        """Record a new revision object for this commit."""
369
        self.rev = Revision(timestamp=self.timestamp,
370
                            timezone=self.timezone,
371
                            committer=self.committer,
372
                            message=self.message,
373
                            inventory_sha1=self.inv_sha1,
1185.16.35 by Martin Pool
- stub for revision properties
374
                            revision_id=self.rev_id,
375
                            properties=self.revprops)
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
376
        self.rev.parent_ids = self.parents
1248 by Martin Pool
- new weave based cleanup [broken]
377
        rev_tmp = StringIO()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
378
        serializer_v5.write_revision(self.rev, rev_tmp)
580 by Martin Pool
- Use explicit lock methods on a branch, rather than doing it
379
        rev_tmp.seek(0)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
380
        if self.config.signature_needed():
381
            plaintext = Testament(self.rev, self.new_inv).as_short_text()
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
382
            self.branch.repository.store_revision_signature(
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
383
                gpg.GPGStrategy(self.config), plaintext, self.rev_id)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
384
        self.branch.repository.revision_store.add(rev_tmp, self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
385
        mutter('new revision_id is {%s}', self.rev_id)
386
387
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
388
        """Remove deleted files from the working inventories.
389
390
        This is done prior to taking the working inventory as the
391
        basis for the new committed inventory.
392
393
        This returns true if any files
394
        *that existed in the basis inventory* were deleted.
395
        Files that were added and deleted
396
        in the working copy don't matter.
397
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
398
        specific = self.specific_files
399
        deleted_ids = []
400
        for path, ie in self.work_inv.iter_entries():
401
            if specific and not is_inside_any(specific, path):
402
                continue
403
            if not self.work_tree.has_filename(path):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
404
                self.reporter.missing(path)
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
405
                deleted_ids.append((path, ie.file_id))
1254 by Martin Pool
- fix handling of selective commit with deleted files
406
        if deleted_ids:
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
407
            deleted_ids.sort(reverse=True)
408
            for path, file_id in deleted_ids:
1248 by Martin Pool
- new weave based cleanup [broken]
409
                del self.work_inv[file_id]
1457.1.11 by Robert Collins
Move _write_inventory to WorkingTree.
410
            self.work_tree._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
411
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
412
    def _store_snapshot(self):
413
        """Pass over inventory and record a snapshot.
1303 by Martin Pool
- commit updates entry_version
414
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
415
        Entries get a new revision when they are modified in 
416
        any way, which includes a merge with a new set of
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
417
        parents that have the same entry. 
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
418
        """
1303 by Martin Pool
- commit updates entry_version
419
        # XXX: Need to think more here about when the user has
420
        # made a specific decision on a particular value -- c.f.
421
        # mark-merge.  
422
        for path, ie in self.new_inv.iter_entries():
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
423
            previous_entries = ie.find_previous_heads(
424
                self.parent_invs, 
1185.33.88 by Martin Pool
[patch] read only the table-of-contents of weaves to speed up commit
425
                self.weave_store.get_weave_prelude_or_empty(ie.file_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
426
                    self.branch.get_transaction()))
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
427
            if ie.revision is None:
428
                change = ie.snapshot(self.rev_id, path, previous_entries,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
429
                                     self.work_tree, self.weave_store,
430
                                     self.branch.get_transaction())
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
431
            else:
432
                change = "unchanged"
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
433
            self.reporter.snapshot_change(change, path)
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
434
435
    def _populate_new_inv(self):
436
        """Build revision inventory.
437
438
        This creates a new empty inventory. Depending on
439
        which files are selected for commit, and what is present in the
440
        current tree, the new inventory is populated. inventory entries 
441
        which are candidates for modification have their revision set to
442
        None; inventory entries that are carried over untouched have their
443
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
444
        """
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
445
        mutter("Selecting files for commit with filter %s", self.specific_files)
446
        self.new_inv = Inventory()
1249 by Martin Pool
- improvements to weave commit [broken]
447
        for path, new_ie in self.work_inv.iter_entries():
448
            file_id = new_ie.file_id
449
            mutter('check %s {%s}', path, new_ie.file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
450
            if self.specific_files:
451
                if not is_inside_any(self.specific_files, path):
1249 by Martin Pool
- improvements to weave commit [broken]
452
                    mutter('%s not selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
453
                    self._carry_entry(file_id)
1249 by Martin Pool
- improvements to weave commit [broken]
454
                    continue
1416 by Robert Collins
when committing a specific file, include all its parents
455
                else:
456
                    # this is selected, ensure its parents are too.
457
                    parent_id = new_ie.parent_id
458
                    while parent_id != ROOT_ID:
459
                        if not self.new_inv.has_id(parent_id):
460
                            ie = self._select_entry(self.work_inv[parent_id])
461
                            mutter('%s selected for commit because of %s',
462
                                   self.new_inv.id2path(parent_id), path)
463
464
                        ie = self.new_inv[parent_id]
465
                        if ie.revision is not None:
466
                            ie.revision = None
467
                            mutter('%s selected for commit because of %s',
468
                                   self.new_inv.id2path(parent_id), path)
469
                        parent_id = ie.parent_id
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
470
            mutter('%s selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
471
            self._select_entry(new_ie)
472
473
    def _select_entry(self, new_ie):
474
        """Make new_ie be considered for committing."""
475
        ie = new_ie.copy()
476
        ie.revision = None
477
        self.new_inv.add(ie)
478
        return ie
479
480
    def _carry_entry(self, file_id):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
481
        """Carry the file unchanged from the basis revision."""
1249 by Martin Pool
- improvements to weave commit [broken]
482
        if self.basis_inv.has_id(file_id):
483
            self.new_inv.add(self.basis_inv[file_id].copy())
1248 by Martin Pool
- new weave based cleanup [broken]
484
485
    def _report_deletes(self):
486
        for file_id in self.basis_inv:
487
            if file_id not in self.new_inv:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
488
                self.reporter.deleted(self.basis_inv.id2path(file_id))
1248 by Martin Pool
- new weave based cleanup [broken]
489
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
490
def _gen_revision_id(config, when):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
491
    """Return new revision-id."""
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
492
    s = '%s-%s-' % (config.user_email(), compact_date(when))
1189 by Martin Pool
- BROKEN: partial support for commit into weave
493
    s += hexlify(rand_bytes(8))
494
    return s