~bzr-pqm/bzr/bzr.dev

184 by mbp at sourcefrog
pychecker fixups
1
# (C) 2005 Canonical
1 by mbp at sourcefrog
import from baz patch-364
2
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
1185.16.40 by Martin Pool
todo
17
# TODO: Some kind of command-line display of revision properties: 
18
# perhaps show them in log -v and allow them as options to the commit command.
1 by mbp at sourcefrog
import from baz patch-364
19
1590.1.1 by Robert Collins
Improve common_ancestor performance.
20
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
21
import bzrlib.errors
1590.1.1 by Robert Collins
Improve common_ancestor performance.
22
import bzrlib.errors as errors
1594.2.15 by Robert Collins
Unfuck performance.
23
from bzrlib.graph import node_distances, select_farthest, all_descendants, Graph
1185.16.39 by Martin Pool
- constraints on revprops
24
from bzrlib.osutils import contains_whitespace
1534.9.1 by Aaron Bentley
Added progress bars to merge
25
from bzrlib.progress import DummyProgress
1649.1.1 by Robert Collins
* 'pull' and 'push' now normalise the revision history, so that any two
26
from bzrlib.symbol_versioning import *
8 by mbp at sourcefrog
store committer's timezone in revision and show
27
974.1.90 by Aaron Bentley
Switched NULL revision ID to 'null:' per robertc's suggestion
28
NULL_REVISION="null:"
974.1.89 by Aaron Bentley
Fixed merging with multiple roots, by using null as graph root.
29
802 by Martin Pool
- Remove XMLMixin class in favour of simple pack_xml, unpack_xml functions
30
class Revision(object):
1 by mbp at sourcefrog
import from baz patch-364
31
    """Single revision on a branch.
32
33
    Revisions may know their revision_hash, but only once they've been
34
    written out.  This is not stored because you cannot write the hash
35
    into the file it describes.
36
697 by Martin Pool
- write out parent list for new revisions
37
    After bzr 0.0.5 revisions are allowed to have multiple parents.
696 by Martin Pool
- Refactor revision deserialization code
38
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
39
    parent_ids
40
        List of parent revision_ids
1185.16.39 by Martin Pool
- constraints on revprops
41
42
    properties
43
        Dictionary of revision properties.  These are attached to the
44
        revision as extra metadata.  The name must be a single 
45
        word; the value can be an arbitrary string.
1 by mbp at sourcefrog
import from baz patch-364
46
    """
696 by Martin Pool
- Refactor revision deserialization code
47
    
1185.16.35 by Martin Pool
- stub for revision properties
48
    def __init__(self, revision_id, properties=None, **args):
1092.2.25 by Robert Collins
support ghosts in commits
49
        self.revision_id = revision_id
1185.16.35 by Martin Pool
- stub for revision properties
50
        self.properties = properties or {}
1185.16.39 by Martin Pool
- constraints on revprops
51
        self._check_properties()
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
52
        self.parent_ids = []
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
53
        self.parent_sha1s = []
1185.42.6 by Jelmer Vernooij
Don't clear Revision.parent_ids after it has been set from the arguments
54
        self.__dict__.update(args)
696 by Martin Pool
- Refactor revision deserialization code
55
1 by mbp at sourcefrog
import from baz patch-364
56
    def __repr__(self):
184 by mbp at sourcefrog
pychecker fixups
57
        return "<Revision id %s>" % self.revision_id
1 by mbp at sourcefrog
import from baz patch-364
58
1185 by Martin Pool
- add xml round-trip test for revisions
59
    def __eq__(self, other):
60
        if not isinstance(other, Revision):
61
            return False
1092.2.20 by Robert Collins
symlink and weaves, whaddya know
62
        # FIXME: rbc 20050930 parent_ids are not being compared
63
        return (
64
                self.inventory_sha1 == other.inventory_sha1
1185 by Martin Pool
- add xml round-trip test for revisions
65
                and self.revision_id == other.revision_id
66
                and self.timestamp == other.timestamp
67
                and self.message == other.message
68
                and self.timezone == other.timezone
1185.16.35 by Martin Pool
- stub for revision properties
69
                and self.committer == other.committer
70
                and self.properties == other.properties)
1185 by Martin Pool
- add xml round-trip test for revisions
71
72
    def __ne__(self, other):
73
        return not self.__eq__(other)
74
1185.16.39 by Martin Pool
- constraints on revprops
75
    def _check_properties(self):
76
        """Verify that all revision properties are OK.
77
        """
78
        for name, value in self.properties.iteritems():
79
            if not isinstance(name, basestring) or contains_whitespace(name):
80
                raise ValueError("invalid property name %r" % name)
81
            if not isinstance(value, basestring):
82
                raise ValueError("invalid property value %r for %r" % 
83
                                 (name, value))
84
1534.4.49 by Robert Collins
Provide a revision.get_history(repository) method for generating a synthetic revision history.
85
    def get_history(self, repository):
86
        """Return the canonical line-of-history for this revision.
87
88
        If ghosts are present this may differ in result from a ghost-free
89
        repository.
90
        """
91
        current_revision = self
92
        reversed_result = []
93
        while current_revision is not None:
94
            reversed_result.append(current_revision.revision_id)
95
            if not len (current_revision.parent_ids):
96
                reversed_result.append(None)
97
                current_revision = None
98
            else:
99
                next_revision_id = current_revision.parent_ids[0]
100
                current_revision = repository.get_revision(next_revision_id)
101
        reversed_result.reverse()
102
        return reversed_result
103
1268 by Martin Pool
- is_ancestor now works by looking at the Branch's stored ancestry
104
105
def is_ancestor(revision_id, candidate_id, branch):
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
106
    """Return true if candidate_id is an ancestor of revision_id.
1268 by Martin Pool
- is_ancestor now works by looking at the Branch's stored ancestry
107
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
108
    A false negative will be returned if any intermediate descendent of
109
    candidate_id is not present in any of the revision_sources.
810 by Martin Pool
- New validate_revision_id function
110
    
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
111
    revisions_source is an object supporting a get_revision operation that
112
    behaves like Branch's.
113
    """
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
114
    return candidate_id in branch.repository.get_ancestry(revision_id)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
115
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
116
117
def iter_ancestors(revision_id, revision_source, only_present=False):
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
118
    ancestors = (revision_id,)
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
119
    distance = 0
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
120
    while len(ancestors) > 0:
121
        new_ancestors = []
122
        for ancestor in ancestors:
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
123
            if not only_present:
124
                yield ancestor, distance
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
125
            try:
126
                revision = revision_source.get_revision(ancestor)
127
            except bzrlib.errors.NoSuchRevision, e:
128
                if e.revision == revision_id:
129
                    raise 
130
                else:
131
                    continue
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
132
            if only_present:
133
                yield ancestor, distance
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
134
            new_ancestors.extend(revision.parent_ids)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
135
        ancestors = new_ancestors
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
136
        distance += 1
137
138
139
def find_present_ancestors(revision_id, revision_source):
1133 by Martin Pool
doc
140
    """Return the ancestors of a revision present in a branch.
141
142
    It's possible that a branch won't have the complete ancestry of
143
    one of its revisions.  
144
145
    """
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
146
    found_ancestors = {}
147
    anc_iter = enumerate(iter_ancestors(revision_id, revision_source,
148
                         only_present=True))
149
    for anc_order, (anc_id, anc_distance) in anc_iter:
150
        if not found_ancestors.has_key(anc_id):
151
            found_ancestors[anc_id] = (anc_order, anc_distance)
152
    return found_ancestors
153
    
1153 by Martin Pool
- clean up some code in revision.py
154
155
def __get_closest(intersection):
156
    intersection.sort()
157
    matches = [] 
158
    for entry in intersection:
159
        if entry[0] == intersection[0][0]:
160
            matches.append(entry[2])
161
    return matches
162
974.1.35 by aaron.bentley at utoronto
Added revision-based common-ancestor checking
163
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
164
def revision_graph(revision, revision_source):
974.1.66 by Aaron Bentley
more cleanups, docs, sorting stuff
165
    """Produce a graph of the ancestry of the specified revision.
1590.1.1 by Robert Collins
Improve common_ancestor performance.
166
    
167
    :return: root, ancestors map, descendants map
974.1.66 by Aaron Bentley
more cleanups, docs, sorting stuff
168
    """
1587.1.4 by Robert Collins
Quick, urgent fix for common_ancestor performance.
169
    revision_source.lock_read()
170
    try:
171
        return _revision_graph(revision, revision_source)
172
    finally:
173
        revision_source.unlock()
174
1590.1.1 by Robert Collins
Improve common_ancestor performance.
175
1587.1.4 by Robert Collins
Quick, urgent fix for common_ancestor performance.
176
def _revision_graph(revision, revision_source):
177
    """See revision_graph."""
1590.1.1 by Robert Collins
Improve common_ancestor performance.
178
    from bzrlib.tsort import topo_sort
179
    graph = revision_source.get_revision_graph(revision)
180
    # mark all no-parent revisions as being NULL_REVISION parentage.
181
    for node, parents in graph.items():
182
        if len(parents) == 0:
183
            graph[node] = [NULL_REVISION]
184
    # add NULL_REVISION to the graph
185
    graph[NULL_REVISION] = []
186
187
    # pick a root. If there are multiple roots
188
    # this could pick a random one.
189
    topo_order = topo_sort(graph.items())
190
    root = topo_order[0]
191
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
192
    ancestors = {}
193
    descendants = {}
1590.1.1 by Robert Collins
Improve common_ancestor performance.
194
195
    # map the descendants of the graph.
196
    # and setup our set based return graph.
197
    for node in graph.keys():
198
        descendants[node] = {}
199
    for node, parents in graph.items():
200
        for parent in parents:
201
            descendants[parent][node] = 1
202
        ancestors[node] = set(parents)
203
974.1.63 by Aaron Bentley
Fixed graph-generation
204
    assert root not in descendants[root]
205
    assert root not in ancestors[root]
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
206
    return root, ancestors, descendants
207
1092.3.4 by Robert Collins
update symlink branch to integration
208
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
209
def combined_graph(revision_a, revision_b, revision_source):
974.1.66 by Aaron Bentley
more cleanups, docs, sorting stuff
210
    """Produce a combined ancestry graph.
211
    Return graph root, ancestors map, descendants map, set of common nodes"""
1590.1.1 by Robert Collins
Improve common_ancestor performance.
212
    root, ancestors, descendants = revision_graph(
213
        revision_a, revision_source)
214
    root_b, ancestors_b, descendants_b = revision_graph(
215
        revision_b, revision_source)
974.1.80 by Aaron Bentley
Improved merge error handling and testing
216
    if root != root_b:
217
        raise bzrlib.errors.NoCommonRoot(revision_a, revision_b)
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
218
    common = set()
219
    for node, node_anc in ancestors_b.iteritems():
220
        if node in ancestors:
221
            common.add(node)
222
        else:
223
            ancestors[node] = set()
224
        ancestors[node].update(node_anc)
225
    for node, node_dec in descendants_b.iteritems():
226
        if node not in descendants:
1185.8.1 by Aaron Bentley
Ensured combined_graph is order-insensitive
227
            descendants[node] = {}
974.1.63 by Aaron Bentley
Fixed graph-generation
228
        descendants[node].update(node_dec)
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
229
    return root, ancestors, descendants, common
230
1092.3.4 by Robert Collins
update symlink branch to integration
231
1534.9.1 by Aaron Bentley
Added progress bars to merge
232
def common_ancestor(revision_a, revision_b, revision_source, 
233
                    pb=DummyProgress()):
1587.1.11 by Robert Collins
Local commits appear to be working properly.
234
    if None in (revision_a, revision_b):
235
        return None
1594.2.15 by Robert Collins
Unfuck performance.
236
    # trivial optimisation
237
    if revision_a == revision_b:
238
        return revision_a
974.1.80 by Aaron Bentley
Improved merge error handling and testing
239
    try:
1534.9.1 by Aaron Bentley
Added progress bars to merge
240
        try:
241
            pb.update('Picking ancestor', 1, 3)
1594.2.15 by Robert Collins
Unfuck performance.
242
            graph = revision_source.get_revision_graph_with_ghosts(
243
                [revision_a, revision_b])
244
            # convert to a NULL_REVISION based graph.
245
            ancestors = graph.get_ancestors()
246
            descendants = graph.get_descendants()
247
            common = set(graph.get_ancestry(revision_a)).intersection(
248
                     set(graph.get_ancestry(revision_b)))
249
            descendants[NULL_REVISION] = {}
250
            ancestors[NULL_REVISION] = []
251
            for root in graph.roots:
252
                descendants[NULL_REVISION][root] = 1
253
                ancestors[root].append(NULL_REVISION)
1607.1.12 by Robert Collins
Fix common_ancestor to still calculate a common ancestor when ghosts are
254
            for ghost in graph.ghosts:
255
                # ghosts act as roots for the purpose of finding 
256
                # the longest paths from the root: any ghost *might*
257
                # be directly attached to the root, so we treat them
258
                # as being such.
259
                # ghost now descends from NULL
260
                descendants[NULL_REVISION][ghost] = 1
261
                # that is it has an ancestor of NULL
262
                ancestors[ghost] = [NULL_REVISION]
263
                # ghost is common if any of ghosts descendants are common:
264
                for ghost_descendant in descendants[ghost]:
265
                    if ghost_descendant in common:
266
                        common.add(ghost)
267
                
1594.2.15 by Robert Collins
Unfuck performance.
268
            root = NULL_REVISION
269
            common.add(NULL_REVISION)
1534.9.1 by Aaron Bentley
Added progress bars to merge
270
        except bzrlib.errors.NoCommonRoot:
271
            raise bzrlib.errors.NoCommonAncestor(revision_a, revision_b)
272
            
273
        pb.update('Picking ancestor', 2, 3)
274
        distances = node_distances (descendants, ancestors, root)
275
        pb.update('Picking ancestor', 3, 2)
276
        farthest = select_farthest(distances, common)
277
        if farthest is None or farthest == NULL_REVISION:
278
            raise bzrlib.errors.NoCommonAncestor(revision_a, revision_b)
279
    finally:
280
        pb.clear()
974.1.87 by Aaron Bentley
Refactored and documented graph stuff
281
    return farthest
974.1.60 by aaron.bentley at utoronto
Initial import of common-ancestor detection
282
283
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
284
class MultipleRevisionSources(object):
1153 by Martin Pool
- clean up some code in revision.py
285
    """Proxy that looks in multiple branches for revisions."""
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
286
    def __init__(self, *args):
287
        object.__init__(self)
288
        assert len(args) != 0
289
        self._revision_sources = args
290
1590.1.1 by Robert Collins
Improve common_ancestor performance.
291
    def revision_parents(self, revision_id):
292
        for source in self._revision_sources:
293
            try:
294
                return source.revision_parents(revision_id)
295
            except (errors.WeaveRevisionNotPresent, errors.NoSuchRevision), e:
296
                pass
297
        raise e
298
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
299
    def get_revision(self, revision_id):
300
        for source in self._revision_sources:
301
            try:
302
                return source.get_revision(revision_id)
303
            except bzrlib.errors.NoSuchRevision, e:
304
                pass
305
        raise e
974.2.7 by aaron.bentley at utoronto
Merged from bzr.24
306
1590.1.1 by Robert Collins
Improve common_ancestor performance.
307
    def get_revision_graph(self, revision_id):
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
308
        # we could probe incrementally until the pending
309
        # ghosts list stop growing, but its cheaper for now
310
        # to just ask for the complete graph for each repository.
311
        graphs = []
312
        for source in self._revision_sources:
313
            ghost_graph = source.get_revision_graph_with_ghosts()
314
            graphs.append(ghost_graph)
315
        absent = 0
316
        for graph in graphs:
317
            if not revision_id in graph.get_ancestors():
318
                absent += 1
319
        if absent == len(graphs):
320
            raise errors.NoSuchRevision(self._revision_sources[0], revision_id)
321
322
        # combine the graphs
1590.1.1 by Robert Collins
Improve common_ancestor performance.
323
        result = {}
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
324
        pending = set([revision_id])
325
        def find_parents(node_id):
326
            """find the parents for node_id."""
327
            for graph in graphs:
328
                ancestors = graph.get_ancestors()
329
                try:
330
                    return ancestors[node_id]
331
                except KeyError:
332
                    pass
333
            raise errors.NoSuchRevision(self._revision_sources[0], node_id)
334
        while len(pending):
335
            # all the graphs should have identical parent lists
336
            node_id = pending.pop()
1590.1.1 by Robert Collins
Improve common_ancestor performance.
337
            try:
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
338
                result[node_id] = find_parents(node_id)
339
                for parent_node in result[node_id]:
340
                    if not parent_node in result:
341
                        pending.add(parent_node)
342
            except errors.NoSuchRevision:
343
                # ghost, ignore it.
1590.1.1 by Robert Collins
Improve common_ancestor performance.
344
                pass
1594.2.3 by Robert Collins
bugfix revision.MultipleRevisionSources.get_revision_graph to integrate ghosts between sources. [slow on weaves, fast on knits.
345
        return result
1590.1.1 by Robert Collins
Improve common_ancestor performance.
346
1594.2.15 by Robert Collins
Unfuck performance.
347
    def get_revision_graph_with_ghosts(self, revision_ids):
348
        # query all the sources for their entire graphs 
349
        # and then build a combined graph for just
350
        # revision_ids.
351
        graphs = []
352
        for source in self._revision_sources:
353
            ghost_graph = source.get_revision_graph_with_ghosts()
354
            graphs.append(ghost_graph.get_ancestors())
355
        for revision_id in revision_ids:
356
            absent = 0
357
            for graph in graphs:
358
                    if not revision_id in graph:
359
                        absent += 1
360
            if absent == len(graphs):
361
                raise errors.NoSuchRevision(self._revision_sources[0],
362
                                            revision_id)
363
364
        # combine the graphs
365
        result = Graph()
366
        pending = set(revision_ids)
367
        done = set()
368
        def find_parents(node_id):
369
            """find the parents for node_id."""
370
            for graph in graphs:
371
                try:
372
                    return graph[node_id]
373
                except KeyError:
374
                    pass
375
            raise errors.NoSuchRevision(self._revision_sources[0], node_id)
376
        while len(pending):
377
            # all the graphs should have identical parent lists
378
            node_id = pending.pop()
379
            try:
380
                parents = find_parents(node_id)
381
                for parent_node in parents:
382
                    # queued or done? 
383
                    if (parent_node not in pending and
384
                        parent_node not in done):
385
                        # no, queue
386
                        pending.add(parent_node)
387
                result.add_node(node_id, parents)
388
                done.add(node_id)
389
            except errors.NoSuchRevision:
390
                # ghost
391
                result.add_ghost(node_id)
392
                continue
393
        return result
394
1587.1.4 by Robert Collins
Quick, urgent fix for common_ancestor performance.
395
    def lock_read(self):
396
        for source in self._revision_sources:
397
            source.lock_read()
398
399
    def unlock(self):
400
        for source in self._revision_sources:
401
            source.unlock()
402
1590.1.1 by Robert Collins
Improve common_ancestor performance.
403
1649.1.1 by Robert Collins
* 'pull' and 'push' now normalise the revision history, so that any two
404
@deprecated_method(zero_eight)
974.2.7 by aaron.bentley at utoronto
Merged from bzr.24
405
def get_intervening_revisions(ancestor_id, rev_id, rev_source, 
406
                              revision_history=None):
407
    """Find the longest line of descent from maybe_ancestor to revision.
408
    Revision history is followed where possible.
409
410
    If ancestor_id == rev_id, list will be empty.
411
    Otherwise, rev_id will be the last entry.  ancestor_id will never appear.
412
    If ancestor_id is not an ancestor, NotAncestor will be thrown
413
    """
974.1.73 by Aaron Bentley
Reimplemented get_intervening_revisions for better scalability
414
    root, ancestors, descendants = revision_graph(rev_id, rev_source)
415
    if len(descendants) == 0:
416
        raise NoSuchRevision(rev_source, rev_id)
417
    if ancestor_id not in descendants:
418
        rev_source.get_revision(ancestor_id)
419
        raise bzrlib.errors.NotAncestor(rev_id, ancestor_id)
420
    root_descendants = all_descendants(descendants, ancestor_id)
421
    root_descendants.add(ancestor_id)
422
    if rev_id not in root_descendants:
423
        raise bzrlib.errors.NotAncestor(rev_id, ancestor_id)
424
    distances = node_distances(descendants, ancestors, ancestor_id,
425
                               root_descendants=root_descendants)
426
427
    def best_ancestor(rev_id):
428
        best = None
429
        for anc_id in ancestors[rev_id]:
430
            try:
431
                distance = distances[anc_id]
432
            except KeyError:
433
                continue
434
            if revision_history is not None and anc_id in revision_history:
435
                return anc_id
436
            elif best is None or distance > best[1]:
437
                best = (anc_id, distance)
438
        return best[0]
439
440
    next = rev_id
441
    path = []
442
    while next != ancestor_id:
443
        path.append(next)
444
        next = best_ancestor(next)
445
    path.reverse()
446
    return path