~bzr-pqm/bzr/bzr.dev

1666.1.2 by Robert Collins
Fix race condition between end of stream and end of file with tuned_gzip.
1
# Copyright (C) 2006 by Canonical Ltd
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
18
"""Tests for tuned_gzip."""
19
20
21
# do not use bzrlib test cases here - this should be suitable for sending
22
# upstream.
23
from cStringIO import StringIO
24
from unittest import TestCase
25
import zlib
26
27
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
28
from bzrlib import tuned_gzip
1666.1.2 by Robert Collins
Fix race condition between end of stream and end of file with tuned_gzip.
29
30
31
class FakeDecompress(object):
32
    """A fake decompressor for testing GzipFile."""
33
34
    def __init__(self):
35
        self.unused_data=''
36
37
    def decompress(self, buf):
38
        """Return an empty string as though we are at eof."""
1666.1.11 by Robert Collins
Really fix short-read support in tuned_gzip. The python zlib module behaved differently than thought.
39
        # note that the zlib module *overwrites* unused data 
40
        # on writes after EOF.
41
        self.unused_data = buf
1666.1.2 by Robert Collins
Fix race condition between end of stream and end of file with tuned_gzip.
42
        return ''
43
44
45
class TestFakeDecompress(TestCase):
46
    """We use a fake decompressor to test GzipFile.
47
48
    This class tests the behaviours we want from it.
49
    """
50
51
    def test_decompress(self):
52
        # decompressing returns no data.
53
        decompress = FakeDecompress()
54
        self.assertEqual('', decompress.decompress('0'))
55
56
    def test_unused_data(self):
57
        # after decompressing, we have 1 unused byte.
58
        # this is normally set by decompressors when they
59
        # detect the end of a compressed stream.
60
        decompress = FakeDecompress()
61
        decompress.decompress('0')
62
        self.assertEqual('0', decompress.unused_data)
63
        # decompressing again (when the short read is read)
1666.1.11 by Robert Collins
Really fix short-read support in tuned_gzip. The python zlib module behaved differently than thought.
64
        # will give us the latest input in the unused_data
65
        # this is arguably a bug in zlib but ...
1666.1.2 by Robert Collins
Fix race condition between end of stream and end of file with tuned_gzip.
66
        decompress.decompress('1234567')
1666.1.11 by Robert Collins
Really fix short-read support in tuned_gzip. The python zlib module behaved differently than thought.
67
        self.assertEqual('1234567', decompress.unused_data)
1666.1.2 by Robert Collins
Fix race condition between end of stream and end of file with tuned_gzip.
68
69
70
class TestGzip(TestCase):
71
72
    def test__read_short_remainder(self):
73
        # a _read call at the end of a compressed hunk should
74
        # read more bytes if there is less than 8 bytes (the 
75
        # gzip trailer) unread.
76
        stream = StringIO('\0\0\0\0\0\0\0\0')
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
77
        myfile = tuned_gzip.GzipFile(fileobj=stream)
1666.1.2 by Robert Collins
Fix race condition between end of stream and end of file with tuned_gzip.
78
        # disable the _new_member check, we are microtesting.
79
        myfile._new_member = False
80
        myfile.crc = zlib.crc32('')
81
        myfile.decompress = FakeDecompress()
82
        myfile.size = 0
83
        myfile._read(1)
84
        # all the data should have been read now
85
        self.assertEqual('', stream.read())
86
        # and it should be new member time in the stream.
87
        self.failUnless(myfile._new_member)