~bzr-pqm/bzr/bzr.dev

1704.2.14 by Martin Pool
[merge] work from 0.8 fixes
1
# Copyright (C) 2005, 2006 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# The newly committed revision is going to have a shape corresponding
19
# to that of the working inventory.  Files that are not in the
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
28
# recorded.  For each parent revision inventory, we check to see what
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
60
    errors,
1959.4.2 by Aaron Bentley
Merge bzr.dev
61
    inventory,
1551.8.30 by Aaron Bentley
Tweak from review comments
62
    tree,
63
    )
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
64
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
65
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
66
                           ConflictsInTree,
67
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
68
                           )
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
69
from bzrlib.osutils import (kind_marker, isdir,isfile, is_inside_any, 
70
                            is_inside_or_parent_of_any,
71
                            quotefn, sha_file, split_lines)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
72
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
73
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
74
from bzrlib.xml5 import serializer_v5
1731.1.33 by Aaron Bentley
Revert no-special-root changes
75
from bzrlib.inventory import Inventory, InventoryEntry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
76
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
77
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
78
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
79
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
80
from bzrlib.workingtree import WorkingTree
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
81
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
82
83
84
class NullCommitReporter(object):
85
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
86
87
    def snapshot_change(self, change, path):
88
        pass
89
90
    def completed(self, revno, rev_id):
91
        pass
92
93
    def deleted(self, file_id):
94
        pass
95
96
    def escaped(self, escape_count, message):
97
        pass
98
99
    def missing(self, path):
100
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
101
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
102
    def renamed(self, change, old_path, new_path):
103
        pass
104
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
105
1189 by Martin Pool
- BROKEN: partial support for commit into weave
106
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
107
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
108
    # this may be more useful if 'note' was replaced by an overridable
109
    # method on self, which would allow more trivial subclassing.
110
    # alternative, a callable could be passed in, allowing really trivial
111
    # reuse for some uis. RBC 20060511
112
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
113
    def snapshot_change(self, change, path):
1616.1.4 by Martin Pool
Verbose commit shouldn't talk about every unchanged file.
114
        if change == 'unchanged':
115
            return
1731.1.45 by Aaron Bentley
Merge bzr.dev
116
        if change == 'added' and path == '':
117
            return
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
118
        note("%s %s", change, path)
119
120
    def completed(self, revno, rev_id):
1607.1.5 by Robert Collins
Make commit verbose mode work!.
121
        note('Committed revision %d.', revno)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
122
    
123
    def deleted(self, file_id):
124
        note('deleted %s', file_id)
125
126
    def escaped(self, escape_count, message):
127
        note("replaced %d control characters in message", escape_count)
128
129
    def missing(self, path):
130
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
131
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
132
    def renamed(self, change, old_path, new_path):
133
        note('%s %s => %s', change, old_path, new_path)
134
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
135
1189 by Martin Pool
- BROKEN: partial support for commit into weave
136
class Commit(object):
137
    """Task of committing a new revision.
138
139
    This is a MethodObject: it accumulates state as the commit is
140
    prepared, and then it is discarded.  It doesn't represent
141
    historical revisions, just the act of recording a new one.
142
143
            missing_ids
144
            Modified to hold a list of files that have been deleted from
145
            the working directory; these should be removed from the
146
            working inventory.
485 by Martin Pool
- move commit code into its own module
147
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
148
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
149
                 reporter=None,
150
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
151
        if reporter is not None:
152
            self.reporter = reporter
153
        else:
154
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
155
        if config is not None:
156
            self.config = config
157
        else:
158
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
159
        
160
    def commit(self,
2149.1.3 by Aaron Bentley
Updates from review comments
161
               branch=DEPRECATED_PARAMETER, message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
162
               timestamp=None,
163
               timezone=None,
164
               committer=None,
165
               specific_files=None,
166
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
167
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
168
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
169
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
170
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
171
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
172
               local=False,
173
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
174
               config=None,
175
               message_callback=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
176
        """Commit working copy as a new revision.
177
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
178
        branch -- the deprecated branch to commit to. New callers should pass in 
179
                  working_tree instead
180
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
181
        message -- the commit message (it or message_callback is required)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
182
1189 by Martin Pool
- BROKEN: partial support for commit into weave
183
        timestamp -- if not None, seconds-since-epoch for a
184
             postdated/predated commit.
185
1253 by Martin Pool
- test that pointless commits are trapped
186
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
187
1253 by Martin Pool
- test that pointless commits are trapped
188
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
189
            Useful for test or import commands that need to tightly
190
            control what revisions are assigned.  If you duplicate
191
            a revision id that exists elsewhere it is your own fault.
192
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
193
194
        allow_pointless -- If true (default), commit even if nothing
195
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
196
1185.16.65 by mbp at sourcefrog
- new commit --strict option
197
        strict -- If true, don't allow a commit if the working tree
198
            contains unknown files.
199
1185.16.35 by Martin Pool
- stub for revision properties
200
        revprops -- Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
201
        :param local: Perform a local only commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
202
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
203
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
204
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
205
        if deprecated_passed(branch):
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
206
            symbol_versioning.warn("Commit.commit (branch, ...): The branch parameter is "
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
207
                 "deprecated as of bzr 0.8. Please use working_tree= instead.",
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
208
                 DeprecationWarning, stacklevel=2)
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
209
            self.branch = branch
1508.1.19 by Robert Collins
Give format3 working trees their own last-revision marker.
210
            self.work_tree = self.branch.bzrdir.open_workingtree()
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
211
        elif working_tree is None:
212
            raise BzrError("One of branch and working_tree must be passed into commit().")
213
        else:
214
            self.work_tree = working_tree
215
            self.branch = self.work_tree.branch
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
216
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
217
            if message is not None:
218
                if isinstance(message, str):
219
                    message = message.decode(bzrlib.user_encoding)
220
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
221
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
222
                raise BzrError("The message or message_callback keyword"
223
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
224
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
225
        self.bound_branch = None
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
226
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
227
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
228
        self.master_locked = False
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
229
        self.rev_id = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
230
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
231
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
232
1607.1.5 by Robert Collins
Make commit verbose mode work!.
233
        if reporter is None and self.reporter is None:
234
            self.reporter = NullCommitReporter()
1607.1.8 by Robert Collins
Integrate latest bzr.dev.
235
        elif reporter is not None:
1607.1.5 by Robert Collins
Make commit verbose mode work!.
236
            self.reporter = reporter
237
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
238
        self.work_tree.lock_write()
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
239
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
240
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
241
            # Cannot commit with conflicts present.
242
            if len(self.work_tree.conflicts())>0:
243
                raise ConflictsInTree
244
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
245
            # setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
246
            self._check_bound_branch()
247
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
248
            # check for out of date working trees
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
249
            try:
250
                first_tree_parent = self.work_tree.get_parent_ids()[0]
251
            except IndexError:
252
                # if there are no parents, treat our parent as 'None'
253
                # this is so that we still consier the master branch
254
                # - in a checkout scenario the tree may have no
255
                # parents but the branch may do.
256
                first_tree_parent = None
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
257
            master_last = self.master_branch.last_revision()
1908.7.6 by Robert Collins
Deprecate WorkingTree.last_revision.
258
            if (master_last is not None and
259
                master_last != first_tree_parent):
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
260
                raise errors.OutOfDateTree(self.work_tree)
261
    
262
            if strict:
263
                # raise an exception as soon as we find a single unknown.
264
                for unknown in self.work_tree.unknowns():
265
                    raise StrictCommitFailed()
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
266
                   
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
267
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
268
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
269
1189 by Martin Pool
- BROKEN: partial support for commit into weave
270
            self.work_inv = self.work_tree.inventory
1534.4.35 by Robert Collins
Give branch its own basis tree and last_revision methods; deprecated branch.working_tree()
271
            self.basis_tree = self.work_tree.basis_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
272
            self.basis_inv = self.basis_tree.inventory
1551.8.29 by Aaron Bentley
Stop accepting non-existant files in commit (#50793)
273
            if specific_files is not None:
274
                # Ensure specified files are versioned
275
                # (We don't actually need the ids here)
276
                tree.find_ids_across_trees(specific_files, 
277
                                           [self.basis_tree, self.work_tree])
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
278
            # one to finish, one for rev and inventory, and one for each
279
            # inventory entry, and the same for the new inventory.
280
            # note that this estimate is too long when we do a partial tree
281
            # commit which excludes some new files from being considered.
282
            # The estimate is corrected when we populate the new inv.
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
283
            self.pb_total = len(self.work_inv) + 5
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
284
            self.pb_count = 0
1189 by Martin Pool
- BROKEN: partial support for commit into weave
285
1223 by Martin Pool
- store inventories in weave
286
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
287
            if len(self.parents) > 1 and self.specific_files:
1704.2.11 by Martin Pool
Handle 'bzr commit DIR' when dir contains pending merges.
288
                raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
289
                        self.specific_files)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
290
            
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
291
            self.builder = self.branch.get_commit_builder(self.parents, 
292
                self.config, timestamp, timezone, committer, revprops, rev_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
293
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
294
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
295
            self._populate_new_inv()
1248 by Martin Pool
- new weave based cleanup [broken]
296
            self._report_deletes()
1245 by Martin Pool
doc
297
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
298
            self._check_pointless()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
299
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
300
            self._emit_progress_update()
1910.2.3 by Aaron Bentley
All tests pass
301
            # TODO: Now the new inventory is known, check for conflicts and
302
            # prompt the user for a commit message.
303
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
304
            # weave lines, because nothing should be recorded until it is known
305
            # that commit will succeed.
1740.3.8 by Jelmer Vernooij
Move make_revision() to commit builder.
306
            self.builder.finish_inventory()
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
307
            self._emit_progress_update()
2149.1.3 by Aaron Bentley
Updates from review comments
308
            message = message_callback(self)
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
309
            assert isinstance(message, unicode), type(message)
310
            self.message = message
311
            self._escape_commit_message()
312
1740.3.9 by Jelmer Vernooij
Make the commit message the first argument of CommitBuilder.commit().
313
            self.rev_id = self.builder.commit(self.message)
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
314
            self._emit_progress_update()
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
315
            # revision data is in the local branch now.
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
316
            
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
317
            # upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
318
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
319
            if self.bound_branch:
320
                self.master_branch.repository.fetch(self.branch.repository,
321
                                                    revision_id=self.rev_id)
322
                # now the master has the revision data
323
                # 'commit' to the master first so a timeout here causes the local
324
                # branch to be out of date
325
                self.master_branch.append_revision(self.rev_id)
326
327
            # and now do the commit locally.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
328
            self.branch.append_revision(self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
329
2041.1.5 by John Arbash Meinel
CommitBuilder.get_tree => CommitBuilder.revision_tree
330
            rev_tree = self.builder.revision_tree()
2041.1.2 by John Arbash Meinel
Update WorkingTree.set_parent_trees() to directly cache inv.
331
            self.work_tree.set_parent_trees([(self.rev_id, rev_tree)])
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
332
            # now the work tree is up to date with the branch
333
            
1607.1.5 by Robert Collins
Make commit verbose mode work!.
334
            self.reporter.completed(self.branch.revno(), self.rev_id)
1472 by Robert Collins
post commit hook, first pass implementation
335
            if self.config.post_commit() is not None:
336
                hooks = self.config.post_commit().split(' ')
337
                # this would be nicer with twisted.python.reflect.namedAny
338
                for hook in hooks:
339
                    result = eval(hook + '(branch, rev_id)',
340
                                  {'branch':self.branch,
341
                                   'bzrlib':bzrlib,
342
                                   'rev_id':self.rev_id})
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
343
            self._emit_progress_update()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
344
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
345
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
346
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
347
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
348
    def _any_real_changes(self):
349
        """Are there real changes between new_inventory and basis?
350
351
        For trees without rich roots, inv.root.revision changes every commit.
352
        But if that is the only change, we want to treat it as though there
353
        are *no* changes.
354
        """
355
        new_entries = self.builder.new_inventory.iter_entries()
356
        basis_entries = self.basis_inv.iter_entries()
357
        new_path, new_root_ie = new_entries.next()
358
        basis_path, basis_root_ie = basis_entries.next()
359
360
        # This is a copy of InventoryEntry.__eq__ only leaving out .revision
361
        def ie_equal_no_revision(this, other):
362
            return ((this.file_id == other.file_id)
363
                    and (this.name == other.name)
364
                    and (this.symlink_target == other.symlink_target)
365
                    and (this.text_sha1 == other.text_sha1)
366
                    and (this.text_size == other.text_size)
367
                    and (this.text_id == other.text_id)
368
                    and (this.parent_id == other.parent_id)
369
                    and (this.kind == other.kind)
370
                    and (this.executable == other.executable)
371
                    )
372
        if not ie_equal_no_revision(new_root_ie, basis_root_ie):
373
            return True
374
375
        for new_ie, basis_ie in zip(new_entries, basis_entries):
376
            if new_ie != basis_ie:
377
                return True
378
379
        # No actual changes present
380
        return False
381
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
382
    def _check_pointless(self):
383
        if self.allow_pointless:
384
            return
385
        # A merge with no effect on files
386
        if len(self.parents) > 1:
387
            return
388
        # work around the fact that a newly-initted tree does differ from its
389
        # basis
1731.1.49 by Aaron Bentley
Merge bzr.dev
390
        if len(self.basis_inv) == 0 and len(self.builder.new_inventory) == 1:
391
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
392
        # Shortcut, if the number of entries changes, then we obviously have
393
        # a change
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
394
        if len(self.builder.new_inventory) != len(self.basis_inv):
395
            return
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
396
        # If length == 1, then we only have the root entry. Which means
397
        # that there is no real difference (only the root could be different)
398
        if (len(self.builder.new_inventory) != 1 and self._any_real_changes()):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
399
            return
400
        raise PointlessCommit()
401
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
402
    def _check_bound_branch(self):
403
        """Check to see if the local branch is bound.
404
405
        If it is bound, then most of the commit will actually be
406
        done using the remote branch as the target branch.
407
        Only at the end will the local branch be updated.
408
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
409
        if self.local and not self.branch.get_bound_location():
410
            raise errors.LocalRequiresBoundBranch()
411
412
        if not self.local:
413
            self.master_branch = self.branch.get_master_branch()
414
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
415
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
416
            # make this branch the reference branch for out of date checks.
417
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
418
            return
419
420
        # If the master branch is bound, we must fail
421
        master_bound_location = self.master_branch.get_bound_location()
422
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
423
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
424
                    self.master_branch, master_bound_location)
425
426
        # TODO: jam 20051230 We could automatically push local
427
        #       commits to the remote branch if they would fit.
428
        #       But for now, just require remote to be identical
429
        #       to local.
430
        
431
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
432
        master_info = self.master_branch.last_revision_info()
433
        local_info = self.branch.last_revision_info()
434
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
435
            raise errors.BoundBranchOutOfDate(self.branch,
436
                    self.master_branch)
437
438
        # Now things are ready to change the master branch
439
        # so grab the lock
440
        self.bound_branch = self.branch
441
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
442
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
443
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
444
    def _cleanup(self):
445
        """Cleanup any open locks, progress bars etc."""
446
        cleanups = [self._cleanup_bound_branch,
447
                    self.work_tree.unlock,
448
                    self.pb.finished]
449
        found_exception = None
450
        for cleanup in cleanups:
451
            try:
452
                cleanup()
453
            # we want every cleanup to run no matter what.
454
            # so we have a catchall here, but we will raise the
455
            # last encountered exception up the stack: and
456
            # typically this will be useful enough.
457
            except Exception, e:
458
                found_exception = e
459
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
460
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
461
            # trashed, e is our sure-to-work exception even though it loses the
462
            # full traceback. XXX: RBC 20060421 perhaps we could check the
463
            # exc_info and if its the same one do a plain raise otherwise 
464
            # 'raise e' as we do now.
465
            raise e
466
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
467
    def _cleanup_bound_branch(self):
468
        """Executed at the end of a try/finally to cleanup a bound branch.
469
470
        If the branch wasn't bound, this is a no-op.
471
        If it was, it resents self.branch to the local branch, instead
472
        of being the master.
473
        """
474
        if not self.bound_branch:
475
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
476
        if self.master_locked:
477
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
478
1390 by Robert Collins
pair programming worx... merge integration and weave
479
    def _escape_commit_message(self):
480
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
481
        # FIXME: RBC 20060419 this should be done by the revision
482
        # serialiser not by commit. Then we can also add an unescaper
483
        # in the deserializer and start roundtripping revision messages
484
        # precisely. See repository_implementations/test_repository.py
485
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
486
        # Python strings can include characters that can't be
487
        # represented in well-formed XML; escape characters that
488
        # aren't listed in the XML specification
489
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
490
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
491
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
492
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
493
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
494
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
495
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
496
497
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
498
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
499
        # TODO: Make sure that this list doesn't contain duplicate 
500
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
501
        self.parents = self.work_tree.get_parent_ids()
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
502
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
503
        for revision in self.parents:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
504
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
505
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
506
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
507
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
508
            else:
509
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
510
1189 by Martin Pool
- BROKEN: partial support for commit into weave
511
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
512
        """Remove deleted files from the working inventories.
513
514
        This is done prior to taking the working inventory as the
515
        basis for the new committed inventory.
516
517
        This returns true if any files
518
        *that existed in the basis inventory* were deleted.
519
        Files that were added and deleted
520
        in the working copy don't matter.
521
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
522
        specific = self.specific_files
523
        deleted_ids = []
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
524
        deleted_paths = set()
1254 by Martin Pool
- fix handling of selective commit with deleted files
525
        for path, ie in self.work_inv.iter_entries():
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
526
            if is_inside_any(deleted_paths, path):
527
                # The tree will delete the required ids recursively.
528
                continue
1254 by Martin Pool
- fix handling of selective commit with deleted files
529
            if specific and not is_inside_any(specific, path):
530
                continue
531
            if not self.work_tree.has_filename(path):
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
532
                deleted_paths.add(path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
533
                self.reporter.missing(path)
1988.2.5 by Robert Collins
When an entire subtree has been deleted, commit will now report that
534
                deleted_ids.append(ie.file_id)
535
        self.work_tree.unversion(deleted_ids)
1248 by Martin Pool
- new weave based cleanup [broken]
536
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
537
    def _populate_new_inv(self):
538
        """Build revision inventory.
539
540
        This creates a new empty inventory. Depending on
541
        which files are selected for commit, and what is present in the
542
        current tree, the new inventory is populated. inventory entries 
543
        which are candidates for modification have their revision set to
544
        None; inventory entries that are carried over untouched have their
545
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
546
        """
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
547
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
548
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
549
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
550
        # ADHB 11-07-2006
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
551
        mutter("Selecting files for commit with filter %s", self.specific_files)
1731.1.64 by Aaron Bentley
Fix up more memorytree tests
552
        assert self.work_inv.root is not None
1910.2.4 by Aaron Bentley
Support old CommitBuilders
553
        entries = self.work_inv.iter_entries()
554
        if not self.builder.record_root_entry:
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
555
            symbol_versioning.warn('CommitBuilders should support recording'
556
                ' the root entry as of bzr 0.10.', DeprecationWarning, 
557
                stacklevel=1)
1910.2.4 by Aaron Bentley
Support old CommitBuilders
558
            self.builder.new_inventory.add(self.basis_inv.root.copy())
559
            entries.next()
560
            self._emit_progress_update()
561
        for path, new_ie in entries:
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
562
            self._emit_progress_update()
1249 by Martin Pool
- improvements to weave commit [broken]
563
            file_id = new_ie.file_id
1959.4.2 by Aaron Bentley
Merge bzr.dev
564
            try:
565
                kind = self.work_tree.kind(file_id)
566
                if kind != new_ie.kind:
1959.4.4 by Aaron Bentley
Trim trailing whitespace
567
                    new_ie = inventory.make_entry(kind, new_ie.name,
1959.4.2 by Aaron Bentley
Merge bzr.dev
568
                                                  new_ie.parent_id, file_id)
569
            except errors.NoSuchFile:
570
                pass
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
571
            # mutter('check %s {%s}', path, file_id)
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
572
            if (not self.specific_files or 
573
                is_inside_or_parent_of_any(self.specific_files, path)):
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
574
                    # mutter('%s selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
575
                    ie = new_ie.copy()
576
                    ie.revision = None
1740.3.5 by Jelmer Vernooij
Simplify inventory population code by using is_inside_or_parent_of_any()
577
            else:
1711.2.101 by John Arbash Meinel
Clean up some unnecessary mutter() calls
578
                # mutter('%s not selected for commit', path)
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
579
                if self.basis_inv.has_id(file_id):
580
                    ie = self.basis_inv[file_id].copy()
581
                else:
582
                    # this entry is new and not being committed
583
                    continue
1731.1.62 by Aaron Bentley
Changes from review comments
584
            self.builder.record_entry_contents(ie, self.parent_invs, 
585
                path, self.work_tree)
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
586
            # describe the nature of the change that has occurred relative to
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
587
            # the basis inventory.
588
            if (self.basis_inv.has_id(ie.file_id)):
589
                basis_ie = self.basis_inv[ie.file_id]
590
            else:
591
                basis_ie = None
592
            change = ie.describe_change(basis_ie, ie)
593
            if change in (InventoryEntry.RENAMED, 
594
                InventoryEntry.MODIFIED_AND_RENAMED):
595
                old_path = self.basis_inv.id2path(ie.file_id)
596
                self.reporter.renamed(change, old_path, path)
597
            else:
598
                self.reporter.snapshot_change(change, path)
1416 by Robert Collins
when committing a specific file, include all its parents
599
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
600
        if not self.specific_files:
601
            return
602
603
        # ignore removals that don't match filespec
604
        for path, new_ie in self.basis_inv.iter_entries():
605
            if new_ie.file_id in self.work_inv:
606
                continue
607
            if is_inside_any(self.specific_files, path):
608
                continue
609
            ie = new_ie.copy()
610
            ie.revision = None
611
            self.builder.record_entry_contents(ie, self.parent_invs, path,
612
                                               self.basis_tree)
613
1666.1.22 by Robert Collins
Rename Commit._update to _emit_progress_update.
614
    def _emit_progress_update(self):
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
615
        """Emit an update to the progress bar."""
616
        self.pb.update("Committing", self.pb_count, self.pb_total)
617
        self.pb_count += 1
618
1248 by Martin Pool
- new weave based cleanup [broken]
619
    def _report_deletes(self):
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
620
        for path, ie in self.basis_inv.iter_entries():
1740.3.4 by Jelmer Vernooij
Move inventory to commit builder.
621
            if ie.file_id not in self.builder.new_inventory:
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
622
                self.reporter.deleted(path)
1248 by Martin Pool
- new weave based cleanup [broken]
623
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
624