~bzr-pqm/bzr/bzr.dev

932 by Martin Pool
- more diff TODOs
1
.. -*- mode: indented-text; compile-command: "make -C doc" -*-
321 by Martin Pool
doc: revfile storage and related things
2
3
4
*******************
5
Things to do in bzr
6
*******************
7
287 by Martin Pool
- todo: plugins
8
293 by Martin Pool
- todos
9
See also various low-level TODOs in the source code.  Try looking in
284 by Martin Pool
- more TODO items
10
the list archive or on gmane.org for previous discussion of these
293 by Martin Pool
- todos
11
issues.
12
13
These are classified by approximate size: an hour or less, a day or
14
less, and several days or more.
15
282 by Martin Pool
- move all TODO items into ./TODO
16
17
Small things
18
------------
19
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
20
* ``bzr status`` should show some description of patches that are merged but 
21
  not yet committed.  Preferably in a very compact format so that they
22
  just fit on a single line; this could also be used for say ``log
23
  --tiny``::
24
25
  2005-11-05      mbp  Flowers for stephane
26
974.1.86 by Aaron Bentley
Added false 'module does not exist' messages to TODO
27
* Fix tests so that import errors caused by modules don't produce false reports
28
  that the tests themselves don't exist.
29
974.1.92 by Aaron Bentley
TODO re tests
30
* Fix tests so that one test failure doesn't prevent other tests from running
31
1171 by Martin Pool
- typo fixes from kfish
32
* print a message at the end of running the tests telling them that the
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
33
  test log and output exists but can be removed
34
35
* tests for running the commit editor, and fix problem of not passing in 
36
  multiple arguments
975 by Martin Pool
- more checks for some operations in subdirectories
37
852 by Martin Pool
todo
38
* Merging add of a new file clashing with an existing file doesn't
39
  work; add gets an error that it's already versioned and the merge
932 by Martin Pool
- more diff TODOs
40
  aborts.
852 by Martin Pool
todo
41
850 by Martin Pool
- Merge merge updates from aaron
42
* Merge should ignore the destination's working directory, otherwise
43
  we get an error about the statcache when pulling from a remote
44
  branch.
45
282 by Martin Pool
- move all TODO items into ./TODO
46
* Add of a file that was present in the base revision should put back
47
  the previous file-id.
48
914 by Martin Pool
- fix up breakage of 'bzr log -v' by root_id patch
49
* Not sure I'm happy with needing to pass a root id to EmptyTree;
50
  comparing anything against an EmptyTree with no root should have the
51
  same effect(?)
52
282 by Martin Pool
- move all TODO items into ./TODO
53
* Handle diff of files which do not have a trailing newline; probably
54
  requires patching difflib to get it exactly right, or otherwise
55
  calling out to GNU diff.
56
902 by Martin Pool
todo
57
* Should be able to copy files between branches to preserve their
58
  file-id (and perhaps eventually parentage.)
59
289 by Martin Pool
todo
60
* -r option should take a revision-id as well as a revno.
61
903 by Martin Pool
todo
62
* allow ``bzr st -r 300`` to show a summary of changes since then.
63
322 by Martin Pool
- update todo list
64
* ``bzr info`` should count only people with distinct email addresses as
290 by Martin Pool
todo
65
  different committers.  (Or perhaps only distinct userids?)
66
322 by Martin Pool
- update todo list
67
* On Windows, command-line arguments should be `glob-expanded`__,
293 by Martin Pool
- todos
68
  because the shell doesn't do this.  However, there are probably some
69
  commands where this shouldn't be done, such as 'bzr ignore', because
70
  we want to accept globs.
71
329 by Martin Pool
- refactor command functions into command classes
72
* ``bzr ignore`` command that just adds a line to the ``.bzrignore`` file
73
  and makes it versioned.  Fix this to break symlinks.
295 by Martin Pool
todo
74
312 by Martin Pool
todo
75
* Any useful sanity checks in 'bzr ignore'?  Perhaps give a warning if
76
  they try to add a single file which is already versioned, or if they
77
  add a pattern which already exists, or if it looks like they gave an
78
  unquoted glob.
310 by Martin Pool
- new 'bzr ignored' command!
79
325 by Martin Pool
- more revfile design notes
80
__ http://mail.python.org/pipermail/python-list/2001-April/037847.html
81
327 by Martin Pool
todo
82
* Separate read and write version checks?
325 by Martin Pool
- more revfile design notes
83
405 by Martin Pool
todo
84
* ``bzr status DIR`` should give status on all files under that
85
  directory.
86
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
87
* ``bzr log DIR`` should give changes to any files within DIR; at the
88
  moment it only lists things which modify the specific named file
89
  (and not its contents)
484 by Martin Pool
todo
90
329 by Martin Pool
- refactor command functions into command classes
91
* ``bzr inventory -r REV`` and perhaps unify this with ``bzr ls``,
92
  giving options to display ids, types, etc.
93
341 by Martin Pool
todo
94
* Split BzrError into various more specific subclasses for different
95
  errors people might want to catch.
326 by Martin Pool
todo
96
393 by Martin Pool
todo: export to tarball
97
* If the export destination ends in '.tar', '.tar.gz', etc then create
98
  a tarball instead of a directory.  (Need to actually make a
99
  temporary directory and then tar that up.)
100
101
  http://www.gelato.unsw.edu.au/archives/git/0504/2194.html
932 by Martin Pool
- more diff TODOs
102
414 by Martin Pool
todo
103
* RemoteBranch could maintain a cache either in memory or on disk.  We
104
  know more than an external cache might about which files are
105
  immutable and which can vary.  On the other hand, it's much simpler
106
  to just use an external proxy cache.
107
586 by Martin Pool
todo
108
  Perhaps ~/.bzr/http-cache.  Baz has a fairly simple cache under
109
  ~/.arch-cache, containing revision information encoded almost as a
110
  bunch of archives.  Perhaps we could simply store full paths.
111
487 by Martin Pool
todo
112
* Maybe also store directories in the statcache so that we can quickly
113
  identify that they still exist.
114
570 by Martin Pool
doc
115
* Diff should show timestamps; for files from the working directory we
116
  can use the file itself; for files from a revision we should use the
117
  commit time of the revision.
118
593 by Martin Pool
todo
119
* Perhaps split command infrastructure from the actual command
120
  definitions.
121
122
* Cleaner support for negative boolean options like --no-recurse.
123
603 by Martin Pool
doc
124
* Statcache should possibly map all file paths to / separators
125
642 by Martin Pool
- notes on patches for Windows
126
* quotefn doubles all backslashes on Windows; this is probably not the
127
  best thing to do.  What would be a better way to safely represent
128
  filenames?  Perhaps we could doublequote things containing spaces,
129
  on the principle that filenames containing quotes are unlikely?
130
  Nice for humans; less good for machine parsing.
131
132
* Patches should probably use only forward slashes, even on Windows,
932 by Martin Pool
- more diff TODOs
133
  otherwise Unix patch can't apply them. (?)
642 by Martin Pool
- notes on patches for Windows
134
665 by Martin Pool
todo
135
* Branch.update_revisions() inefficiently fetches revisions from the
136
  remote server twice; once to find out what text and inventory they
137
  need and then again to actually get the thing.  This is a bit
932 by Martin Pool
- more diff TODOs
138
  inefficient.
665 by Martin Pool
todo
139
140
  One complicating factor here is that we don't really want to have
141
  revisions present in the revision-store until all their constituent
142
  parts are also stored.
143
144
  The basic problem is that RemoteBranch.get_revision() and similar
145
  methods return object, but what we really want is the raw XML, which
146
  can be popped into our own store.  That needs to be refactored.
691 by Martin Pool
todo
147
148
* ``bzr status FOO`` where foo is ignored should say so.
724 by Martin Pool
- todo: bzr mkdir
149
150
* ``bzr mkdir A...`` should just create and add A.
818 by Martin Pool
- Clear pending-merge list when committing.
151
152
* Guard against repeatedly merging any particular patch.
932 by Martin Pool
- more diff TODOs
153
154
* More options for diff:
155
156
  - diff two revisions of the same tree
157
158
  - diff two different branches, optionally at different revisions
159
160
  - diff a particular file in another tree against the corresponding
161
    version in this tree (which should be the default if the second
162
    parameter is a tree root)
163
164
  - diff everything under a particular directory, in any of the above
165
    ways
166
167
  - diff two files inside the same tree, even if they have different
168
    ids
169
170
  - and, of course, tests for all this
171
967 by Martin Pool
todo
172
* Reproducible performance benchmark to measure whether performance is 
173
  getting better or worse.
665 by Martin Pool
todo
174
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
175
* ``bzr log -m foo`` should perhaps error if nothing matches?
176
177
* ``bzr diff -r 30 -r 40 foo.c`` or ``bzr diff -r30..40 foo.c``
178
179
  If diffing between two branches then we probably want two -r
180
  options, since the revisions don't form a range that can be
181
  evaluated on either one.
182
183
* bzr diff shouldn't diff binary files
184
185
* setup.py install when run from a bzr tree should freeze the tree
186
  revision-id into the installed bzr.
187
188
* bzr script should trap ImportError and perhaps give a better error
189
  message?
190
191
* revert after a merge should possibly remove all the BASE/THIS/OTHER
192
  files to get you back to where you were.
193
194
* files that are added and then deleted are still reported as added
195
196
* stores should raise KeyError, not IndexError
197
198
* merging from a remote branch seems to sometimes raise errors not
199
  present locally
200
201
* should be possible to give a related branch when pulling from a
202
  remote branch to make things faster
203
204
* sometimes gives "conflicting add" even when the contents are in fact
205
  the same???
206
1092.1.27 by Robert Collins
two bugfixes to smart_add - do not add paths from nested trees to the parent tree, and do not mutate the user supplied file list
207
* BZRDIR should be in branch.py not __init__.py.
414 by Martin Pool
todo
208
1185.1.11 by Robert Collins
fixme note for bzr status
209
* ``status `` should accept a -r option to show changes relative to a revision,
210
  or between revisions
211
282 by Martin Pool
- move all TODO items into ./TODO
212
Medium things
213
-------------
214
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
215
* ~/.bzr.log is not written anymore for some reason.
216
217
* merge should add all revision and inventory XML to the local store.
218
219
* check should give a warning for revisions that are named in the
220
  chain but not actually present in the store.
221
222
* remove anything outside of the branch implementation that directly
223
  accesses the stores.
282 by Martin Pool
- move all TODO items into ./TODO
224
478 by Martin Pool
- put back support for running diff or status on
225
* More efficient diff of only selected files.  We should be able to
226
  just get the id for the selected files, look up their location and
227
  diff just those files.  No need to traverse the entire inventories.
282 by Martin Pool
- move all TODO items into ./TODO
228
479 by Martin Pool
todo
229
* ``bzr status DIR`` or ``bzr diff DIR`` should report on all changes
230
  under that directory.
231
282 by Martin Pool
- move all TODO items into ./TODO
232
* Fix up Inventory objects to represent root object as an entry.
233
552 by Martin Pool
- update todo list
234
* Don't convert entire entry from ElementTree to an object when it is
235
  read in, but rather wait until the program actually wants to know
236
  about that node.
282 by Martin Pool
- move all TODO items into ./TODO
237
238
* Extract changes from one revision to the next to a text form
239
  suitable for transmission over email.
240
241
* More test cases.
242
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
243
  - ``missing`` command
244
491 by Martin Pool
- Selective commit!
245
  - Selected-file commit
246
247
  - Impossible selected-file commit: adding things in non-versioned
248
    directories, crossing renames, etc.
249
282 by Martin Pool
- move all TODO items into ./TODO
250
* Write a reproducible benchmark, perhaps importing various kernel versions.
251
252
* Directly import diffs!  It seems a bit redundant to need to rescan
253
  the directory to work out what files diff added/deleted/changed when
254
  all the information is there in the diff in the first place.
255
  Getting the exact behaviour for added/deleted subdirectories etc
256
  might be hard.
257
258
  At the very least we could run diffstat over the diff, or perhaps
259
  read the status output from patch.  Just knowing which files might
260
  be modified would be enough to guide the add and commit.
932 by Martin Pool
- more diff TODOs
261
282 by Martin Pool
- move all TODO items into ./TODO
262
  Given this we might be able to import patches at 1/second or better.
263
264
* revfile compression.
265
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
266
* Split inventory into per-directory files?
282 by Martin Pool
- move all TODO items into ./TODO
267
284 by Martin Pool
- more TODO items
268
* Fix ignore file parsing:
269
270
  - fnmatch is not the same as unix patterns
271
272
  - perhaps add extended globs from rsh/rsync
273
274
  - perhaps a pattern that matches only directories or non-directories
275
312 by Martin Pool
todo
276
* Consider using Python logging library as well as/instead of
277
  bzrlib.trace.
278
334 by Martin Pool
doc
279
* Commands should give some progress indication by default.
280
281
  - But quieten this with ``--silent``.
282
312 by Martin Pool
todo
283
* Change to using gettext message localization.
282 by Martin Pool
- move all TODO items into ./TODO
284
315 by Martin Pool
todo
285
* Make a clearer separation between internal and external bzrlib
286
  interfaces.  Make internal interfaces use protected names.  Write at
287
  least some documentation for those APIs, probably as docstrings.
288
289
  Consider using ZopeInterface definitions for the external interface;
290
  I think these are already used in PyBaz.  They allow automatic
291
  checking of the interface but may be unfamiliar to general Python
321 by Martin Pool
doc: revfile storage and related things
292
  developers, so I'm not really keen.
315 by Martin Pool
todo
293
294
* Commands to dump out all command help into a manpage or HTML file or
295
  whatever.
296
326 by Martin Pool
todo
297
* Handle symlinks in the working directory; at the very least it
298
  should be possible for them to be present and ignored/unknown
932 by Martin Pool
- more diff TODOs
299
  without causing assertion failures.
326 by Martin Pool
todo
300
301
  Eventually symlinks should be versioned.
302
329 by Martin Pool
- refactor command functions into command classes
303
* Allow init in a subdirectory to create a nested repository, but only
304
  if the subdirectory is not already versioned.   Perhaps also require
305
  a ``--nested`` to protect against confusion.
306
932 by Martin Pool
- more diff TODOs
307
* Branch names?
329 by Martin Pool
- refactor command functions into command classes
308
339 by Martin Pool
many more diffs
309
* More test framework:
310
311
  - Class that describes the state of a working tree so we can just
312
    assert it's equal.
313
342 by Martin Pool
todo
314
* There are too many methods on Branch() that really manipulate the
932 by Martin Pool
- more diff TODOs
315
  WorkingTree.  They should be moved across.
346 by Martin Pool
todo
316
317
  Also there are some methods which are duplicated on Tree and
318
  Inventory objects, and it should be made more clear which ones are
319
  proxies and which ones behave differently, and how.
342 by Martin Pool
todo
320
361 by Martin Pool
todo
321
* Try using XSLT to add some formatting to REST-generated HTML.  Or
322
  maybe write a small Python program that specifies a header and foot
323
  for the pages and calls into the docutils libraries.
324
366 by Martin Pool
todo
325
* --format=xml for log, status and other commands.
329 by Martin Pool
- refactor command functions into command classes
326
370 by Martin Pool
todo
327
* Attempting to explicitly add a file that's already added should give
328
  a warning; however there should be no warning for directories (since
329
  we scan for new children) or files encountered in a directory that's
330
  being scanned.
329 by Martin Pool
- refactor command functions into command classes
331
377 by Martin Pool
- todo notes on inventory
332
* Better handling of possible collisions on case-losing filesystems;
333
  make sure a single file does not get added twice under different
334
  names.
335
336
* Clean up XML inventory:
337
338
  - Use nesting rather than parent_id pointers.
339
340
  - Hold the ElementTree in memory in the Inventory object and work
341
    directly on that, rather than converting into Python objects every
453 by Martin Pool
- Split WorkingTree into its own file
342
    time it is read in.  Probably still exposoe it through some kind of
377 by Martin Pool
- todo notes on inventory
343
    object interface though, but perhaps that should just be a proxy
344
    for the elements.
345
932 by Martin Pool
- more diff TODOs
346
  - Less special cases for the root directory.
377 by Martin Pool
- todo notes on inventory
347
388 by Martin Pool
doc
348
* Perhaps inventories should remember the revision in which each file
349
  was last changed, as well as its current state?  This is a bit
350
  redundant but might often be interested to know.
351
442 by Martin Pool
todo
352
* stat cache should perhaps only stat files as necessary, rather than
353
  doing them all up-front.  On the other hand, that disallows the
354
  opimization of stating them in inode order.
355
451 by Martin Pool
todo
356
* It'd be nice to pipeline multiple HTTP requests.  Often we can
357
  predict what will be wanted in future: all revisions, or all texts
932 by Martin Pool
- more diff TODOs
358
  in a particular revision, etc.
451 by Martin Pool
todo
359
360
  urlgrabber's docs say they are working on batched downloads; we
361
  could perhaps ride on that or just create a background thread (ew).
362
459 by Martin Pool
- diff now uses stat-cache -- much faster
363
* Paranoid mode where we never trust SHA-1 matches.
364
502 by Martin Pool
todo
365
* Don't commit if there are no changes unless forced.
366
522 by Martin Pool
todo
367
* --dry-run mode for commit?  (Or maybe just run with
368
  check-command=false?)
502 by Martin Pool
todo
369
370
* Generally, be a bit more verbose unless --silent is specified.
371
522 by Martin Pool
todo
372
* Function that finds all changes to files under a given directory;
373
  perhaps log should use this if a directory is given.
374
548 by Martin Pool
- Write statcache using \u style encoding to avoid
375
* XML attributes might have trouble with filenames containing \n and
376
  \r.  Do we really want to support this?  I think perhaps not.
377
574 by Martin Pool
todo
378
* Remember execute bits, so that exports will work OK.
379
579 by Martin Pool
todo
380
* Unify smart_add and plain Branch.add(); perhaps smart_add should
381
  just build a list of files to add and pass that to the regular add
382
  function.
383
604 by Martin Pool
doc
384
* Function to list a directory, saying in which revision each file was
385
  last modified.  Useful for web and gui interfaces, and slow to
386
  compute one file at a time.
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
387
  
388
  This will be done when we track file texts by referring to the
389
  version that created them. 
609 by Martin Pool
- cleanup test code
390
627 by Martin Pool
todo
391
* Check locking is correct during merge-related operations.
392
629 by Martin Pool
todo
393
* Perhaps attempts to get locks should timeout after some period of
394
  time, or at least display a progress message.
395
702 by Martin Pool
todo: bzr upgrade
396
* Split out upgrade functionality from check command into a separate
397
  ``bzr upgrade``.
398
738 by Martin Pool
- default plugin dir is ~/.bzr.conf/plugins
399
* Don't pass around command classes but rather pass objects.  This'd
400
  make it cleaner to construct objects wrapping external commands.
401
818 by Martin Pool
- Clear pending-merge list when committing.
402
* Track all merged-in revisions in a versioned add-only metafile.
403
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
404
* ``pull --clobber`` should discard any local changes not present
405
  remotely.  Not generally what you want, but possibly useful when
406
  you're just mirroring another branch and want to keep tracking it
407
  even when they e.g. uncommit or make similar non-forward movements.
408
  Also for push I suppose.  Clobber may not be the best name, maybe
409
  ``--destroy``?
410
411
* ``uncommit`` command that removes a revision from the end of the
412
  revision-history; just doing this is enough to remove the commit,
413
  and a new commit will automatically be made against the
414
  predecessor.  This can be repeated.
415
416
  It only makes sense to delete from the tail of history, not from the
417
  end.
418
419
  The revision, its inventory and texts remain floating in the store.
420
  We should perhaps add the revision to a list of removed-commits, so
421
  that it can be restored or at least accounted for when checking
422
  consistency.  This file would not be versioned, and probably should
423
  not propagate when branched.
424
425
  If we track merged revisions then we need to update this list too.
426
  If the list is stored in a weave it's easy (implicit): the version
427
  of the list can remain but it won't be referenced anymore.  It's
428
  probably best to just store this list in a weave in the first place
429
  and be done.
430
315 by Martin Pool
todo
431
282 by Martin Pool
- move all TODO items into ./TODO
432
Large things
433
------------
434
321 by Martin Pool
doc: revfile storage and related things
435
* Generate annotations from current file relative to previous
436
  annotations.
437
438
  - Is it necessary to store any kind of annotation where data was
439
    deleted?
440
325 by Martin Pool
- more revfile design notes
441
* Update revfile_ format and make it active:
321 by Martin Pool
doc: revfile storage and related things
442
443
  - Texts should be identified by something keyed on the revision, not
444
    an individual text-id.  This is much more useful for annotate I
445
    think; we want to map back to the revision that last changed it.
446
447
  - Access revfile revisions through the Tree/Store classes.
448
449
  - Check them from check commands.
450
451
  - Store annotations.
452
325 by Martin Pool
- more revfile design notes
453
.. _revfile: revfile.html
454
294 by Martin Pool
todo
455
* Hooks for pre-commit, post-commit, etc.
456
457
  Consider the security implications; probably should not enable hooks
458
  for remotely-fetched branches by default.
459
460
* Pre-commit check.  If this hook is defined, it needs to be handled
461
  specially: create a temporary directory containing the tree as it
462
  will be after the commit.  This means excluding any ignored/unknown
463
  files, and respecting selective commits.  Run the pre-commit check
464
  (e.g. compile and run test suite) in there.
465
519 by Martin Pool
- todo: discussion of pre-commit tests
466
  Possibly this should be done by splitting the commit function into
467
  several parts (under a single interface).  It is already rather
468
  large.  Decomposition:
469
470
   - find tree modifications and prepare in-memory inventory
471
472
   - export that inventory to a temporary directory
473
474
   - run the test in that temporary directory
475
476
   - if that succeeded, continue to actually finish the commit
477
478
  What should be done with the text of modified files while this is
479
  underway?  I don't think we want to count on holding them in memory
480
  and we can't trust the working files to stay in one place so I
481
  suppose we need to move them into the text store, or otherwise into
482
  a temporary directory.
483
484
  If the commit does not actually complete, we would rather the
932 by Martin Pool
- more diff TODOs
485
  content was not left behind in the stores.
519 by Martin Pool
- todo: discussion of pre-commit tests
486
282 by Martin Pool
- move all TODO items into ./TODO
487
* Web interface
488
489
* GUI (maybe in Python GTK+?)
490
284 by Martin Pool
- more TODO items
491
* C library interface
321 by Martin Pool
doc: revfile storage and related things
492
493
* Expansion of $Id$ keywords within working files.  Perhaps do this in
494
  exports first as a simpler case because then we don't need to deal
495
  with removing the tags on the way back in.
496
329 by Martin Pool
- refactor command functions into command classes
497
* ``bzr find``