~bzr-pqm/bzr/bzr.dev

485 by Martin Pool
- move commit code into its own module
1
# Copyright (C) 2005 Canonical Ltd
1248 by Martin Pool
- new weave based cleanup [broken]
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1339 by Martin Pool
- doc
47
# TODO: Rather than mashing together the ancestry and storing it back,
48
# perhaps the weave should have single method which does it all in one
49
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
50
1341 by Martin Pool
- doc
51
# TODO: Perhaps give a warning if one of the revisions marked as
52
# merged is already in the ancestry, and then don't record it as a
53
# distinct parent.
54
1343 by Martin Pool
- fix up test for merge of trees
55
# TODO: If the file is newly merged but unchanged from the version it
56
# merges from, then it should still be reported as newly added
57
# relative to the basis revision.
58
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
59
1189 by Martin Pool
- BROKEN: partial support for commit into weave
60
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
61
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
62
import sys
1188 by Martin Pool
- clean up imports in commit code
63
import time
1248 by Martin Pool
- new weave based cleanup [broken]
64
import pdb
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
65
1188 by Martin Pool
- clean up imports in commit code
66
from binascii import hexlify
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
67
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
68
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
69
from bzrlib.osutils import (local_time_offset,
70
                            rand_bytes, compact_date,
1188 by Martin Pool
- clean up imports in commit code
71
                            kind_marker, is_inside_any, quotefn,
1248 by Martin Pool
- new weave based cleanup [broken]
72
                            sha_string, sha_strings, sha_file, isdir, isfile,
73
                            split_lines)
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
74
from bzrlib.branch import gen_file_id
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
75
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
76
from bzrlib.errors import (BzrError, PointlessCommit,
77
                           HistoryMissing,
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
78
                           ConflictsInTree
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
79
                           )
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
80
import bzrlib.gpg as gpg
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
81
from bzrlib.revision import Revision
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
82
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
83
from bzrlib.xml5 import serializer_v5
1416 by Robert Collins
when committing a specific file, include all its parents
84
from bzrlib.inventory import Inventory, ROOT_ID
1189 by Martin Pool
- BROKEN: partial support for commit into weave
85
from bzrlib.weave import Weave
86
from bzrlib.weavefile import read_weave, write_weave_v5
87
from bzrlib.atomicfile import AtomicFile
88
89
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
90
def commit(*args, **kwargs):
91
    """Commit a new revision to a branch.
92
93
    Function-style interface for convenience of old callers.
94
95
    New code should use the Commit class instead.
96
    """
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
97
    ## XXX: Remove this in favor of Branch.commit?
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
98
    Commit().commit(*args, **kwargs)
99
100
1189 by Martin Pool
- BROKEN: partial support for commit into weave
101
class NullCommitReporter(object):
102
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
103
104
    def snapshot_change(self, change, path):
105
        pass
106
107
    def completed(self, revno, rev_id):
108
        pass
109
110
    def deleted(self, file_id):
111
        pass
112
113
    def escaped(self, escape_count, message):
114
        pass
115
116
    def missing(self, path):
117
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
118
119
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
120
121
    def snapshot_change(self, change, path):
122
        note("%s %s", change, path)
123
124
    def completed(self, revno, rev_id):
125
        note('committed r%d {%s}', revno, rev_id)
126
    
127
    def deleted(self, file_id):
128
        note('deleted %s', file_id)
129
130
    def escaped(self, escape_count, message):
131
        note("replaced %d control characters in message", escape_count)
132
133
    def missing(self, path):
134
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
135
136
class Commit(object):
137
    """Task of committing a new revision.
138
139
    This is a MethodObject: it accumulates state as the commit is
140
    prepared, and then it is discarded.  It doesn't represent
141
    historical revisions, just the act of recording a new one.
142
143
            missing_ids
144
            Modified to hold a list of files that have been deleted from
145
            the working directory; these should be removed from the
146
            working inventory.
485 by Martin Pool
- move commit code into its own module
147
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
148
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
149
                 reporter=None,
150
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
151
        if reporter is not None:
152
            self.reporter = reporter
153
        else:
154
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
155
        if config is not None:
156
            self.config = config
157
        else:
158
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
159
        
160
    def commit(self,
161
               branch, message,
162
               timestamp=None,
163
               timezone=None,
164
               committer=None,
165
               specific_files=None,
166
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
167
               allow_pointless=True,
1185.16.35 by Martin Pool
- stub for revision properties
168
               verbose=False,
169
               revprops=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
        """Commit working copy as a new revision.
171
172
        timestamp -- if not None, seconds-since-epoch for a
173
             postdated/predated commit.
174
1253 by Martin Pool
- test that pointless commits are trapped
175
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
176
1253 by Martin Pool
- test that pointless commits are trapped
177
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
178
            Useful for test or import commands that need to tightly
179
            control what revisions are assigned.  If you duplicate
180
            a revision id that exists elsewhere it is your own fault.
181
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
182
183
        allow_pointless -- If true (default), commit even if nothing
184
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
185
186
        revprops -- Properties for new revision
1189 by Martin Pool
- BROKEN: partial support for commit into weave
187
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
188
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
189
190
        self.branch = branch
1248 by Martin Pool
- new weave based cleanup [broken]
191
        self.weave_store = branch.weave_store
1189 by Martin Pool
- BROKEN: partial support for commit into weave
192
        self.rev_id = rev_id
193
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
194
        self.allow_pointless = allow_pointless
1185.16.35 by Martin Pool
- stub for revision properties
195
        self.revprops = revprops
1189 by Martin Pool
- BROKEN: partial support for commit into weave
196
197
        if timestamp is None:
198
            self.timestamp = time.time()
199
        else:
200
            self.timestamp = long(timestamp)
201
            
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
202
        if self.config is None:
203
            self.config = bzrlib.config.BranchConfig(self.branch)
204
1248 by Martin Pool
- new weave based cleanup [broken]
205
        if rev_id is None:
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
206
            self.rev_id = _gen_revision_id(self.config, self.timestamp)
1248 by Martin Pool
- new weave based cleanup [broken]
207
        else:
208
            self.rev_id = rev_id
209
1189 by Martin Pool
- BROKEN: partial support for commit into weave
210
        if committer is None:
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
211
            self.committer = self.config.username()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
212
        else:
213
            assert isinstance(committer, basestring), type(committer)
214
            self.committer = committer
215
216
        if timezone is None:
217
            self.timezone = local_time_offset()
218
        else:
219
            self.timezone = int(timezone)
220
221
        assert isinstance(message, basestring), type(message)
222
        self.message = message
1390 by Robert Collins
pair programming worx... merge integration and weave
223
        self._escape_commit_message()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
224
1245 by Martin Pool
doc
225
        self.branch.lock_write()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
226
        try:
227
            self.work_tree = self.branch.working_tree()
228
            self.work_inv = self.work_tree.inventory
229
            self.basis_tree = self.branch.basis_tree()
230
            self.basis_inv = self.basis_tree.inventory
231
1223 by Martin Pool
- store inventories in weave
232
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
233
            if len(self.parents) > 1 and self.specific_files:
234
                raise NotImplementedError('selected-file commit of merges is not supported yet')
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
235
            self._check_parents_present()
236
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
237
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
238
            self._populate_new_inv()
239
            self._store_snapshot()
1248 by Martin Pool
- new weave based cleanup [broken]
240
            self._report_deletes()
1245 by Martin Pool
doc
241
1248 by Martin Pool
- new weave based cleanup [broken]
242
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
243
                    or len(self.parents) > 1
1249 by Martin Pool
- improvements to weave commit [broken]
244
                    or self.new_inv != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
245
                raise PointlessCommit()
246
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
247
            if len(list(self.work_tree.iter_conflicts()))>0:
248
                raise ConflictsInTree
249
1189 by Martin Pool
- BROKEN: partial support for commit into weave
250
            self._record_inventory()
251
            self._make_revision()
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
252
            self.reporter.completed(self.branch.revno()+1, self.rev_id)
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
253
            self.branch.append_revision(self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
254
            self.branch.set_pending_merges([])
255
        finally:
256
            self.branch.unlock()
257
258
    def _record_inventory(self):
1223 by Martin Pool
- store inventories in weave
259
        """Store the inventory for the new revision."""
1248 by Martin Pool
- new weave based cleanup [broken]
260
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
261
        self.inv_sha1 = sha_string(inv_text)
1390 by Robert Collins
pair programming worx... merge integration and weave
262
        s = self.branch.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
263
        s.add_text('inventory', self.rev_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
264
                   split_lines(inv_text), self.present_parents,
265
                   self.branch.get_transaction())
1223 by Martin Pool
- store inventories in weave
266
1390 by Robert Collins
pair programming worx... merge integration and weave
267
    def _escape_commit_message(self):
268
        """Replace xml-incompatible control characters."""
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
269
        # Python strings can include characters that can't be
270
        # represented in well-formed XML; escape characters that
271
        # aren't listed in the XML specification
272
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
273
        if isinstance(self.message, unicode):
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
274
            char_pattern = u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]'
275
        else:
276
            # Use a regular 'str' as pattern to avoid having re.subn
277
            # return 'unicode' results.
278
            char_pattern = '[^x09\x0A\x0D\x20-\xFF]'
1390 by Robert Collins
pair programming worx... merge integration and weave
279
        self.message, escape_count = re.subn(
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
280
            char_pattern,
281
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
282
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
283
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
284
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
285
286
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
287
        """Record the parents of a merge for merge detection."""
1223 by Martin Pool
- store inventories in weave
288
        pending_merges = self.branch.pending_merges()
289
        self.parents = []
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
290
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
291
        self.present_parents = []
1241 by Martin Pool
- rename last_patch to last_revision
292
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
293
        if precursor_id:
294
            self.parents.append(precursor_id)
295
        self.parents += pending_merges
1092.2.25 by Robert Collins
support ghosts in commits
296
        for revision in self.parents:
297
            if self.branch.has_revision(revision):
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
298
                self.parent_invs.append(self.branch.get_inventory(revision))
1092.2.25 by Robert Collins
support ghosts in commits
299
                self.present_parents.append(revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
300
301
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
302
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
303
            mutter('commit parent revision {%s}', parent_id)
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
304
            if not self.branch.has_revision(parent_id):
1092.2.25 by Robert Collins
support ghosts in commits
305
                if parent_id == self.branch.last_revision():
1185.12.9 by Aaron Bentley
Removed crude language
306
                    warning("parent is missing %r", parent_id)
1092.2.25 by Robert Collins
support ghosts in commits
307
                    raise HistoryMissing(self.branch, 'revision', parent_id)
308
                else:
309
                    mutter("commit will ghost revision %r", parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
310
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
311
    def _make_revision(self):
312
        """Record a new revision object for this commit."""
313
        self.rev = Revision(timestamp=self.timestamp,
314
                            timezone=self.timezone,
315
                            committer=self.committer,
316
                            message=self.message,
317
                            inventory_sha1=self.inv_sha1,
1185.16.35 by Martin Pool
- stub for revision properties
318
                            revision_id=self.rev_id,
319
                            properties=self.revprops)
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
320
        self.rev.parent_ids = self.parents
1248 by Martin Pool
- new weave based cleanup [broken]
321
        rev_tmp = StringIO()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
322
        serializer_v5.write_revision(self.rev, rev_tmp)
580 by Martin Pool
- Use explicit lock methods on a branch, rather than doing it
323
        rev_tmp.seek(0)
1393.2.3 by John Arbash Meinel
Fixing typos, updating stores, getting tests to pass.
324
        self.branch.revision_store.add(rev_tmp, self.rev_id)
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
325
        if self.config.signature_needed():
326
            self.branch.sign_revision(self.rev_id, gpg.GPGStrategy(self.config))
1189 by Martin Pool
- BROKEN: partial support for commit into weave
327
        mutter('new revision_id is {%s}', self.rev_id)
328
329
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
330
        """Remove deleted files from the working inventories.
331
332
        This is done prior to taking the working inventory as the
333
        basis for the new committed inventory.
334
335
        This returns true if any files
336
        *that existed in the basis inventory* were deleted.
337
        Files that were added and deleted
338
        in the working copy don't matter.
339
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
340
        specific = self.specific_files
341
        deleted_ids = []
342
        for path, ie in self.work_inv.iter_entries():
343
            if specific and not is_inside_any(specific, path):
344
                continue
345
            if not self.work_tree.has_filename(path):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
346
                self.reporter.missing(path)
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
347
                deleted_ids.append((path, ie.file_id))
1254 by Martin Pool
- fix handling of selective commit with deleted files
348
        if deleted_ids:
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
349
            deleted_ids.sort(reverse=True)
350
            for path, file_id in deleted_ids:
1248 by Martin Pool
- new weave based cleanup [broken]
351
                del self.work_inv[file_id]
1249 by Martin Pool
- improvements to weave commit [broken]
352
            self.branch._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
353
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
354
    def _store_snapshot(self):
355
        """Pass over inventory and record a snapshot.
1303 by Martin Pool
- commit updates entry_version
356
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
357
        Entries get a new revision when they are modified in 
358
        any way, which includes a merge with a new set of
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
359
        parents that have the same entry. 
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
360
        """
1303 by Martin Pool
- commit updates entry_version
361
        # XXX: Need to think more here about when the user has
362
        # made a specific decision on a particular value -- c.f.
363
        # mark-merge.  
364
        for path, ie in self.new_inv.iter_entries():
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
365
            previous_entries = ie.find_previous_heads(
366
                self.parent_invs, 
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
367
                self.weave_store.get_weave_or_empty(ie.file_id,
368
                    self.branch.get_transaction()))
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
369
            if ie.revision is None:
370
                change = ie.snapshot(self.rev_id, path, previous_entries,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
371
                                     self.work_tree, self.weave_store,
372
                                     self.branch.get_transaction())
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
373
            else:
374
                change = "unchanged"
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
375
            self.reporter.snapshot_change(change, path)
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
376
377
    def _populate_new_inv(self):
378
        """Build revision inventory.
379
380
        This creates a new empty inventory. Depending on
381
        which files are selected for commit, and what is present in the
382
        current tree, the new inventory is populated. inventory entries 
383
        which are candidates for modification have their revision set to
384
        None; inventory entries that are carried over untouched have their
385
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
386
        """
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
387
        mutter("Selecting files for commit with filter %s", self.specific_files)
388
        self.new_inv = Inventory()
1249 by Martin Pool
- improvements to weave commit [broken]
389
        for path, new_ie in self.work_inv.iter_entries():
390
            file_id = new_ie.file_id
391
            mutter('check %s {%s}', path, new_ie.file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
392
            if self.specific_files:
393
                if not is_inside_any(self.specific_files, path):
1249 by Martin Pool
- improvements to weave commit [broken]
394
                    mutter('%s not selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
395
                    self._carry_entry(file_id)
1249 by Martin Pool
- improvements to weave commit [broken]
396
                    continue
1416 by Robert Collins
when committing a specific file, include all its parents
397
                else:
398
                    # this is selected, ensure its parents are too.
399
                    parent_id = new_ie.parent_id
400
                    while parent_id != ROOT_ID:
401
                        if not self.new_inv.has_id(parent_id):
402
                            ie = self._select_entry(self.work_inv[parent_id])
403
                            mutter('%s selected for commit because of %s',
404
                                   self.new_inv.id2path(parent_id), path)
405
406
                        ie = self.new_inv[parent_id]
407
                        if ie.revision is not None:
408
                            ie.revision = None
409
                            mutter('%s selected for commit because of %s',
410
                                   self.new_inv.id2path(parent_id), path)
411
                        parent_id = ie.parent_id
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
412
            mutter('%s selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
413
            self._select_entry(new_ie)
414
415
    def _select_entry(self, new_ie):
416
        """Make new_ie be considered for committing."""
417
        ie = new_ie.copy()
418
        ie.revision = None
419
        self.new_inv.add(ie)
420
        return ie
421
422
    def _carry_entry(self, file_id):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
423
        """Carry the file unchanged from the basis revision."""
1249 by Martin Pool
- improvements to weave commit [broken]
424
        if self.basis_inv.has_id(file_id):
425
            self.new_inv.add(self.basis_inv[file_id].copy())
1248 by Martin Pool
- new weave based cleanup [broken]
426
427
    def _report_deletes(self):
428
        for file_id in self.basis_inv:
429
            if file_id not in self.new_inv:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
430
                self.reporter.deleted(self.basis_inv.id2path(file_id))
1248 by Martin Pool
- new weave based cleanup [broken]
431
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
432
def _gen_revision_id(config, when):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
433
    """Return new revision-id."""
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
434
    s = '%s-%s-' % (config.user_email(), compact_date(when))
1189 by Martin Pool
- BROKEN: partial support for commit into weave
435
    s += hexlify(rand_bytes(8))
436
    return s