~bzr-pqm/bzr/bzr.dev

485 by Martin Pool
- move commit code into its own module
1
# Copyright (C) 2005 Canonical Ltd
1248 by Martin Pool
- new weave based cleanup [broken]
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
47
# This code requires all merge parents to be present in the branch.
48
# We could relax this but for the sake of simplicity the constraint is
49
# here for now.  It's not totally clear to me how we'd know which file
50
# need new text versions if some parents are absent.  -- mbp 20050915
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1339 by Martin Pool
- doc
52
# TODO: Rather than mashing together the ancestry and storing it back,
53
# perhaps the weave should have single method which does it all in one
54
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
55
1341 by Martin Pool
- doc
56
# TODO: Perhaps give a warning if one of the revisions marked as
57
# merged is already in the ancestry, and then don't record it as a
58
# distinct parent.
59
1343 by Martin Pool
- fix up test for merge of trees
60
# TODO: If the file is newly merged but unchanged from the version it
61
# merges from, then it should still be reported as newly added
62
# relative to the basis revision.
63
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
64
1189 by Martin Pool
- BROKEN: partial support for commit into weave
65
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
66
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
67
import sys
1188 by Martin Pool
- clean up imports in commit code
68
import time
1248 by Martin Pool
- new weave based cleanup [broken]
69
import pdb
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
70
1188 by Martin Pool
- clean up imports in commit code
71
from binascii import hexlify
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
72
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
73
74
from bzrlib.osutils import (local_time_offset, username,
75
                            rand_bytes, compact_date, user_email,
76
                            kind_marker, is_inside_any, quotefn,
1248 by Martin Pool
- new weave based cleanup [broken]
77
                            sha_string, sha_strings, sha_file, isdir, isfile,
78
                            split_lines)
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
79
from bzrlib.branch import gen_file_id
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
80
from bzrlib.errors import (BzrError, PointlessCommit,
81
                           HistoryMissing,
82
                           )
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
83
from bzrlib.revision import Revision
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
84
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
85
from bzrlib.xml5 import serializer_v5
1188 by Martin Pool
- clean up imports in commit code
86
from bzrlib.inventory import Inventory
1189 by Martin Pool
- BROKEN: partial support for commit into weave
87
from bzrlib.weave import Weave
88
from bzrlib.weavefile import read_weave, write_weave_v5
89
from bzrlib.atomicfile import AtomicFile
90
91
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
92
def commit(*args, **kwargs):
93
    """Commit a new revision to a branch.
94
95
    Function-style interface for convenience of old callers.
96
97
    New code should use the Commit class instead.
98
    """
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
99
    ## XXX: Remove this in favor of Branch.commit?
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
100
    Commit().commit(*args, **kwargs)
101
102
1189 by Martin Pool
- BROKEN: partial support for commit into weave
103
class NullCommitReporter(object):
104
    """I report on progress of a commit."""
105
    def added(self, path):
106
        pass
107
108
    def removed(self, path):
109
        pass
110
111
    def renamed(self, old_path, new_path):
112
        pass
113
114
115
class ReportCommitToLog(NullCommitReporter):
116
    def added(self, path):
117
        note('added %s', path)
118
119
    def removed(self, path):
120
        note('removed %s', path)
121
122
    def renamed(self, old_path, new_path):
123
        note('renamed %s => %s', old_path, new_path)
124
125
126
class Commit(object):
127
    """Task of committing a new revision.
128
129
    This is a MethodObject: it accumulates state as the commit is
130
    prepared, and then it is discarded.  It doesn't represent
131
    historical revisions, just the act of recording a new one.
132
133
            missing_ids
134
            Modified to hold a list of files that have been deleted from
135
            the working directory; these should be removed from the
136
            working inventory.
485 by Martin Pool
- move commit code into its own module
137
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
138
    def __init__(self,
139
                 reporter=None):
140
        if reporter is not None:
141
            self.reporter = reporter
142
        else:
143
            self.reporter = NullCommitReporter()
144
145
        
146
    def commit(self,
147
               branch, message,
148
               timestamp=None,
149
               timezone=None,
150
               committer=None,
151
               specific_files=None,
152
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
153
               allow_pointless=True,
154
               verbose=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
155
        """Commit working copy as a new revision.
156
157
        timestamp -- if not None, seconds-since-epoch for a
158
             postdated/predated commit.
159
1253 by Martin Pool
- test that pointless commits are trapped
160
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
161
1253 by Martin Pool
- test that pointless commits are trapped
162
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
163
            Useful for test or import commands that need to tightly
164
            control what revisions are assigned.  If you duplicate
165
            a revision id that exists elsewhere it is your own fault.
166
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
167
168
        allow_pointless -- If true (default), commit even if nothing
169
            has changed and no merges are recorded.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
171
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
172
173
        self.branch = branch
1248 by Martin Pool
- new weave based cleanup [broken]
174
        self.weave_store = branch.weave_store
1189 by Martin Pool
- BROKEN: partial support for commit into weave
175
        self.rev_id = rev_id
176
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
177
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
178
179
        if timestamp is None:
180
            self.timestamp = time.time()
181
        else:
182
            self.timestamp = long(timestamp)
183
            
1248 by Martin Pool
- new weave based cleanup [broken]
184
        if rev_id is None:
185
            self.rev_id = _gen_revision_id(self.branch, self.timestamp)
186
        else:
187
            self.rev_id = rev_id
188
1189 by Martin Pool
- BROKEN: partial support for commit into weave
189
        if committer is None:
190
            self.committer = username(self.branch)
191
        else:
192
            assert isinstance(committer, basestring), type(committer)
193
            self.committer = committer
194
195
        if timezone is None:
196
            self.timezone = local_time_offset()
197
        else:
198
            self.timezone = int(timezone)
199
200
        assert isinstance(message, basestring), type(message)
201
        self.message = message
1390 by Robert Collins
pair programming worx... merge integration and weave
202
        self._escape_commit_message()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
203
1245 by Martin Pool
doc
204
        self.branch.lock_write()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
205
        try:
206
            self.work_tree = self.branch.working_tree()
207
            self.work_inv = self.work_tree.inventory
208
            self.basis_tree = self.branch.basis_tree()
209
            self.basis_inv = self.basis_tree.inventory
210
1223 by Martin Pool
- store inventories in weave
211
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
212
            if len(self.parents) > 1 and self.specific_files:
213
                raise NotImplementedError('selected-file commit of merges is not supported yet')
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
214
            self._check_parents_present()
215
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
216
            self._remove_deleted()
1249 by Martin Pool
- improvements to weave commit [broken]
217
            self.new_inv = Inventory()
1301 by Martin Pool
- more docs in commit code
218
            self._store_entries()
1248 by Martin Pool
- new weave based cleanup [broken]
219
            self._report_deletes()
1305 by Martin Pool
- rename entry_version to name_version
220
            self._set_name_versions()
1245 by Martin Pool
doc
221
1248 by Martin Pool
- new weave based cleanup [broken]
222
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
223
                    or len(self.parents) > 1
1249 by Martin Pool
- improvements to weave commit [broken]
224
                    or self.new_inv != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
225
                raise PointlessCommit()
226
227
            self._record_inventory()
1225 by Martin Pool
- branch now tracks ancestry - all merged revisions
228
            self._record_ancestry()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
229
            self._make_revision()
1250 by Martin Pool
typo
230
            note('committed r%d {%s}', (self.branch.revno() + 1),
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
231
                 self.rev_id)
232
            self.branch.append_revision(self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
233
            self.branch.set_pending_merges([])
234
        finally:
235
            self.branch.unlock()
236
237
1245 by Martin Pool
doc
238
1189 by Martin Pool
- BROKEN: partial support for commit into weave
239
    def _record_inventory(self):
1223 by Martin Pool
- store inventories in weave
240
        """Store the inventory for the new revision."""
1248 by Martin Pool
- new weave based cleanup [broken]
241
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
242
        self.inv_sha1 = sha_string(inv_text)
1390 by Robert Collins
pair programming worx... merge integration and weave
243
        s = self.branch.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
244
        s.add_text('inventory', self.rev_id,
1390 by Robert Collins
pair programming worx... merge integration and weave
245
                   split_lines(inv_text), self.parents)
1223 by Martin Pool
- store inventories in weave
246
1390 by Robert Collins
pair programming worx... merge integration and weave
247
    def _escape_commit_message(self):
248
        """Replace xml-incompatible control characters."""
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
249
        # Python strings can include characters that can't be
250
        # represented in well-formed XML; escape characters that
251
        # aren't listed in the XML specification
252
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
253
        if isinstance(self.message, unicode):
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
254
            char_pattern = u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]'
255
        else:
256
            # Use a regular 'str' as pattern to avoid having re.subn
257
            # return 'unicode' results.
258
            char_pattern = '[^x09\x0A\x0D\x20-\xFF]'
1390 by Robert Collins
pair programming worx... merge integration and weave
259
        self.message, escape_count = re.subn(
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
260
            char_pattern,
261
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
262
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
263
        if escape_count:
264
            note("replaced %d control characters in message", escape_count)
1223 by Martin Pool
- store inventories in weave
265
1225 by Martin Pool
- branch now tracks ancestry - all merged revisions
266
    def _record_ancestry(self):
1270 by Martin Pool
- fix recording of merged ancestry lines
267
        """Append merged revision ancestry to the ancestry file.
268
269
        This should be the merged ancestry of all parents, plus the
270
        new revision id."""
1390 by Robert Collins
pair programming worx... merge integration and weave
271
        s = self.branch.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
272
        w = s.get_weave_or_empty('ancestry')
1333 by Martin Pool
- split out merge-ancestry stuff where it can be reused
273
        lines = self._make_ancestry(w)
1269 by Martin Pool
- some weave operations automatically look up symbolic names if supplied
274
        w.add(self.rev_id, self.parents, lines)
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
275
        s.put_weave('ancestry', w)
1225 by Martin Pool
- branch now tracks ancestry - all merged revisions
276
277
1333 by Martin Pool
- split out merge-ancestry stuff where it can be reused
278
    def _make_ancestry(self, ancestry_weave):
1270 by Martin Pool
- fix recording of merged ancestry lines
279
        """Return merged ancestry lines.
280
281
        The lines are revision-ids followed by newlines."""
1333 by Martin Pool
- split out merge-ancestry stuff where it can be reused
282
        parent_ancestries = [ancestry_weave.get(p) for p in self.parents]
283
        new_lines = merge_ancestry_lines(self.rev_id, parent_ancestries)
284
        mutter('merged ancestry of {%s}:\n%s', self.rev_id, ''.join(new_lines))
285
        return new_lines
1270 by Martin Pool
- fix recording of merged ancestry lines
286
287
1223 by Martin Pool
- store inventories in weave
288
    def _gather_parents(self):
289
        pending_merges = self.branch.pending_merges()
290
        self.parents = []
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
291
        self.parent_trees = []
1241 by Martin Pool
- rename last_patch to last_revision
292
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
293
        if precursor_id:
294
            self.parents.append(precursor_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
295
            self.parent_trees.append(self.basis_tree)
1223 by Martin Pool
- store inventories in weave
296
        self.parents += pending_merges
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
297
        self.parent_trees.extend(map(self.branch.revision_tree, pending_merges))
298
299
300
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
301
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
302
            mutter('commit parent revision {%s}', parent_id)
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
303
            if not self.branch.has_revision(parent_id):
304
                warning("can't commit a merge from an absent parent")
305
                raise HistoryMissing(self.branch, 'revision', parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
306
307
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
308
    def _make_revision(self):
309
        """Record a new revision object for this commit."""
310
        self.rev = Revision(timestamp=self.timestamp,
311
                            timezone=self.timezone,
312
                            committer=self.committer,
313
                            message=self.message,
314
                            inventory_sha1=self.inv_sha1,
315
                            revision_id=self.rev_id)
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
316
        self.rev.parent_ids = self.parents
1248 by Martin Pool
- new weave based cleanup [broken]
317
        rev_tmp = StringIO()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
318
        serializer_v5.write_revision(self.rev, rev_tmp)
580 by Martin Pool
- Use explicit lock methods on a branch, rather than doing it
319
        rev_tmp.seek(0)
1393.2.3 by John Arbash Meinel
Fixing typos, updating stores, getting tests to pass.
320
        self.branch.revision_store.add(rev_tmp, self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
321
        mutter('new revision_id is {%s}', self.rev_id)
322
323
324
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
325
        """Remove deleted files from the working inventories.
326
327
        This is done prior to taking the working inventory as the
328
        basis for the new committed inventory.
329
330
        This returns true if any files
331
        *that existed in the basis inventory* were deleted.
332
        Files that were added and deleted
333
        in the working copy don't matter.
334
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
335
        specific = self.specific_files
336
        deleted_ids = []
337
        for path, ie in self.work_inv.iter_entries():
338
            if specific and not is_inside_any(specific, path):
339
                continue
340
            if not self.work_tree.has_filename(path):
341
                note('missing %s', path)
342
                deleted_ids.append(ie.file_id)
343
        if deleted_ids:
344
            for file_id in deleted_ids:
1393.1.21 by Martin Pool
- merge merge and export fixes from aaron
345
                if file_id in self.work_inv:
346
                    del self.work_inv[file_id]
1249 by Martin Pool
- improvements to weave commit [broken]
347
            self.branch._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
348
349
350
    def _find_file_parents(self, file_id):
351
        """Return the text versions and hashes for all file parents.
352
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
353
        Returned as a map from text version to inventory entry.
1248 by Martin Pool
- new weave based cleanup [broken]
354
355
        This is a set containing the file versions in all parents
356
        revisions containing the file.  If the file is new, the set
357
        will be empty."""
358
        r = {}
359
        for tree in self.parent_trees:
360
            if file_id in tree.inventory:
361
                ie = tree.inventory[file_id]
362
                assert ie.kind == 'file'
363
                assert ie.file_id == file_id
364
                if ie.text_version in r:
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
365
                    assert r[ie.text_version] == ie
1248 by Martin Pool
- new weave based cleanup [broken]
366
                else:
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
367
                    r[ie.text_version] = ie
1303 by Martin Pool
- commit updates entry_version
368
        return r
369
370
1305 by Martin Pool
- rename entry_version to name_version
371
    def _set_name_versions(self):
1303 by Martin Pool
- commit updates entry_version
372
        """Pass over inventory and mark new entry version as needed.
373
374
        Files get a new name version when they are new, have a
375
        different parent, or a different name from in the
376
        basis inventory, or if the file is in a different place
377
        to any of the parents."""
378
        # XXX: Need to think more here about when the user has
379
        # made a specific decision on a particular value -- c.f.
380
        # mark-merge.  
381
        for path, ie in self.new_inv.iter_entries():
382
            old_version = None
383
            file_id = ie.file_id
384
            for parent_tree in self.parent_trees:
385
                parent_inv = parent_tree.inventory
386
                if file_id not in parent_inv:
387
                    continue
388
                parent_ie = parent_inv[file_id]
389
                if parent_ie.parent_id != ie.parent_id:
390
                    old_version = None
391
                    break
392
                elif parent_ie.name != ie.name:
393
                    old_version = None
394
                    break
395
                elif old_version is None:
1305 by Martin Pool
- rename entry_version to name_version
396
                    old_version = parent_ie.name_version
397
                elif old_version != parent_ie.name_version:
1303 by Martin Pool
- commit updates entry_version
398
                    old_version = None
399
                    break
400
                else:
401
                    pass                # so far so good
402
            if old_version is None:
1305 by Martin Pool
- rename entry_version to name_version
403
                mutter('new name_version for {%s}', file_id)
404
                ie.name_version = self.rev_id
1303 by Martin Pool
- commit updates entry_version
405
            else:
1305 by Martin Pool
- rename entry_version to name_version
406
                mutter('name_version for {%s} inherited as {%s}',
1303 by Martin Pool
- commit updates entry_version
407
                       file_id, old_version)
1305 by Martin Pool
- rename entry_version to name_version
408
                ie.name_version = old_version
1189 by Martin Pool
- BROKEN: partial support for commit into weave
409
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
410
1301 by Martin Pool
- more docs in commit code
411
    def _store_entries(self):
412
        """Build revision inventory and store modified files.
413
414
        This is called with new_inv a new empty inventory.  Depending on
415
        which files are selected for commit, and which ones have
416
        been modified or merged, new inventory entries are built
417
        based on the working and parent inventories.
418
419
        As a side-effect this stores new text versions for committed
420
        files with text changes or merges.
421
422
        Each entry can have one of several things happen:
423
424
        carry_file -- carried from the previous version (if not
425
            selected for commit)
426
427
        commit_nonfile -- no text to worry about
428
429
        commit_old_text -- same text, may have moved
430
431
        commit_file -- new text version
432
        """
1249 by Martin Pool
- improvements to weave commit [broken]
433
        for path, new_ie in self.work_inv.iter_entries():
434
            file_id = new_ie.file_id
435
            mutter('check %s {%s}', path, new_ie.file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
436
            if self.specific_files:
437
                if not is_inside_any(self.specific_files, path):
1249 by Martin Pool
- improvements to weave commit [broken]
438
                    mutter('%s not selected for commit', path)
439
                    self._carry_file(file_id)
440
                    continue
1248 by Martin Pool
- new weave based cleanup [broken]
441
            if new_ie.kind != 'file':
1249 by Martin Pool
- improvements to weave commit [broken]
442
                self._commit_nonfile(file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
443
                continue
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
444
            
1248 by Martin Pool
- new weave based cleanup [broken]
445
            file_parents = self._find_file_parents(file_id)
1343 by Martin Pool
- fix up test for merge of trees
446
            mutter('parents of %s are %r', path, file_parents)
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
447
            if len(file_parents) == 1:
448
                parent_ie = file_parents.values()[0]
449
                wc_sha1 = self.work_tree.get_file_sha1(file_id)
450
                if parent_ie.text_sha1 == wc_sha1:
451
                    # text not changed or merged
452
                    self._commit_old_text(file_id, parent_ie)
453
                    continue
1249 by Martin Pool
- improvements to weave commit [broken]
454
            # file is either new, or a file merge; need to record
455
            # a new version
456
            if len(file_parents) > 1:
457
                note('merged %s', path)
458
            elif len(file_parents) == 0:
459
                note('added %s', path)
1207 by Martin Pool
- fix bugs in adding files in subdirectories
460
            else:
1249 by Martin Pool
- improvements to weave commit [broken]
461
                note('modified %s', path)
462
            self._commit_file(new_ie, file_id, file_parents)
463
464
465
    def _commit_nonfile(self, file_id):
466
        self.new_inv.add(self.work_inv[file_id].copy())
467
468
469
    def _carry_file(self, file_id):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
470
        """Carry the file unchanged from the basis revision."""
1249 by Martin Pool
- improvements to weave commit [broken]
471
        if self.basis_inv.has_id(file_id):
472
            self.new_inv.add(self.basis_inv[file_id].copy())
1248 by Martin Pool
- new weave based cleanup [broken]
473
474
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
475
    def _commit_old_text(self, file_id, parent_ie):
476
        """Keep the same text as last time, but possibly a different name."""
477
        ie = self.work_inv[file_id].copy()
478
        ie.text_version = parent_ie.text_version
479
        ie.text_size = parent_ie.text_size
480
        ie.text_sha1 = parent_ie.text_sha1
481
        self.new_inv.add(ie)
482
483
1248 by Martin Pool
- new weave based cleanup [broken]
484
    def _report_deletes(self):
485
        for file_id in self.basis_inv:
486
            if file_id not in self.new_inv:
487
                note('deleted %s', self.basis_inv.id2path(file_id))
488
489
1249 by Martin Pool
- improvements to weave commit [broken]
490
    def _commit_file(self, new_ie, file_id, file_parents):                    
1248 by Martin Pool
- new weave based cleanup [broken]
491
        mutter('store new text for {%s} in revision {%s}',
492
               file_id, self.rev_id)
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
493
        new_lines = self.work_tree.get_file(file_id).readlines()
1199 by Martin Pool
- weave commit records per-file ancestors
494
        self._add_text_to_weave(file_id, new_lines, file_parents)
1249 by Martin Pool
- improvements to weave commit [broken]
495
        new_ie.text_version = self.rev_id
496
        new_ie.text_sha1 = sha_strings(new_lines)
497
        new_ie.text_size = sum(map(len, new_lines))
498
        self.new_inv.add(new_ie)
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
499
500
1199 by Martin Pool
- weave commit records per-file ancestors
501
    def _add_text_to_weave(self, file_id, new_lines, parents):
1248 by Martin Pool
- new weave based cleanup [broken]
502
        self.weave_store.add_text(file_id, self.rev_id, new_lines, parents)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
503
504
505
def _gen_revision_id(branch, when):
506
    """Return new revision-id."""
507
    s = '%s-%s-' % (user_email(branch), compact_date(when))
508
    s += hexlify(rand_bytes(8))
509
    return s
633 by Martin Pool
- Show added/renamed/modified messages from commit for non-file
510
1248 by Martin Pool
- new weave based cleanup [broken]
511
512
513
    
1333 by Martin Pool
- split out merge-ancestry stuff where it can be reused
514
def merge_ancestry_lines(rev_id, ancestries):
515
    """Return merged ancestry lines.
516
517
    rev_id -- id of the new revision
518
    
519
    ancestries -- a sequence of ancestries for parent revisions,
520
        as newline-terminated line lists.
521
    """
522
    if len(ancestries) == 0:
523
        return [rev_id + '\n']
524
    seen = set(ancestries[0])
525
    ancs = ancestries[0][:]    
526
    for parent_ancestry in ancestries[1:]:
527
        for line in parent_ancestry:
528
            assert line[-1] == '\n'
529
            if line not in seen:
530
                ancs.append(line)
531
                seen.add(line)
532
    r = rev_id + '\n'
533
    assert r not in seen
534
    ancs.append(r)
535
    return ancs