~bzr-pqm/bzr/bzr.dev

485 by Martin Pool
- move commit code into its own module
1
# Copyright (C) 2005 Canonical Ltd
1248 by Martin Pool
- new weave based cleanup [broken]
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1339 by Martin Pool
- doc
47
# TODO: Rather than mashing together the ancestry and storing it back,
48
# perhaps the weave should have single method which does it all in one
49
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
50
1341 by Martin Pool
- doc
51
# TODO: Perhaps give a warning if one of the revisions marked as
52
# merged is already in the ancestry, and then don't record it as a
53
# distinct parent.
54
1343 by Martin Pool
- fix up test for merge of trees
55
# TODO: If the file is newly merged but unchanged from the version it
56
# merges from, then it should still be reported as newly added
57
# relative to the basis revision.
58
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
59
1189 by Martin Pool
- BROKEN: partial support for commit into weave
60
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
61
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
62
import sys
1188 by Martin Pool
- clean up imports in commit code
63
import time
1248 by Martin Pool
- new weave based cleanup [broken]
64
import pdb
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
65
1188 by Martin Pool
- clean up imports in commit code
66
from binascii import hexlify
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
67
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
68
69
from bzrlib.osutils import (local_time_offset, username,
70
                            rand_bytes, compact_date, user_email,
71
                            kind_marker, is_inside_any, quotefn,
1248 by Martin Pool
- new weave based cleanup [broken]
72
                            sha_string, sha_strings, sha_file, isdir, isfile,
73
                            split_lines)
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
74
from bzrlib.branch import gen_file_id
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
75
from bzrlib.errors import (BzrError, PointlessCommit,
76
                           HistoryMissing,
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
77
                           ConflictsInTree
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
78
                           )
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
79
from bzrlib.revision import Revision
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
80
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
81
from bzrlib.xml5 import serializer_v5
1416 by Robert Collins
when committing a specific file, include all its parents
82
from bzrlib.inventory import Inventory, ROOT_ID
1189 by Martin Pool
- BROKEN: partial support for commit into weave
83
from bzrlib.weave import Weave
84
from bzrlib.weavefile import read_weave, write_weave_v5
85
from bzrlib.atomicfile import AtomicFile
86
87
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
88
def commit(*args, **kwargs):
89
    """Commit a new revision to a branch.
90
91
    Function-style interface for convenience of old callers.
92
93
    New code should use the Commit class instead.
94
    """
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
95
    ## XXX: Remove this in favor of Branch.commit?
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
96
    Commit().commit(*args, **kwargs)
97
98
1189 by Martin Pool
- BROKEN: partial support for commit into weave
99
class NullCommitReporter(object):
100
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
101
102
    def snapshot_change(self, change, path):
103
        pass
104
105
    def completed(self, revno, rev_id):
106
        pass
107
108
    def deleted(self, file_id):
109
        pass
110
111
    def escaped(self, escape_count, message):
112
        pass
113
114
    def missing(self, path):
115
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
116
117
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
118
119
    def snapshot_change(self, change, path):
120
        note("%s %s", change, path)
121
122
    def completed(self, revno, rev_id):
123
        note('committed r%d {%s}', revno, rev_id)
124
    
125
    def deleted(self, file_id):
126
        note('deleted %s', file_id)
127
128
    def escaped(self, escape_count, message):
129
        note("replaced %d control characters in message", escape_count)
130
131
    def missing(self, path):
132
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
133
134
class Commit(object):
135
    """Task of committing a new revision.
136
137
    This is a MethodObject: it accumulates state as the commit is
138
    prepared, and then it is discarded.  It doesn't represent
139
    historical revisions, just the act of recording a new one.
140
141
            missing_ids
142
            Modified to hold a list of files that have been deleted from
143
            the working directory; these should be removed from the
144
            working inventory.
485 by Martin Pool
- move commit code into its own module
145
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
146
    def __init__(self,
147
                 reporter=None):
148
        if reporter is not None:
149
            self.reporter = reporter
150
        else:
151
            self.reporter = NullCommitReporter()
152
153
        
154
    def commit(self,
155
               branch, message,
156
               timestamp=None,
157
               timezone=None,
158
               committer=None,
159
               specific_files=None,
160
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
161
               allow_pointless=True,
162
               verbose=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
163
        """Commit working copy as a new revision.
164
165
        timestamp -- if not None, seconds-since-epoch for a
166
             postdated/predated commit.
167
1253 by Martin Pool
- test that pointless commits are trapped
168
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
169
1253 by Martin Pool
- test that pointless commits are trapped
170
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
171
            Useful for test or import commands that need to tightly
172
            control what revisions are assigned.  If you duplicate
173
            a revision id that exists elsewhere it is your own fault.
174
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
175
176
        allow_pointless -- If true (default), commit even if nothing
177
            has changed and no merges are recorded.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
178
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
179
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
180
181
        self.branch = branch
1248 by Martin Pool
- new weave based cleanup [broken]
182
        self.weave_store = branch.weave_store
1189 by Martin Pool
- BROKEN: partial support for commit into weave
183
        self.rev_id = rev_id
184
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
185
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
186
187
        if timestamp is None:
188
            self.timestamp = time.time()
189
        else:
190
            self.timestamp = long(timestamp)
191
            
1248 by Martin Pool
- new weave based cleanup [broken]
192
        if rev_id is None:
193
            self.rev_id = _gen_revision_id(self.branch, self.timestamp)
194
        else:
195
            self.rev_id = rev_id
196
1189 by Martin Pool
- BROKEN: partial support for commit into weave
197
        if committer is None:
198
            self.committer = username(self.branch)
199
        else:
200
            assert isinstance(committer, basestring), type(committer)
201
            self.committer = committer
202
203
        if timezone is None:
204
            self.timezone = local_time_offset()
205
        else:
206
            self.timezone = int(timezone)
207
208
        assert isinstance(message, basestring), type(message)
209
        self.message = message
1390 by Robert Collins
pair programming worx... merge integration and weave
210
        self._escape_commit_message()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
211
1245 by Martin Pool
doc
212
        self.branch.lock_write()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
213
        try:
214
            self.work_tree = self.branch.working_tree()
215
            self.work_inv = self.work_tree.inventory
216
            self.basis_tree = self.branch.basis_tree()
217
            self.basis_inv = self.basis_tree.inventory
218
1223 by Martin Pool
- store inventories in weave
219
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
220
            if len(self.parents) > 1 and self.specific_files:
221
                raise NotImplementedError('selected-file commit of merges is not supported yet')
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
222
            self._check_parents_present()
223
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
224
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
225
            self._populate_new_inv()
226
            self._store_snapshot()
1248 by Martin Pool
- new weave based cleanup [broken]
227
            self._report_deletes()
1245 by Martin Pool
doc
228
1248 by Martin Pool
- new weave based cleanup [broken]
229
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
230
                    or len(self.parents) > 1
1249 by Martin Pool
- improvements to weave commit [broken]
231
                    or self.new_inv != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
232
                raise PointlessCommit()
233
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
234
            if len(list(self.work_tree.iter_conflicts()))>0:
235
                raise ConflictsInTree
236
1189 by Martin Pool
- BROKEN: partial support for commit into weave
237
            self._record_inventory()
238
            self._make_revision()
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
239
            self.reporter.completed(self.branch.revno()+1, self.rev_id)
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
240
            self.branch.append_revision(self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
241
            self.branch.set_pending_merges([])
242
        finally:
243
            self.branch.unlock()
244
245
    def _record_inventory(self):
1223 by Martin Pool
- store inventories in weave
246
        """Store the inventory for the new revision."""
1248 by Martin Pool
- new weave based cleanup [broken]
247
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
248
        self.inv_sha1 = sha_string(inv_text)
1390 by Robert Collins
pair programming worx... merge integration and weave
249
        s = self.branch.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
250
        s.add_text('inventory', self.rev_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
251
                   split_lines(inv_text), self.present_parents,
252
                   self.branch.get_transaction())
1223 by Martin Pool
- store inventories in weave
253
1390 by Robert Collins
pair programming worx... merge integration and weave
254
    def _escape_commit_message(self):
255
        """Replace xml-incompatible control characters."""
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
256
        # Python strings can include characters that can't be
257
        # represented in well-formed XML; escape characters that
258
        # aren't listed in the XML specification
259
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
260
        if isinstance(self.message, unicode):
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
261
            char_pattern = u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]'
262
        else:
263
            # Use a regular 'str' as pattern to avoid having re.subn
264
            # return 'unicode' results.
265
            char_pattern = '[^x09\x0A\x0D\x20-\xFF]'
1390 by Robert Collins
pair programming worx... merge integration and weave
266
        self.message, escape_count = re.subn(
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
267
            char_pattern,
268
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
269
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
270
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
271
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
272
273
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
274
        """Record the parents of a merge for merge detection."""
1223 by Martin Pool
- store inventories in weave
275
        pending_merges = self.branch.pending_merges()
276
        self.parents = []
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
277
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
278
        self.present_parents = []
1241 by Martin Pool
- rename last_patch to last_revision
279
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
280
        if precursor_id:
281
            self.parents.append(precursor_id)
282
        self.parents += pending_merges
1092.2.25 by Robert Collins
support ghosts in commits
283
        for revision in self.parents:
284
            if self.branch.has_revision(revision):
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
285
                self.parent_invs.append(self.branch.get_inventory(revision))
1092.2.25 by Robert Collins
support ghosts in commits
286
                self.present_parents.append(revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
287
288
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
289
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
290
            mutter('commit parent revision {%s}', parent_id)
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
291
            if not self.branch.has_revision(parent_id):
1092.2.25 by Robert Collins
support ghosts in commits
292
                if parent_id == self.branch.last_revision():
1185.12.9 by Aaron Bentley
Removed crude language
293
                    warning("parent is missing %r", parent_id)
1092.2.25 by Robert Collins
support ghosts in commits
294
                    raise HistoryMissing(self.branch, 'revision', parent_id)
295
                else:
296
                    mutter("commit will ghost revision %r", parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
297
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
298
    def _make_revision(self):
299
        """Record a new revision object for this commit."""
300
        self.rev = Revision(timestamp=self.timestamp,
301
                            timezone=self.timezone,
302
                            committer=self.committer,
303
                            message=self.message,
304
                            inventory_sha1=self.inv_sha1,
305
                            revision_id=self.rev_id)
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
306
        self.rev.parent_ids = self.parents
1248 by Martin Pool
- new weave based cleanup [broken]
307
        rev_tmp = StringIO()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
308
        serializer_v5.write_revision(self.rev, rev_tmp)
580 by Martin Pool
- Use explicit lock methods on a branch, rather than doing it
309
        rev_tmp.seek(0)
1393.2.3 by John Arbash Meinel
Fixing typos, updating stores, getting tests to pass.
310
        self.branch.revision_store.add(rev_tmp, self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
311
        mutter('new revision_id is {%s}', self.rev_id)
312
313
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
314
        """Remove deleted files from the working inventories.
315
316
        This is done prior to taking the working inventory as the
317
        basis for the new committed inventory.
318
319
        This returns true if any files
320
        *that existed in the basis inventory* were deleted.
321
        Files that were added and deleted
322
        in the working copy don't matter.
323
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
324
        specific = self.specific_files
325
        deleted_ids = []
326
        for path, ie in self.work_inv.iter_entries():
327
            if specific and not is_inside_any(specific, path):
328
                continue
329
            if not self.work_tree.has_filename(path):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
330
                self.reporter.missing(path)
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
331
                deleted_ids.append((path, ie.file_id))
1254 by Martin Pool
- fix handling of selective commit with deleted files
332
        if deleted_ids:
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
333
            deleted_ids.sort(reverse=True)
334
            for path, file_id in deleted_ids:
1248 by Martin Pool
- new weave based cleanup [broken]
335
                del self.work_inv[file_id]
1249 by Martin Pool
- improvements to weave commit [broken]
336
            self.branch._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
337
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
338
    def _store_snapshot(self):
339
        """Pass over inventory and record a snapshot.
1303 by Martin Pool
- commit updates entry_version
340
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
341
        Entries get a new revision when they are modified in 
342
        any way, which includes a merge with a new set of
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
343
        parents that have the same entry. 
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
344
        """
1303 by Martin Pool
- commit updates entry_version
345
        # XXX: Need to think more here about when the user has
346
        # made a specific decision on a particular value -- c.f.
347
        # mark-merge.  
348
        for path, ie in self.new_inv.iter_entries():
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
349
            previous_entries = ie.find_previous_heads(
350
                self.parent_invs, 
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
351
                self.weave_store.get_weave_or_empty(ie.file_id,
352
                    self.branch.get_transaction()))
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
353
            if ie.revision is None:
354
                change = ie.snapshot(self.rev_id, path, previous_entries,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
355
                                     self.work_tree, self.weave_store,
356
                                     self.branch.get_transaction())
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
357
            else:
358
                change = "unchanged"
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
359
            self.reporter.snapshot_change(change, path)
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
360
361
    def _populate_new_inv(self):
362
        """Build revision inventory.
363
364
        This creates a new empty inventory. Depending on
365
        which files are selected for commit, and what is present in the
366
        current tree, the new inventory is populated. inventory entries 
367
        which are candidates for modification have their revision set to
368
        None; inventory entries that are carried over untouched have their
369
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
370
        """
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
371
        mutter("Selecting files for commit with filter %s", self.specific_files)
372
        self.new_inv = Inventory()
1249 by Martin Pool
- improvements to weave commit [broken]
373
        for path, new_ie in self.work_inv.iter_entries():
374
            file_id = new_ie.file_id
375
            mutter('check %s {%s}', path, new_ie.file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
376
            if self.specific_files:
377
                if not is_inside_any(self.specific_files, path):
1249 by Martin Pool
- improvements to weave commit [broken]
378
                    mutter('%s not selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
379
                    self._carry_entry(file_id)
1249 by Martin Pool
- improvements to weave commit [broken]
380
                    continue
1416 by Robert Collins
when committing a specific file, include all its parents
381
                else:
382
                    # this is selected, ensure its parents are too.
383
                    parent_id = new_ie.parent_id
384
                    while parent_id != ROOT_ID:
385
                        if not self.new_inv.has_id(parent_id):
386
                            ie = self._select_entry(self.work_inv[parent_id])
387
                            mutter('%s selected for commit because of %s',
388
                                   self.new_inv.id2path(parent_id), path)
389
390
                        ie = self.new_inv[parent_id]
391
                        if ie.revision is not None:
392
                            ie.revision = None
393
                            mutter('%s selected for commit because of %s',
394
                                   self.new_inv.id2path(parent_id), path)
395
                        parent_id = ie.parent_id
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
396
            mutter('%s selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
397
            self._select_entry(new_ie)
398
399
    def _select_entry(self, new_ie):
400
        """Make new_ie be considered for committing."""
401
        ie = new_ie.copy()
402
        ie.revision = None
403
        self.new_inv.add(ie)
404
        return ie
405
406
    def _carry_entry(self, file_id):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
407
        """Carry the file unchanged from the basis revision."""
1249 by Martin Pool
- improvements to weave commit [broken]
408
        if self.basis_inv.has_id(file_id):
409
            self.new_inv.add(self.basis_inv[file_id].copy())
1248 by Martin Pool
- new weave based cleanup [broken]
410
411
    def _report_deletes(self):
412
        for file_id in self.basis_inv:
413
            if file_id not in self.new_inv:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
414
                self.reporter.deleted(self.basis_inv.id2path(file_id))
1248 by Martin Pool
- new weave based cleanup [broken]
415
1189 by Martin Pool
- BROKEN: partial support for commit into weave
416
def _gen_revision_id(branch, when):
417
    """Return new revision-id."""
418
    s = '%s-%s-' % (user_email(branch), compact_date(when))
419
    s += hexlify(rand_bytes(8))
420
    return s